OSDN Git Service
TreeHugger Robot [Thu, 28 Jun 2018 18:24:19 +0000 (18:24 +0000)]
Merge "Multi-A2DP: Fix timing and codec measurement in metrics" into pi-dev
Hansong Zhang [Wed, 27 Jun 2018 22:23:07 +0000 (15:23 -0700)]
[automerger skipped] DO NOT MERGE AVRC: Copy browse.p_browse_data in btif_av_event_deep_copy am:
1d9a58768e am:
248fd6200b
am:
d2aca78317 -s ours
Change-Id: I3496b8ea2c661618d27087b94427423faa3ddd51
Hansong Zhang [Wed, 27 Jun 2018 22:19:49 +0000 (15:19 -0700)]
DO NOT MERGE AVRC: Copy browse.p_browse_data in btif_av_event_deep_copy am:
1d9a58768e
am:
248fd6200b
Change-Id: I786d844e462ea06f18083f4d47a2f6c786bfc466
Hansong Zhang [Wed, 27 Jun 2018 22:16:12 +0000 (15:16 -0700)]
DO NOT MERGE AVRC: Copy browse.p_browse_data in btif_av_event_deep_copy
am:
1d9a58768e
Change-Id: I7f9ca99de72d0e142210943163a6a3d4b1f61c1d
Jack He [Sat, 9 Jun 2018 03:13:23 +0000 (20:13 -0700)]
Multi-A2DP: Fix timing and codec measurement in metrics
* Copy BtifMediaStats and SchedulingStats when updating metrics
to avoid race conditions
* Do not log audio_duration_ms if session_end_us <= session_start_us
* Clear cached A2DP metrics when LogBluetoothSessionEnd() is called
* Log codec information along-side A2DP metrics
* Log whether A2DP offload is enabled along-side A2DP metrics
Multi-A2DP:
* Log LogBluetoothSessionStart at btif_a2dp_source_start_session_delayed
* Log LogBluetoothSessionEnd at btif_a2dp_source_end_session_delayed
Unit Test:
* Wrote A2DPSessionTwoUpdatesSeparatedbyEndTest that will fail if A2DP
metrics are not cleared when LogBluetoothSessionEnd is called
Bug:
109953464
Test: make, net_test_osi::BluetoothMetricsLoggerTest,
net_test_osi::BluetoothA2DPSessionMetricsTest
Change-Id: I6a311dce8035ce2e3f39773c260ea9eaef73e45b
Merged-In: I6a311dce8035ce2e3f39773c260ea9eaef73e45b
(cherry picked from commit
feeaf5f8cf31394d6f737543f1d0572ca91d487c)
TreeHugger Robot [Wed, 27 Jun 2018 21:02:09 +0000 (21:02 +0000)]
Merge "Add missing btif_a2dp_audio_interface_end_session() call during disconnect" into pi-dev
Pavlin Radoslavov [Thu, 21 Jun 2018 01:28:33 +0000 (18:28 -0700)]
If command_timed_out() is triggered don't get blocked by a deadlock
If command_timed_out() is triggered and we cannot acquire the
commands_pending_response_mutex to print the debug info, then proceed
with the rest of the operations until the process aborts.
Similarly, if startup_timer_expired() is triggered and we are blocked
by a deadlock, just abort() because there is no way to recover.
Bug:
110441099
Test: Code compilation
Change-Id: I367332bbbd9c1d887bd2bc829b9f617114fc96fc
Merged-In: I367332bbbd9c1d887bd2bc829b9f617114fc96fc
(cherry picked from commit
2838b32ce424a6f8c8025175aaf9b6fd8cab313f)
Pavlin Radoslavov [Mon, 25 Jun 2018 23:34:17 +0000 (16:34 -0700)]
Add missing btif_a2dp_audio_interface_end_session() call during disconnect
Update the logic inside btif_a2dp_source_end_session_delayed() to make
sure that btif_a2dp_audio_interface_end_session() is called when device
is disconnected.
Also, update existing log messages to make it easier to identify similar
issues in the future.
Bug:
110176990
Test: Manual: Pair with two headsets, start/suspend/stop/switch active
device
Change-Id: I248e5c3e2c4cf0ad820cef34ba859e9adc8dec8e
Merged-In: I248e5c3e2c4cf0ad820cef34ba859e9adc8dec8e
(cherry picked from commit
f40b85b46c873530f4e6c01c81be8e3b0ff486db)
Pavlin Radoslavov [Wed, 20 Jun 2018 02:10:43 +0000 (19:10 -0700)]
Gracefully handle A2DP hardware offload Audio HAL service death
Register for Audio HAL service death, and restart the Audio HAL session
if necessary.
Bug:
77926419
Test: Manual: stream Bluetooth audio and kill -9 the audioserver
Change-Id: I45e83aea0fb95301e6ceadee74661dd55f8c0f66
Merged-In: I45e83aea0fb95301e6ceadee74661dd55f8c0f66
(cherry picked from commit
5c80c8653a61780f8047413d5ad9f939a8a397f3)
Pavlin Radoslavov [Thu, 14 Jun 2018 23:27:54 +0000 (16:27 -0700)]
Correctly initialize A2DP Sink codecs if A2DP Source HW offload is enabled
This also fixes unit test failures if A2DP Source HW offload is enabled.
Bug:
110228602
Test: Failing unit tests now succeed
Change-Id: I36678738bfcfcce0f2e8a055f10c86cc6b3e682a
Merged-In: I36678738bfcfcce0f2e8a055f10c86cc6b3e682a
(cherry picked from commit
af66441fecd1b56c26d5c25866d6fc7677ec0c2a)
cheneyni [Mon, 11 Jun 2018 13:19:26 +0000 (21:19 +0800)]
Clear local suspending flag when the BTA_AV_STOP_EVT event received
The Stack would set the pending flag when received the Stop request but
did not clear it even state became Opened. This would cuase Stack
replied Suspended immediately to Audio HAL but kept peer at Started
state and failed to handle Start request again.
This change clears the local suspending flag when BTA_AV_STOP_EVT
received and also reset all pending status when becomes Opened so it
will take effect only when Stack is changing state from Started.
Bug:
110022304
Test: Manual: (1) Play A2DP music and switch codec
(2) Play A2DP music and change active device
Change-Id: I4b9aca33eb7eb6c40038e2082d23eb22e5830714
Merged-In: I4b9aca33eb7eb6c40038e2082d23eb22e5830714
(cherry picked from commit
e643d30249256461fd1c0a132b48c65e2eac18ba)
Hansong Zhang [Thu, 14 Jun 2018 00:33:23 +0000 (17:33 -0700)]
DO NOT MERGE AVRC: Copy browse.p_browse_data in btif_av_event_deep_copy
p_msg_src->browse.p_browse_data is not copied, but used after the
original pointer is freed
Bug:
109699112
Test: manual
Change-Id: I1d014eb9a8911da6913173a9b11218bf1c89e16e
TreeHugger Robot [Thu, 7 Jun 2018 15:08:47 +0000 (15:08 +0000)]
Merge "Don't reuse buffer when building response" into pi-dev
Ajay Panicker [Thu, 7 Jun 2018 05:28:11 +0000 (22:28 -0700)]
Merge changes from topic "am-
662f3e36-36cc-485d-824b-
f28c01eea384" into oc-dev am:
0cda123801 am:
427aebe54a
am:
20b2bc080e
Change-Id: I3662266f41058a194921afe9126dfbbd0b9c8b52
Ajay Panicker [Thu, 7 Jun 2018 05:26:17 +0000 (22:26 -0700)]
Merge changes from topic "am-
7125a1ce-592b-4a1d-a4e0-
c6f472d5dc83" into oc-dev am:
086995d099 am:
352b01c987
am:
728f645ccc
Change-Id: I1e3070df2626d5c92f0afe4654da67eb107fee85
Ajay Panicker [Thu, 7 Jun 2018 05:25:47 +0000 (22:25 -0700)]
[automerger skipped] DO NOT MERGE: Don't reuse buffer when building response am:
9bbce86038 am:
2e3d8cde0e
am:
34d0e93bc6 -s ours
Change-Id: I573567707397a1aa0cb69a683156c1a5b76b7bd0
TreeHugger Robot [Thu, 7 Jun 2018 05:25:08 +0000 (05:25 +0000)]
Merge "Send ACK for A2DP_CTRL_CMD_SUSPEND even if audio was no streaming" into pi-dev
Ajay Panicker [Thu, 7 Jun 2018 04:21:58 +0000 (21:21 -0700)]
Merge changes from topic "am-
662f3e36-36cc-485d-824b-
f28c01eea384" into oc-dev am:
0cda123801
am:
427aebe54a
Change-Id: I7d0fb74f7c6f45411f72c0471a239f933e3fc101
Ajay Panicker [Thu, 7 Jun 2018 04:21:32 +0000 (21:21 -0700)]
Merge changes from topic "am-
7125a1ce-592b-4a1d-a4e0-
c6f472d5dc83" into oc-dev am:
086995d099
am:
352b01c987
Change-Id: I1753fa0854933bf75a4d8c763d2be1d29fa398af
Ajay Panicker [Thu, 7 Jun 2018 04:20:59 +0000 (21:20 -0700)]
DO NOT MERGE: Don't reuse buffer when building response am:
9bbce86038
am:
2e3d8cde0e
Change-Id: I3a59bf8a5c375be0388952a1232316bf88ae0928
Ajay Panicker [Thu, 7 Jun 2018 03:08:39 +0000 (20:08 -0700)]
Merge changes from topic "am-
662f3e36-36cc-485d-824b-
f28c01eea384" into oc-dev
am:
0cda123801
Change-Id: I439feb0e5a5ee9dc65613aab59f48f98405ac1c5
Ajay Panicker [Thu, 7 Jun 2018 03:08:06 +0000 (20:08 -0700)]
Merge changes from topic "am-
7125a1ce-592b-4a1d-a4e0-
c6f472d5dc83" into oc-dev
am:
086995d099
Change-Id: I8ba858a9bfdc2d81c487692cda8bb16e9b371356
Ajay Panicker [Thu, 7 Jun 2018 03:07:30 +0000 (20:07 -0700)]
DO NOT MERGE: Don't reuse buffer when building response
am:
9bbce86038
Change-Id: I0b7edc528c15d05e2b07c2ad5b30c40a387eb87f
TreeHugger Robot [Thu, 7 Jun 2018 01:53:54 +0000 (01:53 +0000)]
Merge changes from topic "am-
662f3e36-36cc-485d-824b-
f28c01eea384" into oc-dev
* changes:
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c am:
2f532ef9b0 skipped:
052add83b4
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c am:
2f532ef9b0
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f
DO NOT MERGE: Don't reuse buffer when building response
TreeHugger Robot [Thu, 7 Jun 2018 01:36:28 +0000 (01:36 +0000)]
Merge changes from topic "am-
7125a1ce-592b-4a1d-a4e0-
c6f472d5dc83" into oc-dev
* changes:
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30 am:
5d335dfb7b skipped:
66c6a114a6
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30 am:
5d335dfb7b
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8
DO NOT MERGE: Don't reuse buffer when building response
Android Build Merger (Role) [Thu, 7 Jun 2018 00:46:48 +0000 (00:46 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c am:
2f532ef9b0 skipped:
052add83b4
Change-Id: Id3ae5582793f9deabc23e530380f0aa565b64b8e
Android Build Merger (Role) [Thu, 7 Jun 2018 00:46:46 +0000 (00:46 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c am:
2f532ef9b0
Change-Id: I39f72d38038768d9207455399184cccde2ccba4b
Android Build Merger (Role) [Thu, 7 Jun 2018 00:46:44 +0000 (00:46 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311 am:
3a9eca8d4c
Change-Id: Ib332da78669cd9e8b6c1d3f25d54cc8df23b444a
Android Build Merger (Role) [Thu, 7 Jun 2018 00:46:41 +0000 (00:46 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f am:
cf7d3de311
Change-Id: Idf12259570aae1cf15a4f4805df093a8d0dabf43
Android Build Merger (Role) [Thu, 7 Jun 2018 00:46:38 +0000 (00:46 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
ecef51ee8f
Change-Id: I4911528515373e3dfc0763d5f793df29fb64d4e8
Ajay Panicker [Wed, 6 Jun 2018 21:58:54 +0000 (14:58 -0700)]
DO NOT MERGE: Don't reuse buffer when building response
Bug:
79541338
Test: Compile and connect to remote headset
Change-Id: I5e059615db589e165630f39d631a922006c2d70f
Android Build Merger (Role) [Thu, 7 Jun 2018 00:44:15 +0000 (00:44 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30 am:
5d335dfb7b skipped:
66c6a114a6
Change-Id: I1c26c4fed03c9e6b6e0ae80ab330eb15dfee9072
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:57 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30 am:
5d335dfb7b
Change-Id: I1cd26eb9ac7ddcb7797b8011119156403c7920fb
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:34 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930 am:
ce6884eb30
Change-Id: Ic43b38cb648059daff18c044d45d154b1700a632
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:27 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98 am:
54ef7ee930
Change-Id: Ic705adf4e25e1fb686feaa2894a37cda250fa9c0
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:25 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d am:
f294bdbb98
Change-Id: Ifbff9c61654090104521be186d0bce9a3ae337a8
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:23 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d skipped:
c4d802659d
Change-Id: I5d7ceaba658d90e8a8931b50a6c8774f2c690b5d
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:21 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351 am:
690cc6b25d
Change-Id: I9d251934afe063299b4b7f36ea63c214b5188577
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:20 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8 am:
4d07934351
Change-Id: I7b8076d21aeeb80c469764d0643ee54e9de049ff
Android Build Merger (Role) [Thu, 7 Jun 2018 00:43:18 +0000 (00:43 +0000)]
[automerger] DO NOT MERGE: Don't reuse buffer when building response am:
5b27fef4d8
Change-Id: I73fc976256c6af11d7431778b3c962a2816f5f5f
Ajay Panicker [Wed, 6 Jun 2018 21:29:59 +0000 (14:29 -0700)]
DO NOT MERGE: Don't reuse buffer when building response
Bug:
79541338
Test: Compile and connect to remote headset
Change-Id: I2c00660bb551bbac58df88d2df07c98a30871e58
Ajay Panicker [Tue, 5 Jun 2018 23:08:06 +0000 (16:08 -0700)]
DO NOT MERGE: Don't reuse buffer when building response
Bug:
79541338
Test: Compile and connect to remote headset
Change-Id: I2d808f941d3c71fcb6306c733717624be10478e0
Ajay Panicker [Tue, 5 Jun 2018 23:08:06 +0000 (16:08 -0700)]
Don't reuse buffer when building response
Bug:
79541338
Test: Compile and connect to remote headset
Change-Id: I2d808f941d3c71fcb6306c733717624be10478e0
Ajay Panicker [Thu, 31 May 2018 00:50:39 +0000 (17:50 -0700)]
Run the AVRCP Service interface functions on the BTA thread
Bug:
80416347
Test: Turn off Bluetooth while connected to a device we initiated the
connection to.
Change-Id: I8f10409c495213ef3117aedf66919de7c0b3d164
Pavlin Radoslavov [Tue, 5 Jun 2018 05:18:32 +0000 (22:18 -0700)]
Send ACK for A2DP_CTRL_CMD_SUSPEND even if audio was no streaming
The A2DP_CTRL_CMD_SUSPEND command from the Audio HAL could be received
even if audio wasn't streaming before. Therefore, we should always
respond with an ACK once the command processing has been completed.
Bug:
109712592
Test: Manual: (1) Play music to Headset; (2) Select "This device" as output;
(3) Stop playing music; (4) Select Headset as output
Change-Id: I0f5d52d14b50882931b9d19de1a2f25204fce19e
Pavlin Radoslavov [Tue, 5 Jun 2018 07:49:47 +0000 (00:49 -0700)]
[automerger skipped] [automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e am:
8dca5d6981 skipped:
25fc5872de am:
d25b494ad6 -s ours am:
5b62b582dc -s ours
am:
2c9e2b2869 -s ours
Change-Id: I85d8fcf81ab3582373d2ac0f4b849fccb1ea6918
Pavlin Radoslavov [Tue, 5 Jun 2018 07:45:38 +0000 (00:45 -0700)]
[automerger skipped] [automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e am:
8dca5d6981 skipped:
25fc5872de am:
d25b494ad6 -s ours
am:
5b62b582dc -s ours
Change-Id: I366348476e217dbc3ccfd43611e6e2ca57bfda4c
Pavlin Radoslavov [Tue, 5 Jun 2018 07:41:38 +0000 (00:41 -0700)]
[automerger skipped] [automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e am:
8dca5d6981 skipped:
25fc5872de
am:
d25b494ad6 -s ours
Change-Id: I73dc4042b7c4283bcca582638079c0fc4bab161c
Android Build Merger (Role) [Tue, 5 Jun 2018 03:50:22 +0000 (03:50 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e am:
8dca5d6981 skipped:
25fc5872de
Change-Id: Ic7d6036bf7b14dbc1979990181612dc8c0c35e71
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:29 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e am:
8dca5d6981
Change-Id: I10eba2bac9686a5f50b736d1bc38caa0cd56265a
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:27 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e am:
515cf6983e
Change-Id: I30fe1a2edd100c78a3b4964f9687b7c666217ad0
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:24 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319 am:
c25b7e056e
Change-Id: I526e9afc2a7bb0e101f4d6a70e0e3cb1126e72ca
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:22 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b am:
e7c8891319
Change-Id: I84ba18bda5c2adbc83181bcd9fbea0291fb7a8e7
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:20 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a am:
862eb4827b
Change-Id: I336035e480bcd33d67b90543a9f81fe919dc649a
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:17 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880 am:
ac8793939a
Change-Id: Ibde13c7a9f0af5a7e4f38db226532780b8fc50fa
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:15 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb am:
6b2f63f880
Change-Id: I874adb503bb51f88ad7a934b697221f544fc5488
Android Build Merger (Role) [Tue, 5 Jun 2018 03:48:12 +0000 (03:48 +0000)]
[automerger] Add checks whether the AVDTP element data length is valid am:
e192c988cb
Change-Id: I945a8ce34b41a7df4a3c853ad5b4ba51d0136251
Pavlin Radoslavov [Thu, 31 May 2018 17:23:02 +0000 (10:23 -0700)]
Add checks whether the AVDTP element data length is valid
Bug:
78288378
Test: Manual: Python script and extra logging
Change-Id: I576d798d8b566946a3f2d973cb9d4e8dbd22d09e
Merged-In: I715b5977c833d33ff798f008fbf244effa13ea1f
Jack He [Tue, 5 Jun 2018 02:55:38 +0000 (19:55 -0700)]
Merge changes from topic "am-
3b6a3916-25a5-4937-a978-
aa9d7658661a" into oc-dev am:
6f887610ac am:
52bfa2bb6f
am:
72e5c0e9e3
Change-Id: Ic66b4cdd08cf277fcc476bb3d8fe0fa9efb79ec3
Jack He [Tue, 5 Jun 2018 02:51:58 +0000 (19:51 -0700)]
Merge changes from topic "am-
3b6a3916-25a5-4937-a978-
aa9d7658661a" into oc-dev am:
6f887610ac
am:
52bfa2bb6f
Change-Id: Ib6702ff2231fab534399df7310d81803562ef5e5
Jack He [Tue, 5 Jun 2018 02:49:04 +0000 (19:49 -0700)]
Merge changes from topic "am-
3b6a3916-25a5-4937-a978-
aa9d7658661a" into oc-dev
am:
6f887610ac
Change-Id: Ib29a9d7fa791b539f1496a99dbbc3644e6760a5d
TreeHugger Robot [Tue, 5 Jun 2018 02:38:00 +0000 (02:38 +0000)]
Merge changes from topic "am-
3b6a3916-25a5-4937-a978-
aa9d7658661a" into oc-dev
* changes:
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7 am:
1321566723 skipped:
8e9b525909
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7 am:
1321566723
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55
DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf
Pavlin Radoslavov [Tue, 5 Jun 2018 01:51:19 +0000 (18:51 -0700)]
Merge "Add BT_HDR length check for received AVCTP packets" into oc-dev am:
47660ad688 am:
a6bb951521
am:
d039265803
Change-Id: Ida55d984d4252494240076de069a13076018fd52
Pavlin Radoslavov [Tue, 5 Jun 2018 01:50:50 +0000 (18:50 -0700)]
Merge "Add packet length check for received AVCTP packets" into oc-dev am:
7f8d2f60e1 am:
540e7b9bc6
am:
10dc625132
Change-Id: I54dad8a11b35fc5e7281f3c16c44e8eccb96bf37
Pavlin Radoslavov [Tue, 5 Jun 2018 01:50:16 +0000 (18:50 -0700)]
Merge "Add checks whether the AVDTP element data length is valid" into oc-dev am:
3c083d2d96 am:
af9c4bf9c1
am:
e3d36896d1
Change-Id: I8cec27a67fb5537e685ebe2b16c13aed4d9cc99a
Pavlin Radoslavov [Tue, 5 Jun 2018 01:39:16 +0000 (18:39 -0700)]
Merge "Add BT_HDR length check for received AVCTP packets" into oc-dev am:
47660ad688
am:
a6bb951521
Change-Id: I8d5638c89b226dc8a20d9287cfe80e687542621f
Pavlin Radoslavov [Tue, 5 Jun 2018 01:38:51 +0000 (18:38 -0700)]
Merge "Add packet length check for received AVCTP packets" into oc-dev am:
7f8d2f60e1
am:
540e7b9bc6
Change-Id: If46b368d67ac44645f1c29085bb35e33e3f02816
Pavlin Radoslavov [Tue, 5 Jun 2018 01:38:20 +0000 (18:38 -0700)]
Merge "Add checks whether the AVDTP element data length is valid" into oc-dev am:
3c083d2d96
am:
af9c4bf9c1
Change-Id: I79bb4b33bbbeff0ee232d107acfc7f0426bbac77
Pavlin Radoslavov [Tue, 5 Jun 2018 01:30:00 +0000 (18:30 -0700)]
Merge "Add BT_HDR length check for received AVCTP packets" into oc-dev
am:
47660ad688
Change-Id: I2194af7ebcbc48db7d78421b61a07fd5f952c3fe
Pavlin Radoslavov [Tue, 5 Jun 2018 01:29:33 +0000 (18:29 -0700)]
Merge "Add packet length check for received AVCTP packets" into oc-dev
am:
7f8d2f60e1
Change-Id: Iacb904337e82fff45e51b4c3526786c3b0cd5f0c
Pavlin Radoslavov [Tue, 5 Jun 2018 01:29:01 +0000 (18:29 -0700)]
Merge "Add checks whether the AVDTP element data length is valid" into oc-dev
am:
3c083d2d96
Change-Id: I3bb4b672c9ae6623da8ed76fafef15a6ce368a7e
Jack He [Tue, 5 Jun 2018 01:02:51 +0000 (18:02 -0700)]
[automerger skipped] [automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a am:
452fcb6a05 skipped:
ffc7491237 am:
ba0f19a644 -s ours am:
66947b9501 -s ours
am:
0e732604e7 -s ours
Change-Id: I79c72b38b169a2e7932e2a76f2f20b2cbd611c71
TreeHugger Robot [Tue, 5 Jun 2018 01:00:53 +0000 (01:00 +0000)]
Merge "Add BT_HDR length check for received AVCTP packets" into oc-dev
TreeHugger Robot [Tue, 5 Jun 2018 01:00:38 +0000 (01:00 +0000)]
Merge "Add packet length check for received AVCTP packets" into oc-dev
TreeHugger Robot [Tue, 5 Jun 2018 00:58:27 +0000 (00:58 +0000)]
Merge "Add checks whether the AVDTP element data length is valid" into oc-dev
Android Build Merger (Role) [Tue, 5 Jun 2018 00:49:12 +0000 (00:49 +0000)]
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7 am:
1321566723 skipped:
8e9b525909
Change-Id: Ie598286e6577250401752aa4f8783761b683c470
Android Build Merger (Role) [Tue, 5 Jun 2018 00:49:10 +0000 (00:49 +0000)]
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7 am:
1321566723
Change-Id: I61ca7ec910613a253d5611d71fdcf223a367ace4
Android Build Merger (Role) [Tue, 5 Jun 2018 00:49:08 +0000 (00:49 +0000)]
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83 am:
a5fc127aa7
Change-Id: I1cf449cd8ec0c4cbd3ca7176900b5c803cc24067
Android Build Merger (Role) [Tue, 5 Jun 2018 00:49:06 +0000 (00:49 +0000)]
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55 am:
b8af4e4a83
Change-Id: Ieab711bb2c2408a09c13032c775a819c2695cb87
Android Build Merger (Role) [Tue, 5 Jun 2018 00:49:03 +0000 (00:49 +0000)]
[automerger] DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf am:
6245466d55
Change-Id: I63ea708b1a1c087724749cd587cbcad86e1fe30c
Jack He [Tue, 5 Jun 2018 00:40:42 +0000 (17:40 -0700)]
DO NOT MERGE BNEP: Fix build breakage by using osi_free instead of GKI_freebuf
Bug:
79164722
Bug:
78286118
Test: make
Change-Id: I04fc994d9bca80aa4711118d3c5be02f2b809a48
Jack He [Tue, 5 Jun 2018 00:30:45 +0000 (17:30 -0700)]
[automerger skipped] [automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a am:
452fcb6a05 skipped:
ffc7491237 am:
ba0f19a644 -s ours
am:
66947b9501 -s ours
Change-Id: Ie84cd501b5074319b2c77fc0841975e1eb7714d7
Jack He [Tue, 5 Jun 2018 00:06:20 +0000 (17:06 -0700)]
[automerger skipped] [automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a am:
452fcb6a05 skipped:
ffc7491237
am:
ba0f19a644 -s ours
Change-Id: I9215defae8eeb6d083a0644984eb26c6a7302c08
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:53 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a am:
452fcb6a05 skipped:
ffc7491237
Change-Id: Ieb47cc367f89bce412a30d1bf44117c014141cee
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:16 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a am:
452fcb6a05
Change-Id: I88ef6244852f3391a864cc13dc559d97cc8d61d6
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:14 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a am:
8c679a453a
Change-Id: I57dfaa5eceea67bca11ba561a5010130be0066fe
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:12 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad am:
7211394f5a
Change-Id: I9a39f998411705e5062c9757db52778081be495c
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:10 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06 am:
3ba9845cad
Change-Id: I17a958293bb80866db6348f68a3c477a48f7de53
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:07 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a am:
eee28a5a06
Change-Id: I5018c4115f5502d5f88c955f77221339663eca91
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:05 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23 am:
81dcda9a5a
Change-Id: I1cd6cf2b54334cff0bb8568cb0dd5ef6121ca444
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:03 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4 am:
8f9b349c23
Change-Id: I404328203b34b5e48d2d5fbca3667e9dac9ca742
Android Build Merger (Role) [Mon, 4 Jun 2018 23:10:01 +0000 (23:10 +0000)]
[automerger] BNEP: Fix OOB access in bnep_data_ind am:
0bd01271c4
Change-Id: I12f77728b3ad0f10b3cd0f34a7068272573e6ea4
Jack He [Fri, 1 Jun 2018 21:00:42 +0000 (14:00 -0700)]
BNEP: Fix OOB access in bnep_data_ind
* Stop reading the L2CAP packet if packet length is 0
* Process the buffer for BNEP_EXTENSION_CONTROL packet before advancing
the buffer pointer by length of payload
* Reject BNEP_EXTENSION_CONTROL packet when the payload size is zero
* Move error logging to more appropriate locations at where the OOB access
is most likely triggered
Bug:
78286118
Bug:
79164722
Test: Send zero length L2CAP packet to BNEP, send invalid
BNEP_EXTENSION_CONTROL packet
Change-Id: I7e18632b8faab1b6aaca1bff1b7f55d69962729e
Merged-In: I7e18632b8faab1b6aaca1bff1b7f55d69962729e
(cherry picked from commit
3c799a6e25abdf6bacb660ff7a06338836cc7356)
The Android Automerger [Mon, 4 Jun 2018 22:51:03 +0000 (22:51 +0000)]
The Android Automerger [Mon, 4 Jun 2018 22:48:54 +0000 (22:48 +0000)]
Jack He [Mon, 4 Jun 2018 22:31:24 +0000 (15:31 -0700)]
BNEP: Fix OOB access in bnep_data_ind
am:
0416340ffa
Change-Id: I45d6d2adb09316bcc231ae875d788885c40768c8
Pavlin Radoslavov [Thu, 31 May 2018 18:04:54 +0000 (11:04 -0700)]
Add BT_HDR length check for received AVCTP packets
Bug:
79944113
Test: Code compilation
Change-Id: I02c76ab8fad61669394062bf34656ea32f465b6a
Merged-In: I02c76ab8fad61669394062bf34656ea32f465b6a
(cherry picked from commit
4262b932e487b19d578d79e0120cf03291f44efc)
Pavlin Radoslavov [Thu, 31 May 2018 02:26:16 +0000 (19:26 -0700)]
Add packet length check for received AVCTP packets
Bug:
79944113
Test: Manual: Custom test program and extra logging
Change-Id: Icde465fed723bf876ce3885d11099fddcb92de81
Merged-In: Icde465fed723bf876ce3885d11099fddcb92de81
(cherry picked from commit
2a934acf498a6b715cc7c634123aa403a70fe9e6)
Pavlin Radoslavov [Thu, 31 May 2018 00:56:14 +0000 (17:56 -0700)]
Add checks whether the AVDTP element data length is valid
Bug:
78288378
Test: Manual: Python script and extra logging
Change-Id: I715b5977c833d33ff798f008fbf244effa13ea1f
Merged-In: I715b5977c833d33ff798f008fbf244effa13ea1f
(cherry picked from commit
9b3f96f50287d8789aff6d6895d7ae02ca6ac619)
Jack He [Fri, 1 Jun 2018 21:00:42 +0000 (14:00 -0700)]
BNEP: Fix OOB access in bnep_data_ind
* Stop reading the L2CAP packet if packet length is 0
* Process the buffer for BNEP_EXTENSION_CONTROL packet before advancing
the buffer pointer by length of payload
* Reject BNEP_EXTENSION_CONTROL packet when the payload size is zero
* Move error logging to more appropriate locations at where the OOB access
is most likely triggered
Bug:
78286118
Bug:
79164722
Test: Send zero length L2CAP packet to BNEP, send invalid
BNEP_EXTENSION_CONTROL packet
Merged-In: I7e18632b8faab1b6aaca1bff1b7f55d69962729e
Change-Id: I7e18632b8faab1b6aaca1bff1b7f55d69962729e
(cherry picked from commit
3c799a6e25abdf6bacb660ff7a06338836cc7356)