OSDN Git Service
Christian Kamm [Mon, 12 Sep 2011 08:44:11 +0000 (10:44 +0200)]
QmlJS checks: Correct the check for dangerous == and add tests.
Change-Id: Ie0f4062069bf241020868af34ce6d36146b4b0c7
Reviewed-on: http://codereview.qt-project.org/4646
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Fri, 9 Sep 2011 13:49:05 +0000 (15:49 +0200)]
QmlJS: Add infrastructure for tests of QML static checker.
Change-Id: Idf49bc0c29ad82456a5fe65e2acced6a4fb130fc
Reviewed-on: http://codereview.qt-project.org/4552
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Tue, 13 Sep 2011 11:32:29 +0000 (13:32 +0200)]
QmlJS: Cleanup Link.
* Don't use Qt macros for d-ptr.
* Move private functions to LinkPrivate.
Change-Id: Icb6f579e9168dd9bf5cccec1255fda1939e47c9a
Reviewed-on: http://codereview.qt-project.org/4767
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Wed, 14 Sep 2011 07:28:49 +0000 (09:28 +0200)]
QmlJS: Enable 'follow symbol' for local variables.
Task-number: QTCREATORBUG-6094
Change-Id: Icf286bc412b48dbd1cb38c47ad7b91040b5aae0f
Reviewed-on: http://codereview.qt-project.org/4864
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Aurindam Jana [Tue, 13 Sep 2011 15:26:02 +0000 (17:26 +0200)]
QmlDebugger: Added dialog "Attach to QML Port..."
The dialog is added to Debug->Start Debugging menu option. It specifies the host
and port that the JSDebugClient connects to for listening to debug messages.
Change-Id: I7f828c169ff2338f4780025f72182c5fc8784c4a
Reviewed-on: http://codereview.qt-project.org/4824
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Christian Kamm [Fri, 9 Sep 2011 12:56:12 +0000 (14:56 +0200)]
QmlJS tests: Make basic test pass again.
Change-Id: Iff7d36e7c7908b267fc02cd46e3f2a173ef5c7b9
Reviewed-on: http://codereview.qt-project.org/4547
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Fri, 9 Sep 2011 11:56:41 +0000 (13:56 +0200)]
QmlJS: Improve import error messages.
Change-Id: Ief305b787fbc4577acfdec41083bc72e178db46d
Reviewed-on: http://codereview.qt-project.org/4537
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 11:30:48 +0000 (13:30 +0200)]
QmlJS indenter: Fix labelled statements and break/continue with label.
Also do some cleanup to make handling of substatements nicer.
Change-Id: I78773fc81d9b0058fa97c5cef393cca34b7fd885
Reviewed-on: http://codereview.qt-project.org/4413
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Wed, 14 Sep 2011 07:59:05 +0000 (09:59 +0200)]
QmlJS highlighting: Fix external object property highlight.
Change-Id: Ie9fa9aceb72c40ca2f991f48f70f89e5ab342436
Reviewed-on: http://codereview.qt-project.org/4870
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 05:21:38 +0000 (07:21 +0200)]
QmlJS checks: Add 'unreachable code' warnings.
Change-Id: I59e490adce5c0cd7784894a0f9d4435cdcbc9b23
Reviewed-on: http://codereview.qt-project.org/4332
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Eike Ziller [Fri, 9 Sep 2011 14:10:57 +0000 (16:10 +0200)]
Keep multiple search results in history.
Change-Id: I7350c78479343e85b1ca4957e08bccefb5756d20
Reviewed-on: http://codereview.qt-project.org/4556
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Tobias Hunger [Tue, 13 Sep 2011 15:05:50 +0000 (15:05 +0000)]
VCS: Make initialization of a repo trigger updateActions
Make initialization/cloning of a repo trigger an updateActions.
This is needed to e.g. enable git actions after a git repo is created.
Reviewed-by: Hugues Delorme
Change-Id: Ia8513a216e584fe8e512fdd5d6215aa96c075f3f
Reviewed-on: http://codereview.qt-project.org/4878
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Christian Kamm [Wed, 14 Sep 2011 08:42:23 +0000 (10:42 +0200)]
C++ function signature: Don't try to reuse nonexistant context.
Change-Id: I890cccc25c5ba774691edee860845e22a7b7ec78
Reviewed-on: http://codereview.qt-project.org/4876
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Kai Koehne [Tue, 13 Sep 2011 15:05:51 +0000 (17:05 +0200)]
QmlProfiler: Fix help output
Change-Id: I52aca06921ae45ad0103d672ede569cbbce09eea
Reviewed-on: http://codereview.qt-project.org/4800
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
hjk [Tue, 13 Sep 2011 16:18:22 +0000 (18:18 +0200)]
debugger: Use the 'r' format to read register contents.
One wart less.
Change-Id: Iff86c93308a4e4d93a55139940aff2e26edc1e1f
Reviewed-on: http://codereview.qt-project.org/4827
Reviewed-by: hjk <qthjk@ovi.com>
Kai Koehne [Tue, 13 Sep 2011 14:43:06 +0000 (16:43 +0200)]
Add changes-2.4.0 file
Change-Id: Ic6b59e9a40134b1e37e64170bcf12388c535014a
Reviewed-on: http://codereview.qt-project.org/4794
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Kai Koehne [Tue, 13 Sep 2011 14:36:31 +0000 (16:36 +0200)]
qtpromaker: Fix typo in help
Change-Id: I77b5448cc19451944ec70fa5394c3f534dfcad7b
Eike Ziller [Fri, 9 Sep 2011 06:46:51 +0000 (08:46 +0200)]
Move advanced search dialog into search result pane.
And move the cancel button into the specific search result widget.
Change-Id: Ide8173e1ec5de091e1c1332a2b0c47d9a30a4c87
Reviewed-on: http://codereview.qt-project.org/4555
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Eike Ziller [Wed, 7 Sep 2011 18:28:04 +0000 (20:28 +0200)]
Show more info about a search and move UI for replacing
Change-Id: I6e024583c0d778a65007eb4590118c4329b2118a
Reviewed-on: http://codereview.qt-project.org/4554
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Christian Kamm [Tue, 13 Sep 2011 09:07:37 +0000 (11:07 +0200)]
C++ function signature: Add shortcut to marker tooltip.
Change-Id: Ied3268bb624df4201ca42beb76d20b9a638d5918
Reviewed-on: http://codereview.qt-project.org/4746
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christian Kamm [Mon, 12 Sep 2011 13:02:30 +0000 (15:02 +0200)]
C++: Don't jump to change when applying function signature quickfix.
Change-Id: I93abf773717b3f82fc6fa15e1916f48bc3edec95
Reviewed-on: http://codereview.qt-project.org/4675
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christoph Mathys [Tue, 13 Sep 2011 11:14:25 +0000 (13:14 +0200)]
debugger: Add support for threadnames in core file debugging.
The gdb engine now calls thread-info instead of thread-list-ids
when debugging core files and fall back to thread-list-ids if
thread-info does not work. This is now the same behaviour as if
qtcreator is attached to a running process.
Change-Id: I09b8e60fab329d9b65c501e18cd3fd9ceb22f506
Merge-request: 2192
Reviewed-by: hjk <qtc-committer@nokia.com>
Reviewed-on: http://codereview.qt-project.org/4763
Reviewed-by: hjk <qthjk@ovi.com>
Daniel Teske [Tue, 13 Sep 2011 11:12:34 +0000 (13:12 +0200)]
Fix buddy for Utils::PathChooser
Task-number: QTCREATORBUG-4966
Change-Id: I848f8fbdc6fa613e7308bb5700b9cbc305f36c73
Reviewed-on: http://codereview.qt-project.org/4760
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
hjk [Tue, 13 Sep 2011 07:54:37 +0000 (09:54 +0200)]
fakevim: string literals
Change-Id: I17b78751a161a25b1b1de7018c47e07274f0f438
Reviewed-on: http://codereview.qt-project.org/4756
Reviewed-by: hjk <qthjk@ovi.com>
Orgad Shaneh [Tue, 13 Sep 2011 10:50:33 +0000 (12:50 +0200)]
Dumper: Fixed wrong function call
Merge-request: 383
Reviewed-by: hjk <qtc-committer@nokia.com>
Change-Id: I4d8c60f8877f6771783ba368050b8bce8891ba9e
Reviewed-on: http://codereview.qt-project.org/4757
Reviewed-by: hjk <qthjk@ovi.com>
Christian Kamm [Tue, 13 Sep 2011 09:36:05 +0000 (11:36 +0200)]
C++ function signature: Allow most specifiers to be replaced.
Except for some SimpleSpecifiers and AttributeSpecifiers. Fixes a bug
where NamedTypeSpecifiers would not be replaced when the return type
was adjusted.
Change-Id: Ie093615ebf1b26d181b888fcbcc341e5bdf85fd1
Reviewed-on: http://codereview.qt-project.org/4749
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Marco Bubke [Mon, 12 Sep 2011 14:52:54 +0000 (16:52 +0200)]
Wizards: Refactor GeneratedFile in a extra file
Change-Id: I58f7053405c79774154c2f0447944533e6b10152
Reviewed-on: http://codereview.qt-project.org/4685
Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
hjk [Mon, 12 Sep 2011 13:16:27 +0000 (15:16 +0200)]
fakevim: make toggle action scriptable
Change-Id: Ic089b91db144389bac4967a6c4f8be361b1a3bda
Reviewed-on: http://codereview.qt-project.org/4730
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Robert Loehning [Mon, 12 Sep 2011 13:48:43 +0000 (15:48 +0200)]
Fixed operator precedence
Change-Id: I8482915ac8218d6575fb4c51dbcf0d1fcd0d60e4
Reviewed-on: http://codereview.qt-project.org/4681
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Robert Loehning [Mon, 12 Sep 2011 13:07:05 +0000 (15:07 +0200)]
Removed unused constant
Change-Id: I5a58bb3f4a5be240d1e4b59ad8a592699f35af93
Reviewed-on: http://codereview.qt-project.org/4676
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
Thomas Hartmann [Mon, 12 Sep 2011 12:59:58 +0000 (14:59 +0200)]
QmlDesigner.formeEditor: create paintPlaceHolder
Change-Id: I91d3aa94b4e8ac91eeaed98d19722837e590dfdf
Reviewed-on: http://codereview.qt-project.org/4673
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Mon, 12 Sep 2011 09:48:33 +0000 (11:48 +0200)]
QmlJS: Fix reference lookup cycles.
Since several reference lookups involve Evaluate which may cause
further reference lookups, we need to be able to pass the existing
ReferenceContext to avoid cycles.
Change-Id: I2f1eeaad4d6b6ff094413d51077b03c985f6fab4
Reviewed-on: http://codereview.qt-project.org/4653
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Aurindam Jana [Mon, 12 Sep 2011 10:45:17 +0000 (12:45 +0200)]
WatchHandler: Fix warnings
Change-Id: I877a78b48e7b5c0abb30db6661b9e1986be61b47
Reviewed-on: http://codereview.qt-project.org/4659
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
Thomas Hartmann [Wed, 7 Sep 2011 11:50:47 +0000 (13:50 +0200)]
QmlDesigner.formEditor: improving appearence
Change-Id: Icdc10bb0eca30a4e5d85e5200e1c19b5a846b4e4
Reviewed-on: http://codereview.qt-project.org/4350
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Marco Bubke <marco.bubke@nokia.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Christian Kamm [Mon, 12 Sep 2011 10:58:59 +0000 (12:58 +0200)]
QmlJS semantic highlighter: Abort when file changes.
Fixes the warning in incrementalApplyExtraAdditionalFormats being
triggered when the document is reduced in size while a highlight is
running.
Change-Id: I60e0c8772d511f52ee433d27cc77ba726030b354
Reviewed-on: http://codereview.qt-project.org/4661
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christian Stenger [Mon, 12 Sep 2011 09:07:54 +0000 (11:07 +0200)]
Added indentation test for Qml
Change-Id: I15751d93dccba232455e6e85c4ac0c30c74be3af
Reviewed-on: http://codereview.qt-project.org/4650
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bill King <bill.king@nokia.com>
Christian Kamm [Fri, 9 Sep 2011 12:21:31 +0000 (14:21 +0200)]
C++ function signature: Don't accidentally eat specifiers.
You could accidentally delete specifiers like 'static' or 'virtual' with
the 'apply function signature changes' quick fix before.
Change-Id: Ia97a33f663a01063fad4d432551715ebf27a18d5
Reviewed-on: http://codereview.qt-project.org/4538
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christian Kamm [Mon, 12 Sep 2011 06:41:53 +0000 (08:41 +0200)]
C++: Fix function return type printing.
We used to print T * foo(), but our style suggests T *foo().
Change-Id: Ie3b0ce6b620785ec98aeb394f7955ce959440619
Reviewed-on: http://codereview.qt-project.org/4634
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christian Kamm [Fri, 9 Sep 2011 08:55:11 +0000 (10:55 +0200)]
QmlJS: Use mime types to distinguish qml and js files.
This allows adding patterns to the qml mime type in the options dialog.
Previously they were always parsed as js.
Change-Id: Ifa344fb6ab8cbcda02becef991cf6807615a1caa
Reviewed-on: http://codereview.qt-project.org/4515
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Bill King [Mon, 12 Sep 2011 08:29:08 +0000 (10:29 +0200)]
New waitForSignal function
...and real life test case.
Change-Id: Id22f4a7bf444e319651b54e1a3a230040b982e30
Reviewed-on: http://codereview.qt-project.org/4548
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
Shane Bradley [Wed, 7 Sep 2011 00:19:21 +0000 (10:19 +1000)]
qttest: Fix issues reported by Krazy
Change-Id: I7bce3cd862b7f680f1b8f42249ae0df4c12e10d9
Reviewed-on: http://codereview.qt-project.org/4299
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Bill King [Thu, 8 Sep 2011 14:45:39 +0000 (16:45 +0200)]
Sort help registrations.
Looks cleaner, also helps cleanup.
Change-Id: If3182f974ca3401cd44fb062d695685e5029aa81
Reviewed-on: http://codereview.qt-project.org/4473
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Christian Kandeler [Fri, 9 Sep 2011 15:06:15 +0000 (17:06 +0200)]
RemoteLinux: Change output at the end of a deploy step.
"Deployment finished" is potentially misleading, as other steps
might follow.
Change-Id: I457b2c2427c65146b48e13bf9323ac11feee18db
Reviewed-on: http://codereview.qt-project.org/4561
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Christian Kandeler [Fri, 9 Sep 2011 15:04:14 +0000 (17:04 +0200)]
RemoteLinux: Change default deployment method.
Do direct upload instead of creating and extracting a tarball.
Change-Id: Ic84f3a833a7f42e392e37bf4e9b2f9522af5f5ca
Reviewed-on: http://codereview.qt-project.org/4560
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Eike Ziller [Wed, 7 Sep 2011 08:32:24 +0000 (10:32 +0200)]
Remove unnecessary 'explicit's.
Change-Id: Id0386635b1c7daadf2501361a2c78019b9dfd4ab
Reviewed-on: http://codereview.qt-project.org/4553
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Bill King [Fri, 9 Sep 2011 09:38:13 +0000 (11:38 +0200)]
More wait-for-project-refresh
Change-Id: Ic08c7e66edbcf300d6643ea0139cf9eea1720e31
Reviewed-on: http://codereview.qt-project.org/4519
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
Christian Kandeler [Fri, 9 Sep 2011 12:24:30 +0000 (14:24 +0200)]
RemoteLinux: Make GenericDirectUploadStep extensible.
Change-Id: I2f201145dbfcd152a7d5624554d66dc17a91352c
Reviewed-on: http://codereview.qt-project.org/4539
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Bill King [Fri, 9 Sep 2011 10:25:43 +0000 (12:25 +0200)]
Speed up this testcase
While qt is large, it also takes a fair amount of time to process.
This should still be a sufficient testcase for basic project opening.
Change-Id: I319d009d22ad1607926d2cd751953a6268266f35
Reviewed-on: http://codereview.qt-project.org/4523
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
Bill King [Fri, 9 Sep 2011 08:14:09 +0000 (10:14 +0200)]
Wait for project refresh before building.
Change-Id: Ia5bbeec726168ecd0264ff351dd0eab9b9af31d2
Reviewed-on: http://codereview.qt-project.org/4512
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
Tobias Hunger [Thu, 8 Sep 2011 17:44:34 +0000 (19:44 +0200)]
Build fix
Change-Id: I2cef68b757d6f0affd21151a7f59029dce814c95
Reviewed-on: http://codereview.qt-project.org/4485
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Tobias Hunger [Tue, 6 Sep 2011 15:19:05 +0000 (15:19 +0000)]
ABI: Improve tool chain selection for Qt projects
* Set a null-ABI for toolchains where detection of ABI failed: This
allows the user to select any tool chain.
* Warn if ABI detection fails by showing a message in the Qt version
setup dialog
* Do not override the mkspec if the Qt version has a null ABI only:
We (have to) trust the user to know what he is doing in that case.
* GCC: Add version information to GCC tool chain and use it to select
the mkspec on Mac.
* GCC: Do not override mkspec if we do a cross-compile
(and actually detect that).
* GCC: Leave out -32 or -64 from mkspec if the compiler binaries ABI
matches the target ABI.
* Linux-generic is compatible with all other linuxes (both ways)
The targets themselves do additional filtering and will remove
anything that does not work for them anyway.
Task-number: QTCREATORBUG-5756
Task-number: QTCREATORBUG-5960
Change-Id: Ib3c0ac91f3aa8e2a823e3e9891a02bdccb97af14
Reviewed-on: http://codereview.qt-project.org/4281
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
hjk [Wed, 7 Sep 2011 12:26:11 +0000 (14:26 +0200)]
all: some m_d -> d style
Change-Id: Iac1f12980bf47666007817cfb2c64a6d1e9b780e
Reviewed-on: http://codereview.qt-project.org/4477
Reviewed-by: hjk <qthjk@ovi.com>
hjk [Wed, 7 Sep 2011 07:26:29 +0000 (09:26 +0200)]
use Core::Id for IEditorFactory::id
Change-Id: Iefd67a0461d9016b8ba0f3371df7ec6d42e188c5
Reviewed-on: http://codereview.qt-project.org/4321
Reviewed-by: hjk <qthjk@ovi.com>
hjk [Thu, 8 Sep 2011 15:38:47 +0000 (17:38 +0200)]
debugger: take care of unknown instructions in arm disassembler output
Change-Id: Ibeb8992856e8c5031e21925316c3fb0f9d7764e1
Reviewed-on: http://codereview.qt-project.org/4479
Reviewed-by: hjk <qthjk@ovi.com>
hjk [Wed, 7 Sep 2011 13:20:04 +0000 (15:20 +0200)]
debugger: robustness when stepping through inaccessible memory
Change-Id: I9cafda99986b653872e57f8223a0fe4621fd5136
Reviewed-on: http://codereview.qt-project.org/4478
Reviewed-by: hjk <qthjk@ovi.com>
Christian Kamm [Thu, 8 Sep 2011 12:47:19 +0000 (14:47 +0200)]
C++ function signature: Fix problem with multiline declarations.
QTextCursor::selectedText() has null chars where the tokenizer expects
newlines.
Change-Id: I15ae87ef8525c89812a61b80abda91d36bf56576
Reviewed-on: http://codereview.qt-project.org/4450
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Leandro Melo [Thu, 8 Sep 2011 12:01:18 +0000 (14:01 +0200)]
C++: Fix duplicate items in C++ completion for Qt methods
In the old code completion engine items were created on the stack
and passed around by value. With the refactoring of the code assist
API they became heap objects manipulated through pointers. This
patch fixes one reminiscence not caught during the refactoring
in which the same actual pointer was being used more than once to
be appended on the list.
Change-Id: I2009fb0b6aa18df57aa5ca9bde0591536ca2cd74
Reviewed-on: http://codereview.qt-project.org/4444
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Benito van der Zander [Tue, 6 Sep 2011 15:46:06 +0000 (17:46 +0200)]
add always defined macro Q_CREATOR_RUN to cpp parser
Merge-request: 336
Reviewed-by: Erik Verbruggen <erik.verbruggen@nokia.com>
Change-Id: Iefd0c60bb3e78047e28dcff33cc62c15ed11f711
Reviewed-on: http://codereview.qt-project.org/4292
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 09:01:13 +0000 (11:01 +0200)]
QmlJS checks: Improve warning about accidental empty blocks.
Change-Id: I2bddd65aef9092bf87f5a441e065ebca0e772174
Reviewed-on: http://codereview.qt-project.org/4331
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Christian Kamm [Tue, 6 Sep 2011 11:59:50 +0000 (13:59 +0200)]
QmlJS checks: Fix collection of use-before-declaration warnings.
Previously they would not be collected if the var had a
duplicate-declaration warning.
Change-Id: I82244e911fcdfc3d11cc391288da263ee288a3ca
Reviewed-on: http://codereview.qt-project.org/4330
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Christian Kamm [Thu, 8 Sep 2011 10:52:37 +0000 (12:52 +0200)]
C++: Always set source location of function symbols.
Change-Id: I83bcea6fcdbf113d541a962ac461aef1765d99fd
Reviewed-on: http://codereview.qt-project.org/4433
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 10:06:46 +0000 (12:06 +0200)]
QmlJS indenter: Fix indentation for property initializers.
property int foo: {
used to start an object literal but is a block statement now.
Change-Id: I9ffbce4927b444314f1a43aba65ca3d9d234e47c
Reviewed-on: http://codereview.qt-project.org/4339
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Aurindam Jana [Thu, 8 Sep 2011 10:22:13 +0000 (12:22 +0200)]
WatchHandler: Move generationCounter to individual WatchModels
Change-Id: I39cdd48ed02cbcf6702076245c765cb6c8926c1b
Reviewed-on: http://codereview.qt-project.org/4429
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: hjk <qthjk@ovi.com>
Christian Kandeler [Thu, 8 Sep 2011 10:38:46 +0000 (12:38 +0200)]
RemoteLinux: Don't assume a POSIX-compliant ps command.
Presumably, lots of embedded systems don't have one.
Task-number: QTCREATORBUG-5918
Change-Id: Idfbd7fe2d27ed992b3f3dbba240943d0fe41dc5b
Reviewed-on: http://codereview.qt-project.org/4432
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Christian Kamm [Fri, 2 Sep 2011 11:25:08 +0000 (13:25 +0200)]
QmlJS: Honor typeinfo lines in qmldir files.
Change-Id: I1ddad1eb031bc4b95671be4a474b5e8e72f6e350
Reviewed-on: http://codereview.qt-project.org/4137
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Christian Kamm [Thu, 25 Aug 2011 10:35:55 +0000 (12:35 +0200)]
QmlJS: Find setContextProperty calls in C++ and expose to QML.
Task-number: QTCREATORBUG-3199
Change-Id: I591490ceafadc0f5a07c63ec063f1bdfa7055f47
Reviewed-on: http://codereview.qt-project.org/4074
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Thorbjørn Lindeijer [Thu, 8 Sep 2011 09:30:48 +0000 (11:30 +0200)]
Added support for Microsoft-specific inline keywords
__inline is equivalent to inline.
__forceinline is used to override the cost/benefit analysis.
Change-Id: Ifc7c94c1798f98c553ffa979a722ede9df11b3f0
Merge-request: 2206
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Reviewed-on: http://codereview.qt-project.org/4416
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Shane Bradley [Wed, 7 Sep 2011 03:51:54 +0000 (13:51 +1000)]
qttest: Rename private classes to match Creator standard.
Change-Id: I4926d1947216395a18c2e263417d14d08e9487f4
Reviewed-on: http://codereview.qt-project.org/4301
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bill King <bill.king@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Christian Stenger [Tue, 6 Sep 2011 07:12:15 +0000 (09:12 +0200)]
Added test for creation of QtQuick application
Added more QtQuick tests and did some refactorings according to re-appearing code.
Completed the Qt Quick Wizards test from QtCreatorTestingMatrix.
Change-Id: I857d9f3c3809221e2df3e096b3926a8d5d36b828
Reviewed-on: http://codereview.qt-project.org/4238
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bill King <bill.king@nokia.com>
Christian Kandeler [Thu, 8 Sep 2011 08:15:38 +0000 (10:15 +0200)]
RemoteLinux: Grab used ports information from /proc.
The target host might not have lsof.
Change-Id: Ic0bbaf933e145b94b4665a0bfad12721984c3cc9
Reviewed-on: http://codereview.qt-project.org/4409
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Christian Kamm [Thu, 8 Sep 2011 06:49:01 +0000 (08:49 +0200)]
C++: Set endOffset of Function symbols even if skipping bodies.
Fixes insert-definition-from-declaration when the source file was not
yet opened in an editor.
Change-Id: I4263113390ae4fbe9d4641104b5cb43373ddc5a4
Reviewed-on: http://codereview.qt-project.org/4394
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Christian Kamm [Thu, 8 Sep 2011 06:55:20 +0000 (08:55 +0200)]
QmlJS checks: Don't complain about alias properties.
Change-Id: I6721b42a6ae8cc4de3d85754bf12c95f7366212e
Reviewed-on: http://codereview.qt-project.org/4395
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Christian Kandeler [Wed, 7 Sep 2011 13:48:10 +0000 (15:48 +0200)]
RemoteLinux: Respect qmake scopes for subdirs deployment.
Task-number: QTCREATORBUG-6017
Change-Id: Ib7e3814c88ad4598e897a0c99103eafb61846eeb
Reviewed-on: http://codereview.qt.nokia.com/4365
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Christian Kandeler [Wed, 7 Sep 2011 13:43:11 +0000 (15:43 +0200)]
RemoteLinux: It's not a fatal error when ports gathering fails.
Change-Id: If803e1acaaa8164a5177fa5ca227516cc06c577c
Reviewed-on: http://codereview.qt.nokia.com/4364
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Thomas Hartmann [Wed, 7 Sep 2011 12:33:42 +0000 (14:33 +0200)]
QmlDesigner: changing the path of plugins
This patch changes the path of QmlDesigner specific plugins on Linux
and Windows.
The path is changed from lib/qmldesigner to lib/qtcreator/qmldesigner.
The plugins use the same plugindestdir.pri now.
Task-number: QTCREATORBUG-5222
Change-Id: I12e874c8501dc7546f924cec950f29b55a837c88
Reviewed-on: http://codereview.qt.nokia.com/4356
Reviewed-by: Marco Bubke <marco.bubke@nokia.com>
Christian Kandeler [Wed, 7 Sep 2011 13:06:51 +0000 (15:06 +0200)]
RemoteLinux: Deploy tarball to /tmp.
Home directories might be at non-standard locations on embedded Linux
systems.
Task-number: QTCREATORBUG-5916
Change-Id: I9988c9accc91c90e9b950b74460d48aacd18da28
Reviewed-on: http://codereview.qt.nokia.com/4362
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Christian Kandeler [Wed, 7 Sep 2011 12:57:35 +0000 (14:57 +0200)]
RemoteLinux: Remove unused class member.
Change-Id: Ifdd99c320253774f1c3938188ef1bc103c1638b4
Reviewed-on: http://codereview.qt.nokia.com/4361
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Leandro Melo [Wed, 7 Sep 2011 12:02:31 +0000 (14:02 +0200)]
Code assist: Fix memory leak in completion
One fix is in the runner, which is part of the completion
engine itself. The other is specific for C++.
Task-number: QTCREATORBUG-5947
Change-Id: Ib8fff1eb5adad1ffb2a11da66c50b545e1457df8
Reviewed-on: http://codereview.qt.nokia.com/4355
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Christian Kandeler [Tue, 6 Sep 2011 14:15:58 +0000 (16:15 +0200)]
ProjectExplorer: Make RunConfiguration::fromMap() public.
Callers might want to use it polymorphically, e.g. in the restore()
method of a factory that can create more than run configuration.
Change-Id: I773f7b5d75fb6f9ad007cdafc0cf0b56e5f8da8b
Reviewed-on: http://codereview.qt.nokia.com/4266
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Daniel Teske [Wed, 7 Sep 2011 09:52:04 +0000 (11:52 +0200)]
Export Qt4PriFileNode
Change-Id: I4e6dd89a8ddd95aa21ebf5555c05349f541bd83e
Reviewed-on: http://codereview.qt.nokia.com/4335
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Daniel Teske [Tue, 6 Sep 2011 15:21:51 +0000 (17:21 +0200)]
Add Qt4PriFileNode::subProjectNodesExact which uses the exact parse
Change-Id: Ic6b8dedbc31830295e3dccea82c5f6514840dc57
Reviewed-on: http://codereview.qt.nokia.com/4282
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Tobias Hunger [Tue, 6 Sep 2011 15:12:14 +0000 (15:12 +0000)]
Remove unnecessary virtual keywords
Change-Id: I8f75bad07959a8d80ddf1c9245b89c1cc977ce61
Reviewed-on: http://codereview.qt.nokia.com/4280
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Tobias Hunger [Tue, 6 Sep 2011 14:24:13 +0000 (14:24 +0000)]
Abi: Add isNull() method
Change-Id: If8d6e5ace13857e4435b09e47d5d40dd2befdacf
Reviewed-on: http://codereview.qt.nokia.com/4279
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 07:26:46 +0000 (09:26 +0200)]
QmlJS parser: Fix else token in IfStatement.
Change-Id: Id994a9c5777021e3dc5027776df42234441440d8
Reviewed-on: http://codereview.qt.nokia.com/4319
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Christian Kamm [Wed, 7 Sep 2011 06:45:01 +0000 (08:45 +0200)]
C++: Improve Literal::hashCode.
This can have a dramatic impact on performance when a file contains lots
of unique literals.
Change-Id: I5309b28f704d7f53e164dc8084ae08354c09354b
Reviewed-on: http://codereview.qt.nokia.com/4312
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Christian Kandeler [Wed, 7 Sep 2011 07:07:41 +0000 (09:07 +0200)]
RemoteLinux: Make incremental deployment configurable...
...for the direct upload step.
Change-Id: I369963556f0c72b692b802b30a0e43c03b8b2397
Reviewed-on: http://codereview.qt.nokia.com/4315
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Eike Ziller [Tue, 6 Sep 2011 11:03:15 +0000 (13:03 +0200)]
Refactor the search result widget to its own class.
To be used for switching between multiple search result lists.
Change-Id: I4cf62f7e5adf71bac7d4fdfed05d74cea4f3ca44
Rubber-stamped-by: Daniel Teske
Reviewed-on: http://codereview.qt.nokia.com/4255
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Christian Kamm [Tue, 6 Sep 2011 10:59:30 +0000 (12:59 +0200)]
QmlJS checks: Warn about inappropriate use of constructor functions.
Change-Id: Iaedaaa88915f2010bfdd0d2b5ca95f01f8663ed7
Reviewed-on: http://codereview.qt.nokia.com/4254
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Christian Kamm [Thu, 1 Sep 2011 13:04:21 +0000 (15:04 +0200)]
QmlJS: Cleanup in Check.
Evaluate supports ExpressionStatements now.
Change-Id: I74c440fe0abf27c3d3b41b7d28a69fdd9359fb2e
Reviewed-on: http://codereview.qt.nokia.com/4080
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
Marco Bubke [Tue, 6 Sep 2011 15:50:56 +0000 (17:50 +0200)]
QmlDesigner.NodeInstances: Show stripes for items without content
Change-Id: I6c737616d485445d77efd8b6d73b2d8259e5120b
Reviewed-on: http://codereview.qt.nokia.com/4288
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Marco Bubke [Tue, 6 Sep 2011 15:24:27 +0000 (17:24 +0200)]
QmlDesigner.NodeInstances: Refactor isManipulatable to isChangeable
Change-Id: Icfc508e1549f4cfbcdda09b4611b2d66b4e2de1d
Reviewed-on: http://codereview.qt.nokia.com/4287
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Marco Bubke [Tue, 6 Sep 2011 15:23:25 +0000 (17:23 +0200)]
QmlDesigner.NodeInstances: Render only items with content
Change-Id: I9f17f369816763b2ac983d557d6bcaa723a28139
Reviewed-on: http://codereview.qt.nokia.com/4286
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Leandro Melo [Tue, 6 Sep 2011 14:45:47 +0000 (16:45 +0200)]
C++: Add __try, __except, and __finally to configuration
This is not really a direct mapping to the Microsoft specifc
ones, but I guess defining such macros is an acceptable solution.
Change-Id: I17a9414364ef664f2e8afa7ececc6a87f663049e
Reviewed-on: http://codereview.qt.nokia.com/4277
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@nokia.com>
Christian Stenger [Tue, 6 Sep 2011 13:32:25 +0000 (15:32 +0200)]
Corrected lookup for qmlviewer on Windows
Change-Id: I4ebb87bca34aba07ef5fd408cf5481d8cb10ecf6
Reviewed-on: http://codereview.qt.nokia.com/4264
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
Eike Ziller [Fri, 2 Sep 2011 09:51:31 +0000 (11:51 +0200)]
Move and cleanup search specific API to SearchResult class
Change-Id: I7e64701e8833ad38b9ac01d316bd00302602a390
Rubber-stamped-by: Daniel Teske
Reviewed-on: http://codereview.qt.nokia.com/4179
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Christian Kandeler [Tue, 6 Sep 2011 14:14:17 +0000 (16:14 +0200)]
RemoteLinux: Give default value to constructor argument.
Change-Id: I39d5994d3a8ccad29f462f04eeff2ce9b6ef9566
Reviewed-on: http://codereview.qt.nokia.com/4265
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Leandro Melo [Tue, 6 Sep 2011 09:50:58 +0000 (11:50 +0200)]
C++: More flexibility for string representation of macros
It's now possible to get the macro definition with the actual
line breaks used on the code. This is particularly useful for
tooltips in order for them to look nice.
The preprocessor is changed so the macro also stores the breaks
positions. This doesn't seem to have any impact on performance.
In my machine, for example, the total time for parsing Creator's
source code is approx. 18100ms with or without the patch.
Change-Id: Ic7487236315c3567d26496315accdb2adfea894a
Reviewed-on: http://codereview.qt.nokia.com/4253
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Leandro Melo [Tue, 6 Sep 2011 09:28:47 +0000 (11:28 +0200)]
C++: Normalize line ending for preprocessing
There is logic in the preprocessor that assumes a normalized line
ending. Other patches have already fixed the issue in other parts.
Change-Id: Iac262da361b6528cc9466a6c87e83da95af9ea04
Reviewed-on: http://codereview.qt.nokia.com/4252
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
Kai Koehne [Mon, 5 Sep 2011 12:07:27 +0000 (14:07 +0200)]
QmlProfilerTool: Fix hang on exit
the reader thread has to terminate on its own, terminate
is not reliable.
Change-Id: I4222bc8f0c585c190cd90efbaade0b03ca698ec7
Reviewed-on: http://codereview.qt.nokia.com/4194
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
Kai Koehne [Mon, 5 Sep 2011 10:49:54 +0000 (12:49 +0200)]
QmlProfilerTool: Fix help text
Make sure it fits 80 columns.
Change-Id: I52eea0e79be33ae7b546fbca6b7e07e1d78d2a94
Reviewed-on: http://codereview.qt.nokia.com/4191
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>