OSDN Git Service
Sunny Goyal [Tue, 8 Dec 2015 21:52:39 +0000 (21:52 +0000)]
Merge "Moving DB creation to background thread" into ub-launcher3-master
Sunny Goyal [Tue, 8 Dec 2015 21:47:09 +0000 (21:47 +0000)]
Merge "Verifying the install shortcut intent before casting the extras to various object types" into ub-launcher3-burnaby-polish
am:
06538a7784
* commit '
06538a778485e920a651bf662a90c6a5dc3b0218':
Verifying the install shortcut intent before casting the extras to various object types
Sunny Goyal [Tue, 8 Dec 2015 21:43:10 +0000 (21:43 +0000)]
Merge "Verifying the install shortcut intent before casting the extras to various object types" into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 29 Oct 2015 17:28:32 +0000 (10:28 -0700)]
Moving DB creation to background thread
Change-Id: I5404edd8df7160108c230d245f34bf8e24173619
Sunny Goyal [Tue, 8 Dec 2015 20:56:53 +0000 (20:56 +0000)]
Recreating QSB when the widget host gets reset
am:
655daaed3e
* commit '
655daaed3ef8a68deaae5f72acbc1fc444cc54d6':
Recreating QSB when the widget host gets reset
Sunny Goyal [Tue, 8 Dec 2015 17:28:23 +0000 (09:28 -0800)]
Recreating QSB when the widget host gets reset
Bug:
25073414
Change-Id: Ibdaa2b330ef7989cb7c93d64a05c8f6e5b26594a
Tony Wickham [Tue, 8 Dec 2015 02:40:37 +0000 (02:40 +0000)]
Merge "Added an instrumentation test case for quickly adding a widget." into ub-launcher3-burnaby-polish
am:
d42f97ee07
* commit '
d42f97ee070f508216763ba3c45c8004866bc1ec':
Added an instrumentation test case for quickly adding a widget.
Tony Wickham [Tue, 8 Dec 2015 02:36:54 +0000 (02:36 +0000)]
Merge "Added an instrumentation test case for quickly adding a widget." into ub-launcher3-burnaby-polish
Sunny Goyal [Tue, 8 Dec 2015 01:48:59 +0000 (01:48 +0000)]
Merge "Adding FeatureFlags.java file to aggregate various feature definitions" into ub-launcher3-burnaby-polish
am:
f3b13b55df
* commit '
f3b13b55df44ff23fdb184cd467dfd2b6d89074f':
Adding FeatureFlags.java file to aggregate various feature definitions
Sunny Goyal [Tue, 8 Dec 2015 01:44:40 +0000 (01:44 +0000)]
Merge "Adding FeatureFlags.java file to aggregate various feature definitions" into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 7 Dec 2015 23:00:24 +0000 (15:00 -0800)]
Adding FeatureFlags.java file to aggregate various feature definitions
Change-Id: I52d04ab979329d1afd42fd74ec0a533dd819fd23
Sunny Goyal [Mon, 7 Dec 2015 22:51:23 +0000 (14:51 -0800)]
Verifying the install shortcut intent before casting the extras to various object types
Bug:
26043109
Change-Id: I95f127d62a6a508a850e11d6728afc7509fb07d1
Tony Wickham [Thu, 3 Dec 2015 01:55:07 +0000 (17:55 -0800)]
Added config_springLoadWorkspace to enable/disable spring-loaded workspace.
- Added side hints back
- Only scale down icons if spring-loaded
- Only show App Info drop target if spring-loaded
Change-Id: I4b0dddccbe0e80b7ceb6b7266fc527f757744148
Tony Wickham [Fri, 4 Dec 2015 22:21:19 +0000 (14:21 -0800)]
Merge "Add appropriate (tiny) offset to widget drops so they land correctly." into ub-launcher3-burnaby-polish
am:
8db5d7ca60
* commit '
8db5d7ca60e79f007bfce7952c15c74d0ee44bc0':
Add appropriate (tiny) offset to widget drops so they land correctly.
Tony Wickham [Fri, 4 Dec 2015 22:14:36 +0000 (22:14 +0000)]
Merge "Add appropriate (tiny) offset to widget drops so they land correctly." into ub-launcher3-burnaby-polish
Tony [Sun, 18 Oct 2015 22:01:32 +0000 (15:01 -0700)]
Added an instrumentation test case for quickly adding a widget.
This would have caught the race condition bugs that caused the "specified child
already has a parent" IllegalStateException (bug
23896857).
Change-Id: I3b408d21113237b0c89a0a7161f504596212bd58
Tony Wickham [Fri, 4 Dec 2015 18:33:51 +0000 (18:33 +0000)]
Merge "Increase spacing between icons in All Apps on tablets." into ub-launcher3-burnaby-polish
am:
bcec69525d
* commit '
bcec69525d8c4c64258f930608ab4e437368c058':
Increase spacing between icons in All Apps on tablets.
Tony Wickham [Fri, 4 Dec 2015 18:30:09 +0000 (18:30 +0000)]
Merge "Increase spacing between icons in All Apps on tablets." into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 4 Dec 2015 18:04:54 +0000 (10:04 -0800)]
resolve merge conflicts of
39b700fcc5 to ub-launcher3-
Change-Id: I394258be0c75289cab2f5141c0fb765504527420
Tony Wickham [Fri, 4 Dec 2015 18:01:51 +0000 (18:01 +0000)]
Merge "Cleanup keyboard code." into ub-launcher3-burnaby-polish
am:
b88d0bccbe
* commit '
b88d0bccbe997e5c45c930698e37f52865bd9210':
Cleanup keyboard code.
Sunny Goyal [Fri, 4 Dec 2015 17:56:04 +0000 (17:56 +0000)]
Merge "Normalizing app icons based on the standard icon guidelines" into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 4 Dec 2015 17:55:33 +0000 (17:55 +0000)]
Merge "Cleanup keyboard code." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 4 Dec 2015 17:48:17 +0000 (09:48 -0800)]
Cleanup keyboard code.
This should be the last keyboard CL.
- Fix bug: couldn't focus All Apps button in some cases when the All
Apps column was skipped over. Also added test case for this.
- Stop explicitly passing countX and countY to handleKeyEvent, as
these had to match the matrix dimensions anyways.
- Rename createSparseMatrix() - there were 3 methods of the same name,
but all had different purposes. This is confusing both from a
readability standpoint and also when looking at stack traces.
Change-Id: I08ba8411674fcea43a608856c114dee8dbd22398
Tony Wickham [Thu, 3 Dec 2015 22:52:03 +0000 (22:52 +0000)]
Hide the focus indicator view when going to a fullscreen page.
am:
62b9b6054e
* commit '
62b9b6054e46074f57ccf156a8663b4392cd82d9':
Hide the focus indicator view when going to a fullscreen page.
Tony Wickham [Wed, 18 Nov 2015 18:56:35 +0000 (10:56 -0800)]
Hide the focus indicator view when going to a fullscreen page.
Bug:
25649853
Change-Id: I9f2f221020548b48d816924a1803a1a70d11c412
Tony Wickham [Thu, 3 Dec 2015 22:34:43 +0000 (22:34 +0000)]
Fullscreen pages (e.g. Now) are focusable via keyboard.
am:
0fa5ada226
* commit '
0fa5ada2261a29ad9be7195c8cdb8cb50bdd0742':
Fullscreen pages (e.g. Now) are focusable via keyboard.
Tony Wickham [Sat, 14 Nov 2015 01:32:20 +0000 (17:32 -0800)]
Fullscreen pages (e.g. Now) are focusable via keyboard.
Change-Id: I962551651aeb9ac7b57bb51b195adc3140db30d8
Tony Wickham [Thu, 3 Dec 2015 22:23:11 +0000 (22:23 +0000)]
Make sure pages are always accessible via left/right arrow keys.
am:
af78b59af1
* commit '
af78b59af19264105b8ce856defa5342d6fd584a':
Make sure pages are always accessible via left/right arrow keys.
Tony Wickham [Wed, 11 Nov 2015 17:25:38 +0000 (09:25 -0800)]
Make sure pages are always accessible via left/right arrow keys.
- Handle NextPageFirstItem as first focusable item in reading order
- Handle PreviousPageLastItem as last focusable item in reading order
- Check the hotseat after the workspace in both cases above
- Dpad horizontal navigation (left/right) uses these as a last
resort (Rule3) to guarantee an item takes focus if a page exists
Note that it is necessary to search for a focusable item because
widgets are not yet focusable.
Bug:
25591057
Change-Id: I953648bd76c657d660a38427fdd4108bf9963c23
Tony Wickham [Thu, 3 Dec 2015 20:45:25 +0000 (20:45 +0000)]
Merge "Add special column for All Apps button in FocusLogic\'s sparse matrix." into ub-launcher3-burnaby-polish
am:
b879abd274
* commit '
b879abd2747c1c1473c8d2b9d9c97707da8218f3':
Add special column for All Apps button in FocusLogic's sparse matrix.
Tony Wickham [Thu, 3 Dec 2015 20:41:28 +0000 (20:41 +0000)]
Merge "Add special column for All Apps button in FocusLogic's sparse matrix." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 4 Nov 2015 02:05:01 +0000 (18:05 -0800)]
Add appropriate (tiny) offset to widget drops so they land correctly.
Also removed some unused parameters I found on the way.
Bug:
25191623
Change-Id: Ib9a30db106467c114cc8b54a5b13ed3e88162d56
Sunny Goyal [Thu, 17 Sep 2015 21:59:10 +0000 (14:59 -0700)]
Normalizing app icons based on the standard icon guidelines
Bug:
18245189
Change-Id: Iaadcddbe3f966733a13b2e1fb60ba09a8b3aef9a
Sunny Goyal [Thu, 3 Dec 2015 03:32:07 +0000 (19:32 -0800)]
resolve merge conflicts of
aa4011e63e to ub-launcher3-
Change-Id: Id91f5c3be2678ca05cd51aa72bb6a25112afb020
Sunny Goyal [Thu, 3 Dec 2015 03:25:21 +0000 (03:25 +0000)]
Merge "Scaling down the icon before applying the user badge > This also saves memory only create one new bitmap while loading instead of two" into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 2 Dec 2015 23:18:22 +0000 (23:18 +0000)]
Merge "Disallow scrolling if workspace is in transition." into ub-launcher3-burnaby-polish
am:
ac929f4ad8
* commit '
ac929f4ad80fabeddfae51e30ec5d7ff434652c8':
Disallow scrolling if workspace is in transition.
Tony Wickham [Wed, 2 Dec 2015 23:11:09 +0000 (23:11 +0000)]
Merge "Disallow scrolling if workspace is in transition." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 2 Dec 2015 21:37:07 +0000 (13:37 -0800)]
Increase spacing between icons in All Apps on tablets.
Change-Id: If90332098f749295da07f4faca707a7a6965666b
Sunny Goyal [Tue, 1 Dec 2015 23:36:37 +0000 (23:36 +0000)]
Merge "Keeping the focus indicator on the widget view, while a child is focused" into ub-launcher3-burnaby-polish
am:
093a58cc77
* commit '
093a58cc776be2a3cd5aed9d14df9c78a35af052':
Keeping the focus indicator on the widget view, while a child is focused
Sunny Goyal [Tue, 1 Dec 2015 23:19:11 +0000 (23:19 +0000)]
Merge "Keeping the focus indicator on the widget view, while a child is focused" into ub-launcher3-burnaby-polish
Sunny Goyal [Tue, 1 Dec 2015 22:49:42 +0000 (22:49 +0000)]
Adding margin to Drag layer instead of checking for right insets at every place
am:
9326461652
* commit '
9326461652c36c2ddd888d1452cf7f075a391868':
Adding margin to Drag layer instead of checking for right insets at every place
Sunny Goyal [Mon, 23 Nov 2015 19:47:50 +0000 (11:47 -0800)]
Adding margin to Drag layer instead of checking for right insets at every place
Bug:
25692432
Change-Id: I853f41a17c54b30b7772b9fd8556d9465de84752
Sunny Goyal [Tue, 1 Dec 2015 21:21:49 +0000 (13:21 -0800)]
Keeping the focus indicator on the widget view, while a child is focused
Bug:
25199581
Change-Id: Ie08d1438ae0c1b5d4fcaa4d642508c1b9db0f5d4
Sunny Goyal [Mon, 30 Nov 2015 18:19:02 +0000 (10:19 -0800)]
resolve merge conflicts of
0c2f0700a5 to ub-launcher3-
Change-Id: I92f38e9f4ac4d9b6c5a3000e0971d2bc417bd3c6
Sunny Goyal [Tue, 24 Nov 2015 18:16:37 +0000 (10:16 -0800)]
Only fetching firstInstallTime for an activity when required
Change-Id: Ia16c05718938849f4250802d8770ddfe6dbef055
Sunny Goyal [Mon, 19 Oct 2015 21:03:30 +0000 (14:03 -0700)]
Scaling down the icon before applying the user badge
> This also saves memory only create one new bitmap while loading instead of two
Bug:
25027252
Change-Id: Ia594dd65a30f32e99404190f649b334615c9e17f
Sunny Goyal [Wed, 25 Nov 2015 18:15:56 +0000 (18:15 +0000)]
Merge "Allowing widgets to be focusable" into ub-launcher3-burnaby-polish
am:
d007d0722c
* commit '
d007d0722c782266f494806e750c24208d6d3ca5':
Allowing widgets to be focusable
Sunny Goyal [Wed, 25 Nov 2015 18:10:56 +0000 (18:10 +0000)]
Merge "Allowing widgets to be focusable" into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 25 Nov 2015 00:06:14 +0000 (00:06 +0000)]
Merge "Skip to the end of the folder open animation in battery saver mode." into ub-launcher3-burnaby-polish
am:
6e83dc4031
* commit '
6e83dc4031b78ac6e65102b2d936e9e769686fec':
Skip to the end of the folder open animation in battery saver mode.
Tony Wickham [Wed, 25 Nov 2015 00:06:08 +0000 (00:06 +0000)]
Don\'t let folder be replaced with final item twice.
am:
1a690cb785
* commit '
1a690cb785a1b1644ad4c97e8b755528b2222cfc':
Don't let folder be replaced with final item twice.
Tony Wickham [Wed, 25 Nov 2015 00:02:12 +0000 (00:02 +0000)]
Merge "Skip to the end of the folder open animation in battery saver mode." into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 24 Nov 2015 23:34:53 +0000 (15:34 -0800)]
Don't let folder be replaced with final item twice.
Bug:
25732317
Change-Id: I77b3ddc8951583bebfb908fda934c9b80ddebce0
Sunny Goyal [Tue, 24 Nov 2015 21:12:32 +0000 (13:12 -0800)]
resolve merge conflicts of
7bce5f7988 to ub-launcher3-
Change-Id: Id352ce219bed7701956bb462ea2dd0a5aebe7317
Sunny Goyal [Tue, 24 Nov 2015 19:40:40 +0000 (11:40 -0800)]
Tying LauncherAppState lifecycle with LauncherProvider
The content provider is the first component started with the main process,
which makes it ideal for initiating LauncherAppState
Change-Id: I03db82a8949ad1376af53a0033592f421dbf0b15
Sunny Goyal [Mon, 23 Nov 2015 18:48:37 +0000 (18:48 +0000)]
Merge "Setting statusbar and nav bar colors in theme instead of code" into ub-launcher3-burnaby-polish
am:
4ee66259eb
* commit '
4ee66259eb7835bfcf3747596e068319e1e3c677':
Setting statusbar and nav bar colors in theme instead of code
Tony Wickham [Mon, 23 Nov 2015 18:48:28 +0000 (18:48 +0000)]
Merge "Focus doesn\'t leave folders without also closing them." into ub-launcher3-burnaby-polish
am:
298f1c4578
* commit '
298f1c4578e45168e74aa4b8561fcd88bfe509fe':
Focus doesn't leave folders without also closing them.
Sunny Goyal [Mon, 23 Nov 2015 18:45:41 +0000 (18:45 +0000)]
Merge "Setting statusbar and nav bar colors in theme instead of code" into ub-launcher3-burnaby-polish
Tony Wickham [Mon, 23 Nov 2015 18:43:21 +0000 (18:43 +0000)]
Merge "Focus doesn't leave folders without also closing them." into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 17 Nov 2015 18:46:48 +0000 (10:46 -0800)]
Focus doesn't leave folders without also closing them.
- Pressing Tab wraps around to the first item from the folder name,
and vice versa when pressing Shift+Tab.
- When tapping off the folder while editing the text, the folder
requests focus. We handle the following cases from that state:
- Pressing an arrow key or Tab gives focus to the first item.
- Pressing Shift+Tab gives focus to the last item.
- Fix slight corner case where moving from folder name to an item
didn't update mIsEditingName to false. So when clicking off of
the folder, it gave focus to the folder (as mentioned above)
instead of closing the folder like it usually does when icons are
focused. Not a huge deal, but still worth fixing.
Bug:
25687579
Change-Id: I1bec844c8ccd09529a11b9e3a1d92b3bdf7b2eb3
Tony Wickham [Thu, 19 Nov 2015 20:45:30 +0000 (12:45 -0800)]
Disallow scrolling if workspace is in transition.
Because going to overview mode scales down the workspace, it was
thinking the touch was moving even though your finger was still. If
the "movement" was large enough, it was treated as a scroll, causing
jank. This was especially prevalent on tablets due to their size.
Bug:
25779718
Change-Id: Idb7833e0087bd24ca840f6afc451bf221f6bc047
Tony Wickham [Thu, 19 Nov 2015 00:47:26 +0000 (00:47 +0000)]
Merge "Stop requesting focus on folder if it was closed without animating." into ub-launcher3-burnaby-polish
am:
55bd16bfdc
* commit '
55bd16bfdce57772691519fb894b95c7f088846e':
Stop requesting focus on folder if it was closed without animating.
Tony Wickham [Thu, 19 Nov 2015 00:36:20 +0000 (00:36 +0000)]
Merge "Stop requesting focus on folder if it was closed without animating." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 18 Nov 2015 19:59:19 +0000 (19:59 +0000)]
Merge "Handle errors gracefully in WallpaperCropActivity." into ub-launcher3-burnaby-polish
am:
0151ff1683
* commit '
0151ff168368883301e84c7d1f790c9f2721e459':
Handle errors gracefully in WallpaperCropActivity.
Tony Wickham [Wed, 18 Nov 2015 19:51:55 +0000 (19:51 +0000)]
Merge "Handle errors gracefully in WallpaperCropActivity." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 4 Nov 2015 23:01:54 +0000 (15:01 -0800)]
Handle errors gracefully in WallpaperCropActivity.
(cherry picked from commit
c984cde00840d8594a8b203748cb6e4f9967fd7c)
Now instead of crashing, it says "Couldn't load image."
Bug:
25326319
Bug:
25656670
Change-Id: I71471f4b26f7c23dee40b60772ddd798f67b409e
Tony Wickham [Wed, 18 Nov 2015 01:59:26 +0000 (17:59 -0800)]
Stop requesting focus on folder if it was closed without animating.
Bug:
25092436
Change-Id: Ia6b72ec8c9fa02fc159457b81fef12f6fd394769
Sunny Goyal [Mon, 16 Nov 2015 04:47:01 +0000 (04:47 +0000)]
Fixing crash when uninstalling an app destroys the folder
am:
b9c29d455e
* commit '
b9c29d455e301d1b31b911a37eb3bec7e0e16865':
Fixing crash when uninstalling an app destroys the folder
Sunny Goyal [Sat, 14 Nov 2015 12:39:20 +0000 (18:09 +0530)]
Fixing crash when uninstalling an app destroys the folder
Bug:
25666490
Bug:
25677822
Change-Id: Id71c04df0a5546ba95239ba2e3f7aabb697375a4
Tony Wickham [Fri, 13 Nov 2015 18:10:57 +0000 (18:10 +0000)]
Revert "Revert "Reverting folder cell width on portrait phones.""
am:
6159c242bc
* commit '
6159c242bc610f13e4c7550ae8b15f25603f4b23':
Revert "Revert "Reverting folder cell width on portrait phones.""
Tony Wickham [Fri, 13 Nov 2015 18:07:18 +0000 (18:07 +0000)]
Revert "Revert "Reverting folder cell width on portrait phones.""
This reverts commit
1974e98f5ec4713e50ba64ec32a7607c92ddce9b.
Change-Id: I7c5d86de187989c085f676933ce3f1cbd57ed8a7
Tony Wickham [Thu, 12 Nov 2015 23:52:34 +0000 (23:52 +0000)]
Revert "Reverting folder cell width on portrait phones."
am:
1974e98f5e
* commit '
1974e98f5ec4713e50ba64ec32a7607c92ddce9b':
Revert "Reverting folder cell width on portrait phones."
Tony Wickham [Thu, 12 Nov 2015 23:46:33 +0000 (23:46 +0000)]
Revert "Reverting folder cell width on portrait phones."
This reverts commit
b25e684a766362422f5693f7a2189910c1275584.
Change-Id: Ie86adc4b35c73ab7ef78d73225b437adc4751172
Tony Wickham [Thu, 12 Nov 2015 23:41:06 +0000 (23:41 +0000)]
Reverting folder cell width on portrait phones.
am:
b25e684a76
* commit '
b25e684a766362422f5693f7a2189910c1275584':
Reverting folder cell width on portrait phones.
Tony Wickham [Thu, 12 Nov 2015 21:12:06 +0000 (13:12 -0800)]
Reverting folder cell width on portrait phones.
The extra folder cell space added in ag/790800 looks bad on phones in
portrait mode, so reverting it here. However, we keep the extra space
on tablets or phones in landscape mode, since it provides more room
for long app names (bug
22462641).
Bug:
25662215
Change-Id: I2a37b884458ee557c9b8cff0c3edef16bfc50efb
Tony Wickham [Thu, 12 Nov 2015 20:31:50 +0000 (12:31 -0800)]
Skip to the end of the folder open animation in battery saver mode.
Bug:
25666809
Change-Id: I867d56a34fc5e0ad6aaabd8b6df47be05ec31966
Tony Wickham [Wed, 11 Nov 2015 17:19:53 +0000 (17:19 +0000)]
Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish
am:
a43f78fc4b
* commit '
a43f78fc4b70bf54b9c90758660b6155ef0257aa':
Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
Tony Wickham [Wed, 11 Nov 2015 17:19:07 +0000 (17:19 +0000)]
Merge "Play common transition animations from a common method." into ub-launcher3-master
Tony Wickham [Wed, 11 Nov 2015 17:16:14 +0000 (17:16 +0000)]
Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 11 Nov 2015 00:52:14 +0000 (16:52 -0800)]
Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
The first of these cases seems like they should already have been
present, and the last couple allow you to switch pages by hitting
arrow keys on the edges of the hotseat.
Bug:
25589939
Change-Id: I9378b209250f7dc376fa97efde979bcee2979537
Tony Wickham [Tue, 10 Nov 2015 23:38:00 +0000 (23:38 +0000)]
Don\'t add offset to CellLayout\'s fullscreen children.
am:
26b0142543
* commit '
26b01425436277447fe24d01ad50d9e64f82109e':
Don't add offset to CellLayout's fullscreen children.
Tony Wickham [Tue, 10 Nov 2015 22:44:32 +0000 (14:44 -0800)]
Don't add offset to CellLayout's fullscreen children.
Bug:
25411084
Change-Id: Ifbcd0a53cf04a7fc29386f4f09aaf7f972e7354a
Tony Wickham [Tue, 10 Nov 2015 01:51:08 +0000 (17:51 -0800)]
Add special column for All Apps button in FocusLogic's sparse matrix.
The All Apps button creates a number of edge cases, mainly because it
causes the hotseat to sometimes have an extra column than the workspace.
Previously, we sort of swept these problems under the rug by simply
ignoring the All Apps button if other icons were present in the hotseat,
with the assumption that those other icons should get focus instead of
the All Apps button. (If possible, we want to stay in the same column
when moving from the workspace to the hotseat.) But this doesn't always
work, as in the attached bug where the hotseat doesn't get focus at all
when the All Apps button is an obvious candidate for it.
By adding a specialized column in the focus matrix for the All Apps
button, we ensure that moving down to the hotseat stays within the
original column when possible, while also allowing the focus to switch
to the All Apps button if appropriate. Furthermore, we take care to skip
over the All Apps column when necessary in order to maintain all
previous functionality.
Bug:
25590522
Change-Id: I5d6a8ee69de8834314c4689246fe7d54329b2eef
Tony Wickham [Sat, 7 Nov 2015 01:31:18 +0000 (01:31 +0000)]
Added unit tests for b/
25434120 regression.
am:
3cfa97d4c1
* commit '
3cfa97d4c14fa4af3ee3613e44ba7b7128141e31':
Added unit tests for b/
25434120 regression.
Tony Wickham [Sat, 7 Nov 2015 01:08:57 +0000 (17:08 -0800)]
Added unit tests for b/
25434120 regression.
Change-Id: I55b10274c4bb63ec6fd3138236e78a04e3eac91a
Tony Wickham [Fri, 6 Nov 2015 18:11:49 +0000 (18:11 +0000)]
Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish
am:
0e2f3849b8
* commit '
0e2f3849b84f59ed7c1c4336ca01ac17f096e265':
Make sure user can always get to next page with keyboard.
Tony Wickham [Fri, 6 Nov 2015 18:11:43 +0000 (18:11 +0000)]
Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish
am:
0f6f2b181f
* commit '
0f6f2b181fcf28887b343226cef3b263a65621cd':
Stop explicitly snapping to page when navigating with keyboard.
Tony Wickham [Fri, 6 Nov 2015 18:10:05 +0000 (18:10 +0000)]
Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 6 Nov 2015 18:08:44 +0000 (18:08 +0000)]
Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 6 Nov 2015 02:29:49 +0000 (02:29 +0000)]
Ignoring DeadObjectException in startListening
am:
1b323794f2
* commit '
1b323794f2f6443b9142ee613e5851a096f19fd6':
Ignoring DeadObjectException in startListening
Tony Wickham [Thu, 5 Nov 2015 20:14:26 +0000 (12:14 -0800)]
Make sure user can always get to next page with keyboard.
There's a case where hitting the left/right arrow in the first/last
column wouldn't give focus to an icon on the next page because it is
vertically too far from the first icon to be considered. This makes
for a bad user experience, because there is no way to switch pages
with the keyboard. So now we brute-force search for an appropriate
icon if none was found in this case.
Bug:
25434120
Change-Id: Ifdead0e3b458717ccb33e2f0ec7c15f1fcce4b95
Sunny Goyal [Thu, 5 Nov 2015 10:39:57 +0000 (16:09 +0530)]
Ignoring DeadObjectException in startListening
> As of android M, the platform somtimes throws DeadObjectException
instead of TransactionTooLargeException
Bug:
25305031
Change-Id: I3a98db8a5041aef01640d16f9beb71b72bf598f1
Tony Wickham [Thu, 5 Nov 2015 01:44:32 +0000 (17:44 -0800)]
Stop explicitly snapping to page when navigating with keyboard.
When an icon grabs focus, it already snaps to its own page, so
the explicit snapToPage() is redundant. And in the case where no icon
will grab the focus, the explicit call puts us in a weird state
because the page snaps but the focus doesn't change (see bug).
(This happens, for instance, if you are moving from an icon on the
bottom right of page 1 and the only icon on page 2 is in the top
left. In this case, the second icon won't take focus because the
angle is too wide according to FocusLogic#handleDpadHorizontal().)
Bug:
25434120
Change-Id: I17b0ef7d86426a2599bc948bf2313dca7e112364
Tony Wickham [Wed, 4 Nov 2015 23:01:54 +0000 (15:01 -0800)]
Handle OutOfMemoryException gracefully in WallpaperCropActivity.
Now instead of crashing, it says "Couldn't load image."
Bug:
25326319
Change-Id: I6918b7b34e0a9b40036b1405fc449c10c2e1d40a
Tony Wickham [Tue, 3 Nov 2015 22:07:57 +0000 (22:07 +0000)]
Stop clearing focus when snapping to a new workspace page.
am:
04e2c9ef56
* commit '
04e2c9ef5663262fc9dd08ffc4b59fe305a017f3':
Stop clearing focus when snapping to a new workspace page.
Yohei Yukawa [Sat, 31 Oct 2015 01:54:58 +0000 (18:54 -0700)]
Enable selection action mode for Android M+.
Since I62963d225e6ea5d2ec9d8ebc8a6d73099f5d6c7f, we have disabled
selection action mode in the folder-name editing mode on Launcher,
mainly because it messed up the view on phones. However that is no
longer the case in Android M and later, where floating action mode
is available.
With this CL, we start relying on the default floating action mode
in Android M and later.
Bug:
22210697
Change-Id: Ie19e7844194acd86cdb013254a1923f0b1d78e11
Tony Wickham [Sat, 31 Oct 2015 01:04:48 +0000 (18:04 -0700)]
Stop clearing focus when snapping to a new workspace page.
Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.
Bug:
25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
Tony Wickham [Fri, 30 Oct 2015 18:48:11 +0000 (18:48 +0000)]
Merge "resolve merge conflicts of
4530aca912 to ub-launcher3-" into ub-launcher3-master
Tony Wickham [Fri, 30 Oct 2015 18:03:51 +0000 (11:03 -0700)]
Added Gravity.CENTER_HORIZONTAL to drop target layout params.
I'm not sure if it is strictly necessary, but it is probably good to
be more explicit regardless.
Change-Id: Ib7647dbcb5449e22ef87da8d49b4e7804ba5c17f
Tony Wickham [Fri, 30 Oct 2015 18:09:44 +0000 (11:09 -0700)]
resolve merge conflicts of
4530aca912 to ub-launcher3-
Change-Id: I55a0cd751cbcce8fcc8efa23a0a88a01ec08522b
Tony Wickham [Fri, 30 Oct 2015 17:37:43 +0000 (10:37 -0700)]
resolve merge conflicts of
a3c74d10a7 to ub-launcher3-
Change-Id: Ibeb2499ac278e4094a2922501cfffad2489e58ed