OSDN Git Service

pg-rex/syncrep.git
21 years agopg_resetxlog was missing support for the pg_control fields added in 7.3.
Tom Lane [Wed, 2 Oct 2002 19:45:47 +0000 (19:45 +0000)]
pg_resetxlog was missing support for the pg_control fields added in 7.3.

21 years agoAlter scale selection for NUMERIC division and transcendental functions
Tom Lane [Wed, 2 Oct 2002 19:21:26 +0000 (19:21 +0000)]
Alter scale selection for NUMERIC division and transcendental functions
so that precision of result is always at least as good as you'd get from
float8 arithmetic (ie, always at least 16 digits of accuracy).  Per
pg_hackers discussion a few days ago.

21 years agoTurn GUC log_min_error_statement off by default by setting it to PANIC.
Bruce Momjian [Wed, 2 Oct 2002 16:27:57 +0000 (16:27 +0000)]
Turn GUC log_min_error_statement off by default by setting it to PANIC.

21 years agotest files added by Kris Jurka
Dave Cramer [Tue, 1 Oct 2002 16:11:30 +0000 (16:11 +0000)]
test files added by Kris Jurka

21 years agoPass less-unsafe parameters to Darwin's NSLinkModule. While this change prevents...
Tom Lane [Tue, 1 Oct 2002 05:06:44 +0000 (05:06 +0000)]
Pass less-unsafe parameters to Darwin's NSLinkModule.  While this change prevents a backend coredump when loading a broken shlib, it also seems to suppress the error messages that might help debug the problem :-(.  Perhaps someone would like to supply a 'linkEdit' hook to get the best of both worlds.  But in the meantime, backend crash trumps error reporting.

21 years agoFixed test suite to call PoolingDataSourceTest which was missed
Barry Lind [Tue, 1 Oct 2002 04:36:00 +0000 (04:36 +0000)]
Fixed test suite to call PoolingDataSourceTest which was missed

 Modified Files:
  OptionalTestSuite.java

21 years agoApplied doc patch to jdbc doc which documents support for datasources
Barry Lind [Tue, 1 Oct 2002 04:09:13 +0000 (04:09 +0000)]
Applied doc patch to jdbc doc which documents support for datasources
patch submitted by ammulder@alumni.princeton.edu

 Modified Files:
  jdbc.sgml

21 years agoUpdate FAQ for 7.2.3 version.
Bruce Momjian [Tue, 1 Oct 2002 03:28:56 +0000 (03:28 +0000)]
Update FAQ for 7.2.3 version.

21 years agoUpdate HISTORY/release.sgml for 7.2.3.
Bruce Momjian [Tue, 1 Oct 2002 03:23:05 +0000 (03:23 +0000)]
Update HISTORY/release.sgml for 7.2.3.

21 years agoschema awareness patch provided by Kris Jurka
Dave Cramer [Tue, 1 Oct 2002 00:39:02 +0000 (00:39 +0000)]
schema awareness patch provided by Kris Jurka

21 years agoAdd Bear's SSL comments.
Bruce Momjian [Sun, 29 Sep 2002 04:06:54 +0000 (04:06 +0000)]
Add Bear's SSL comments.

21 years agoMake the world at least somewhat safe for zero-column tables, and
Tom Lane [Sat, 28 Sep 2002 20:00:19 +0000 (20:00 +0000)]
Make the world at least somewhat safe for zero-column tables, and
remove the special case in ALTER DROP COLUMN to prohibit dropping a
table's last column.

21 years agoARGH!
Tom Lane [Fri, 27 Sep 2002 20:57:08 +0000 (20:57 +0000)]
ARGH!

Vacuum must not advance pg_database.datvacuumxid nor truncate CLOG
unless it's processed *all* tables in the database.  Vacuums run by
unprivileged users don't count.

(Beats head against nearest convenient wall...)

21 years ago> Fix clusterdb to be schema-aware
Bruce Momjian [Fri, 27 Sep 2002 17:51:10 +0000 (17:51 +0000)]
> Fix clusterdb to be schema-aware

Please apply the patch attached and this should be solved.

Alvaro Herrera

21 years agoUse heap_formtuple not heap_addheader to construct pg_index tuples.
Tom Lane [Fri, 27 Sep 2002 15:05:23 +0000 (15:05 +0000)]
Use heap_formtuple not heap_addheader to construct pg_index tuples.
heap_addheader is wrong because it doesn't cope with varlena fields,
notably indpred.

21 years agoDon't mess with HEAP_XMAX_INVALID in heaptuple.c routines; there is
Tom Lane [Fri, 27 Sep 2002 15:04:08 +0000 (15:04 +0000)]
Don't mess with HEAP_XMAX_INVALID in heaptuple.c routines; there is
no reason to worry about the tuple commit status bits until the tuple
is inserted in a relation by heapam.c.  Also, improve comments for
heap_addheader().

21 years agoHave -d5 -d0 not affect the extra variables set with -d5.
Bruce Momjian [Fri, 27 Sep 2002 03:59:00 +0000 (03:59 +0000)]
Have -d5 -d0 not affect the extra variables set with -d5.

21 years agoMake postgres -d0 set server_min_messages to notice. Reset doesn't work
Bruce Momjian [Fri, 27 Sep 2002 03:34:15 +0000 (03:34 +0000)]
Make postgres -d0 set server_min_messages to notice.  Reset doesn't work
at this area in the code.

21 years agoSimplify SSL certificate instructions.
Bruce Momjian [Fri, 27 Sep 2002 02:04:39 +0000 (02:04 +0000)]
Simplify SSL certificate instructions.

21 years agoEnsure that before truncating CLOG, we force a checkpoint even if no
Tom Lane [Thu, 26 Sep 2002 22:58:34 +0000 (22:58 +0000)]
Ensure that before truncating CLOG, we force a checkpoint even if no
recent WAL activity has occurred.  Without this, it's possible that a
later crash might leave tuples on disk with un-updated commit status
bits.

21 years agoFix problems with loss of tuple commit status bits during WAL redo of
Tom Lane [Thu, 26 Sep 2002 22:46:29 +0000 (22:46 +0000)]
Fix problems with loss of tuple commit status bits during WAL redo of
VACUUM FULL tuple moves.  Store full-width t_infomask in WAL, rather
than storing low 8 bits and expecting to be able to reconstruct upper
bits.  While at it, remove redundant t_oid field from WAL headers
(the OID, if present, is now recorded in the data portion of the tuple).
WAL version number bumped --- this does not force an initdb, you can
instead run pg_resetxlog after a clean shutdown of the old postmaster.

21 years agoBack out /pl memory leak patch. Wait for new version.
Bruce Momjian [Thu, 26 Sep 2002 05:39:03 +0000 (05:39 +0000)]
Back out /pl memory leak patch.  Wait for new version.

21 years agoClean up SSL compiler warnings.
Bruce Momjian [Thu, 26 Sep 2002 05:37:58 +0000 (05:37 +0000)]
Clean up SSL compiler warnings.

21 years agoAttached is a patch to contrib/dbmirror that fixes a bug that was
Bruce Momjian [Thu, 26 Sep 2002 05:24:30 +0000 (05:24 +0000)]
Attached is a patch to contrib/dbmirror that fixes a bug that was
causing  the postmaster to crash when the trigger was running on a table
without a  primary key.

I've also updated the docs to explicitly say that tables need primary
keys.

Steven Singer

21 years agoI have attached the pltcl patch again, just in case. For the sake of clarity
Bruce Momjian [Thu, 26 Sep 2002 05:23:26 +0000 (05:23 +0000)]
I have attached the pltcl patch again, just in case. For the sake of clarity
let's say this patch superscedes the previous one.

I have also attached a patch addressing the similar memory leak problem in
plpython. This includes a slight adjustment of the tests in the source
directory. The patch also includes a cosmetic change to remove a compiler
warning although I think the change makes the code look worse though.

BTW, by my reckoning the memory leak would occur with prepared plans and
without. If that is not the case then I've been barking up the wrong tree.

Nigel J. Andrews

21 years agoThis patch removes a use of uninitialized memory in lmgr/lock.c, by
Bruce Momjian [Thu, 26 Sep 2002 05:18:30 +0000 (05:18 +0000)]
This patch removes a use of uninitialized memory in lmgr/lock.c, by
adding a missing sprintf().

Neil Conway

21 years agoPass postmaster -d down to the postgres backend to trigger special -d
Bruce Momjian [Thu, 26 Sep 2002 05:17:00 +0000 (05:17 +0000)]
Pass postmaster -d down to the postgres backend to trigger special -d
handling in the backend.

21 years agoAllow SSL to work withouth client-side certificate infrastructure.
Bruce Momjian [Thu, 26 Sep 2002 04:41:55 +0000 (04:41 +0000)]
Allow SSL to work withouth client-side certificate infrastructure.

21 years agoEnhance the description of user and database management. Reduce the
Peter Eisentraut [Wed, 25 Sep 2002 21:16:10 +0000 (21:16 +0000)]
Enhance the description of user and database management.  Reduce the
number of forward references in the admin guide.

21 years agoRemove ShutdownBufferPoolAccess exit callback, and do the work in
Tom Lane [Wed, 25 Sep 2002 20:31:40 +0000 (20:31 +0000)]
Remove ShutdownBufferPoolAccess exit callback, and do the work in
ProcKill instead, where we still have a PGPROC with which to wait on
LWLocks.  This fixes 'can't wait without a PROC structure' failures
occasionally seen during backend shutdown (I'm surprised they weren't
more frequent, actually).  Add an Assert() to LWLockAcquire to help
catch any similar mistakes in future.  Fix failure to update MyProcPid
for standalone backends and pgstat processes.

21 years agoShouldn't be here ...
Tom Lane [Wed, 25 Sep 2002 14:27:16 +0000 (14:27 +0000)]
Shouldn't be here ...

21 years agoStamp configure for beta2.
Bruce Momjian [Wed, 25 Sep 2002 13:23:15 +0000 (13:23 +0000)]
Stamp configure for beta2.

21 years agoInstall proper earthdistance file, regression passes.
Bruce Momjian [Wed, 25 Sep 2002 13:04:48 +0000 (13:04 +0000)]
Install proper earthdistance file, regression passes.

21 years agoApplied patch from Aaron Mulder (ammulder@alumni.princeton.edu) that fixes
Barry Lind [Wed, 25 Sep 2002 07:01:31 +0000 (07:01 +0000)]
Applied patch from Aaron Mulder (ammulder@alumni.princeton.edu) that fixes
jdbc datasource support for jdk1.4/jdbc3

 Modified Files:
  jdbc/build.xml jdbc/org/postgresql/Driver.java.in
  jdbc/org/postgresql/jdbc2/optional/BaseDataSource.java
  jdbc/org/postgresql/jdbc2/optional/PGObjectFactory.java
  jdbc/org/postgresql/jdbc2/optional/PooledConnectionImpl.java
  jdbc/org/postgresql/jdbc2/optional/PoolingDataSource.java
  jdbc/org/postgresql/test/jdbc2/optional/BaseDataSourceTest.java
  jdbc/org/postgresql/test/jdbc2/optional/OptionalTestSuite.java
  jdbc/org/postgresql/test/jdbc3/Jdbc3TestSuite.java
 Added Files:
  jdbc/org/postgresql/jdbc3/Jdbc3ConnectionPool.java
  jdbc/org/postgresql/jdbc3/Jdbc3ObjectFactory.java
  jdbc/org/postgresql/jdbc3/Jdbc3PooledConnection.java
  jdbc/org/postgresql/jdbc3/Jdbc3PoolingDataSource.java
  jdbc/org/postgresql/jdbc3/Jdbc3SimpleDataSource.java
  jdbc/org/postgresql/test/jdbc2/optional/PoolingDataSourceTest.java
  jdbc/org/postgresql/test/jdbc3/Jdbc3ConnectionPoolTest.java
  jdbc/org/postgresql/test/jdbc3/Jdbc3PoolingDataSourceTest.java
  jdbc/org/postgresql/test/jdbc3/Jdbc3SimpleDataSourceTest.java
  jdbc/org/postgresql/test/util/MiniJndiContext.java
  jdbc/org/postgresql/test/util/MiniJndiContextFactory.java

21 years agoAdd missing earthdistance regression test files.
Bruce Momjian [Wed, 25 Sep 2002 03:46:04 +0000 (03:46 +0000)]
Add missing earthdistance regression test files.

21 years agoMake PL/pgSQL capitalization consistent.
Bruce Momjian [Tue, 24 Sep 2002 23:37:42 +0000 (23:37 +0000)]
Make PL/pgSQL capitalization consistent.

21 years agoChange default privileges for languages and functions to be PUBLIC USAGE
Tom Lane [Tue, 24 Sep 2002 23:14:25 +0000 (23:14 +0000)]
Change default privileges for languages and functions to be PUBLIC USAGE
and PUBLIC EXECUTE, respectively.  Per discussion about easing updates
from prior versions.

21 years agoUpdate some obsolete comments and column descriptions.
Tom Lane [Tue, 24 Sep 2002 21:26:44 +0000 (21:26 +0000)]
Update some obsolete comments and column descriptions.

21 years agoRemove useless O_DIROPEN stuff.
Peter Eisentraut [Tue, 24 Sep 2002 20:20:10 +0000 (20:20 +0000)]
Remove useless O_DIROPEN stuff.

21 years agoTweak conversion names to follow the established naming scheme, and
Peter Eisentraut [Tue, 24 Sep 2002 20:14:59 +0000 (20:14 +0000)]
Tweak conversion names to follow the established naming scheme, and
document that scheme.

21 years agoAdd earthdistance regression file.
Bruce Momjian [Tue, 24 Sep 2002 20:09:33 +0000 (20:09 +0000)]
Add earthdistance regression file.

21 years agoAdd missing correction of sublevelsup when pulling up a subquery.
Tom Lane [Tue, 24 Sep 2002 18:38:23 +0000 (18:38 +0000)]
Add missing correction of sublevelsup when pulling up a subquery.
Fixes problem with cases like
SELECT * FROM foo t WHERE NOT EXISTS (SELECT remoteid FROM
(SELECT f1 as remoteid FROM foo WHERE f1 = t.f1) AS t1)

21 years agoFix broken markup.
Tom Lane [Mon, 23 Sep 2002 23:20:38 +0000 (23:20 +0000)]
Fix broken markup.

21 years agoFurther thinking about heap_mark4update: in HeapTupleSelfUpdated case,
Tom Lane [Mon, 23 Sep 2002 22:57:44 +0000 (22:57 +0000)]
Further thinking about heap_mark4update: in HeapTupleSelfUpdated case,
executor should not return the tuple as successfully marked, because in
fact it's been deleted.  Not clear that this case has ever been seen
in practice (I think you'd have to write a SELECT FOR UPDATE that calls
a function that deletes some row the SELECT will visit later...) but we
should be consistent.  Also add comments to several other places that
got it right but didn't explain what they were doing.

21 years agoMove PyGreSQL usage documentation from README into DocBook. Some other
Peter Eisentraut [Mon, 23 Sep 2002 21:10:13 +0000 (21:10 +0000)]
Move PyGreSQL usage documentation from README into DocBook.  Some other
editing.

21 years agoDisallow VACUUM, ANALYZE, TRUNCATE on temp tables belonging to other
Tom Lane [Mon, 23 Sep 2002 20:43:41 +0000 (20:43 +0000)]
Disallow VACUUM, ANALYZE, TRUNCATE on temp tables belonging to other
backends.  Given that temp tables now store data locally in the local
buffer manager, these things are not going to work safely.

21 years agoTweak dblink functions to use int4 arguments instead of int2,
Tom Lane [Mon, 23 Sep 2002 18:03:32 +0000 (18:03 +0000)]
Tweak dblink functions to use int4 arguments instead of int2,
to avoid having to write explicit casts.  From Joe Conway.

21 years agoAdd:
Bruce Momjian [Mon, 23 Sep 2002 14:52:28 +0000 (14:52 +0000)]
Add:

> * Add start time to pg_stat_activity

21 years agoUpdate HISTORY for 7.3beta2.
Bruce Momjian [Mon, 23 Sep 2002 05:25:38 +0000 (05:25 +0000)]
Update HISTORY for 7.3beta2.

21 years agoAdd win32 rename discussion to archives.
Bruce Momjian [Mon, 23 Sep 2002 01:59:40 +0000 (01:59 +0000)]
Add win32 rename discussion to archives.

21 years agoThe valid return value should be MODIFY instead of MODIFIED.
Bruce Momjian [Mon, 23 Sep 2002 01:51:02 +0000 (01:51 +0000)]
The valid return value should be MODIFY instead of MODIFIED.
The error message said so :-)

In 25.3. Using PL/Python

        If the trigger "when" is BEFORE, you may return None or "OK"
        from the Python function to indicate the tuple is unmodified, "SKIP"
        to abort the event, or "MODIFIED" to indicate you've modified the tuple.

should read
        If the trigger "when" is BEFORE, you may return None or "OK"
        from the Python function to indicate the tuple is unmodified, "SKIP"
        to abort the event, or "MODIFY" to indicate you've modified the tuple.

elein

21 years agoObviously noone has ever tested the doubling of availiable result ids
Bruce Momjian [Mon, 23 Sep 2002 01:43:23 +0000 (01:43 +0000)]
Obviously noone has ever tested the doubling of availiable result ids
up to
reaching the hard limit. After opening 16(=current REST_START value)
results via pg_exec, the next pg_exec tries to find an empty slot
forever :-( . In PgSetResultId file pgtclId.c in the for loop there
has to be done a break, if res_max ist reached. The piece of code
should look like
        if (resid == connid->res_max)
        {
            resid = 0;
            break;   /* the break as to be added */
        }

now everything works (double available results after reaching
RES_START up to reaching RES_HARD_MAX)

Gerhard Hintermayer

21 years agoNothing.
Bruce Momjian [Mon, 23 Sep 2002 01:39:05 +0000 (01:39 +0000)]
Nothing.

21 years agoGet rid of bogus use of heap_mark4update in reindex operations (cf.
Tom Lane [Mon, 23 Sep 2002 00:42:48 +0000 (00:42 +0000)]
Get rid of bogus use of heap_mark4update in reindex operations (cf.
recent bug report).  Fix processing of nailed-in-cache indexes;
it appears that REINDEX DATABASE has been broken for months :-(.

21 years agoIn UpdateStats(), don't bother to update the pg_class row if it already
Tom Lane [Sun, 22 Sep 2002 23:03:58 +0000 (23:03 +0000)]
In UpdateStats(), don't bother to update the pg_class row if it already
contains the correct statistics.  This is a partial solution for the
problem of allowing concurrent CREATE INDEX commands: unless they commit
at nearly the same instant, the second one will see the first one's
pg_class updates as committed, and won't try to update again, thus
avoiding the 'tuple concurrently updated' failure.

21 years agoRemove commas for compatibility with newer releases of bison.
Tom Lane [Sun, 22 Sep 2002 21:56:47 +0000 (21:56 +0000)]
Remove commas for compatibility with newer releases of bison.

21 years agoRemove commas for compatibility with newer bisons.
Tom Lane [Sun, 22 Sep 2002 21:54:31 +0000 (21:54 +0000)]
Remove commas for compatibility with newer bisons.

21 years agoRemove extraneous | ... while bison 1.28 doesn't object, newer versions
Tom Lane [Sun, 22 Sep 2002 21:51:18 +0000 (21:51 +0000)]
Remove extraneous | ... while bison 1.28 doesn't object, newer versions
do.

21 years agoRemove commas from %type and %token lists, for compatibility with newer
Tom Lane [Sun, 22 Sep 2002 21:44:43 +0000 (21:44 +0000)]
Remove commas from %type and %token lists, for compatibility with newer
versions of bison.

21 years agoTranslation updates, some messages tweaked.
Peter Eisentraut [Sun, 22 Sep 2002 20:57:21 +0000 (20:57 +0000)]
Translation updates, some messages tweaked.

21 years agoRelationClearRelation must reset rd_targblock and update rd_nblocks
Tom Lane [Sun, 22 Sep 2002 20:56:28 +0000 (20:56 +0000)]
RelationClearRelation must reset rd_targblock and update rd_nblocks
even when dealing with a nailed-in-cache relation; otherwise, following
VACUUM truncation of a system catalog, other backends might have
unreasonably large values of these fields.

21 years agoMake \dS work more like it used to, viz, show only system objects.
Tom Lane [Sun, 22 Sep 2002 20:44:22 +0000 (20:44 +0000)]
Make \dS work more like it used to, viz, show only system objects.

21 years agoI haven't seen any objections, so here is a patch. It removes "#define
Tom Lane [Sun, 22 Sep 2002 20:08:51 +0000 (20:08 +0000)]
I haven't seen any objections, so here is a patch. It removes "#define
YYERROR_VERBOSE" from contrib/cube and contrib/seg, and adjusts the expected
output accordingly. Hopefully this will consistently pass across multiple
bison versions.

Joe Conway

21 years agoserver_min_messages and friends should have valid values at bootup.
Tom Lane [Sun, 22 Sep 2002 19:52:38 +0000 (19:52 +0000)]
server_min_messages and friends should have valid values at bootup.

21 years agoReplace pg_attribute.attisinherited with attislocal and attinhcount
Tom Lane [Sun, 22 Sep 2002 19:42:52 +0000 (19:42 +0000)]
Replace pg_attribute.attisinherited with attislocal and attinhcount
columns, to allow more correct behavior in multiple-inheritance cases.
Patch by Alvaro Herrera, review by Tom Lane.

21 years agoFix busted markup.
Tom Lane [Sun, 22 Sep 2002 18:47:24 +0000 (18:47 +0000)]
Fix busted markup.

21 years agoBring SIMILAR TO and SUBSTRING into some semblance of conformance with
Tom Lane [Sun, 22 Sep 2002 17:27:25 +0000 (17:27 +0000)]
Bring SIMILAR TO and SUBSTRING into some semblance of conformance with
the SQL99 standard.  (I'm not sure that the character-class features are
quite right, but that can be fixed later.)  Document SQL99 and POSIX
regexps as being different features; provide variants of SUBSTRING for
each.

21 years agoMove most of the error checking for foreign-key constraints out of
Tom Lane [Sun, 22 Sep 2002 00:37:09 +0000 (00:37 +0000)]
Move most of the error checking for foreign-key constraints out of
parse analysis and into the execution code (in tablecmds.c).  This
eliminates a lot of unreasonably complex code that needed to have two
or more execution paths in case it was dealing with a not-yet-created
table column vs. an already-existing one.  The execution code is always
dealing with already-created tables and so needs only one case.  This
also eliminates some potential race conditions (the table wasn't locked
between parse analysis and execution), makes it easy to fix the gripe
about wrong referenced-column names generating a misleading error message,
and lets us easily add a dependency from the foreign-key constraint to
the unique index that it requires the referenced table to have.  (Cf.
complaint from Kris Jurka 12-Sep-2002 on pgsql-bugs.)

Also, third try at building a deletion mechanism that is not sensitive
to the order in which pg_depend entries are visited.  Adding the above-
mentioned dependency exposed the folly of what dependency.c had been
doing: it failed for cases where B depends on C while both auto-depend
on A.  Dropping A should succeed in this case, but was failing if C
happened to be visited before B.  It appears the only solution is two
separate walks over the dependency tree.

21 years agoAdd last-ditch defense against attempts to compile datetime code with
Tom Lane [Sat, 21 Sep 2002 19:52:41 +0000 (19:52 +0000)]
Add last-ditch defense against attempts to compile datetime code with
-ffast-math.

21 years agoProvide an upgrade strategy for dump files containing functions declared
Tom Lane [Sat, 21 Sep 2002 18:39:26 +0000 (18:39 +0000)]
Provide an upgrade strategy for dump files containing functions declared
with OPAQUE.  CREATE LANGUAGE, CREATE TRIGGER, and CREATE TYPE will all
accept references to functions declared with OPAQUE --- but they will
issue a NOTICE, and will modify the function entries in pg_proc to have
the preferred type-safe argument or result types instead of OPAQUE.
Per recent pghackers discussions.

21 years agoAdd more appropriate markup.
Peter Eisentraut [Sat, 21 Sep 2002 18:32:54 +0000 (18:32 +0000)]
Add more appropriate markup.

21 years agoFix PPC s_lock operations to work correctly on multi-CPU machines.
Tom Lane [Sat, 21 Sep 2002 00:14:05 +0000 (00:14 +0000)]
Fix PPC s_lock operations to work correctly on multi-CPU machines.
Need 'isync' during TAS and 'sync' during S_UNLOCK.

21 years agoPerformance improvement for MultiRecordFreeSpace on large relations ---
Tom Lane [Fri, 20 Sep 2002 19:56:01 +0000 (19:56 +0000)]
Performance improvement for MultiRecordFreeSpace on large relations ---
avoid O(N^2) behavior.  Problem noted and fixed by Stephen Marshall <smarshall@wsicorp.com>,
with some help from Tom Lane.

21 years agoRevision
Peter Eisentraut [Fri, 20 Sep 2002 18:39:41 +0000 (18:39 +0000)]
Revision

21 years agoPut in defense against gcc -ffast-math.
Peter Eisentraut [Fri, 20 Sep 2002 18:38:57 +0000 (18:38 +0000)]
Put in defense against gcc -ffast-math.

21 years agoCode review for check-domain-constraints-in-COPY patch. Do correct thing
Tom Lane [Fri, 20 Sep 2002 16:56:02 +0000 (16:56 +0000)]
Code review for check-domain-constraints-in-COPY patch.  Do correct thing
when default expression for a domain is being used.  Avoid repetitive
catalog lookups.

21 years agoUpdate regression expected results for to_char() change.
Tom Lane [Fri, 20 Sep 2002 16:44:55 +0000 (16:44 +0000)]
Update regression expected results for to_char() change.

21 years agoChange domain patch to COERCE_IMPLICIT_CAST, per Tom.
Bruce Momjian [Fri, 20 Sep 2002 15:43:03 +0000 (15:43 +0000)]
Change domain patch to COERCE_IMPLICIT_CAST, per Tom.

21 years agoFix compile error from Rod's patch.
Bruce Momjian [Fri, 20 Sep 2002 15:29:44 +0000 (15:29 +0000)]
Fix compile error from Rod's patch.

21 years agoDone:
Bruce Momjian [Fri, 20 Sep 2002 03:57:57 +0000 (03:57 +0000)]
Done:

> * -to_char(0,'FM999.99') returns a period, to_char(1,'FM999.99') doesn't (Karel)

21 years agoThe patch fix bug described in TODO:
Bruce Momjian [Fri, 20 Sep 2002 03:57:09 +0000 (03:57 +0000)]
The patch fix bug described in TODO:

 * to_char(0,'FM999.99') returns a period, to_char(1,'FM999.99') does not

Karel Zak

21 years agoTom Lane wrote:
Bruce Momjian [Fri, 20 Sep 2002 03:55:40 +0000 (03:55 +0000)]
Tom Lane wrote:
> I see in your recent bytea-LIKE patch
>
>         if (datatype != BYTEAOID && pg_database_encoding_max_length()
> 1)
>             len = pg_mbcliplen((const unsigned char *) workstr, len,
len - 1);
>         else
>             len -= -1;
>
> Surely there's one too many minus signs in that last?

Joe Conway

21 years agoThis patch cleans up some of the code in src/util/adt/formatting.c,
Bruce Momjian [Fri, 20 Sep 2002 03:54:57 +0000 (03:54 +0000)]
This patch cleans up some of the code in src/util/adt/formatting.c,
fixes a few minor bugs (typos, potential buffer overruns, etc.), and
fixes some spelling/grammar mistakes.

Neil Conway

21 years agoTiny patch fixing small documentation typo.
Bruce Momjian [Fri, 20 Sep 2002 03:54:21 +0000 (03:54 +0000)]
Tiny patch fixing small documentation typo.

Oleg Bartunov

21 years agoThis patch fixes two typos in src/backend/storage/ipc/README.
Bruce Momjian [Fri, 20 Sep 2002 03:53:55 +0000 (03:53 +0000)]
This patch fixes two typos in src/backend/storage/ipc/README.

Neil Conway

21 years agoFixed this problem and added regression tests in domain.sql.
Bruce Momjian [Fri, 20 Sep 2002 03:52:50 +0000 (03:52 +0000)]
Fixed this problem and added regression tests in domain.sql.

Also:
- Changed header file order (alphabetical)
- Changed to m = attnum - 1 in binary copy code for consistency

Rod Taylor

21 years agoI have included fixes to declare some floating point constants as double
Bruce Momjian [Fri, 20 Sep 2002 03:47:22 +0000 (03:47 +0000)]
I have included fixes to declare some floating point constants as double
instead of int, change the calculation method to use the haversine
formula
which is more accurrate for short distances, added a grant to public for
geo_distance and added a regression test.

I will resubmit the earth distance stuff based on cube after 7.3 is
released.

Bruno Wolff III

21 years ago> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
Bruce Momjian [Fri, 20 Sep 2002 03:45:08 +0000 (03:45 +0000)]
> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> moment, but they used to be used; I think the correct response is to
> put back the missing counter increments, not rip out the counters.

Ok, fair enough. It's worth noting that they've been broken for a
while -- for example, the HashJoin counter increments were broken when
you comitted r1.20 of executor/nodeHashJoin.c in May of '99.

I've attached a revised patch that doesn't remove the counters (but
doesn't increment them either: I'm not sure of all the places where
the counter should be incremented).

Neil Conway

21 years agoMention that pg_get_viewdef(name) is deprecated.
Bruce Momjian [Fri, 20 Sep 2002 03:44:06 +0000 (03:44 +0000)]
Mention that pg_get_viewdef(name) is deprecated.

Rod Taylor

21 years agoThis grants execute privileges to public for the fti() function. Should
Bruce Momjian [Fri, 20 Sep 2002 03:42:39 +0000 (03:42 +0000)]
This grants execute privileges to public for the fti() function.  Should
we go through and give all the contribs grants?

Christopher Kings-Lynne

21 years agoThis patch corrects a minor mis-statement in the CREATE DOMAIN docs,
Bruce Momjian [Fri, 20 Sep 2002 03:39:15 +0000 (03:39 +0000)]
This patch corrects a minor mis-statement in the CREATE DOMAIN docs,
pointed out by Chris KL on -hackers a little while ago -- NOT NULL !=
CHECK xxx IS NOT NULL.

Neil Conway

21 years agoTweak heap.c to refuse attempts to create table columns of standalone
Tom Lane [Thu, 19 Sep 2002 23:40:56 +0000 (23:40 +0000)]
Tweak heap.c to refuse attempts to create table columns of standalone
composite types.  Add a couple more lsyscache.c routines to support this,
and make use of them in some other places that were doing lookups the
hard way.

21 years agoDepartment of second thoughts: suppressing implicit casts everywhere in
Tom Lane [Thu, 19 Sep 2002 22:48:34 +0000 (22:48 +0000)]
Department of second thoughts: suppressing implicit casts everywhere in
ruleutils display is not such a great idea.  For arguments of functions
and operators I think we'd better keep the historical behavior of showing
such casts explicitly, to ensure that the function/operator is reparsed
the same way when the rule is reloaded.  This also makes the output of
EXPLAIN less obscurantist about exactly what's happening.

21 years agoExtend pg_cast castimplicit column to a three-way value; this allows us
Tom Lane [Wed, 18 Sep 2002 21:35:25 +0000 (21:35 +0000)]
Extend pg_cast castimplicit column to a three-way value; this allows us
to be flexible about assignment casts without introducing ambiguity in
operator/function resolution.  Introduce a well-defined promotion hierarchy
for numeric datatypes (int2->int4->int8->numeric->float4->float8).
Change make_const to initially label numeric literals as int4, int8, or
numeric (never float8 anymore).
Explicitly mark Func and RelabelType nodes to indicate whether they came
from a function call, explicit cast, or implicit cast; use this to do
reverse-listing more accurately and without so many heuristics.
Explicit casts to char, varchar, bit, varbit will truncate or pad without
raising an error (the pre-7.2 behavior), while assigning to a column without
any explicit cast will still raise an error for wrong-length data like 7.3.
This more nearly follows the SQL spec than 7.2 behavior (we should be
reporting a 'completion condition' in the explicit-cast cases, but we have
no mechanism for that, so just do silent truncation).
Fix some problems with enforcement of typmod for array elements;
it didn't work at all in 'UPDATE ... SET array[n] = foo', for example.
Provide a generalized array_length_coerce() function to replace the
specialized per-array-type functions that used to be needed (and were
missing for NUMERIC as well as all the datetime types).
Add missing conversions int8<->float4, text<->numeric, oid<->int8.
initdb forced.

21 years agoAdd mention of /contrib/adddepend to HISTORY.
Bruce Momjian [Wed, 18 Sep 2002 20:43:03 +0000 (20:43 +0000)]
Add mention of /contrib/adddepend to HISTORY.

21 years agoAdd 'adddepend' script to handle pre-7.3 object dependencies.
Bruce Momjian [Wed, 18 Sep 2002 20:38:59 +0000 (20:38 +0000)]
Add 'adddepend' script to handle pre-7.3 object dependencies.

21 years agoUpdate installation instructions and put mostly everything in one place.
Peter Eisentraut [Wed, 18 Sep 2002 20:09:32 +0000 (20:09 +0000)]
Update installation instructions and put mostly everything in one place.
Also, some editing in PL/Perl and PL/Python chapters.

21 years agoRemove pgeasy and odbc.
Peter Eisentraut [Wed, 18 Sep 2002 20:07:15 +0000 (20:07 +0000)]
Remove pgeasy and odbc.

21 years agoRename help file upgrade_7.3 to upgrade_tips_7.3.
Bruce Momjian [Wed, 18 Sep 2002 15:24:08 +0000 (15:24 +0000)]
Rename help file upgrade_7.3 to upgrade_tips_7.3.

21 years agoAdd GRANT EXECUTE ON FUNCTION
Tatsuo Ishii [Wed, 18 Sep 2002 06:38:29 +0000 (06:38 +0000)]
Add GRANT EXECUTE ON FUNCTION