OSDN Git Service
Kevin Rocard [Fri, 12 May 2017 09:08:46 +0000 (09:08 +0000)]
Merge changes from topic 'audio-primary-hal-vts-fix' into oc-dev am:
257c2f1a43
am:
c8e1b1dadc
Change-Id: Ifb57505618923484ea469dcbf117f90d2cdd1f4b
Jaesoo Lee [Fri, 12 May 2017 09:08:21 +0000 (09:08 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h am:
92c77bd6e7 am:
4b1848247f am:
d21a105380
am:
4c15eccb92
Change-Id: I99d8db9341bc683d87dea0149e46267587abf0c9
Kevin Rocard [Fri, 12 May 2017 06:57:47 +0000 (06:57 +0000)]
Merge changes from topic 'audio-primary-hal-vts-fix' into oc-dev
am:
257c2f1a43
Change-Id: Ic8850d915b5672e7529f99e7d57845b2de44857a
Jaesoo Lee [Fri, 12 May 2017 05:16:36 +0000 (05:16 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h am:
92c77bd6e7 am:
4b1848247f
am:
d21a105380
Change-Id: I1a674bd0827b0dccdb01fded168cf3122de81afa
Jaesoo Lee [Fri, 12 May 2017 05:12:35 +0000 (05:12 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h am:
92c77bd6e7
am:
4b1848247f
Change-Id: I7563d66174d3fd5c6c7a35389bb5d5ed78c7ac3c
Jaesoo Lee [Fri, 12 May 2017 05:10:34 +0000 (05:10 +0000)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h
am:
92c77bd6e7
Change-Id: I2782872f927b8fa9a0cc1da877d0f1cac3680150
Kevin Rocard [Thu, 11 May 2017 22:34:39 +0000 (22:34 +0000)]
Merge changes from topic 'audio-primary-hal-vts-fix' into oc-dev
* changes:
Audio HAL: A volume/gain outside of [0,1] is an error
Audio HAL VTS: Log test unexpected behaviour
Audio HAL VTS: Improve ASSERT of Result and Return
Audio HAL VTS: stopped stream state getters may return INVALID_STATE
Audio HAL VTS: setGain allow -0.0
Audio HAL VTS: Some methods are optional
Audio HAL VTS: GetPresentationPosition may return 0 on stop stream
Audio HAL VTS: getDevice() == NONE => not supported
Audio HAL VTS: Getter test assert logic was incorrect
Audio HAL VTS: debugDump can only test for crash
Audio HAL VTS: Sanitize prepareFor{Writing,Reading} input size
Audio HAL VTS: refactor prepareFor{Reading,Writing}
Audio HAL VTS: Sanitize setMode input
Audio HAL VTS: Allow OK when setting a non existing parameter
Audio HAL VTS: differentiate getParam success/failure/not_implemented
Audio HAL VTS: Fix style on modified files
Steven Moreland [Thu, 11 May 2017 16:14:59 +0000 (09:14 -0700)]
Fix side branch build breakage.
Some branch is complaining:
error: undefined reference to 'android::hardware::power::V1_0::IPower::unlinkToDeath(android::sp<android::hardware::hidl_death_recipient> const&)'
Test: N/A
Test: works on master branch
Change-Id: Ifbd47fd47312e02e25eb326f374c71c7dceb2944
Steven Moreland [Thu, 11 May 2017 01:46:22 +0000 (01:46 +0000)]
Merge changes from topic 'fix-hidl-generate' into oc-dev am:
4be51a8512 -s ours
am:
da36690e9b -s ours
Change-Id: I2a0776d045cca8967c29643b4d3b4507f88384a9
Steven Moreland [Thu, 11 May 2017 01:38:23 +0000 (01:38 +0000)]
Update makefiles for c++-sources and c++-headers. am:
8716f3063e -s ours
am:
2b6a9e2213 -s ours
Change-Id: I9337dd2e4686519c9e955ccf685073ef4640ff85
Steven Moreland [Thu, 11 May 2017 01:38:14 +0000 (01:38 +0000)]
Update makefiles for c++-sources and c++-headers. (2/2) am:
bc71124120
am:
a32ebce372
Change-Id: Ic1dd8f98e72656bc12a6e5224e541f75afb79daa
Martijn Coenen [Thu, 11 May 2017 01:36:26 +0000 (01:36 +0000)]
Merge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev am:
6c062f77c1
am:
b05e4c9414
Change-Id: I9fa6d2b4283ca50506ffcc6a665e6a2e46c4c2f9
Steven Moreland [Thu, 11 May 2017 00:55:46 +0000 (00:55 +0000)]
Merge changes from topic 'fix-hidl-generate' into oc-dev
am:
4be51a8512 -s ours
Change-Id: I91054a4a0ffcf6ff117bd4b6c3dcc3a94e7231c2
Steven Moreland [Thu, 11 May 2017 00:49:04 +0000 (00:49 +0000)]
Update makefiles for c++-sources and c++-headers.
am:
8716f3063e -s ours
Change-Id: If3655769859781369e8cb8456f133e0c35636254
Steven Moreland [Thu, 11 May 2017 00:48:55 +0000 (00:48 +0000)]
Update makefiles for c++-sources and c++-headers. (2/2)
am:
bc71124120
Change-Id: Icf36068a4d863a8520854c7a83e51f960c188e12
Martijn Coenen [Thu, 11 May 2017 00:47:30 +0000 (00:47 +0000)]
Merge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev
am:
6c062f77c1
Change-Id: I921160390dc9f90e7872729194ed1d1240ce68b7
Jaesoo Lee [Tue, 2 May 2017 06:15:14 +0000 (15:15 +0900)]
configstore: include types.h instead of ISurfaceFlingerConfigs.h
Utils.h does not need to include ISurfaceFlingerConfigs.h.
Bug:
37727469
Test: successfully built sailfish-userdebug
Change-Id: I6650020bfc3b265d871ca3244b8900c336f98419
Steven Moreland [Wed, 10 May 2017 23:48:25 +0000 (23:48 +0000)]
Actually fix build breakage with cleanspec. am:
319b8292be am:
b16a4d26d3 am:
6ad2f6c984
am:
ef8f6e8370
Change-Id: Idaef598fff95e2e8d384d6b427529956dd3b94b9
Steven Moreland [Wed, 10 May 2017 23:47:58 +0000 (23:47 +0000)]
Add CleanSpec to hardware/interfaces. am:
e468cf8004 am:
7780055fd1 am:
aae66d171a
am:
5e077fbd92 -s ours
Change-Id: I40c1636a49c883edfadf349f72494e9da27cd1de
Steven Moreland [Wed, 10 May 2017 22:51:15 +0000 (22:51 +0000)]
Actually fix build breakage with cleanspec. am:
319b8292be am:
b16a4d26d3
am:
6ad2f6c984
Change-Id: I09a208dcd24cf17d3171ed5d4f64282a2642dd56
Steven Moreland [Wed, 10 May 2017 22:48:44 +0000 (22:48 +0000)]
Actually fix build breakage with cleanspec. am:
319b8292be
am:
b16a4d26d3
Change-Id: I235f68723215a806317828b65d9b8905598b10eb
Steven Moreland [Wed, 10 May 2017 22:47:14 +0000 (22:47 +0000)]
Actually fix build breakage with cleanspec.
am:
319b8292be
Change-Id: Ic9dcbf28c238b30eba296fedcdef08af049aef31
Steven Moreland [Wed, 10 May 2017 22:32:32 +0000 (15:32 -0700)]
Actually fix build breakage with cleanspec.
OUT_DIR instead of OUT
Test: manual
Change-Id: I2e48c6f2f39ff2318517ff55cbfa6ca912c05021
Steven Moreland [Wed, 10 May 2017 22:32:32 +0000 (15:32 -0700)]
Actually fix build breakage with cleanspec.
OUT_DIR instead of OUT
Test: manual
Change-Id: I2e48c6f2f39ff2318517ff55cbfa6ca912c05021
Steven Moreland [Wed, 10 May 2017 21:03:08 +0000 (21:03 +0000)]
Add CleanSpec to hardware/interfaces. am:
e468cf8004 am:
7780055fd1
am:
aae66d171a
Change-Id: Id1a1c32443e342915dd40147560bb1987d782f9d
Steven Moreland [Wed, 10 May 2017 20:58:37 +0000 (20:58 +0000)]
Add CleanSpec to hardware/interfaces. am:
e468cf8004
am:
7780055fd1
Change-Id: I5d5f2618fc6d18034439d3cb1c31290d825f1c2e
Steven Moreland [Wed, 10 May 2017 20:55:57 +0000 (20:55 +0000)]
Merge "Add CleanSpec to hardware/interfaces."
Steven Moreland [Wed, 10 May 2017 20:55:36 +0000 (20:55 +0000)]
Add CleanSpec to hardware/interfaces.
am:
e468cf8004
Change-Id: If1978c73a668dacaf8f3b2842a704c5b28d5135e
Steven Moreland [Wed, 10 May 2017 20:37:21 +0000 (13:37 -0700)]
Add CleanSpec to hardware/interfaces.
Fixes build breakage from interface changing after -Lc++-sources
and -Lc++-headers was added to hidl-gen.
Test: manual
Change-Id: I9ee0a0e7b72f8f2a3253d205943a696c07129a64
Steven Moreland [Wed, 10 May 2017 20:37:21 +0000 (13:37 -0700)]
Add CleanSpec to hardware/interfaces.
Fixes build breakage from interface changing after -Lc++-sources
and -Lc++-headers was added to hidl-gen.
Test: wip
Change-Id: I9ee0a0e7b72f8f2a3253d205943a696c07129a64
Ahmed ElArabawy [Wed, 10 May 2017 20:37:39 +0000 (20:37 +0000)]
Merge "power hal: Add power HAL API 1.1"
Steven Moreland [Wed, 10 May 2017 20:02:38 +0000 (20:02 +0000)]
Merge changes from topic 'fix-hidl-generate' into oc-dev
* changes:
Update makefiles for c++-sources and c++-headers.
Update makefiles for c++-sources and c++-headers. (2/2)
Martijn Coenen [Wed, 10 May 2017 17:55:46 +0000 (17:55 +0000)]
Merge "Start processes that need real-time with CAP_SYS_NICE." into oc-dev
TreeHugger Robot [Wed, 10 May 2017 17:43:57 +0000 (17:43 +0000)]
Merge "Support different SIM power states"
Steven Moreland [Wed, 10 May 2017 03:13:43 +0000 (03:13 +0000)]
Update makefiles for c++-sources and c++-headers. am:
cb360c60d8 am:
4bd4e7fb3b am:
127b116fe5
am:
8e89a43590
Change-Id: I35950a57e220cdbe7672d5e814230fb73c154fac
PO HUNG CHEN [Wed, 10 May 2017 03:13:19 +0000 (03:13 +0000)]
Merge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev am:
c365952316
am:
9a520b0524
Change-Id: I432106555061104bb4ec06b02d53c1390306202b
Sanket Padawe [Wed, 10 May 2017 03:13:03 +0000 (03:13 +0000)]
Merge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev am:
41ea816c9d
am:
3ea42032f4
Change-Id: I9366bec6584deaad4e7bc8f856d3d358781899f8
Steven Moreland [Tue, 9 May 2017 21:34:19 +0000 (14:34 -0700)]
Update makefiles for c++-sources and c++-headers.
Test: pass
Bug:
38174080
Merged-In: I683455736eed35e6ced24e2763c2bdb5fb6c9601
Change-Id: I683455736eed35e6ced24e2763c2bdb5fb6c9601
Steven Moreland [Wed, 10 May 2017 02:51:19 +0000 (19:51 -0700)]
Update makefiles for c++-sources and c++-headers. (2/2)
Test: pass
Bug:
38174080
Change-Id: Icad451f9f9ad5f46412356a4171a8a1222f8e545
Steven Moreland [Wed, 10 May 2017 02:58:00 +0000 (02:58 +0000)]
Update makefiles for c++-sources and c++-headers. am:
cb360c60d8 am:
4bd4e7fb3b
am:
127b116fe5
Change-Id: I3a2aa76acef0f0d1455bfad775e87e8089d357e8
Steven Moreland [Wed, 10 May 2017 02:52:52 +0000 (02:52 +0000)]
Update makefiles for c++-sources and c++-headers. am:
cb360c60d8
am:
4bd4e7fb3b
Change-Id: Ief274574dda12a38f62f49953a88f612d5b3586c
Steven Moreland [Wed, 10 May 2017 02:47:25 +0000 (02:47 +0000)]
Update makefiles for c++-sources and c++-headers.
am:
cb360c60d8
Change-Id: If0f0c69fa29a8c1cbd0d5b4e53e386ef8b68757e
PO HUNG CHEN [Wed, 10 May 2017 02:42:02 +0000 (02:42 +0000)]
Merge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev
am:
c365952316
Change-Id: If6399162d868c7498ca6e4a5d9453b4425ab77cc
Sanket Padawe [Wed, 10 May 2017 02:41:46 +0000 (02:41 +0000)]
Merge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev
am:
41ea816c9d
Change-Id: I3f9efd6422652efc967a9c8a5bda284f87a4a458
PO HUNG CHEN [Wed, 10 May 2017 02:28:10 +0000 (02:28 +0000)]
Merge "Bugfix: Add HIDL_FETCH_IScheduleTest declaration" into oc-dev
Sanket Padawe [Wed, 10 May 2017 02:27:04 +0000 (02:27 +0000)]
Merge "Update IRadioResponse.hal documentation to fix failing VTS" into oc-dev
Mathias Agopian [Tue, 2 May 2017 00:29:17 +0000 (17:29 -0700)]
fix circular dependency libnativewindow <-> libui
Bug:
37647680,
37648355
Test: compile, manual
Change-Id: I2fdec8e86f6729aadd572a250b9d55d77f0d4eef
Eino-Ville Talvala [Tue, 9 May 2017 23:17:18 +0000 (23:17 +0000)]
Camera: Remove TODOs in interfaces am:
71619beef7
am:
569dbdc90e
Change-Id: I27e0bd177eabd9b61c42fd01c8c523a53f2441a6
Eino-Ville Talvala [Tue, 9 May 2017 23:16:57 +0000 (23:16 +0000)]
Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev am:
0b3d86e05a
am:
e643da4e19
Change-Id: Ie8227d2db1667e60421ff88a65555260b426e16e
Ram Periathiruvadi [Tue, 9 May 2017 23:16:28 +0000 (23:16 +0000)]
Merge "Add DOOR_LOCK to default config." into oc-dev am:
c63bdfbd74
am:
4f65adf509
Change-Id: I5ae7088e129992262e8403da35aacb44502016b0
Naina Nalluri [Fri, 5 May 2017 18:00:05 +0000 (11:00 -0700)]
Update IRadioResponse.hal documentation to fix failing VTS
update IRadioResponse.hal documentation with
nas/data error codes
Bug:
35671595
Test: Only doc update.
Change-Id: I5a106e05b487f7deecb208af6465e5ea5238b26e
Steven Moreland [Tue, 9 May 2017 21:34:19 +0000 (14:34 -0700)]
Update makefiles for c++-sources and c++-headers.
Test: pass
Bug:
38174080
Change-Id: I683455736eed35e6ced24e2763c2bdb5fb6c9601
Eino-Ville Talvala [Tue, 9 May 2017 21:32:28 +0000 (21:32 +0000)]
Camera: Remove TODOs in interfaces
am:
71619beef7
Change-Id: I43e85210ab1972f8245376831f578816be4dea78
Eino-Ville Talvala [Tue, 9 May 2017 21:32:10 +0000 (21:32 +0000)]
Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
am:
0b3d86e05a
Change-Id: Ic0ca4e1eff6716466ef86bc6a660bc371da875d6
Ram Periathiruvadi [Tue, 9 May 2017 21:31:44 +0000 (21:31 +0000)]
Merge "Add DOOR_LOCK to default config." into oc-dev
am:
c63bdfbd74
Change-Id: I2386d09d237957da9f7ea146412b5a36cbf208a6
Kumar Anand [Thu, 26 Jan 2017 20:23:09 +0000 (12:23 -0800)]
power hal: Add power HAL API 1.1
Extend APIs to collect subsystem low power statistics.
Many subsystems (e.g.wifi) could be living on an
independent power island (sourced from VBatt directly)
and might even have their own dedicated XTAL to source
their clocks. Since these SOCs are capable of
autonomously operating (while the platform is in one
of the sleep states), they are still drawing power
from the VBatt. Hence it is critical to understand
the (SOC) level low power statistics as well when
the battery level changes and be able to find any
correlation in event of unexpected battery drain.
Bug:
29339696
Test: VTS
Change-Id: I1b6ea557dbdf1aa06e9560635fcba8d54afabda7
Signed-off-by: Ahmed ElArabawy <arabawy@google.com>
TreeHugger Robot [Tue, 9 May 2017 20:13:44 +0000 (20:13 +0000)]
Merge "[AWARE] Passphrase limit check used incorrect limit"
Etan Cohen [Tue, 9 May 2017 18:44:38 +0000 (11:44 -0700)]
[AWARE] Passphrase limit check used incorrect limit
Passphrase has a lower and upper limit. The uppper limit check
was using the incorrect (lower) limit value.
Bug:
38164425
Test: builds & CtsVerifier test passes
Change-Id: I8a58f46a9558f828f8ccfda07935fcf62285f8c3
Eino-Ville Talvala [Tue, 9 May 2017 18:13:20 +0000 (11:13 -0700)]
Camera: Remove TODOs in interfaces
These are tracked elsewhere and won't be addresed for the initial
interface versions.
Update current.txt hashes; comment-only update
Test: Compiles
Bug:
34108979
Bug:
33269977
Bug:
33262893
Change-Id: I0c0521cf69649d871f64a67773ce822db2487044
Grace Chen [Wed, 26 Apr 2017 01:41:20 +0000 (18:41 -0700)]
Support different SIM power states
Test: Verify SIM power states
Bug:
35844036
Change-Id: I769f7eada97286680cb516c63d28da11bb69db4d
TreeHugger Robot [Tue, 9 May 2017 17:30:35 +0000 (17:30 +0000)]
Merge "Camera: Clean up TODOs that aren't going to be addressed." into oc-dev
TreeHugger Robot [Tue, 9 May 2017 17:21:13 +0000 (17:21 +0000)]
Merge "Add DOOR_LOCK to default config." into oc-dev
Martijn Coenen [Tue, 9 May 2017 16:57:00 +0000 (09:57 -0700)]
Start processes that need real-time with CAP_SYS_NICE.
Bug:
37293077
Test: verified CAP_SYS_NICE granted in /proc/pid/status
Change-Id: If404450cbeb077d331b231bda1af2d6eae774b75
Kevin Rocard [Tue, 9 May 2017 00:08:11 +0000 (17:08 -0700)]
Audio HAL: A volume/gain outside of [0,1] is an error
Hals are supposed to received normalized volumes, between 0 and 1.
Previously volumes outside [0,1] were clamp to this range.
This clamping has the capability to hide bugs thus return an error if
such volume is received.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: Ia4880bdff6111cbcdae6a4ebee921eddae141ee4
Signed-off-by: Kevin Rocard <krocard@google.com>
Yifan Hong [Mon, 8 May 2017 22:55:22 +0000 (22:55 +0000)]
Merge "Revert "Set omx and configstore as optional."" into oc-dev am:
b8e84d240f
am:
92a3c3d75d
Change-Id: I9f2f988465253d16cb8d2881991893d3e42be6d5
Eino-Ville Talvala [Mon, 8 May 2017 22:29:28 +0000 (15:29 -0700)]
Camera: Clean up TODOs that aren't going to be addressed.
These TODOs aren't in scope for the wrapper libraries.
Leave the few TODOs that have bugs tracking them, and the ones that
are from autogenerated metadata.
Test: Builds
Bug:
34108979
Change-Id: Ib28467a4fbcfaab4a0809334bc62eabb9290797a
Yifan Hong [Mon, 8 May 2017 22:12:06 +0000 (22:12 +0000)]
Merge "Revert "Set omx and configstore as optional."" into oc-dev
am:
b8e84d240f
Change-Id: Iaf5f7aacacd2eb72b1ba98e19f5fe7589580bdbd
Kevin Rocard [Mon, 8 May 2017 18:53:07 +0000 (11:53 -0700)]
Audio HAL VTS: Log test unexpected behaviour
Some test output infos that are useful to understand how they run.
Unfortunately the xml report does not seem to be saved by VTS tradefed.
Thus output them in logcat.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I9a2cc10160c3b1c8f81db0464efbc6b26600cadc
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 02:21:58 +0000 (19:21 -0700)]
Audio HAL VTS: Improve ASSERT of Result and Return
Previously tests on Result and Return were using ASSERT_NO_FATAL_FAILURE
and helper methods.
This leaded to complex error messages were the error did not pointed to
the helper methods instead of the ASSERT_RESULT call.
Additionally SCOPE_TRACE messages are repeated
for each ASSERT_NO_FATAL_FAILURE level.
Use ::testing::AssertionResult to improve drastically the error messages.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: If705502546606d678df3f1966b0cd9f3ef8c2529
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 17:57:06 +0000 (10:57 -0700)]
Audio HAL VTS: stopped stream state getters may return INVALID_STATE
A never started stream should have its render position and next write
timestamp at 0 or indicate that the state is invalid.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I62e16066bb22101ee8f75154fc6c85a66be2f402
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 18:19:25 +0000 (11:19 -0700)]
Audio HAL VTS: setGain allow -0.0
Previously -0.0 was consider an invalid value as not in the range [0,1].
But it is quite difficult in C++ to differentiate -0.0 and 0.0 as -0.0 == 0.0
and such difference has no impact in practice.
Thus leave the implementation support or not -0.0.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: Ia0ebcb325f77adcf8471620f418da1cbe8995e36
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 18:16:05 +0000 (11:16 -0700)]
Audio HAL VTS: Some methods are optional
Although the method documentation does not say it,
some HIDL interface methods are optional.
Update the tests to allow NOT_SUPPORTED to be returned.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: If31acc2dbdb6d1d563910e85c99401c48f4f3f86
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 17:52:43 +0000 (10:52 -0700)]
Audio HAL VTS: GetPresentationPosition may return 0 on stop stream
GetPresentationPosition returns the last time a sample was written to
the hardware.
Calling it on a stop stream should return 0 sample written, but the
timestamps of that measure is of little importance.
Thus allow this timestamp to be 0 indicating that the measure was never
actually made.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I3c33b60f98e8cbea269a7739cc1889af932dcff5
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 02:34:29 +0000 (19:34 -0700)]
Audio HAL VTS: getDevice() == NONE => not supported
getDevice does not return a Result, thus it can not return NOT_SUPPORTED.
Consider NONE as not supported.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I3b6f7a1fbc1d1535faf549f5b031461cb39d1722
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 01:58:58 +0000 (18:58 -0700)]
Audio HAL VTS: Getter test assert logic was incorrect
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: Iaf2d71829a15b12dcf56e825773c8a697896a264
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 01:41:46 +0000 (18:41 -0700)]
Audio HAL VTS: debugDump can only test for crash
DebugDump does not return an error code, thus the implementation can not
return not implemented.
As a result, the test can not expect any output from the function.
Only test that the call does not crash and add a log if the function is
probably not implemented in the test.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I2c18958bceb1eb638491f9afce9d8e8025ccd3ec
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 01:34:59 +0000 (18:34 -0700)]
Audio HAL VTS: Sanitize prepareFor{Writing,Reading} input size
Return an error if framesCount or frameSize are null to avoid a division
by zero when calculating the buffer size.
The message queues are allocated with a buffer size but if two big they will
assert not return an error.
Thus take some margin on the buffer size check.
Note that both function should be refactored as 99% identical.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I0576e9016ef2e567c8d4e171c6237883d9865db9
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 01:31:24 +0000 (18:31 -0700)]
Audio HAL VTS: refactor prepareFor{Reading,Writing}
Those functions had lots of copy paste on errors and
the following patch will even add more error detections.
Refactor the hidl_cb call to avoid all duplication.
Note that both function should be refactored as 99% identical.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: I40d6926b4f9f5e3aba51e878f55fb013f4ca09c1
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 01:16:00 +0000 (18:16 -0700)]
Audio HAL VTS: Sanitize setMode input
Some values of AudioMode are exposed although implementation detail.
Make sure the client can not use them.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: If513c2a06efa8a92459f0af80c63232fc63302b0
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Wed, 3 May 2017 17:43:21 +0000 (10:43 -0700)]
Audio HAL VTS: Allow OK when setting a non existing parameter
setHwAvSync and setParameters were implemented in the pre-hidl interface
as set_parameters.
Unfortunately set_parameters did not return an error if a key was not
implemented.
As most HIDL implementation will be a wrapper around the pre-hidl
interface, allow those functions to return OK on not implemented key.
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: Icfcaa02b7d63e03375fddc90dc5a803754c1874f
Signed-off-by: Kevin Rocard <krocard@google.com>
Yifan Hong [Mon, 8 May 2017 21:10:56 +0000 (21:10 +0000)]
Merge "Revert "Set omx and configstore as optional."" into oc-dev
Kevin Rocard [Wed, 3 May 2017 00:38:34 +0000 (17:38 -0700)]
Audio HAL VTS: differentiate getParam success/failure/not_implemented
When sending parameters to the HAL (and some getters are implemented
with getParameters), the client expect a status consistent
with the other HIDL methods. Ie: not implemented or success and failure.
Unfortunately, the legacy get_parameter interface, which currently most
Audio HIDL implementation are a wrapper around, do not return such error
code.
Get parameters return a list of key values.
- If a requested key does not return a key value pair, consider it not
implemented
- If a requested key returns a key not followed by a correct value,
consider it a failure
- otherwise it is a success
Test: vts-tradefed run vts --module VtsHalAudioV2_0Target
Test: call/play music/record/video...
Bug:
36311550
Change-Id: Id6711e9c1974fe5a336b6de83a9b6d14f74437c9
Signed-off-by: Kevin Rocard <krocard@google.com>
Kevin Rocard [Fri, 5 May 2017 21:02:55 +0000 (14:02 -0700)]
Audio HAL VTS: Fix style on modified files
In order to avoid style inconsistency as well as non functional
modification in following patches,
fix the style of all files modified for the fix of the VTS tests.
Patch generated with:
$ clang-format -i --style file -- <file list>
Bug:
36311550
Test: compile
Change-Id: I53dbcdabf959a6100e34a2ee4d0f951d525049cb
TreeHugger Robot [Mon, 8 May 2017 19:29:33 +0000 (19:29 +0000)]
Merge "Increase poll max size, avoid performance issue when batching"
Ram Periathiruvadi [Thu, 4 May 2017 18:06:17 +0000 (11:06 -0700)]
Add DOOR_LOCK to default config.
One of the triggers for Bluetooth Auto connect is a door unlock signal.
Adding it to the list of default supported properties.
Bug: b/
37674555
Test: Auto connect triggers on adb shell dumpsys activity service
com.android.car inject-event zoned-boolean 0x16200b02 1 false
Change-Id: Icfed9ea57239cd2397f3e71dcfaccd767a2e9739
(cherry picked from commit
e17a009d5de6601e0482cc5495aef16c562c6e30)
Shuo Qian [Mon, 8 May 2017 18:22:44 +0000 (18:22 +0000)]
Merge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing" into oc-dev am:
79c636a4ff
am:
d46cee4a8d
Change-Id: Ifa92260e442518d56e9e4cda341970ec884f33e9
Etan Cohen [Mon, 8 May 2017 17:53:38 +0000 (17:53 +0000)]
Merge "[WIFI] Remove dependency on vendor-specific library"
Shuo Qian [Mon, 8 May 2017 17:52:46 +0000 (17:52 +0000)]
Merge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing" into oc-dev
am:
79c636a4ff
Change-Id: I81fc971a9a36550c254999222bdc669dd234b558
Shuo Qian [Mon, 8 May 2017 17:49:17 +0000 (17:49 +0000)]
Merge "Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are failing" into oc-dev
Yi Kong [Mon, 8 May 2017 17:27:50 +0000 (17:27 +0000)]
Remove unused lambda captures am:
5ca756ea1f am:
68f6e99613 am:
dcf35ca86e
am:
c86120fbb4
Change-Id: I5663bbc8cd3927208ae9f33b398d6d57b5380e85
TreeHugger Robot [Mon, 8 May 2017 17:26:46 +0000 (17:26 +0000)]
Merge "Add DOOR_LOCK to default config."
Yi Kong [Mon, 8 May 2017 17:24:21 +0000 (17:24 +0000)]
Remove unused lambda captures am:
5ca756ea1f am:
68f6e99613
am:
dcf35ca86e
Change-Id: I025a2f240cb6f4278bece0f1b3c91dbfcdffa0fc
Yi Kong [Mon, 8 May 2017 17:21:17 +0000 (17:21 +0000)]
Remove unused lambda captures am:
5ca756ea1f
am:
68f6e99613
Change-Id: I4646c377fec898d104f13e260eb039b42f8cc31d
Yi Kong [Mon, 8 May 2017 17:17:45 +0000 (17:17 +0000)]
Remove unused lambda captures
am:
5ca756ea1f
Change-Id: Ia11bcc3b1f05b4582fa85856d1cdf94c41c23fdc
Howard Chen [Mon, 8 May 2017 06:04:05 +0000 (14:04 +0800)]
Bugfix: Add HIDL_FETCH_IScheduleTest declaration
Fix the bug that makes the registerAsServer fails.
sp<IScheduleTest> server =
IScheduleTest::getService(serviceName, true);
status_t status = server->registerAsService(serviceName);
Bug:
38099333
Test: oc-dev on pixel sailfish with a vts test case
"libhwbinder_latency -i 1"
Change-Id: I892835a25ef7df56a6424da41c0fc477b3a532d8
Yifan Hong [Thu, 4 May 2017 22:33:12 +0000 (22:33 +0000)]
Revert "Set omx and configstore as optional."
Test: boots
Test: Youtube video works
Bug:
35356977
Fixes:
38001671
This reverts commit
49a6654ccf5675470b5f638a918a963cc446ee36.
Change-Id: I7b04aa62e248c7fae0307229d07ffa174109ff05
sqian [Fri, 5 May 2017 19:51:56 +0000 (12:51 -0700)]
Add GENERIC_FAILURE error checks for some Radio BTSAP Apis which are
failing
Test: Vts
Bug:
35671595
Change-Id: Ie2ca86437283ce2f8e4b5cad21454a8d201e53ad
Jayachandran Chinnakkannu [Fri, 5 May 2017 22:53:33 +0000 (22:53 +0000)]
Merge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev am:
eca8d114bf
am:
1a8f5c3595
Change-Id: Icb21f8f205b5d199c72741b209aac7b51eab32dd
Jayachandran Chinnakkannu [Fri, 5 May 2017 22:29:14 +0000 (22:29 +0000)]
Merge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev
am:
eca8d114bf
Change-Id: I33e926f4ecd0314b4554ca9d90104f8afda773eb
Jayachandran Chinnakkannu [Fri, 5 May 2017 22:22:33 +0000 (22:22 +0000)]
Merge "VTS: Fix IRadio.setAllowedCarriers and IRadio.nvResetConfig" into oc-dev