OSDN Git Service

pg-rex/syncrep.git
21 years agoIn the examples, I missed changing a few 'column' and 'table' mentions
Bruce Momjian [Fri, 6 Dec 2002 16:40:13 +0000 (16:40 +0000)]
In the examples, I missed changing a few 'column' and 'table' mentions
to domain when copying alter table docs.
--
Rod Taylor <rbt@rbt.ca>

21 years agoAttached are two small patches to expose md5 as a user function -- including
Bruce Momjian [Fri, 6 Dec 2002 05:20:28 +0000 (05:20 +0000)]
Attached are two small patches to expose md5 as a user function -- including
documentation and regression test mods. It seemed small and unobtrusive enough
to not require a specific proposal on the hackers list -- but if not, let me
know and I'll make a pitch. Otherwise, if there are no objections please apply.

Joe Conway

21 years agoMention of DEFAULT_STATISTICS_TARGET default.
Bruce Momjian [Fri, 6 Dec 2002 05:18:57 +0000 (05:18 +0000)]
Mention of DEFAULT_STATISTICS_TARGET default.

Jeff Davis

21 years agoThis patch improves the documentation for SERIAL columns a little bit.
Bruce Momjian [Fri, 6 Dec 2002 05:17:42 +0000 (05:17 +0000)]
This patch improves the documentation for SERIAL columns a little bit.

Neil Conway

21 years agoRANDOM_PAGE_COST clarification of docs.
Bruce Momjian [Fri, 6 Dec 2002 05:17:03 +0000 (05:17 +0000)]
RANDOM_PAGE_COST clarification of docs.

Joseph Shraibman

21 years agoThank you very much, you catch it :). This bug had a long life, because it
Bruce Momjian [Fri, 6 Dec 2002 05:15:02 +0000 (05:15 +0000)]
Thank you very much, you catch it :). This bug had a long life, because it
exists if and only if locale of postmaster
was a different from C (or ru_RU.KOI8-R).

Please, apply patch for current CVS & 7.3.1

Magnus Naeslund(f) wrote:
> Ok, I nailed the bug, but i'm not sure what the correct fix is.
> Attached tsearch_morph.diff that remedies this problem by avoiding it.
> Also there's a debug aid patch if someone would like to know how i
> finally found it out :)
>
> There problem in the lemmatize() function is that GETDICT(...) returned
> a value not handled (BYLOCALE).
> The value (-1) and later used as an index into the dicts[] array.
> After that everything went berserk stack went crazy somehow so trapping
> the fault sent me to the wrong place, and every time i read the value it
> was positive ;)
>
> So now i just return the initial word passed to the lemmatize function,
> because i don't know what to do with it.

Magnus Naeslund

21 years agoMark ALTER DOMAIN as supported, fix typo in header.
Bruce Momjian [Fri, 6 Dec 2002 05:07:16 +0000 (05:07 +0000)]
Mark ALTER DOMAIN as supported, fix typo in header.

21 years agoRe-addd Rod's ALTER DOMAIN patch.
Bruce Momjian [Fri, 6 Dec 2002 05:00:34 +0000 (05:00 +0000)]
Re-addd Rod's ALTER DOMAIN patch.

21 years agoAdd file.
Bruce Momjian [Fri, 6 Dec 2002 04:40:58 +0000 (04:40 +0000)]
Add file.

21 years agoAdd SGML file.
Bruce Momjian [Fri, 6 Dec 2002 04:40:36 +0000 (04:40 +0000)]
Add SGML file.

21 years agoBack out V6 code, caused postmaster startup failure.
Bruce Momjian [Fri, 6 Dec 2002 04:37:05 +0000 (04:37 +0000)]
Back out V6 code, caused postmaster startup failure.

21 years agoAdd missing v6utils file.
Bruce Momjian [Fri, 6 Dec 2002 04:18:11 +0000 (04:18 +0000)]
Add missing v6utils file.

21 years agoUpdated IPv6 patch to fix netmask.
Bruce Momjian [Fri, 6 Dec 2002 03:49:19 +0000 (03:49 +0000)]
Updated IPv6 patch to fix netmask.

21 years agoWe have just finished porting the old KAME IPv6 patch over to
Bruce Momjian [Fri, 6 Dec 2002 03:46:37 +0000 (03:46 +0000)]
We have just finished porting the old KAME IPv6 patch over to
postgresql version 7.3, but yea... this patch adds full IPv6
support to postgres. I've tested it out on 7.2.3 and has
been running perfectly stable.

CREDITS:
 The KAME Project  (Initial patch)
 Nigel Kukard  <nkukard@lbsd.net>
 Johan Jordaan  <johanj@lando.co.za>

21 years agoSome time ago John Gray <jgray@azuli.co.uk> and myself worked out and
Bruce Momjian [Fri, 6 Dec 2002 03:44:14 +0000 (03:44 +0000)]
Some time ago John Gray <jgray@azuli.co.uk> and myself worked out and
tested a patch to contrib/xml where the existing code was causing
postgres to crash when it encountered & entities in the XML. I've
enclosed a patch that John came up with to correct this problem. It
patches against 7.3 and will apply on 7.2x if the elog WARNING calls
are changed to elog NOTICE.

Michael Richards

21 years agoBack out ALTER DOMAIN patch until missing file appears.
Bruce Momjian [Fri, 6 Dec 2002 03:43:35 +0000 (03:43 +0000)]
Back out ALTER DOMAIN patch until missing file appears.

21 years agoALTER DOMAIN .. SET / DROP NOT NULL
Bruce Momjian [Fri, 6 Dec 2002 03:28:34 +0000 (03:28 +0000)]
ALTER DOMAIN .. SET / DROP NOT NULL
ALTER DOMAIN .. SET / DROP DEFAULT
ALTER DOMAIN .. ADD / DROP CONSTRAINT

New files:
- doc/src/sgml/ref/alter_domain.sgml

Rod Taylor

21 years agoPyGreSQL inserttable patch
Bruce Momjian [Fri, 6 Dec 2002 03:19:28 +0000 (03:19 +0000)]
PyGreSQL inserttable patch
=====================

I suggested an improvement of the inserttable in the PyGreSQL interface
already in January, but seemingly it was never implemented. I was told this
is the right place to get patches in for PyGreSQL, so I'm reposting my patch
here.

I consider the inserttable methode essential in populating the database
because of its benefits in performance compared to insert, so I think this
patch is quite essential. The attachment is an improved version of the
corresponding pg_inserttable function in pgmodule.c, which fixes the
following problems:

* The function raised exceptions because PyList_GetItem was used beyond the
size of the list. This was checked by comparing the result with NULL, but
the exception was not cleaned up, which could result in mysterious errors in
the following Python code. Instead of clearing the exception using
PyErr_Clear or something like that, I avoided throwing the exception at all
by at first requesting the size of the list. Using this opportunity, I also
checked the uniformity of the size of the rows passed in the lists/tuples.
The function also accepts (and silently ignores) empty lists and sublists.
* Python "None" values are now accepted and properly converted to PostgreSQL
NULL values
* The function now generates an error message in case of a line buffer
overflow
* It copes with tabulators, newlines and backslashes in strings now
* Rewrote the buffer filling code which should now run faster by avoiding
unnecessary string copy operations forth and back

Christoph Zwerschke

21 years agoWith a recent commit truncate is transaction safe in 7.4.
Bruce Momjian [Fri, 6 Dec 2002 03:15:07 +0000 (03:15 +0000)]
With a recent commit truncate is transaction safe in 7.4.

Rod Taylor

21 years agoAs far as I figured from the source code this function only deals with
Bruce Momjian [Thu, 5 Dec 2002 23:21:07 +0000 (23:21 +0000)]
As far as I figured from the source code this function only deals with
cleaning up locale names and nothing else. Since all the locale names
are in plain  ASCII I think it will be safe to use ASCII-only lower-case
conversion.

Nicolai Tufar

21 years agolocalbuf.c must be able to do blind writes.
Tom Lane [Thu, 5 Dec 2002 22:48:03 +0000 (22:48 +0000)]
localbuf.c must be able to do blind writes.

21 years agoAvoid pulling up sublinks from a subselect's targetlist. Works around
Tom Lane [Thu, 5 Dec 2002 21:46:37 +0000 (21:46 +0000)]
Avoid pulling up sublinks from a subselect's targetlist.  Works around
problems that occur if sublink is referenced via a join alias variable.
Perhaps this can be improved later, but a simple and safe fix is needed
for 7.3.1.

21 years agoIt looks like the problem was introduced when the "SET autocommit" and
Bruce Momjian [Thu, 5 Dec 2002 21:03:51 +0000 (21:03 +0000)]
It looks like the problem was introduced when the "SET autocommit" and
"SET search_path"  commands were added to the beginning of the script.

The attatched patch should fix the problem. It probably should be
applied  against the 7.3 and 7.4 branches.

Steven Singer

21 years agoAdd:
Bruce Momjian [Thu, 5 Dec 2002 20:30:36 +0000 (20:30 +0000)]
Add:

> * Add SQL99 WITH clause to SELECT (Tom, Fernando)
> * Add SQL99 WITH RECURSIVE to SELECT (Tom, Fernando)
443a444
> * Fernando Nasser <fnasser@redhat.com>

21 years agoClearify variables names so it is clear which variable is the
Bruce Momjian [Thu, 5 Dec 2002 18:52:43 +0000 (18:52 +0000)]
Clearify variables names so it is clear which variable is the
client-supplied password and which is from pg_shadow.

21 years agoAllow 'password' encryption even when pg_shadow has MD5 passwords, per
Bruce Momjian [Thu, 5 Dec 2002 18:39:43 +0000 (18:39 +0000)]
Allow 'password' encryption even when pg_shadow has MD5 passwords, per
report from Terry Yapt and Hiroshi.

Backpatch to 7.3.

21 years agoPhase 1 of read-only-plans project: cause executor state nodes to point
Tom Lane [Thu, 5 Dec 2002 15:50:39 +0000 (15:50 +0000)]
Phase 1 of read-only-plans project: cause executor state nodes to point
to plan nodes, not vice-versa.  All executor state nodes now inherit from
struct PlanState.  Copying of plan trees has been simplified by not
storing a list of SubPlans in Plan nodes (eliminating duplicate links).
The executor still needs such a list, but it can build it during
ExecutorStart since it has to scan the plan tree anyway.
No initdb forced since no stored-on-disk structures changed, but you
will need a full recompile because of node-numbering changes.

21 years agoImprovements from Neil Conway.
Bruce Momjian [Thu, 5 Dec 2002 05:47:44 +0000 (05:47 +0000)]
Improvements from Neil Conway.

21 years agoDocument get/set bit/byte functions.
Bruce Momjian [Thu, 5 Dec 2002 04:38:30 +0000 (04:38 +0000)]
Document get/set bit/byte functions.

21 years agoMore cleanup of userid to be AclId rather than Oid.
Bruce Momjian [Thu, 5 Dec 2002 04:04:51 +0000 (04:04 +0000)]
More cleanup of userid to be AclId rather than Oid.

21 years agochanged sort of column names to sort by attnum, not attname
Dave Cramer [Thu, 5 Dec 2002 01:11:43 +0000 (01:11 +0000)]
changed sort of column names to sort by attnum, not attname

21 years agoUpdate docs mention of query string for debug_ commands, from Joseph
Bruce Momjian [Wed, 4 Dec 2002 21:43:07 +0000 (21:43 +0000)]
Update docs mention of query string for debug_ commands, from Joseph
Shraibman.

21 years agoRepair oversight in recent change of dependency extraction code: when
Tom Lane [Wed, 4 Dec 2002 20:00:37 +0000 (20:00 +0000)]
Repair oversight in recent change of dependency extraction code: when
recursing to handle a join alias var, the context had better be set to
be appropriate to the join var's query level.  Per report from Hristo Neshev.

21 years agoAdd:
Bruce Momjian [Wed, 4 Dec 2002 18:23:47 +0000 (18:23 +0000)]
Add:

>  * Add ALTER SEQUENCE to modify min/max/increment/cache/cycle values

21 years agoStamp minor version numbers for 7.4 release.
Bruce Momjian [Wed, 4 Dec 2002 18:14:11 +0000 (18:14 +0000)]
Stamp minor version numbers for 7.4 release.

21 years agoRemove typprtlen from getdescr() as it is not available in 7.3. Return -1 for
D'Arcy J.M. Cain [Wed, 4 Dec 2002 12:23:42 +0000 (12:23 +0000)]
Remove typprtlen from getdescr() as it is not available in 7.3.  Return -1 for
that field so that existing programs don't break.

21 years agoMake usesysid consistently int4, not oid.
Bruce Momjian [Wed, 4 Dec 2002 05:18:38 +0000 (05:18 +0000)]
Make usesysid consistently int4, not oid.

Catalog patch from Alvaro Herrera for same.

catversion updated. initdb required.

21 years agoDone:
Bruce Momjian [Tue, 3 Dec 2002 22:10:47 +0000 (22:10 +0000)]
Done:

> * -Add OpenBSD's getpeereid() call for local socket authentication

21 years agoDeal with cases where getpeereid _and_ another creditial method is
Bruce Momjian [Tue, 3 Dec 2002 22:09:20 +0000 (22:09 +0000)]
Deal with cases where getpeereid _and_ another creditial method is
supported.

21 years agoAdd OpenBSD local indent credentials, from William Ahern.
Bruce Momjian [Tue, 3 Dec 2002 21:50:44 +0000 (21:50 +0000)]
Add OpenBSD local indent credentials, from William Ahern.

21 years agoUpdated:
Bruce Momjian [Tue, 3 Dec 2002 17:38:34 +0000 (17:38 +0000)]
Updated:

< * Add sql3 recursive unions
> * Add SQL99 WITH clause to SELECT
> * Add SQL99 WITH RECURSIVE to SELECT

21 years agoFix off-by-one bug in usage check.
Tom Lane [Tue, 3 Dec 2002 07:12:18 +0000 (07:12 +0000)]
Fix off-by-one bug in usage check.

21 years agoAdd for D'Arcy:
Bruce Momjian [Mon, 2 Dec 2002 05:42:36 +0000 (05:42 +0000)]
Add for D'Arcy:

> * Python
>  o Allow users to register their own types with _pg
>  o Allow SELECT to return a dictionary of dictionaries
>  o Allow COPY BINARY FROM

21 years agoRepair core dump when trying to delete an entry from an already-NULL
Tom Lane [Mon, 2 Dec 2002 05:20:47 +0000 (05:20 +0000)]
Repair core dump when trying to delete an entry from an already-NULL
datconfig or useconfig field.  Per report from Dustin Sallings.

21 years agoFix script name in README.
Tom Lane [Mon, 2 Dec 2002 00:29:01 +0000 (00:29 +0000)]
Fix script name in README.

21 years agoFix dependency generation for multicolumn foreign keys. From Adam Buraczewski.
Tom Lane [Mon, 2 Dec 2002 00:28:29 +0000 (00:28 +0000)]
Fix dependency generation for multicolumn foreign keys.  From Adam Buraczewski.

21 years agoDone in 7.3, so removed:
Bruce Momjian [Sun, 1 Dec 2002 21:28:01 +0000 (21:28 +0000)]
Done in 7.3, so removed:

<  o Allow psql \copy to specify column names
199d197
<  o Add SET REAL_FORMAT and SET DOUBLE_PRECISION_FORMAT using printf args

21 years agoDone:
Bruce Momjian [Sun, 1 Dec 2002 21:20:45 +0000 (21:20 +0000)]
Done:

> * -Inline simple SQL functions to avoid overhead (Tom)

21 years agoTeach planner to expand sufficiently simple SQL-language functions
Tom Lane [Sun, 1 Dec 2002 21:05:14 +0000 (21:05 +0000)]
Teach planner to expand sufficiently simple SQL-language functions
('SELECT expression') inline, like macros, during the constant-folding
phase of planning.  The actual expansion is not difficult, but checking
that we're not changing the semantics of the call turns out to be more
subtle than one might think; in particular must pay attention to
permissions issues, strictness, and volatility.

21 years agoFix ExecMakeTableFunctionResult() to work with generic expressions as
Tom Lane [Sun, 1 Dec 2002 20:27:32 +0000 (20:27 +0000)]
Fix ExecMakeTableFunctionResult() to work with generic expressions as
well as function calls.  This is needed for cases where the planner has
constant-folded or inlined the original function call.  Possibly we should
back-patch this change into 7.3 branch as well.

21 years agoFix pg_dump failure against 7.1 or older servers, per
Tom Lane [Sun, 1 Dec 2002 18:44:00 +0000 (18:44 +0000)]
Fix pg_dump failure against 7.1 or older servers, per
report from Philip Warner.

21 years agoRun COPY OUT in a temporary memory context that's reset once per row,
Tom Lane [Sun, 1 Dec 2002 18:14:22 +0000 (18:14 +0000)]
Run COPY OUT in a temporary memory context that's reset once per row,
and eliminate its manual pfree() calls.  This solves the encoding-conversion
bug recently reported, and should be faster and more robust than the
original coding anyway.  For example, we are no longer at risk if
datatype output routines leak memory or choose to return a constant string.

21 years agoCode review for IS DISTINCT FROM patch. Fix incorrect constant-folding
Tom Lane [Sat, 30 Nov 2002 21:25:08 +0000 (21:25 +0000)]
Code review for IS DISTINCT FROM patch.  Fix incorrect constant-folding
logic, dissuade planner from thinking that 'x IS DISTINCT FROM 42' may
be optimized into 'x = 42' (!!), cause dependency on = operator to be
recorded correctly, minor other improvements.

21 years agoMissed one place that can be simplified after recent Param/Const cleanup.
Tom Lane [Sat, 30 Nov 2002 18:28:49 +0000 (18:28 +0000)]
Missed one place that can be simplified after recent Param/Const cleanup.

21 years agoBe more realistic about plans involving Materialize nodes: take their
Tom Lane [Sat, 30 Nov 2002 05:21:03 +0000 (05:21 +0000)]
Be more realistic about plans involving Materialize nodes: take their
cost into account while planning.

21 years agoMake install and clean targets behave more normally.
Tom Lane [Sat, 30 Nov 2002 00:22:39 +0000 (00:22 +0000)]
Make install and clean targets behave more normally.

21 years agoUpgrade planner and executor to allow multiple hash keys for a hash join,
Tom Lane [Sat, 30 Nov 2002 00:08:22 +0000 (00:08 +0000)]
Upgrade planner and executor to allow multiple hash keys for a hash join,
instead of only one.  This should speed up planning (only one hash path
to consider for a given pair of relations) as well as allow more effective
hashing, when there are multiple hashable joinclauses.

21 years agoTighten selection of equality and ordering operators for grouping
Tom Lane [Fri, 29 Nov 2002 21:39:12 +0000 (21:39 +0000)]
Tighten selection of equality and ordering operators for grouping
operations: make sure we use operators that are compatible, as determined
by a mergejoin link in pg_operator.  Also, add code to planner to ensure
we don't try to use hashed grouping when the grouping operators aren't
marked hashable.

21 years agoRepair prehistoric logic error in lseg_eq and lseg_ne.
Tom Lane [Fri, 29 Nov 2002 19:25:33 +0000 (19:25 +0000)]
Repair prehistoric logic error in lseg_eq and lseg_ne.

21 years agoSuppress compiler warning from newer gcc.
Tom Lane [Fri, 29 Nov 2002 19:03:01 +0000 (19:03 +0000)]
Suppress compiler warning from newer gcc.

21 years agoThis patch fixes two tiny memory leaks in pg_dump and two in pg_dumpall.
Bruce Momjian [Fri, 29 Nov 2002 16:38:42 +0000 (16:38 +0000)]
This patch fixes two tiny memory leaks in pg_dump and two in pg_dumpall.

Neil Conway

21 years agoAdd trigger emails.
Bruce Momjian [Thu, 28 Nov 2002 20:05:13 +0000 (20:05 +0000)]
Add trigger emails.

21 years agorm should be rm -f, per comment from Peter Harris.
Tom Lane [Wed, 27 Nov 2002 23:21:12 +0000 (23:21 +0000)]
rm should be rm -f, per comment from Peter Harris.
(Checked with Peter Eisentraut.)

21 years agoImprove some comments.
Tom Lane [Wed, 27 Nov 2002 20:52:04 +0000 (20:52 +0000)]
Improve some comments.

21 years agoAdd note that scaling factor should be >= # of clients.
Tom Lane [Wed, 27 Nov 2002 19:26:10 +0000 (19:26 +0000)]
Add note that scaling factor should be >= # of clients.

21 years agoSynced parser with backend
Michael Meskes [Wed, 27 Nov 2002 08:30:27 +0000 (08:30 +0000)]
Synced parser with backend

21 years agoMove to URGENT, for Justin:
Bruce Momjian [Tue, 26 Nov 2002 22:05:49 +0000 (22:05 +0000)]
Move to URGENT, for Justin:

< * Create native Win32 port [win32]

21 years agoRecreate HISTORY file to match release.sgml changes. Stamp 7.3 final in
Bruce Momjian [Tue, 26 Nov 2002 22:04:03 +0000 (22:04 +0000)]
Recreate HISTORY file to match release.sgml changes.  Stamp 7.3 final in
configure/configure.in.

21 years agoAdd -cmdTuples to tcl interface.
Bruce Momjian [Tue, 26 Nov 2002 21:38:49 +0000 (21:38 +0000)]
Add -cmdTuples to tcl interface.

21 years agoUpdate trigger discussion.
Bruce Momjian [Tue, 26 Nov 2002 19:43:53 +0000 (19:43 +0000)]
Update trigger discussion.

21 years agoUpdate build rules for /HISTORY.
Bruce Momjian [Tue, 26 Nov 2002 19:22:16 +0000 (19:22 +0000)]
Update build rules for /HISTORY.

21 years agoAdd to trigger thread.
Bruce Momjian [Tue, 26 Nov 2002 18:54:26 +0000 (18:54 +0000)]
Add to trigger thread.

21 years agoFix typo in release notes.
Bruce Momjian [Tue, 26 Nov 2002 05:16:59 +0000 (05:16 +0000)]
Fix typo in release notes.

21 years agoAllocate proper length for sprintf string, from Tatsuo.
Bruce Momjian [Tue, 26 Nov 2002 03:08:00 +0000 (03:08 +0000)]
Allocate proper length for sprintf string, from Tatsuo.

21 years agoUse Params, rather than run-time-modified Const nodes, to handle
Tom Lane [Tue, 26 Nov 2002 03:01:59 +0000 (03:01 +0000)]
Use Params, rather than run-time-modified Const nodes, to handle
sublink results and COPY's domain constraint checking.  A Const that
isn't really constant is just a Bad Idea(tm).  Remove hacks in
parse_coerce and other places that were needed because of the former
klugery.

21 years agoGuard against 0 length string encoding conversion case.
Tatsuo Ishii [Tue, 26 Nov 2002 02:22:29 +0000 (02:22 +0000)]
Guard against 0 length string encoding conversion case.

21 years agoRemove check for pg_group file as part of initdb -W password assignment
Bruce Momjian [Mon, 25 Nov 2002 21:41:46 +0000 (21:41 +0000)]
Remove check for pg_group file as part of initdb -W password assignment
--- not needed.

21 years agoRemove unused constisset and constiscast fields of Const nodes. Clean
Tom Lane [Mon, 25 Nov 2002 21:29:42 +0000 (21:29 +0000)]
Remove unused constisset and constiscast fields of Const nodes.  Clean
up code and documentation associated with Param nodes.

21 years agoRestructure outfuncs and readfuncs to use macros in the same style as
Tom Lane [Mon, 25 Nov 2002 18:12:12 +0000 (18:12 +0000)]
Restructure outfuncs and readfuncs to use macros in the same style as
just done for copyfuncs/equalfuncs.  Read functions in particular get
a lot shorter than before, and it's much easier to compare an out function
with the corresponding read function to make sure they agree.
initdb forced due to small changes in nodestring format (regularizing
a few cases that were formerly idiosyncratic).

21 years agoUn-break triggers declared for INSERT OR DELETE OR UPDATE. This worked
Tom Lane [Mon, 25 Nov 2002 03:36:50 +0000 (03:36 +0000)]
Un-break triggers declared for INSERT OR DELETE OR UPDATE.  This worked
okay in 7.3, so I think it must have been busted in the recent triggers
patch.

21 years agoRestructure the code in copyfuncs and equalfuncs to put much heavier
Tom Lane [Mon, 25 Nov 2002 03:33:27 +0000 (03:33 +0000)]
Restructure the code in copyfuncs and equalfuncs to put much heavier
reliance on macros, in hopes of eliminating silly typos (like copying
to the wrong field) and just generally making it easier to see the forest
instead of the trees.  As an example, here is the new code for A_Indices:

static A_Indices *
_copyAIndices(A_Indices *from)
{
A_Indices  *newnode = makeNode(A_Indices);

COPY_NODE_FIELD(lidx);
COPY_NODE_FIELD(uidx);

return newnode;
}

static bool
_equalAIndices(A_Indices *a, A_Indices *b)
{
COMPARE_NODE_FIELD(lidx);
COMPARE_NODE_FIELD(uidx);

return true;
}

I plan to redo outfuncs/readfuncs in a similar style, but am committing
what I've got.

21 years agoI'm sending you a small patch to pgdb.py module. This
D'Arcy J.M. Cain [Mon, 25 Nov 2002 03:11:15 +0000 (03:11 +0000)]
I'm sending you a small patch to pgdb.py module.  This
raises pgdb.DatabaseError when any of the fetch*
methods was invoked but previous call to execute* did
not produce any result set or no call was issued yet.
Also, raises pgdb.NotSupportedError when .nextset() is
invoked, instead of NameError.

This behaviour complies with DB-API 2.0.

Thanks for your work!

Timur Irmatov.

21 years agoChange the pkey method so that the caller can optionally set the dictionary
D'Arcy J.M. Cain [Mon, 25 Nov 2002 02:15:13 +0000 (02:15 +0000)]
Change the pkey method so that the caller can optionally set the dictionary
used for the primary key lookup.  This will prevent a database lookup
for each connection object that gets created.  This could be a significant
optimization on a busy system.

Similarly, the get_attnames method allows for the attributes dictionary
to be installed directly.

21 years agoChange the debug variable to allow better control by the caller over how
D'Arcy J.M. Cain [Mon, 25 Nov 2002 01:28:32 +0000 (01:28 +0000)]
Change the debug variable to allow better control by the caller over how
debug output is managed.  The user can continue to use the current method
of passing a formatting string to have a replacement done and output will
be sent to the standard output exactly as it did before.  In addition they
can set it to a file object, sys.stderr for example, and the query string
will be printed to it.  Thay can also set it to a method (function) and the
query string will be passed to that method giving them the maximum flexibility
to do whatever they want with the query string.

I will be working with the PyGreSQL documentation shortly and at that time
will properly document this feature.

21 years agoRestructure planning of nestloop inner indexscans so that the set of usable
Tom Lane [Sun, 24 Nov 2002 21:52:15 +0000 (21:52 +0000)]
Restructure planning of nestloop inner indexscans so that the set of usable
joinclauses is determined accurately for each join.  Formerly, the code only
considered joinclauses that used all of the rels from the outer side of the
join; thus for example
FROM (a CROSS JOIN b) JOIN c ON (c.f1 = a.x AND c.f2 = b.y)
could not exploit a two-column index on c(f1,f2), since neither of the
qual clauses would be in the joininfo list it looked in.  The new code does
this correctly, and also is able to eliminate redundant clauses, thus fixing
the problem noted 24-Oct-02 by Hans-Jürgen Schönig.

21 years ago7.4devel now supports SQL:1999's "enhanced trigger capability" (which
Bruce Momjian [Sun, 24 Nov 2002 03:15:55 +0000 (03:15 +0000)]
7.4devel now supports SQL:1999's "enhanced trigger capability" (which
is just FOR EACH STATEMENT triggers, AFAICS); this patch updates the
SQL conformance docs to note that.

Neil Conway

21 years agoSplit:
Bruce Momjian [Sun, 24 Nov 2002 03:14:01 +0000 (03:14 +0000)]
Split:

> * -Support statement-level triggers (Neil)
> * Support triggers on columns (Neil)

21 years agoFix inappropriate quoting in dblink. From Joe Conway.
Tom Lane [Sat, 23 Nov 2002 18:59:25 +0000 (18:59 +0000)]
Fix inappropriate quoting in dblink.  From Joe Conway.

21 years agoFix regression test breakage from triggers patch.
Tom Lane [Sat, 23 Nov 2002 18:42:37 +0000 (18:42 +0000)]
Fix regression test breakage from triggers patch.

21 years agoFix compile warnings from truncate patch.
Tom Lane [Sat, 23 Nov 2002 18:26:45 +0000 (18:26 +0000)]
Fix compile warnings from truncate patch.

21 years agoUpdate regression for new patches. Bump up catversion.
Bruce Momjian [Sat, 23 Nov 2002 18:13:22 +0000 (18:13 +0000)]
Update regression for new patches. Bump up catversion.

21 years agoHeres a patch which will create the sql_help.h file on Win32 if it
Bruce Momjian [Sat, 23 Nov 2002 04:06:32 +0000 (04:06 +0000)]
Heres a patch which will create the sql_help.h file on Win32 if it
doesn't already exist using an installed copy of perl. I've tested it
using perl v5.6.1 from ActiveState and all appears to work.

Al Sutton

21 years agoTransaction safe Truncate
Bruce Momjian [Sat, 23 Nov 2002 04:05:52 +0000 (04:05 +0000)]
Transaction safe Truncate

Rod Taylor

21 years agoThis minor patch corrects an error in the function docs: it's
Bruce Momjian [Sat, 23 Nov 2002 04:04:43 +0000 (04:04 +0000)]
This minor patch corrects an error in the function docs: it's
"version()", not "version".

Neil Conway

21 years agoThis patch implements FOR EACH STATEMENT triggers, per my email to
Bruce Momjian [Sat, 23 Nov 2002 03:59:09 +0000 (03:59 +0000)]
This patch implements FOR EACH STATEMENT triggers, per my email to
-hackers a couple days ago.

Notes/caveats:

        - added regression tests for the new functionality, all
          regression tests pass on my machine

        - added pg_dump support

        - updated PL/PgSQL to support per-statement triggers; didn't
          look at the other procedural languages.

        - there's (even) more code duplication in trigger.c than there
          was previously. Any suggestions on how to refactor the
          ExecXXXTriggers() functions to reuse more code would be
          welcome -- I took a brief look at it, but couldn't see an
          easy way to do it (there are several subtly-different
          versions of the code in question)

        - updated the documentation. I also took the liberty of
          removing a big chunk of duplicated syntax documentation in
          the Programmer's Guide on triggers, and moving that
          information to the CREATE TRIGGER reference page.

        - I also included some spelling fixes and similar small
          cleanups I noticed while making the changes. If you'd like
          me to split those into a separate patch, let me know.

Neil Conway

21 years agoDone:
Bruce Momjian [Sat, 23 Nov 2002 03:52:44 +0000 (03:52 +0000)]
Done:

> * -Support statement-level triggers and triggers on columns (Neil)

21 years agoWhen I made the cube(text) function for 7.3, I neglected to add a
Bruce Momjian [Sat, 23 Nov 2002 03:50:50 +0000 (03:50 +0000)]
When I made the cube(text) function for 7.3, I neglected to add a
matching create cast command. The attached diff adds a create cast as
assignment to cube.sql.in .

Bruno Wolff III

21 years agoUpdate ports list from recent regression-test-database entries.
Tom Lane [Sat, 23 Nov 2002 03:50:34 +0000 (03:50 +0000)]
Update ports list from recent regression-test-database entries.

21 years agoThis is a patch to make cube output work like double precision output
Bruce Momjian [Sat, 23 Nov 2002 03:50:21 +0000 (03:50 +0000)]
This is a patch to make cube output work like double precision output
with regard to the extra_float_digits setting.

Since builtins.h was already included, I just deleted the extern
statement (and accompaning comments).

 Bruno Wolff III

21 years agoRelease note improvements (Neil, Tom)
Tom Lane [Sat, 23 Nov 2002 02:41:03 +0000 (02:41 +0000)]
Release note improvements (Neil, Tom)