OSDN Git Service
Jungshik Shin [Tue, 29 Mar 2016 00:06:35 +0000 (00:06 +0000)]
Merge "Load hyphenator for 22 new languages" into nyc-dev
Pirama Arumuga Nainar [Mon, 28 Mar 2016 23:28:14 +0000 (23:28 +0000)]
Merge "[RenderScript] Fail with Exception from validateObjectIsPrimitiveArray" into nyc-dev
Siyamed Sinir [Mon, 28 Mar 2016 23:16:19 +0000 (23:16 +0000)]
Merge "Update get/setFontFeatureSettings JavaDoc" into nyc-dev
Siyamed Sinir [Sat, 26 Mar 2016 01:25:39 +0000 (18:25 -0700)]
Update get/setFontFeatureSettings JavaDoc
Add CSS font-feature-settings URL to get/setFontFeatureSettings method
JavaDoc in both TextView and Paint.
Bug:
27857640
Change-Id: I8c20068801032407d493e4f4a15b89dcf35949d2
Jungshik Shin [Mon, 28 Mar 2016 22:40:21 +0000 (15:40 -0700)]
Load hyphenator for 22 new languages
In addition, all English locales other than those explicitly mapped
to en-US are mapped to en-GB.
BUG:
26405413
Change-Id: Ie5b77af164c95a6ed5639da5752ddf21f92181bc
Wei Liu [Mon, 28 Mar 2016 22:45:22 +0000 (22:45 +0000)]
Merge "Move ThermalObserver to frameworks/opt/wear" into nyc-dev
Phil Burk [Mon, 28 Mar 2016 22:31:24 +0000 (22:31 +0000)]
Merge "AudioTrack: document some throws" into nyc-dev
Jorim Jaggi [Mon, 28 Mar 2016 22:16:42 +0000 (22:16 +0000)]
Merge "Fix nav bar consuming" into nyc-dev
Jorim Jaggi [Mon, 28 Mar 2016 22:16:17 +0000 (22:16 +0000)]
Merge "Cleanup window callbacks locking" into nyc-dev
Chris Tate [Mon, 28 Mar 2016 22:14:42 +0000 (22:14 +0000)]
Merge "Don't back up / restore "we're in night mode"" into nyc-dev
Philip P. Moltmann [Mon, 28 Mar 2016 21:59:38 +0000 (21:59 +0000)]
Merge "Update printers even if there are no printers found." into nyc-dev
Jorim Jaggi [Sat, 26 Mar 2016 05:57:01 +0000 (22:57 -0700)]
Fix nav bar consuming
- Cache shouldAlwaysConsumeNavbar so it doesn't get reset when
insets == null
- Remove logic with frame comparison when determining whether to
consume nav bar. Not sure how that ever worked.
- Make sure shouldAlwaysConsumeNavBar survives when consuming
insets.
Bug:
27157904
Change-Id: I35f209ab27cc12240038da7efa9e79c95f70c6ce
Arunesh Mishra [Mon, 28 Mar 2016 21:57:52 +0000 (21:57 +0000)]
Merge "Fix permission string typo for test app." into nyc-dev
Dianne Hackborn [Mon, 28 Mar 2016 21:46:44 +0000 (21:46 +0000)]
Merge "Fix issue #
27776639: Background Check: Conn_Change..." into nyc-dev
Christopher Tate [Mon, 28 Mar 2016 21:32:15 +0000 (14:32 -0700)]
Don't back up / restore "we're in night mode"
Bug
27880039
Change-Id: Ida59c9e602b939038e4bb3f55a6bf96db8897348
Sergei Vasilinetc [Mon, 28 Mar 2016 21:21:44 +0000 (21:21 +0000)]
Merge "Fix NPE while using mLayerPaint" into nyc-dev
Phil Burk [Mon, 28 Mar 2016 21:19:17 +0000 (14:19 -0700)]
AudioTrack: document some throws
For setBufferSizeInFrames() and related methods.
Bug:
27384290
Change-Id: Ie5decb39d7945f304f57163c5da540cfd01903c7
Signed-off-by: Phil Burk <philburk@google.com>
Jorim Jaggi [Sat, 26 Mar 2016 01:32:19 +0000 (18:32 -0700)]
Cleanup window callbacks locking
- Also get rid of USE_MT_RENDERER, because there is no point in
having a flag if the other path never gets tested.
Bug:
27738239
Change-Id: Ic76115962940e72f2c59b8d291d078d15f8d493c
Felipe Leme [Mon, 28 Mar 2016 21:11:25 +0000 (21:11 +0000)]
Merge "Removed FLAG_ADVANCED." into nyc-dev
Wale Ogunwale [Mon, 28 Mar 2016 21:04:50 +0000 (21:04 +0000)]
Merge "Don't show home activity when exiting split-screen with recents visible" into nyc-dev
Arunesh Mishra [Mon, 28 Mar 2016 20:58:07 +0000 (13:58 -0700)]
Fix permission string typo for test app.
Bug:
27875640
Change-Id: I2052e40d86ffcfbbcdef15ab3bec68ce1bdfa736
Joe Onorato [Mon, 28 Mar 2016 20:52:38 +0000 (20:52 +0000)]
Merge "Refactor ProcessStats." into nyc-dev
Jason Monk [Mon, 28 Mar 2016 20:40:38 +0000 (20:40 +0000)]
Merge "Update the data saver assets" into nyc-dev
Jason Monk [Mon, 28 Mar 2016 20:36:35 +0000 (16:36 -0400)]
Update the data saver assets
Bug:
27588223
Change-Id: Ic25a7a695fb2df019b861ef1547da3fca5cd96f9
sergeyv [Mon, 28 Mar 2016 20:23:28 +0000 (13:23 -0700)]
Fix NPE while using mLayerPaint
bug:
27873847
Change-Id: I9bfae72dfa9bda45fdeb94544b7656e2584f29f6
Wale Ogunwale [Mon, 28 Mar 2016 20:22:34 +0000 (20:22 +0000)]
Merge "Show non-top tasks in the docked stack in recents." into nyc-dev
Derek Sollenberger [Mon, 28 Mar 2016 20:17:36 +0000 (16:17 -0400)]
Fix broken test.
bug:
27877439
Change-Id: I43b009f3c9ebe8011a241d0740136e6cff2e1ff7
Jason Monk [Mon, 28 Mar 2016 20:12:12 +0000 (20:12 +0000)]
Merge "QS Anim tweaks" into nyc-dev
Jorim Jaggi [Sat, 26 Mar 2016 02:56:13 +0000 (19:56 -0700)]
Fix flicker
This line was added for window swapping, but it's not actually needed
and causes regressions.
Bug:
27635189
Change-Id: I6c9cdac8d1bf30029b9f36a106e1f2afebfd9072
Jorim Jaggi [Sat, 26 Mar 2016 02:37:44 +0000 (19:37 -0700)]
Fix touch exclude region for divider handle
Bug:
27854148
Change-Id: I93421d07b2be29846be4748a3be3b89b9b465613
Andrii Kulian [Mon, 28 Mar 2016 20:03:37 +0000 (20:03 +0000)]
Merge "Persist task minimal width and height" into nyc-dev
Felipe Leme [Mon, 28 Mar 2016 20:02:04 +0000 (13:02 -0700)]
Removed FLAG_ADVANCED.
On M, internal storage such as bugreport files were only shown when user
selected the "Show internal storage", but such UI has changed on N.
BUG:
27862860
Change-Id: I1edf086a9f9345303595ee952e4646764709d36d
Jason Monk [Mon, 28 Mar 2016 20:00:09 +0000 (16:00 -0400)]
QS Anim tweaks
Change-Id: Ic1c3b3c9554dea2b608edfd1b11d255eee38b1ef
Jorim Jaggi [Mon, 28 Mar 2016 19:57:24 +0000 (19:57 +0000)]
Merge "Fix divider animation" into nyc-dev
Jorim Jaggi [Mon, 28 Mar 2016 19:35:31 +0000 (12:35 -0700)]
Fix null pointer exception
- Make sure to use the correct task to get the stack.
- Don't try to show non-resizable toast when we didn't do
anything.
Bug:
27870378
Change-Id: I69fec6aa792c2f05d905a7c99c05ebdc689ad032
Tao Bao [Mon, 28 Mar 2016 19:51:35 +0000 (19:51 +0000)]
Merge "UpdateEngine: Add resetStatus() as system API." into nyc-dev
Paul Mclean [Mon, 28 Mar 2016 19:49:14 +0000 (19:49 +0000)]
Merge "Added logging to USB Audio connect and disconnect." into nyc-dev
Makoto Onuki [Mon, 28 Mar 2016 19:34:06 +0000 (19:34 +0000)]
Merge "ShortcutManager: Cleanup package info handling" into nyc-dev
Andrii Kulian [Mon, 28 Mar 2016 19:28:22 +0000 (19:28 +0000)]
Merge "Fix API numbering issues" into nyc-dev
Brad Ebinger [Mon, 28 Mar 2016 19:27:18 +0000 (19:27 +0000)]
Merge "Add VIA number column to CallLog Database" into nyc-dev
Chad Brubaker [Mon, 28 Mar 2016 19:14:21 +0000 (19:14 +0000)]
Merge "Use X509ExtendedTrustManagers" into nyc-dev
Yigit Boyar [Mon, 28 Mar 2016 19:10:07 +0000 (19:10 +0000)]
Merge "Recover focus on size change in ListView" into nyc-dev
Paul McLean [Fri, 25 Mar 2016 16:14:27 +0000 (10:14 -0600)]
Added logging to USB Audio connect and disconnect.
This will let us see in bug reports if the USB device in question
is ACTUALLY recognized and added/removed from the audio system.
Bug:
27812441
Change-Id: Id3eb4d4f3f0b1e66a24999706ba589c0962eba58
Wale Ogunwale [Mon, 28 Mar 2016 15:15:27 +0000 (08:15 -0700)]
Show non-top tasks in the docked stack in recents.
Allows the user to access the task through recents since
it isn't currently visible on screen.
Also, changed recents to launch task currently in the docked
stack in the fullscreen stack when selected from recents list.
Bug:
27864383
Change-Id: I58549023920d064a30b6355367c3193ce3207bbd
Pirama Arumuga Nainar [Mon, 28 Mar 2016 19:00:00 +0000 (12:00 -0700)]
[RenderScript] Fail with Exception from validateObjectIsPrimitiveArray
Bug: http://b/
25982676
Instead of returning null from validateObjectIsPrimitiveArray, fail with
an exception. The callers of this function do not check for null.
Change-Id: Idd2b50a7b137e8d2db7a334bb9a48c1b19ee2403
Mitchell Wills [Mon, 28 Mar 2016 18:41:02 +0000 (18:41 +0000)]
Merge "Add accessor for buckets scanned in ScanData" into nyc-dev
Chris Craik [Mon, 28 Mar 2016 18:30:21 +0000 (18:30 +0000)]
Merge "Consume TextureView matrix safely" into nyc-dev
Lifu Tang [Mon, 28 Mar 2016 18:22:26 +0000 (18:22 +0000)]
Merge "Added missing constants to GnssMeasurement" into nyc-dev
Yohei Yukawa [Mon, 28 Mar 2016 18:20:55 +0000 (18:20 +0000)]
Merge "Dump more info for View when IMM#DEBUG is true." into nyc-dev
Andrii Kulian [Mon, 28 Mar 2016 17:37:44 +0000 (10:37 -0700)]
Fix API numbering issues
This fixes issues with API numbering introduced in
2e751b8c778fd991fcdcec3bc2d1f32a722f436b.
Original commit replaced 'minimalSize' resource with 'minimalWidth' and
'minimalHeight' and 'make update-api' shifted the numbering of other resources.
This change reverts the shift, reuses number of 'minimalSize' and adds
another one new.
Bug:
27528326
Change-Id: I7d327f00043c2bd2aab7285e03223a042e8c97a3
Dianne Hackborn [Sat, 26 Mar 2016 01:48:15 +0000 (18:48 -0700)]
Fix issue #
27776639: Background Check: Conn_Change...
...shouldnt be received when app is awake
(Really any implicit broadcast.)
Fix up a few things so we are more strict when not in lenient
mode.
Change-Id: I3c711525787e07ea7c604d0f9bc123e02448fa68
Yohei Yukawa [Mon, 28 Mar 2016 17:55:24 +0000 (17:55 +0000)]
Merge "Clean-up a workaround that is no longer necessary." into nyc-dev
Chad Brubaker [Sun, 27 Mar 2016 06:04:04 +0000 (23:04 -0700)]
Use X509ExtendedTrustManagers
Move the X509TrustManagers for the Network Security Config from
X509TrustManagers to X509ExtendedTrustManagers.
Bug:
27271561
Change-Id: I084a6c6022fe69730192d2bdcbabaf58e8f92f04
Chris Craik [Mon, 28 Mar 2016 17:47:51 +0000 (17:47 +0000)]
Merge "Add a couple more tests around bitmap uploads" into nyc-dev
Eino-Ville Talvala [Mon, 28 Mar 2016 17:47:19 +0000 (17:47 +0000)]
Merge "Camera: Add bandaid for preview orientation on reverse-landscape cameras" into nyc-dev
Makoto Onuki [Mon, 28 Mar 2016 17:40:58 +0000 (10:40 -0700)]
ShortcutManager: Cleanup package info handling
Bug
27548047
Change-Id: I598b25d1901230cec6fb3760fe5efeff3b3fef96
George Mount [Mon, 28 Mar 2016 17:21:10 +0000 (17:21 +0000)]
Merge "If resume occurs, force finish of exiting activity." into nyc-dev
George Mount [Mon, 28 Mar 2016 17:20:52 +0000 (17:20 +0000)]
Merge "Disable suppressLayout in Visibility Activity Transitoins." into nyc-dev
Chris Craik [Sat, 26 Mar 2016 01:34:11 +0000 (18:34 -0700)]
Consume TextureView matrix safely
Fixes:
27825042
TextureView's matrix may not be set at record time - delay using it
until on RenderThread, when deferring the op.
Change-Id: Icf8b55d656e304ec049ca803b042dc2359482db2
Yigit Boyar [Fri, 25 Mar 2016 00:44:28 +0000 (17:44 -0700)]
Recover focus on size change in ListView
This CL fixes a bug in ListView where if items are not selectable,
not focusable(in terms of ListView flags) but get focus (because
they can), ListView would not recover the focus properly although
it would make the child visible.
The major issue seems like AbsListView marks data set changed when
the list resizes. It seems like a workaround for some other issue
and the code is from 2009 so instead of changing it, I've decided
to implement a workaround to minimize the potential of breaking
something else.
Bug:
27488391
Change-Id: I5babd00e97bba7cb8cc9cfd0697ef79dfae12b97
Deepanshu Gupta [Mon, 28 Mar 2016 17:07:12 +0000 (17:07 +0000)]
Merge "Fix menu popup rendering" into nyc-dev
Andreas Gampe [Mon, 28 Mar 2016 17:01:09 +0000 (17:01 +0000)]
Merge "[STOPSHIP] PackageManager: Add package setting flag for N upgrade" into nyc-dev
Tao Bao [Mon, 28 Mar 2016 17:00:04 +0000 (17:00 +0000)]
Merge "RecoverySystemService: Dump exception stack on IOExceptions." into nyc-dev
Andrii Kulian [Mon, 28 Mar 2016 16:59:26 +0000 (16:59 +0000)]
Merge "Use correct task bounds after updating override config" into nyc-dev
Deepanshu Gupta [Mon, 28 Mar 2016 16:57:24 +0000 (09:57 -0700)]
Fix menu popup rendering
Change-Id: I3394866d72af7fd1762ac477529a4a1bc473b7dc
Jeff Sharkey [Mon, 28 Mar 2016 16:35:43 +0000 (16:35 +0000)]
Merge "Work around buggy DMAgent." into nyc-dev
Makoto Onuki [Mon, 28 Mar 2016 16:32:45 +0000 (16:32 +0000)]
Merge "ShortcutManager: Handle package broadcasts." into nyc-dev
Tenghui Zhu [Mon, 28 Mar 2016 16:30:56 +0000 (16:30 +0000)]
Merge "Update the Drawable.inflate() documentation" into nyc-dev
Felipe Leme [Mon, 28 Mar 2016 16:28:21 +0000 (16:28 +0000)]
Merge "More Data Saver / Battery Saver modes cleanup" into nyc-dev
Aga Wronska [Mon, 28 Mar 2016 16:18:56 +0000 (16:18 +0000)]
Merge "Add full bar mode for search view on small devices" into nyc-dev
Aga Wronska [Fri, 25 Mar 2016 01:22:09 +0000 (18:22 -0700)]
Add full bar mode for search view on small devices
Fixed:
27406434
Change-Id: I828ff72752cdb35dff453ea405209f169e550c1a
Calin Juravle [Mon, 28 Mar 2016 15:44:49 +0000 (15:44 +0000)]
Merge "Read "dalvik.vm.usejitprofiles" for package compile command" into nyc-dev
Andreas Gampe [Sat, 26 Mar 2016 03:03:51 +0000 (20:03 -0700)]
[STOPSHIP] PackageManager: Add package setting flag for N upgrade
First upgrade to N level needs to compile apps with the first-boot
reason, as profiles are missing. The SDK level check does not work
for the preview, as the version is not incremented, yet.
Add a flag to the package settings to track the status.
Note: STOPSHIP, this will be reverted before release.
Bug:
27689078
Bug:
27872764
Change-Id: Ifd460d5235348f041ef64c9b61068af47113ddcb
Calin Juravle [Mon, 28 Mar 2016 11:31:52 +0000 (12:31 +0100)]
Read "dalvik.vm.usejitprofiles" for package compile command
Bug:
27859630
Change-Id: I8c6fff6762646e4abe5b72428c23ceefa90b1f53
Jeff Sharkey [Mon, 28 Mar 2016 15:14:07 +0000 (09:14 -0600)]
Work around buggy DMAgent.
They're targeting new API level, but they aren't handling the new
constants.
Bug:
27785116
Change-Id: I8391294d963c86af1f948b91c7d1de6b7f44f66a
Geoff Mendal [Mon, 28 Mar 2016 14:49:37 +0000 (14:49 +0000)]
Merge "Import translations. DO NOT MERGE" into nyc-dev
Jeff Sharkey [Mon, 28 Mar 2016 14:48:46 +0000 (14:48 +0000)]
Merge "Freeze apps during upgrade, check if uninstalled." into nyc-dev
Geoff Mendal [Mon, 28 Mar 2016 14:46:31 +0000 (07:46 -0700)]
Import translations. DO NOT MERGE
Change-Id: Ib89b994dbaf04d2c068f33cdf084a90fe9cab769
Auto-generated-cl: translation import
Jason Monk [Mon, 28 Mar 2016 14:46:05 +0000 (14:46 +0000)]
Merge "Make sure settings tiles pick up locale changes" into nyc-dev
Jason Monk [Mon, 28 Mar 2016 14:44:43 +0000 (10:44 -0400)]
Make sure settings tiles pick up locale changes
Bug:
27727312
Change-Id: Ic54437805bb264dd8e569ac38673c5ee36b2378a
Wale Ogunwale [Mon, 28 Mar 2016 14:43:51 +0000 (07:43 -0700)]
Don't show home activity when exiting split-screen with recents visible
If we will be focusing on the home stack next and its current top activity
is visible, then use it as the next task to display vs the return to value.
Bug:
27859516
Bug:
27776008
Change-Id: I5aec0bafb07b7c7391608efdfbdc46b1496d6b57
George Mount [Mon, 28 Mar 2016 14:33:47 +0000 (14:33 +0000)]
Merge "Wrong layout file chosen for 6" phones." into nyc-dev
Geoff Mendal [Mon, 28 Mar 2016 14:32:58 +0000 (14:32 +0000)]
Merge "Import translations. DO NOT MERGE" into nyc-dev
Geoff Mendal [Mon, 28 Mar 2016 14:32:42 +0000 (14:32 +0000)]
Merge "Import translations. DO NOT MERGE" into nyc-dev
Geoff Mendal [Mon, 28 Mar 2016 14:32:11 +0000 (14:32 +0000)]
Merge "Import translations. DO NOT MERGE" into nyc-dev
Derek Sollenberger [Mon, 28 Mar 2016 14:31:16 +0000 (14:31 +0000)]
Merge "Compute text bounds on a per glyph basis when drawing from an SkPicture." into nyc-dev
Geoff Mendal [Mon, 28 Mar 2016 14:27:25 +0000 (07:27 -0700)]
Import translations. DO NOT MERGE
Change-Id: If53b6bafc90089964ee5de76e683bf196160c171
Auto-generated-cl: translation import
Geoff Mendal [Mon, 28 Mar 2016 14:26:36 +0000 (07:26 -0700)]
Import translations. DO NOT MERGE
Change-Id: I8e62258c3b6d7a4a3a201084410e6420eaf8fbfa
Auto-generated-cl: translation import
Jason Monk [Mon, 28 Mar 2016 14:19:49 +0000 (10:19 -0400)]
QS: Toggle flashlight on long click
Bug:
27599572
Change-Id: Ie333a7b5cc63fa8e9536ed705ca997c8a8409d22
Geoff Mendal [Mon, 28 Mar 2016 14:18:33 +0000 (07:18 -0700)]
Import translations. DO NOT MERGE
Change-Id: I841ff855e2ecfa65c2ce1e7432c9f5c67543ad4e
Auto-generated-cl: translation import
Jason Monk [Mon, 28 Mar 2016 14:18:02 +0000 (14:18 +0000)]
Merge "Update the QS page indicator" into nyc-dev
Jason Monk [Mon, 28 Mar 2016 14:12:44 +0000 (14:12 +0000)]
Merge "Don't show low battery notification if bat saver" into nyc-dev
Jason Monk [Wed, 16 Mar 2016 13:18:35 +0000 (09:18 -0400)]
QS edit drag and drop accessibility
Bug:
27667843
Change-Id: Ief0980af25d855942b0565e5a9bfcc0d266bdbe0
Shubham Ajmera [Mon, 28 Mar 2016 10:57:29 +0000 (10:57 +0000)]
Merge "Add OpenJDK Arrays parallelSetAll methods" into nyc-dev
Shubham Ajmera [Mon, 28 Mar 2016 10:53:20 +0000 (11:53 +0100)]
Add OpenJDK Arrays parallelSetAll methods
Adds parallelSetAll(int[], java.util.function.IntUnaryOperator),
parallelSetAll(long[], java.util.function.IntToLongFunction),
parallelSetAll(double[], java.util.function.IntToDoubleFunction),
parallelSetAll(T[], java.util.function.IntFunction<? extends T>)
from the upstream along with the corresponding tests.
Bug:
27540010
(cherry-picked from commit
4293e554dbdc7aae8f965b8da96be03219584a17)
Change-Id: Iaa4a0749d8bb95ea8a0072a43bfbd6d6f459ff28
Calin Juravle [Mon, 28 Mar 2016 10:26:34 +0000 (10:26 +0000)]
Merge "Don't check if forward locked apps are used by others" into nyc-dev
Yohei Yukawa [Mon, 28 Mar 2016 08:52:47 +0000 (01:52 -0700)]
Dump more info for View when IMM#DEBUG is true.
This is a preparation CL to fix Bug
27858665. In order to debug issues
like this, we want to record following information about View.
- Whether the View is focused or not.
- Whether the Window to which the View belongs is focused or not.
- Whether the View belongs to a Window or not.
This CL has no impact on production build where IMM#DEBUG is false.
Bug:
18920212
Change-Id: I06bcd5e42d55f96a9e916eb34ed7785cfe14c96f
Yohei Yukawa [Mon, 28 Mar 2016 07:28:50 +0000 (00:28 -0700)]
Clean-up a workaround that is no longer necessary.
With the previous commit [1], now Bug
27868748 is fixed and Bug
6789252
is no longer reproducible even without a workaround [2] for that. Hence
this CL logically reverts [2] in favor of simplicity.
[1]: If2a03bc84d318775fd4a197fa43acde086eda442
aaa38c9f1ae019f0fe8c3ba80630f26e582cc89c
[2]: I66f51da1299532793ef8fa700f35b0811670f235
4e5184f929d2498714bc7734fe10b9b8810cb071
Bug:
27868748
Change-Id: Ic59af43343eb44d1d2c23a3f4018565e7a75b143
Yohei Yukawa [Mon, 28 Mar 2016 06:47:47 +0000 (06:47 +0000)]
Merge "Ensure IC#finishComposingText() is called on the correct Handler." into nyc-dev
Yohei Yukawa [Mon, 28 Mar 2016 06:46:04 +0000 (23:46 -0700)]
Ensure IC#finishComposingText() is called on the correct Handler.
This attempts to reland previously reverted CLs [1][2] due to an
unexpected regression (Bug
27824691).
The Bug
27868748 we want to address by this CL is that currently
InputConnection#finishComposingText() can be called on the root view's
Handler no matter what Handler is associated with
ControlledInputConnectionWrapper. Actually the root cause of
Bug
6789252 is the same, but there we worked around it by not calling
InputConnection#finishComposingText() in certain situations [3].
With this CL we should be able to logically revert that workaround.
This CL also removes redundant IMM#mServedInputConnection. This is safe
because the following two fields have the same lifetime.
- InputMethodManager#mServedInputConnection
- InputMethodManager#mServedInputConnectionWrapper
We do not need to maintain both of them. This also allows us to use a
strong refecente in IInputConnectionWrapper#mInputConnection instead of
a WeakReference. To understand why this is safe, we need to understand
how things previously worked, which is as follows:
1. InputMethodManager#mServedInputConnection becomes non-null.
-> IInputConnectionWrapper#mInputConnection.get() is guaranteed to
be alive.
2. InputMethodManager#mServedInputConnection becomes null or another
object.
-> IInputConnectionWrapper#mInputConnection.get() may not be alive.
Since we know exactly when InputMethodManager#mServedInputConnection is
updated, in theory we do not need to use WeakReference here, and
with this CL we do not use WeakReference anymore. Actually the initial
commit [1] accidentally removed the last strong reference to the active
InputConnection and WeakReference could be null at any time, which was
what we observed in Bug
27824691.
[1]: I1181e067aa5bedbdf0c7ec1bcec479257aea511c
afb6558c8f5e0ee797b252558d7e529e3d946d8f
[2]: Ibe94f115e607a198d12ecd3d4e4f91a7d9469c98
16e2c7b59aacf44df7aaa0d04e0228240907487f
[3]: I66f51da1299532793ef8fa700f35b0811670f235
4e5184f929d2498714bc7734fe10b9b8810cb071
Bug:
27868748
Change-Id: If2a03bc84d318775fd4a197fa43acde086eda442