OSDN Git Service

android-x86/external-bluetooth-bluez.git
10 years agolib: Add missing structure for accept physical link command
Marcel Holtmann [Tue, 8 Oct 2013 13:08:56 +0000 (06:08 -0700)]
lib: Add missing structure for accept physical link command

10 years agolib: Fix a few whitespace damages
Marcel Holtmann [Tue, 8 Oct 2013 11:12:25 +0000 (04:12 -0700)]
lib: Fix a few whitespace damages

10 years agolib: Update company identifiers
Marcel Holtmann [Tue, 8 Oct 2013 06:45:52 +0000 (23:45 -0700)]
lib: Update company identifiers

10 years agotools: Print PAL version for AMP controllers
Marcel Holtmann [Mon, 7 Oct 2013 22:33:13 +0000 (15:33 -0700)]
tools: Print PAL version for AMP controllers

10 years agolib: Add special functions for PAL version mapping
Marcel Holtmann [Mon, 7 Oct 2013 22:32:40 +0000 (15:32 -0700)]
lib: Add special functions for PAL version mapping

10 years agomonitor: Differntiate between LMP and PAL version information
Marcel Holtmann [Mon, 7 Oct 2013 21:53:38 +0000 (14:53 -0700)]
monitor: Differntiate between LMP and PAL version information

10 years agomonitor: Fix broken assoc_fragment structure value
Marcel Holtmann [Mon, 7 Oct 2013 19:47:07 +0000 (12:47 -0700)]
monitor: Fix broken assoc_fragment structure value

10 years agomonitor: Fix wrong event code for channel selected event
Marcel Holtmann [Mon, 7 Oct 2013 17:05:54 +0000 (10:05 -0700)]
monitor: Fix wrong event code for channel selected event

10 years agoobexd/session: Fix crash while disconnecting
Luiz Augusto von Dentz [Mon, 7 Oct 2013 15:44:44 +0000 (18:44 +0300)]
obexd/session: Fix crash while disconnecting

Requests need to be cancelled when obc_session_shutdown is called
otherwise they can trigger the callback with invalid/freed data as in
the following backtrace:
Invalid read of size 8
   at 0x426684: setpath_cb (session.c:998)
   by 0x412AEB: handle_response (gobex.c:949)
   by 0x413010: incoming_data (gobex.c:1192)
   by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x40D59C: main (main.c:319)
 Address 0x571f598 is 40 bytes inside a block of size 56 free'd
   at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x3D4604D9AE: g_free (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x426EA9: obc_session_shutdown (session.c:555)
   by 0x4254B4: remove_session (manager.c:62)
   by 0x43DC53: process_message.isra.5 (object.c:259)
   by 0x3D4981CE85: ??? (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x3D4980FA30: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x43A9D7: message_dispatch (mainloop.c:76)
   by 0x3D46048962: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)

10 years agomonitor: Fix typo in command constant
Marcel Holtmann [Mon, 7 Oct 2013 12:26:26 +0000 (05:26 -0700)]
monitor: Fix typo in command constant

10 years agomonitor: Add support for decoding location data commands
Marcel Holtmann [Mon, 7 Oct 2013 12:05:05 +0000 (05:05 -0700)]
monitor: Add support for decoding location data commands

10 years agoBluetooth: Add definitions for location data commands
Marcel Holtmann [Mon, 7 Oct 2013 11:51:04 +0000 (04:51 -0700)]
Bluetooth: Add definitions for location data commands

10 years agomonitor: Add support for decoding flow control mode commands
Marcel Holtmann [Mon, 7 Oct 2013 11:39:37 +0000 (04:39 -0700)]
monitor: Add support for decoding flow control mode commands

10 years agoBluetooth: Add definitions for flow control mode commands
Marcel Holtmann [Mon, 7 Oct 2013 11:39:14 +0000 (04:39 -0700)]
Bluetooth: Add definitions for flow control mode commands

10 years agotools: Fix hciconfig device information printout for AMP controllers
Marcel Holtmann [Mon, 7 Oct 2013 10:33:29 +0000 (03:33 -0700)]
tools: Fix hciconfig device information printout for AMP controllers

10 years agomonitor: Fix flow specification modify complete event name
Marcel Holtmann [Mon, 7 Oct 2013 10:05:36 +0000 (03:05 -0700)]
monitor: Fix flow specification modify complete event name

10 years agomonitor: Fix physical link disconnection complete event name
Marcel Holtmann [Mon, 7 Oct 2013 09:23:04 +0000 (02:23 -0700)]
monitor: Fix physical link disconnection complete event name

10 years agotools/l2cap-tester: Fix closing server sockets in time
Johan Hedberg [Sun, 6 Oct 2013 15:38:17 +0000 (18:38 +0300)]
tools/l2cap-tester: Fix closing server sockets in time

We should use the teardown function instead of the destroy function for
closing server sockets since otherwise tests may conflict with each
other.

10 years agoemulator: Add support for read local amp assoc command
Marcel Holtmann [Sat, 5 Oct 2013 17:31:14 +0000 (10:31 -0700)]
emulator: Add support for read local amp assoc command

10 years agoemulator: Add some extra long option strings
Marcel Holtmann [Sat, 5 Oct 2013 16:52:10 +0000 (09:52 -0700)]
emulator: Add some extra long option strings

10 years agoemulator: Make unix server sockets optional
Marcel Holtmann [Sat, 5 Oct 2013 15:27:50 +0000 (08:27 -0700)]
emulator: Make unix server sockets optional

10 years agoemulator: Exit with failure when Virtual HCI setup fails
Marcel Holtmann [Sat, 5 Oct 2013 15:19:58 +0000 (08:19 -0700)]
emulator: Exit with failure when Virtual HCI setup fails

10 years agoemulator: Add command line option for AMP controllers
Marcel Holtmann [Sat, 5 Oct 2013 15:19:04 +0000 (08:19 -0700)]
emulator: Add command line option for AMP controllers

10 years agoemulator: Add special Virtual HCI setup command
Marcel Holtmann [Sat, 5 Oct 2013 15:15:41 +0000 (08:15 -0700)]
emulator: Add special Virtual HCI setup command

10 years agomonitor: Use special hash and randomizer print functions
Marcel Holtmann [Sat, 5 Oct 2013 13:28:39 +0000 (06:28 -0700)]
monitor: Use special hash and randomizer print functions

10 years agomonitor: Mark hash and randomizer as P-192 versions
Marcel Holtmann [Sat, 5 Oct 2013 13:26:33 +0000 (06:26 -0700)]
monitor: Mark hash and randomizer as P-192 versions

10 years agomonitor: Update EIR and AD information elements
Marcel Holtmann [Sat, 5 Oct 2013 13:20:42 +0000 (06:20 -0700)]
monitor: Update EIR and AD information elements

10 years agomonitor: Fix EIR Data Type / AD Type assigned numbers
João Paulo Rechi Vita [Tue, 1 Oct 2013 23:04:37 +0000 (20:04 -0300)]
monitor: Fix EIR Data Type / AD Type assigned numbers

The values for Public Target Address and Random Target Address were
swapped. This information can be verified in the Bluetooth SIG Assigned
numbers webpage:

https://www.bluetooth.org/en-us/specification/assigned-numbers/generic-access-profile

10 years agomonitor: Add translation of Bluetooth version information
Marcel Holtmann [Sat, 5 Oct 2013 13:05:17 +0000 (06:05 -0700)]
monitor: Add translation of Bluetooth version information

10 years agoandroid: Android version of log.c
Frederic Danis [Fri, 4 Oct 2013 11:48:47 +0000 (14:48 +0300)]
android: Android version of log.c

Add logging for Android, currently print logs to stderr and stdout.

10 years agobuild: Add BlueZ Android daemon
Frederic Danis [Fri, 4 Oct 2013 11:48:46 +0000 (14:48 +0300)]
build: Add BlueZ Android daemon

10 years agoandroid-build: Add BlueZ Android daemon
Frederic Danis [Fri, 4 Oct 2013 11:48:45 +0000 (14:48 +0300)]
android-build: Add BlueZ Android daemon

Define local mapping to glib path, otherwise this has to be inside central
place in the build repository.

10 years agoandroid: Add skeleton of BlueZ Android daemon
Frederic Danis [Fri, 4 Oct 2013 11:48:44 +0000 (14:48 +0300)]
android: Add skeleton of BlueZ Android daemon

10 years agobuild: Add skeleton for BlueZ Android
Frederic Danis [Fri, 4 Oct 2013 11:48:43 +0000 (14:48 +0300)]
build: Add skeleton for BlueZ Android

Retrieve Bluetooth version from configure.ac.

10 years agobuild-sys: Add missing $(AM_CFLAGS) to obexd_src_obexd_CFLAGS
Szymon Janc [Fri, 4 Oct 2013 09:05:38 +0000 (11:05 +0200)]
build-sys: Add missing $(AM_CFLAGS) to obexd_src_obexd_CFLAGS

This fix not passing extra build flags when --enable-maintainer-mode
is used.

10 years agoobexd/MAP: Fix protected property value
Szymon Janc [Fri, 4 Oct 2013 09:05:37 +0000 (11:05 +0200)]
obexd/MAP: Fix protected property value

"Sent" flag value was returned instead of "Protected" one.
This also fix following build error:

  CC     obexd/client/obexd-map.o
obexd/client/map.c:711:17: error: ‘get_protected’ defined but not
    used [-Werror=unused-function]
cc1: all warnings being treated as errors

10 years agoobexd/client: Remove unused static functions
Szymon Janc [Fri, 4 Oct 2013 09:05:36 +0000 (11:05 +0200)]
obexd/client: Remove unused static functions

This fix following build error:

  CC     obexd/client/obexd-dbus.o
obexd/client/dbus.c:70:13: error: ‘append_array_variant’ defined but
    not used [-Werror=unused-function]
obexd/client/dbus.c:97:13: error: ‘append_dict_variant’ defined but
    not used [-Werror=unused-function]

10 years agoclient/transfer: Return "error" for unknown status in status2str
Szymon Janc [Fri, 4 Oct 2013 09:05:35 +0000 (11:05 +0200)]
client/transfer: Return "error" for unknown status in status2str

This can happen only if there is a bug in obexd code.
This fix following build error:

  CC     obexd/client/obexd-transfer.o
obexd/client/transfer.c: In function ‘status2str’:
obexd/client/transfer.c:277:1: error: control reaches end of non-void
    function [-Werror=return-type]

10 years agoobexd/MAP: Fix missing include
Szymon Janc [Fri, 4 Oct 2013 09:05:34 +0000 (11:05 +0200)]
obexd/MAP: Fix missing include

This fix following build error:

  CC     obexd/client/obexd-map.o
obexd/client/map.c: In function ‘msg_element’:
obexd/client/map.c:1113:2: error: implicit declaration of function ‘strtoull’ [-Werror=implicit-function-declaration]

10 years agoobexd/service: Remove unused local variable
Szymon Janc [Fri, 4 Oct 2013 09:05:33 +0000 (11:05 +0200)]
obexd/service: Remove unused local variable

This fix following build error:

  CC     obexd/src/obexd-service.o
obexd/src/service.c: In function ‘obex_service_driver_register’:
obexd/src/service.c:100:10: error: unused variable ‘l’ [-Werror=unused-variable]

10 years agoobexd: Return "error" for unknown status in status2str
Szymon Janc [Fri, 4 Oct 2013 09:05:32 +0000 (11:05 +0200)]
obexd: Return "error" for unknown status in status2str

This can happend only if there is a bug in obexd code.
This fix following buld error:

  CC     obexd/src/obexd-manager.o
obexd/src/manager.c: In function ‘status2str’:
obexd/src/manager.c:292:1: error: control reaches end of non-void
    function [-Werror=return-type]

10 years agoobexd: Remove unused local variables
Szymon Janc [Fri, 4 Oct 2013 09:05:31 +0000 (11:05 +0200)]
obexd: Remove unused local variables

This fix following build errors:

obexd/src/manager.c: In function ‘get_root’:
obexd/src/manager.c:253:23: error: unused variable ‘os’
    [-Werror=unused-variable]

obexd/src/manager.c: In function ‘manager_emit_transfer_started’:
obexd/src/manager.c:534:22: error: unused variable ‘id’
    [-Werror=unused-variable]

obexd/src/manager.c: In function ‘manager_request_authorization’:
obexd/src/manager.c:684:14: error: unused variable ‘type’
    [-Werror=unused-variable]
obexd/src/manager.c:683:14: error: unused variable ‘filename’
    [-Werror=unused-variable]

10 years agoobexd: Remove unused static functions
Szymon Janc [Fri, 4 Oct 2013 09:05:30 +0000 (11:05 +0200)]
obexd: Remove unused static functions

This fix following build error:

obexd/src/manager.c: At top level:
obexd/src/manager.c:190:13: error:
     ‘dbus_message_iter_append_dict_entry’ defined but not used
     [-Werror=unused-function]

10 years agoobexd/MAP: Remove unused mas_drivers variable
Szymon Janc [Fri, 4 Oct 2013 09:05:29 +0000 (11:05 +0200)]
obexd/MAP: Remove unused mas_drivers variable

This fix following build error:

  CC     obexd/client/obexd-mns.o
obexd/client/mns.c:344:38: error: ‘mas_drivers’ defined but not used
    [-Werror=unused-variable]
cc1: all warnings being treated as errors

10 years agoobexd/MAP: Fix missing include
Szymon Janc [Fri, 4 Oct 2013 09:05:28 +0000 (11:05 +0200)]
obexd/MAP: Fix missing include

This fix following build error:

  CC     obexd/client/obexd-mns.o
obexd/client/mns.c: In function ‘parse_event_report_handle’:
obexd/client/mns.c:187:2: error: implicit declaration of function
    ‘strtoull’ [-Werror=implicit-function-declaration]

10 years agoobexd/MAP: Fix missing include
Szymon Janc [Fri, 4 Oct 2013 09:05:27 +0000 (11:05 +0200)]
obexd/MAP: Fix missing include

This fix following build error:

  CC     obexd/client/obexd-mns.o
obexd/client/mns.c: In function ‘mns_connect’:
obexd/client/mns.c:105:2: error: implicit declaration of function
    ‘manager_register_session’ [-Werror=implicit-function-declaration]
obexd/client/mns.c: In function ‘mns_disconnect’:
obexd/client/mns.c:128:2: error: implicit declaration of function
    ‘manager_unregister_session’ [-Werror=implicit-function-declaration]

10 years agoobexd/bluetooth: Make dict_append_entry function static
Szymon Janc [Fri, 4 Oct 2013 09:05:26 +0000 (11:05 +0200)]
obexd/bluetooth: Make dict_append_entry function static

This fix following build error:

  CC     obexd/plugins/obexd-bluetooth.o
obexd/plugins/bluetooth.c:242:6: error: no previous declaration for
     ‘dict_append_entry’ [-Werror=missing-declarations]

10 years agoobexd/bluetooth: Remove unused local variables
Szymon Janc [Fri, 4 Oct 2013 09:05:25 +0000 (11:05 +0200)]
obexd/bluetooth: Remove unused local variables

This ix following build errors:

  CC     obexd/plugins/obexd-bluetooth.o
obexd/plugins/bluetooth.c: In function ‘register_profile_reply’:
obexd/plugins/bluetooth.c:202:10: error: unused variable ‘err’
    [-Werror=unused-variable]

obexd/plugins/bluetooth.c: In function ‘name_acquired’:
obexd/plugins/bluetooth.c:367:15: error: unused variable ‘uuid’
    [-Werror=unused-variable]

obexd/plugins/bluetooth.c: In function ‘name_released’:
obexd/plugins/bluetooth.c:389:15: error: unused variable ‘uuid’
    [-Werror=unused-variable]

obexd/plugins/bluetooth.c: In function ‘bluetooth_start’:
obexd/plugins/bluetooth.c:400:10: error: unused variable ‘ios’
    [-Werror=unused-variable]

10 years agoobexd/MAP: Fix invalid snprintf format string in map_msg_get()
Szymon Janc [Fri, 4 Oct 2013 07:01:25 +0000 (09:01 +0200)]
obexd/MAP: Fix invalid snprintf format string in map_msg_get()

obexd/client/map.c: In function ‘map_msg_get’:
obexd/client/map.c:446:2: warning: format ‘%u’ expects argument of type
     ‘unsigned int’, but argument 4 has type ‘uint64_t’ [-Wformat]
obexd/client/map.c:446:2: warning: format ‘%u’ expects argument of type
     ‘unsigned int’, but argument 4 has type ‘uint64_t’ [-Wformat]

10 years agodoc: Correct a few minor style issues
Marcel Holtmann [Fri, 4 Oct 2013 06:04:07 +0000 (23:04 -0700)]
doc: Correct a few minor style issues

10 years agodoc: Add missing title text to static address command
Marcel Holtmann [Thu, 3 Oct 2013 16:14:07 +0000 (09:14 -0700)]
doc: Add missing title text to static address command

10 years agoobexd/MAP: Store message handle in binary format
Luiz Augusto von Dentz [Thu, 3 Oct 2013 12:42:37 +0000 (15:42 +0300)]
obexd/MAP: Store message handle in binary format

This is more efficient in terms of memory and hash lookups, it is also
not prone to string format bugs in remote stacks such as leading zeros
being treated as a different handle as can be experience with
Nokia N950 which sends events using a handle with leading zeros but
message listing don't have them.

10 years agoobexd/session: Fix crash while processing command queue
Luiz Augusto von Dentz [Thu, 3 Oct 2013 11:18:21 +0000 (14:18 +0300)]
obexd/session: Fix crash while processing command queue

session_process_queue can call a callback which can cause the session to
be freed:
Invalid write of size 4
   at 0x4265C9: session_process (session.c:716)
   by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x40D55C: main (main.c:319)
 Address 0x4d658a8 is 104 bytes inside a block of size 120 free'd
   at 0x4A074C4: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x3D4604D9AE: g_free (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x4265B1: session_process_queue (session.c:794)
   by 0x4265C8: session_process (session.c:714)
   by 0x3D46047E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3D46048559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x40D55C: main (main.c:319)

10 years agoobexd: Prefix folders in event reports with leading slash
Christian Fetzer [Tue, 24 Sep 2013 14:16:07 +0000 (16:16 +0200)]
obexd: Prefix folders in event reports with leading slash

The internal representation of folder paths starts with a leading slash.
Therefore we have to prepend it to the folders received in event reports.

10 years agoobexd: Handle message shift and message deleted events
Christian Fetzer [Tue, 24 Sep 2013 14:16:06 +0000 (16:16 +0200)]
obexd: Handle message shift and message deleted events

Update Folder propery if the message has been shifted or deleted.

10 years agoobexd: Update Status property in map documentation
Christian Fetzer [Tue, 24 Sep 2013 14:16:04 +0000 (16:16 +0200)]
obexd: Update Status property in map documentation

For outgoing messages, the status field values are:
"delivery-success", "sending-success", "delivery-failure", "sending-failure"

10 years agoobexd: Handle message status events
Christian Fetzer [Tue, 24 Sep 2013 14:16:03 +0000 (16:16 +0200)]
obexd: Handle message status events

For outgoing messages, the message status is changed when an event
indicates that the sending/delivery has failed or succeeded.

10 years agoobexd: Handle new message event
Christian Fetzer [Tue, 24 Sep 2013 14:16:01 +0000 (16:16 +0200)]
obexd: Handle new message event

Register new org.bluez.obex.Message1 D-Bus object when a NewMessage
event report has arrived.

10 years agotools/l2cap-tester: Make setup_powered_server() enable LE advertising when necessary
Johan Hedberg [Tue, 24 Sep 2013 13:11:00 +0000 (16:11 +0300)]
tools/l2cap-tester: Make setup_powered_server() enable LE advertising when necessary

10 years agotools/l2cap-tester: Rename generic test_bredr_server() to test_server()
Johan Hedberg [Tue, 24 Sep 2013 12:53:43 +0000 (15:53 +0300)]
tools/l2cap-tester: Rename generic test_bredr_server() to test_server()

10 years agotools/l2cap-tester: Fix passing correct psm to create_l2cap_sock()
Johan Hedberg [Tue, 24 Sep 2013 12:52:07 +0000 (15:52 +0300)]
tools/l2cap-tester: Fix passing correct psm to create_l2cap_sock()

10 years agotools/l2cap-tester: Separate server and client setup routines
Johan Hedberg [Thu, 19 Sep 2013 18:22:00 +0000 (21:22 +0300)]
tools/l2cap-tester: Separate server and client setup routines

10 years agotools/l2cap-tester: Add LE support
Johan Hedberg [Thu, 19 Sep 2013 16:59:30 +0000 (19:59 +0300)]
tools/l2cap-tester: Add LE support

10 years agobnep: improve error-msg if bnep.ko is not loaded
David Herrmann [Wed, 2 Oct 2013 15:57:31 +0000 (17:57 +0200)]
bnep: improve error-msg if bnep.ko is not loaded

bnep.ko, besides others, can be disabled in custom kernels if
network-support is not required. To avoid strange error messages, handle
EPROTONOSUPPORT as a special case and emit a warning that kernel support
is missing.

10 years agoplugin: handle ENOSYS as not-supported
David Herrmann [Wed, 2 Oct 2013 15:57:30 +0000 (17:57 +0200)]
plugin: handle ENOSYS as not-supported

Allow plugins to return -ENOSYS during registration and handle it as
"not-supported" error. It makes the error messages slightly more useful in
case kernel-support is missing for a particular subsystem.

10 years agomonitor: Fail on invalid command line parameters
Marcel Holtmann [Thu, 3 Oct 2013 03:46:06 +0000 (20:46 -0700)]
monitor: Fail on invalid command line parameters

10 years agomonitor: Use different tables for BR/EDR and LE L2CAP signal channels
Marcel Holtmann [Wed, 2 Oct 2013 15:24:12 +0000 (08:24 -0700)]
monitor: Use different tables for BR/EDR and LE L2CAP signal channels

10 years agodoc/mgmt-api: Add definition for Set Static Address
Johan Hedberg [Wed, 2 Oct 2013 13:21:42 +0000 (16:21 +0300)]
doc/mgmt-api: Add definition for Set Static Address

10 years agotools/btmgmt: Fix small copy&paste issue
Marcel Holtmann [Wed, 2 Oct 2013 13:14:43 +0000 (06:14 -0700)]
tools/btmgmt: Fix small copy&paste issue

10 years agotools/btmgmt: Add support for setting static address
Marcel Holtmann [Wed, 2 Oct 2013 13:13:55 +0000 (06:13 -0700)]
tools/btmgmt: Add support for setting static address

10 years agolib: Add define for mgmt_set_static_address
Marcel Holtmann [Wed, 2 Oct 2013 13:12:06 +0000 (06:12 -0700)]
lib: Add define for mgmt_set_static_address

10 years agotools/mgmt-tester: Fix expected response code for start_discovery case
Johan Hedberg [Wed, 2 Oct 2013 12:48:41 +0000 (15:48 +0300)]
tools/mgmt-tester: Fix expected response code for start_discovery case

10 years agoobexd: Fix emitting Type property changed signals for messages
Christian Fetzer [Tue, 24 Sep 2013 11:27:08 +0000 (13:27 +0200)]
obexd: Fix emitting Type property changed signals for messages

In order to determine if the message Type property has changed,
the stored type needs to be compared with the parsed type and not with
the raw value received from the MSE.

This fixes the issue that the property changed signal for the Type
property is emitted for every message on every ListMessage call.

10 years agosdp: Check for correct pkt size received instead of error
Andrei Emeltchenko [Tue, 1 Oct 2013 11:57:34 +0000 (14:57 +0300)]
sdp: Check for correct pkt size received instead of error

Check that the full header is received in recv().

10 years agolib: Fix invalid "whitespace" on company identifier string
Anderson Lizardo [Tue, 1 Oct 2013 14:11:22 +0000 (10:11 -0400)]
lib: Fix invalid "whitespace" on company identifier string

Somehow, the invalid multibyte sequence "\xC2\xA0" (which is displayed
as a whitespace) was inserted on a company identifier string. Fix this
to avoid a bogus diff when running tools/update_compids.sh.

10 years agotools: Fix update_compids.sh to avoid non-ASCII output
Anderson Lizardo [Tue, 1 Oct 2013 15:46:06 +0000 (11:46 -0400)]
tools: Fix update_compids.sh to avoid non-ASCII output

Some distros have html2text patches that may generate non-ASCII output
even when -ascii is used. This patch adds another case (seen in Fedora)
where HTML entity   (non-breaking space) is converted into a
multibyte whitespace.

Also add a sanity check to make sure non-ASCII text is not introduced in
lib/bluetooth.c.

10 years agodoc: Small beautification
Marcel Holtmann [Wed, 2 Oct 2013 11:01:54 +0000 (04:01 -0700)]
doc: Small beautification

10 years agotools/mgmt-tester: Add some basic set_bredr set cases
Johan Hedberg [Wed, 2 Oct 2013 09:01:34 +0000 (12:01 +0300)]
tools/mgmt-tester: Add some basic set_bredr set cases

10 years agotools/btmgmt: Add support for set_bredr
Johan Hedberg [Wed, 2 Oct 2013 07:41:48 +0000 (10:41 +0300)]
tools/btmgmt: Add support for set_bredr

10 years agolib: Add define for mgmt_set_bredr
Johan Hedberg [Wed, 2 Oct 2013 07:43:23 +0000 (10:43 +0300)]
lib: Add define for mgmt_set_bredr

10 years agodoc/mgmt-api: Add Set BR/EDR command definition
Johan Hedberg [Wed, 2 Oct 2013 09:16:43 +0000 (12:16 +0300)]
doc/mgmt-api: Add Set BR/EDR command definition

10 years agotools/btmgmt: Fix minor whitespace issue
Johan Hedberg [Wed, 2 Oct 2013 07:41:30 +0000 (10:41 +0300)]
tools/btmgmt: Fix minor whitespace issue

10 years agotools/mgmt-tester: Update expected settings to support recent HS changes
Johan Hedberg [Tue, 1 Oct 2013 06:29:12 +0000 (09:29 +0300)]
tools/mgmt-tester: Update expected settings to support recent HS changes

10 years agotools/mgmt-tester: Add test cases for enabling high speed
Marcel Holtmann [Tue, 1 Oct 2013 05:02:59 +0000 (22:02 -0700)]
tools/mgmt-tester: Add test cases for enabling high speed

10 years agotools/mgmt-tester: Cleanup indentation of test cases
Marcel Holtmann [Tue, 1 Oct 2013 04:37:45 +0000 (21:37 -0700)]
tools/mgmt-tester: Cleanup indentation of test cases

10 years agolib: Fix use of uninitialized variable in sdp_set_profile_descs
Szymon Janc [Mon, 30 Sep 2013 13:06:03 +0000 (15:06 +0200)]
lib: Fix use of uninitialized variable in sdp_set_profile_descs

Error path on default case was not breaking loop. To keep error
handling similar all error path were converted to use goto.

This fix following:
target  C: libbluetooth <= external/bluetooth/bluez/android/../lib/sdp.c
lib/sdp.c: In function 'sdp_set_profile_descs':
lib/sdp.c:487:10: warning: 'values[0]' may be used uninitialized in
    this function [-Wmaybe-uninitialized]
lib/sdp.c:2562:19: note: 'values[0]' was declared here
lib/sdp.c:545:11: warning: 'dtds[0]' may be used uninitialized in this
    function [-Wmaybe-uninitialized]
lib/sdp.c:2562:9: note: 'dtds[0]' was declared here

10 years agotest/test-hfp: Fix passing missing backlog parameter to sco.listen()
Johan Hedberg [Sat, 28 Sep 2013 19:49:24 +0000 (22:49 +0300)]
test/test-hfp: Fix passing missing backlog parameter to sco.listen()

10 years agoobexd/client: Fix not setting Transfer.Size for GET operations
Luiz Augusto von Dentz [Fri, 27 Sep 2013 11:21:36 +0000 (14:21 +0300)]
obexd/client: Fix not setting Transfer.Size for GET operations

GET operations may return the length header in the first response which
should be set as transfer Size property.

10 years agogobex: Revert g_obex_pending_req_abort to static pending_req_abort
Luiz Augusto von Dentz [Tue, 24 Sep 2013 14:14:25 +0000 (17:14 +0300)]
gobex: Revert g_obex_pending_req_abort to static pending_req_abort

This reverts the changes introduced in
9095deb82572112fc0870095bf2222964610eafe that made pending_req_abort
public which is not necessary considering g_obex_cancel_req can do the
same and is safe to call even if the request is not pending.

10 years agogobex: Fix crash on g_obex_pending_req_abort
Luiz Augusto von Dentz [Tue, 24 Sep 2013 14:34:02 +0000 (17:34 +0300)]
gobex: Fix crash on g_obex_pending_req_abort

It is not safe to call g_obex_pending_req_abort directly as pending_req
can be NULL:
Invalid read of size 4
   at 0x41231E: g_obex_pending_req_abort (gobex.c:693)
   by 0x416A8A: g_obex_cancel_transfer (gobex-transfer.c:647)
   by 0x42DEF2: obc_transfer_cancel (transfer.c:180)
   by 0x43D833: process_message.isra.5 (object.c:259)
   by 0x3B0701CE85: ??? (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x3B0700FA30: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x43A5B7: message_dispatch (mainloop.c:76)
   by 0x3B03C48962: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3B03C47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3B03C48157: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3B03C48559: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x40D53C: main (main.c:319)
 Address 0x30 is not stack'd, malloc'd or (recently) free'd

10 years agotools: Limit controller type to two bits of device info type
Marcel Holtmann [Sun, 29 Sep 2013 04:00:02 +0000 (21:00 -0700)]
tools: Limit controller type to two bits of device info type

10 years agolib: Update company identifiers
Marcel Holtmann [Sat, 28 Sep 2013 07:05:50 +0000 (00:05 -0700)]
lib: Update company identifiers

10 years agoobexd/bluetooth: Fix memory leak when adapter is off
Luiz Augusto von Dentz [Wed, 25 Sep 2013 15:03:21 +0000 (18:03 +0300)]
obexd/bluetooth: Fix memory leak when adapter is off

sdp_connect fails when Bluetooth adapter is off which leads to the
following leak:
37 bytes in 1 blocks are definitely lost in loss record 68 of 165
   at 0x4A06409: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x3B03C4D89E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3B03C64BAE: g_strdup (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x427D5D: bluetooth_connect (bluetooth.c:410)
   by 0x426CC9: obc_session_create (session.c:454)
   by 0x425693: create_session (manager.c:203)
   by 0x43D8A3: process_message.isra.5 (object.c:259)
   by 0x3B0701CE85: ??? (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x3B0700FA30: dbus_connection_dispatch (in /usr/lib64/libdbus-1.so.3.7.4)
   by 0x43A627: message_dispatch (mainloop.c:76)
   by 0x3B03C48962: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3)
   by 0x3B03C47E05: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3600.3)

10 years agoobexd: Clarify the folder property of PushMessage
Christian Fetzer [Mon, 23 Sep 2013 09:24:29 +0000 (11:24 +0200)]
obexd: Clarify the folder property of PushMessage

The folder property of PushMessages does not accept path information,
it allows only to request the messages to be added to a subfolder of the
current folder.

10 years agoobexd: Clarify the folder property of ListMessages
Christian Fetzer [Mon, 23 Sep 2013 09:24:28 +0000 (11:24 +0200)]
obexd: Clarify the folder property of ListMessages

The folder property of ListMessages does not accept path information,
it allows only to request the messages of a subfolder of the current
folder.

10 years agoobexd: Fix setting message folder for relative folder in ListMessages
Christian Fetzer [Mon, 23 Sep 2013 09:24:27 +0000 (11:24 +0200)]
obexd: Fix setting message folder for relative folder in ListMessages

The method ListMessages allows to specify a relative subfolder.
This subfolder needs to be added to the current path when registering
a new message interface.

10 years agoobexd: Add folder property to map_msg_create
Christian Fetzer [Mon, 23 Sep 2013 09:24:26 +0000 (11:24 +0200)]
obexd: Add folder property to map_msg_create

Message interfaces are not necessarily created for the current folder,
therefore the folder needs to be specified in a parameter.

For example, messages can be created for sub folders when using the folder
parameter in ListMessages.

10 years agodoc: Update description for Set Advertising command
Marcel Holtmann [Wed, 25 Sep 2013 16:32:04 +0000 (09:32 -0700)]
doc: Update description for Set Advertising command

10 years agotools/mgmt-tester: Add basic rejection test case for LE advertising
Johan Hedberg [Tue, 24 Sep 2013 12:38:18 +0000 (15:38 +0300)]
tools/mgmt-tester: Add basic rejection test case for LE advertising

10 years agotools/mgmt-tester: Add basic LE advertising success test cases
Johan Hedberg [Tue, 24 Sep 2013 12:36:02 +0000 (15:36 +0300)]
tools/mgmt-tester: Add basic LE advertising success test cases