OSDN Git Service

android-x86/art.git
10 years agoam 277a7c7b: ART: Fix dex file verifier type-list handling
Andreas Gampe [Tue, 2 Sep 2014 16:31:44 +0000 (16:31 +0000)]
am 277a7c7b: ART: Fix dex file verifier type-list handling

* commit '277a7c7b4bb9c421380592fd3998d2e79e4035b3':
  ART: Fix dex file verifier type-list handling

10 years agoART: Fix dex file verifier type-list handling
Andreas Gampe [Fri, 29 Aug 2014 23:07:49 +0000 (16:07 -0700)]
ART: Fix dex file verifier type-list handling

It is rare, but valid, to have an empty type list.

Bug: 17327877
Change-Id: Ib3a8ff3e5ccd8fe7c04b1e97485bf3e6de72aa4d

10 years agoam 20632daa: Merge "Add native memory accounting through custom allocator." into...
Mathieu Chartier [Sat, 30 Aug 2014 01:49:42 +0000 (01:49 +0000)]
am 20632daa: Merge "Add native memory accounting through custom allocator." into lmp-dev

* commit '20632daac36995947d2d1943f89f07ac277e61f0':
  Add native memory accounting through custom allocator.

10 years agoMerge "Add native memory accounting through custom allocator." into lmp-dev
Mathieu Chartier [Sat, 30 Aug 2014 01:17:19 +0000 (01:17 +0000)]
Merge "Add native memory accounting through custom allocator." into lmp-dev

10 years agoAdd native memory accounting through custom allocator.
Mathieu Chartier [Mon, 25 Aug 2014 20:08:22 +0000 (13:08 -0700)]
Add native memory accounting through custom allocator.

Added a custom allocator that lets you pass in a special tag which
specifices where the allocation came from. This is used when
dumping. The performance overhead is low since each allocation only
does a atomic add/sub for each allocation/free.

The measurements are dumped to traces.txt during SIGQUIT.

Example output:
I/art     (27274): AllocatorTagHeap active=120 max=120 total=168
I/art     (27274): AllocatorTagMonitorList active=1572 max=6240 total=11724
I/art     (27274): AllocatorTagClassTable active=185208 max=185208 total=268608
I/art     (27274): AllocatorTagInternTable active=430368 max=430368 total=436080
I/art     (27274): AllocatorTagMaps active=5616 max=6168 total=34392
I/art     (27274): AllocatorTagLOS active=1024 max=1536 total=2044
I/art     (27274): AllocatorTagSafeMap active=0 max=51936 total=533688
I/art     (27274): AllocatorTagLOSMaps active=144 max=1248 total=5760
I/art     (27274): AllocatorTagReferenceTable active=10944 max=11840 total=19136
I/art     (27274): AllocatorTagHeapBitmap active=32 max=40 total=56
I/art     (27274): AllocatorTagHeapBitmapLOS active=8 max=8 total=8
I/art     (27274): AllocatorTagVerifier active=0 max=18844 total=1073156
I/art     (27274): AllocatorTagModUnionCardSet active=5300 max=5920 total=56020
I/art     (27274): AllocatorTagModUnionReferenceArray active=24864 max=24864 total=24864
I/art     (27274): AllocatorTagJNILibrarires active=320 max=320 total=320
I/art     (27274): AllocatorTagOatFile active=1400 max=1400 total=5852

Bug: 16238192

Change-Id: Ibb470ef2e9c9a24563bb46422d46a55799704d82

10 years agoam 9bf1b088: Merge "Fix mips build for nested signal handler" into lmp-dev
Dave Allison [Fri, 29 Aug 2014 18:31:09 +0000 (18:31 +0000)]
am 9bf1b088: Merge "Fix mips build for nested signal handler" into lmp-dev

* commit '9bf1b088e4e12121037090dd9c92393fbe805cb6':
  Fix mips build for nested signal handler

10 years agoMerge "Fix mips build for nested signal handler" into lmp-dev
Dave Allison [Fri, 29 Aug 2014 18:18:53 +0000 (18:18 +0000)]
Merge "Fix mips build for nested signal handler" into lmp-dev

10 years agoam 496cd337: Fix segfault if running without image.
Alex Light [Fri, 29 Aug 2014 18:18:23 +0000 (18:18 +0000)]
am 496cd337: Fix segfault if running without image.

* commit '496cd337c19ca8386fec24633160f82c01993bbd':
  Fix segfault if running without image.

10 years agoFix mips build for nested signal handler
Dave Allison [Fri, 29 Aug 2014 18:05:17 +0000 (11:05 -0700)]
Fix mips build for nested signal handler

Bug: 17006816

Change-Id: If41c6d7a2f12f1822ca36d9e2f0f22b3ca854098

10 years agoFix segfault if running without image.
Alex Light [Fri, 29 Aug 2014 17:28:25 +0000 (10:28 -0700)]
Fix segfault if running without image.

Bug: 17325091

(cherry picked from commit 7adb7ac3913364de8cc57b8934024dd12e1d3bea)

Change-Id: I343099543ce0abf02219da84d61d9ce2dfc47980

10 years agoam 2cc42e30: Merge "Quick compiler: Fix MIPS build" into lmp-dev
buzbee [Fri, 29 Aug 2014 17:07:52 +0000 (17:07 +0000)]
am 2cc42e30: Merge "Quick compiler: Fix MIPS build" into lmp-dev

* commit '2cc42e3029182ad6c6443376c1a4cbf9c1e6a784':
  Quick compiler: Fix MIPS build

10 years agoMerge "Quick compiler: Fix MIPS build" into lmp-dev
buzbee [Fri, 29 Aug 2014 16:59:46 +0000 (16:59 +0000)]
Merge "Quick compiler: Fix MIPS build" into lmp-dev

10 years agoQuick compiler: Fix MIPS build
buzbee [Thu, 28 Aug 2014 20:48:56 +0000 (13:48 -0700)]
Quick compiler: Fix MIPS build

b/16484538

In debug builds, the Quick compiler frequently runs a sanity checker
over the register pool.  Among other things, it attempts to verify
consistent representation of register pairs.  However, a register's
"wide" flag is meaningful only when the register pair is associated
with a Dalvik wide value (sreg != INVALID_SREG) rather than a temp
wide value.

The MIPS build was tripping over this bad assertion.  Fixed here.

Note related cl/105461

(cherry-picked from commit sha 3a658077af2a931e5d7f6cd22b777c57112c19df)

Change-Id: Id726ff1ea0f5cbcc8dba6fa3aacb3fd4fc043a63

10 years agoam 8ac3356d: Avoid null pointer dereference when sending JDWP packets
Sebastien Hertz [Fri, 29 Aug 2014 12:27:00 +0000 (12:27 +0000)]
am 8ac3356d: Avoid null pointer dereference when sending JDWP packets

* commit '8ac3356db74f5e38c70406cc5f5e65a49ff41fd7':
  Avoid null pointer dereference when sending JDWP packets

10 years agoAvoid null pointer dereference when sending JDWP packets
Sebastien Hertz [Thu, 28 Aug 2014 16:50:36 +0000 (18:50 +0200)]
Avoid null pointer dereference when sending JDWP packets

Bug: 16218394

(cherry picked from commit 60ed7da4d193e0f90b05c4236af77d3b276c0ea4)

Change-Id: I4882b3b6bb97facb8fca4c7ece65f4c7c96c57fe

10 years agoam 6a6a8965: Fix Mac build
Brian Carlstrom [Fri, 29 Aug 2014 05:46:55 +0000 (05:46 +0000)]
am 6a6a8965: Fix Mac build

* commit '6a6a896572a76e3871f5f6b2901e3bb5dec1e2f3':
  Fix Mac build

10 years agoFix Mac build
Brian Carlstrom [Fri, 29 Aug 2014 05:17:13 +0000 (22:17 -0700)]
Fix Mac build

Bug: 17000769,16875245

(cherry picked from commit debdda0262bfbcb966a89e693d933cc74eb412ac)

Change-Id: I158f090c89587f176813a15e9edad917bd134cd0

10 years agoam 6c050b5f: Fix incorect variable name.
Alex Light [Fri, 29 Aug 2014 03:34:25 +0000 (03:34 +0000)]
am 6c050b5f: Fix incorect variable name.

* commit '6c050b5f782b61a16083ae35c98931a2d51d0a33':
  Fix incorect variable name.

10 years agoam 1f019816: Change /dalvik-cache to be owned by root.
Alex Light [Fri, 29 Aug 2014 03:34:19 +0000 (03:34 +0000)]
am 1f019816: Change /dalvik-cache to be owned by root.

* commit '1f0198162044d015072cbb7824f4a6688d0300ee':
  Change /dalvik-cache to be owned by root.

10 years agoFix incorect variable name.
Alex Light [Thu, 28 Aug 2014 23:23:48 +0000 (16:23 -0700)]
Fix incorect variable name.

Bug: 16875245
(cherry picked from commit 1291e9bc87edc8fde56434bc66bef0c62d44a8e6)
Change-Id: Idd0f7ac677568a53569308a67f1ad613584949a5

10 years agoChange /dalvik-cache to be owned by root.
Alex Light [Wed, 27 Aug 2014 22:37:23 +0000 (15:37 -0700)]
Change /dalvik-cache to be owned by root.

Also prune the dalvik-cache during startup if we need to generate or
relocate an image.

Bug: 17000769,16875245

(cherry picked from commit 2539613be94f599c1713627f80c7398028d1a6aa)

Change-Id: I29a70215a2207bc4e0db02ab751d32a68edf4b66

10 years agoam e6caf046: Merge "Fix issue with Thread.setName hanging after Thread.start" into...
Brian Carlstrom [Thu, 28 Aug 2014 22:48:35 +0000 (22:48 +0000)]
am e6caf046: Merge "Fix issue with Thread.setName hanging after Thread.start" into lmp-dev

* commit 'e6caf04639aec134f7b668bf71cd6797a4759dd9':
  Fix issue with Thread.setName hanging after Thread.start

10 years agoMerge "Fix issue with Thread.setName hanging after Thread.start" into lmp-dev
Brian Carlstrom [Thu, 28 Aug 2014 22:23:09 +0000 (22:23 +0000)]
Merge "Fix issue with Thread.setName hanging after Thread.start" into lmp-dev

10 years agoam 7654123b: Merge "Ensure proxy constructor is in dex cache" into lmp-dev
Brian Carlstrom [Thu, 28 Aug 2014 19:01:48 +0000 (19:01 +0000)]
am 7654123b: Merge "Ensure proxy constructor is in dex cache" into lmp-dev

* commit '7654123b2fd7abeb40522dac791fa26a1364d030':
  Ensure proxy constructor is in dex cache

10 years agoMerge "Ensure proxy constructor is in dex cache" into lmp-dev
Brian Carlstrom [Thu, 28 Aug 2014 18:54:15 +0000 (18:54 +0000)]
Merge "Ensure proxy constructor is in dex cache" into lmp-dev

10 years agoam 679c3ced: Merge "Prevent exception bugs in class linker" into lmp-dev
Mathieu Chartier [Thu, 28 Aug 2014 18:48:33 +0000 (18:48 +0000)]
am 679c3ced: Merge "Prevent exception bugs in class linker" into lmp-dev

* commit '679c3cedaf1550113104f5113b23f0fdec6175c0':
  Prevent exception bugs in class linker

10 years agoMerge "Prevent exception bugs in class linker" into lmp-dev
Mathieu Chartier [Thu, 28 Aug 2014 18:37:29 +0000 (18:37 +0000)]
Merge "Prevent exception bugs in class linker" into lmp-dev

10 years agoEnsure proxy constructor is in dex cache
Sebastien Hertz [Wed, 27 Aug 2014 13:32:56 +0000 (15:32 +0200)]
Ensure proxy constructor is in dex cache

Bug: 17262039

(cherry picked from commit ae94e350f100207359b8345d8d21e78e7cfb44c4)

Change-Id: I1cfc8dac1f63b9012fa098804135be8847b1daee

10 years agoFix issue with Thread.setName hanging after Thread.start
Brian Carlstrom [Thu, 28 Aug 2014 06:43:46 +0000 (23:43 -0700)]
Fix issue with Thread.setName hanging after Thread.start

When suspending a thread by peer the invariant that only attached threads are
suspended must be maintained. Add a ThreadList::Contains check which requires
making this method non-static.
Add some extra thread logging.

Bug: 17302037
Change-Id: I89af9840e398c2ceadeb736c431dfe3be8f3ba06

10 years agoPrevent exception bugs in class linker
Mathieu Chartier [Wed, 27 Aug 2014 22:28:28 +0000 (15:28 -0700)]
Prevent exception bugs in class linker

There were some places that could throw exceptions but still succeed.
This caused the allocation entrypoints to occasionally allocate a
heap object with a pending exception.
Also added some additional AssertNoExceptionPending.

Bug: 17164348

Change-Id: Ic6dd3b0cce9955349176503dd7f6c3da7ab0a6f1

10 years agoam 5b41c2a8: Merge "Actually ask the pthread implementation for the stack guard size...
Elliott Hughes [Thu, 28 Aug 2014 17:00:01 +0000 (17:00 +0000)]
am 5b41c2a8: Merge "Actually ask the pthread implementation for the stack guard size." into lmp-dev

* commit '5b41c2a8f8e4a745b18685413b51c883cd993403':
  Actually ask the pthread implementation for the stack guard size.

10 years agoam d1e4e735: Merge "Revert "Avoid using NanoTime for compiler and verifier"" into...
Ian Rogers [Thu, 28 Aug 2014 17:00:00 +0000 (17:00 +0000)]
am d1e4e735: Merge "Revert "Avoid using NanoTime for compiler and verifier"" into lmp-dev

* commit 'd1e4e735cdf98e2ece7fa9a5dfeaad98d0c37cd1':
  Revert "Avoid using NanoTime for compiler and verifier"

10 years agoMerge "Actually ask the pthread implementation for the stack guard size." into lmp-dev
Elliott Hughes [Thu, 28 Aug 2014 16:50:40 +0000 (16:50 +0000)]
Merge "Actually ask the pthread implementation for the stack guard size." into lmp-dev

10 years agoMerge "Revert "Avoid using NanoTime for compiler and verifier"" into lmp-dev
Ian Rogers [Thu, 28 Aug 2014 16:50:38 +0000 (16:50 +0000)]
Merge "Revert "Avoid using NanoTime for compiler and verifier"" into lmp-dev

10 years agoam cd7a048c: Merge "Support booting without functioning boot.oat/art patchoat." into...
Brian Carlstrom [Wed, 27 Aug 2014 23:47:50 +0000 (23:47 +0000)]
am cd7a048c: Merge "Support booting without functioning boot.oat/art patchoat." into lmp-dev

* commit 'cd7a048cfac23e6ec3e1ba3ab4c1dddb322eaadf':
  Support booting without functioning boot.oat/art patchoat.

10 years agoMerge "Support booting without functioning boot.oat/art patchoat." into lmp-dev
Brian Carlstrom [Wed, 27 Aug 2014 23:40:53 +0000 (23:40 +0000)]
Merge "Support booting without functioning boot.oat/art patchoat." into lmp-dev

10 years agoActually ask the pthread implementation for the stack guard size.
Elliott Hughes [Wed, 27 Aug 2014 18:47:01 +0000 (11:47 -0700)]
Actually ask the pthread implementation for the stack guard size.

Bug: 17111575
Change-Id: I23919b1e8aeff627a65daf57f1109bec60b196cc

10 years agoam 074c8c6a: Merge "Avoid using NanoTime for compiler and verifier" into lmp-dev
Mathieu Chartier [Wed, 27 Aug 2014 21:52:49 +0000 (21:52 +0000)]
am 074c8c6a: Merge "Avoid using NanoTime for compiler and verifier" into lmp-dev

* commit '074c8c6aac3bd42a173befd1a4eafd479ef12dc9':
  Avoid using NanoTime for compiler and verifier

10 years agoRevert "Avoid using NanoTime for compiler and verifier"
Ian Rogers [Wed, 27 Aug 2014 21:46:57 +0000 (21:46 +0000)]
Revert "Avoid using NanoTime for compiler and verifier"

This reverts commit c89e6edbdce97c7d199b54bf63aed7ea01ebf1ff.

Change-Id: Id3b89121a19e64bf3c457c39b375f3d3c0fcc579

10 years agoMerge "Avoid using NanoTime for compiler and verifier" into lmp-dev
Mathieu Chartier [Wed, 27 Aug 2014 21:46:42 +0000 (21:46 +0000)]
Merge "Avoid using NanoTime for compiler and verifier" into lmp-dev

10 years agoAvoid using NanoTime for compiler and verifier
Mathieu Chartier [Wed, 27 Aug 2014 21:10:58 +0000 (14:10 -0700)]
Avoid using NanoTime for compiler and verifier

Target timings before with -j2 --compiler-filter=interpret-only:
Approximate speedup 3%.

Before:
real    0m36.852s
real    0m36.050s
real    0m36.246s

After:
real    0m35.667s
real    0m35.779s
real    0m35.458s

Bug: 16853450

Change-Id: Id996172d8283639fe293ddfc26d01fc1a0beed0b

10 years agoam 52fb2a63: Merge "Handle nested signals" into lmp-dev
Dave Allison [Wed, 27 Aug 2014 19:54:05 +0000 (19:54 +0000)]
am 52fb2a63: Merge "Handle nested signals" into lmp-dev

* commit '52fb2a636a082cf5dc4c669a4b34085135709645':
  Handle nested signals

10 years agoSupport booting without functioning boot.oat/art patchoat.
Alex Light [Sat, 23 Aug 2014 00:49:35 +0000 (17:49 -0700)]
Support booting without functioning boot.oat/art patchoat.

Bug: 17000769

(cherry picked from commit 84d7605f93f1e6e86a16e02017e305c90e93117a)

Change-Id: I89c26a905af12ea288742368c2c038afd57a879a

10 years agoMerge "Handle nested signals" into lmp-dev
Dave Allison [Wed, 27 Aug 2014 19:42:39 +0000 (19:42 +0000)]
Merge "Handle nested signals" into lmp-dev

10 years agoam b68c6e57: Reduce interpret-only compile time.
Mathieu Chartier [Wed, 27 Aug 2014 18:58:37 +0000 (18:58 +0000)]
am b68c6e57: Reduce interpret-only compile time.

* commit 'b68c6e578a28a9717d78dfd522d9d9b8befaedf2':
  Reduce interpret-only compile time.

10 years agoReduce interpret-only compile time.
Mathieu Chartier [Tue, 19 Aug 2014 21:29:46 +0000 (14:29 -0700)]
Reduce interpret-only compile time.

Before:
39.04user 5.18system 0:29.24elapsed 151%CPU (0avgtext+0avgdata 164176maxresident)k
38.87user 5.16system 0:29.14elapsed 151%CPU (0avgtext+0avgdata 164144maxresident)k

After:
36.26user 3.25system 0:27.00elapsed 146%CPU (0avgtext+0avgdata 162592maxresident)k
36.25user 3.28system 0:26.28elapsed 150%CPU (0avgtext+0avgdata 162688maxresident)k

Disabled implicit stack protection for the compiler, this reduces page faults.

Added support for not timing every method compilation and verification. NanoTime is
slow and adds ~2 seconds of real time. This is currently enabled since people want
to know which methods are slow to compile.

Bug: 16853450

(cherry picked from commit 8e219ae27624116b6d23e858fb21e93342f81d66)

Change-Id: I349ffb3f36db8c437137387aa6914dc17d743f09

10 years agoHandle nested signals
Dave Allison [Tue, 26 Aug 2014 18:07:58 +0000 (11:07 -0700)]
Handle nested signals

This allows for signals to be raised inside the ART signal handler.
This can occur when the JavaStackTraceHandler attempts to generate
a stack trace and something goes wrong.

It also fixes an issue where the fault manager was not being
correctly shut down inside the signal chaining code.  In this
case the signal handler was not restored to the original.

Bug: 17006816
Bug: 17133266
Change-Id: I9c25bf4f6921e6a107aefbdf47d2c0db9f41508f

10 years agoam f59b605f: Merge "Fix race condition in TransitionCollector." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 18:12:29 +0000 (18:12 +0000)]
am f59b605f: Merge "Fix race condition in TransitionCollector." into lmp-dev

* commit 'f59b605f82c0e2b7bfc6019ee7bd650628f50d3a':
  Fix race condition in TransitionCollector.

10 years agoam ccb1a5d4: ART: Reject field accesses to non-reference vregs.
Stephen Kyle [Tue, 26 Aug 2014 18:12:28 +0000 (18:12 +0000)]
am ccb1a5d4: ART: Reject field accesses to non-reference vregs.

* commit 'ccb1a5d46bc1b4ee888e74775f5c1291d600ff54':
  ART: Reject field accesses to non-reference vregs.

10 years agoMerge "Fix race condition in TransitionCollector." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 18:01:37 +0000 (18:01 +0000)]
Merge "Fix race condition in TransitionCollector." into lmp-dev

10 years agoFix race condition in TransitionCollector.
Mathieu Chartier [Sat, 23 Aug 2014 20:56:03 +0000 (13:56 -0700)]
Fix race condition in TransitionCollector.

There was a minor race condition that could happen if multiple
threads called TransitionCollector at the same time. Starting out
in CMS:

Thread 1: TransitionCollector(SS).
Thread 2: TransitionCollector(CMS) sees that it is already CMS so
has copying_transition == false. But then thread 2 changes to SS.
Thread 1 resumes but incorrectly doesn't check the
disable_moving_gc_count_ possibly resulting in errors if
disable_moving_gc_count_ != 0 due to JNI since we are going from
SS -> CMS and are goign to move objects.

Bug: 17189964

Change-Id: I4f0d002717516b81355d66f26e0e8ebe3958348d

10 years agoART: Reject field accesses to non-reference vregs.
Stephen Kyle [Fri, 22 Aug 2014 14:03:07 +0000 (15:03 +0100)]
ART: Reject field accesses to non-reference vregs.

The verifier will now reject any iget/iput insts
that do not have a reference object in vB.

Bug: 17207857
Signed-off-by: Stuart Monteith <stuart.monteith@arm.com>
(cherry picked from commit 695c5982eeddee18c643cc2f94c9d78fa75599ab)

Change-Id: I3790b8687673643bb142549d74f36a3e2978bf13

10 years agoam 506bcfc6: Merge "Map heap maps at a lower address." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 17:23:17 +0000 (17:23 +0000)]
am 506bcfc6: Merge "Map heap maps at a lower address." into lmp-dev

* commit '506bcfc66454555f792fbc7893ff3b2877c9b288':
  Map heap maps at a lower address.

10 years agoMerge "Map heap maps at a lower address." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 17:15:20 +0000 (17:15 +0000)]
Merge "Map heap maps at a lower address." into lmp-dev

10 years agoam b2634e97: Merge "ART: kSuper also has IncompatibleClassChangeError" into lmp-dev
Andreas Gampe [Tue, 26 Aug 2014 17:14:50 +0000 (17:14 +0000)]
am b2634e97: Merge "ART: kSuper also has IncompatibleClassChangeError" into lmp-dev

* commit 'b2634e9790a7099cf84d3509afe7af18f4349f11':
  ART: kSuper also has IncompatibleClassChangeError

10 years agoam 7f28597b: Merge "ART: Fix IncompatibleClassChange check for ArtMethod" into lmp-dev
Andreas Gampe [Tue, 26 Aug 2014 17:14:49 +0000 (17:14 +0000)]
am 7f28597b: Merge "ART: Fix IncompatibleClassChange check for ArtMethod" into lmp-dev

* commit '7f28597bfa4b5e11911e4d4caa13fe2ab234a53e':
  ART: Fix IncompatibleClassChange check for ArtMethod

10 years agoMerge "ART: kSuper also has IncompatibleClassChangeError" into lmp-dev
Andreas Gampe [Tue, 26 Aug 2014 17:10:28 +0000 (17:10 +0000)]
Merge "ART: kSuper also has IncompatibleClassChangeError" into lmp-dev

10 years agoMerge "ART: Fix IncompatibleClassChange check for ArtMethod" into lmp-dev
Andreas Gampe [Tue, 26 Aug 2014 17:04:14 +0000 (17:04 +0000)]
Merge "ART: Fix IncompatibleClassChange check for ArtMethod" into lmp-dev

10 years agoam 83182ed4: Merge "Reduce lock contention when debugging" into lmp-dev
Sebastien Hertz [Tue, 26 Aug 2014 13:50:57 +0000 (13:50 +0000)]
am 83182ed4: Merge "Reduce lock contention when debugging" into lmp-dev

* commit '83182ed48c55729cd34780fc598f269cc98af739':
  Reduce lock contention when debugging

10 years agoMerge "Reduce lock contention when debugging" into lmp-dev
Sebastien Hertz [Tue, 26 Aug 2014 13:43:17 +0000 (13:43 +0000)]
Merge "Reduce lock contention when debugging" into lmp-dev

10 years agoam cb50ed40: Merge "Quick compiler: fix DCHECK" into lmp-dev
buzbee [Tue, 26 Aug 2014 13:09:04 +0000 (13:09 +0000)]
am cb50ed40: Merge "Quick compiler: fix DCHECK" into lmp-dev

* commit 'cb50ed40fc39a1c1786e57f5c839a3cd230e1744':
  Quick compiler: fix DCHECK

10 years agoMerge "Quick compiler: fix DCHECK" into lmp-dev
buzbee [Tue, 26 Aug 2014 12:58:44 +0000 (12:58 +0000)]
Merge "Quick compiler: fix DCHECK" into lmp-dev

10 years agoam 118785c6: CheckAndClearResolveException should allow LinkageError
Brian Carlstrom [Tue, 26 Aug 2014 11:18:28 +0000 (11:18 +0000)]
am 118785c6: CheckAndClearResolveException should allow LinkageError

* commit '118785c6f82ac1ec7074b5efe367b3dafd904940':
  CheckAndClearResolveException should allow LinkageError

10 years agoCheckAndClearResolveException should allow LinkageError
Brian Carlstrom [Tue, 26 Aug 2014 06:07:30 +0000 (23:07 -0700)]
CheckAndClearResolveException should allow LinkageError

Bug: 16565964
Change-Id: Ibf236c627519a5cdef9479b7bc21e931d5474abf

10 years agoART: kSuper also has IncompatibleClassChangeError
Andreas Gampe [Tue, 26 Aug 2014 03:55:01 +0000 (20:55 -0700)]
ART: kSuper also has IncompatibleClassChangeError

When resolving methods, kSuper can also have
IncompatibleClassChangeError.

Bug: 17266767
Change-Id: I5fafe03ad578f605825a3d0c89f1254a4a385b76

10 years agoART: Fix IncompatibleClassChange check for ArtMethod
Andreas Gampe [Tue, 26 Aug 2014 03:46:31 +0000 (20:46 -0700)]
ART: Fix IncompatibleClassChange check for ArtMethod

In case of kSuper we should complain sometimes.

Bug: 17265201
Change-Id: Ifad903a750495963c7128296713fbd7c4add71cd

10 years agoam eac98d7c: Merge "Reduce GC log spam." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 03:42:19 +0000 (03:42 +0000)]
am eac98d7c: Merge "Reduce GC log spam." into lmp-dev

* commit 'eac98d7cb0f84c664d22deebf1ae5062730d7a31':
  Reduce GC log spam.

10 years agoMerge "Reduce GC log spam." into lmp-dev
Mathieu Chartier [Tue, 26 Aug 2014 03:30:33 +0000 (03:30 +0000)]
Merge "Reduce GC log spam." into lmp-dev

10 years agoReduce GC log spam.
Mathieu Chartier [Tue, 26 Aug 2014 02:46:57 +0000 (19:46 -0700)]
Reduce GC log spam.

Homogeneous compaction and collector transitions now print to
VLOG(gc) instead of LOG(INFO).

Bug: 17166556
Change-Id: I5d54acf36a9b2763922e6329596a2f191d45535c

10 years agoMap heap maps at a lower address.
Mathieu Chartier [Mon, 25 Aug 2014 23:32:41 +0000 (16:32 -0700)]
Map heap maps at a lower address.

We now map the heap mmaps at a lower address in case the app needs
larger continuous address space.

Bug: 16502380

Change-Id: I2cc11d0c207c0eae8db0c5025a48b11119c5a802

10 years agoQuick compiler: fix DCHECK
buzbee [Mon, 25 Aug 2014 16:34:03 +0000 (09:34 -0700)]
Quick compiler: fix DCHECK

A DCHECK intended to verify the soundness of the mapping between
a wide Dalvik value and a pair of temp registers incorrectly fired
when the temp register pair was associated with a wide temporary
(i.e. - when (SReg() == INVALID_SREG)).

In this particular situation, the wideness flag is meaningful only when
there is an associated valid vreg.  Code rearranged to only perform
the DCHECK and reset the partner's wideness bit when we're dealing with
a live wide value.

b/16484538

Change-Id: I3b8a7bebc5d918c65ea56ae8db0a8a5cd8003386

10 years agoam 0699fbf7: Reduce log spam by changing a LOG(INFO) to VLOG(startup)
Alex Light [Mon, 25 Aug 2014 18:57:06 +0000 (18:57 +0000)]
am 0699fbf7: Reduce log spam by changing a LOG(INFO) to VLOG(startup)

* commit '0699fbf769befd3a850005790b26941c38fa2fb4':
  Reduce log spam by changing a LOG(INFO) to VLOG(startup)

10 years agoam 507e6180: Support running without a boot image.
Alex Light [Mon, 25 Aug 2014 18:57:05 +0000 (18:57 +0000)]
am 507e6180: Support running without a boot image.

* commit '507e6180ad271eb719c67ce7394852c731d975a5':
  Support running without a boot image.

10 years agoReduce log spam by changing a LOG(INFO) to VLOG(startup)
Alex Light [Thu, 21 Aug 2014 16:45:00 +0000 (09:45 -0700)]
Reduce log spam by changing a LOG(INFO) to VLOG(startup)

Bug: 17166556

(cherry picked from commit b6cabc1345ec307559a6e85141fb69b7caa9413c)

Change-Id: I9975ba07ad8f119a6e367e2770a60040a462149b

10 years agoSupport running without a boot image.
Alex Light [Tue, 19 Aug 2014 21:23:13 +0000 (14:23 -0700)]
Support running without a boot image.

Bug: 17000769

(cherry picked from commit 64ad14dbe2225441fb7734bf6d89358d96692eea)

Change-Id: I6404d5050c8a2f4ee6e70d58532eb25ee9de248e

10 years agoam 73aa0b03: Merge "Fix GC memory overhead accounting." into lmp-dev
Mathieu Chartier [Mon, 25 Aug 2014 17:54:06 +0000 (17:54 +0000)]
am 73aa0b03: Merge "Fix GC memory overhead accounting." into lmp-dev

* commit '73aa0b03a56a19b73c51136c32624bc5069782e0':
  Fix GC memory overhead accounting.

10 years agoMerge "Fix GC memory overhead accounting." into lmp-dev
Mathieu Chartier [Mon, 25 Aug 2014 17:43:17 +0000 (17:43 +0000)]
Merge "Fix GC memory overhead accounting." into lmp-dev

10 years agoam 83a2192d: Merge "Add fallback for non moving space being full." into lmp-dev
Mathieu Chartier [Sat, 23 Aug 2014 01:20:59 +0000 (01:20 +0000)]
am 83a2192d: Merge "Add fallback for non moving space being full." into lmp-dev

* commit '83a2192d360cdf678c9d4422b5f1bc73d5df602b':
  Add fallback for non moving space being full.

10 years agoMerge "Add fallback for non moving space being full." into lmp-dev
Mathieu Chartier [Sat, 23 Aug 2014 01:01:19 +0000 (01:01 +0000)]
Merge "Add fallback for non moving space being full." into lmp-dev

10 years agoAdd fallback for non moving space being full.
Mathieu Chartier [Fri, 22 Aug 2014 21:53:04 +0000 (14:53 -0700)]
Add fallback for non moving space being full.

When the non moving space becomes full, we disable moving GC and
make the main space the new non moving space.

Also added a runtime option for changing the non moving space size:
-XX:NonMovingSpaceCapacity.

Bug: 17189964
Change-Id: I04d00d0f457f6c1f5724bf32932b6b6ce4d341b1

10 years agoam 1e4fbd8b: Merge "Using the correct time for wait_start_ms when lock contention...
Ian Rogers [Fri, 22 Aug 2014 21:57:17 +0000 (21:57 +0000)]
am 1e4fbd8b: Merge "Using the correct time for wait_start_ms when lock contention logging is enabled" into lmp-dev

* commit '1e4fbd8b7d65064d087c5afe812943b203ed205a':
  Using the correct time for wait_start_ms when lock contention logging is enabled

10 years agoMerge "Using the correct time for wait_start_ms when lock contention logging is enabl...
Ian Rogers [Fri, 22 Aug 2014 21:48:42 +0000 (21:48 +0000)]
Merge "Using the correct time for wait_start_ms when lock contention logging is enabled" into lmp-dev

10 years agoUsing the correct time for wait_start_ms when lock contention logging is enabled
Xin Guan [Fri, 22 Aug 2014 16:55:37 +0000 (11:55 -0500)]
Using the correct time for wait_start_ms when lock contention logging is enabled

Bug: 17208457
Change-Id: I35555e0acf3b37bb3776a62c64d59ae93403b237

10 years agoFix GC memory overhead accounting.
Mathieu Chartier [Thu, 21 Aug 2014 19:21:48 +0000 (12:21 -0700)]
Fix GC memory overhead accounting.

There was some missing null checks.

Bug: 16238192

Change-Id: Iaf8d752db5f21e76f668c0066a063239ff374eee

10 years agoam 1f8ea040: Merge "ART: Allow uninitialized runtime in oat code" into lmp-dev
Andreas Gampe [Fri, 22 Aug 2014 17:20:49 +0000 (17:20 +0000)]
am 1f8ea040: Merge "ART: Allow uninitialized runtime in oat code" into lmp-dev

* commit '1f8ea0402915b394461bb6a3ca58e05c62f63082':
  ART: Allow uninitialized runtime in oat code

10 years agoMerge "ART: Allow uninitialized runtime in oat code" into lmp-dev
Andreas Gampe [Fri, 22 Aug 2014 17:14:12 +0000 (17:14 +0000)]
Merge "ART: Allow uninitialized runtime in oat code" into lmp-dev

10 years agoam fd684f6d: Merge "Always setup the native bridge library" into lmp-dev
Calin Juravle [Fri, 22 Aug 2014 17:00:29 +0000 (17:00 +0000)]
am fd684f6d: Merge "Always setup the native bridge library" into lmp-dev

* commit 'fd684f6d51cf4bee6e7bf62c9d632fbebd7dd8b7':
  Always setup the native bridge library

10 years agoam 84a9ba10: Merge "Fix testing wrong variable for non zygote." into lmp-dev
Mathieu Chartier [Fri, 22 Aug 2014 17:00:29 +0000 (17:00 +0000)]
am 84a9ba10: Merge "Fix testing wrong variable for non zygote." into lmp-dev

* commit '84a9ba10a826b8480be53ea164fc6168544b2a48':
  Fix testing wrong variable for non zygote.

10 years agoMerge "Always setup the native bridge library" into lmp-dev
Calin Juravle [Fri, 22 Aug 2014 16:55:31 +0000 (16:55 +0000)]
Merge "Always setup the native bridge library" into lmp-dev

10 years agoMerge "Fix testing wrong variable for non zygote." into lmp-dev
Mathieu Chartier [Fri, 22 Aug 2014 16:48:58 +0000 (16:48 +0000)]
Merge "Fix testing wrong variable for non zygote." into lmp-dev

10 years agoFix testing wrong variable for non zygote.
Mathieu Chartier [Fri, 22 Aug 2014 01:28:20 +0000 (18:28 -0700)]
Fix testing wrong variable for non zygote.

For non zygote we want to only have a single non moving space to
let dex2oat use RosAlloc for all allocations.

Fixed stale low memory logic in parsed options.

Bug: 17189964
Change-Id: I85a565002fd18ae30105df084796521abd60ea12

10 years agoReduce lock contention when debugging
Sebastien Hertz [Tue, 19 Aug 2014 13:33:43 +0000 (15:33 +0200)]
Reduce lock contention when debugging

Uses a ReaderWriterMutex for the breakpoint lock to reduce contention during
debugging session.

Also adds missing thread safety annotations on fields and methods related to
instrumentation and debugging.

Bug: 16814665
Bug: 11667502
Change-Id: I056cdafa91109e0c83806c8d8df75c37ade0a354

10 years agoAlways setup the native bridge library
Calin Juravle [Fri, 22 Aug 2014 11:53:59 +0000 (12:53 +0100)]
Always setup the native bridge library

... even if the string is empty. This will initialize the native bridge
library but mark it as unavailable.

- also, rename native_bridge_library_path to
native_bridge_library_filename to be closer to the actual meaning (it's
just the filename without any path).

Bug: 16404669.
Change-Id: I94628639691459d48d1fbf0841f36b68d51818e7

10 years agoam e246f336: Fixed wrong field usage in Instrumentation::RemoveListener
Daniel Mihalyi [Fri, 22 Aug 2014 09:20:29 +0000 (09:20 +0000)]
am e246f336: Fixed wrong field usage in Instrumentation::RemoveListener

* commit 'e246f33605a2d6b96f2c7221fa0165dc067c3079':
  Fixed wrong field usage in Instrumentation::RemoveListener

10 years agoam 96add978: Optimized instrumentation listener handling
Daniel Mihalyi [Fri, 22 Aug 2014 09:20:28 +0000 (09:20 +0000)]
am 96add978: Optimized instrumentation listener handling

* commit '96add97815ba8418fb4e8c0fc08dbf9c7198f244':
  Optimized instrumentation listener handling

10 years agoART: Allow uninitialized runtime in oat code
Andreas Gampe [Fri, 22 Aug 2014 06:10:47 +0000 (23:10 -0700)]
ART: Allow uninitialized runtime in oat code

Oatdump does not initialize a runtime. Avoid a segfault.

Bug: 17194559
Change-Id: I1a1bd3fc7762ff4714251617a975e832522fa879

10 years agoFixed wrong field usage in Instrumentation::RemoveListener
Daniel Mihalyi [Thu, 21 Aug 2014 13:57:25 +0000 (15:57 +0200)]
Fixed wrong field usage in Instrumentation::RemoveListener

Signed-off-by: Daniel Mihalyi <daniel.mihalyi@mattakis.com>
Bug: 16814665

(cherry picked from commit 6644521cfaff718a55e3602efb3b54bf19a0cd1a)

Change-Id: Ie68c70ba6ee2e0bd918717c8659c057f98e66ff7

10 years agoOptimized instrumentation listener handling
Daniel Mihalyi [Mon, 18 Aug 2014 16:45:31 +0000 (18:45 +0200)]
Optimized instrumentation listener handling

Some instrumentation listener lists may be modified while iterating
over the list to deliver an instrumentation event. Therefore the
previous implementation copied the list of listeners before starting
the iteration.

This new implementation only copies the list of instrumentation
listeners when the list is changed. Instances of the list are
reference counted using std::shared_ptr<>.

Bug: 16814665

(cherry picked from commit ca1d06cfa2f2b8d2be4390644e126cb68cdbb5ba)

Change-Id: Ib2e6b980de85b75f1c8f4a8825bdc7767154663a

10 years agoam 39c2a379: Merge "Fix fugu build" into lmp-dev
Dave Allison [Fri, 22 Aug 2014 01:19:23 +0000 (01:19 +0000)]
am 39c2a379: Merge "Fix fugu build" into lmp-dev

* commit '39c2a379795460374b41e627257130e3c4ab961f':
  Fix fugu build

10 years agoMerge "Fix fugu build" into lmp-dev
Dave Allison [Fri, 22 Aug 2014 01:09:18 +0000 (01:09 +0000)]
Merge "Fix fugu build" into lmp-dev