OSDN Git Service
Thomas G. Lockhart [Wed, 9 Jun 1999 13:43:42 +0000 (13:43 +0000)]
Make minor changes in wording.
Adjust tags to get a clean build.
Bruce Momjian [Wed, 9 Jun 1999 12:39:46 +0000 (12:39 +0000)]
Remove -O2 for linux/alpha, make -O.
Vadim B. Mikheev [Wed, 9 Jun 1999 12:23:42 +0000 (12:23 +0000)]
Reset evaluation plan tuple table next free slot counter to 0
after ExecEndNode. It must be done! Or we'll be out of free
tuple slots very soon, though slots are freed by ExecEndNode
and ready for reusing.
We didn't see this problem before because of
int nSlots = ExecCountSlotsNode(plan);
TupleTable tupleTable = ExecCreateTupleTable(nSlots + 10);
/* why add ten? - jolly */
code in InitPlan - i.e. extra 10 slots. Simple select uses
3 slots and so it was possible to re-use evaluation plan
3 additional times and didn't get
elog(NOTICE, "Plan requires more slots than are available");
elog(ERROR, "send mail to your local executor guru to fix this");
Changes are obvious and shouldn't be problems with them.
Though, I added Assert(epqstate->es_tupleTable->next == 0)
before EvalPlanQual():ExecInitNode and we'll notice if
something is still wrong. Is it better to change Assert
to elog(ERROR) ?
Vadim B. Mikheev [Wed, 9 Jun 1999 03:51:40 +0000 (03:51 +0000)]
MVCC updates.
Vadim B. Mikheev [Tue, 8 Jun 1999 20:01:01 +0000 (20:01 +0000)]
MVCC updation.
Bruce Momjian [Tue, 8 Jun 1999 19:19:51 +0000 (19:19 +0000)]
Linux-alpha gets -O
Bruce Momjian [Tue, 8 Jun 1999 17:34:43 +0000 (17:34 +0000)]
Remove optimization on linux/alpha.
Bruce Momjian [Tue, 8 Jun 1999 16:42:55 +0000 (16:42 +0000)]
Fix for duplicate LC_COLLATE
Bruce Momjian [Tue, 8 Jun 1999 16:42:10 +0000 (16:42 +0000)]
Add mention of new pg_dump feature.
Bruce Momjian [Tue, 8 Jun 1999 16:27:26 +0000 (16:27 +0000)]
Install proper Irix FAQ.
Bruce Momjian [Tue, 8 Jun 1999 01:37:55 +0000 (01:37 +0000)]
Cleanup
Bruce Momjian [Tue, 8 Jun 1999 01:32:05 +0000 (01:32 +0000)]
Disable pg_upgrade for 6.5.
Bruce Momjian [Mon, 7 Jun 1999 22:58:31 +0000 (22:58 +0000)]
I attach a patch for pg_upgrade. This does two things:
1. check whether the program is being executed in $PGDATA/.. This is
necessary if the data tree is not in the standard place, as is the
case with the Debian distribution (because of Debian policy).
2. give a clearer error message if the dumped data structure fails to
be loaded.
Oliver Elphick
Bruce Momjian [Mon, 7 Jun 1999 17:20:24 +0000 (17:20 +0000)]
On AIX 4.3.2 the third line in template/aix_42:
SHARED_LIB:
needs to be changed to:
SHARED_LIB:-lc
I think this was also needed on AIX 4.2. Comments Please !!
If nobody objects, I suggest to make this change, since it cannot
break AIX 4.2 and is necessary on AIX 4.3
Andreas
Vadim B. Mikheev [Mon, 7 Jun 1999 15:14:54 +0000 (15:14 +0000)]
Concurrency... Highest one...
DO NOT EVEN TRY TO DO PageGetMaxOffsetNumber BEFORE
LockBuffer!
-:)
Bruce Momjian [Mon, 7 Jun 1999 14:29:20 +0000 (14:29 +0000)]
> Here is a small patch that should only affect win32 building
> (native win32, not cygnus).
> It does the following:
> Patches two win32.mak files to DEFINE HAVE_VSNPRINTF and
> HAVE_STRDUP. This is required to build at all.
> Bumps the version number on libpq.dll from 6.4 to 6.5.
> Required for install programs to work.
> Adds defintions for BLCKSZ and MAXIMUM_ALIGN to "win32.h" in
> the client-side libpiq directory.
>
> All these files are only used when building on native win32,
> so it should be safe I think.
>
> Again, really sorry to throw this in so late, but I would
> hate to do the same thing as with 6.4 (which required 6.4.1
> to at all compile on Win32).
>
> Thanks,
>
> //Magnus
Tom Lane [Mon, 7 Jun 1999 14:28:26 +0000 (14:28 +0000)]
Repair recently-introduced error in makeIndexable for LIKE:
a non-leading % would be put into the >=/<= patterns. Also, repair
longstanding confusion about whether %% means a literal %%. The SQL92
doesn't say any such thing, and textlike() knows that, but gram.y didn't.
Vadim B. Mikheev [Mon, 7 Jun 1999 14:28:22 +0000 (14:28 +0000)]
Have to release meta page before reading root one!
< 6.5 versions were just not affected by this bug due to locking.
Bruce Momjian [Mon, 7 Jun 1999 02:42:07 +0000 (02:42 +0000)]
Update TODO.
Vadim B. Mikheev [Sun, 6 Jun 1999 20:19:35 +0000 (20:19 +0000)]
1. xact.c: update comments about changing MyProc->xid and MyProc->xmin.
2. varsup.c:ReadNewTransactionId(): don't read nextXid from disk -
this func doesn't allocate next xid, so ShmemVariableCache->nextXid
may be used (but GetNewTransactionId() must be called first).
3. vacuum.c: change elog(ERROR, "Child item....") to elog(NOTICE) -
this is not ERROR, proper handling is just not implemented, yet.
4. s_lock.c: increase S_MAX_BUSY by 2 times.
5. shmem.c:GetSnapshotData(): have to call ReadNewTransactionId()
_after_ SpinAcquire(ShmemIndexLock).
Tom Lane [Sun, 6 Jun 1999 17:46:40 +0000 (17:46 +0000)]
equal() needs a case for Aggref nodes, as shown by:
regression=> select sum(q1) from int8_tbl group by q2 order by sum(q1);
NOTICE: equal: don't know whether nodes of type 107 are equal
Tom Lane [Sun, 6 Jun 1999 17:41:01 +0000 (17:41 +0000)]
Add a regression test case to catch breakage of GROUP BY
and aggregate functions in queries that use inheritance.
Tom Lane [Sun, 6 Jun 1999 17:38:11 +0000 (17:38 +0000)]
Fix problems with grouping/aggregation in queries that use
inheritance ... basically it was completely busted :-(
Vadim B. Mikheev [Sun, 6 Jun 1999 15:14:40 +0000 (15:14 +0000)]
I used bad style of comments and ... commented out some code in
EvalPlanQualNext() when implemented it... -:)
Uncommented...
Tom Lane [Sat, 5 Jun 1999 20:22:30 +0000 (20:22 +0000)]
Instead of failing when the constructed name for a sequence,
index, etc is too long, truncate until it fits.
Bruce Momjian [Sat, 5 Jun 1999 20:07:54 +0000 (20:07 +0000)]
Update from Massimo
Bruce Momjian [Sat, 5 Jun 1999 19:09:48 +0000 (19:09 +0000)]
Hi,
I have updated my contrib code for version 6.5. In the attachment you will
find the directories array, datetime, miscutil, string, tools and userlocks
which replace the corresponding directories under contrib.
In contrib/tools you will find some developement scripts which I use while
hacking the sources. I hope they will be useful for some other people.
I have also added a contrib/Makefile which tries to compile and install all
the contribs. Unfortunately many of them don't have a Makefile or don't
compile cleanly.
--
Massimo Dal Zotto
Bruce Momjian [Sat, 5 Jun 1999 18:30:43 +0000 (18:30 +0000)]
New FAQ with commerical support mention.
Bruce Momjian [Sat, 5 Jun 1999 18:24:55 +0000 (18:24 +0000)]
Update faq and hpux faq.
Tom Lane [Sat, 5 Jun 1999 18:05:17 +0000 (18:05 +0000)]
Remove redeclarations of default parameter values from
PgDatabase::DisplayTuples and PgDatabase::PrintTuples. This is incorrect
according to strict interpretation of the C++ spec, and some compilers
will reject it. Also silence g++ warning about unused parameter.
Tatsuo Ishii [Sat, 5 Jun 1999 10:27:31 +0000 (10:27 +0000)]
a fix for Win32 support provided by yutaka@marin.or.jp.
The patch will avoid to add .exe suffix to the pg_encoding
binary.
Marc G. Fournier [Sat, 5 Jun 1999 04:18:09 +0000 (04:18 +0000)]
trace.patch (compilation error)
the gettimeofday doesn't compile under Linux with glibc2 because
the DST_NONE constant is no more defined. It seems that this code
(written by me) has always be wrong but for some reason working.
From: Massimo Dal Zotto <dz@cs.unitn.it>
Marc G. Fournier [Sat, 5 Jun 1999 04:15:09 +0000 (04:15 +0000)]
man.patch (make inconsistency)
the default target is 'install' instead of 'all'. So if you do a
make without target you actually do a make install, which is not
what one normally expects from a standard makefile.
From: Massimo Dal Zotto <dz@cs.unitn.it>
Marc G. Fournier [Sat, 5 Jun 1999 04:13:21 +0000 (04:13 +0000)]
ecpg.patch (wrong makefile expansion in some cases)
the ecpg Makefiles use a variable DESTDIR which is never defined
except by debian/rules makefile, in which case the ecpg makefiles
expand wrong pathnames. If we want to support a DESTDIR root it
must be done consistently in all the makefiles, not just in ecpg.
From: Massimo Dal Zotto <dz@cs.unitn.it>
Bruce Momjian [Sat, 5 Jun 1999 03:43:07 +0000 (03:43 +0000)]
Update FAQ's for release.
Bruce Momjian [Sat, 5 Jun 1999 02:47:13 +0000 (02:47 +0000)]
Update with more TODO items.
Tom Lane [Fri, 4 Jun 1999 21:21:13 +0000 (21:21 +0000)]
Suppress indexes on large objects from psql's \d listing;
they were confusing because the large object tables themselves are not
shown. (Besides, if you've got hundreds or thousands of large objects,
you really don't want to see 'em at all.)
Also, suppress all indexes from the \z ACL listing, since indexes have
no meaningful protection information.
Tom Lane [Fri, 4 Jun 1999 21:14:46 +0000 (21:14 +0000)]
Add startup-time check that -B is not unreasonably small for
given number of backends (-N), per recent discussion in pghackers list.
Tom Lane [Fri, 4 Jun 1999 21:13:38 +0000 (21:13 +0000)]
Add configurable option controlling security checks in LO functions.
Tom Lane [Fri, 4 Jun 1999 21:12:07 +0000 (21:12 +0000)]
Turns out OIDNAMELEN wasn't really being used at all!
Get rid of it to make customization of NAMEDATALEN easier.
Thomas G. Lockhart [Fri, 4 Jun 1999 15:51:42 +0000 (15:51 +0000)]
Add blurb on new docs in release notes.
Make minor info and markup changes for v6.5 release.
Thomas G. Lockhart [Fri, 4 Jun 1999 15:50:44 +0000 (15:50 +0000)]
Add input parameters for LOCK TABLE. Still needs explanation from Vadim.
Fix markup.
Thomas G. Lockhart [Fri, 4 Jun 1999 06:31:14 +0000 (06:31 +0000)]
May as well keep an ApplixWare version of this file too.
Thomas G. Lockhart [Fri, 4 Jun 1999 06:24:02 +0000 (06:24 +0000)]
Hardcopy for v6.5 release.
Thomas G. Lockhart [Fri, 4 Jun 1999 06:23:27 +0000 (06:23 +0000)]
Add a mention of doc changes in the release notes.
Thomas G. Lockhart [Fri, 4 Jun 1999 06:23:00 +0000 (06:23 +0000)]
Release notes from sgml for v6.5 release.
Bruce Momjian [Fri, 4 Jun 1999 04:28:54 +0000 (04:28 +0000)]
Add mention of SHARE ROW EXCLUSIVE mode.
Bruce Momjian [Fri, 4 Jun 1999 04:16:11 +0000 (04:16 +0000)]
man page cleanup for vadim.
Bruce Momjian [Fri, 4 Jun 1999 03:44:42 +0000 (03:44 +0000)]
Add description for SET TRANSACTION.
Tom Lane [Fri, 4 Jun 1999 02:19:47 +0000 (02:19 +0000)]
Fix for failure to clean SysCache entry when a relation is deleted
in the same transaction that created it.
Bruce Momjian [Thu, 3 Jun 1999 20:45:08 +0000 (20:45 +0000)]
cleanup
Bruce Momjian [Thu, 3 Jun 1999 20:44:28 +0000 (20:44 +0000)]
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
SET TRANSACTION ISOLATION LEVEL READ COMMITTED;
^^^^ required
Also note that SET TRANSACTION ISOLATION LEVEL change
isolevel for _current_ transaction, in accordance with
standard, not for session (ALTER SESSION is used in Oracle,
but it's not implemented currently).
And I would don't mention SET XACTISOLEVEL TO ...
form at all.
Please update set.sgml - I failed to understand all these
SET TIME ZONE { '<REPLACEABLE CLASS="PARAMETER">
now.
for Vadim
Bruce Momjian [Thu, 3 Jun 1999 20:42:18 +0000 (20:42 +0000)]
Thanks for this, but SET TRANSACTION ISOLATION LEVEL
should be described like SET TIME ZONE: TO is not allowed, as well
as DEFAULT option. There are only two forms:
for Vadim.
Bruce Momjian [Thu, 3 Jun 1999 20:40:50 +0000 (20:40 +0000)]
Update of release notes with new items.
Bruce Momjian [Thu, 3 Jun 1999 19:52:09 +0000 (19:52 +0000)]
Add mention of FOR UPDATE and LIMIT/OFFSET>
Bruce Momjian [Thu, 3 Jun 1999 19:18:00 +0000 (19:18 +0000)]
Update lock sgml/man/psql help pages.
Bruce Momjian [Thu, 3 Jun 1999 18:38:00 +0000 (18:38 +0000)]
Add SET TRANSACTION ISOLATION LEVEL and SET NAMES mention.
Bruce Momjian [Thu, 3 Jun 1999 18:25:27 +0000 (18:25 +0000)]
Update psql help so it looks better.
Bruce Momjian [Thu, 3 Jun 1999 18:18:43 +0000 (18:18 +0000)]
Update SET commands for psql \h, man pages, and sgml.
Thomas G. Lockhart [Thu, 3 Jun 1999 16:13:54 +0000 (16:13 +0000)]
Minor markup fixes.
Thomas G. Lockhart [Thu, 3 Jun 1999 16:13:35 +0000 (16:13 +0000)]
Make separate subsection for Vadim's MVCC notes.
Add timing info for v6.5 on my linux box.
Thomas G. Lockhart [Thu, 3 Jun 1999 16:11:58 +0000 (16:11 +0000)]
Fix markup and formatting.
Thomas G. Lockhart [Thu, 3 Jun 1999 16:05:38 +0000 (16:05 +0000)]
Installation notes for v6.5.
Generated from install.sgml and installation.sgml.
Vadim B. Mikheev [Thu, 3 Jun 1999 13:33:13 +0000 (13:33 +0000)]
1. Additional fix against ERROR: Child itemid marked as unused
in CommitTransaction().
2. Changes in GetSnapshotData().
Vadim B. Mikheev [Thu, 3 Jun 1999 13:25:54 +0000 (13:25 +0000)]
Unuseful tuple.t_data->t_infomask & HEAP_XMIN_COMMITTED in
vc_scanheap().
Vadim B. Mikheev [Thu, 3 Jun 1999 07:11:50 +0000 (07:11 +0000)]
Notes in Migration to v6.5 section.
Vadim B. Mikheev [Thu, 3 Jun 1999 04:41:41 +0000 (04:41 +0000)]
1. MyProc->xid assignment is moved to GetNewTransactionId so newer
transactions will not assume that MyProc transaction was committed
before snapshot calculations. With old MyProc->xid assignment
(in xact.c:StartTransaction()) there was ability to see the same
row twice (I used gdb for this)!...
2. Assignments of InvalidTransactionId to MyProc->xid and MyProc->xmin
are moved from xact.c:CommitTransaction() to
xact.c:RecordTransactionCommit() - this invalidation must be done
before releasing transaction locks or bad (too high) XmaxRecent value
might be used by vacuum ("ERROR: Child itemid marked as unused"
reported by "Hiroshi Inoue" <Inoue@tpf.co.jp>; once again, gdb
allowed me reproduce this error).
Thomas G. Lockhart [Thu, 3 Jun 1999 04:21:51 +0000 (04:21 +0000)]
Markup changes for v6.5 release.
Clean out duplicate stuff in odbc.sgml resulting from a faulty patch.
Thomas G. Lockhart [Thu, 3 Jun 1999 04:20:32 +0000 (04:20 +0000)]
CGM format from Hannu. Seem to have lost the .ag original :(
Thomas G. Lockhart [Thu, 3 Jun 1999 04:18:58 +0000 (04:18 +0000)]
New versions of hardcopy for 6.5 release.
Tom Lane [Thu, 3 Jun 1999 04:01:16 +0000 (04:01 +0000)]
pg_dump failed on any database containing large objects,
because it ignored the LOs themselves but failed to ignore the indexes
on the LOs. How long has this been broken??
Tom Lane [Thu, 3 Jun 1999 03:17:37 +0000 (03:17 +0000)]
Ensure consistent results when FormSortKeys fails to find
all the expected keys (it was returning uninitialized memory).
Tom Lane [Thu, 3 Jun 1999 01:28:24 +0000 (01:28 +0000)]
Ooops ... dllist.c can't use Assert() when it is compiled into
libpq ...
Jan Wieck [Wed, 2 Jun 1999 11:52:29 +0000 (11:52 +0000)]
Changed "current." into "old." in rule string backparsing
Jan
Bruce Momjian [Wed, 2 Jun 1999 03:37:15 +0000 (03:37 +0000)]
The INET and CIDR types mistakenly compared 198.68.123.0/24 and
198.68.123.0/27 the same when indexing them.
D'Arcy
Thomas G. Lockhart [Tue, 1 Jun 1999 17:26:18 +0000 (17:26 +0000)]
Make sure that only one intro is included in the integrated doc.
Multiple intros cause trouble since they have some section elements
(e.g. "y2k.sgml") in common leading to duplicate labels.
Include emacs formatting hints in the intro*.sgml sources.
Vadim B. Mikheev [Tue, 1 Jun 1999 09:35:39 +0000 (09:35 +0000)]
typedef struct LTAG
{
Oid relId;
Oid dbId;
union
{
BlockNumber blkno;
TransactionId xid;
} objId;
>
> Added:
> /*
> * offnum should be part of objId.tupleId above, but would increase
> * sizeof(LOCKTAG) and so moved here; currently used by userlocks only.
> */
> OffsetNumber offnum;
uint16 lockmethod; /* needed by userlocks */
} LOCKTAG;
gmake clean required...
User locks are ready for 6.5 release...
Bruce Momjian [Tue, 1 Jun 1999 02:43:37 +0000 (02:43 +0000)]
forgot to attach the patch. :(
Vince.
Bruce Momjian [Tue, 1 Jun 1999 02:37:33 +0000 (02:37 +0000)]
commented out PgConnection& references for now. May be using them
later.
Vince.
Tom Lane [Mon, 31 May 1999 23:48:04 +0000 (23:48 +0000)]
Fix some latent bugs in dllist.c (carelessness about setting
all fields that should be set). Add a MoveToFront primitive to speed up
one of the hotspots in SearchSysCache.
Tom Lane [Mon, 31 May 1999 22:53:59 +0000 (22:53 +0000)]
Clean up memory leaks in LO operations by freeing LO's private
memory context at transaction commit or abort.
Tom Lane [Mon, 31 May 1999 19:32:47 +0000 (19:32 +0000)]
Generate a more specific error message when an operator used
in an index doesn't have a restriction selectivity estimator.
Tom Lane [Mon, 31 May 1999 18:28:52 +0000 (18:28 +0000)]
Round up shmem size estimate to 1Kb boundary.
Tom Lane [Mon, 31 May 1999 17:01:52 +0000 (17:01 +0000)]
Correct serious bug in hashtable expansion routine: under the
right circumstances it would leave old and new bucket headers pointing to
the same list of records.
Bruce Momjian [Mon, 31 May 1999 16:18:53 +0000 (16:18 +0000)]
NT similar file update.
Vadim B. Mikheev [Mon, 31 May 1999 01:48:13 +0000 (01:48 +0000)]
Release XactLockTable share lock immediately after this lock is acquired
(no sense to hold it) or we'll be out of lock entries.
Great thanks to Hiroshi Inoue.
Tom Lane [Sun, 30 May 1999 15:32:45 +0000 (15:32 +0000)]
Clean up uninitialized-variable warning from egcs.
(Curious that gcc doesn't complain about this code...).
Tom Lane [Sun, 30 May 1999 15:22:34 +0000 (15:22 +0000)]
egcs thinks omitting the return type in a function declaration
is poor coding style. I agree.
Tom Lane [Sun, 30 May 1999 15:17:58 +0000 (15:17 +0000)]
Replace static rcsid[] strings by IDENTIFICATION comments in
file headers, to conform to established Postgres coding style and avoid
warnings from gcc.
Tom Lane [Sun, 30 May 1999 00:06:44 +0000 (00:06 +0000)]
configure.in forgot to do AC_LANG_C to reselect C-based tests
after checking for presence of C++ compiler. Odd we hadn't seen any
reports of problems before...
Tom Lane [Sat, 29 May 1999 16:26:42 +0000 (16:26 +0000)]
Turns out that configure's test for HPUXMATHLIB didn't work
when used with egcs --- now it does.
Vadim B. Mikheev [Sat, 29 May 1999 10:25:33 +0000 (10:25 +0000)]
1. Run all pg_dump queries in single serializable transaction.
2. Get rid of locking when updating statistics in vacuum.
3. Use QuerySnapshot in COPY TO and call SetQuerySnashot
in main tcop loop before FETCH and COPY TO.
Vadim B. Mikheev [Sat, 29 May 1999 06:14:43 +0000 (06:14 +0000)]
Fix xid table sizing.
Tom Lane [Sat, 29 May 1999 03:58:43 +0000 (03:58 +0000)]
Missing semicolons in non-HAS_TEST_AND_SET code paths :-(
Tom Lane [Sat, 29 May 1999 03:17:20 +0000 (03:17 +0000)]
Avoid redundant SysCache searches in coerce_type, for another
few percent speedup in INSERT...
Tom Lane [Sat, 29 May 1999 01:48:06 +0000 (01:48 +0000)]
new_relation_targetlist used to cause about 8 separate (and
redundant) SearchSysCache searches per table column in an INSERT, which
accounted for a good percentage of the CPU time for INSERT ... VALUES().
Now it only does two searches in the typical case.
Tom Lane [Sat, 29 May 1999 01:45:21 +0000 (01:45 +0000)]
Clean up inefficient and just plain bad code in some hot-spot
cache access routines.
Tom Lane [Fri, 28 May 1999 17:03:31 +0000 (17:03 +0000)]
Repair performance problem in SI segment manipulations: iterating
through MAXBACKENDS array entries used to be fine when MAXBACKENDS = 64.
It's not so cool with MAXBACKENDS = 1024 (or more!), especially not in a
frequently-used routine like SIDelExpiredDataEntries. Repair by making
procState array size be the soft MaxBackends limit rather than the hard
limit, and by converting SIGetProcStateLimit() to a macro.
Bruce Momjian [Fri, 28 May 1999 14:24:24 +0000 (14:24 +0000)]
Clean up mention of gmake vs. make.
Bruce Momjian [Fri, 28 May 1999 04:54:34 +0000 (04:54 +0000)]
Update pygresql version stamp.