OSDN Git Service
David Warren [Fri, 1 May 2009 21:22:21 +0000 (14:22 -0700)]
am
01a62ee: AI 148202: Applying changes to build_new_device.jd originall
Merge commit '
01a62eeda8f2065aaf26a02decc615c19b63e967' into donut
* commit '
01a62eeda8f2065aaf26a02decc615c19b63e967':
AI 148202: Applying changes to build_new_device.jd originally made by Reena in CL 148100. I made her edits by hand. The problem is that I moved all content files from docs to docs/guide and she edited the version in docs (which no longer exists).
David Warren [Fri, 1 May 2009 21:22:07 +0000 (14:22 -0700)]
AI 148202: Applying changes to build_new_device.jd originally made by Reena in CL 148100. I made her edits by hand. The problem is that I moved all content files from docs to docs/guide and she edited the version in docs (which no longer exists).
Automated import of CL 148202
Raphael [Fri, 1 May 2009 19:34:14 +0000 (12:34 -0700)]
ADT #
1823896: Ability to add an "extra" action to the AVD Selector.
Used to display the AVD Manager from the Device Chooser/Launch config.
Used to delete AVDs from the AVD Manager.
In AVD Manager, also hide the Cancel button since actions are
immediate and not cancelable.
Android (Google) Code Review [Fri, 1 May 2009 18:09:46 +0000 (11:09 -0700)]
Merge change 856 into donut
* changes:
Modified the command to run native test on the host: - when valgrind is used, the output is discarded, always. - otherwise, the output of the test is printed only when the test failed.
Nicolas Catania [Fri, 1 May 2009 02:27:52 +0000 (19:27 -0700)]
Modified the command to run native test on the host:
- when valgrind is used, the output is discarded, always.
- otherwise, the output of the test is printed only when the test failed.
David Warren [Fri, 1 May 2009 00:27:16 +0000 (17:27 -0700)]
am
2b15cf1: AI 148129: Missing \ in Pdk.Mk causing build to not go throu
Merge commit '
2b15cf1abf2f41e3a9f7edc99d65a9e9d38e6c25' into donut
* commit '
2b15cf1abf2f41e3a9f7edc99d65a9e9d38e6c25':
AI 148129: Missing \ in Pdk.Mk causing build to not go through - Gaurav
Reena Lee [Fri, 1 May 2009 00:27:16 +0000 (17:27 -0700)]
am
390be0e: AI 148128: -Removed "Option1" about using buildspec which is
Merge commit '
390be0e33d61654113b4bdc9b1974b33eebd2205' into donut
* commit '
390be0e33d61654113b4bdc9b1974b33eebd2205':
AI 148128: -Removed "Option1" about using buildspec which is no longer relevant.
David Warren [Fri, 1 May 2009 00:27:15 +0000 (17:27 -0700)]
am
1b4feb4: AI 148118: 2 new debugging docs.
Merge commit '
1b4feb4926e8b34b10569f492a7f06175d3829bb' into donut
* commit '
1b4feb4926e8b34b10569f492a7f06175d3829bb':
AI 148118: 2 new debugging docs.
David Warren [Fri, 1 May 2009 00:27:15 +0000 (17:27 -0700)]
am
e0d7b8a: AI 148117: these docs have moved into "guide" directory.
Merge commit '
e0d7b8a65d51912228d920f8b884f401146531e2' into donut
* commit '
e0d7b8a65d51912228d920f8b884f401146531e2':
AI 148117: these docs have moved into "guide" directory.
David Warren [Fri, 1 May 2009 00:27:14 +0000 (17:27 -0700)]
am
5f6ca4f: AI 148105: Assigning to Ryan for Dr No Approval.
Merge commit '
5f6ca4f519a1a9375628102f284ab059fd0ef4a1' into donut
* commit '
5f6ca4f519a1a9375628102f284ab059fd0ef4a1':
AI 148105: Assigning to Ryan for Dr No Approval.
David Warren [Fri, 1 May 2009 00:23:42 +0000 (17:23 -0700)]
AI 148129: Missing \ in Pdk.Mk causing build to not go through - Gaurav
Automated import of CL 148129
Reena Lee [Fri, 1 May 2009 00:22:16 +0000 (17:22 -0700)]
AI 148128: -Removed "Option1" about using buildspec which is no longer relevant.
-Updated paths to no longer reference device/
Automated import of CL 148128
Android (Google) Code Review [Fri, 1 May 2009 00:18:00 +0000 (17:18 -0700)]
Merge change 839 into donut
* changes:
ADT #
1823896: AVD Manager button in the AVD Selector.
David Warren [Fri, 1 May 2009 00:16:25 +0000 (17:16 -0700)]
AI 148118: 2 new debugging docs.
Automated import of CL 148118
Raphael [Thu, 30 Apr 2009 23:10:47 +0000 (16:10 -0700)]
ADT #
1823896: AVD Manager button in the AVD Selector.
Device chooser: avd manager callback + avd list refresh.
Device chooser: dialog title.
Device launcher tab: avd manager callaback + avd list refresh.
David Warren [Fri, 1 May 2009 00:14:56 +0000 (17:14 -0700)]
AI 148117: these docs have moved into "guide" directory.
Automated import of CL 148117
David Warren [Fri, 1 May 2009 00:11:58 +0000 (17:11 -0700)]
AI 148105: Assigning to Ryan for Dr No Approval.
These are new content files for the partner development kit that will be hosted off of source.android.com externally.
Automated import of CL 148105
Reena Lee [Fri, 1 May 2009 00:09:29 +0000 (17:09 -0700)]
am
9844b75: AI 148100: Testing out PDK updates by updating /device/partn
Merge commit '
9844b7560db1101ef69186fa93fc062ca9fe7c3a' into donut
* commit '
9844b7560db1101ef69186fa93fc062ca9fe7c3a':
AI 148100: Testing out PDK updates by updating /device/partner/ references in the "building a new device" steps
Mike Ritter [Fri, 1 May 2009 00:09:29 +0000 (17:09 -0700)]
am
925f5d2: AI 148090: Whichdoc = online/offline
Merge commit '
925f5d2ee93268cec699210b8f61858211da7289' into donut
* commit '
925f5d2ee93268cec699210b8f61858211da7289':
AI 148090: Whichdoc = online/offline
Reena Lee [Fri, 1 May 2009 00:08:54 +0000 (17:08 -0700)]
AI 148100: Testing out PDK updates by updating /device/partner/ references in the "building a new device" steps
Automated import of CL 148100
Mike Ritter [Fri, 1 May 2009 00:07:19 +0000 (17:07 -0700)]
AI 148090: Whichdoc = online/offline
Whichmodule = pdk for clearsilver
Automated import of CL 148090
Android (Google) Code Review [Thu, 30 Apr 2009 21:37:23 +0000 (14:37 -0700)]
Merge change 822 into donut
* changes:
Move some simulator fixes from master to donut. In git master they were part of change
700ccfcc01d3081ff74ef5006e8f0dec5ac52a96, which was an auto import from //branches/master/...@140412 The original change was 134529 in perforce.
Xavier Ducrohet [Thu, 30 Apr 2009 00:34:38 +0000 (17:34 -0700)]
Display the AVD manager wizard during launches where no compatible AVDs exist.
Marco Nelissen [Thu, 30 Apr 2009 21:11:03 +0000 (14:11 -0700)]
Move some simulator fixes from master to donut.
In git master they were part of change
700ccfcc01d3081ff74ef5006e8f0dec5ac52a96,
which was an auto import from //branches/master/...@140412
The original change was 134529 in perforce.
Android (Google) Code Review [Thu, 30 Apr 2009 18:59:01 +0000 (11:59 -0700)]
Merge change 770 into donut
* changes:
ADT
1603194: Android Package browser for Instrumentation nodes.
Android (Google) Code Review [Thu, 30 Apr 2009 16:41:46 +0000 (09:41 -0700)]
Merge change 776 into donut
* changes:
Make sure we request the Client allocation status even if we fail to open a debugger port for it.
Mike Ritter [Thu, 30 Apr 2009 06:30:44 +0000 (23:30 -0700)]
am
aa2d952: AI 147991: make sources appear in online-pdk/guide
Merge commit '
aa2d95234e8350eebf789da2b976f843318dead8' into donut
* commit '
aa2d95234e8350eebf789da2b976f843318dead8':
AI 147991: make sources appear in online-pdk/guide
Xavier Ducrohet [Thu, 30 Apr 2009 01:18:36 +0000 (18:18 -0700)]
Make sure we request the Client allocation status even if we fail to open a debugger port for it.
Raphael [Thu, 30 Apr 2009 00:32:52 +0000 (17:32 -0700)]
ADT
1603194: Android Package browser for Instrumentation nodes.
Xavier Ducrohet [Wed, 29 Apr 2009 21:38:30 +0000 (14:38 -0700)]
Make sure that any exception during the final packaging properly put an error marker on the project (since build failed.
Android (Google) Code Review [Wed, 29 Apr 2009 19:10:55 +0000 (12:10 -0700)]
Merge change 715 into donut
* changes:
ADT #
1820114: Provide a quick UI to edit AVD.
Raphael [Wed, 29 Apr 2009 06:41:40 +0000 (23:41 -0700)]
ADT #
1820114: Provide a quick UI to edit AVD.
This is temporary and will be replaced once we get the standalone AVD UI.
Mike Ritter [Wed, 29 Apr 2009 16:19:32 +0000 (09:19 -0700)]
AI 147991: make sources appear in online-pdk/guide
BUG=
1815368
Automated import of CL 147991
Scott Main [Wed, 29 Apr 2009 04:53:14 +0000 (21:53 -0700)]
am
705a3ee: AI 147793: cleanup broken links and delete all innacurate in
Merge commit '
705a3ee3975877460c124d98eda12ae16dadd1a6' into donut
* commit '
705a3ee3975877460c124d98eda12ae16dadd1a6':
AI 147793: cleanup broken links and delete all innacurate info in apidemo pages
Android (Google) Code Review [Tue, 28 Apr 2009 20:52:51 +0000 (13:52 -0700)]
Merge change 663 into donut
* changes:
Fix ADT#
1807821: -f option ignored when avd dir already existed.
Android (Google) Code Review [Tue, 28 Apr 2009 20:16:19 +0000 (13:16 -0700)]
Merge change 657 into donut
* changes:
Fix a memory deallocation error that was crashing q2dm.
Jack Veenstra [Tue, 28 Apr 2009 18:33:55 +0000 (11:33 -0700)]
Fix a memory deallocation error that was crashing q2dm.
Also fix a bunch of compile warnings by changing "char *" to "const char *".
Raphael [Tue, 28 Apr 2009 19:54:47 +0000 (12:54 -0700)]
Fix ADT#
1807821: -f option ignored when avd dir already existed.
Also fixed an NPE when parsing some invalid AVDs.
Raphael [Tue, 28 Apr 2009 19:11:03 +0000 (12:11 -0700)]
Fix cygwin git script, we need some of the external projects.
Android (Google) Code Review [Tue, 28 Apr 2009 18:02:14 +0000 (11:02 -0700)]
Merge change 627 into donut
* changes:
Fix a bunch of issues related to packaging the content of libs (NPE with files with no extension, not ignoring ignorable folders). Also fixed an issue when parsing Manifest with <uses-sdk />
Xavier Ducrohet [Tue, 28 Apr 2009 02:02:03 +0000 (19:02 -0700)]
Move ADT to 0.9.1
Xavier Ducrohet [Tue, 28 Apr 2009 01:52:49 +0000 (18:52 -0700)]
Fix a bunch of issues related to packaging the content of libs (NPE with files with no extension, not ignoring ignorable folders). Also fixed an issue when parsing Manifest with <uses-sdk />
Xavier Ducrohet [Tue, 28 Apr 2009 00:38:40 +0000 (17:38 -0700)]
Make traceview compile with the new API from SdkStats.
Android (Google) Code Review [Mon, 27 Apr 2009 23:08:01 +0000 (16:08 -0700)]
Merge change 609 into donut
* changes:
Fix the opt-in window for usage stat so that it works when running from ADT.
Xavier Ducrohet [Mon, 27 Apr 2009 21:58:09 +0000 (14:58 -0700)]
Fix the opt-in window for usage stat so that it works when running from ADT.
Raphael [Mon, 27 Apr 2009 22:01:16 +0000 (15:01 -0700)]
Documents various git issues for Windows.
Raphael [Mon, 27 Apr 2009 01:07:04 +0000 (18:07 -0700)]
Split development/.gitignore into separate gitignore files per project.
Added missing gitignore for layoutlib_utils.
Changed mkstubs build path to use prebuilt/asm-3.1 instead of asm-3.1 project.
Scott Main [Sat, 25 Apr 2009 21:04:53 +0000 (14:04 -0700)]
AI 147793: cleanup broken links and delete all innacurate info in apidemo pages
BUG=
1810005
Automated import of CL 147793
Xavier Ducrohet [Fri, 24 Apr 2009 23:35:32 +0000 (16:35 -0700)]
Add Eclipse projects bin folders to the gitignore list.
Android (Google) Code Review [Fri, 24 Apr 2009 23:08:21 +0000 (16:08 -0700)]
Merge change 556 into donut
* changes:
Fixed a bug in XML parser handler where some words were being split in two. Fixes #
1812655.
Amith Yamasani [Fri, 24 Apr 2009 22:14:02 +0000 (15:14 -0700)]
Fixed a bug in XML parser handler where some words were being split in two. Fixes #
1812655.
Properly concatenate characters to create a full word before adding the word to the tree.
Android (Google) Code Review [Fri, 24 Apr 2009 22:11:52 +0000 (15:11 -0700)]
Merge change 504 into donut
* changes:
Add network statistics collection to monkey runs.
Android (Google) Code Review [Fri, 24 Apr 2009 21:37:17 +0000 (14:37 -0700)]
Merge change 536 into donut
* changes:
ADT #
1810565: Fix symlinks for ADT/DDMS show up in git
Jack Palevich [Fri, 24 Apr 2009 20:04:26 +0000 (13:04 -0700)]
Add a sample showing how to use the new static OpenGL ES bindings.
(Actually repurpose the existing Texture Triangle sample.)
Raphael Moll [Fri, 24 Apr 2009 03:06:36 +0000 (20:06 -0700)]
ADT #
1810565: Fix symlinks for ADT/DDMS show up in git
Use a .gitignore to prevent files created by
./development/tools/eclipse/scripts/create_all_symlinks.sh
from appearing in git.
This is for Linux. Not sure if we need to amend that for Mac/Windows.
Android (Google) Code Review [Thu, 23 Apr 2009 22:06:39 +0000 (15:06 -0700)]
Merge change 506 into donut
* changes:
yuv420sp2rgb: a tool to convert from YUV 4:2:0 semiplanar to various RGB formats
Android (Google) Code Review [Thu, 23 Apr 2009 21:49:30 +0000 (14:49 -0700)]
Merge change 434 into donut
* changes:
Added a method in run_command.py to run a host test. The run can also happen under valgrind.
Dave Bort [Thu, 23 Apr 2009 20:46:58 +0000 (13:46 -0700)]
Add official copyright templates
Signed-off-by: Dave Bort <dbort@android.com>
Jim Miller [Thu, 23 Apr 2009 00:04:48 +0000 (17:04 -0700)]
Add network statistics collection to monkey runs.
Iliyan Malchev [Thu, 23 Apr 2009 20:14:13 +0000 (13:14 -0700)]
yuv420sp2rgb: a tool to convert from YUV 4:2:0 semiplanar to various RGB formats
Signed-off-by: Iliyan Malchev <malchev@google.com>
Jean-Baptiste Queru [Thu, 23 Apr 2009 00:56:50 +0000 (17:56 -0700)]
merge cupcake into donut
Mike Ritter [Wed, 22 Apr 2009 20:45:33 +0000 (13:45 -0700)]
Merge branch 'readonly-p4-donut' into donut
Mike Ritter [Wed, 22 Apr 2009 20:44:21 +0000 (13:44 -0700)]
AI 147382: am: CL 147379 copy pdk templates sub-directories also.
Original author: mritter
Merged from: //branches/cupcake/...
Automated import of CL 147382
Jean-Michel Trivi [Wed, 22 Apr 2009 20:17:57 +0000 (13:17 -0700)]
Merge branch 'readonly-p4-donut' into donut
Jean-Michel Trivi [Wed, 22 Apr 2009 20:16:35 +0000 (13:16 -0700)]
AI 147301: am: CL 147296 Reuse the JetPlayer singleton instance in the initialization of JetBoy instead of destroying it.
Original author: jmtrivi
Merged from: //branches/cupcake/...
Automated import of CL 147301
Xavier Ducrohet [Wed, 22 Apr 2009 19:13:17 +0000 (12:13 -0700)]
AI 147402: Fix plugin.xml to match refactoring of the new file wizard.
Automated import of CL 147402
Nicolas Catania [Wed, 22 Apr 2009 18:08:32 +0000 (11:08 -0700)]
Added a method in run_command.py to run a host test.
The run can also happen under valgrind.
runtest.py: Search for host test as well. Run these under valgrind.
Mike Ritter [Wed, 22 Apr 2009 16:55:08 +0000 (09:55 -0700)]
AI 147379: copy pdk templates sub-directories also.
BUG=
1801344
Automated import of CL 147379
Jean-Michel Trivi [Wed, 22 Apr 2009 01:50:58 +0000 (18:50 -0700)]
AI 147296: Reuse the JetPlayer singleton instance in the initialization of JetBoy instead of destroying it.
BUG=
1804737
Automated import of CL 147296
Xavier Ducrohet [Tue, 21 Apr 2009 23:24:06 +0000 (16:24 -0700)]
Merge branch 'readonly-p4-donut' into donut
Xavier Ducrohet [Tue, 21 Apr 2009 23:22:51 +0000 (16:22 -0700)]
AI 147271: am: CL 147269 Remove "show compass" option as it requires Google Maps dependency.
Original author: xav
Merged from: //branches/cupcake/...
Automated import of CL 147271
Xavier Ducrohet [Tue, 21 Apr 2009 23:20:58 +0000 (16:20 -0700)]
AI 147269: Remove "show compass" option as it requires Google Maps dependency.
BUG=
1804337
Automated import of CL 147269
Raphael Moll [Tue, 21 Apr 2009 22:51:07 +0000 (15:51 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Tue, 21 Apr 2009 22:49:49 +0000 (15:49 -0700)]
AI 147264: am: CL 147262 ADT #
1761055: Pre-select node types when adding node in manifest & resource based on context
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147264
Raphael Moll [Tue, 21 Apr 2009 22:47:39 +0000 (15:47 -0700)]
AI 147262: ADT #
1761055: Pre-select node types when adding node in manifest & resource based on context
BUG=
1761055
Automated import of CL 147262
Jeff Hamilton [Tue, 21 Apr 2009 22:10:49 +0000 (15:10 -0700)]
Merge branch 'readonly-p4-donut' into donut
Jeff Hamilton [Tue, 21 Apr 2009 22:09:35 +0000 (15:09 -0700)]
AI 147247: am: CL 147243 Make the API sample check to see if there is anything installed to handle the recognition intent.
Original author: jham
Merged from: //branches/cupcake/...
Automated import of CL 147247
Jeff Hamilton [Tue, 21 Apr 2009 22:05:59 +0000 (15:05 -0700)]
AI 147243: Make the API sample check to see if there is anything installed to handle the recognition intent.
BUG=
1803523
Automated import of CL 147243
Raphael Moll [Tue, 21 Apr 2009 20:24:01 +0000 (13:24 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Tue, 21 Apr 2009 20:22:51 +0000 (13:22 -0700)]
AI 147193: am: CL 147190 Javadoc for MkStubs.
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147193
Raphael Moll [Tue, 21 Apr 2009 20:20:37 +0000 (13:20 -0700)]
AI 147190: Javadoc for MkStubs.
BUG=
1778786
Automated import of CL 147190
Raphael Moll [Tue, 21 Apr 2009 20:09:20 +0000 (13:09 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Tue, 21 Apr 2009 20:07:50 +0000 (13:07 -0700)]
AI 147177: am: CL 147175 ADT #
1801951: "adb.exe" misses the dot in android_rules.xml
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147177
Raphael Moll [Tue, 21 Apr 2009 20:06:05 +0000 (13:06 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Tue, 21 Apr 2009 20:04:52 +0000 (13:04 -0700)]
AI 147175: ADT #
1801951: "adb.exe" misses the dot in android_rules.xml
BUG=
1801951
Automated import of CL 147175
Raphael Moll [Tue, 21 Apr 2009 20:04:49 +0000 (13:04 -0700)]
AI 147176: am: CL 147174 ADT #
1801919: Make default options output a bit more friendly.
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147176
Raphael Moll [Tue, 21 Apr 2009 20:03:55 +0000 (13:03 -0700)]
AI 147174: ADT #
1801919: Make default options output a bit more friendly.
BUG=
1801919
Automated import of CL 147174
Andy Stadler [Tue, 21 Apr 2009 18:53:02 +0000 (11:53 -0700)]
Merge branch 'readonly-p4-donut' into donut
Andy Stadler [Tue, 21 Apr 2009 18:51:42 +0000 (11:51 -0700)]
AI 147167: am: CL 147162 Emphasize in the javadoc that the "pkg" parameters to
InstrumentationTestCase and its descendants should be the
package manager package name (not the java package name, and
not the test package) of the package holding the Activity
under test.
Added similar notations to the ApiDemos call sites.
JAVADOC ONLY - should be safe change for cupcake sdk.
Original author: stadler
Merged from: //branches/cupcake/...
Automated import of CL 147167
Andy Stadler [Tue, 21 Apr 2009 18:48:53 +0000 (11:48 -0700)]
AI 147162: Emphasize in the javadoc that the "pkg" parameters to
InstrumentationTestCase and its descendants should be the
package manager package name (not the java package name, and
not the test package) of the package holding the Activity
under test.
Added similar notations to the ApiDemos call sites.
JAVADOC ONLY - should be safe change for cupcake sdk.
BUG=
1783981
Automated import of CL 147162
Raphael Moll [Mon, 20 Apr 2009 23:16:34 +0000 (16:16 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Mon, 20 Apr 2009 23:15:15 +0000 (16:15 -0700)]
AI 147027: am: CL 147025 ADT #
1795718: disable --mode in "android create project".
The alias build rules do not work and the flag wasn't even used
by ProjectCreator anyway. Will reintroduce later.
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147027
Raphael Moll [Mon, 20 Apr 2009 23:13:19 +0000 (16:13 -0700)]
AI 147025: ADT #
1795718: disable --mode in "android create project".
The alias build rules do not work and the flag wasn't even used
by ProjectCreator anyway. Will reintroduce later.
BUG=
1795718
Automated import of CL 147025
Raphael Moll [Mon, 20 Apr 2009 22:43:27 +0000 (15:43 -0700)]
Merge branch 'readonly-p4-donut' into donut
Raphael Moll [Mon, 20 Apr 2009 22:41:59 +0000 (15:41 -0700)]
AI 147013: am: CL 147012 A readme describing the usage and limitations of MkStubs.
Original author: raphael
Merged from: //branches/cupcake/...
Automated import of CL 147013
Raphael Moll [Mon, 20 Apr 2009 22:40:40 +0000 (15:40 -0700)]
AI 147012: A readme describing the usage and limitations of MkStubs.
BUG=
1778786
Automated import of CL 147012
Xavier Ducrohet [Mon, 20 Apr 2009 21:12:39 +0000 (14:12 -0700)]
Merge branch 'readonly-p4-donut' into donut
Xavier Ducrohet [Mon, 20 Apr 2009 21:11:22 +0000 (14:11 -0700)]
AI 146983: am: CL 146980 Fix the display of the target hash string when displaying unresolved target errors.
Original author: xav
Merged from: //branches/cupcake/...
Automated import of CL 146983
Xavier Ducrohet [Mon, 20 Apr 2009 21:09:05 +0000 (14:09 -0700)]
AI 146980: Fix the display of the target hash string when displaying unresolved target errors.
BUG=
1800971
Automated import of CL 146980
Raphael Moll [Mon, 20 Apr 2009 20:24:11 +0000 (13:24 -0700)]
Merge branch 'readonly-p4-donut' into donut