OSDN Git Service
Magnus Hagander [Thu, 3 May 2007 14:04:03 +0000 (14:04 +0000)]
Release builds generate different strangely formatted export names
for local symbols, that shouldn't be exported. This patch excludes them,
cutting down about 10,000 exported symbols and decreasing the binary size
by 20%.
Tom Lane [Wed, 2 May 2007 23:34:48 +0000 (23:34 +0000)]
Dept. of second thoughts: add comments cautioning against using
ReadOrZeroBuffer to fetch pages from beyond physical EOF. This would
usually work, but would cause problems for md.c if writes occurred
beyond a segment boundary when the previous segment file hadn't been
fully extended.
Tom Lane [Wed, 2 May 2007 23:18:03 +0000 (23:18 +0000)]
During WAL recovery, when reading a page that we intend to overwrite completely
from the WAL data, don't bother to physically read it; just have bufmgr.c
return a zeroed-out buffer instead. This speeds recovery significantly,
and also avoids unnecessary failures when a page-to-be-overwritten has corrupt
page headers on disk. This replaces a former kluge that accomplished the
latter by pretending zero_damaged_pages was always ON during WAL recovery;
which was OK when the kluge was put in, but is unsafe when restoring a WAL
log that was written with full_page_writes off.
Heikki Linnakangas
Tom Lane [Wed, 2 May 2007 21:08:46 +0000 (21:08 +0000)]
Fix things so that when CREATE INDEX CONCURRENTLY sets pg_index.indisvalid
true at the very end of its processing, the update is broadcast via a
shared-cache-inval message for the index; without this, existing backends that
already have relcache entries for the index might never see it become valid.
Also, force a relcache inval on the index's parent table at the same time,
so that any cached plans for that table are re-planned; this ensures that
the newly valid index will be used if appropriate. Aside from making
C.I.C. behave more reasonably, this is necessary infrastructure for some
aspects of the HOT patch. Pavan Deolasee, with a little further stuff from
me.
Alvaro Herrera [Wed, 2 May 2007 18:27:57 +0000 (18:27 +0000)]
Use the new TimestampDifferenceExceeds API instead of timestamp_cmp_internal
and TimestampDifference, to make coding clearer. I think this should also fix
the failure to start workers in platforms with low resolution timers, as
reported by Itagaki Takahiro.
Alvaro Herrera [Wed, 2 May 2007 15:47:14 +0000 (15:47 +0000)]
Fix failure to check for INVALID worker entry in the new autovacuum code, which
could happen when a worker took to long to start and was thus "aborted" by the
launcher. Noticed by lionfish buildfarm member.
Tom Lane [Wed, 2 May 2007 15:32:42 +0000 (15:32 +0000)]
Fix oversight in PG_RE_THROW processing: it's entirely possible that there
isn't any place to throw the error to. If so, we should treat the error
as FATAL, just as we would have if it'd been thrown outside the PG_TRY
block to begin with.
Although this is clearly a *potential* source of bugs, it is not clear
at the moment whether it is an *actual* source of bugs; there may not
presently be any PG_TRY blocks in code that can be reached with no outer
longjmp catcher. So for the moment I'm going to be conservative and not
back-patch this. The change breaks ABI for users of PG_RE_THROW and hence
might create compatibility problems for loadable modules, so we should not
put it into released branches without proof that it's needed.
Magnus Hagander [Tue, 1 May 2007 20:11:14 +0000 (20:11 +0000)]
Add wrapper script around install.pl that calls buildenv.bat before doing
the install.
Dave Page
Tom Lane [Tue, 1 May 2007 18:53:52 +0000 (18:53 +0000)]
Fix a thinko in my patch of a couple months ago for bug #3116: it did the
wrong thing when inlining polymorphic SQL functions, because it was using the
function's declared return type where it should have used the actual result
type of the current call. In 8.1 and 8.2 this causes obvious failures even if
you don't have assertions turned on; in 8.0 and 7.4 it would only be a problem
if the inlined expression were used as an input to a function that did
run-time type determination on its inputs. Add a regression test, since this
is evidently an under-tested area.
Tom Lane [Mon, 30 Apr 2007 21:01:53 +0000 (21:01 +0000)]
Change the timestamps recorded in transaction commit/abort xlog records
from time_t to TimestampTz representation. This provides full gettimeofday()
resolution of the timestamps, which might be useful when attempting to
do point-in-time recovery --- previously it was not possible to specify
the stop point with sub-second resolution. But mostly this is to get
rid of TimestampTz-to-time_t conversion overhead during commit. Per my
proposal of a day or two back.
Tom Lane [Mon, 30 Apr 2007 16:37:08 +0000 (16:37 +0000)]
Fix oversight in my patch of yesterday: forgot to ensure that stats would
still be forced out at backend exit.
Tom Lane [Mon, 30 Apr 2007 03:23:49 +0000 (03:23 +0000)]
Implement rate-limiting logic on how often backends will attempt to send
messages to the stats collector. This avoids the problem that enabling
stats_row_level for autovacuum has a significant overhead for short
read-only transactions, as noted by Arjen van der Meijden. We can avoid
an extra gettimeofday call by piggybacking on the one done for WAL-logging
xact commit or abort (although that doesn't help read-only transactions,
since they don't WAL-log anything).
In my proposal for this, I noted that we could change the WAL log entries
for commit/abort to record full TimestampTz precision, instead of only
time_t as at present. That's not done in this patch, but will be committed
separately.
Tom Lane [Mon, 30 Apr 2007 00:16:43 +0000 (00:16 +0000)]
Marginal performance hack: use a dedicated routine instead of copyObject
to copy nodes that are known to be Vars during plan reference adjustment.
Saves useless memzero operation as well as the big switch in copyObject.
Tom Lane [Mon, 30 Apr 2007 00:14:54 +0000 (00:14 +0000)]
Marginal performance hack: avoid unnecessary work in expression_tree_mutator.
We can just palloc, instead of using makeNode, when we are going to
overwrite the whole node anyway in the FLATCOPY macro. Also, use
FLATCOPY instead of copyObject for common node types Var and Const.
Tom Lane [Mon, 30 Apr 2007 00:12:08 +0000 (00:12 +0000)]
Marginal performance hack: remove the loop that used to be needed to
look through a freelist for a chunk of adequate size. For a long time
now, all elements of a given freelist have been exactly the same
allocated size, so we don't need a loop. Since the loop never iterated
more than once, you'd think this wouldn't matter much, but it makes a
noticeable savings in a simple test --- perhaps because the compiler
isn't optimizing on a mistaken assumption that the loop would repeat.
AllocSetAlloc is called often enough that saving even a couple of
instructions is worthwhile.
Bruce Momjian [Sun, 29 Apr 2007 07:17:12 +0000 (07:17 +0000)]
Update to 8.4:
< * Make standard_conforming_strings the default in 8.3?
> * Make standard_conforming_strings the default in 8.4?
Bruce Momjian [Sun, 29 Apr 2007 06:48:11 +0000 (06:48 +0000)]
Pl/pgsql MOVE done:
< o Add support for MOVE and SCROLL cursors
<
< PL/pgSQL cursors should support the same syntax as
< backend cursors.
<
> o -Add support for MOVE cursors
> o Add support for SCROLL cursors
Neil Conway [Sun, 29 Apr 2007 01:21:09 +0000 (01:21 +0000)]
Support for MOVE in PL/PgSQL. Initial patch from Magnus, some improvements
by Pavel Stehule, and reviewed by Neil Conway.
Neil Conway [Sat, 28 Apr 2007 23:54:59 +0000 (23:54 +0000)]
Add support for IN as alternative to FROM in PL/PgSQL's FETCH statement,
for consistency with the backend's FETCH command. Patch from Pavel
Stehule, reviewed by Neil Conway.
Tom Lane [Fri, 27 Apr 2007 22:05:49 +0000 (22:05 +0000)]
Modify processing of DECLARE CURSOR and EXPLAIN so that they can resolve the
types of unspecified parameters when submitted via extended query protocol.
This worked in 8.2 but I had broken it during plancache changes. DECLARE
CURSOR is now treated almost exactly like a plain SELECT through parse
analysis, rewrite, and planning; only just before sending to the executor
do we divert it away to ProcessUtility. This requires a special-case check
in a number of places, but practically all of them were already special-casing
SELECT INTO, so it's not too ugly. (Maybe it would be a good idea to merge
the two by treating IntoClause as a form of utility statement? Not going to
worry about that now, though.) That approach doesn't work for EXPLAIN,
however, so for that I punted and used a klugy solution of running parse
analysis an extra time if under extended query protocol.
Neil Conway [Fri, 27 Apr 2007 20:08:43 +0000 (20:08 +0000)]
Remove no-longer-true statement from the docs. Since the default config
now enables row-level stats, the out of the box stats volume is no
longer particularly low.
Magnus Hagander [Fri, 27 Apr 2007 16:45:54 +0000 (16:45 +0000)]
Properly set MODULE_PATHNAME based on module name instead of incorrectly based
on directory name. Fixes the generation of .sql files in contrib/spi.
Per complaint from Dave Page.
Michael Meskes [Fri, 27 Apr 2007 07:55:14 +0000 (07:55 +0000)]
Removed non-existant function from extern.h
Michael Meskes [Fri, 27 Apr 2007 06:56:11 +0000 (06:56 +0000)]
Inlined two functions to get rid of va_list problems on some archs.
Tom Lane [Thu, 26 Apr 2007 23:24:46 +0000 (23:24 +0000)]
Fix dynahash.c to suppress hash bucket splits while a hash_seq_search() scan
is in progress on the same hashtable. This seems the least invasive way to
fix the recently-recognized problem that a split could cause the scan to
visit entries twice or (with much lower probability) miss them entirely.
The only field-reported problem caused by this is the "failed to re-find
shared lock object" PANIC in COMMIT PREPARED reported by Michel Dorochevsky,
which was caused by multiply visited entries. However, it seems certain
that mdsync() is vulnerable to missing required fsync's due to missed
entries, and I am fearful that RelationCacheInitializePhase2() might be at
risk as well. Because of that and the generalized hazard presented by this
bug, back-patch all the supported branches.
Along the way, fix pg_prepared_statement() and pg_cursor() to not assume
that the hashtables they are examining will stay static between calls.
This is risky regardless of the newly noted dynahash problem, because
hash_seq_search() has never promised to cope with deletion of table entries
other than the just-returned one. There may be no bug here because the only
supported way to call these functions is via ExecMakeTableFunctionResult()
which will cycle them to completion before doing anything very interesting,
but it seems best to get rid of the assumption. This affects 8.2 and HEAD
only, since those functions weren't there earlier.
Neil Conway [Thu, 26 Apr 2007 22:25:56 +0000 (22:25 +0000)]
Another tweak for tab completion of CREATE TEMP. Instead of only
completing CREATE { TEMP | TEMPORARY } TABLE, we should also suggest
VIEW and SEQUENCE. Per Greg Sabino Mullane.
Neil Conway [Thu, 26 Apr 2007 22:10:54 +0000 (22:10 +0000)]
Consistency tweaks for a table in the SGML docs: we don't terminate
table entries describing functions with periods.
Neil Conway [Thu, 26 Apr 2007 18:10:28 +0000 (18:10 +0000)]
Minor enhancement to psql tab completion. If we see "CREATE TEMPORARY",
we can complete "TABLE". The previous coding only looked for "CREATE TEMP".
Note that I didn't add TEMPORARY to the list of suggested completions
after we've seen "CREATE", since TEMP is equivalent and more concise. But
if the user has already manually typed TEMPORARY, we may as well
complete TABLE for them.
Neil Conway [Thu, 26 Apr 2007 18:00:24 +0000 (18:00 +0000)]
Minor tweak for DISCARD ref page.
Neil Conway [Thu, 26 Apr 2007 16:13:15 +0000 (16:13 +0000)]
Rename the newly-added commands for discarding session state.
RESET SESSION, RESET PLANS, and RESET TEMP are now DISCARD ALL,
DISCARD PLANS, and DISCARD TEMP, respectively. This is to avoid
confusion with the pre-existing RESET variants: the DISCARD
commands are not actually similar to RESET. Patch from Marko
Kreen, with some minor editorialization.
Magnus Hagander [Thu, 26 Apr 2007 14:09:12 +0000 (14:09 +0000)]
libpgtypes is a client lib, should not link with backend.
Magnus Hagander [Thu, 26 Apr 2007 10:36:47 +0000 (10:36 +0000)]
Generate "fake configure output" for pg_config, so that external builds
like Slony can figure out which options were enabled in the build.
Neil Conway [Wed, 25 Apr 2007 19:48:27 +0000 (19:48 +0000)]
Minor consistency tweak for SGML docs.
Magnus Hagander [Wed, 25 Apr 2007 19:00:05 +0000 (19:00 +0000)]
Install libpgport.lib as needed by some client programs.
Dave Page
Magnus Hagander [Wed, 25 Apr 2007 18:58:33 +0000 (18:58 +0000)]
Install headers in the same directory structure as Mingw.
Dave Page
Bruce Momjian [Wed, 25 Apr 2007 13:01:41 +0000 (13:01 +0000)]
Remove tabs from installation.sgml.
Bruce Momjian [Wed, 25 Apr 2007 01:31:01 +0000 (01:31 +0000)]
Update Japanese FAQs.
Jun Kuwamura
Bruce Momjian [Tue, 24 Apr 2007 21:29:42 +0000 (21:29 +0000)]
Fix typo.
Bruce Momjian [Tue, 24 Apr 2007 21:28:54 +0000 (21:28 +0000)]
Update FAQ item:
<H3 id="item3.6">3.6) What is the upgrade process for
PostgreSQL?</H3>
to reference both versioning and specific upgrade instructions.
Magnus Hagander [Tue, 24 Apr 2007 12:25:18 +0000 (12:25 +0000)]
Set maximum semaphore count to 32767 instead of 1. Fixes
errorcode 298 when unlocking a semaphore more than once.
Per report from Marcin Waldowski.
Magnus Hagander [Mon, 23 Apr 2007 17:18:58 +0000 (17:18 +0000)]
Don't try to install uuid-ossp since we don't build it.
Per buildfarm member mastodon.
Neil Conway [Mon, 23 Apr 2007 16:52:53 +0000 (16:52 +0000)]
Fix newly-introduced documentation typo.
Peter Eisentraut [Sun, 22 Apr 2007 21:16:18 +0000 (21:16 +0000)]
Make some functions immutable.
thanks Marko Kreen
Peter Eisentraut [Sun, 22 Apr 2007 21:12:25 +0000 (21:12 +0000)]
Fix typo
Bruce Momjian [Sun, 22 Apr 2007 13:28:43 +0000 (13:28 +0000)]
Done:
> o -Allow commenting of variables in postgresql.conf to restore them
Tom Lane [Sun, 22 Apr 2007 03:52:40 +0000 (03:52 +0000)]
Remove some of the most blatant brain-fade in the recent guc patch
(it's so nice to have a buildfarm member that actively rejects naked
uses of strcasecmp). This coding is still pretty awful, though, since
it's going to be O(N^2) in the number of guc variables. May I direct
your attention to bsearch?
Tom Lane [Sat, 21 Apr 2007 21:01:45 +0000 (21:01 +0000)]
Some further performance tweaks for planning large inheritance trees that
are mostly excluded by constraints: do the CE test a bit earlier to save
some adjust_appendrel_attrs() work on excluded children, and arrange to
use array indexing rather than rt_fetch() to fetch RTEs in the main body
of the planner. The latter is something I'd wanted to do for awhile anyway,
but seeing list_nth_cell() as 35% of the runtime gets one's attention.
Magnus Hagander [Sat, 21 Apr 2007 20:58:05 +0000 (20:58 +0000)]
Fix build for directories with spaces in them by quoting properly.
Joachim Wieland
Peter Eisentraut [Sat, 21 Apr 2007 20:02:41 +0000 (20:02 +0000)]
Make configuration parameters fall back to their default values when they
are removed from the configuration file.
Joachim Wieland
Magnus Hagander [Sat, 21 Apr 2007 19:04:51 +0000 (19:04 +0000)]
Don't try to build uuid-ossp on msvc.
Peter Eisentraut [Sat, 21 Apr 2007 18:26:44 +0000 (18:26 +0000)]
Fix alignment of help output.
Peter Eisentraut [Sat, 21 Apr 2007 17:26:18 +0000 (17:26 +0000)]
Contrib module uuid-ossp for generating UUID values using the OSSP UUID
library. New configure option --with-ossp-uuid to activate.
Andrew Dunstan [Sat, 21 Apr 2007 15:30:28 +0000 (15:30 +0000)]
Document new -with-libxslt build option.
Tom Lane [Sat, 21 Apr 2007 06:18:52 +0000 (06:18 +0000)]
Avoid useless work during set_plain_rel_pathlist() when the relation
will be excluded by constraint exclusion anyway. Greg Stark
Tom Lane [Sat, 21 Apr 2007 05:56:41 +0000 (05:56 +0000)]
Tweak make_inh_translation_lists() to check the common case wherein parent and
child attnums are the same, before it grovels through each and every child
column looking for a name match. Saves some time in large inheritance trees,
per example from Greg.
Tom Lane [Sat, 21 Apr 2007 04:49:20 +0000 (04:49 +0000)]
Improve the way in which CatalogCacheComputeHashValue combines multiple key
values: don't throw away perfectly good hash bits, and increase the shift
distances so as to provide more separation in the common case where some of
the key values are small integers (and so their hashes are too, because
hashfunc.c doesn't try all that hard). This reduces the runtime of
SearchCatCache by a factor of 4 in an example provided by Greg Stark,
in which the planner spends a whole lot of time searching the two-key
STATRELATT cache. It seems unlikely to hurt in other cases, but maybe
we could do even better?
Tom Lane [Sat, 21 Apr 2007 04:10:53 +0000 (04:10 +0000)]
Adjust pgstat_initstats() to avoid repeated searches of the TabStat arrays
when a relation is opened multiple times in the same transaction. This is
particularly useful for system catalogs, which we may heap_open or index_open
many times in a transaction, and it doesn't really cost anything extra even
if the rel is touched but once. Motivated by study of an example from Greg
Stark, in which pgstat_initstats() accounted for an unreasonably large
fraction of the runtime.
Tom Lane [Sat, 21 Apr 2007 02:41:13 +0000 (02:41 +0000)]
Tweak set_rel_width() to avoid redundant executions of getrelid().
In very large queries this accounts for a noticeable fraction of
planning time. Per an example from Greg Stark.
Peter Eisentraut [Fri, 20 Apr 2007 21:51:46 +0000 (21:51 +0000)]
Documentation for UUID type
Bruce Momjian [Fri, 20 Apr 2007 20:15:52 +0000 (20:15 +0000)]
Add comment on why deadlock detection error messages only prints numbers.
Bruce Momjian [Fri, 20 Apr 2007 19:40:53 +0000 (19:40 +0000)]
Add script major_release_split to simplify creating release notes for
multiple releases.
Bruce Momjian [Fri, 20 Apr 2007 15:47:08 +0000 (15:47 +0000)]
Add mention of checking <link> behavior of HISTORY.html to release
checklist.
Bruce Momjian [Fri, 20 Apr 2007 13:48:21 +0000 (13:48 +0000)]
Remove duplicate text, per Magnus.
Tom Lane [Fri, 20 Apr 2007 03:27:23 +0000 (03:27 +0000)]
Fix markup.
Security: CVE-2007-2138
Tom Lane [Fri, 20 Apr 2007 02:37:38 +0000 (02:37 +0000)]
Support explicit placement of the temporary-table schema within search_path.
This is needed to allow a security-definer function to set a truly secure
value of search_path. Without it, a malicious user can use temporary objects
to execute code with the privileges of the security-definer function. Even
pushing the temp schema to the back of the search path is not quite good
enough, because a function or operator at the back of the path might still
capture control from one nearer the front due to having a more exact datatype
match. Hence, disable searching the temp schema altogether for functions and
operators.
Security: CVE-2007-2138
Tom Lane [Thu, 19 Apr 2007 22:44:32 +0000 (22:44 +0000)]
Sync timezone data with 2007e zic release.
Tom Lane [Thu, 19 Apr 2007 20:24:04 +0000 (20:24 +0000)]
Repair PANIC condition in hash indexes when a previous index extension attempt
failed (due to lock conflicts or out-of-space). We might have already
extended the index's filesystem EOF before failing, causing the EOF to be
beyond what the metapage says is the last used page. Hence the invariant
maintained by the code needs to be "EOF is at or beyond last used page",
not "EOF is exactly the last used page". Problem was created by my patch
of 2006-11-19 that attempted to repair bug #2737. Since that was
back-patched to 7.4, this needs to be as well. Per report and test case
from Vlastimil Krejcir.
Tom Lane [Thu, 19 Apr 2007 16:33:24 +0000 (16:33 +0000)]
Fix plpgsql to avoid reference to already-freed memory when returning a
pass-by-reference data type and the RETURN statement is within an EXCEPTION
block. Bug introduced by my fix of 2007-01-28 to use per-subtransaction
ExprContexts/EStates; since that wasn't back-patched into older branches,
only 8.2 and HEAD are affected. Per report from Gary Winslow.
Alvaro Herrera [Thu, 19 Apr 2007 16:26:44 +0000 (16:26 +0000)]
Silence compiler warnings, per Bruce.
Bruce Momjian [Thu, 19 Apr 2007 13:02:49 +0000 (13:02 +0000)]
Release wording updates for releases 8.2.4, 8.1.9, 8.0.13, 7.4.17, 7.3.19.
Bruce Momjian [Thu, 19 Apr 2007 03:05:10 +0000 (03:05 +0000)]
Update FAQ for 8.2.4.
Bruce Momjian [Thu, 19 Apr 2007 02:47:36 +0000 (02:47 +0000)]
Release note updates for 8.2.4, 8.1.9, 8.0.13, 7.4.17, 7.3.19.
Bruce Momjian [Wed, 18 Apr 2007 20:44:53 +0000 (20:44 +0000)]
Remove tabs from SGML source files.
Alvaro Herrera [Wed, 18 Apr 2007 16:44:18 +0000 (16:44 +0000)]
Enable configurable log of autovacuum actions. Initial patch from Simon
Riggs, additional code and docs by me. Per discussion.
Magnus Hagander [Wed, 18 Apr 2007 13:50:09 +0000 (13:50 +0000)]
Enable building of 64-bit libpq using visual studio 8 and the
win32.mak file.
Enable building with kerberos support using the win32.mak file.
Hiroshi Saito + me
Bruce Momjian [Wed, 18 Apr 2007 13:31:17 +0000 (13:31 +0000)]
Item not done, per Pavel:
< o -Add MOVE
< o -Add support for SCROLL cursors
> o Add support for MOVE and SCROLL cursors
Magnus Hagander [Wed, 18 Apr 2007 10:14:06 +0000 (10:14 +0000)]
Change default build to release, to be consistent with unix build.
Make it possible to set the default from builenv.bat.
Per request from Dave Page
Magnus Hagander [Wed, 18 Apr 2007 08:32:40 +0000 (08:32 +0000)]
Silence mingw compiler warning
Bruce Momjian [Wed, 18 Apr 2007 02:28:22 +0000 (02:28 +0000)]
Update docs/error message for CSV quote/escape --- must be ASCII.
Backpatch doc change to 8.2.X.
Bruce Momjian [Wed, 18 Apr 2007 00:38:57 +0000 (00:38 +0000)]
Update error message for COPY with a multi-byte delimiter.
Bruce Momjian [Wed, 18 Apr 2007 00:17:56 +0000 (00:17 +0000)]
Document that the COPY delimiter must be an ASCII byte, rather than a
multi-byte value. It can also be a single-byte encoded character if
the client and server versions match.
Backpatch to 8.2.X.
Bruce Momjian [Tue, 17 Apr 2007 23:54:32 +0000 (23:54 +0000)]
Update TODO for plpgsql cursors:
< o -Add support for WITH HOLD and SCROLL cursors
> o -Add support for SCROLL cursors
> o Add support for WITH HOLD cursors
Tom Lane [Tue, 17 Apr 2007 21:29:31 +0000 (21:29 +0000)]
Fix condition for whether end_heap_rewrite must fsync, per Heikki.
Bruce Momjian [Tue, 17 Apr 2007 21:22:51 +0000 (21:22 +0000)]
Also done for PL/pgSQL:
< o Add support for WITH HOLD and SCROLL cursors
> o -Add support for WITH HOLD and SCROLL cursors
Bruce Momjian [Tue, 17 Apr 2007 21:22:13 +0000 (21:22 +0000)]
Done:
< o Add MOVE
> o -Add MOVE
Bruce Momjian [Tue, 17 Apr 2007 20:50:34 +0000 (20:50 +0000)]
Add warning about TODO item:
< Currently all schemas are owned by the super-user because they are
< copied from the template1 database.
> Currently all schemas are owned by the super-user because they are copied
> from the template1 database. However, since all objects are inherited
> from the template database, it is not clear that setting schemas to the db
> owner is correct.
Tom Lane [Tue, 17 Apr 2007 20:49:39 +0000 (20:49 +0000)]
Don't assume rd_smgr stays open across all of a rewriteheap operation;
doing so can result in crash if an sinval reset occurs meanwhile.
I believe this explains intermittent buildfarm failures in cluster test.
Bruce Momjian [Tue, 17 Apr 2007 20:47:55 +0000 (20:47 +0000)]
Not easy, per Alvaro:
< * %Set proper permissions on non-system schemas during db creation
> * Set proper permissions on non-system schemas during db creation
Tom Lane [Tue, 17 Apr 2007 20:03:03 +0000 (20:03 +0000)]
Rewrite choose_bitmap_and() to make it more robust in the presence of
competing alternatives for indexes to use in a bitmap scan. The former
coding took estimated selectivity as an overriding factor, causing it to
sometimes choose indexes that were much slower to scan than ones with a
slightly worse selectivity. It was also too narrow-minded about which
combinations of indexes to consider ANDing. The rewrite makes it pay more
attention to index scan cost than selectivity; this seems sane since it's
impossible to have very bad selectivity with low cost, whereas the reverse
isn't true. Also, we now consider each index alone, as well as adding
each index to an AND-group led by each prior index, for a total of about
O(N^2) rather than O(N) combinations considered. This makes the results
much less dependent on the exact order in which the indexes are
considered. It's still a lot cheaper than an O(2^N) exhaustive search.
A prefilter step eliminates all but the cheapest of those indexes using
the same set of WHERE conditions, to keep the effective value of N down in
scenarios where the DBA has created lots of partially-redundant indexes.
Tom Lane [Tue, 17 Apr 2007 17:30:35 +0000 (17:30 +0000)]
Fix erroneous column counts in some documentation tables. Brian Gough
Tom Lane [Tue, 17 Apr 2007 01:06:28 +0000 (01:06 +0000)]
And remove 'em again ...
Tom Lane [Tue, 17 Apr 2007 01:05:10 +0000 (01:05 +0000)]
Temporarily re-add derived files, in hopes of straightening out their CVS status.
Magnus Hagander [Mon, 16 Apr 2007 20:15:38 +0000 (20:15 +0000)]
Don't write timing output in quiet mode.
Merlin Moncure
Tom Lane [Mon, 16 Apr 2007 18:50:49 +0000 (18:50 +0000)]
Tweak clean_encoding_name() API to avoid need to cast away const.
Kris Jurka
Tom Lane [Mon, 16 Apr 2007 18:42:10 +0000 (18:42 +0000)]
Fix pg_dump to not crash if -t or a similar switch is used to select a serial
sequence for dumping without also selecting its owning table. Make it not try
to emit ALTER SEQUENCE OWNED BY in this situation.
Per report from Michael Nolan.
Magnus Hagander [Mon, 16 Apr 2007 18:39:19 +0000 (18:39 +0000)]
Enable IPV6 for all MSVC builds, including the VC6 libpq-only build.
Per request from Hiroshi Saito.
Alvaro Herrera [Mon, 16 Apr 2007 18:30:04 +0000 (18:30 +0000)]
Add a multi-worker capability to autovacuum. This allows multiple worker
processes to be running simultaneously. Also, now autovacuum processes do not
count towards the max_connections limit; they are counted separately from
regular processes, and are limited by the new GUC variable
autovacuum_max_workers.
The launcher now has intelligence to launch workers on each database every
autovacuum_naptime seconds, limited only on the max amount of worker slots
available.
Also, the global worker I/O utilization is limited by the vacuum cost-based
delay feature. Workers are "balanced" so that the total I/O consumption does
not exceed the established limit. This part of the patch was contributed by
ITAGAKI Takahiro.
Per discussion.
Tom Lane [Mon, 16 Apr 2007 18:21:07 +0000 (18:21 +0000)]
Make plancache store cursor options so it can pass them to planner during
a replan. I had originally thought this was not necessary, but the new
SPI facilities create a path whereby queries planned with non-default
options can get into the cache, so it is necessary.
Tom Lane [Mon, 16 Apr 2007 17:21:24 +0000 (17:21 +0000)]
Support scrollable cursors (ie, 'direction' clause in FETCH) in plpgsql.
Pavel Stehule, reworked a bit by Tom.
Tom Lane [Mon, 16 Apr 2007 01:14:58 +0000 (01:14 +0000)]
Expose more cursor-related functionality in SPI: specifically, allow
access to the planner's cursor-related planning options, and provide new
FETCH/MOVE routines that allow access to the full power of those commands.
Small refactoring of planner(), pg_plan_query(), and pg_plan_queries()
APIs to make it convenient to pass the planning options down from SPI.
This is the core-code portion of Pavel Stehule's patch for scrollable
cursor support in plpgsql; I'll review and apply the plpgsql changes
separately.