OSDN Git Service
Tom Lane [Fri, 18 Apr 2008 20:51:17 +0000 (20:51 +0000)]
Fix typo.
Alvaro Herrera [Fri, 18 Apr 2008 18:43:09 +0000 (18:43 +0000)]
Modify the float4 datatype to be pass-by-val. Along the way, remove the last
uses of the long-deprecated float32 in contrib/seg; the definitions themselves
are still there, but no longer used. fmgr/README updated to match.
I added a CREATE FUNCTION to account for existing seg_center() code in seg.c
too, and some tests for it and the neighbor functions. At the same time,
remove checks for NULL which are not needed (because the functions are declared
STRICT).
I had to do some adjustments to contrib's btree_gist too. The choices for
representation there are not ideal for changing the underlying types :-(
Original patch by Zoltan Boszormenyi, with some adjustments by me.
Tom Lane [Fri, 18 Apr 2008 17:05:45 +0000 (17:05 +0000)]
Fix rmtree() so that it keeps going after failure to remove any individual
file; the idea is that we should clean up as much as we can, even if there's
some problem removing one file. Make the error messages a bit less misleading,
too. In passing, const-ify function arguments.
Heikki Linnakangas [Fri, 18 Apr 2008 06:48:38 +0000 (06:48 +0000)]
Fix two race conditions between the pending unlink mechanism that was put in
place to prevent reusing relation OIDs before next checkpoint, and DROP
DATABASE. First, if a database was dropped, bgwriter would still try to unlink
the files that the rmtree() call by the DROP DATABASE command has already
deleted, or is just about to delete. Second, if a database is dropped, and
another database is created with the same OID, bgwriter would in the worst
case delete a relation in the new database that happened to get the same OID
as a dropped relation in the old database.
To fix these race conditions:
- make rmtree() ignore ENOENT errors. This fixes the 1st race condition.
- make ForgetDatabaseFsyncRequests forget unlink requests as well.
- force checkpoint on in dropdb on all platforms
Since ForgetDatabaseFsyncRequests() is asynchronous, the 2nd change isn't
enough on its own to fix the problem of dropping and creating a database with
same OID, but forcing a checkpoint on DROP DATABASE makes it sufficient.
Per Tom Lane's bug report and proposal. Backpatch to 8.3.
Tom Lane [Fri, 18 Apr 2008 01:42:17 +0000 (01:42 +0000)]
Cause EXPLAIN's VERBOSE option to print the target list (output column list)
of each plan node, instead of its former behavior of dumping the internal
representation of the plan tree. The latter display is still available for
those who really want it (see debug_print_plan), but uses for it are certainly
few and and far between. Per discussion.
This patch also removes the explain_pretty_print GUC, which is obsoleted
by the change.
Alvaro Herrera [Thu, 17 Apr 2008 21:37:28 +0000 (21:37 +0000)]
Clean up a few places where Datums were being treated as pointers (and vice
versa) without going through DatumGetPointer.
Gavin Sherry, with Feng Tian.
Tom Lane [Thu, 17 Apr 2008 21:22:14 +0000 (21:22 +0000)]
Fix a couple of oversights associated with the "physical tlist" optimization:
we had several code paths where a physical tlist could be used for the input
to a Sort node, which is a dumb idea because any unneeded table columns will
increase the volume of data the sort has to push around.
(Unfortunately the easy-looking fix of calling disuse_physical_tlist during
make_sort_xxx doesn't work because in most cases we're already committed to
the current input tlist --- it's been marked with sort column numbers, or
we've built grouping column numbers using it, etc. The tlist has to be
selected properly at the calling level before we start constructing sort-col
information. This is easy enough to do, we were just failing to take the
point into consideration.)
Back-patch to 8.3. I believe the problem probably exists clear back to 7.4
when the physical tlist optimization was added, but I'm afraid to back-patch
further than 8.3 without a great deal more study than I want to put into it.
The code in this area has drifted a lot over time. The real-world importance
of these code paths is uncertain anyway --- I think in many cases we'd
probably prefer hash-based methods.
Bruce Momjian [Thu, 17 Apr 2008 20:57:07 +0000 (20:57 +0000)]
TODO Done:
> * -Allow administrators to safely terminate individual sessions
Bruce Momjian [Thu, 17 Apr 2008 20:56:41 +0000 (20:56 +0000)]
Re-enable pg_terminate_backend() using SIGTERM. SIGTERM testing still
needed.
Tom Lane [Thu, 17 Apr 2008 18:30:18 +0000 (18:30 +0000)]
Add some code to EXPLAIN to show the targetlist (ie, output columns)
of each plan node. For the moment this is debug support only and is
not enabled unless EXPLAIN_PRINT_TLISTS is defined at build time.
Later I'll see about the idea of letting EXPLAIN VERBOSE do it.
Tom Lane [Wed, 16 Apr 2008 23:59:40 +0000 (23:59 +0000)]
Repair two places where SIGTERM exit could leave shared memory state
corrupted. (Neither is very important if SIGTERM is used to shut down the
whole database cluster together, but there's a problem if someone tries to
SIGTERM individual backends.) To do this, introduce new infrastructure
macros PG_ENSURE_ERROR_CLEANUP/PG_END_ENSURE_ERROR_CLEANUP that take care
of transiently pushing an on_shmem_exit cleanup hook. Also use this method
for createdb cleanup --- that wasn't a shared-memory-corruption problem,
but SIGTERM abort of createdb could leave orphaned files lying around.
Backpatch as far as 8.2. The shmem corruption cases don't exist in 8.1,
and the createdb usage doesn't seem important enough to risk backpatching
further.
Andrew Dunstan [Wed, 16 Apr 2008 22:16:00 +0000 (22:16 +0000)]
Fix MinGW warnings re formats and unused variables. per ITAGAKI Takahiro
Bruce Momjian [Wed, 16 Apr 2008 21:03:08 +0000 (21:03 +0000)]
Ignore blank lines in typedef file.
Bruce Momjian [Wed, 16 Apr 2008 20:57:18 +0000 (20:57 +0000)]
Update most recent release to 8.3.1.
Tom Lane [Wed, 16 Apr 2008 18:23:04 +0000 (18:23 +0000)]
Fix LOAD_CRIT_INDEX() macro to take out AccessShareLock on the system index
it is trying to build a relcache entry for. This is an oversight in my 8.2
patch that tried to ensure we always took a lock on a relation before trying
to build its relcache entry. The implication is that if someone committed a
reindex of a critical system index at about the same time that some other
backend were starting up without a valid pg_internal.init file, the second one
might PANIC due to not seeing any valid version of the index's pg_class row.
Improbable case, but definitely not impossible.
Bruce Momjian [Wed, 16 Apr 2008 18:18:00 +0000 (18:18 +0000)]
Fix comment typo.
Bryce Nesbitt
Bruce Momjian [Wed, 16 Apr 2008 17:50:01 +0000 (17:50 +0000)]
Update TODO wording.
Bruce Momjian [Wed, 16 Apr 2008 17:25:56 +0000 (17:25 +0000)]
Add to TODO:
> * Implement the non-threaded Avahi service discovery protocol
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg00939.php
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00097.php
> http://archives.postgresql.org/pgsql-hackers/2008-03/msg01211.php
> http://archives.postgresql.org/pgsql-patches/2008-04/msg00001.php
Andrew Dunstan [Wed, 16 Apr 2008 14:19:56 +0000 (14:19 +0000)]
Avoid using unnecessary pgwin32_safestat in libpq.
Bruce Momjian [Tue, 15 Apr 2008 21:39:19 +0000 (21:39 +0000)]
Re-add terminate TODO item.
Bruce Momjian [Tue, 15 Apr 2008 20:28:47 +0000 (20:28 +0000)]
Revert addition of pg_terminate_backend() because of race conditions.
Andrew Dunstan [Tue, 15 Apr 2008 16:22:36 +0000 (16:22 +0000)]
Add multi-line flag to regex that needs it. Backpatch to 8.2. Fix from Andreas Zeugswetter
Bruce Momjian [Tue, 15 Apr 2008 15:08:59 +0000 (15:08 +0000)]
Add TODO item:
< * Allow NOTIFY in rules involving conditionals
>
> o Allow NOTIFY in rules involving conditionals
> o Improve LISTEN concurrency
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg01106.php
Bruce Momjian [Tue, 15 Apr 2008 15:07:09 +0000 (15:07 +0000)]
Move LISTEN/NOTIFY items to separate TODO section.
Bruce Momjian [Tue, 15 Apr 2008 14:24:32 +0000 (14:24 +0000)]
Add to TODO:
> * Allow XML to accept more liberal DOCTYPE specifications
>
> http://archives.postgresql.org/pgsql-general/2008-02/msg00347.php
Bruce Momjian [Tue, 15 Apr 2008 13:55:42 +0000 (13:55 +0000)]
Done:
> * -Allow administrators to safely terminate individual sessions either
Bruce Momjian [Tue, 15 Apr 2008 13:55:12 +0000 (13:55 +0000)]
Add pg_terminate_backend() to allow terminating only a single session.
Andrew Dunstan [Tue, 15 Apr 2008 12:16:51 +0000 (12:16 +0000)]
Make integer_datetimes the default for MSVC even if not mentioned in config.pl.
Tom Lane [Mon, 14 Apr 2008 17:05:34 +0000 (17:05 +0000)]
Push index operator lossiness determination down to GIST/GIN opclass
"consistent" functions, and remove pg_amop.opreqcheck, as per recent
discussion. The main immediate benefit of this is that we no longer need
8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery
searches on GIN indexes. In future it should be possible to optimize some
other queries better than is done now, by detecting at runtime whether the
index match is exact or not.
Tom Lane, after an idea of Heikki's, and with some help from Teodor.
Alvaro Herrera [Mon, 14 Apr 2008 15:04:20 +0000 (15:04 +0000)]
Fix indentation in new REFERENCED BY psql output, per Brendan Jurd.
Bruce Momjian [Mon, 14 Apr 2008 13:33:53 +0000 (13:33 +0000)]
Add URL for:
* Consider automatic caching of statements at various levels:
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg00823.php
Tom Lane [Sun, 13 Apr 2008 20:51:21 +0000 (20:51 +0000)]
Since createplan.c no longer cares whether index operators are lossy, it has
no particular need to do get_op_opfamily_properties() while building an
indexscan plan. Postpone that lookup until executor start. This simplifies
createplan.c a lot more than it complicates nodeIndexscan.c, and makes things
more uniform since we already had to do it that way for RowCompare
expressions. Should be a bit faster too, at least for plans that aren't
re-used many times, since we avoid palloc'ing and perhaps copying the
intermediate list data structure.
Tom Lane [Sun, 13 Apr 2008 19:18:14 +0000 (19:18 +0000)]
Phase 2 of project to make index operator lossiness be determined at runtime
instead of plan time. Extend the amgettuple API so that the index AM returns
a boolean indicating whether the indexquals need to be rechecked, and make
that rechecking happen in nodeIndexscan.c (currently the only place where
it's expected to be needed; other callers of index_getnext are just erroring
out for now). For the moment, GIN and GIST have stub logic that just always
sets the recheck flag to TRUE --- I'm hoping to get Teodor to handle pushing
that control down to the opclass consistent() functions. The planner no
longer pays any attention to amopreqcheck, and that catalog column will go
away in due course.
Tom Lane [Sun, 13 Apr 2008 03:49:22 +0000 (03:49 +0000)]
Turn the -i/--ignore-version options of pg_dump and pg_dumpall into no-ops:
the server version check is now always enforced. Relax the version check to
allow a server that is of pg_dump's own major version but a later minor
version; this is the only case that -i was at all safe to use in.
pg_restore already enforced only a very weak version check, so this is
really just a documentation change for it.
Per discussion.
Tom Lane [Sat, 12 Apr 2008 23:21:04 +0000 (23:21 +0000)]
Clean up a few places where Datums were being treated as pointers without
going through DatumGetPointer or some other "official" conversion macro.
Not actually a bug, since Datum the same size as pointer is the only
supported case at the moment, but good cleanup for the future.
Gavin Sherry
Tom Lane [Sat, 12 Apr 2008 23:14:21 +0000 (23:14 +0000)]
Create new routines systable_beginscan_ordered, systable_getnext_ordered,
systable_endscan_ordered that have API similar to systable_beginscan etc
(in particular, the passed-in scankeys have heap not index attnums),
but guarantee ordered output, unlike the existing functions. For the moment
these are just very thin wrappers around index_beginscan/index_getnext/etc.
Someday they might need to get smarter; but for now this is just a code
refactoring exercise to reduce the number of direct callers of index_getnext,
in preparation for changing that function's API.
In passing, remove index_getnext_indexitem, which has been dead code for
quite some time, and will have even less use than that in the presence
of run-time-lossy indexes.
Tom Lane [Fri, 11 Apr 2008 23:53:00 +0000 (23:53 +0000)]
A quick try at un-breaking the Cygwin build. Whether it needs the
pgwin32_safestat remains to be determined, but in any case the current
code is not tolerable.
Tom Lane [Fri, 11 Apr 2008 22:54:23 +0000 (22:54 +0000)]
Add some debug support code to try to catch future mistakes in the area of
input functions that include garbage bytes in their results. Provide a
compile-time option RANDOMIZE_ALLOCATED_MEMORY to make palloc fill returned
blocks with variable contents. This option also makes the parser perform
conversions of literal constants twice and compare the results, emitting a
WARNING if they don't match. (This is the code I used to catch the input
function bugs fixed in the previous commit.) For the moment, I've set it
to be activated automatically by --enable-cassert.
Tom Lane [Fri, 11 Apr 2008 22:52:05 +0000 (22:52 +0000)]
Fix several datatype input functions that were allowing unused bytes in their
results to contain uninitialized, unpredictable values. While this was okay
as far as the datatypes themselves were concerned, it's a problem for the
parser because occurrences of the "same" literal might not be recognized as
equal by datumIsEqual (and hence not by equal()). It seems sufficient to fix
this in the input functions since the only critical use of equal() is in the
parser's comparisons of ORDER BY and DISTINCT expressions.
Per a trouble report from Marc Cousin.
Patch all the way back. Interestingly, array_in did not have the bug before
8.2, which may explain why the issue went unnoticed for so long.
Bruce Momjian [Fri, 11 Apr 2008 19:50:40 +0000 (19:50 +0000)]
Update wording:
< * Allow functions to control the transaction state
> * Allow calling of a procedure outside a SELECT that can control the
> transaction state
Bruce Momjian [Fri, 11 Apr 2008 19:36:07 +0000 (19:36 +0000)]
Changed TODO wording:
< * Support procedures, which return no value
> * Allow functions to control the transaction state
Bruce Momjian [Fri, 11 Apr 2008 19:16:47 +0000 (19:16 +0000)]
Add TODO:
> * Support procedures, which return no value
>
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg01375.php
Bruce Momjian [Fri, 11 Apr 2008 19:14:57 +0000 (19:14 +0000)]
Update URLs for dead space map.
Bruce Momjian [Fri, 11 Apr 2008 16:09:33 +0000 (16:09 +0000)]
Fix main README typo.
Brendan Jurd
Tom Lane [Thu, 10 Apr 2008 22:25:26 +0000 (22:25 +0000)]
Replace "amgetmulti" AM functions with "amgetbitmap", in which the whole
indexscan always occurs in one call, and the results are returned in a
TIDBitmap instead of a limited-size array of TIDs. This should improve
speed a little by reducing AM entry/exit overhead, and it is necessary
infrastructure if we are ever to support bitmap indexes.
In an only slightly related change, add support for TIDBitmaps to preserve
(somewhat lossily) the knowledge that particular TIDs reported by an index
need to have their quals rechecked when the heap is visited. This facility
is not really used yet; we'll need to extend the forced-recheck feature to
plain indexscans before it's useful, and that hasn't been coded yet.
The intent is to use it to clean up 8.3's horrid @@@ kluge for text search
with weighted queries. There might be other uses in future, but that one
alone is sufficient reason.
Heikki Linnakangas, with some adjustments by me.
Bruce Momjian [Thu, 10 Apr 2008 18:58:15 +0000 (18:58 +0000)]
Add TODO URLs moved from open items queue:
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg00265.php
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg01214.php
> http://archives.postgresql.org/pgsql-patches/2007-05/msg00013.php
> http://archives.postgresql.org/pgsql-hackers/2007-07/msg00741.php
> http://archives.postgresql.org/pgsql-hackers/2007-08/msg00014.php
> http://archives.postgresql.org/pgsql-hackers/2007-08/msg00487.php
> * Allow index scans to return matching index keys
>
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg01079.php
>
> http://archives.postgresql.org/pgsql-patches/2007-10/msg00166.php
> http://archives.postgresql.org/pgsql-patches/2008-01/msg00049.php
Magnus Hagander [Thu, 10 Apr 2008 16:58:51 +0000 (16:58 +0000)]
Create wrapper pgwin32_safestat() and redefine stat() to it
on win32, because the stat() function in the runtime cannot
be trusted to always update the st_size field.
Per report and research by Sergey Zubkovsky.
Magnus Hagander [Thu, 10 Apr 2008 15:20:52 +0000 (15:20 +0000)]
Make parameters in implementation have same const:ness as the ones in
the prototype. Silences msvc build warning.
Alvaro Herrera [Thu, 10 Apr 2008 15:16:46 +0000 (15:16 +0000)]
Remove mention of DBD::PgSPI, which is unmaintained and generally unnecessary.
Alvaro Herrera [Thu, 10 Apr 2008 13:34:33 +0000 (13:34 +0000)]
Mention pg_backend_pid() in the system information section in addition
to the monitoring section.
Jim Nasby
Michael Meskes [Thu, 10 Apr 2008 10:43:35 +0000 (10:43 +0000)]
PGTYPEStimestamp_sub should use the values and not the pointers to substract.
Bruce Momjian [Wed, 9 Apr 2008 02:52:04 +0000 (02:52 +0000)]
Document that continuous archiving backup can be used for cases where
you can't get a simultaneous snapshot.
Bruce Momjian [Wed, 9 Apr 2008 01:04:08 +0000 (01:04 +0000)]
Update text FAQ.
Bruce Momjian [Wed, 9 Apr 2008 01:00:46 +0000 (01:00 +0000)]
Small wording improvements for source code READMEs.
Bruce Momjian [Wed, 9 Apr 2008 00:59:24 +0000 (00:59 +0000)]
Revert README cleanups.
Bruce Momjian [Wed, 9 Apr 2008 00:55:30 +0000 (00:55 +0000)]
Revert sentence removal from nickname in FAQ.
Bruce Momjian [Wed, 9 Apr 2008 00:44:07 +0000 (00:44 +0000)]
Remove mention of the Berkeley origins of the alias "Postgres" ---
seems unnecessary to mention in the FAQ, per discussion on IRC.
Tom Lane [Tue, 8 Apr 2008 18:20:29 +0000 (18:20 +0000)]
Fix tsvector_update_trigger() to be domain-friendly: it needs to allow all
the columns it works with to be domains over the expected type, not just
exactly the expected type. In passing, fix ts_stat() the same way.
Per report from Markus Wollny.
Peter Eisentraut [Tue, 8 Apr 2008 09:50:29 +0000 (09:50 +0000)]
On cygwin and win32, don't override the shlib name when building a module.
Should fix regression test failures on those platforms.
Magnus Hagander [Tue, 8 Apr 2008 07:50:41 +0000 (07:50 +0000)]
Make integer_datetimes the default on msvc as well, to have the same
default as other platforms.
Peter Eisentraut [Mon, 7 Apr 2008 23:08:15 +0000 (23:08 +0000)]
Always define stlib, since some platforms need it for building modules.
Should fix build failures on AIX.
Peter Eisentraut [Mon, 7 Apr 2008 14:15:58 +0000 (14:15 +0000)]
Implement a few changes to how shared libraries and dynamically loadable
modules are built. Foremost, it creates a solid distinction between these two
types of targets based on what had already been implemented and duplicated in
ad hoc ways before. Specifically,
- Dynamically loadable modules no longer get a soname. The numbers previously
set in the makefiles were dummy numbers anyway, and the presence of a soname
upset a few packaging tools, so it is nicer not to have one.
- The cumbersome detour taken on installation (build a libfoo.so.0.0.0 and
then override the rule to install foo.so instead) is removed.
- Lots of duplicated code simplified.
Bruce Momjian [Mon, 7 Apr 2008 02:14:14 +0000 (02:14 +0000)]
Add to TODO:
>
> o Add ability to obfuscate function bodies
>
> http://archives.postgresql.org/pgsql-patches/2008-01/msg00125.php
Bruce Momjian [Mon, 7 Apr 2008 00:51:27 +0000 (00:51 +0000)]
Add documentation clarification for IS [NOT] NULL and row-valued
expressions.
Tom Lane [Sun, 6 Apr 2008 23:43:29 +0000 (23:43 +0000)]
Make plpgsql support FOR over a query specified by a cursor declaration,
for improved compatibility with Oracle.
Pavel Stehule, with some fixes by me.
Tom Lane [Sun, 6 Apr 2008 16:54:49 +0000 (16:54 +0000)]
Improve hash_any() to use word-wide fetches when hashing suitably aligned
data. This makes for a significant speedup at the cost that the results
now vary between little-endian and big-endian machines; which forces us
to add explicit ORDER BYs in a couple of regression tests to preserve
machine-independent comparison results. Also, force initdb by bumping
catversion, since the contents of hash indexes will change (at least on
big-endian machines).
Kenneth Marshall and Tom Lane, based on work from Bob Jenkins. This commit
does not adopt Bob's new faster mix() algorithm, however, since we still need
to convince ourselves that that doesn't degrade the quality of the hashing.
Tom Lane [Sat, 5 Apr 2008 03:40:15 +0000 (03:40 +0000)]
A small visit from the portability and localization police.
Bruce Momjian [Sat, 5 Apr 2008 02:44:42 +0000 (02:44 +0000)]
Make dblink_current_query() reference pg_catalog.current_query(), per Tom.
Bruce Momjian [Sat, 5 Apr 2008 02:26:14 +0000 (02:26 +0000)]
Re-add dblink_current_query() for backward compatibility.
Tom Lane [Sat, 5 Apr 2008 01:58:20 +0000 (01:58 +0000)]
Defend against JOINs having more than 32K columns altogether. We cannot
currently support this because we must be able to build Vars referencing
join columns, and varattno is only 16 bits wide. Perhaps this should be
improved in future, but considering that it never came up before, I'm not
sure the problem is worth much effort. Per bug #4070 from Marcello
Ceschia.
The problem seems largely academic in 8.0 and 7.4, because they have
(different) O(N^2) performance issues with such wide joins, but
back-patch all the way anyway.
Bruce Momjian [Sat, 5 Apr 2008 01:34:06 +0000 (01:34 +0000)]
Have pg_stop_backup() wait for all archive files to be sent, rather than
returing right away. This guarantees that when pg_stop_backup()
returns, you have a valid backup.
Simon Riggs
Tom Lane [Fri, 4 Apr 2008 18:45:36 +0000 (18:45 +0000)]
Re-implement division for numeric values using the traditional "schoolbook"
algorithm. This is a good deal slower than our old roundoff-error-prone
code for long inputs, so we keep the old code for use in the transcendental
functions, where everything is approximate anyway. Also create a
user-accessible function div(numeric, numeric) to provide access to the
exact result of trunc(x/y) --- since the regular numeric / operator will
round off its result, simply computing that expression in SQL doesn't
reliably give the desired answer. This fixes bug #3387 and various related
corner cases, and improves the usefulness of PG for high-precision integer
arithmetic.
Bruce Momjian [Fri, 4 Apr 2008 18:00:25 +0000 (18:00 +0000)]
Have psql command 'help' suggest the use of \?, updated version.
Greg Sabino Mullane
Bruce Momjian [Fri, 4 Apr 2008 17:42:43 +0000 (17:42 +0000)]
Allow 'help' in psql to show \? help, for novice assistance.
Greg Sabino Mullane
Tom Lane [Fri, 4 Apr 2008 17:25:23 +0000 (17:25 +0000)]
Remove no-longer-used function assign_backslash_quote()
Bruce Momjian [Fri, 4 Apr 2008 17:02:56 +0000 (17:02 +0000)]
Remove unneed #include now that current_query() has moved to the backend.
Bruce Momjian [Fri, 4 Apr 2008 16:57:21 +0000 (16:57 +0000)]
Implement current_query(), that shows the currently executing query.
At the same time remove dblink/dblink_current_query() as it is no longer
necessary
*BACKWARD COMPATIBILITY ISSUE* for dblink
Tomas Doran
Magnus Hagander [Fri, 4 Apr 2008 12:44:36 +0000 (12:44 +0000)]
Oops, change should go in scan.l to survive a clean checkout and not just
a make clean...
Magnus Hagander [Fri, 4 Apr 2008 11:47:19 +0000 (11:47 +0000)]
Convert backslash_quote guc to use enum.
Magnus Hagander [Fri, 4 Apr 2008 08:33:15 +0000 (08:33 +0000)]
Turn xmlbinary and xmloption GUC variables into enumsTurn xmlbinary and
xmloption GUC variables into enums..
Tom Lane [Thu, 3 Apr 2008 21:13:07 +0000 (21:13 +0000)]
Add a variant of the Levenshtein string-distance function that lets the user
specify the cost values to use, instead of always using 1's.
Volkan Yazici
In passing, remove fuzzystrmatch.h, which contained a bunch of stuff that had
no business being in a .h file; fold it into its only user, fuzzystrmatch.c.
Bruce Momjian [Thu, 3 Apr 2008 18:14:02 +0000 (18:14 +0000)]
Add Wiki URLs for:
< * Allow encoding on a per-column basis optionally using the ICU library
> http://wiki.postgresql.org/wiki/Todo:Collate
> http://wiki.postgresql.org/wiki/Todo:ICU
Tom Lane [Thu, 3 Apr 2008 17:12:27 +0000 (17:12 +0000)]
Remove heap_release_fetch, which is no longer used anywhere; this simplifies
heap_fetch a little.
Bruce Momjian [Thu, 3 Apr 2008 16:37:07 +0000 (16:37 +0000)]
Add to TODO:
> * Improve how ANALYZE computes in-doubt tuples
>
> http://archives.postgresql.org/pgsql-hackers/2007-11/msg00771.php
>
Tom Lane [Thu, 3 Apr 2008 16:27:25 +0000 (16:27 +0000)]
Teach ANALYZE to distinguish dead and in-doubt tuples, which it formerly
classed all as "dead"; also get it to count DEAD item pointers as dead rows,
instead of ignoring them as before. Also improve matters so that tuples
previously inserted or deleted by our own transaction are handled nicely:
the stats collector's live-tuple and dead-tuple counts will end up correct
after our transaction ends, regardless of whether we end in commit or abort.
While there's more work that could be done to improve the counting of in-doubt
tuples in both VACUUM and ANALYZE, this commit is enough to alleviate some
known bad behaviors in 8.3; and the other stuff that's been discussed seems
like research projects anyway.
Pavan Deolasee and Tom Lane
Magnus Hagander [Thu, 3 Apr 2008 13:25:02 +0000 (13:25 +0000)]
Oops, add proper #ifdef for systems without support for syslog.
Per buildfarm member mastodon.
Peter Eisentraut [Thu, 3 Apr 2008 09:52:03 +0000 (09:52 +0000)]
Remove -C from rsync call, because it omits directories named "core".
Magnus Hagander [Thu, 3 Apr 2008 09:21:15 +0000 (09:21 +0000)]
Convert syslog_facility guc to enum type.
Bruce Momjian [Thu, 3 Apr 2008 01:56:04 +0000 (01:56 +0000)]
Add URLs for:
* Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT
> http://archives.postgresql.org/pgsql-patches/2008-01/msg00105.php
> http://archives.postgresql.org/pgsql-patches/2008-03/msg00327.php
Tom Lane [Wed, 2 Apr 2008 18:31:50 +0000 (18:31 +0000)]
Revert my bad decision of about a year ago to make PortalDefineQuery
responsible for copying the query string into the new Portal. Such copying
is unnecessary in the common code path through exec_simple_query, and in
this case it can be enormously expensive because the string might contain
a large number of individual commands; we were copying the entire, long
string for each command, resulting in O(N^2) behavior for N commands.
(This is the cause of bug #4079.) A second problem with it is that
PortalDefineQuery really can't risk error, because if it elog's before
having set up the Portal, we will leak the plancache refcount that the
caller is trying to hand off to the portal. So go back to the design in
which the caller is responsible for making sure everything is copied into
the portal if necessary.
Magnus Hagander [Wed, 2 Apr 2008 14:42:56 +0000 (14:42 +0000)]
Convert three more guc settings to enum type:
default_transaction_isolation, session_replication_role and regex_flavor.
Bruce Momjian [Wed, 2 Apr 2008 02:11:47 +0000 (02:11 +0000)]
Remove due to survey/discussion:
<
< * Prefix command-line utilities like createuser with 'pg_'
<
< http://archives.postgresql.org/pgsql-hackers/2007-06/msg00025.php
<
Tom Lane [Tue, 1 Apr 2008 03:51:09 +0000 (03:51 +0000)]
Support EXECUTE USING in plpgsql.
Pavel Stehule, with some improvements by myself.
Tom Lane [Tue, 1 Apr 2008 03:09:30 +0000 (03:09 +0000)]
Add SPI-level support for executing SQL commands with one-time-use plans,
that is commands that have out-of-line parameters but the plan is prepared
assuming that the parameter values are constants. This is needed for the
plpgsql EXECUTE USING patch, but will probably have use elsewhere.
This commit includes the SPI functions and documentation, but no callers
nor regression tests. The upcoming EXECUTE USING patch will provide
regression-test coverage. I thought committing this separately made
sense since it's logically a distinct feature.
Tom Lane [Tue, 1 Apr 2008 00:48:33 +0000 (00:48 +0000)]
Fix an oversight I made in a cleanup patch over a year ago:
eval_const_expressions needs to be passed the PlannerInfo ("root") structure,
because in some cases we want it to substitute values for Param nodes.
(So "constant" is not so constant as all that ...) This mistake partially
disabled optimization of unnamed extended-Query statements in 8.3: in
particular the LIKE-to-indexscan optimization would never be applied if the
LIKE pattern was passed as a parameter, and constraint exclusion depending
on a parameter value didn't work either.
Tom Lane [Mon, 31 Mar 2008 16:59:26 +0000 (16:59 +0000)]
Apply my original fix for Taiki Yamaguchi's bug report about DISTINCT MAX().
Add some regression tests for plausible failures in this area.
Tom Lane [Mon, 31 Mar 2008 03:34:27 +0000 (03:34 +0000)]
Fix my brain fade in TRUNCATE triggers patch: can't release relcache refcounts
while EState still contains pointers to those relations. Exposed by the
CLOBBER_CACHE_ALWAYS tests that buildfarm member jaguar is running (I knew
those cycles would pay off...)
Tom Lane [Mon, 31 Mar 2008 02:43:14 +0000 (02:43 +0000)]
Use error message wordings for permissions checks on .pgpass and SSL private
key files that are similar to the one for the postmaster's data directory
permissions check. (I chose to standardize on that one since it's the most
heavily used and presumably best-wordsmithed by now.) Also eliminate explicit
tests on file ownership in these places, since the ensuing read attempt must
fail anyway if it's wrong, and there seems no value in issuing the same error
message for distinct problems. (But I left in the explicit ownership test in
postmaster.c, since it had its own error message anyway.) Also be more
specific in the documentation's descriptions of these checks. Per a gripe
from Kevin Hunter.
Tom Lane [Mon, 31 Mar 2008 01:31:43 +0000 (01:31 +0000)]
Fix a number of places that were making file-type tests infelicitously.
The places that did, eg,
(statbuf.st_mode & S_IFMT) == S_IFDIR
were correct, but there is no good reason not to use S_ISDIR() instead,
especially when that's what the other 90% of our code does. The places
that did, eg,
(statbuf.st_mode & S_IFDIR)
were flat out *wrong* and would fail in various platform-specific ways,
eg a symlink could be mistaken for a regular file on most Unixen.
The actual impact of this is probably small, since the problem cases
seem to always involve symlinks or sockets, which are unlikely to be
found in the directories that PG code might be scanning. But it's
clearly trouble waiting to happen, so patch all the way back anyway.
(There seem to be no occurrences of the mistake in 7.4.)
Tom Lane [Sun, 30 Mar 2008 18:10:20 +0000 (18:10 +0000)]
Show database access privileges in psql's \l command. For \l+, also show
database size, when available to the current user.
Andrew Gilligan