OSDN Git Service
Javier Martinez Canillas [Sun, 2 May 2010 17:05:33 +0000 (13:05 -0400)]
Staging: adis16255: Fix compile error
This patch solves a compilation error in today linux-next tree.
The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 2 May 2010 07:33:26 +0000 (09:33 +0200)]
Staging: winbond: Renamed README to TODO and corrected Pavel's mail
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Sat, 1 May 2010 22:12:26 +0000 (19:12 -0300)]
Staging: vt6656: code cleanup, fixed comments style at the end of headers
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Sat, 1 May 2010 17:25:00 +0000 (14:25 -0300)]
Staging: vt6656: removed VOID/PVOID definitions
Warnings about the usage of externs in .c files were not resolved here.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:59:57 +0000 (13:59 -0700)]
Staging: comedi: clean up kcomedilib/get.c
Remove all of the unused functions, leaving only those that are
actually called by in-kernel code.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:55:30 +0000 (13:55 -0700)]
Staging: comedi: delete kcomedilib/data.c
No one is using any of these functions, so remove the file entirely.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:51:58 +0000 (13:51 -0700)]
Staging: comedi: remove unused functions from comedilib.h
Remove the functions that are not used from this file. Now it will
be easier to determine what code can be removed from kcomedilib by
using sparse.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:44:56 +0000 (13:44 -0700)]
Staging: comedi: move an include file out of comedlib.h
The one .c file that needs it can properly include it.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:42:37 +0000 (13:42 -0700)]
Staging: comedi: clean up comedilib.h
Remove a whole #ifdef section that is not needed anymore.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 20:08:06 +0000 (13:08 -0700)]
Staging: comedi: kcomedilib: remove ksyms.c file
Move only the exports that we actually use into the individual
files, and delete the ksyms.c file entirely. This will make it
easier to start cleaning up kcomedilib (i.e. delete most of it.)
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 19:38:02 +0000 (12:38 -0700)]
Staging: comedi: remove comedi_ksyms.c
Move the 4 remaining exports to their function location
and then remove the comedi_ksyms.c file, as it's no longer
needed.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 19:33:17 +0000 (12:33 -0700)]
Staging: comedi: rename check_chanlist to comedi_check_chanlist
It's a global function, so properly name it and move the
export to where the function is located at.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 19:12:02 +0000 (12:12 -0700)]
Staging: comedi: more EXPORT_SYMBOL movement
Move the exports for the variables that are in range.c into the
file itself. These variables should be prefixed with comedi_ but
that's for a different patch...
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 19:02:23 +0000 (12:02 -0700)]
Staging: comedi: more EXPORT_SYMBOL movement
This moves the markings to the comedi_fops.c file, where
they belong.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 18:54:07 +0000 (11:54 -0700)]
Staging: comedi: move a bunch of EXPORT_SYMBOL lines
Move the ones that are needed to be in drivers.c into the
file. This is with the goal of deleting the comedi_ksyms.c
file.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 18:43:32 +0000 (11:43 -0700)]
Staging: comedi: comedi_ksysms: remove commented out symbols
These aren't needed, they are commented out, so remove them.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Linus Lüssing [Mon, 22 Mar 2010 21:46:15 +0000 (22:46 +0100)]
Staging: batman-adv: Fixing wrap-around bug in vis
When the seqno for a vis packet had a wrap around from i.e. 255 to 0,
add_packet() would falsely claim the older packet with the seqno 255 as
newer as the one with the seqno of 0 and would therefore ignore the new
packet. This happens with all following vis packets until the old vis
packet expires after 180 seconds timeout. This patch fixes this issue
and gets rid of these highly undesired 3min. breaks for the vis-server.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Linus Lüssing [Mon, 22 Mar 2010 21:46:14 +0000 (22:46 +0100)]
Staging: batman-adv: Fix VIS output bug for secondary interfaces
TQ and HNA records for originators on secondary interfaces were
wrongly being included on the primary interface. Ensure we output a
line for each source interface on every node, so we correctly separate
primary and secondary interface records.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andrew Lunn [Mon, 22 Mar 2010 21:46:13 +0000 (22:46 +0100)]
Staging: batman-adv: don't have interrupts disabled while sending.
send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now need a new lock to protect that
instead of vis_hash_lock.
Also a few checkpatch cleanups.
Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 17:59:23 +0000 (10:59 -0700)]
Staging: dt3155v4l: add driver to the build
The last patch forgot to add the driver to the Makefile, so it
would not end up getting built. This resolves that issue.
Cc: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marin Mitov [Fri, 30 Apr 2010 15:36:09 +0000 (18:36 +0300)]
Staging: Yet another (third) dt3155 driver PCI/video4linux compliant
Kernel module (device driver) for dt3155 frame grabber
video4linux2 compliant (finally). Works with "xawtv -f".
======================================================
This driver is written (almost) from scratch, using the
allocator developed for dt3155pci see bellow). The driver
uses videobuf-dma-contig interface modified to use the above
mentioned allocator instead of dma_alloc_coheren().
The first thing to do was to design a new allocator based
on allocating a configurable number of 4MB chunks of memory,
that latter are broken into frame buffers of 768x576 bytes
kept in different FIFOs (queues). As far as the driver autoloads
as a kernel module during kernel boot, the allocation of 4MB
chunks succeeds.
The driver keeps three FIFOs: one for 4MB chunks, one for free
buffers (available for allocations) and one for buffers already
allocated. Allocation/deallocation is done automatically though
the video4linux videobuf subsystem (some pointers to functions
are replaced by driver supplied functions).
Sure, there are problems:
1. The device tested to work with "xawtv -f" either via read()
method (DT3155_STREAMING not selected), or via mmap() method
(DT3155_STREAMING is selected) only. This coresponds to either
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE;
or
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
but not when
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE |
V4L2_CAP_STREAMING |
V4L2_CAP_READWRITE;
This is because xawtv calls poll() before starting streaming,
but videobuf_poll_stream() automatically starts reading if streaming
is not started.
This selection is made during kernel configuration (for now).
2. Works for CCIR, but should work for RS-170 (not tested)
This is made also during kernel configuration.
3. Could work for multiple dt3155 frame grabbers in a PC,
(private data is allocated during PCI probe() method), but
is not tested due to lack of a second board.
4. Not tested on a BIG ENDIAN architecture.
5. Many others you could find .... :-)
All critics, comments, suggestions are wellcome.
Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 00:36:52 +0000 (17:36 -0700)]
Staging: comedi: remove another vendor id
This id was already in the drivers, so just use it there
instead of in a common header file.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 00:32:04 +0000 (17:32 -0700)]
Staging: comedi: move another pci vendor id
Move the vendor id to the drivers needing it.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 00:23:51 +0000 (17:23 -0700)]
Staging: comedi: move another pci device id to the driver
Put a pci vendor id into the drivers that need them.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Sat, 1 May 2010 00:07:25 +0000 (17:07 -0700)]
Staging: comedi: move a pci vendor id
The vendor id should be in the driver that needs it, not in
a common file.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 23:58:36 +0000 (16:58 -0700)]
Staging: comedi: remove some pci vendor ids
These are never used, so remove them.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 23:52:52 +0000 (16:52 -0700)]
Staging: comedi: use the standard NI pci device id
Don't redefine something that we already have in the core
kernel. Also move to use PCI_DEVICE() macros to make things
a bit simpler when changing the define.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:59:18 +0000 (15:59 -0700)]
Staging: comedi: fix up remaining coding style issue in proc.c
Move the external variable into a .h file, where it belongs.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:55:39 +0000 (15:55 -0700)]
Staging: comedi: remove wrapper.h
Just make the bit call when it is needed, no need to wrap
things up like this for no reason.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:48:19 +0000 (15:48 -0700)]
Staging: comedi: remove local pci_ids.h file
It's only being used for one vendor id, so move it into
the driver that uses it and delete the file.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:43:12 +0000 (15:43 -0700)]
Staging: comedi: fix up coding issues in proc.c
Fixes all but one.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:35:37 +0000 (15:35 -0700)]
Staging: comedi: fix up coding style issues in range.c
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:31:13 +0000 (15:31 -0700)]
Staging: comedi: remove unneeded ifdef in comedi_bond.c
No need to check for MODULE_LICENSE, it's always there.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:26:54 +0000 (15:26 -0700)]
Staging: comedi: fix coding style issues in comedidev.h
This resolves some coding style issues in comedidev.h
And yes, volatile here meant nothing, removing it is ok.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:25:53 +0000 (15:25 -0700)]
Staging: comedi: fix up coding style issues in comedilib.h
This resolves some issues with comedilib.h
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Fri, 30 Apr 2010 17:07:12 +0000 (10:07 -0700)]
Staging: cxt1e1: use netdev_priv to fix build
Fix cxt1e1 build error:
drivers/staging/cxt1e1/linux.c:1195: error: 'struct net_device' has no member named 'priv'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Van Nyen [Thu, 29 Apr 2010 17:27:31 +0000 (19:27 +0200)]
Staging: iio: Fix remaining code style issues
fix code style issues
Signed-of-by: Roel Van Nyen <roel.vannyen@gmail.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Iain Churcher [Thu, 29 Apr 2010 18:02:01 +0000 (19:02 +0100)]
Staging: comedi: numerous checkpatch.pl issues in dt282x.c
This patch cleans up numerous WARNINGS and ERRORS listed by the
checkpatch.pl tool
Signed-off-by: Iain Churcher <iain.linux.coding@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Thu, 29 Apr 2010 17:46:32 +0000 (10:46 -0700)]
Staging: memrar: fix printk format warning
Fix printk format warning in memrar:
drivers/staging/memrar/memrar_handler.c:393: warning: format '%u' expects type 'unsigned int', but argument 4 has type 'size_t'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ossama Othman <ossama.othman@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Rankilor [Thu, 29 Apr 2010 10:17:16 +0000 (18:17 +0800)]
Staging: comedi: added log level to printk's in comedi_fops.c
This patches comedi_fops.c to add kernel log level to some printk calls
Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
matthias [Thu, 29 Apr 2010 15:05:56 +0000 (17:05 +0200)]
Staging: add driver for adis16255 gyroscope
This drivers allows a communication with the Analog Devices ADIS16255
Low Power Gyroscope over SPI.
Signed-off-by: Matthias Brugger <mensch0815@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Yong Wang [Fri, 23 Apr 2010 08:26:42 +0000 (16:26 +0800)]
Staging: rtl8192e: Use the standard config option for PM functions
Use the standard config option CONFIG_PM to enable rtl8192e PM
functions. Tested on Samsung N140 and it works fine. Without enabling
the PM functions, the box always fails to resume.
Signed-off-by: Yong Wang <yong.y.wang@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Sat, 17 Apr 2010 15:07:42 +0000 (12:07 -0300)]
Staging: vt6656: Removed IN definition
Code cleanup, removed empty IN definition used to denote input parameters.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Forest Bond [Sat, 17 Apr 2010 15:03:47 +0000 (11:03 -0400)]
Staging: vt6655: Rename hostap_set_hostapd, hostap_iotctl.
The functions hostap_set_hostapd, hostap_iotctl clashed with functions of the
same name with CONFIG_HOSTAP=y and/or CONFIG_VT6656=y.
Signed-off-by: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Forest Bond [Sat, 17 Apr 2010 15:03:38 +0000 (11:03 -0400)]
Staging: vt6656: Rename hostap_set_hostapd, hostap_iotctl.
The functions hostap_set_hostapd, hostap_iotctl clashed with functions of the
same name with CONFIG_HOSTAP=y and/or CONFIG_VT6655=y.
Signed-off-by: Forest Bond <forest@alittletooquiet.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Wed, 14 Apr 2010 00:54:48 +0000 (21:54 -0300)]
Staging: vt6656: incorporated ETH_ALEN macro instead of custom one
Replaced custom U_ETHER_ADDR_LEN by ETH_ALEN from <linux/if_ether.h>.
Resolved checkpatch findings on the changed lines, mostly indentation.
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Tue, 13 Apr 2010 22:43:07 +0000 (19:43 -0300)]
Staging: vt6656: struct usb_driver cleanup
Code cleanup following other USB drivers:
- Renamed driver struct and callbacks to vt6656_*
- Added __init/__exit like directives
- Resolved checkpatch.pl findings on those lines
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:57 +0000 (13:16 -0500)]
Staging: Kconfig, Makefile for TI's ST ldisc
This change adds the Kconfig and Make file for TI's
ST line discipline driver and the BlueZ driver for BT
core of the TI BT/FM/GPS combo chip.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Pavan Savoy [Thu, 8 Apr 2010 18:16:59 +0000 (13:16 -0500)]
Staging: bluetooth: BT driver using ST for TI combo devices
This is BlueZ driver making use of Shared Transport line
discipline to communicate with the chip.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:58 +0000 (13:16 -0500)]
Staging: add TODO and ABI to ti-st
A TODO file and a ABI to list the things to be done,
and user-space/kernel-space interface for this ldisc.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:56 +0000 (13:16 -0500)]
Staging: sources for ST header file
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This is the common header file for both the ST driver and the
protocol drivers which intend to use ST as their mode of
transport.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:55 +0000 (13:16 -0500)]
Staging: sources for HCI LL PM protocol
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This module constitutes the proprietary power management
protocol from TI for the BT/FM/GPS combo chips
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:54 +0000 (13:16 -0500)]
Staging: sources for Init manager module
Kernel Space Init-Manager works along with User-Mode
Init Manager daemon running to maintain the UART state.
Communication between user-space daemon and this module can be
1. Via the pid written onto sysfs entry
2. Via the rfkill subsystem
It also is a platform driver with a relevant platform device
in the board-*.c along with the list of BT/FM/GPS chip enable
gpio configuration
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavan Savoy [Thu, 8 Apr 2010 18:16:53 +0000 (13:16 -0500)]
Staging: sources for ST core
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This module constitutes the core logic, TTY ldisc driver
and the exported symbols for registering/unregistering of
the protocol drivers such as BT/FM/GPS.
Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Howard Chu [Mon, 12 Apr 2010 05:27:13 +0000 (22:27 -0700)]
Staging: rt2870: Allow building on ARM
Signed-off-by: Howard Chu <hyc@symas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Sun, 11 Apr 2010 18:59:01 +0000 (15:59 -0300)]
staging: vt6656: cleared checkpatch.pl findings in 80211hdr.h
Code cleanup in:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Findings were:
do not use C99 // comments
space required after that close brace '}'
line over 80 characters
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 11 Apr 2010 12:05:51 +0000 (15:05 +0300)]
Staging: rtl8192u: fix space coding style issue in ieee80211_crypt.h
This is a patch to the ieee80211_crypt.h file that fixed up a space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 11 Apr 2010 12:05:39 +0000 (15:05 +0300)]
Staging: rtl8192u: ix brace, comments and space coding style issue in ieee80211.h
This is a patch to the ieee80211.h file that fixed up a brace, comments
and space Errors found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 11 Apr 2010 10:39:47 +0000 (13:39 +0300)]
Staging: rtl8192u: fix comments and space coding style issue in dot11d.h
This is a patch to the dot11d.h file that fixed up a comments and space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 11 Apr 2010 10:22:53 +0000 (13:22 +0300)]
Staging: serqt_usb2: fix space coding style issue in serqt_usb2.c
This is a patch to the serqt_usb2.c files that fixed space error and
warning found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
John Church [Thu, 8 Apr 2010 21:04:17 +0000 (16:04 -0500)]
Staging: rtl8187se: fix coding style issues in r8180_core.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John Church <j.church@ymail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:18 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not mess with carrier settings while scanning
Toggling the link carrier is a non sense and is the grossest locking I can
think of. Moreover, it's giving a completely inaccurate status to userspace
who could for example decide to turn the interface down on carrier off
detection.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:19 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not send NULL BSSID events when not associated
If we're not associated, we should not send wireless events to let userspace
know that we just left an ESSID, simply because we havent yet joined it.
If we keep on doing that, wpa_supplicant could receive such events while
actually trying to join an ESSID, and thus decide to stop trying. This leads
to a lot of connection failures as this driver seems to be sending GIWAP
events quite a lot.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:17 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not autoconnect based on probe response
Getting a probe response after sending a probe request to a specific SSID
doesnt mean we're trying to associate with this SSID.
wpa_supplicant should be the only one deciding when to join an SSID, not the
kernel.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ng Kian Yong [Sat, 3 Apr 2010 09:09:34 +0000 (17:09 +0800)]
Staging: vt6655: fix brace coding style issue in ioctl.c
This is a patch to the ioctl.c file that fixes up a brace warning found
by the checkpatch.pl tool
Signed-off-by: Ng Kian Yong <ngky@comp.nus.edu.sg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 3 Apr 2010 05:00:37 +0000 (07:00 +0200)]
Staging: udlfb: minor cleanups
This cleans up udlfb a tiny bit.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Olimpiu Pascariu [Thu, 1 Apr 2010 20:48:14 +0000 (23:48 +0300)]
Staging: rtl8187se: fixed checkpatch.pl warnings and errors in r8180_rtl8225z2.c
This is a patch to the r8180_rtl8225z2.c file that fixes up errors and
warnings found by the checkpatch.pl tool
Signed-off-by: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Soeren Moeller [Tue, 30 Mar 2010 20:11:12 +0000 (20:11 +0000)]
Staging: quatech_usb2: fix coding style issues
This is a patch to the file quatech_usb2.c that fixes two space before
tabular and one line of more than 80 characters warnings found by
checkpatch.pl
Signed-off-by: Soeren Moeller <soerenmoeller2001@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ossama Othman [Fri, 26 Mar 2010 22:11:11 +0000 (15:11 -0700)]
Staging: add initial memrar ABI document
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Javier Muñoz Mellid [Mon, 29 Mar 2010 17:35:24 +0000 (19:35 +0200)]
Staging: sm7xx: Fixed coding style issue
Fixed a format issue
Signed-off-by: Javier Muñoz Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 13:28:19 +0000 (00:28 +1100)]
Staging: vt6656: int.c: Fixed Coding Style issues
Fixed almost all the issues given by checkpatch.pl except for one
warning about an 81 character line, which cannot really be decomposed
(the code is a bit too nested there).
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 12:19:20 +0000 (23:19 +1100)]
Staging: vt6656: tcrc.c: Fixed coding style issues
Fixed minor problems with indentation.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 12:28:33 +0000 (23:28 +1100)]
Staging: vt6656: tether.c: Fixed coding style issues
Fixed some indentation and spacing issues.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 12:20:36 +0000 (23:20 +1100)]
Staging: vt6656: michael.c: Fixed coding style issues
Replaced lots of spaces by real tabs and resolved other minor issues.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 11:40:54 +0000 (22:40 +1100)]
Staging: vt6656: control.c: Fixed coding style issues
Replaced lots of spaces by real tabs and fixed some 80+ lines.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniel Kenji Toyama [Mon, 29 Mar 2010 11:26:46 +0000 (22:26 +1100)]
Staging: vt6656: rc4.c: Fixed coding style issues
Replaced all indentation by spaces by tabs.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Johan Meiring [Sun, 28 Mar 2010 19:36:09 +0000 (21:36 +0200)]
Staging: line6: rewrote inline comments in control.h
This is a patch to control.h that presents certain inline comments in a
neater way, and which eliminates the 80 character error found by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 28 Apr 2010 20:40:11 +0000 (16:40 -0400)]
Staging: vme: declare vme_calc_slot() as static
vme_calc_slot() is not used anywhere other than vme.c so it should be
declared as static.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 28 Apr 2010 20:40:10 +0000 (16:40 -0400)]
Staging: vme: declare vme_bus_num_mtx static
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Martyn Welch [Mon, 22 Mar 2010 14:58:57 +0000 (14:58 +0000)]
Staging: vme: Correct checkpatch errors
Correct numerous checkpatch errors in the vme driver.
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Martyn Welch [Mon, 22 Mar 2010 14:58:50 +0000 (14:58 +0000)]
Staging: vme: Use dev_err rather than printk
Replace instances of printk with dev_err where possible.
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Florian Schilhabel [Thu, 18 Mar 2010 14:18:56 +0000 (15:18 +0100)]
Staging: rtl8192su: changed check_reset_cnt to be static again
variable check_reset_cnt in rtl819x_watchdog_wqcallback is now static
again.
also, little cosmetics.
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Florian Schilhabel [Thu, 18 Mar 2010 14:18:34 +0000 (15:18 +0100)]
Staging: rtl8192su: some work on SetBWModeCallback8192SUsbWorkItem
mostly cosmetics.
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Florian Schilhabel [Thu, 18 Mar 2010 14:18:12 +0000 (15:18 +0100)]
Staging: rtl8192su: removed 2 printks in rtl8192SU_link_change
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Florian Schilhabel [Thu, 18 Mar 2010 14:17:29 +0000 (15:17 +0100)]
Staging: rtl8192su: refactored FirmwareDownload92S
added a new function: FirmwareRequest92S
This function(instead of FirmwareDownload92S) is now responsible for
requesting the firmware.
FirmwareDownload92S is now easier to read, smaller and follows kernel
coding style.
plus cosmetics.
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Florian Schilhabel [Thu, 18 Mar 2010 14:16:47 +0000 (15:16 +0100)]
Staging: rtl8192su: refactored EnableHWSecurityConfig8192 and setKey
refactored EnableHWSecurityConfig8192 and setKey a bit by replacing
if...else if... else with switch...case
plus cosmetics
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonas Lundqvist [Tue, 16 Mar 2010 14:41:09 +0000 (15:41 +0100)]
Staging: phison: fix incorrect tabs in phison.c
This patch fixes two incorrect tab warnings found by the checkpatch.pl
tool
Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 07:36:15 +0000 (09:36 +0200)]
Staging: wlags49_h2: fix copyright and comments style issue in dhfcfg.h
This is a patch to the dhfcfg.h file that fixed up a copyright and
commets style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 07:24:57 +0000 (09:24 +0200)]
Staging: wlags49_h2: fix space and comments style issue in dhf.h
This is a patch to the dhf.c file that fixed up a space and comments
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sat, 20 Mar 2010 07:24:44 +0000 (09:24 +0200)]
Staging: wlags49_h2: fix copyright and space style issue in dhf.h
This is a patch to the dhf.h file that fixed up a copyright anf space
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Wed, 17 Mar 2010 09:02:49 +0000 (11:02 +0200)]
Staging: wlags49_h2: fix trailing statements coding style issue in dhf.c
This is a patch to the dhf.c file that fixed up a trailing statements
Errors found by the checkpatch.pl tools, like
trailing statements should be on next line
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Wed, 17 Mar 2010 08:14:34 +0000 (10:14 +0200)]
Staging: wlags49_h2: fix TAB and space coding style issue dhf.c
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Tue, 16 Mar 2010 19:59:22 +0000 (21:59 +0200)]
Staging: wlags49_h2: fix copyright style issue in dhf.c
This is a patch to the dhf.c file that fixed up a copyright style Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Tue, 16 Mar 2010 19:48:11 +0000 (21:48 +0200)]
Staging: wlags49_h2: fix comments coding style issue in dhf.c
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 22:05:34 +0000 (00:05 +0200)]
Staging: wlags49_h2: fix TAB and space coding style issue in ap_h2.c
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 21:29:02 +0000 (23:29 +0200)]
Staging: wlags49_h2: fix comments coding style issue in ap_h2.c
This is a patch to the ap_h2.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 20:46:24 +0000 (22:46 +0200)]
Staging: wlags49_h2: fix spaces, macros and comments coding style issue in debug.h
This is a patch to the debug.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
and
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
and
do not use C99 // comments
and
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Wed, 17 Mar 2010 14:40:57 +0000 (14:40 +0000)]
Staging: wlan-ng: refactor p80211wext.c to reduce text size.
Refactor the wext interface to reduce lines of code & module text size.
- add a helper function p80211wext_getmib
- rename p80211wext_dorequest to p80211wext_setmib
- refactor wext to call the get/set mib helpers and so reduce repeated code.
size reported text reduction :-
text data bss dec hex filename
8343 720 0 9063 2367 p80211wext.o.patch
9907 720 0 10631 2987 p80211wext.o.orig
Tested on x86_32 laptop, everything works correctly using NetworkManager,
and iwconfig & iwlist return sensible results when reading from the card.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Wed, 17 Mar 2010 14:40:56 +0000 (14:40 +0000)]
Staging: wlan-ng: fix p80211wext_mhz_to_channel for channel 14
Channel 14 is 2484 Mhz (cf p80211wext_channel_to_mhz) so this patch
corrects what seems to be just a typo.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Wed, 17 Mar 2010 14:40:55 +0000 (14:40 +0000)]
Staging: wlan-ng: tidy up iw_handler
Use array initialisation technique copied from ipw2200.c.
This should always get the function pointers in the correct place,
without the needed for endless counting, skipping blanks etc.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>