OSDN Git Service
Rich Felker [Wed, 18 Apr 2018 18:46:05 +0000 (14:46 -0400)]
minor cleanup in fopencookie
assign entire struct rather than member-at-a-time. don't repeat buffer
sizes; always use sizeof to ensure consistency.
Rich Felker [Tue, 17 Apr 2018 22:36:19 +0000 (18:36 -0400)]
allow interposition/replacement of allocator (malloc)
replacement is subject to conditions on the replacement functions.
they may only call functions which are async-signal-safe, as specified
either by POSIX or as an implementation-defined extension. if any
allocator functions are replaced, at least malloc, realloc, and free
must be provided. if calloc is not provided, it will behave as
malloc+memset. any of the memalign-family functions not provided will
fail with ENOMEM.
in order to implement the above properties, calloc and __memalign
check that they are using their own malloc or free, respectively.
choice to check malloc or free is based on considerations of
supporting __simple_malloc. in order to make this work, calloc is
split into separate versions for __simple_malloc and full malloc;
commit
ba819787ee93ceae94efd274f7849e317c1bff58 already did most of
the split anyway, and completing it saves an extra call frame.
previously, use of -Bsymbolic-functions made dynamic interposition
impossible. now, we are using an explicit dynamic-list, so add
allocator functions to the list. most are not referenced anyway, but
all are added for completeness.
Rich Felker [Wed, 18 Apr 2018 04:16:12 +0000 (00:16 -0400)]
refactor flockfile not to duplicate lock mechanism logic
Rich Felker [Wed, 18 Apr 2018 03:59:41 +0000 (23:59 -0400)]
fix stdio lock dependency on read-after-free not faulting
instead of using a waiters count, add a bit to the lock field
indicating that the lock may have waiters. threads which obtain the
lock after contending for it will perform a potentially-spurious wake
when they release the lock.
Rich Felker [Tue, 17 Apr 2018 20:37:30 +0000 (16:37 -0400)]
remove unused __brk function/source file
commit
e3bc22f1eff87b8f029a6ab31f1a269d69e4b053 removed all references
to __brk.
Rich Felker [Tue, 17 Apr 2018 19:55:18 +0000 (15:55 -0400)]
enable reclaim_gaps for fdpic
the existing laddr function for fdpic cannot translate ELF virtual
addresses outside of the LOAD segments to runtime addresses because
the fdpic loadmap only covers the logically-mapped part. however the
whole point of reclaim_gaps is to recover the slack space up to the
page boundaries, so it needs to work with such addresses.
add a new laddr_pg function that accepts any address in the page range
for the LOAD segment by expanding the loadmap records out to page
boundaries. only use the new version for reclaim_gaps, so as not to
impact performance of other address lookups.
also, only use laddr_pg for the start address of a gap; the end
address lies one byte beyond the end, potentially in a different page
where it would get mapped differently. instead of mapping end, apply
the length (end-start) to the mapped value of start.
Rich Felker [Tue, 17 Apr 2018 19:18:49 +0000 (15:18 -0400)]
comment __malloc_donate overflow logic
Alexander Monakov [Mon, 16 Apr 2018 17:54:36 +0000 (20:54 +0300)]
ldso, malloc: implement reclaim_gaps via __malloc_donate
Split 'free' into unmap_chunk and bin_chunk, use the latter to introduce
__malloc_donate and use it in reclaim_gaps instead of calling 'free'.
Alexander Monakov [Mon, 16 Apr 2018 17:54:35 +0000 (20:54 +0300)]
malloc: fix an over-allocation bug
Fix an instance where realloc code would overallocate by OVERHEAD bytes
amount. Manually arrange for reuse of memcpy-free-return exit sequence.
Rich Felker [Tue, 17 Apr 2018 00:12:12 +0000 (20:12 -0400)]
use explicit dynamic-list rather than symbolic-functions for linking
we have always bound symbols at libc.so link time rather than runtime
to minimize startup-time relocations and overhead of calls through the
PLT, and possibly also to preclude interposition that would not work
correctly anyway if allowed. historically, binding at link-time was
also necessary for the dynamic linker to work, but the dynamic linker
bootstrap overhaul in commit
f3ddd173806fd5c60b3f034528ca24542aecc5b9
made it unnecessary.
our use of -Bsymbolic-functions, rather than -Bsymbolic, was chosen
because the latter is incompatible with public global data; it makes
it incompatible with copy relocations in the main program. however,
not all global data needs to be public. by using --dynamic-list
instead with an explicit list, we can reduce the number of symbolic
relocations left for runtime.
this change will also allow us to permit interposition of specific
functions (e.g. the allocator) if/when we want to, by adding them to
the dynamic list.
Rich Felker [Mon, 16 Apr 2018 21:35:43 +0000 (17:35 -0400)]
fix return value of nice function
the Linux SYS_nice syscall is unusable because it does not return the
newly set priority. always use SYS_setpriority. also avoid overflows
in addition of inc by handling large inc values directly without
examining the old nice value.
Alexander Monakov [Sat, 16 Dec 2017 11:27:25 +0000 (14:27 +0300)]
optimize malloc0
Implementation of __malloc0 in malloc.c takes care to preserve zero
pages by overwriting only non-zero data. However, malloc must have
already modified auxiliary heap data just before and beyond the
allocated region, so we know that edge pages need not be preserved.
For allocations smaller than one page, pass them immediately to memset.
Otherwise, use memset to handle partial pages at the head and tail of
the allocation, and scan complete pages in the interior. Optimize the
scanning loop by processing 16 bytes per iteration and handling rest of
page via memset as soon as a non-zero byte is found.
Rich Felker [Wed, 11 Apr 2018 19:05:22 +0000 (15:05 -0400)]
fix incorrect results for catan with some inputs
the catan implementation from OpenBSD includes a FIXME-annotated
"overflow" branch that produces a meaningless and incorrect
large-magnitude result. it was reachable via three paths,
corresponding to gotos removed by this commit, in order:
1. pure imaginary argument with imaginary component greater than 1 in
magnitude. this case does not seem at all exceptional and is
handled (at least with the quality currently expected from our
complex math functions) by the existing non-exceptional code path.
2. arguments on the unit circle, including the pure-real argument 1.0.
these are not exceptional except for ±i, which should produce
results with infinite imaginary component and which lead to
computation of atan2(±0,0) in the existing non-exceptional code
path. such calls to atan2() however are well-defined by POSIX.
3. the specific argument +i. this route should be unreachable due to
the above (2), but subtle rounding effects might have made it
possible in rare cases. continuing on the non-exceptional code path
in this case would lead to computing the (real) log of an infinite
argument, then producing a NAN when multiplying it by I.
for now, remove the exceptional code paths entirely. replace the
multiplication by I with construction of a complex number using the
CMPLX macro so that the NAN issue (3) prevented cannot arise.
with these changes, catan should give reasonably correct results for
real arguments, and should no longer give completely-wrong results for
pure-imaginary arguments outside the interval (-i,+i).
Rich Felker [Mon, 9 Apr 2018 16:33:17 +0000 (12:33 -0400)]
fix wrong result in casin and many related complex functions
the factor of -i noted in the comment at the top of casin.c was
omitted from the actual code, yielding a result rotated 90 degrees and
propagating into errors in other functions defined in terms of casin.
implement multiplication by -i as a rotation of the real and imaginary
parts of the result, rather than by actual multiplication, since the
latter cannot be optimized without knowledge that the operand is
finite. here, the rotation is the actual intent, anyway.
Samuel Holland [Sat, 7 Apr 2018 14:47:16 +0000 (09:47 -0500)]
implement wcsftime padding specifier extensions
Commit
8a6bd7307da3fc4d08dd6a9277b611ccb4971354 added support for
padding specifier extensions to strftime, but did not modify wcsftime.
In the process, it added a parameter to __strftime_fmt_1 in strftime.c,
but failed to update the prototype in wcsftime.c. This was found by
compiling musl with LTO:
src/time/wcsftime.c:7:13: warning: type of '__strftime_fmt_1' does \
not match original declaration [-Wlto-type-mismatch]
Fix the prototype of __strftime_fmt_1 in wcsftime.c, and generate the
'pad' argument the same way as it is done in strftime.
Rich Felker [Thu, 5 Apr 2018 15:04:21 +0000 (11:04 -0400)]
prevent bypass of guarantee that suids start with fd 0/1/2 open
it was reported by Erik Bosman that poll fails without setting revents
when the nfds argument exceeds the current value for RLIMIT_NOFILE,
causing the subsequent open calls to be bypassed. if the rlimit is
either 1 or 2, this leaves fd 0 and 1 potentially closed but openable
when the application code is reached.
based on a brief reading of the poll syscall documentation and code,
it may be possible for poll to fail under other attacker-controlled
conditions as well. if it turns out these are reasonable conditions
that may happen in the real world, we may have to go back and
implement fallbacks to probe each fd individually if poll fails, but
for now, keep things simple and treat all poll failures as fatal.
Szabolcs Nagy [Sun, 1 Apr 2018 20:02:01 +0000 (20:02 +0000)]
fix fmaf wrong result
if double precision r=x*y+z is not a half way case between two single
precision floats or it is an exact result then fmaf returns (float)r.
however the exactness check was wrong when |x*y| < |z| and could cause
incorrectly rounded result in nearest rounding mode when r is a half
way case.
fmaf(-0x1.26524ep-54, -0x1.cb7868p+11, 0x1.d10f5ep-29)
was incorrectly rounded up to 0x1.d117ap-29 instead of 0x1.d1179ep-29.
(exact result is 0x1.d1179efffffffecp-29, r is 0x1.d1179fp-29)
Rich Felker [Wed, 28 Mar 2018 19:53:45 +0000 (15:53 -0400)]
fix default feature profile in tar.h
commit
d93c0740d86aaf7043e79b942a6c0b3f576af4c8 added use of feature
test macros without including features.h, causing a definition that
should be exposed in the default profile, TSVTX, to appear only when
_XOPEN_SOURCE or higher is explicitly defined.
Rich Felker [Sun, 25 Mar 2018 02:47:36 +0000 (22:47 -0400)]
adjust makefile target-specific CFLAGS rules to be more robust & complete
previously, MEMOPS_SRCS failed to include arch-specific replacement
files for memcpy, etc., omitting CFLAGS_MEMOPS and thereby potentially
causing build failure if an arch provided C (rather than asm)
replacements for these files.
instead of trying to explicitly include all the files that might have
arch replacements, which is prone to human error, extract final names
to be used out of $(LIBC_OBJS), where the rules for arch replacements
have already been applied. do the same for NOSSP_OBJS, using CRT_OBJS
and LDSO_OBJS rather than repeating ourselves with $(wildcard...) and
explicit pathnames again.
Rich Felker [Sat, 24 Mar 2018 16:15:43 +0000 (12:15 -0400)]
fix out-of-tree build of crt files with stack protector enabled
the makefile logic for these files was wrong in the out-of-tree case,
but it likely only affected the "all" level of stack protector.
Rich Felker [Sun, 11 Mar 2018 01:45:49 +0000 (20:45 -0500)]
explicitly use signed keyword to define intNN_t and derivative types
standing alone, both the signed and int keywords identify the same
type, a (signed) int. however the C language has an exception where,
when the lone keyword int is used to declare a bitfield, it's
implementation-defined whether the bitfield is signed or unsigned. C11
footnote 125 extends this implementation-definedness to typedefs, and
DR#315 extends it to other integer types (for which support with
bitfields is implementation-defined).
while reasonable ABIs (all the ones we support) define bitfields as
signed by default, GCC and compatible compilers offer an option
-funsigned-bitfields to change the default. while any signed types
defined without explicit use of the signed keyword are affected, the
stdint.h types, especially intNN_t, have a natural use in bitfields.
ensure that bitfields defined with these types always have the correct
signedness regardless of compiler & flags used.
see also GCC PR 83294.
Rich Felker [Sat, 10 Mar 2018 23:08:02 +0000 (18:08 -0500)]
fix minor namespace issues in termios.h
the output delay features (NL*, CR*, TAB*, BS*, and VT*) are
XSI-shaded. VT* is in the V* namespace reservation but the rest need
to be suppressed in base POSIX namespace.
unfortunately this change introduces feature test macro checks into
another bits header. at some point these checks should be simplified
by having features.h handle the "FTM X implies Y" relationships.
Rich Felker [Sat, 10 Mar 2018 23:03:17 +0000 (18:03 -0500)]
remove spurious const keyword in sigqueue declaration
this must have been taken from POSIX without realizing that it was
meaningless. the resolution to Austin Group issue #844 removed it from
the standard.
Rich Felker [Sat, 10 Mar 2018 23:02:05 +0000 (18:02 -0500)]
fix minor namespace issue in unistd.h
the F_* macros associated with the lockf function are XSI-shaded (like
the lockf function itself) and should only be exposed when the
function is.
Rich Felker [Sat, 10 Mar 2018 22:57:44 +0000 (17:57 -0500)]
fix minor namespace issue in tar.h
TSVTX is XSI-shaded.
Rich Felker [Sat, 10 Mar 2018 22:53:27 +0000 (17:53 -0500)]
fix minor namespace issues in limits.h
PAGE_SIZE, NZERO, and NL_LANGMAX are XSI-shaded.
Rich Felker [Sat, 10 Mar 2018 22:49:23 +0000 (17:49 -0500)]
use PAGESIZE rather than PAGE_SIZE in user.h bits
align with commit
c9c2cd3e6955cb1d57b8be01d4b072bf44058762.
Rich Felker [Sat, 10 Mar 2018 22:47:14 +0000 (17:47 -0500)]
reverse definition dependency between PAGESIZE and PAGE_SIZE
PAGESIZE is actually the version defined in POSIX base, with PAGE_SIZE
being in the XSI option. use PAGESIZE as the underlying definition to
facilitate making exposure of PAGE_SIZE conditional.
Rich Felker [Wed, 7 Mar 2018 16:22:38 +0000 (11:22 -0500)]
fix nl_langinfo_l(CODESET, loc) reporting wrong locale's value
use of MB_CUR_MAX encoded a hidden dependency on the currently active
locale for the calling thread, whereas nl_langinfo_l is supposed to
report for the locale passed as an argument.
Rich Felker [Mon, 26 Feb 2018 02:13:38 +0000 (21:13 -0500)]
add public interface headers to implementation files
general policy is that all source files defining a public API or an
ABI mechanism referenced by a public header should include the public
header that declares the interface, so that the compiler or analysis
tools can check the consistency of the declarations. Alexander Monakov
pointed out a number of violations of this principle a few years back.
fix them now.
Rich Felker [Sat, 24 Feb 2018 21:45:33 +0000 (16:45 -0500)]
fix aliasing violations in fgetpos/fsetpos
add a member of appropriate type to the fpos_t union so that accesses
are well-defined. use long long instead of off_t since off_t is not
always exposed in stdio.h and there's no namespace-clean alias for it.
access is still performed using pointer casts rather than by naming
the union member as a matter of style; to the extent possible, the
naming of fields in opaque types defined in the public headers is not
treated as an API contract with the implementation. access via the
pointer cast is valid as long as the union has a member of matching
type.
Rich Felker [Sat, 24 Feb 2018 17:33:06 +0000 (12:33 -0500)]
use idiomatic safe form for FUNLOCK macro
previously this macro used an odd if/else form instead of the more
idiomatic do/while(0), making it unsafe against omission of trailing
semicolon. the omission would make the following statement conditional
instead of producing an error.
Rich Felker [Sat, 24 Feb 2018 17:08:30 +0000 (12:08 -0500)]
in vswprintf, initialize the FILE rather than memset-and-assign
this is the idiom that's used elsewhere and should be more efficient
or at least no worse.
Rich Felker [Sat, 24 Feb 2018 16:38:53 +0000 (11:38 -0500)]
remove unused MIN macro from getdelim source file
Rich Felker [Sat, 24 Feb 2018 16:36:00 +0000 (11:36 -0500)]
remove useless null check before call to free in fclose
Rich Felker [Sat, 24 Feb 2018 16:33:18 +0000 (11:33 -0500)]
remove useless and confusing parentheses in stdio __towrite function
they seem to be relics of
e3cd6c5c265cd481db6e0c5b529855d99f0bda30
where this code was refactored from a check that previously masked
against (F_ERR|F_NOWR) instead of just F_NOWR.
Rich Felker [Sat, 24 Feb 2018 16:19:54 +0000 (11:19 -0500)]
avoid use of readv syscall in __stdio_read backend when not needed
formally, calling readv with a zero-length first iov component should
behave identically to calling read on just the second component, but
presence of a zero-length iov component has triggered bugs in some
kernels and performs significantly worse than a simple read on some
file types.
Rich Felker [Sat, 24 Feb 2018 15:51:16 +0000 (10:51 -0500)]
consistently return number of bytes read from stdio read backend
the stdio FILE read backend's return type is size_t, not ssize_t, and
all of the special (non-fd-backed) FILE types already return the
number of bytes read (zero) on error or eof. only __stdio_read leaked
a syscall error return into its return value.
fread had a workaround for this behavior going all the way back to the
original check-in. remove the workaround since it's no longer needed.
Rich Felker [Sat, 24 Feb 2018 15:43:13 +0000 (10:43 -0500)]
remove obfuscated flags bit-twiddling logic in __stdio_read
replace with simple conditional that doesn't rely on assumption that
cnt is either 0 or -1.
Rich Felker [Sat, 24 Feb 2018 15:26:26 +0000 (10:26 -0500)]
fix getopt wrongly treating colons in optstring as valid option chars
the ':' in optstring has special meaning as a flag applying to the
previous option character, or to getopt's error handling behavior when
it appears at the beginning. don't also accept a "-:" option based on
its presence.
Rich Felker [Fri, 23 Feb 2018 07:54:01 +0000 (02:54 -0500)]
add getentropy function
based loosely on patch by Hauke Mehrtens; converted to wrap the public
API of the underlying getrandom function rather than direct syscalls,
so that if/when a fallback implementation of getrandom is added it
will automatically get picked up by getentropy too.
Hauke Mehrtens [Sat, 6 Jan 2018 22:08:09 +0000 (23:08 +0100)]
add getrandom syscall wrapper
This syscall is available since Linux 3.17 and was also implemented in
glibc in version 2.25 using the same interfaces.
Szabolcs Nagy [Fri, 2 Feb 2018 20:58:20 +0000 (20:58 +0000)]
aarch64: add sve_context struct and related defines from linux v4.15
signal context definitions for scalable vector extension new in commit
d0b8cd3187889476144bd9b13bf36a932c3e7952
Szabolcs Nagy [Tue, 6 Feb 2018 22:33:38 +0000 (22:33 +0000)]
elf.h: add DT_SYMTAB_SHNDX
it's a recent addition to elf gabi:
http://sco.com/developers/gabi/latest/revision.html
based on discussions at
https://sourceware.org/bugzilla/show_bug.cgi?id=15835
Szabolcs Nagy [Fri, 2 Feb 2018 21:31:39 +0000 (21:31 +0000)]
elf.h: syncronize DF_1_ flags with binutils
DF_1_STUB and DF_1_PIE were added in binutils-gdb commit
5c383f026242d25a3c21fdfda42e5ca218b346c8
Szabolcs Nagy [Fri, 2 Feb 2018 21:22:38 +0000 (21:22 +0000)]
elf.h: update NT_* coredump elf notes for linux v4.15
NT_ARM_SVE and NT_S390_RI_CB are new in linux commits
43d4da2c45b2f5d62f8a79ff7c6f95089bb24656 and
262832bc5acda76fd8f901d39f4da1121d951222
the rest are older.
musl missed NT_PRFPREG because it followed the glibc api:
https://sourceware.org/bugzilla/show_bug.cgi?id=14890
Szabolcs Nagy [Fri, 2 Feb 2018 21:18:26 +0000 (21:18 +0000)]
elf.h: add PPC64_OPT_LOCALENTRY
allows calling extern functions without saving r2, for details see
glibc commit
0572433b5beb636de1a49ec6b4fdab830c38cdc5
Szabolcs Nagy [Fri, 2 Feb 2018 21:13:06 +0000 (21:13 +0000)]
elf.h: add AT_* auxval macros for cache geometry
AT_L1I_*, AT_L1D_*, AT_L2_* and AT_L3_* were added in linux v4.11 for
powerpc in commit
98a5f361b8625c6f4841d6ba013bbf0e80d08147.
Szabolcs Nagy [Fri, 2 Feb 2018 21:04:51 +0000 (21:04 +0000)]
sys/prctl.h: add new PR_SVE_* macros from linux v4.15
PR_SVE_SET_VL and PR_SVE_GET_VL controls are new in linux commit
2d2123bc7c7f843aa9db87720de159a049839862
related PR_SVE_* macros were added in
7582e22038a266444eb87bc07c372592ad647439
Szabolcs Nagy [Fri, 2 Feb 2018 20:46:45 +0000 (20:46 +0000)]
aarch64: update hwcap.h for linux v4.15
HWCAP_SVE is new in linux commit
43994d824e8443263dc98b151e6326bf677be52e
HWCAP_SHA3, HWCAP_SM3, HWCAP_SM4, HWCAP_ASIMDDP and HWCAP_SHA512 are new in
f5e035f8694c3bdddc66ea46ecda965ee6853718
Szabolcs Nagy [Fri, 2 Feb 2018 20:42:27 +0000 (20:42 +0000)]
arm: add get_tls syscall from linux v4.15
for systems without tp register or kuser helper, new in linux commit
8fcd6c45f5a65621ec809b7866a3623e9a01d4ed
Szabolcs Nagy [Fri, 2 Feb 2018 20:38:15 +0000 (20:38 +0000)]
powerpc: update hwcap.h for linux v4.15
PPC_FEATURE2_HTM_NO_SUSPEND is new in linux commit
cba6ac4869e45cc93ac5497024d1d49576e82666
PPC_FEATURE2_DARN and PPC_FEATURE2_SCV were new in v4.12 in commit
a4700a26107241cc7b9ac8528b2c6714ff99983d
Szabolcs Nagy [Fri, 2 Feb 2018 20:27:39 +0000 (20:27 +0000)]
s390x: add s390_sthyi system call from v4.15
to store hypervisor information, added in linux commit
3d8757b87d7fc15a87928bc970f060bc9c6dc618
Szabolcs Nagy [Fri, 2 Feb 2018 20:23:04 +0000 (20:23 +0000)]
netinet/in.h: add new IPV6_FREEBIND from linux v4.15
new socekt option for AF_INET6 SOL_RAW sockets, added in linux commit
84e14fe353de7624872e582887712079ba0b2d56
Szabolcs Nagy [Fri, 2 Feb 2018 20:19:46 +0000 (20:19 +0000)]
netinet/tcp.h: add TCP_* socket options from linux v4.15
TCP_FASTOPEN_KEY is new in
1fba70e5b6bed53496ba1f1f16127f5be01b5fb6
TCP_FASTOPEN_NO_COOKIE is new in
71c02379c762cb616c00fd5c4ed253fbf6bbe11b
Szabolcs Nagy [Fri, 2 Feb 2018 20:10:09 +0000 (20:10 +0000)]
add MAP_SYNC and MAP_SHARED_VALIDATE from linux v4.15
for synchronous page faults, new in linux commit
1c9725974074a047f6080eecc62c50a8e840d050 and
b6fb293f2497a9841d94f6b57bd2bb2cd222da43
note that only targets that use asm-generic/mman.h have this new
flag defined, so undef it on other targets (mips*, powerpc*).
Szabolcs Nagy [Mon, 27 Nov 2017 01:16:14 +0000 (01:16 +0000)]
mips,powerpc: fix TIOCSER_TEMT in termios.h
use the same token to define TIOCSER_TEMT as is used in ioctl.h
so when both headers are included there are no redefinition warnings
during musl build.
Szabolcs Nagy [Mon, 27 Nov 2017 00:22:01 +0000 (00:22 +0000)]
netinet/tcp.h: add tcp_diag_md5sig struct from linux v4.14
for querying tcp md5 signing keys.
new in linux commit
c03fa9bcacd9ac04595cc13f34f3445f0a5ecf13
Szabolcs Nagy [Sun, 26 Nov 2017 23:58:25 +0000 (23:58 +0000)]
sys/{mman,shm}.h: add {MAP,SHM}_HUGE_ macros from linux uapi
*_HUGE_SHIFT, *_HUGE_2MB, *_HUGE_1GB are documented in the man page,
so add all of the *_HUGE_* macros from linux uapi.
if MAP_HUGETLB is set, top bits of the mmap flags encode the page size.
see the linux commit
aafd4562dfee81a40ba21b5ea3cf5e06664bc7f6
if SHM_HUGETLB is set, top bits of the shmget flags encode the page size.
see the linux commit
4da243ac1cf6aeb30b7c555d56208982d66d6d33
*_HUGE_16GB is defined unsigned to avoid signed left shift ub.
Szabolcs Nagy [Sun, 26 Nov 2017 23:36:17 +0000 (23:36 +0000)]
netinet/if_ether.h: add new ETH_P_ macros from linux v4.14
new ethertypes in linux v4.14:
ETH_P_ERSPAN new in
84e54fe0a5eaed696dee4019c396f8396f5a908b
ETH_P_IFE new in
2804fd3af6ba5ae5737705b27146455eabe2e2f8
ETH_P_NSH new in
155e6f649757c902901e599c268f8b575ddac1f8
ETH_P_MAP new in
7373ae7e8f0bf2c0718422481da986db5058b005
Szabolcs Nagy [Sun, 26 Nov 2017 23:26:26 +0000 (23:26 +0000)]
net/if_arp.h: add ARPHRD_RAWIP from linux v4.14
new in linux commmit
cdf4969c42a6c1a376dd03a9e846cf638d3cd4b1
Szabolcs Nagy [Sun, 26 Nov 2017 23:20:38 +0000 (23:20 +0000)]
signal.h: add missing SIGTRAP si_codes
TRAP_BRANCH and TRAP_HWBKPT new in linux commit
da654b74bda14c45a7d98c731bf3c1a43b6b74e2
Szabolcs Nagy [Sun, 26 Nov 2017 23:05:45 +0000 (23:05 +0000)]
aarch64: add HWCAP_DCPOP from linux v4.14
indicates ARMv8.2-DCPoP persistent memory support extension.
new in linux commit
7aac405ebb3224037efd56b73d82d181111cdac3
Szabolcs Nagy [Sun, 26 Nov 2017 21:54:30 +0000 (21:54 +0000)]
sys/mman.h: add MADV_WIPEONFORK from linux v4.14
allows zeroing anonymous private pages inherited by a child process.
new in linux commit
d2cd9ede6e193dd7d88b6d27399e96229a551b19
Szabolcs Nagy [Sun, 26 Nov 2017 22:53:48 +0000 (22:53 +0000)]
sys/socket.h: add MSG_ZEROCOPY from linux v4.14
MSG_ZEROCOPY socket send flag avoids copy in the kernel
new in linux commit
52267790ef52d7513879238ca9fac22c1733e0e3
SO_ZEROCOPY socket option enables MSG_ZEROCOPY if availale
new in linux commit
76851d1212c11365362525e1e2c0a18c97478e6b
Szabolcs Nagy [Sun, 26 Nov 2017 22:34:31 +0000 (22:34 +0000)]
sys/socket.h: add SOL_TLS from linux v4.13
socket option for kernel TLS support
new in linux commit
3c4d7559159bfe1e3b94df3a657b2cda3a34e218
Szabolcs Nagy [Sun, 26 Nov 2017 22:21:31 +0000 (22:21 +0000)]
sys/socket.h: add PF_SMC from linux v4.11
add AF_SMC and PF_SMC for the IBM shared memory communication protocol.
new in linux commit
ac7138746e14137a451f8539614cdd349153e0c0
(linux socket.h is not in uapi so this update was missed earlier)
Rich Felker [Thu, 22 Feb 2018 18:39:19 +0000 (13:39 -0500)]
release 1.1.19
Rich Felker [Wed, 21 Feb 2018 19:19:01 +0000 (14:19 -0500)]
update authors/contributors list
these additions were made by scanning git log since the last major
update in commit
790580b2fc47bc20e613336cb937a120422a770c. in addition
to git-level commit authorship, "patch by" text in the commit message
was also scanned. this idiom was used in the past for patches that
underwent substantial edits when merging or where the author did not
provide a commit message. going forward, my intent is to use commit
authorship consistently for attribution.
as before my aim was adding everyone with either substantial code
contributions or a pattern of ongoing simple patch submission; any
omissions are unintentional.
Matúš Olekšák [Wed, 21 Feb 2018 17:03:04 +0000 (12:03 -0500)]
fix detection of LIBCC for compiler-rt with clang
Maintainer's note: at one point, -lcompiler_rt apparently worked, and
may still work and be preferable if one has manually installed the
library in a public lib directory. but with current versions of clang,
the full pathname to the library file is needed. the original patch
removed the -lcompiler_rt check; I have left it in place in case there
are users depending on it, and since, when it does work, it's
preferable so as not to code a dependency on the specific compiler
version and paths in config.mak.
Rich Felker [Wed, 21 Feb 2018 16:59:34 +0000 (11:59 -0500)]
convert execvp error handling to switch statement
this is more extensible if we need to consider additional errors, and
more efficient as long as the compiler does not know it can cache the
result of __errno_location (a surprisingly complex issue detailed in
commit
a603a75a72bb469c6be4963ed1b55fabe675fe15).
Przemyslaw Pawelczyk [Sun, 22 Oct 2017 22:07:42 +0000 (00:07 +0200)]
fix execvp failing on not-dir entries in PATH.
It's better to make execvp continue PATH search on ENOTDIR rather than
issuing an error. Bogus entries should not render rest of PATH invalid.
Maintainer's note: POSIX seems to require the search to continue like
this as part of XBD 8.3 Other Environment Variables. Only errors that
conclusively determine non-existence are candidates for continuing;
otherwise for consistency we have to report the error.
Rich Felker [Mon, 12 Feb 2018 01:48:14 +0000 (20:48 -0500)]
fix incorrect overflow check for allocation in fmemopen
when a null buffer pointer is passed to fmemopen, requesting it
allocate its own memory buffer, extremely large size arguments near
SIZE_MAX could overflow and result in underallocation. this results
from omission of the size of the cookie structure in the overflow
check but inclusion of it in the calloc call.
instead of accounting for individual small contributions to the total
allocation size needed, simply reject sizes larger than PTRDIFF_MAX,
which will necessarily fail anyway. then adding arbitrary fixed-size
structures is safe without matching up the expressions in the
comparison and the allocation.
Szabolcs Nagy [Sun, 17 Sep 2017 15:35:55 +0000 (15:35 +0000)]
better configure check for long double support
Dmitry V. Levin [Fri, 12 Jan 2018 15:12:24 +0000 (18:12 +0300)]
make getcwd fail if it cannot obtain an absolute path
Currently getcwd(3) can succeed without returning an absolute path
because the underlying getcwd syscall, starting with linux commit
v2.6.36-rc1~96^2~2, may succeed without returning an absolute path.
This is a conformance issue because "The getcwd() function shall
place an absolute pathname of the current working directory
in the array pointed to by buf, and return buf".
Fix this by checking the path returned by syscall and failing with
ENOENT if the path is not absolute. The error code is chosen for
consistency with the case when the current directory is unlinked.
Similar issue was fixed in glibc recently, see
https://sourceware.org/bugzilla/show_bug.cgi?id=22679
Rich Felker [Wed, 7 Feb 2018 19:31:42 +0000 (14:31 -0500)]
disallow non-absolute rpath $ORIGIN for suid/sgid/AT_SECURE processes
in theory non-absolute origins can only arise when either the main
program is invoked by running ldso as a command (inherently non-suid)
or when dlopen was called with a relative pathname containing at least
one slash. such usage would be inherently insecure in an suid program
anyway, so the old behavior here does not seem to have been insecure.
harden against it anyway.
Rich Felker [Wed, 7 Feb 2018 19:27:08 +0000 (14:27 -0500)]
honor rpath $ORIGIN for ldd/ldso command with program in working dir
the rpath fixup code assumed any module's name field would contain at
least one slash, an invariant which is usually met but not in the case
of a main executable loaded from the current working directory by
running ldd or ldso as a command. it would be possible to make this
invariant always hold, but it has a higher runtime allocation cost and
does not seem useful elsewhere, so just patch things up in fixup_rpath
instead.
Rich Felker [Tue, 6 Feb 2018 17:31:06 +0000 (12:31 -0500)]
adjust strftime + modifier to match apparent intent of POSIX
it's unclear from the specification whether the word "consumes" in
"consumes more than four bytes to represent a year" refers just to
significant places or includes leading zeros due to field width
padding. however the examples in the rationale indicate that the
latter was the intent. in particular, the year 270 is shown being
formatted by %+5Y as +0270 rather than 00270.
previously '+' prefixing was implemented just by comparing the year
against 10000. instead, count the number of significant digits and
padding bytes to be added, and use the total to determine whether to
apply the '+' prefix.
based on testing by Dennis Wölfing.
Rich Felker [Mon, 5 Feb 2018 18:36:04 +0000 (13:36 -0500)]
fix strftime field widths with %F format and zero year
the code to strip initial sign and leading zeros inadvertently
stripped all the zeros and the subsequent '-' separating the month.
instead, only strip sign characters from the very first position, and
only strip zeros when they are followed by another digit.
based on testing by Dennis Wölfing.
Rich Felker [Mon, 5 Feb 2018 16:45:52 +0000 (11:45 -0500)]
document pthread structure ABI constraints in comments
in the original submission of the patch that became commit
7c709f2d4f9872d1b445f760b0e68da89e256b9e, and in subsequent reading of
it by others, it was not clear that the new member had to be inserted
before canary_at_end, or that inserting it at that location was safe.
add comments to document.
Alexander Monakov [Mon, 5 Feb 2018 14:38:37 +0000 (17:38 +0300)]
re-fix child reaping in wordexp
Do not retry waitpid if the child was terminated by a signal. Do not
examine status: since we are not passing any flags, we will not receive
stop or continue notifications.
Rich Felker [Mon, 5 Feb 2018 16:31:11 +0000 (11:31 -0500)]
revert regression in faccessat AT_EACCESS robustness
commit
f9fb20b42da0e755d93de229a5a737d79a0e8f60 switched from using a
pipe for the result to conveying it via the child process exit status.
Alexander Monakov pointed out that the latter could fail if the
application is not expecting faccessat to produce a child and performs
a wait operation with __WCLONE or __WALL, and that it is not clear
whether it's guaranteed to work when SIGCHLD's disposition has been
set to SIG_IGN.
in addition, that commit introduced a bug that caused EACCES to be
produced instead of EBUSY due to an exit path that was overlooked when
the error channel was changed, and introduced a spurious retry loop
around the wait operation.
William Pitcock [Fri, 2 Feb 2018 20:08:55 +0000 (20:08 +0000)]
store pthread stack guard sizes for pthread_getattr_np
Rich Felker [Fri, 2 Feb 2018 17:15:43 +0000 (12:15 -0500)]
adjust dladdr dli_fbase definition to match other implementations
the Linux and FreeBSD man pages for dladdr document dli_fbase as the
"base address" of the library/module found. normally (e.g. AT_BASE)
the term "base" is used to denote the base address relative to which
p_vaddr addresses are interpreted; however in the case of dladdr's
Dl_info structure, existing implementations define it as the lowest
address of the mapping, which makes sense in the context of
determining which module's memory range the input address falls
within.
since this is a nonstandard interface provided to mimic one provided
by other implementations, adjust it to match their behavior.
Samuel Holland [Tue, 30 Jan 2018 02:36:42 +0000 (20:36 -0600)]
getopt_long: accept prefix match of long options containing equals signs
Consider the first equals sign found in the option to be the delimiter
between it and its argument, even if it matches an equals sign in the
option name. This avoids consuming the equals sign, which would prevent
finding the argument. Instead, it forces a partial match of the part of
the option name before the equals sign.
Maintainer's note: GNU getopt_long does not explicitly document this
behavior, but it can be seen as a consequence of how partial matches
are specified, and at least GNU (bfd) ld is known to make use of it.
Samuel Holland [Tue, 30 Jan 2018 02:36:41 +0000 (20:36 -0600)]
fix getopt_long arguments to partial matches
If we find a partial option name match, we need to keep looking for
ambiguous/conflicting options. However, we need to remember the position
in the candidate argument to find its option-argument later, if there is
one. This fixes e.g. option "foobar" being given as "--fooba=baz".
William Pitcock [Wed, 31 Jan 2018 23:29:24 +0000 (23:29 +0000)]
aarch64: fix mismatched type of ucontext_t uc_link member
Rostislav Skudnov [Fri, 12 Jan 2018 17:06:03 +0000 (17:06 +0000)]
add _DIRENT_HAVE_D_* macros to dirent.h
Rich Felker [Thu, 11 Jan 2018 01:45:02 +0000 (20:45 -0500)]
fix printf alt-form octal with value 0 and no explicit precision
commit
78897b0dc00b7cd5c29af5e0b7eebf2396d8dce0 wrongly simplified
Dmitry Levin's original submitted patch fixing alt-form octal with the
zero flag and field width present, omitting the special case where the
value is zero. as a result, printf("%#o",0) wrongly prints "00" rather
than "0".
the logic prior to this commit was actually better, in that it was
aligned with how the alt-form flag (#) for printf is specified ("it
shall increase the precision"). at the time there was no good way to
avoid the zero flag issue with the old logic, but commit
167dfe9672c116b315e72e57a55c7769f180dffa added tracking of whether an
explicit precision was provided.
revert commit
78897b0dc00b7cd5c29af5e0b7eebf2396d8dce0 and switch to
using the explicit precision indicator for suppressing the zero flag.
Jens Gustedt [Wed, 3 Jan 2018 13:17:12 +0000 (14:17 +0100)]
revise the definition of multiple basic locks in the code
In all cases this is just a change from two volatile int to one.
Jens Gustedt [Wed, 3 Jan 2018 13:17:12 +0000 (14:17 +0100)]
consistently use the LOCK an UNLOCK macros
In some places there has been a direct usage of the functions. Use the
macros consistently everywhere, such that it might be easier later on to
capture the fast path directly inside the macro and only have the call
overhead on the slow path.
Jens Gustedt [Wed, 3 Jan 2018 13:17:12 +0000 (14:17 +0100)]
new lock algorithm with state and congestion count in one atomic int
A variant of this new lock algorithm has been presented at SAC'16, see
https://hal.inria.fr/hal-
01304108. A full version of that paper is
available at https://hal.inria.fr/hal-
01236734.
The main motivation of this is to improve on the safety of the basic lock
implementation in musl. This is achieved by squeezing a lock flag and a
congestion count (= threads inside the critical section) into a single
int. Thereby an unlock operation does exactly one memory
transfer (a_fetch_add) and never touches the value again, but still
detects if a waiter has to be woken up.
This is a fix of a use-after-free bug in pthread_detach that had
temporarily been patched. Therefore this patch also reverts
c1e27367a9b26b9baac0f37a12349fc36567c8b6
This is also the only place where internal knowledge of the lock
algorithm is used.
The main price for the improved safety is a little bit larger code.
Under high congestion, the scheduling behavior will be different
compared to the previous algorithm. In that case, a successful
put-to-sleep may appear out of order compared to the arrival in the
critical section.
Hauke Mehrtens [Sat, 6 Jan 2018 22:32:52 +0000 (23:32 +0100)]
add additional uapi guards for Linux kernel header files
With Linux kernel 4.16 it will be possible to guard more parts of the
Linux header files from a libc. Make use of this in musl to guard all
the structures and other definitions from the Linux header files which
are also defined by the header files provided by musl. This will make
it possible to compile source files which include both the libc
headers and the kernel userspace headers.
This extends the definitions done in commit
04983f227238 ("make
netinet/in.h suppress clashing definitions from kernel headers")
Rich Felker [Tue, 19 Dec 2017 03:33:51 +0000 (22:33 -0500)]
fix iconv output of surrogate pairs in ucs2
in the unified code for handling utf-16 and ucs2 output, the check for
ucs2 wrongly looked at the source charset rather than the destination
charset.
Rich Felker [Tue, 19 Dec 2017 03:08:54 +0000 (22:08 -0500)]
add support for BOM-determined-endian UCS2, UTF-16, and UTF-32 to iconv
previously, the charset names without endianness specified were always
interpreted as big endian. unicode specifies that UTF-16 and UTF-32
have BOM-determined endianness if BOM is present, and are otherwise
big endian. since commit
5b546faa67544af395d6407553762b37e9711157
added support for stateful encodings, it is now possible to implement
BOM support via the conversion descriptor state.
for conversions to these charsets, the output is always big endian and
does not have a BOM.
Rich Felker [Tue, 19 Dec 2017 00:58:41 +0000 (19:58 -0500)]
add cp866 (dos cyrillic) to iconv
Rich Felker [Tue, 19 Dec 2017 00:33:56 +0000 (19:33 -0500)]
update case mappings to unicode 10.0
the mapping tables and code are not automatically generated; they were
produced by comparing the output of towupper/towlower against the
mappings in the UCD, ignoring characters that were previously excluded
from case mappings or from alphabetic status (micro sign and circled
letters), and adding table entries or code for everything else
missing.
based very loosely on a patch by Reini Urban.
Rich Felker [Mon, 18 Dec 2017 23:05:23 +0000 (18:05 -0500)]
update ctype tables to unicode 10.0
Rich Felker [Mon, 18 Dec 2017 23:01:42 +0000 (18:01 -0500)]
reformat ctype tables to be diff-friendly, match tool output
the new version of the code used to generate these tables forces a
newline every 256 entries, whereas at the time these files were
originally generated and committed, it only wrapped them at 80
columns. the new behavior ensures that localized changes to the
tables, if they are ever needed, will produce localized diffs.
commit
d060edf6c569ba9df4b52d6bcd93edde812869c9 made the corresponding
changes to the iconv tables.
Rich Felker [Fri, 15 Dec 2017 17:58:33 +0000 (12:58 -0500)]
fix endian errors in netinet/icmp6.h due to failure to include endian.h