OSDN Git Service

android-x86/system-bt.git
4 years agoMerge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc...
Ted Wang [Wed, 6 Nov 2019 18:21:20 +0000 (10:21 -0800)]
Merge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc-mr1-dev am: 82e29feb42 am: 0b3d1dd9a9
am: ea5f6b522e

Change-Id: Ib1374a76587575d7c34ea99e9c56ed900086dda0

4 years agoMerge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc...
Ted Wang [Wed, 6 Nov 2019 18:15:11 +0000 (10:15 -0800)]
Merge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc-mr1-dev am: 82e29feb42
am: 0b3d1dd9a9

Change-Id: I44d5112277d9f1c7e25c7872b79a8f8f03a3396e

4 years agoMerge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc...
Ted Wang [Wed, 6 Nov 2019 18:08:13 +0000 (10:08 -0800)]
Merge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc-mr1-dev
am: 82e29feb42

Change-Id: I6d685ffb735c1ff96224ec19d8eab569f4b2c2f2

4 years agoMerge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc...
TreeHugger Robot [Wed, 6 Nov 2019 17:48:42 +0000 (17:48 +0000)]
Merge "Fix potential OOB write in btm_read_remote_ext_features_complete" into oc-mr1-dev

4 years agoFix potential OOB write in btm_read_remote_ext_features_complete
Ted Wang [Fri, 4 Oct 2019 10:39:02 +0000 (18:39 +0800)]
Fix potential OOB write in btm_read_remote_ext_features_complete

Add event length check to avoid hci event sent from controller not
correct.
Add page number check to avoid page number is bigger than max page
number.

Bug: 141552859
Test: inject function
Merged-In: I3bd7349f382aa0e42123bbd835dcb60b77af099a
Change-Id: I3bd7349f382aa0e42123bbd835dcb60b77af099a

4 years ago[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad am: 2bcb84cd7d am:...
Nick Desaulniers [Wed, 16 Oct 2019 04:34:28 +0000 (21:34 -0700)]
[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad am: 2bcb84cd7d am: 6c6ffc3d18
am: 9e474d2ee6

Change-Id: I343bab88804aed8f0120f6719e78dc633ff96f35

4 years ago[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad am: 2bcb84cd7d
Nick Desaulniers [Wed, 16 Oct 2019 04:30:26 +0000 (21:30 -0700)]
[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad am: 2bcb84cd7d
am: 6c6ffc3d18

Change-Id: I7d24cb7afab04cd92c526417930884ec133a0c4c

4 years agoMerge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi...
Martin Brabham [Wed, 16 Oct 2019 04:29:28 +0000 (21:29 -0700)]
Merge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi-dev" into pi-dev am: 01c69ce222
am: fee0b616ea

Change-Id: I738b73e6a8b5fff974f286168bc8ec9523501411

4 years ago[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad
Nick Desaulniers [Wed, 16 Oct 2019 04:20:22 +0000 (21:20 -0700)]
[system][bt] fix -Wdangling-gsl am: 20ed45d633 am: 2f0c176bad
am: 2bcb84cd7d

Change-Id: I216e30fb5fb6ca5cadb7821d33825db4f197d087

4 years agoMerge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi...
Martin Brabham [Wed, 16 Oct 2019 04:20:22 +0000 (21:20 -0700)]
Merge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi-dev" into pi-dev
am: 01c69ce222

Change-Id: Ie358b950ce8488361da18d040d5e825eda79a795

4 years agoMerge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi...
Martin Brabham [Wed, 16 Oct 2019 03:10:24 +0000 (03:10 +0000)]
Merge "resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi-dev" into pi-dev

4 years ago[system][bt] fix -Wdangling-gsl am: 20ed45d633
Nick Desaulniers [Tue, 15 Oct 2019 21:31:31 +0000 (14:31 -0700)]
[system][bt] fix -Wdangling-gsl am: 20ed45d633
am: 2f0c176bad

Change-Id: I82b0d0a3b21111b8711d58609c3f70f4637bc74b

4 years ago[system][bt] fix -Wdangling-gsl
Nick Desaulniers [Tue, 15 Oct 2019 21:24:30 +0000 (14:24 -0700)]
[system][bt] fix -Wdangling-gsl
am: 20ed45d633

Change-Id: I9f59103dc40ae2154a2b2314d309ba0f7184376a

4 years ago[system][bt] fix -Wdangling-gsl
Nick Desaulniers [Thu, 10 Oct 2019 21:04:47 +0000 (14:04 -0700)]
[system][bt] fix -Wdangling-gsl

BtAddrString() returns a std::string. It's not safe to chain a call to
c_str() as otherwise the returned std::string is a temporary, and the
expression evaluates to an immediately dangling pointer.

Bug: 139945549
Bug: 142558228
Test: mm
Change-Id: I30972458abcc563b24ee0d80b289c3efd6c3e04d
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
4 years agoresolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi-dev
Martin Brabham [Wed, 2 Oct 2019 15:42:19 +0000 (08:42 -0700)]
resolve merge conflicts of 26513d4a93ed51c4b3e3c8608a28cbc41aba79ba to pi-dev

Test: I solemnly swear I tested this conflict resolution.
Bug: 110433804
Change-Id: I1ba3911607e587d13a69d2cfc4f8f905fe031141

4 years ago[automerger skipped] Merge "JustWorks: Auto-accept only incoming temporary pairing...
Martin Brabham [Thu, 3 Oct 2019 16:21:38 +0000 (09:21 -0700)]
[automerger skipped] Merge "JustWorks: Auto-accept only incoming temporary pairing." into pi-dev am: 6c603cedb5 -s ours
am: 9665fdd556 -s ours
am skip reason: change_id I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8 with SHA1 a73dfccf32 is in history

Change-Id: I949ed3c2d0eff4f3613eb5210307d55d75622f08

4 years ago[automerger skipped] Merge "JustWorks: Auto-accept only incoming temporary pairing...
Martin Brabham [Thu, 3 Oct 2019 16:14:38 +0000 (09:14 -0700)]
[automerger skipped] Merge "JustWorks: Auto-accept only incoming temporary pairing." into pi-dev
am: 6c603cedb5 -s ours
am skip reason: change_id I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8 with SHA1 a73dfccf32 is in history

Change-Id: I3becd255be392b7858a68302943deff735884477

4 years agoMerge "JustWorks: Auto-accept only incoming temporary pairing." into pi-dev
Martin Brabham [Thu, 3 Oct 2019 15:58:42 +0000 (15:58 +0000)]
Merge "JustWorks: Auto-accept only incoming temporary pairing." into pi-dev

4 years agoMerge "A2DP: Don't wait for role switch on a blacklisted device" into qt-r1-dev
Myles Watson [Thu, 3 Oct 2019 13:30:48 +0000 (13:30 +0000)]
Merge "A2DP: Don't wait for role switch on a blacklisted device" into qt-r1-dev

4 years agoFix read out of bounds in BtifAvEvent::DeepCopy am: 8ac773aa5b
Jakub Pawlowski [Thu, 3 Oct 2019 00:24:01 +0000 (17:24 -0700)]
Fix read out of bounds in BtifAvEvent::DeepCopy am: 8ac773aa5b
am: ea54f0f392

Change-Id: I6c2cd356b94f72d1718afc5764b74ebbffe00426

4 years agoFix read out of bounds in BtifAvEvent::DeepCopy
Jakub Pawlowski [Thu, 3 Oct 2019 00:16:01 +0000 (17:16 -0700)]
Fix read out of bounds in BtifAvEvent::DeepCopy
am: 8ac773aa5b

Change-Id: I7fdb4699d3aebaafe77e278786a8ddefbf0916f8

4 years agoJustWorks: Auto-accept only incoming temporary pairing.
Martin Brabham [Thu, 20 Jun 2019 15:59:24 +0000 (08:59 -0700)]
JustWorks: Auto-accept only incoming temporary pairing.

Bug: 110433804
Bug: 134461862
Test: Manual; atest net_test_bluetooth
Change-Id: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8
Merged-In: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8

4 years agoFix read out of bounds in BtifAvEvent::DeepCopy
Jakub Pawlowski [Wed, 2 Oct 2019 13:04:38 +0000 (15:04 +0200)]
Fix read out of bounds in BtifAvEvent::DeepCopy

Bug: 140768453
Change-Id: Ia05e12382ef78a3e07228d09bcf9347f9976bffd

4 years agoJustWorks: Auto-accept only incoming temporary pairing. am: 10e15ee461
Martin Brabham [Wed, 2 Oct 2019 01:13:16 +0000 (18:13 -0700)]
JustWorks: Auto-accept only incoming temporary pairing. am: 10e15ee461
am: 103ba67ee2

Change-Id: I89a7a2650b3c4814a28c13a287722485d0b6eba7

4 years ago[automerger skipped] Revert "DO NOT MERGE: btif: require pairing dialog for JustWorks...
Martin Brabham [Wed, 2 Oct 2019 01:07:51 +0000 (18:07 -0700)]
[automerger skipped] Revert "DO NOT MERGE: btif: require pairing dialog for JustWorks SSP" am: caff42bd3c -s ours
am: a3330ce66a

Change-Id: I8d329840d1b0c168b5876c6cd85cd28fee0b5f72

4 years agoJustWorks: Auto-accept only incoming temporary pairing.
Martin Brabham [Wed, 2 Oct 2019 01:07:33 +0000 (18:07 -0700)]
JustWorks: Auto-accept only incoming temporary pairing.
am: a73dfccf32

Change-Id: If2371493e1dc6d0ac4d3be413c847f1a0a115ccd

4 years agoJustWorks: Auto-accept only incoming temporary pairing.
Martin Brabham [Wed, 2 Oct 2019 01:06:15 +0000 (18:06 -0700)]
JustWorks: Auto-accept only incoming temporary pairing.
am: 10e15ee461

Change-Id: I392280bb44e2ab665baeab5ef5f1e6b9323fe463

4 years ago[automerger skipped] Revert "DO NOT MERGE: btif: require pairing dialog for JustWorks...
Martin Brabham [Wed, 2 Oct 2019 01:06:08 +0000 (18:06 -0700)]
[automerger skipped] Revert "DO NOT MERGE: btif: require pairing dialog for JustWorks SSP"
am: caff42bd3c -s ours
am skip reason: subject contains skip directive

Change-Id: I28ca9e4d3b1995295a392f58f1e973e2212968ac

4 years agoA2DP: Don't wait for role switch on a blacklisted device
Cheney Ni [Wed, 25 Sep 2019 13:33:25 +0000 (21:33 +0800)]
A2DP: Don't wait for role switch on a blacklisted device

When there are 2 or more ACL links, we will try to be the master for
better link quality, and setup flags to wait for the following role
switch results. Because this is an asynchronous task, we would check
flags for any further actions. However, there would not be other results
for role switch IOP, and could be just ignored.

Bug: 141177108
Test: Add headset to IOP and do A2DP playback manually
Change-Id: I0d9e92968765365410909908ffcaf6dc81161ea0
Merged-In: I0d9e92968765365410909908ffcaf6dc81161ea0
(cherry picked from commit f11548248484e27044e3fc2b634db89a61eede05)

4 years agoRevert "DO NOT MERGE: btif: require pairing dialog for JustWorks SSP"
Martin Brabham [Sat, 8 Jun 2019 04:58:52 +0000 (04:58 +0000)]
Revert "DO NOT MERGE: btif: require pairing dialog for JustWorks SSP"

This reverts commit 26ba26be830f04e6fd9c77b075bcae48677d4cce.

Reason for revert: breaks tv UX
Bug: 110433804
Change-Id: I2c644ed62619f34494be0a0c7c75078cec0ebdd3

4 years agoJustWorks: Auto-accept only incoming temporary pairing.
Martin Brabham [Thu, 20 Jun 2019 15:59:24 +0000 (08:59 -0700)]
JustWorks: Auto-accept only incoming temporary pairing.

Bug: 110433804
Bug: 134461862
Test: Manual; atest net_test_bluetooth
Change-Id: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8
Merged-In: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8

4 years agoJustWorks: Auto-accept only incoming temporary pairing.
Martin Brabham [Thu, 20 Jun 2019 15:59:24 +0000 (08:59 -0700)]
JustWorks: Auto-accept only incoming temporary pairing.

Bug: 110433804
Bug: 134461862
Test: Manual; atest net_test_bluetooth
Change-Id: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8
Merged-In: I4e3f39bc08e9d9493734a21ea29d76e43aeb50c8

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:23:59 +0000 (18:23 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev am: ca7cd4593a am: 92b5515436 -s ours am: 81e5d13abe -s ours am: ec4d990050 -s ours
am: 46737356e4 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 ecf8f751b0 is in history

Change-Id: Ibcb246f3dc79f1c3134528a61c405fa4b475e559

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:16:58 +0000 (18:16 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev am: ca7cd4593a am: 92b5515436 -s ours am: 81e5d13abe -s ours
am: ec4d990050 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 ecf8f751b0 is in history

Change-Id: I229bcea18a55e7c62cce886a13e6083ebe37dbc3

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:09:56 +0000 (18:09 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev am: ca7cd4593a am: 92b5515436 -s ours
am: 81e5d13abe -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 ecf8f751b0 is in history

Change-Id: Ia3d8616b3d0cbb86e9ddbe0f0154594a58f0914f

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:05:17 +0000 (18:05 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-mr1-dev am: 88452a2e0d -s ours am: cd2d913f94 -s ours
am: b50e15f579 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 50bf4cf1bf is in history

Change-Id: Id3a6bced31d944ea55c6d27baee754a8cb6917fa

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:04:54 +0000 (18:04 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into pi-dev am: 2e2864e169 -s ours
am: bab739ce60 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 50bf4cf1bf is in history

Change-Id: Ic1d664b57e5ef5eb6d3e4d0926dd7ccf3e8b620d

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:03:55 +0000 (18:03 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-mr1-dev am: 88452a2e0d -s ours
am: cd2d913f94 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 50bf4cf1bf is in history

Change-Id: Ic1f84b471d78143f521ca4cd13eec0bf7febca28

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 01:03:54 +0000 (18:03 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev am: ca7cd4593a
am: 92b5515436 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 ecf8f751b0 is in history

Change-Id: I9fdc5544ebca6f8849ae522890eb5774b5cc914f

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into oc-dev
Rahul Sabnis [Sat, 28 Sep 2019 00:57:56 +0000 (17:57 -0700)]
Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev
am: ca7cd4593a

Change-Id: I2b44586f43a2249034a286338c2ba68b78339cb7

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 00:57:54 +0000 (17:57 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into oc-mr1-dev
am: 88452a2e0d -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 969ebed816 is in history

Change-Id: Ib38f1eeb7bac5fcf5b48b4d72d92e5546389c7ed

4 years ago[automerger skipped] Merge "Use memcpy instead of casting to convert device_class...
Rahul Sabnis [Sat, 28 Sep 2019 00:57:54 +0000 (17:57 -0700)]
[automerger skipped] Merge "Use memcpy instead of casting to convert device_class to int" into pi-dev
am: 2e2864e169 -s ours
am skip reason: change_id Iee71ce35576e438317841d41a81fda6a87e1984a with SHA1 50bf4cf1bf is in history

Change-Id: Icbe38484058fc4d1f2af1445cb4c2c1ff6634627

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into oc-dev
TreeHugger Robot [Sat, 28 Sep 2019 00:40:38 +0000 (00:40 +0000)]
Merge "Use memcpy instead of casting to convert device_class to int" into oc-dev

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into oc-mr1-dev
TreeHugger Robot [Sat, 28 Sep 2019 00:40:01 +0000 (00:40 +0000)]
Merge "Use memcpy instead of casting to convert device_class to int" into oc-mr1-dev

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into pi-dev
TreeHugger Robot [Sat, 28 Sep 2019 00:37:34 +0000 (00:37 +0000)]
Merge "Use memcpy instead of casting to convert device_class to int" into pi-dev

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into qt-dev
Rahul Sabnis [Fri, 27 Sep 2019 22:47:57 +0000 (15:47 -0700)]
Merge "Use memcpy instead of casting to convert device_class to int" into qt-dev
am: 69ee68fd8b

Change-Id: I908e28c8a7797cdcf840654449f7d05a13e929e1

4 years agoMerge "Use memcpy instead of casting to convert device_class to int" into qt-dev
TreeHugger Robot [Fri, 27 Sep 2019 22:28:30 +0000 (22:28 +0000)]
Merge "Use memcpy instead of casting to convert device_class to int" into qt-dev

4 years agoSDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba am: 23bcf922...
Zongheng Wang [Fri, 27 Sep 2019 21:52:22 +0000 (14:52 -0700)]
SDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba am: 23bcf92253 am: 736669e4a5
am: 4a8fc7789e

Change-Id: Iee49e1f37dd060b3d9bc014dca272273082ec354

4 years agoSDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b am: ae973c77...
Zongheng Wang [Fri, 27 Sep 2019 21:51:58 +0000 (14:51 -0700)]
SDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b am: ae973c7782 am: 2dc8860396
am: 5d03b9c3fd

Change-Id: I3fa65a8d00c62896ee542f5ec22cac39e64e93e0

4 years agoSDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba am: 23bcf92253
Zongheng Wang [Fri, 27 Sep 2019 21:45:57 +0000 (14:45 -0700)]
SDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba am: 23bcf92253
am: 736669e4a5

Change-Id: If70ce170d5aefa143635218cbe0ae922fffc3a01

4 years agoSDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b am: ae973c7782
Zongheng Wang [Fri, 27 Sep 2019 21:45:29 +0000 (14:45 -0700)]
SDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b am: ae973c7782
am: 2dc8860396

Change-Id: I55a374d40550c8a42e61762606f3580e439c0725

4 years agoSDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba
Zongheng Wang [Fri, 27 Sep 2019 21:38:01 +0000 (14:38 -0700)]
SDP: Disconnect when there is a bad length am: 7f555a1a9b am: 325d1539ba
am: 23bcf92253

Change-Id: I8d078555cba1231252f8d9cbf9c9f911f91a8cb3

4 years agoSDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b
Zongheng Wang [Fri, 27 Sep 2019 21:37:33 +0000 (14:37 -0700)]
SDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a am: e6bda7c73b
am: ae973c7782

Change-Id: I7c4e10c31d265a7f7cef79a938078376d3a7c16d

4 years agoSDP: Disconnect when there is a bad length am: 7f555a1a9b
Zongheng Wang [Fri, 27 Sep 2019 21:31:23 +0000 (14:31 -0700)]
SDP: Disconnect when there is a bad length am: 7f555a1a9b
am: 325d1539ba

Change-Id: I21d1ab45bfe4f1e13a8e168abaafaafb1ccb1198

4 years agoSDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a
Zongheng Wang [Fri, 27 Sep 2019 21:30:53 +0000 (14:30 -0700)]
SDP: disconnect if sdp_copy_raw_data fails am: 41939a2b5a
am: e6bda7c73b

Change-Id: Ia3f4fe31ed2f8ea056a1dd0d3b07b8af6799dc19

4 years agoSDP: Disconnect when there is a bad length
Zongheng Wang [Fri, 27 Sep 2019 21:24:46 +0000 (14:24 -0700)]
SDP: Disconnect when there is a bad length
am: 7f555a1a9b

Change-Id: Ia4da75e08758cda98a79bdd1f37be2480e36c71d

4 years agoSDP: disconnect if sdp_copy_raw_data fails
Zongheng Wang [Fri, 27 Sep 2019 21:24:22 +0000 (14:24 -0700)]
SDP: disconnect if sdp_copy_raw_data fails
am: 41939a2b5a

Change-Id: Icf97e5e7008909461c92ec761c8ced647002754f

4 years agoSDP: Disconnect when there is a bad length
Zongheng Wang [Wed, 21 Aug 2019 00:56:04 +0000 (17:56 -0700)]
SDP: Disconnect when there is a bad length

Handle the case when SDP_RAW_DATA_INCLUDED is FALSE.
Related to: I9f0df8b2de28970e7d69b737ce5d363785183bf3

Bug: 137239831
Bug: 117105007
Test: manual test
Change-Id: I354494565005f2ca9093486546fc54c145066413
Merged-In: I354494565005f2ca9093486546fc54c145066413
(cherry picked from commit e45fe0a8ec678c73c57967b69c2fd485eef92927)

4 years agoFix potential OOB read in sdpu_get_len_from_type am: fa800d23fa am: 9f26f5c19b am...
Ted Wang [Fri, 20 Sep 2019 01:28:44 +0000 (18:28 -0700)]
Fix potential OOB read in sdpu_get_len_from_type am: fa800d23fa am: 9f26f5c19b am: e85a439780
am: d07c7f1412

Change-Id: I212560b012e42e4e5d9504bf7be704a11fc1bf96

4 years agoFix potential OOB read in sdpu_get_len_from_type am: fa800d23fa am: 9f26f5c19b
Ted Wang [Fri, 20 Sep 2019 01:22:41 +0000 (18:22 -0700)]
Fix potential OOB read in sdpu_get_len_from_type am: fa800d23fa am: 9f26f5c19b
am: e85a439780

Change-Id: Ic92fcfa82fd26d4797f64d968e08fe1270104384

4 years agoFix potential OOB read in sdpu_get_len_from_type am: fa800d23fa
Ted Wang [Fri, 20 Sep 2019 01:16:39 +0000 (18:16 -0700)]
Fix potential OOB read in sdpu_get_len_from_type am: fa800d23fa
am: 9f26f5c19b

Change-Id: I41a4a4710edba1b5c052338ed17ff18db058eb94

4 years agoFix potential OOB read in sdpu_get_len_from_type
Ted Wang [Fri, 20 Sep 2019 01:10:45 +0000 (18:10 -0700)]
Fix potential OOB read in sdpu_get_len_from_type
am: fa800d23fa

Change-Id: I06b19e7e195f7d0f80b8371b58a003809bd1f9c5

4 years agoFix potential OOB read in sdpu_get_len_from_type
Ted Wang [Mon, 29 Apr 2019 02:11:04 +0000 (10:11 +0800)]
Fix potential OOB read in sdpu_get_len_from_type

Add boundary check in sdpu_get_len_from_type to prevent potential OOB read.

(This commit was skipped from oc-dr1-dev down, so the Merged-In tag is
from a later CL to avoid a conflict)

Bug: 117105007
Test: Manul
Change-Id: I1bb50e840a977df1c0403f3cce2d73dd1a73aa62
Merged-In: I9f0df8b2de28970e7d69b737ce5d363785183bf3
(cherry picked from commit 1243f8da338dadfe2a3c281a08297b431402d41c)
(cherry picked from commit 4d8e1d63e1a2116c47702d38d858f5a742e8292f)

4 years ago[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr...
Myles Watson [Wed, 18 Sep 2019 19:09:24 +0000 (12:09 -0700)]
[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr am: 4291c84baa -s ours am: 2b28faafa0 -s ours am: a03b3585db -s ours
am: 44ec263e5c -s ours
am skip reason: change_id Ib642f79ed22b65ede5ff786cb1e163d172480f11 with SHA1 d4f012bc80 is in history

Change-Id: Icb2adee4a9d3b21908181dd5ad323ec415b0010f

4 years ago[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr...
Myles Watson [Wed, 18 Sep 2019 19:05:38 +0000 (12:05 -0700)]
[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr am: 4291c84baa -s ours am: 2b28faafa0 -s ours
am: a03b3585db -s ours
am skip reason: subject contains skip directive

Change-Id: I4544f77006664ae0bdef00369f01fea77ca02761

4 years ago[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr...
Myles Watson [Wed, 18 Sep 2019 18:56:34 +0000 (11:56 -0700)]
[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr am: 4291c84baa -s ours
am: 2b28faafa0 -s ours
am skip reason: subject contains skip directive

Change-Id: I78f9c36cbf4c97a252e06b4e2b1862799f93f48d

4 years ago[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr
Myles Watson [Wed, 18 Sep 2019 18:50:21 +0000 (11:50 -0700)]
[automerger skipped] DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr
am: 4291c84baa -s ours
am skip reason: change_id Ib642f79ed22b65ede5ff786cb1e163d172480f11 with SHA1 d4f012bc80 is in history

Change-Id: I73d7f92b5dc4ab723c721edbc53131e8be6c3d79

4 years agoDO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr
Myles Watson [Thu, 25 Oct 2018 00:05:12 +0000 (17:05 -0700)]
DO NOT MERGE: SDP: Check p_end in save_attr_seq and add_attr

(This CL is missed between oc-dev and oc-mr1-dev)

Bug: 115900043
Test: Sanity pairing and SDP PTS
Change-Id: Ib642f79ed22b65ede5ff786cb1e163d172480f11
Merged-In: Ib642f79ed22b65ede5ff786cb1e163d172480f11
(cherry picked from commit d4f012bc80bc68be1cab967958d4cf7e9c1ee442)

4 years agoUse memcpy instead of casting to convert device_class to int
Rahul Sabnis [Fri, 30 Aug 2019 01:23:37 +0000 (18:23 -0700)]
Use memcpy instead of casting to convert device_class to int

Bug: 140152619
Test: atest net_test_btcoreclear
Change-Id: Iee71ce35576e438317841d41a81fda6a87e1984a
Merged-In: Iee71ce35576e438317841d41a81fda6a87e1984a
(cherry picked from commit ec75f1efb6b9be4933225a4b724e7a3ef5e3d70b)

4 years agoUse memcpy instead of casting to convert device_class to int
Rahul Sabnis [Fri, 30 Aug 2019 01:23:37 +0000 (18:23 -0700)]
Use memcpy instead of casting to convert device_class to int

Bug: 140152619
Test: atest net_test_btcoreclear
Change-Id: Iee71ce35576e438317841d41a81fda6a87e1984a
Merged-In: Iee71ce35576e438317841d41a81fda6a87e1984a
(cherry picked from commit ec75f1efb6b9be4933225a4b724e7a3ef5e3d70b)

4 years agoUse memcpy instead of casting to convert device_class to int
Rahul Sabnis [Fri, 30 Aug 2019 01:23:37 +0000 (18:23 -0700)]
Use memcpy instead of casting to convert device_class to int

Bug: 140152619
Test: atest net_test_btcoreclear
Change-Id: Iee71ce35576e438317841d41a81fda6a87e1984a
Merged-In: Iee71ce35576e438317841d41a81fda6a87e1984a
(cherry picked from commit ec75f1efb6b9be4933225a4b724e7a3ef5e3d70b)

4 years agoUse memcpy instead of casting to convert device_class to int
Rahul Sabnis [Fri, 30 Aug 2019 01:23:37 +0000 (18:23 -0700)]
Use memcpy instead of casting to convert device_class to int

Bug: 140152619
Test: atest net_test_btcoreclear
Change-Id: Iee71ce35576e438317841d41a81fda6a87e1984a
Merged-In: Iee71ce35576e438317841d41a81fda6a87e1984a
(cherry picked from commit ec75f1efb6b9be4933225a4b724e7a3ef5e3d70b)

4 years agoSDP: disconnect if sdp_copy_raw_data fails
Zongheng Wang [Mon, 5 Aug 2019 19:45:35 +0000 (12:45 -0700)]
SDP: disconnect if sdp_copy_raw_data fails

Our partners met with the problem with sdp_copy_raw_data updated in
CVE-2019-2116. When peer device responds with a wrong size,
sdp_copy_raw_data will not complete and won't trigger
disconnection. This CL enables the disconnection when a wrong size is
received.

Bug: 137239831
Bug: 117105007
Test: manual test
Change-Id: I9f0df8b2de28970e7d69b737ce5d363785183bf3
Merged-In: I9f0df8b2de28970e7d69b737ce5d363785183bf3
(cherry picked from commit bc9df3451dad17c1ab1002fdbc85d60e57d4f0af)

4 years ago[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc3...
Ugo Yu [Wed, 11 Sep 2019 17:22:19 +0000 (10:22 -0700)]
[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev am: 9bc574c618 -s ours am: db61bc8978 -s ours am: 40ac062848 -s ours
am: ee56071b66 -s ours
am skip reason: change_id I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff with SHA1 a65f859b17 is in history

Change-Id: I3c511fd11e78acc9a8ba928ddd0d8a006d2aa20f

4 years ago[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc3...
Ugo Yu [Wed, 11 Sep 2019 17:15:16 +0000 (10:15 -0700)]
[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev am: 9bc574c618 -s ours am: db61bc8978 -s ours
am: 40ac062848 -s ours
am skip reason: change_id I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff with SHA1 a65f859b17 is in history

Change-Id: Ie70ddf9c2a82f51eaca9704974fd734b846553bb

4 years ago[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc3...
Ugo Yu [Wed, 11 Sep 2019 17:08:15 +0000 (10:08 -0700)]
[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev am: 9bc574c618 -s ours
am: db61bc8978 -s ours
am skip reason: change_id I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff with SHA1 a65f859b17 is in history

Change-Id: I2f3f74f49288ff10fbb570f94a5a6eac6b1d421e

4 years ago[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc3...
Ugo Yu [Wed, 11 Sep 2019 17:01:13 +0000 (10:01 -0700)]
[automerger skipped] resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev
am: 9bc574c618 -s ours
am skip reason: change_id I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff with SHA1 a65f859b17 is in history

Change-Id: Iffd5b655457623e328f3cce1a5894d8a611cd417

4 years agoresolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev
Ugo Yu [Wed, 11 Sep 2019 05:52:45 +0000 (13:52 +0800)]
resolve merge conflicts of 098e2972201b454de0f95a72636ecd9009dc32de to oc-dr1-dev

Bug: 79703832
Test: I solemnly swear I tested this conflict resolution.
Change-Id: Id582a274929f10d65e22d71f61de4b8953fed18e
Merged-In: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff

4 years ago[automerger skipped] Merge "Store BLE keys using the address from the ble_auth_cmpl_e...
Ugo Yu [Wed, 11 Sep 2019 03:29:44 +0000 (20:29 -0700)]
[automerger skipped] Merge "Store BLE keys using the address from the ble_auth_cmpl_evt" into qt-dev
am: a9b50ae838 -s ours
am skip reason: change_id I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff with SHA1 a65f859b17 is in history

Change-Id: I5b647f66f187e1bee38a89cb15ccd13eab6cfa7e

4 years agoMerge "Store BLE keys using the address from the ble_auth_cmpl_evt" into qt-dev
TreeHugger Robot [Wed, 11 Sep 2019 03:10:15 +0000 (03:10 +0000)]
Merge "Store BLE keys using the address from the ble_auth_cmpl_evt" into qt-dev

4 years ago[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_...
Ugo Yu [Wed, 11 Sep 2019 01:29:07 +0000 (18:29 -0700)]
[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt am: a65f859b17 -s ours am: 441b011410 -s ours
am: b1f32a5867

Change-Id: I4d4b8817a909fe33fd213029b19fd45ec0b37c80

4 years ago[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_...
Ugo Yu [Wed, 11 Sep 2019 01:24:34 +0000 (18:24 -0700)]
[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt am: a65f859b17 -s ours
am: 441b011410 -s ours
am skip reason: subject contains skip directive

Change-Id: I1854ec89e994337d44522ddbf9da2366991d17a4

4 years ago[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_...
Ugo Yu [Wed, 11 Sep 2019 01:19:07 +0000 (18:19 -0700)]
[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt am: b2334f0589 -s ours
am: 10a884f61f

Change-Id: I77eb3ddf1f8a06c4a88435660f82aab23e301738

4 years ago[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_...
Ugo Yu [Wed, 11 Sep 2019 01:08:13 +0000 (18:08 -0700)]
[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt
am: a65f859b17 -s ours
am skip reason: subject contains skip directive

Change-Id: I33793fde2925c0a87cb043238b22862cdd7d40b3

4 years ago[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_...
Ugo Yu [Wed, 11 Sep 2019 01:08:13 +0000 (18:08 -0700)]
[automerger skipped] DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt
am: b2334f0589 -s ours
am skip reason: subject contains skip directive

Change-Id: I86a56a7c0b4676005b8b39eb6c800f834b68ef41

4 years agoStore BLE keys using the address from the ble_auth_cmpl_evt
Ugo Yu [Thu, 11 Jul 2019 12:12:42 +0000 (20:12 +0800)]
Store BLE keys using the address from the ble_auth_cmpl_evt

Reading the peer address from btif_dm_ble_auth_cmpl_evt, instead
of using the value from the pairing control block in
btif_dm_save_ble_bonding_keys, ensures that BLE keys are stored with
the correct address.

Bug: 133234174
Bug: 79703832
Test: 1. Initiate crosskey pairing from BLE
      2. Check whether BLE keys are stored correctly
Change-Id: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff
Merged-In: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff

5 years agoStore BLE keys using the address from the ble_auth_cmpl_evt
Ugo Yu [Thu, 11 Jul 2019 12:12:42 +0000 (20:12 +0800)]
Store BLE keys using the address from the ble_auth_cmpl_evt

Reading the peer address from btif_dm_ble_auth_cmpl_evt, instead
of using the value from the pairing control block in
btif_dm_save_ble_bonding_keys, ensures that BLE keys are stored with
the correct address.

Bug: 133234174
Bug: 79703832
Test: 1. Initiate crosskey pairing from BLE
      2. Check whether BLE keys are stored correctly
Change-Id: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff

5 years agoDO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt
Ugo Yu [Thu, 11 Jul 2019 12:12:42 +0000 (20:12 +0800)]
DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt

Reading the peer address from btif_dm_ble_auth_cmpl_evt, instead
of using the value from the pairing control block in
btif_dm_save_ble_bonding_keys, ensures that BLE keys are stored with
the correct address.

Bug: 133234174
Bug: 79703832
Test: 1. Initiate crosskey pairing from BLE
      2. Check whether BLE keys are stored correctly
Change-Id: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff
Merged-In: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff
(cherry picked from commit 0d95651e8b22b1012f1ee103e4a0b8665a0c17d4)

5 years agoDO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt
Ugo Yu [Thu, 11 Jul 2019 12:12:42 +0000 (20:12 +0800)]
DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt

Reading the peer address from btif_dm_ble_auth_cmpl_evt, instead
of using the value from the pairing control block in
btif_dm_save_ble_bonding_keys, ensures that BLE keys are stored with
the correct address.

Bug: 133234174
Bug: 79703832
Test: 1. Initiate crosskey pairing from BLE
      2. Check whether BLE keys are stored correctly
Change-Id: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff
(cherry picked from commit 0d95651e8b22b1012f1ee103e4a0b8665a0c17d4)

5 years agoDO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt
Ugo Yu [Thu, 11 Jul 2019 12:12:42 +0000 (20:12 +0800)]
DO NOT MERGE Store BLE keys using the address from the ble_auth_cmpl_evt

Reading the peer address from btif_dm_ble_auth_cmpl_evt, instead
of using the value from the pairing control block in
btif_dm_save_ble_bonding_keys, ensures that BLE keys are stored with
the correct address.

Bug: 133234174
Bug: 79703832
Test: 1. Initiate crosskey pairing from BLE
      2. Check whether BLE keys are stored correctly
Change-Id: I18b4a1d8e2cdcd6dd4a300f1dc9e6d3892a3baff
(cherry picked from commit 0d95651e8b22b1012f1ee103e4a0b8665a0c17d4)

5 years agoSwitch Nintendo workaround to match by name
Andre Eisenbach [Wed, 10 Jul 2019 20:30:43 +0000 (13:30 -0700)]
Switch Nintendo workaround to match by name
am: c14c14fbc4

Change-Id: I89b558a9b3e87b58e15a8358fa66258fc03a882f

5 years agoMatch Nintento Pro Controller by name for interop
Andre Eisenbach [Wed, 10 Jul 2019 20:30:00 +0000 (13:30 -0700)]
Match Nintento Pro Controller by name for interop
am: b71ebf2d82

Change-Id: I683d6dabefeeed51e1a1e9919d3c1b1d28a47647

5 years agoHearing Aid: set BLE phy to 2M if local and peer indicate PHY 2M support
weichinweng [Wed, 3 Jul 2019 09:52:19 +0000 (17:52 +0800)]
Hearing Aid: set BLE phy to 2M if local and peer indicate PHY 2M support

Set the BLE phy to 2M if the BT controller and peer Hearing Aid device
indicate phy 2M support, otherwise, use default phy channel.

Bug: 135769508
Test: 1.Forget/Repair Hearing Aid device check whether phy is expected.
2.Disconnect/Reconnect Hearing Aid device check whether phy is expected.
3.HearingAid device power off/on, check whether phy is expected.

Change-Id: Ib410a8885f3a68c361bb97d5c9a3833f2a1be528
Merged-In: Ib410a8885f3a68c361bb97d5c9a3833f2a1be528
(cherry picked from commit 554c3598db5661ac0166eb12006d248a38723db1)

5 years agoSwitch Nintendo workaround to match by name
Andre Eisenbach [Mon, 8 Jul 2019 21:49:06 +0000 (14:49 -0700)]
Switch Nintendo workaround to match by name

Bug: 136478524
Test: manual
Change-Id: Ib60cd5adfc4db3ba93fe5ed8c15353225b6cf165

5 years agoMatch Nintento Pro Controller by name for interop
Andre Eisenbach [Mon, 1 Jul 2019 17:48:10 +0000 (10:48 -0700)]
Match Nintento Pro Controller by name for interop

The Nintento Pro Controller uses an unknown number of
BDA ranges (at least 3 found internally). Switching
to name matching...

Bug: 136478524
Test: manual
Change-Id: Ie2dfb700c9550af0c314759ec496a04a8e1aa062

5 years agoRootCanal: Set the timer period to 1 second
Myles Watson [Wed, 3 Jul 2019 23:08:24 +0000 (16:08 -0700)]
RootCanal: Set the timer period to 1 second
am: eb9a775086

Change-Id: Iaf7e4e6bab48fd9f882c2d0e0c53b1cd71e7ff65

5 years agoRootCanal: Set the timer period to 1 second
Myles Watson [Mon, 1 Jul 2019 22:22:26 +0000 (15:22 -0700)]
RootCanal: Set the timer period to 1 second

Reduce the CPU overhead of simulating the Bluetooth chip.

Bug: 136503363
Test: enable Bluetooth with RootCanal
Change-Id: I3a783a4d8a46d4eef43ddbace23c672ef9f6d7f9
Merged-In: I609f917061e5d83e011edfeb61de281ff45b13e4

5 years agoMerge "RootCanal: Make beacons less verbose" into qt-dev
Myles Watson [Mon, 1 Jul 2019 22:31:26 +0000 (15:31 -0700)]
Merge "RootCanal: Make beacons less verbose" into qt-dev
am: 155a2373f3

Change-Id: I45556790bd687e82aa2bd2effc084a5aab1160e0

5 years agoMerge "RootCanal: Make beacons less verbose" into qt-dev
TreeHugger Robot [Mon, 1 Jul 2019 22:11:59 +0000 (22:11 +0000)]
Merge "RootCanal: Make beacons less verbose" into qt-dev

5 years agoRootCanal: Make beacons less verbose
Myles Watson [Wed, 26 Jun 2019 17:27:19 +0000 (10:27 -0700)]
RootCanal: Make beacons less verbose

Fixes: 136287879
Test: scan for Bluetooth devices, watch logcat
Change-Id: I971a7e56359adc39d006a1b10b5333c2f31ebaff
(cherry picked from commit 0d5adc6fac590dc14f46790b3962c40712303aea)