OSDN Git Service

pg-rex/syncrep.git
16 years agoReduce memory requirements for writing CSVlogs, so it will work with about
Andrew Dunstan [Thu, 23 Aug 2007 01:24:43 +0000 (01:24 +0000)]
Reduce memory requirements for writing CSVlogs, so it will work with about
the same amount of memory in ErrorContext as standard logs.

16 years agounbreak ECPG tests for VPATH builds.
Andrew Dunstan [Thu, 23 Aug 2007 00:38:17 +0000 (00:38 +0000)]
unbreak ECPG tests for VPATH builds.

16 years agoFix typo in FAQ_DEV.
Bruce Momjian [Thu, 23 Aug 2007 00:10:07 +0000 (00:10 +0000)]
Fix typo in FAQ_DEV.

16 years agoAdd book to FAQ_DEV:
Bruce Momjian [Thu, 23 Aug 2007 00:09:34 +0000 (00:09 +0000)]
Add book to FAQ_DEV:

Transactional Information Systems by Gerhard Weikum, Kaufmann

16 years agoFix possible core dump from pgbench -d option. Julius Stroffek
Tom Lane [Wed, 22 Aug 2007 23:03:27 +0000 (23:03 +0000)]
Fix possible core dump from pgbench -d option.  Julius Stroffek

16 years agoSuppress testing the options of CREATE TEXT SEARCH DICTIONARY during
Tom Lane [Wed, 22 Aug 2007 22:30:20 +0000 (22:30 +0000)]
Suppress testing the options of CREATE TEXT SEARCH DICTIONARY during
initdb.  We should create all the standard dictionaries even though
some of them may not work in template1's encoding.  Per Teodor.

16 years agoMore cleaning up and removed some duplicates.
Michael Meskes [Wed, 22 Aug 2007 08:20:58 +0000 (08:20 +0000)]
More cleaning up and removed some duplicates.

16 years agoPropagate Magnus' fix for Windows snowball build into Makefile.cygwin.
Tom Lane [Wed, 22 Aug 2007 06:34:18 +0000 (06:34 +0000)]
Propagate Magnus' fix for Windows snowball build into Makefile.cygwin.

16 years agoFix cut-n-paste-o.
Tom Lane [Wed, 22 Aug 2007 06:26:32 +0000 (06:26 +0000)]
Fix cut-n-paste-o.

16 years agoFix VPATH-build problem in new tsearch makefile, per Chad Wagner.
Tom Lane [Wed, 22 Aug 2007 06:11:56 +0000 (06:11 +0000)]
Fix VPATH-build problem in new tsearch makefile, per Chad Wagner.

16 years agoRemove option to change parser of an existing text search configuration.
Tom Lane [Wed, 22 Aug 2007 05:13:50 +0000 (05:13 +0000)]
Remove option to change parser of an existing text search configuration.
This prevents needing to do complex and poorly-defined updates of the
mapping table if the new parser has different token types than the old.
Per discussion.

16 years agoText search doc updates --- first cut at
Tom Lane [Wed, 22 Aug 2007 04:45:20 +0000 (04:45 +0000)]
Text search doc updates --- first cut at
syncing the existing docs with the final syntax decisions.

16 years agoWhoops, missed updating dsynonym_init for new dictionary parameter method.
Tom Lane [Wed, 22 Aug 2007 04:13:15 +0000 (04:13 +0000)]
Whoops, missed updating dsynonym_init for new dictionary parameter method.

16 years agoMake \dFt and \dFt+ do something different --- omitting the function
Tom Lane [Wed, 22 Aug 2007 02:25:34 +0000 (02:25 +0000)]
Make \dFt and \dFt+ do something different --- omitting the function
names in the former case seems more consistent with the behavior of
other \dF commands.

16 years agoSimplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by treating the
Tom Lane [Wed, 22 Aug 2007 01:39:46 +0000 (01:39 +0000)]
Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by treating the
init options of the template as top-level options in the syntax.  This also
makes ALTER a bit easier to use, since options can be replaced individually.
I also made these statements verify that the tmplinit method will accept
the new settings before they get stored; in the original coding you didn't
find out about mistakes until the dictionary got invoked.

Under the hood, init methods now get options as a List of DefElem instead
of a raw text string --- that lets tsearch use existing options-pushing code
instead of duplicating functionality.

16 years agoSimplify CREATE TEXT SEARCH CONFIGURATION by eliminating the separate
Tom Lane [Tue, 21 Aug 2007 21:24:00 +0000 (21:24 +0000)]
Simplify CREATE TEXT SEARCH CONFIGURATION by eliminating the separate
'with map' parameter; as things now stand there's really not much point
in specifying a config-to-copy if you don't copy its map.  Also, use
COPY instead of TEMPLATE as the key word for a config-to-copy, so as
to avoid confusion with text search templates.  Per discussion; the
just-committed reference page for the command already describes it
this way.

16 years agoFirst rough cut at text search documentation: bare bones reference
Tom Lane [Tue, 21 Aug 2007 21:08:47 +0000 (21:08 +0000)]
First rough cut at text search documentation: bare bones reference
pages for the new SQL commands.  I also committed Bruce's text search
introductory chapter, as-is except for fixing some markup errors,
so that there would be a place for the reference pages to link to.

16 years agoExclude snowball/libstemmer/ files from the set processed by pgindent.
Tom Lane [Tue, 21 Aug 2007 16:08:23 +0000 (16:08 +0000)]
Exclude snowball/libstemmer/ files from the set processed by pgindent.
There's not much point in prettifying machine-generated code, and it
seems best to keep these files exactly like upstream anyway.  Also add
some notes about why various files are excluded.

16 years agoUppercase keywords in regression tsearch test scripts.
Bruce Momjian [Tue, 21 Aug 2007 15:41:13 +0000 (15:41 +0000)]
Uppercase keywords in regression tsearch test scripts.

16 years agoAvoid using TEXT as a Bison symbol, since this provokes warnings on
Tom Lane [Tue, 21 Aug 2007 15:13:42 +0000 (15:13 +0000)]
Avoid using TEXT as a Bison symbol, since this provokes warnings on
Windows builds.  In passing, fix an obsolete comment, per gripe from
Greg Stark.

16 years agoRemove tabs from SGML files.
Bruce Momjian [Tue, 21 Aug 2007 15:13:16 +0000 (15:13 +0000)]
Remove tabs from SGML files.

16 years agoBuild snowball DLL for tsearch-in-core.
Magnus Hagander [Tue, 21 Aug 2007 15:10:41 +0000 (15:10 +0000)]
Build snowball DLL for tsearch-in-core.
(Still needs to build the .sql output files, but this handles the C part
of the build)

16 years agoDon't define BUILDING_DLL for snowball lib. Should fix build problems
Magnus Hagander [Tue, 21 Aug 2007 13:32:33 +0000 (13:32 +0000)]
Don't define BUILDING_DLL for snowball lib. Should fix build problems
on mingw and probably cygwin.

16 years agoRemove extraneous semicolon --- buildfarm member bear, for one,
Tom Lane [Tue, 21 Aug 2007 06:34:42 +0000 (06:34 +0000)]
Remove extraneous semicolon --- buildfarm member bear, for one,
objects to it.

16 years agoFix cash_mul_int4 and cash_div_int4 for overenthusiastic substitution
Tom Lane [Tue, 21 Aug 2007 03:56:07 +0000 (03:56 +0000)]
Fix cash_mul_int4 and cash_div_int4 for overenthusiastic substitution
of int64 for int32.  Per reports from Merlin Moncure and Andrew Chernow.

16 years agoFix money type's send/receive functions to conform to recent widening
Tom Lane [Tue, 21 Aug 2007 03:14:36 +0000 (03:14 +0000)]
Fix money type's send/receive functions to conform to recent widening
of the datatype to int64.  Per Andrew Chernow.

16 years agoFix potential access-off-the-end-of-memory in varbit_out(): it fetched the
Tom Lane [Tue, 21 Aug 2007 02:40:06 +0000 (02:40 +0000)]
Fix potential access-off-the-end-of-memory in varbit_out(): it fetched the
byte after the last full byte of the bit array, regardless of whether that
byte was part of the valid data or not.  Found by buildfarm testing.
Thanks to Stefan Kaltenbrunner for nailing down the cause.

16 years agoSuppress uninitialized-variable warning.
Tom Lane [Tue, 21 Aug 2007 01:47:19 +0000 (01:47 +0000)]
Suppress uninitialized-variable warning.

16 years agoFix a small 64-bit problem in tsearch patch.
Tom Lane [Tue, 21 Aug 2007 01:45:33 +0000 (01:45 +0000)]
Fix a small 64-bit problem in tsearch patch.

16 years agocontrib/tsearch2 now fails its regression test because of conflicts with
Tom Lane [Tue, 21 Aug 2007 01:12:28 +0000 (01:12 +0000)]
contrib/tsearch2 now fails its regression test because of conflicts with
the core additions.  For the moment I diked it out of contrib/Makefile.
We should look at turning it into a backward-compatibility package.

16 years agoTsearch2 functionality migrates to core. The bulk of this work is by
Tom Lane [Tue, 21 Aug 2007 01:11:32 +0000 (01:11 +0000)]
Tsearch2 functionality migrates to core.  The bulk of this work is by
Oleg Bartunov and Teodor Sigaev, but I did a lot of editorializing,
so anything that's broken is probably my fault.

Documentation is nonexistent as yet, but let's land the patch so we can
get some portability testing done.

16 years agoAdd configure option --with-system-tzdata to use operating system time zone
Peter Eisentraut [Mon, 20 Aug 2007 08:53:12 +0000 (08:53 +0000)]
Add configure option --with-system-tzdata to use operating system time zone
database.

16 years agominor typo fixes in CSVlog docs, per Michael Glaesemann
Andrew Dunstan [Sun, 19 Aug 2007 03:23:30 +0000 (03:23 +0000)]
minor typo fixes in CSVlog docs, per Michael Glaesemann

16 years agoDone:
Bruce Momjian [Sun, 19 Aug 2007 02:36:08 +0000 (02:36 +0000)]
Done:

< * Allow server log information to be output as INSERT statements
> * -Allow server log information to be output as CSV format

16 years agoProvide for logfiles in machine readable CSV format. In consequence, rename
Andrew Dunstan [Sun, 19 Aug 2007 01:41:25 +0000 (01:41 +0000)]
Provide for logfiles in machine readable CSV format. In consequence, rename
redirect_stderr to logging_collector.
Original patch from Arul Shaji, subsequently modified by Greg Smith, and then
heavily modified by me.

16 years agoAdd:
Bruce Momjian [Thu, 16 Aug 2007 19:02:15 +0000 (19:02 +0000)]
Add:

>
> * Reduce XID consumption of read-only queries
>
>    http://archives.postgresql.org/pgsql-hackers/2007-08/msg00516.php
>

16 years agoArrange to cache a ResultRelInfo in the executor's EState for relations that
Tom Lane [Wed, 15 Aug 2007 21:39:50 +0000 (21:39 +0000)]
Arrange to cache a ResultRelInfo in the executor's EState for relations that
are not one of the query's defined result relations, but nonetheless have
triggers fired against them while the query is active.  This was formerly
impossible but can now occur because of my recent patch to fix the firing
order for RI triggers.  Caching a ResultRelInfo avoids duplicating work by
repeatedly opening and closing the same relation, and also allows EXPLAIN
ANALYZE to "see" and report on these extra triggers.  Use the same mechanism
to cache open relations when firing deferred triggers at transaction shutdown;
this replaces the former one-element-cache strategy used in that case, and
should improve performance a bit when there are deferred triggers on a number
of relations.

16 years agoRepair problems occurring when multiple RI updates have to be done to the same
Tom Lane [Wed, 15 Aug 2007 19:15:47 +0000 (19:15 +0000)]
Repair problems occurring when multiple RI updates have to be done to the same
row within one query: we were firing check triggers before all the updates
were done, leading to bogus failures.  Fix by making the triggers queued by
an RI update go at the end of the outer query's trigger event list, thereby
effectively making the processing "breadth-first".  This was indeed how it
worked pre-8.0, so the bug does not occur in the 7.x branches.
Per report from Pavel Stehule.

16 years agoAdd third idea about pulling data from indexes.
Bruce Momjian [Wed, 15 Aug 2007 15:53:30 +0000 (15:53 +0000)]
Add third idea about pulling data from indexes.

>   A third idea would be for a heap scan to check if all rows are visible
>   and if so set a per-table flag which can be checked by index scans.
>   Any change to the table would have to clear the flag.  To detect
>   changes during the heap scan a counter could be set at the start and
>   checked at the end --- if it is the same, the table has not been
>   modified --- any table change would increment the counter.

16 years agoFix whitespace in TODO.
Bruce Momjian [Wed, 15 Aug 2007 15:36:31 +0000 (15:36 +0000)]
Fix whitespace in TODO.

16 years agoFix oversight in async-commit patch: there were some places in heapam.c
Tom Lane [Tue, 14 Aug 2007 17:35:18 +0000 (17:35 +0000)]
Fix oversight in async-commit patch: there were some places in heapam.c
that still thought they could set HEAP_XMAX_COMMITTED immediately after
seeing the other transaction commit.  Make them use the same logic as
tqual.c does to determine if the hint bit can be set yet.

16 years agoDone for ecpg:
Bruce Momjian [Tue, 14 Aug 2007 17:02:42 +0000 (17:02 +0000)]
Done for ecpg:

<  o Use backend PREPARE/EXECUTE facility for ecpg where possible

16 years agoIt seems we simply expected the same output for failure and success.
Michael Meskes [Tue, 14 Aug 2007 11:21:38 +0000 (11:21 +0000)]
It seems we simply expected the same output for failure and success.

16 years agoIt seems I always forget .in files.
Michael Meskes [Tue, 14 Aug 2007 10:56:20 +0000 (10:56 +0000)]
It seems I always forget .in files.

16 years agoHopefully fixed missing CHAR_BIT symbol
Michael Meskes [Tue, 14 Aug 2007 10:54:57 +0000 (10:54 +0000)]
Hopefully fixed missing CHAR_BIT symbol

16 years agoFixed compiler warning for enum handling
Michael Meskes [Tue, 14 Aug 2007 10:32:47 +0000 (10:32 +0000)]
Fixed compiler warning for enum handling

16 years agoAs usual I forgot some files. :-)
Michael Meskes [Tue, 14 Aug 2007 10:19:14 +0000 (10:19 +0000)]
As usual I forgot some files. :-)

16 years ago- Finished major rewrite to use new protocol version
Michael Meskes [Tue, 14 Aug 2007 10:01:54 +0000 (10:01 +0000)]
- Finished major rewrite to use new protocol version
- Really prepare statements
- Added more regression tests
- Added auto-prepare mode
- Use '$n' for positional variables, '?' is still possible via ecpg option
- Cleaned up the sources a little bit

16 years agoTEMPORARILY make synchronous_commit default to OFF, so that we can get more
Tom Lane [Mon, 13 Aug 2007 19:27:12 +0000 (19:27 +0000)]
TEMPORARILY make synchronous_commit default to OFF, so that we can get more
thorough testing of async-commit mode from the buildfarm.  This patch MUST
get reverted before 8.3 release!

16 years agoFix two bugs induced in VACUUM FULL by async-commit patch.
Tom Lane [Mon, 13 Aug 2007 19:08:26 +0000 (19:08 +0000)]
Fix two bugs induced in VACUUM FULL by async-commit patch.

First, we cannot assume that XLogAsyncCommitFlush guarantees hint bits will be
settable, because clog.c's inexact LSN bookkeeping results in windows where a
previously flushed transaction is considered unhintable because it shares an
LSN slot with a later unflushed transaction.  But repair_frag requires
XMIN_COMMITTED to be correct so that it can distinguish tuples moved by the
current vacuum.  Since not being able to set the bit is an uncommon corner
case, the most practical way of dealing with it seems to be to abandon
shrinking (ie, don't invoke repair_frag) when we find a non-dead tuple whose
XMIN_COMMITTED bit couldn't be set.

Second, it is possible for the same reason that a RECENTLY_DEAD tuple does not
get its XMAX_COMMITTED bit set during scan_heap.  But by the time repair_frag
examines the tuple it might be possible to set the bit.  We therefore must
take buffer content lock when calling HeapTupleSatisfiesVacuum a second time,
else we can get an Assert failure in SetBufferCommitInfoNeedsSave.  This
latter bug is latent in existing releases, but I think it cannot actually
occur without async commit, since the first HeapTupleSatisfiesVacuum call
should always have set the bit.  So I'm not going to back-patch it.

In passing, reduce the existing "cannot shrink relation" messages from NOTICE
to LOG level.  The new message must be no higher than LOG if we don't want
unpredictable regression test failures, and consistency seems like a good
idea.  Also arrange that only one such message is reported per VACUUM FULL;
in typical scenarios you could get spammed with many such messages, which
seems a bit useless.

16 years agoDocument that the regexp split functions ignore zero-length matches in
Tom Lane [Mon, 13 Aug 2007 01:18:47 +0000 (01:18 +0000)]
Document that the regexp split functions ignore zero-length matches in
certain corner cases.  Per discussion, the code does what we want, but
it really needs to be documented that these functions act differently
from regexp_matches.

16 years agoRemove an "optimization" I installed in 2001, to make repalloc() attempt to
Tom Lane [Sun, 12 Aug 2007 20:39:14 +0000 (20:39 +0000)]
Remove an "optimization" I installed in 2001, to make repalloc() attempt to
enlarge the memory chunk in-place when it was feasible to do so.  This turns
out to not work well at all for scenarios involving repeated cycles of
palloc/repalloc/pfree: the eventually freed chunks go into the wrong freelist
for the next initial palloc request, and so we consume memory indefinitely.
While that could be defended against, the number of cases where the
optimization can still be applied drops significantly, and adjusting the
initial sizes of StringInfo buffers makes it drop to almost nothing.
Seems better to just remove the extra complexity.
Per recent discussion and testing.

16 years agoIncrease the initial size of StringInfo buffers to 1024 bytes (from 256);
Tom Lane [Sun, 12 Aug 2007 20:18:06 +0000 (20:18 +0000)]
Increase the initial size of StringInfo buffers to 1024 bytes (from 256);
likewise increase the initial size of the scanner's literal buffer to 1024
(from 128).  Instrumentation of the regression tests suggests that this
saves a useful amount of repalloc() traffic --- the number of calls occurring
during one set of tests drops from about 6900 to about 3900.  The old sizes
were chosen in the late 90's with an eye to machines much smaller than
are common today.

16 years agoAvoid memory leakage across successive calls of regexp_matches() or
Tom Lane [Sat, 11 Aug 2007 19:16:41 +0000 (19:16 +0000)]
Avoid memory leakage across successive calls of regexp_matches() or
regexp_split_to_table() within a single query.  This is only a partial
solution, as it turns out that with enough matches per string these
functions can also tickle a repalloc() misbehavior.  But fixing that
is a topic for a separate patch.

16 years agoCode review for regexp_matches/regexp_split patch. Refactor to avoid assuming
Tom Lane [Sat, 11 Aug 2007 03:56:24 +0000 (03:56 +0000)]
Code review for regexp_matches/regexp_split patch.  Refactor to avoid assuming
that cached compiled patterns will still be there when the function is next
called.  Clean up looping logic, thereby fixing bug identified by Pavel
Stehule.  Share setup code between the two functions, add some comments, and
avoid risky mixing of int and size_t variables.  Clean up the documentation a
tad, and accept all the flag characters mentioned in table 9-19 rather than
just a subset.

16 years agoFix uninitialized-memory bug in plpython proargnames patch. Per bug #3523
Tom Lane [Fri, 10 Aug 2007 03:16:04 +0000 (03:16 +0000)]
Fix uninitialized-memory bug in plpython proargnames patch.  Per bug #3523

16 years agoFix unintended change of output format for createlang/droplang -l. Missed
Tom Lane [Fri, 10 Aug 2007 00:39:31 +0000 (00:39 +0000)]
Fix unintended change of output format for createlang/droplang -l.  Missed
these uses of printQuery() in FETCH_COUNT patch a year ago :-(.  Per report
from Tomoaki Sato.

16 years agoFix search for SGML stylesheets to include the place where Gentoo keeps them.
Tom Lane [Thu, 9 Aug 2007 02:33:58 +0000 (02:33 +0000)]
Fix search for SGML stylesheets to include the place where Gentoo keeps them.
Brendan Jurd

16 years agoRevise postmaster startup/shutdown logic to eliminate the problem that a
Tom Lane [Thu, 9 Aug 2007 01:18:43 +0000 (01:18 +0000)]
Revise postmaster startup/shutdown logic to eliminate the problem that a
constant flow of new connection requests could prevent the postmaster from
completing a shutdown or crash restart.  This is done by labeling child
processes that are "dead ends", that is, we know that they were launched only
to tell a client that it can't connect.  These processes are managed
separately so that they don't confuse us into thinking that we can't advance
to the next stage of a shutdown or restart sequence, until the very end
where we must wait for them to drain out so we can delete the shmem segment.
Per discussion of a misbehavior reported by Keaton Adams.

Since this code was baroque already, and my first attempt at fixing the
problem made it entirely impenetrable, I took the opportunity to rewrite it
in a state-machine style.  That eliminates some duplicated code sections and
hopefully makes everything a bit clearer.

16 years agoFix a gradual memory leak in ExecReScanAgg(). Because the aggregation
Neil Conway [Wed, 8 Aug 2007 18:07:05 +0000 (18:07 +0000)]
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.

16 years agoFix thinko in multi-autovac-workers code: validity checks made by
Tom Lane [Wed, 8 Aug 2007 16:00:46 +0000 (16:00 +0000)]
Fix thinko in multi-autovac-workers code: validity checks made by
GUC assign hooks are supposed to be made whether doit is true or not.

16 years agoAdjust the output of MemoryContextStats() so that the stats for a
Neil Conway [Tue, 7 Aug 2007 06:25:14 +0000 (06:25 +0000)]
Adjust the output of MemoryContextStats() so that the stats for a
child memory contexts is indented two spaces to the right of its
parent context.  This should make it easier to deduce the memory
context hierarchy from the output of MemoryContextStats().

16 years agoFix incorrect URI for cvs rsync
Magnus Hagander [Mon, 6 Aug 2007 07:58:06 +0000 (07:58 +0000)]
Fix incorrect URI for cvs rsync

16 years agoFix pg_restore to guard against unexpected EOF while reading an archive file.
Tom Lane [Mon, 6 Aug 2007 01:38:15 +0000 (01:38 +0000)]
Fix pg_restore to guard against unexpected EOF while reading an archive file.
Per report and partial patch from Chad Wagner.

16 years agoAdjust configure so that it sets CFLAGS properly for Intel's icc
Tom Lane [Sun, 5 Aug 2007 15:43:00 +0000 (15:43 +0000)]
Adjust configure so that it sets CFLAGS properly for Intel's icc
even if the compiler is not defining __GNUC__.  Per report from
Dirk Tilger that it is possible for icc to not do that.

16 years agoApparently icc doesn't always define __ICC, and it's more correct to
Tom Lane [Sun, 5 Aug 2007 15:11:40 +0000 (15:11 +0000)]
Apparently icc doesn't always define __ICC, and it's more correct to
check for __INTEL_COMPILER.  Per report from Dirk Tilger.
Not back-patched since I don't fully trust it yet ...

16 years agoFix up bad layout of some comments (probably pg_indent's fault), and
Tom Lane [Sat, 4 Aug 2007 21:53:00 +0000 (21:53 +0000)]
Fix up bad layout of some comments (probably pg_indent's fault), and
improve grammar a tad.  Per Greg Stark.

16 years agoTweak for initdb: if more command-line arguments were specified than
Neil Conway [Sat, 4 Aug 2007 21:01:09 +0000 (21:01 +0000)]
Tweak for initdb: if more command-line arguments were specified than
expected, exit with an error, rather than complaining about the error
on stderr but continuing onward.

16 years agoFix crash caused by log_timezone patch if we attempt to emit any elog messages
Tom Lane [Sat, 4 Aug 2007 19:29:25 +0000 (19:29 +0000)]
Fix crash caused by log_timezone patch if we attempt to emit any elog messages
between the setting of log_line_prefix and the setting of log_timezone.  We
can't realistically set log_timezone any earlier than we do now, so the best
behavior seems to be to use GMT zone if any timestamps are to be logged during
early startup.  Create a dummy zone variable with a minimal definition of GMT
(in particular it will never know about leap seconds), so that we can set it
up without reference to any external files.

16 years agoFix a problem in my recent patch to initialize cancel_key for autovac workers
Tom Lane [Sat, 4 Aug 2007 03:15:49 +0000 (03:15 +0000)]
Fix a problem in my recent patch to initialize cancel_key for autovac workers
as well as regular backends: if no regular backend launches before the autovac
launcher tries to start an autovac worker, the postmaster would get an Assert
fault due to calling PostmasterRandom before random_seed was initialized.
Cleanest solution seems to be to take the initialization of random_seed out
of ServerLoop and let PostmasterRandom do it for itself.

16 years agoSwitch over to using the src/timezone functions for formatting timestamps
Tom Lane [Sat, 4 Aug 2007 01:26:54 +0000 (01:26 +0000)]
Switch over to using the src/timezone functions for formatting timestamps
displayed in the postmaster log.  This avoids Windows-specific problems with
localized time zone names that are in the wrong encoding, and generally seems
like a good idea to forestall other potential platform-dependent issues.
To preserve the existing behavior that all backends will log in the same time
zone, create a new GUC variable log_timezone that can only be changed on a
system-wide basis, and reference log-related calculations to that zone instead
of the TimeZone variable.

This fixes the issue reported by Hiroshi Saito that timestamps printed by
xlog.c startup could be improperly localized on Windows.  We still need a
simpler patch for that problem in the back branches, however.

16 years agoFix some sloppiness in the recent multiple-autovacuum-worker patch. It was
Tom Lane [Fri, 3 Aug 2007 20:06:50 +0000 (20:06 +0000)]
Fix some sloppiness in the recent multiple-autovacuum-worker patch.  It was
not bothering to initialize is_autovacuum for regular backends, meaning there
was a significant chance of the postmaster prematurely sending them SIGTERM
during database shutdown.  Also, leaving the cancel key unset for an autovac
worker meant that any client could send it SIGINT, which doesn't sound
especially good either.

16 years agoUpdate supported standalone VC++ version to 7.1+ only, and fix
Magnus Hagander [Fri, 3 Aug 2007 10:47:11 +0000 (10:47 +0000)]
Update supported standalone VC++ version to 7.1+ only, and fix
some bad data leftover in win32.mak.

Per request from Hiroshi Saito.

16 years agoMove session_start out of MyProcPort stucture and make it a global called MyStartTime,
Andrew Dunstan [Thu, 2 Aug 2007 23:39:45 +0000 (23:39 +0000)]
Move session_start out of MyProcPort stucture and make it a global called MyStartTime,
so that we will be able to create a cookie for all processes for CSVlogs.
It is set wherever MyProcPid is set. Take the opportunity to remove the now
unnecessary session-only restriction on the %s and %c escapes in log_line_prefix.

16 years agoMake sure syslogPipe runs in binary mode on Windows to avoid corrupting the pipe...
Andrew Dunstan [Thu, 2 Aug 2007 23:15:27 +0000 (23:15 +0000)]
Make sure syslogPipe runs in binary mode on Windows to avoid corrupting the pipe chunking protocol. Backport to 8.0

16 years agoFix a memory leak in tuplestore_end(). Unlikely to be significant during
Neil Conway [Thu, 2 Aug 2007 17:48:52 +0000 (17:48 +0000)]
Fix a memory leak in tuplestore_end(). Unlikely to be significant during
normal operation, but tuplestore_end() ought to do what it claims to do.

16 years agoDone:
Bruce Momjian [Wed, 1 Aug 2007 23:13:31 +0000 (23:13 +0000)]
Done:

< * Allow buffered WAL writes and fsync

16 years agoSupport an optional asynchronous commit mode, in which we don't flush WAL
Tom Lane [Wed, 1 Aug 2007 22:45:09 +0000 (22:45 +0000)]
Support an optional asynchronous commit mode, in which we don't flush WAL
before reporting a transaction committed.  Data consistency is still
guaranteed (unlike setting fsync = off), but a crash may lose the effects
of the last few transactions.  Patch by Simon, some editorialization by Tom.

16 years agoFix strange quoting.
Bruce Momjian [Wed, 1 Aug 2007 22:24:32 +0000 (22:24 +0000)]
Fix strange quoting.

16 years agoFix script quoting problem.
Bruce Momjian [Wed, 1 Aug 2007 22:23:01 +0000 (22:23 +0000)]
Fix script quoting problem.

16 years agoRemove links to old Win32 source code ports.
Bruce Momjian [Wed, 1 Aug 2007 00:24:55 +0000 (00:24 +0000)]
Remove links to old Win32 source code ports.

16 years agoFix a bug in the original implementation of redundant-join-clause removal:
Tom Lane [Tue, 31 Jul 2007 19:53:37 +0000 (19:53 +0000)]
Fix a bug in the original implementation of redundant-join-clause removal:
clauses in which one side or the other references both sides of the join
cannot be removed as redundant, because that expression won't have been
constrained below the join.  Per report from Sergey Burladyan.

CVS HEAD does not contain this bug due to EquivalenceClass rewrite, but it
seems wise to include the regression test for it anyway.

16 years agoIf we're gonna use ExecRelationIsTargetRelation here, might as well
Tom Lane [Tue, 31 Jul 2007 16:36:07 +0000 (16:36 +0000)]
If we're gonna use ExecRelationIsTargetRelation here, might as well
simplify a bit further.

16 years agoFix security definer functions with polymorphic arguments. This case has
Tom Lane [Tue, 31 Jul 2007 15:49:49 +0000 (15:49 +0000)]
Fix security definer functions with polymorphic arguments.  This case has
never worked because fmgr_security_definer() neglected to pass the fn_expr
information through.  Per report from Viatcheslav Kalinin.

16 years agoSlight refactor for ExecOpenScanRelation(): we can use
Neil Conway [Fri, 27 Jul 2007 19:09:04 +0000 (19:09 +0000)]
Slight refactor for ExecOpenScanRelation(): we can use
ExecRelationIsTargetRelation() to check if the relation is a target
rel, rather than scanning through the result relation array ourselves.

16 years agoUpdate conformance information about bigint type
Peter Eisentraut [Fri, 27 Jul 2007 10:37:52 +0000 (10:37 +0000)]
Update conformance information about bigint type

found by Michael Glaesemann

16 years agoRemove FileUnlink(), which wasn't being used anywhere and interacted poorly
Tom Lane [Thu, 26 Jul 2007 15:15:18 +0000 (15:15 +0000)]
Remove FileUnlink(), which wasn't being used anywhere and interacted poorly
with the recent patch to log temp file sizes at removal time.  Doesn't seem
worth fixing since it's unused.
In passing, make a few elog messages conform to the message style guide.

16 years agoArrange to put TOAST tables belonging to temporary tables into special schemas
Tom Lane [Wed, 25 Jul 2007 22:16:18 +0000 (22:16 +0000)]
Arrange to put TOAST tables belonging to temporary tables into special schemas
named pg_toast_temp_nnn, alongside the pg_temp_nnn schemas used for the temp
tables themselves.  This allows low-level code such as the relcache to
recognize that these tables are indeed temporary, which enables various
optimizations such as not WAL-logging changes and using local rather than
shared buffers for access.  Aside from obvious performance benefits, this
provides a solution to bug #3483, in which other backends unexpectedly held
open file references to temporary tables.  The scheme preserves the property
that TOAST tables are not in any schema that's normally in the search path,
so they don't conflict with user table names.

initdb forced because of changes in system view definitions.

16 years agoSuppress warning when compiling with -DPROFILE_PID_DIR: sys/stat.h is
Tom Lane [Wed, 25 Jul 2007 19:58:56 +0000 (19:58 +0000)]
Suppress warning when compiling with -DPROFILE_PID_DIR: sys/stat.h is
supposed to be included when using mkdir().

16 years agoAdjust horology test to avoid join-plan-dependent result ordering in
Tom Lane [Wed, 25 Jul 2007 17:22:37 +0000 (17:22 +0000)]
Adjust horology test to avoid join-plan-dependent result ordering in
a few queries.  Should fix buildfarm failures arising from new,
more aggressive autovac settings.

16 years agoSynced parser
Michael Meskes [Wed, 25 Jul 2007 16:10:41 +0000 (16:10 +0000)]
Synced parser

16 years agoRename DLLIMPORT macro to PGDLLIMPORT to avoid conflict with
Magnus Hagander [Wed, 25 Jul 2007 12:22:54 +0000 (12:22 +0000)]
Rename DLLIMPORT macro to PGDLLIMPORT to avoid conflict with
third party includes (like tcl) that define DLLIMPORT.

16 years agoFix standalone win32 makefile (MSVC6) for SSPI and GSSAPI.
Magnus Hagander [Wed, 25 Jul 2007 11:37:25 +0000 (11:37 +0000)]
Fix standalone win32 makefile (MSVC6) for SSPI and GSSAPI.

Hiroshi Saito

16 years agoDisable warning 4090 = different const qualifiers on msvc since it
Magnus Hagander [Wed, 25 Jul 2007 10:51:03 +0000 (10:51 +0000)]
Disable warning 4090 = different const qualifiers on msvc since it
warns about things that aren't wrong.

16 years agoSilence compiler warnings on mingw
Magnus Hagander [Wed, 25 Jul 2007 10:17:46 +0000 (10:17 +0000)]
Silence compiler warnings on mingw

16 years agoImplement RETURN QUERY for PL/PgSQL. This provides some convenient syntax
Neil Conway [Wed, 25 Jul 2007 04:19:09 +0000 (04:19 +0000)]
Implement RETURN QUERY for PL/PgSQL. This provides some convenient syntax
sugar for PL/PgSQL set-returning functions that want to return the result
of evaluating a query; it should also be more efficient than repeated
RETURN NEXT statements. Based on an earlier patch from Pavel Stehule.

16 years agoFix predicate-proving logic to cope with binary-compatibility cases when
Tom Lane [Tue, 24 Jul 2007 17:22:07 +0000 (17:22 +0000)]
Fix predicate-proving logic to cope with binary-compatibility cases when
checking whether an IS NULL/IS NOT NULL clause is implied or refuted by
a strict function.  Per example from Dawid Kuroczko.
Backpatch to 8.2 since this is arguably a performance bug.

16 years agoSilence compiler warning on mingw
Magnus Hagander [Tue, 24 Jul 2007 11:16:36 +0000 (11:16 +0000)]
Silence compiler warning on mingw

16 years agoMake it possible, and default, for MingW to build with SSPI support
Magnus Hagander [Tue, 24 Jul 2007 09:00:27 +0000 (09:00 +0000)]
Make it possible, and default, for MingW to build with SSPI support
by dynamically loading the function that's missing from the MingW
headers and library.

16 years agoCreate a new dedicated Postgres process, "wal writer", which exists to write
Tom Lane [Tue, 24 Jul 2007 04:54:09 +0000 (04:54 +0000)]
Create a new dedicated Postgres process, "wal writer", which exists to write
and fsync WAL at convenient intervals.  For the moment it just tries to
offload this work from backends, but soon it will be responsible for
guaranteeing a maximum delay before asynchronously-committed transactions
will be flushed to disk.

This is a portion of Simon Riggs' async-commit patch, committed to CVS
separately because a background WAL writer seems like it might be a good idea
independently of the async-commit feature.  I rebased walwriter.c on
bgwriter.c because it seemed like a more appropriate way of handling signals;
while the startup/shutdown logic in postmaster.c is more like autovac because
we want walwriter to quit before we start the shutdown checkpoint.