OSDN Git Service

android-x86/system-bt.git
3 years agoUse proper type stack/acl/::tLINK_POLICY
Chris Manton [Thu, 24 Dec 2020 17:20:11 +0000 (09:20 -0800)]
Use proper type stack/acl/::tLINK_POLICY

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7d915bb5c8e5f1e776d3b2c3db90f95acc6de846

3 years agoAdd stack/acl/btm_pm::BTM_SetLinkPolicyActiveMode
Chris Manton [Sat, 26 Dec 2020 20:56:17 +0000 (12:56 -0800)]
Add stack/acl/btm_pm::BTM_SetLinkPolicyActiveMode

Bug: 175344733
Test: cert
Tag: #refactor

Change-Id: Ic3fae4495111f50dc17abe510fea395b33b91431

3 years agoGroup like functions main/shim/acl::
Chris Manton [Sun, 27 Dec 2020 17:49:04 +0000 (09:49 -0800)]
Group like functions main/shim/acl::

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I555d895b49c0eb0f9e8e1cd5f67a124f5eeeb23b

3 years agogd: add shim layer for LE scanning manager
Chienyuan [Tue, 29 Dec 2020 06:54:18 +0000 (14:54 +0800)]
gd: add shim layer for LE scanning manager

Tag: #refactor
Bug: 159815595
Test: manual
Change-Id: Idea9ad04a51938a3f8bcc2d594dd1d7483adde5c

3 years agoMerge "Shim: Add GD scanning init flags"
Treehugger Robot [Tue, 29 Dec 2020 06:12:21 +0000 (06:12 +0000)]
Merge "Shim: Add GD scanning init flags"

3 years agoShim: Add GD scanning init flags
Chienyuan [Mon, 28 Dec 2020 08:43:08 +0000 (16:43 +0800)]
Shim: Add GD scanning init flags

Tag: #gd-refactor
Bug: 159815595
Test: cert/run --host
Change-Id: I758d69ff5ab7bb6029444aa699fc4d638ba21a2a

3 years agogd: Set flag for connectable advertising
Chienyuan [Fri, 25 Dec 2020 10:19:25 +0000 (18:19 +0800)]
gd: Set flag for connectable advertising

Tag: #gd-refactor
Bug: 176047975
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: Iea0e70eba8a9401e66a6078ba3f62adada81af0c

3 years agogd: Handle duration and max advertising event
Chienyuan [Fri, 25 Dec 2020 09:11:44 +0000 (17:11 +0800)]
gd: Handle duration and max advertising event

Tag: #gd-refactor
Bug: 176047975
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: Ie87986b11ed0b412290296c50ebb0b8bce31fb7d

3 years agoFix bad SC bit in Pairing Request/Response between two android phones
Jakub Pawlowski [Wed, 23 Dec 2020 20:41:30 +0000 (21:41 +0100)]
Fix bad SC bit in Pairing Request/Response between two android phones

This patch fixes recent regression where Secure Connection pairing is no
longer used, even between two capable devices.

Tag: #gd-refactor
Bug: 141555841
Test: bond two LE devices capable of Secure Connection
Change-Id: If621078a62cb42d2f6b88e94801ada5d107a727a

3 years agoMerge "[GD-Controller] Enable SSP controller when security layer is not enabled"
Treehugger Robot [Wed, 23 Dec 2020 04:15:19 +0000 (04:15 +0000)]
Merge "[GD-Controller] Enable SSP controller when security layer is not enabled"

3 years agoMerge "stack/eatt: Add multi read var and multi notification handling"
Jakub Pawlowski [Wed, 23 Dec 2020 02:02:37 +0000 (02:02 +0000)]
Merge "stack/eatt: Add multi read var and multi notification handling"

3 years agoMerge changes I7a22a399,Id3686045
Treehugger Robot [Tue, 22 Dec 2020 20:22:21 +0000 (20:22 +0000)]
Merge changes I7a22a399,Id3686045

* changes:
  HCI: Add support for synchronous commands
  [GD-SCO] Add SCO related commands and events

3 years ago[GD-Controller] Enable SSP controller when security layer is not enabled
Jack He [Tue, 22 Dec 2020 20:18:54 +0000 (12:18 -0800)]
[GD-Controller] Enable SSP controller when security layer is not enabled

* This allows Simple Secure Pairing when only controller layer is
enabled

Fixes: 176048878
Tag: #gd-refactor
Test: gd/cert/run
Change-Id: I2ab30bb47f75cde94c1d2d83bc284027771eef60

3 years agostack/eatt: Add multi read var and multi notification handling
Łukasz Rymanowski [Thu, 18 Jun 2020 10:18:16 +0000 (12:18 +0200)]
stack/eatt: Add multi read var and multi notification handling

Multi read variable is added to GATT server.
Multi notification handling as a GATT client.

Tag: #feature
Bug: 159786353
Sponsor: jpawlowski@
Test: compile & manual testing
Change-Id: Ibeb27a0eb7f0c9c241bc9dbac24d6f4306140005

3 years agoStraighten out stack/acl/btm_acl::acl_address_from_handle
Chris Manton [Tue, 22 Dec 2020 00:43:12 +0000 (16:43 -0800)]
Straighten out stack/acl/btm_acl::acl_address_from_handle

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I64fa3a2dc6cef8080eaf0e6536f6a7d553ff02d2

3 years agoConsolidate #defs BT_PSM_
Chris Manton [Mon, 21 Dec 2020 23:37:36 +0000 (15:37 -0800)]
Consolidate #defs BT_PSM_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I2d05e6bdbebbd5bd796de995bb582ba3e499d381

3 years agoRe-log BTM_SetPowerMode
Chris Manton [Tue, 22 Dec 2020 02:31:43 +0000 (18:31 -0800)]
Re-log BTM_SetPowerMode

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iad96cb93c510b5df5630245d9fc6637ca07d3c05

3 years agoRe-log BTM_SetSsrParams
Chris Manton [Tue, 22 Dec 2020 02:33:37 +0000 (18:33 -0800)]
Re-log BTM_SetSsrParams

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ida8b507b32d5978b0ce98596ac58dde37874c39a

3 years agoStreamline process_ssr_event
Chris Manton [Tue, 22 Dec 2020 02:33:17 +0000 (18:33 -0800)]
Streamline process_ssr_event

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I875ec08cb039286f0d9538f5f173b82376d245b9

3 years agoUse tACL_CB::DefaultPacketTypes
Chris Manton [Sun, 13 Dec 2020 01:13:46 +0000 (17:13 -0800)]
Use tACL_CB::DefaultPacketTypes

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ie034c9703f18b18a7338b362816414f602e1923c

3 years agoRe-log stack/acl/btm_pm::btm_pm_proc_cmd_status
Chris Manton [Fri, 11 Dec 2020 00:20:17 +0000 (16:20 -0800)]
Re-log stack/acl/btm_pm::btm_pm_proc_cmd_status

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia8dceac14b10761ef40db6d9999d768462b7ae50

3 years agoUse proper types tHCI_STATUS
Chris Manton [Thu, 10 Dec 2020 02:15:14 +0000 (18:15 -0800)]
Use proper types tHCI_STATUS

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ied837f99e446b509d5f6d03a53465a9c07c70d04

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_sniff
Chris Manton [Thu, 10 Dec 2020 04:26:35 +0000 (20:26 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_sniff

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3c38e184a0eafb16f0aa653365e74c41ab822d49

3 years agoEncapsulate tBTM_PM_MCB::state
Chris Manton [Mon, 7 Dec 2020 04:15:25 +0000 (20:15 -0800)]
Encapsulate tBTM_PM_MCB::state

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ieb954f5d1395e0b860e5483b534ae2a0df274b1c

3 years agoStreamline stack/acl/btm_pm::BTM_ReadPowerMode
Chris Manton [Wed, 9 Dec 2020 22:22:37 +0000 (14:22 -0800)]
Streamline stack/acl/btm_pm::BTM_ReadPowerMode

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Id9e92d788a8d4ecb624db6155e39c509787b9aa2

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_timer_cback
Chris Manton [Fri, 11 Dec 2020 00:25:38 +0000 (16:25 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_timer_cback

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7149d0578c7cc3674c7a54c9952994400e67195c

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_cback
Chris Manton [Thu, 10 Dec 2020 21:30:48 +0000 (13:30 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_cback

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I4b19475d9731ca151894327393fbf4cf560ecfac

3 years agoRe-log bta/dm/bta_dm_act::bta_dm_rm_cback
Chris Manton [Wed, 9 Dec 2020 17:04:00 +0000 (09:04 -0800)]
Re-log bta/dm/bta_dm_act::bta_dm_rm_cback

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I86b87654fb9e9c8a0de8a9c2966712cfd9ab8056

3 years agoRe-log bta/av/bta_av_aact::bta_av_conn_failed
Chris Manton [Wed, 9 Dec 2020 16:52:50 +0000 (08:52 -0800)]
Re-log bta/av/bta_av_aact::bta_av_conn_failed

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ie4d215f13959efe536298478510116b867ba10bb

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_set_mode
Chris Manton [Wed, 9 Dec 2020 16:52:36 +0000 (08:52 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_set_mode

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I36ec01426689b61693eb63210344df2b788474b7

3 years agoEncapsulate bta/dm/bta_dm_int::tBTA_DM_DEV_INFO
Chris Manton [Wed, 9 Dec 2020 20:28:53 +0000 (12:28 -0800)]
Encapsulate bta/dm/bta_dm_int::tBTA_DM_DEV_INFO

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ie829593e381619b7ee46e2fb73d9b5bb842b2d31

3 years agoAdd stack/include/btm_api_types::is_legal_power_mode
Chris Manton [Wed, 9 Dec 2020 23:13:18 +0000 (15:13 -0800)]
Add stack/include/btm_api_types::is_legal_power_mode

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I001c2476f23acb57fbb57f20e6212e9eb3f0ef9c

3 years agoAdd audio gateway BtaIdSysText::BTA_ID_AG
Chris Manton [Sat, 19 Dec 2020 01:58:42 +0000 (17:58 -0800)]
Add audio gateway BtaIdSysText::BTA_ID_AG

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Id263cdd4b0c56ec1eeae517ee1c8b96cca096daa

3 years agoAdd tBTA_AG_SCB::ToString
Chris Manton [Tue, 15 Dec 2020 00:16:04 +0000 (16:16 -0800)]
Add tBTA_AG_SCB::ToString

Monster structure needs visibility

Towards readability

Bug: 163134718
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I7d20e5d71f2108103bb878fb3774421e8df76a6e

3 years agoMerge "Swich TEST_MAPPING config to unit_tests:true"
Julien Desprez [Tue, 22 Dec 2020 00:59:36 +0000 (00:59 +0000)]
Merge "Swich TEST_MAPPING config to unit_tests:true"

3 years agoSwich TEST_MAPPING config to unit_tests:true
Julien Desprez [Mon, 21 Dec 2020 22:00:45 +0000 (14:00 -0800)]
Swich TEST_MAPPING config to unit_tests:true

All unit_tests:true are run in presubmit which avoids
the explicit definition of TEST_MAPPING.

Test: presubmit runs all those tests
Bug: 175408655
Change-Id: Ibf2b80f902bffa4924853f001780e2d273cf451f

3 years agoAdd L2CAP 5.2 packets
Hansong Zhang [Thu, 17 Dec 2020 19:20:02 +0000 (11:20 -0800)]
Add L2CAP 5.2 packets

Bug: 141555841
Tag: #gd-refactor
Test: make
Change-Id: I73b6e21f06824aed74e7131dec388108f5ecd018

3 years agoenum-ify bta/ag/bta_ag_int::tBTA_AG_SCO
Chris Manton [Tue, 15 Dec 2020 00:08:11 +0000 (16:08 -0800)]
enum-ify bta/ag/bta_ag_int::tBTA_AG_SCO

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: If8bcba05b54b4665244331a11039272df9c8f5c9

3 years agoRearrange enumify stack/btm/btm_sco::SCO_ST_
Chris Manton [Mon, 14 Dec 2020 23:26:54 +0000 (15:26 -0800)]
Rearrange enumify stack/btm/btm_sco::SCO_ST_

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia68644821a23772e43746036d890de979cee1d84

3 years agoRe-include stack/acl/btm_pm
Chris Manton [Thu, 10 Dec 2020 22:16:11 +0000 (14:16 -0800)]
Re-include stack/acl/btm_pm

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ib2d5d5d1f5db8e0047a04749fd1ed0660db4ab35

3 years agoenum-ify stack/include/avrc_defs::tAVRC_PDU
Chris Manton [Sat, 12 Dec 2020 17:15:24 +0000 (09:15 -0800)]
enum-ify stack/include/avrc_defs::tAVRC_PDU

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I667063c026983dcfe04f8b2a98466febdcaeb041

3 years agoUse acl default methods
Chris Manton [Fri, 11 Dec 2020 00:26:56 +0000 (16:26 -0800)]
Use acl default methods

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Id799d219408efa9ac55892e479a1605c5259edbb

3 years agoStati-ify bta/ag/bta_ag_cmd
Chris Manton [Thu, 17 Dec 2020 22:38:21 +0000 (14:38 -0800)]
Stati-ify bta/ag/bta_ag_cmd

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia608f80ca893162d3d199e58751d91dc281922b4

3 years agoAdd stack/rfcomm/rfc_int::rfcomm_mx_state_text
Chris Manton [Sat, 19 Dec 2020 02:00:18 +0000 (18:00 -0800)]
Add stack/rfcomm/rfc_int::rfcomm_mx_state_text

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Id3649acae3d2706e9d9a4c7d5db0db7174f7f86f

3 years agoAdd main/shim/acl::DumpsysRecord for p_sec_rec
Chris Manton [Tue, 15 Dec 2020 01:44:34 +0000 (17:44 -0800)]
Add main/shim/acl::DumpsysRecord for p_sec_rec

Towards dumpable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia9d8ea362578a9a95cebab8a26befb200f1f9f55

3 years agoAdd stack/btm/security_device_record::ToString
Chris Manton [Tue, 15 Dec 2020 01:44:42 +0000 (17:44 -0800)]
Add stack/btm/security_device_record::ToString

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I9e6c1e5865f1524854e8cc7ce3648d7e662d112e

3 years agoAdd declaration btm_sco_chk_pend_unpark
Chris Manton [Sun, 20 Dec 2020 01:32:40 +0000 (17:32 -0800)]
Add declaration btm_sco_chk_pend_unpark

And fix types

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I1b4b978d8aae1f0122189c5d7be3abb395a70b9e

3 years agoAdd tBTA_DM_SRVCS::ToString
Chris Manton [Fri, 11 Dec 2020 00:24:47 +0000 (16:24 -0800)]
Add tBTA_DM_SRVCS::ToString

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iddfc929dddd16d3287ba945789d4bb24ea8beac8

3 years agoUse power_mode_state_text in dumpsys
Chris Manton [Thu, 10 Dec 2020 04:26:48 +0000 (20:26 -0800)]
Use power_mode_state_text in dumpsys

Towards dumpable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3388cd5cbeccfa28cc0f88d491e83751dad524f0

3 years agoAdd stack/include/btm_api_types::power_mode_text
Chris Manton [Thu, 10 Dec 2020 00:54:52 +0000 (16:54 -0800)]
Add stack/include/btm_api_types::power_mode_text

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I18da64eab0ff3e30a8aa7554c6469ae25b9beb07

3 years agoUse proper acl transport check
Chris Manton [Sat, 12 Dec 2020 17:28:05 +0000 (09:28 -0800)]
Use proper acl transport check

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I32c2f381dd49c9683217d2c40abe5146b4bd9ad8

3 years agogd_acl: SCO temporary fix
Chris Manton [Sun, 20 Dec 2020 01:22:49 +0000 (17:22 -0800)]
gd_acl: SCO temporary fix

Assume unknown disconnects are from SCO and
respond accordingly

Bug: 166280067
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Icce62bdc05f4e7ba17b1a05ca40b0db42d8e5cc8

3 years agoMove power_mode registration from btm_cb into acl
Chris Manton [Sat, 19 Dec 2020 18:59:11 +0000 (10:59 -0800)]
Move power_mode registration from btm_cb into acl

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iaaf7632753f030c70275631da754711759ff822a

3 years agoAdd context term for StackAclBtmPm::btm_pm_snd_md_req
Chris Manton [Sat, 19 Dec 2020 16:50:58 +0000 (08:50 -0800)]
Add context term for StackAclBtmPm::btm_pm_snd_md_req

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: If1d4d1809c987dcd01397c5d77ae416d8b8b685f

3 years agoMove stack/acl/acl::tBTM_PM_STATE earlier in header
Chris Manton [Sat, 19 Dec 2020 19:17:14 +0000 (11:17 -0800)]
Move stack/acl/acl::tBTM_PM_STATE earlier in header

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I91ea973bc27328cbbe8bcc1a9e432399da07a366

3 years agoMove tACL_CB::tBTM_PM_MCB definition before tACL_CONN
Chris Manton [Sat, 19 Dec 2020 19:13:12 +0000 (11:13 -0800)]
Move tACL_CB::tBTM_PM_MCB definition before tACL_CONN

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I544f44c343a15f8737d4da8c34444aa3b10c0291

3 years agoAdd stack/acl/btm_acl::acl_get_connection_from_handle
Chris Manton [Sat, 19 Dec 2020 17:13:28 +0000 (09:13 -0800)]
Add stack/acl/btm_acl::acl_get_connection_from_handle

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I9042c6b548c98c038dea817d51a6bd9c891ae758

3 years agoMerge changes I1d3569da,Ic6d95ccc,I999c43fd,Ie68b9124,I91e6a21f, ...
Zach Johnson [Sat, 19 Dec 2020 19:38:01 +0000 (19:38 +0000)]
Merge changes I1d3569da,Ic6d95ccc,I999c43fd,Ie68b9124,I91e6a21f, ...

* changes:
  rusty-gd: more controller
  rusty-gd: controller supported commands & le buffer sizes
  rusty-gd: A bit more controller
  rusty-gd: add intos for builders, so we can skip the formal build call
  rusty-gd: start controller module
  rusty-gd: simplify queued & pending commands
  rusty-gd: make scalar getters return by copy rather than ref
  rusty-gd: drastically simplify command sending
  rusty-gd: improve ergonomics of sending commands a bit

3 years agoMerge changes Iaca9bcda,I3094c7a6,I5d79687e
Zach Johnson [Sat, 19 Dec 2020 02:45:57 +0000 (02:45 +0000)]
Merge changes Iaca9bcda,I3094c7a6,I5d79687e

* changes:
  rusty-gd: send reset command when HCI starts
  rusty-gd: no more sleep
  rusty-gd: protect protected events in hci

3 years agoMerge changes I6a0f12b6,I40942038,I4ce65e27
Zach Johnson [Sat, 19 Dec 2020 02:44:10 +0000 (02:44 +0000)]
Merge changes I6a0f12b6,I40942038,I4ce65e27

* changes:
  rusty-gd: only allow one registration for an event, allow unregistering
  rusty-gd: drop events dropped by cpp-gd
  rusty-gd: implement le meta events

3 years agoMerge changes Ie08faff0,I0356c210,Ie591460e,I51b88fc9
Zach Johnson [Fri, 18 Dec 2020 21:47:07 +0000 (21:47 +0000)]
Merge changes Ie08faff0,I0356c210,Ie591460e,I51b88fc9

* changes:
  rusty-gd: update command sending to match cpp-gd
  rusty-gd: simplify hci a little bit
  rusty-gd: simplify some packet usages
  rusty-gd: improve ergonomics of converting packets to vectors

3 years agorusty-gd: more controller
Zach Johnson [Mon, 14 Dec 2020 04:55:11 +0000 (20:55 -0800)]
rusty-gd: more controller

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I1d3569dadac6411be16c1cf94f3ce6c031846920

3 years agorusty-gd: controller supported commands & le buffer sizes
Zach Johnson [Mon, 14 Dec 2020 03:54:51 +0000 (19:54 -0800)]
rusty-gd: controller supported commands & le buffer sizes

also, generate TryFrom for OpCodeIndex from OpCode, to remove 700+ lines
of repeated code in C++ gd controller

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ic6d95ccc87a0ccc64636f16b0ef379c1f0d2f069

3 years agorusty-gd: A bit more controller
Zach Johnson [Mon, 14 Dec 2020 01:14:27 +0000 (17:14 -0800)]
rusty-gd: A bit more controller

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I999c43fdbb5bcbcbb005dece73192ec2300138d0

3 years agorusty-gd: add intos for builders, so we can skip the formal build call
Zach Johnson [Sun, 13 Dec 2020 11:22:22 +0000 (03:22 -0800)]
rusty-gd: add intos for builders, so we can skip the formal build call

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie68b9124b0d6f7b4c52ce882a6966995088d17f6

3 years agorusty-gd: start controller module
Zach Johnson [Sun, 13 Dec 2020 11:09:15 +0000 (03:09 -0800)]
rusty-gd: start controller module

only a few calls to start, more to come

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I91e6a21f4d15e67c5ad7b917cd31d419bf86ebe9

3 years agorusty-gd: simplify queued & pending commands
Zach Johnson [Sun, 13 Dec 2020 10:31:53 +0000 (02:31 -0800)]
rusty-gd: simplify queued & pending commands

since packets are just wrappers around Arcs, copies are somewhat cheap

so no need to keep a struct with just opcode anymore

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I6294a728e07b2ee949ef96465b07678845f5115c

3 years agorusty-gd: make scalar getters return by copy rather than ref
Zach Johnson [Sun, 13 Dec 2020 10:17:22 +0000 (02:17 -0800)]
rusty-gd: make scalar getters return by copy rather than ref

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I1427e8cc8c252a1eddb68470b1df215cf53c628f

3 years agorusty-gd: drastically simplify command sending
Zach Johnson [Sun, 13 Dec 2020 09:59:43 +0000 (01:59 -0800)]
rusty-gd: drastically simplify command sending

include a trait during generation that knows how to
convert the event responses to the correct matching type

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Icf96ce20c0b2311e94e5198c1cc4038f78683771

3 years agorusty-gd: send reset command when HCI starts
Zach Johnson [Sun, 13 Dec 2020 08:18:03 +0000 (00:18 -0800)]
rusty-gd: send reset command when HCI starts

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Iaca9bcda285ff4682532efeb43e2892adc487e9a

3 years agorusty-gd: only allow one registration for an event, allow unregistering
Zach Johnson [Sun, 13 Dec 2020 07:03:50 +0000 (23:03 -0800)]
rusty-gd: only allow one registration for an event, allow unregistering

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I6a0f12b696a22f0653037e3530ccfb4e2f38d001

3 years agorusty-gd: update command sending to match cpp-gd
Zach Johnson [Sun, 13 Dec 2020 06:14:56 +0000 (22:14 -0800)]
rusty-gd: update command sending to match cpp-gd

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie08faff009045ee329c7392652d632fed49f9d11

3 years agorusty-gd: improve ergonomics of sending commands a bit
Zach Johnson [Sun, 13 Dec 2020 08:22:14 +0000 (00:22 -0800)]
rusty-gd: improve ergonomics of sending commands a bit

use generics to implicity call into

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ied9f2e4f544979f63554bd3276e092788e0f0706

3 years agorusty-gd: no more sleep
Zach Johnson [Sun, 13 Dec 2020 07:51:13 +0000 (23:51 -0800)]
rusty-gd: no more sleep

since it's backed by a fd, a structure that encourages reuse is a good
thing.

integrate this into HCI, for command timeouts

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I3094c7a666281cebdfdeee05246ac1ad557988c5

3 years agorusty-gd: drop events dropped by cpp-gd
Zach Johnson [Sun, 13 Dec 2020 06:54:17 +0000 (22:54 -0800)]
rusty-gd: drop events dropped by cpp-gd

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I40942038dea359a31f413f604dcc3c6db926f80e

3 years agorusty-gd: simplify hci a little bit
Zach Johnson [Sun, 13 Dec 2020 05:38:53 +0000 (21:38 -0800)]
rusty-gd: simplify hci a little bit

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I0356c2102cf760c091a92ae0ab8ee7917eea03b6

3 years agorusty-gd: protect protected events in hci
Zach Johnson [Sun, 13 Dec 2020 07:16:12 +0000 (23:16 -0800)]
rusty-gd: protect protected events in hci

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I5d79687eb4d464fb5942651f86945db31cfa62d3

3 years agorusty-gd: implement le meta events
Zach Johnson [Sun, 13 Dec 2020 06:45:46 +0000 (22:45 -0800)]
rusty-gd: implement le meta events

and oh hey, pattern matching is pretty freaking great

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I4ce65e275ffe0e16161260e854d02987d166e4ca

3 years agorusty-gd: simplify some packet usages
Zach Johnson [Sun, 13 Dec 2020 05:13:52 +0000 (21:13 -0800)]
rusty-gd: simplify some packet usages

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie591460ed642a46215cfe8b0ddefcb509f21db89

3 years agorusty-gd: improve ergonomics of converting packets to vectors
Zach Johnson [Sun, 13 Dec 2020 05:02:59 +0000 (21:02 -0800)]
rusty-gd: improve ergonomics of converting packets to vectors

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I51b88fc9513475ab0e25b41ce5bb40b7934e9692

3 years agoMerge "rusty-gd: integrate rusty packets into existing code"
Zach Johnson [Fri, 18 Dec 2020 01:31:42 +0000 (01:31 +0000)]
Merge "rusty-gd: integrate rusty packets into existing code"

3 years agoMerge changes I65399f4e,Iad27b185,Ia43609b6,I78a06be7,I8e518f2b, ...
Treehugger Robot [Thu, 17 Dec 2020 20:37:07 +0000 (20:37 +0000)]
Merge changes I65399f4e,Iad27b185,Ia43609b6,I78a06be7,I8e518f2b, ...

* changes:
  Properly retrieve acl_conn stack/acl/btm_acl::btm_pm_proc_mode_change
  Re-log stack/acl/btm_pm::BTM_SetPowerMode
  Re-log bta/dm/bta_dm_pm::bta_dm_pm_cback
  Introduce bluetooth::legacy::hci::Interface
  gd_acl: Add bluetooth::shim::ACL_Disconnect
  gd_acl: Add shim disconnect
  gd_acl: Add main/shim/helpers::ToDisconnectReasonFromLegacy
  Remove unnecessary stack/acl/btm_acl::l2c_link_hci_conn_comp
  Add stack/btm/btm_main::BTM_LogHistory
  Properly retrieve acl_conn stack/acl/btm_acl::btm_acl_encrypt_change
  Properly retrieve acl_conn stack/acl/btm_acl::btm_acl_process_sca_cmpl_pkt
  Properly retrieve acl_conn stack/acl/btm_acl::btm_read_failed_contact_counter_complete
  Properly retrieve acl_conn stack/acl/btm_acl::btm_read_link_quality_complete
  Properly retrieve acl_conn stack/acl/btm_acl::btm_read_remote_ext_features_failed
  gd_acl: Add sniff_subrating to dumpsys
  Add stack/acl/btm_pm::StackAclBtmPm::btm_pm_get_power_manager_from_handle
  Add stack/acl/btm_acl::acl_disconnect_from_handle
  Add stack/acl/btm_acl::hci_btsnd_hcic_disconnect
  Add tBTA_DM_SSR_SPEC.name[] field for sniff subrating options
  Add bta/dm/bta_dm_int::device_info_text

3 years agorusty-gd: integrate rusty packets into existing code
Zach Johnson [Sun, 13 Dec 2020 04:11:26 +0000 (20:11 -0800)]
rusty-gd: integrate rusty packets into existing code

still gotta wait for parsing to land for this to officially work, but
this allows us to play with the ergonomics independently based on what
compiles..

next CLs will start to improve the ergos.

some ergos improved this CL.

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I5eadd7619c5d392c2dd03331c5d604d9a52a1687

3 years agoHCI: Add support for synchronous commands
Myles Watson [Thu, 17 Dec 2020 19:00:07 +0000 (11:00 -0800)]
HCI: Add support for synchronous commands

Bug: 175844355
Tag: #gd-refactor
Test: make
Change-Id: I7a22a399cb175e6702b2c14df4c8f35def8835cf

3 years agoMerge "use common data + payload for hci & hal facades"
Zach Johnson [Thu, 17 Dec 2020 19:26:20 +0000 (19:26 +0000)]
Merge "use common data + payload for hci & hal facades"

3 years agoMerge "rusty-gd: create singular proto facade lib"
Zach Johnson [Thu, 17 Dec 2020 19:22:18 +0000 (19:22 +0000)]
Merge "rusty-gd: create singular proto facade lib"

3 years ago[GD-SCO] Add SCO related commands and events
Jack He [Thu, 17 Dec 2020 11:36:21 +0000 (03:36 -0800)]
[GD-SCO] Add SCO related commands and events

Bug: 175844355
Tag: #gd-refactor
Test: make
Change-Id: Id36860456779533abea1e3be517697cfabe45302

3 years agoMerge "gd: Default to rotating addresses"
Treehugger Robot [Thu, 17 Dec 2020 17:38:26 +0000 (17:38 +0000)]
Merge "gd: Default to rotating addresses"

3 years agoProperly retrieve acl_conn stack/acl/btm_acl::btm_pm_proc_mode_change
Chris Manton [Sun, 13 Dec 2020 19:22:34 +0000 (11:22 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_pm_proc_mode_change

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I65399f4e4bc108c19e1e52dcd719f050f7479caa

3 years agoRe-log stack/acl/btm_pm::BTM_SetPowerMode
Chris Manton [Wed, 9 Dec 2020 05:55:52 +0000 (21:55 -0800)]
Re-log stack/acl/btm_pm::BTM_SetPowerMode

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Iad27b18551957854ae1c8a0b962492abf7e53e10

3 years agoRe-log bta/dm/bta_dm_pm::bta_dm_pm_cback
Chris Manton [Wed, 9 Dec 2020 05:55:38 +0000 (21:55 -0800)]
Re-log bta/dm/bta_dm_pm::bta_dm_pm_cback

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia43609b6e9bf52d156e8770cb8bde903d7cb1ed7

3 years agoIntroduce bluetooth::legacy::hci::Interface
Chris Manton [Wed, 16 Dec 2020 20:19:58 +0000 (12:19 -0800)]
Introduce bluetooth::legacy::hci::Interface

Migrate away from globals which allow any module
anywhere to bypass design intent which may
potentially introduce unintended code paths and
possible instability in module relationships.

Also towards testable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I78a06be73906973e0bbdaba78cc7fbf27d9b27cb

3 years agogd_acl: Add bluetooth::shim::ACL_Disconnect
Chris Manton [Wed, 16 Dec 2020 17:42:43 +0000 (09:42 -0800)]
gd_acl: Add bluetooth::shim::ACL_Disconnect

Bug: 166280067
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8e518f2bd768889874814950cd08be6e193aa0a1

3 years agogd_acl: Add shim disconnect
Chris Manton [Wed, 16 Dec 2020 17:43:19 +0000 (09:43 -0800)]
gd_acl: Add shim disconnect

Bug: 166280067
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8bf1358024ab61c5ed8377424c52e9aa219a75d5

3 years agogd_acl: Add main/shim/helpers::ToDisconnectReasonFromLegacy
Chris Manton [Wed, 16 Dec 2020 17:42:28 +0000 (09:42 -0800)]
gd_acl: Add main/shim/helpers::ToDisconnectReasonFromLegacy

Bug: 166280067
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ic3229da912e823fc16bda0e377d0b8f08db0d730

3 years agoRemove unnecessary stack/acl/btm_acl::l2c_link_hci_conn_comp
Chris Manton [Tue, 15 Dec 2020 22:55:16 +0000 (14:55 -0800)]
Remove unnecessary stack/acl/btm_acl::l2c_link_hci_conn_comp

No longer part of the hci_l2c interface

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Icd5170cef3883c047b44ae9932a26654b6a807b2

3 years agoAdd stack/btm/btm_main::BTM_LogHistory
Chris Manton [Mon, 14 Dec 2020 02:58:42 +0000 (18:58 -0800)]
Add stack/btm/btm_main::BTM_LogHistory

Expand to allow any module to partake

Towards dumpable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3e587c191e93ba0cbee96a2e0f9cb4c6514033ca

3 years agoProperly retrieve acl_conn stack/acl/btm_acl::btm_acl_encrypt_change
Chris Manton [Sun, 13 Dec 2020 19:42:31 +0000 (11:42 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_acl_encrypt_change

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I256932b85550c1c005c54879002f19ad10e25d3d

3 years agoProperly retrieve acl_conn stack/acl/btm_acl::btm_acl_process_sca_cmpl_pkt
Chris Manton [Sun, 13 Dec 2020 19:36:50 +0000 (11:36 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_acl_process_sca_cmpl_pkt

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I26b5e537e3a99ee689d43314115e5fb8ebb0cc55

3 years agoProperly retrieve acl_conn stack/acl/btm_acl::btm_read_failed_contact_counter_complete
Chris Manton [Sun, 13 Dec 2020 19:14:03 +0000 (11:14 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_failed_contact_counter_complete

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8391353a58a57c0f5d57e80e14ca0c122f30a1dc