OSDN Git Service
Rich Felker [Thu, 21 Apr 2011 00:55:13 +0000 (20:55 -0400)]
implement (nonstandard) forkpty
Rich Felker [Thu, 21 Apr 2011 00:02:35 +0000 (20:02 -0400)]
disallow blank strings as service or host name
Rich Felker [Thu, 21 Apr 2011 00:00:59 +0000 (20:00 -0400)]
fix bugs in ipv4 parsing
Rich Felker [Wed, 20 Apr 2011 23:15:27 +0000 (19:15 -0400)]
fix initgroups (uninitialized count passed to getgrouplist)
Rich Felker [Wed, 20 Apr 2011 23:05:59 +0000 (19:05 -0400)]
shadow password fixes: empty fields should read as -1 not 0
Rich Felker [Wed, 20 Apr 2011 19:55:58 +0000 (15:55 -0400)]
namespace fixes for sys/mman.h
Rich Felker [Wed, 20 Apr 2011 19:36:15 +0000 (15:36 -0400)]
fix missing include in posix_madvise.c (compile error)
Rich Felker [Wed, 20 Apr 2011 19:25:28 +0000 (15:25 -0400)]
support posix_madvise (previous a stub)
the check against MADV_DONTNEED to because linux MADV_DONTNEED
semantics conflict dangerously with the POSIX semantics
Rich Felker [Wed, 20 Apr 2011 19:20:22 +0000 (15:20 -0400)]
add syscall wrappers for posix_fadvise, posix_fallocate
Rich Felker [Wed, 20 Apr 2011 03:42:56 +0000 (23:42 -0400)]
block cancellation in wordexp, handle more errors
Rich Felker [Wed, 20 Apr 2011 03:37:57 +0000 (23:37 -0400)]
avoid malloc of potentially-large string in wordexp
Rich Felker [Wed, 20 Apr 2011 03:09:14 +0000 (23:09 -0400)]
move some more code out of pthread_create.c
this also de-uglifies the dummy function aliasing a bit.
Rich Felker [Tue, 19 Apr 2011 17:16:59 +0000 (13:16 -0400)]
fix uninitialized waiters field in semaphores
Rich Felker [Tue, 19 Apr 2011 01:35:14 +0000 (21:35 -0400)]
dns lookups: protect against cancellation and fix incorrect error codes
Rich Felker [Tue, 19 Apr 2011 01:22:14 +0000 (21:22 -0400)]
avoid fd leak if opendir is cancelled when calloc has failed
Rich Felker [Tue, 19 Apr 2011 01:17:03 +0000 (21:17 -0400)]
protect ftw and nftw against cancellation
Rich Felker [Tue, 19 Apr 2011 01:11:23 +0000 (21:11 -0400)]
protect syslog against cancellation
these functions are allowed to be cancellation points, but then we
would have to install cleanup handlers to avoid termination with locks
held.
Rich Felker [Tue, 19 Apr 2011 00:50:37 +0000 (20:50 -0400)]
recheck cancellation disabled flag after syscall returns EINTR
we already checked before making the syscall, but it's possible that a
signal handler interrupted the blocking syscall and disabled
cancellation, and that this is the cause of EINTR. in this case, the
old behavior was testably wrong.
Rich Felker [Mon, 18 Apr 2011 22:42:34 +0000 (18:42 -0400)]
remove bogus extra logic for close cancellability
like all other syscalls, close should return to the caller if and only
if it successfully performed its action. it is necessary that the
application be able to determine whether the close succeeded.
Rich Felker [Sun, 17 Apr 2011 23:25:17 +0000 (19:25 -0400)]
fix typo in x86_64 cancellable syscall asm
Rich Felker [Sun, 17 Apr 2011 21:32:36 +0000 (17:32 -0400)]
minimal realpath implementation using /proc
clean and simple, but fails when the caller does not have permissions
to open the file for reading or when /proc is not available. i may
replace this with a full implementation later, possibly leaving this
version as an optimization to use when it works.
Rich Felker [Sun, 17 Apr 2011 21:09:41 +0000 (17:09 -0400)]
pthread_exit is not supposed to affect cancellability
if the exit was caused by cancellation, __cancel has already set these
flags anyway.
Rich Felker [Sun, 17 Apr 2011 21:06:05 +0000 (17:06 -0400)]
fix pthread_exit from cancellation handler
cancellation frames were not correctly popped, so this usage would not
only loop, but also reuse discarded and invalid parts of the stack.
Rich Felker [Sun, 17 Apr 2011 20:53:54 +0000 (16:53 -0400)]
clean up handling of thread/nothread mode, locking
Rich Felker [Sun, 17 Apr 2011 20:32:15 +0000 (16:32 -0400)]
debloat: use __syscall instead of syscall where possible
don't waste time (and significant code size due to function call
overhead!) setting errno when the result of a syscall does not matter
or when it can't fail.
Rich Felker [Sun, 17 Apr 2011 19:30:08 +0000 (15:30 -0400)]
fix bugs in cancellable syscall asm
x86_64 was just plain wrong in the cancel-flag-already-set path, and
crashing.
the more subtle error was not clearing the saved stack pointer before
returning to c code. this could result in the signal handler
misidentifying c code as the pre-syscall part of the asm, and acting
on cancellation at the wrong time, and thus resource leak race
conditions.
also, now __cancel (in the c code) is responsible for clearing the
saved sp in the already-cancelled branch. this means we have to use
call rather than jmp to ensure the stack pointer in the c will never
match what the asm saved.
Rich Felker [Sun, 17 Apr 2011 17:21:13 +0000 (13:21 -0400)]
optimize cancellation enable/disable code
the goal is to be able to use pthread_setcancelstate internally in
the implementation, whenever a function might want to use functions
which are cancellation points but avoid becoming a cancellation point
itself. i could have just used a separate internal function for
temporarily inhibiting cancellation, but the solution in this commit
is better because (1) it's one less implementation-specific detail in
functions that need to use it, and (2) application code can also get
the same benefit.
previously, pthread_setcancelstate dependend on pthread_self, which
would pull in unwanted thread setup overhead for non-threaded
programs. now, it temporarily stores the state in the global libc
struct if threads have not been initialized, and later moves it if
needed. this way we can instead use __pthread_self, which has no
dependencies and assumes that the thread register is already valid.
Rich Felker [Sun, 17 Apr 2011 16:15:55 +0000 (12:15 -0400)]
don't use pthread_once when there is no danger in race
Rich Felker [Sun, 17 Apr 2011 16:09:47 +0000 (12:09 -0400)]
fix some minor issues in cancellation handling patch
signals were wrongly left masked, and cancellability state was not
switched to disabled, during the execution of cleanup handlers.
Rich Felker [Sun, 17 Apr 2011 15:43:03 +0000 (11:43 -0400)]
overhaul pthread cancellation
this patch improves the correctness, simplicity, and size of
cancellation-related code. modulo any small errors, it should now be
completely conformant, safe, and resource-leak free.
the notion of entering and exiting cancellation-point context has been
completely eliminated and replaced with alternative syscall assembly
code for cancellable syscalls. the assembly is responsible for setting
up execution context information (stack pointer and address of the
syscall instruction) which the cancellation signal handler can use to
determine whether the interrupted code was in a cancellable state.
these changes eliminate race conditions in the previous generation of
cancellation handling code (whereby a cancellation request received
just prior to the syscall would not be processed, leaving the syscall
to block, potentially indefinitely), and remedy an issue where
non-cancellable syscalls made from signal handlers became cancellable
if the signal handler interrupted a cancellation point.
x86_64 asm is untested and may need a second try to get it right.
Rich Felker [Fri, 15 Apr 2011 16:07:26 +0000 (12:07 -0400)]
remove stupid debug code in wordexp
Rich Felker [Fri, 15 Apr 2011 16:06:34 +0000 (12:06 -0400)]
implement wordexp. first try, may be buggy. intended to be safe.
Rich Felker [Fri, 15 Apr 2011 16:04:13 +0000 (12:04 -0400)]
avoid setting errno when checking for tty
setting errno here is completely valid, but some programs, notably
busybox printf, assume that errno will not be set during output and
treat this as an error condition. in any case, skipping it slightly
reduces code size and saves time.
Rich Felker [Fri, 15 Apr 2011 03:33:46 +0000 (23:33 -0400)]
document some changes in the upcoming release
Rich Felker [Fri, 15 Apr 2011 02:06:30 +0000 (22:06 -0400)]
fix O_SYNC definition, cleanup fcntl.h
Rich Felker [Fri, 15 Apr 2011 01:50:07 +0000 (21:50 -0400)]
fix FAPPEND typo on x86_64 (previously only fixed on i386)
Rich Felker [Fri, 15 Apr 2011 01:49:22 +0000 (21:49 -0400)]
fcntl.h: move macros that do not vary between archs out of bits
Rich Felker [Fri, 15 Apr 2011 01:45:26 +0000 (21:45 -0400)]
fix broken fcntl locks on x86_64
Rich Felker [Fri, 15 Apr 2011 01:43:49 +0000 (21:43 -0400)]
make tmpfile slightly more efficient (use unlink syscall instead of remove)
Rich Felker [Thu, 14 Apr 2011 23:14:42 +0000 (19:14 -0400)]
fix typo in legacy FAPPEND definition
Rich Felker [Thu, 14 Apr 2011 20:23:31 +0000 (16:23 -0400)]
add useless type fd_mask. it's in the reserved namespace.
Rich Felker [Thu, 14 Apr 2011 19:10:50 +0000 (15:10 -0400)]
change sem_trywait algorithm so it never has to call __wake
Rich Felker [Thu, 14 Apr 2011 18:39:57 +0000 (14:39 -0400)]
cheap trick to further optimize locking normal mutexes
Rich Felker [Thu, 14 Apr 2011 16:51:00 +0000 (12:51 -0400)]
use a separate signal from SIGCANCEL for SIGEV_THREAD timers
otherwise we cannot support an application's desire to use
asynchronous cancellation within the callback function. this change
also slightly debloats pthread_create.c.
Rich Felker [Thu, 14 Apr 2011 00:47:01 +0000 (20:47 -0400)]
simplify cancellation point handling
we take advantage of the fact that unless self->cancelpt is 1,
cancellation cannot happen. so just increment it by 2 to temporarily
block cancellation. this drops pthread_create.o well under 1k.
Rich Felker [Wed, 13 Apr 2011 22:32:33 +0000 (18:32 -0400)]
simplify syslog, add vsyslog interface (nonstandard)
with datagram sockets, depending on fprintf not to flush the output
early was very fragile; the new version simply uses a small fixed-size
buffer. it could be updated to dynamic-allocate large buffers if
needed, but i can't envision any admin being happy about finding
64kb-long lines in their syslog...
Rich Felker [Wed, 13 Apr 2011 21:51:45 +0000 (17:51 -0400)]
remove useless SIGPIPE protection from syslog
per the standard, SIGPIPE is not generated for SOCK_DGRAM.
Rich Felker [Wed, 13 Apr 2011 21:24:25 +0000 (17:24 -0400)]
fix syslog (corrected SIGPIPE blocking, and using dgram instead of stream)
it actually appears the hacks to block SIGPIPE are probably not
necessary, and potentially harmful. if i can confirm this, i'll remove
them.
Rich Felker [Wed, 13 Apr 2011 20:45:43 +0000 (16:45 -0400)]
numerous fixes to sysv ipc
some of these definitions were just plain wrong, others based on
outdated ancient "non-64" versions of the kernel interface.
as much as possible has now been moved out of bits/*
these changes break abi (the old abi for these functions was wrong),
but since they were not working anyway it can hardly matter.
Rich Felker [Wed, 13 Apr 2011 20:13:49 +0000 (16:13 -0400)]
add syslog.h cruft for syslogd to use...
Rich Felker [Wed, 13 Apr 2011 19:24:26 +0000 (15:24 -0400)]
add profile for getmntent_r
Rich Felker [Wed, 13 Apr 2011 18:55:26 +0000 (14:55 -0400)]
add syscall wrapper for flock
it should be noted that flock does not mix well with standard fcntl
locking, but nonetheless some applications will attempt to use flock
instead of fcntl if both exist. options to configure or small patches
may be needed. debian maintainers have plenty of experience with this
unfortunate situation...
Rich Felker [Wed, 13 Apr 2011 18:52:23 +0000 (14:52 -0400)]
fix bug whereby getopt_long allowed mismatch in last char of option name
Rich Felker [Wed, 13 Apr 2011 17:22:19 +0000 (13:22 -0400)]
fix typos on RLIM_NLIMITS, remove _GNU_SOURCE test for it
RLIM_* is in the reserved namespace for this header
Rich Felker [Wed, 13 Apr 2011 17:16:49 +0000 (13:16 -0400)]
fix and cleanup suseconds_t/timeval stuff (broken on 64-bit)
trash in the upper 32 bits was making the kernel sleep forever in
select on 64-bit systems.
Rich Felker [Wed, 13 Apr 2011 13:39:47 +0000 (09:39 -0400)]
implement getgrouplist (for initgroups), formerly dummied-out
Rich Felker [Wed, 13 Apr 2011 13:03:22 +0000 (09:03 -0400)]
fix prototypes/signature for setgroups, etc.
Rich Felker [Wed, 13 Apr 2011 12:45:28 +0000 (08:45 -0400)]
fix incorrect GNU sighandler_t typedef
Rich Felker [Wed, 13 Apr 2011 12:36:29 +0000 (08:36 -0400)]
implement memrchr (nonstandard) and optimize strrchr in terms of it
Rich Felker [Wed, 13 Apr 2011 12:35:32 +0000 (08:35 -0400)]
add ptsname_r (nonstandard) and split ptsname (standard) to separate file
this eliminates the ugly static buffer in programs that use ptsname_r.
Rich Felker [Tue, 12 Apr 2011 21:52:14 +0000 (17:52 -0400)]
speed up threaded fork
after fork, we have a new process and the pid is equal to the tid of
the new main thread. there is no need to make two separate syscalls to
obtain the same number.
Rich Felker [Tue, 12 Apr 2011 17:36:22 +0000 (13:36 -0400)]
more changes for upcoming 0.7.8
Rich Felker [Tue, 12 Apr 2011 17:13:27 +0000 (13:13 -0400)]
optimize ntohl etc. in terms of bswap functions
we can do this without violating the namespace now that they are
macros/inline functions rather than extern functions. the motivation
is that gcc was generating giant, slow, horrible code for the old
functions, and now generates a single byte-swapping instruction.
Rich Felker [Tue, 12 Apr 2011 17:04:17 +0000 (13:04 -0400)]
move bswap functions to static inline in byteswap.h
Rich Felker [Tue, 12 Apr 2011 16:18:11 +0000 (12:18 -0400)]
fix broken bswap_32
Rich Felker [Tue, 12 Apr 2011 16:03:33 +0000 (12:03 -0400)]
utmpx.h is no longer under standards, so expose ut_exit structure
Rich Felker [Tue, 12 Apr 2011 16:01:20 +0000 (12:01 -0400)]
add some traditional aliases to stat.h
Rich Felker [Tue, 12 Apr 2011 15:50:52 +0000 (11:50 -0400)]
fix printf("%.9g", 1.1) and similar not dropping trailing zeros
Rich Felker [Tue, 12 Apr 2011 15:50:14 +0000 (11:50 -0400)]
add missing rlimit macros
Rich Felker [Mon, 11 Apr 2011 14:48:52 +0000 (10:48 -0400)]
more types cleanup
the basic idea is that the only things in alltypes.h should be types
that either vary from system to system (in practice, not just in
theoretical la-la land - this is the implementation so we choose what
constraints we want to impose on ports) or which are needed by
multiple system headers.
Rich Felker [Mon, 11 Apr 2011 14:38:00 +0000 (10:38 -0400)]
cleanup types stuff in headers, fix missing u_int*_t in sys/types.h
Rich Felker [Mon, 11 Apr 2011 05:58:14 +0000 (01:58 -0400)]
fix errno handling in scandir:
1. saved errno was not being restored, illegally clearing errno to 0.
2. no need to backup and save errno around free; it will not touch
except perhaps when the program has already invoked UB...
Rich Felker [Mon, 11 Apr 2011 05:52:23 +0000 (01:52 -0400)]
fix fputwc return value
Rich Felker [Mon, 11 Apr 2011 05:50:26 +0000 (01:50 -0400)]
remove ugly warning-suppression hack from crypt - this invokes UB!
Rich Felker [Mon, 11 Apr 2011 04:10:26 +0000 (00:10 -0400)]
update README since we now DO have a mailing list
Rich Felker [Mon, 11 Apr 2011 02:47:43 +0000 (22:47 -0400)]
add some ugly legacy type names in sys/types.h (u_char etc.)
Rich Felker [Mon, 11 Apr 2011 02:46:46 +0000 (22:46 -0400)]
add legacy BSD-style timer*() macros in sys/time.h
Rich Felker [Sun, 10 Apr 2011 22:32:59 +0000 (18:32 -0400)]
add missing UTIME_* macros in sys/stat.h
Rich Felker [Sun, 10 Apr 2011 22:27:47 +0000 (18:27 -0400)]
add missing float.h macros
actually FLT_ROUNDS needs to expand to a static inline function that
obtains the current rounding mode and returns it, but that will be
added later with fenv.h stuff.
Rich Felker [Sat, 9 Apr 2011 06:26:55 +0000 (02:26 -0400)]
run pthread tsd destructors when a timer thread pretends to exit
Rich Felker [Sat, 9 Apr 2011 06:23:33 +0000 (02:23 -0400)]
greatly improve SIGEV_THREAD timers
calling pthread_exit from, or pthread_cancel on, the timer callback
thread will no longer destroy the timer.
Rich Felker [Sat, 9 Apr 2011 05:32:38 +0000 (01:32 -0400)]
prepare notes for 0.7.8 release
Rich Felker [Sat, 9 Apr 2011 05:17:55 +0000 (01:17 -0400)]
work around a nasty bug in linux readv syscall
according to posix, readv "shall be equivalent to read(), except..."
that it places the data into the buffers specified by the iov array.
however on linux, when reading from a terminal, each iov element
behaves almost like a separate read. this means that if the first iov
exactly satisfied the request (e.g. a length-one read of '\n') and the
second iov is nonzero length, the syscall will block again after
getting the blank line from the terminal until another line is read.
simply put, entering a single blank line becomes impossible.
the solution, fortunately, is simple. whenever the buffer size is
nonzero, reduce the length of the requested read by one byte and let
the last byte go through the buffer. this way, readv will already be
in the second (and last) iov, and won't re-block on the second iov.
Rich Felker [Fri, 8 Apr 2011 16:16:24 +0000 (12:16 -0400)]
better fix sysconf pthread stack min
Rich Felker [Fri, 8 Apr 2011 16:15:37 +0000 (12:15 -0400)]
consistency with pthread stack min in limits.h
Rich Felker [Fri, 8 Apr 2011 15:56:52 +0000 (11:56 -0400)]
fix broken sigsetjmp on x86_64
Rich Felker [Fri, 8 Apr 2011 13:24:19 +0000 (09:24 -0400)]
workaround broken msghdr struct on 64bit linux
POSIX clearly specifies the type of msg_iovlen and msg_controllen, and
Linux ignores it and makes them both size_t instead. to work around
this we add padding (instead of just using the wrong types like glibc
does), but we also need to patch-up the struct before passing it to
the kernel in case the caller did not zero-fill it.
if i could trust the kernel to just ignore the upper 32 bits, this
would not be necessary, but i don't think it will ignore them...
Rich Felker [Fri, 8 Apr 2011 13:21:51 +0000 (09:21 -0400)]
fix ipv6 address printing: 2001 appeared as 201, etc.
Rich Felker [Fri, 8 Apr 2011 12:49:28 +0000 (08:49 -0400)]
fix broken dns response parsing code that made most ipv6 lookups fail
Rich Felker [Fri, 8 Apr 2011 12:14:28 +0000 (08:14 -0400)]
return the requested string as the "canonical name" for numeric addresses
previously NULL was returned in ai_canonname, resulting in crashes in
some callers. this behavior was incorrect. note however that the new
behavior differs from glibc, which performs reverse dns lookups. POSIX
is very clear that a reverse DNS lookup must not be performed for
numeric addresses.
Rich Felker [Fri, 8 Apr 2011 03:18:12 +0000 (23:18 -0400)]
fix uninitialized variables in dns lookup code
Rich Felker [Fri, 8 Apr 2011 03:13:47 +0000 (23:13 -0400)]
fix bug in TRE found by clang (typo && instead of &)
Rich Felker [Thu, 7 Apr 2011 20:19:30 +0000 (16:19 -0400)]
fix misplaced *'s in string functions (harmless)
Rich Felker [Thu, 7 Apr 2011 20:13:47 +0000 (16:13 -0400)]
fix broken unsigned comparison in wcstoumax
Rich Felker [Thu, 7 Apr 2011 20:10:44 +0000 (16:10 -0400)]
fix breakage due to converting a return type to size_t in iconv...
Rich Felker [Thu, 7 Apr 2011 00:43:39 +0000 (20:43 -0400)]
fixed crash in new rsyscall (failure to set sa_flags for signal handler)
Rich Felker [Thu, 7 Apr 2011 00:32:53 +0000 (20:32 -0400)]
consistency: change all remaining syscalls to use SYS_ rather than __NR_ prefix
Rich Felker [Thu, 7 Apr 2011 00:27:07 +0000 (20:27 -0400)]
move rsyscall out of pthread_create module
this is something of a tradeoff, as now set*id() functions, rather
than pthread_create, are what pull in the code overhead for dealing
with linux's refusal to implement proper POSIX thread-vs-process
semantics. my motivations are:
1. it's cleaner this way, especially cleaner to optimize out the
rsyscall locking overhead from pthread_create when it's not needed.
2. it's expected that only a tiny number of core system programs will
ever use set*id() functions, whereas many programs may want to use
threads, and making thread overhead tiny is an incentive for "light"
programs to try threads.
Rich Felker [Wed, 6 Apr 2011 23:47:50 +0000 (19:47 -0400)]
pthread exit stuff: don't bother setting errno when we won't check it.
Rich Felker [Wed, 6 Apr 2011 23:46:46 +0000 (19:46 -0400)]
fix rsyscall handler: must not clobber errno from signal context