OSDN Git Service
Richard Smith [Sun, 20 Apr 2014 22:10:16 +0000 (22:10 +0000)]
More C++ification.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206722
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 21:56:02 +0000 (21:56 +0000)]
Remove some more C junk from these files.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206721
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 21:52:16 +0000 (21:52 +0000)]
Don't provide two different definitions of ModRMDecision, OpcodeDecision, and ContextDecision in different source files (depending on #define magic).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206720
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 21:35:26 +0000 (21:35 +0000)]
Don't define llvm::X86Disassembler::InstructionSpecifier in different ways in
different source files.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206719
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 21:28:33 +0000 (21:28 +0000)]
Maybe if I touch this file the buildbots will actually rerun configure like they need to...
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206718
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 21:07:34 +0000 (21:07 +0000)]
What year is it! This file has no reason to be written in C, and has doubly no
reason to expose a global symbol 'decodeInstruction' nor to pollute the global
scope with a bunch of external linkage entities (some of which conflict with
others elsewhere in LLVM).
This is just the initial transition to C++; more cleanups to follow.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206717
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Sun, 20 Apr 2014 21:05:36 +0000 (21:05 +0000)]
[Mips] Add more special values for the st_other field in the symbol
table entry for MIPS.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206716
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Sun, 20 Apr 2014 21:05:30 +0000 (21:05 +0000)]
[C++11] Range-based loop simplification.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206715
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Smith [Sun, 20 Apr 2014 20:26:39 +0000 (20:26 +0000)]
Fix redefinition of default argument, found by modules build. It's not
entirely clear whether this should be valid with modules enabled, but the fixed
code is cleaner regardless.
Also fix a TU-local type that accidentally had external linkage.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206714
91177308-0d34-0410-b5e6-
96231b3b80d8
Alp Toker [Sat, 19 Apr 2014 23:56:35 +0000 (23:56 +0000)]
Remove some empty statements
Cleanup only.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206710
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Sat, 19 Apr 2014 23:42:50 +0000 (23:42 +0000)]
ProfileData: Remove an extra semicolon
Spotted by Nick Lewycky in review, thanks!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206708
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Sat, 19 Apr 2014 22:46:00 +0000 (22:46 +0000)]
Revert "blockfreq: Rewrite BlockFrequencyInfoImpl"
This reverts commit r206704, as expected.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206707
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Sat, 19 Apr 2014 22:45:44 +0000 (22:45 +0000)]
Revert "blockfreq: Temporarily turn on -debug-only=block-freq"
This reverts commit r206705, as planned.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206706
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Sat, 19 Apr 2014 22:40:56 +0000 (22:40 +0000)]
blockfreq: Temporarily turn on -debug-only=block-freq
These tests fail after my BlockFrequencyInfo rewrite on two buildbots
[1][2]. I can't reproduce it locally, so I'm temporarily turning on
-debug-only=block-freq so I can find the problem.
[1]: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/1860
[2]: http://llvm-amd64.freebsd.your.org/b/builders/clang-i386-freebsd/builds/18477
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206705
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Sat, 19 Apr 2014 22:34:26 +0000 (22:34 +0000)]
Reapply "blockfreq: Rewrite BlockFrequencyInfoImpl"
This reverts commit r206677, reapplying my BlockFrequencyInfo rewrite.
I've done a careful audit, added some asserts, and fixed a couple of
bugs (unfortunately, they were in unlikely code paths). There's a small
chance that this will appease the failing bots [1][2]. (If so, great!)
If not, I have a follow-up commit ready that will temporarily add
-debug-only=block-freq to the two failing tests, allowing me to compare
the code path between what the failing bots and what my machines (and
the rest of the bots) are doing. Once I've triggered those builds, I'll
revert both commits so the bots go green again.
[1]: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/1816
[2]: http://llvm-amd64.freebsd.your.org/b/builders/clang-i386-freebsd/builds/18445
<rdar://problem/
14292693>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206704
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Sat, 19 Apr 2014 13:47:43 +0000 (13:47 +0000)]
Patch by Vadim Chugunov
Win64 stack unwinder gets confused when execution flow "falls through" after
a call to 'noreturn' function. This fixes the "missing epilogue" problem by
emitting a trap instruction for IR 'unreachable' on x86_x64-pc-windows.
A secondary use for it would be for anyone wanting to make double-sure that
'noreturn' functions, indeed, do not return.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206684
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Sat, 19 Apr 2014 05:40:09 +0000 (05:40 +0000)]
Patch by Ray Donnelly to print register names instead of numbers.
http://reviews.llvm.org/D3422
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206683
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Sat, 19 Apr 2014 00:50:15 +0000 (00:50 +0000)]
Add parens to appease GCC warning.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206678
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Sat, 19 Apr 2014 00:42:46 +0000 (00:42 +0000)]
Revert "blockfreq: Rewrite BlockFrequencyInfoImpl" (#2)
This reverts commit r206666, as planned.
Still stumped on why the bots are failing. Sanitizer bots haven't
turned anything up. If anyone can help me debug either of the failures
(referenced in r206666) I'll owe them a beer. (In the meantime, I'll be
auditing my patch for undefined behaviour.)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206677
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Sat, 19 Apr 2014 00:33:15 +0000 (00:33 +0000)]
OnDiskHashTable: Audit types and use offset_type consistently
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206675
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Sat, 19 Apr 2014 00:33:12 +0000 (00:33 +0000)]
ProfileData: Avoid UB when reading
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206674
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 23:50:07 +0000 (23:50 +0000)]
OnDiskHashTable: Fix a think-o with offset_type
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206672
91177308-0d34-0410-b5e6-
96231b3b80d8
Nick Lewycky [Fri, 18 Apr 2014 23:32:28 +0000 (23:32 +0000)]
Check whether functions have any lines associated before emitting coverage info for them. This isn't just a size/time saving, gcov may crash on these.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206671
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 23:25:35 +0000 (23:25 +0000)]
llvm-profdata: Avoid writing to /dev/null in tests
We fseek on our output file in llvm-profdata, which errors on some
systems. Avoid getting into the situation by writing to /dev/null
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206670
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Fri, 18 Apr 2014 23:06:39 +0000 (23:06 +0000)]
Change the ARM assembler to require a :lower16: or :upper16 on non-constant
expressions for mov instructions instead of silently truncating by default.
For the ARM assembler, we want to avoid misleadingly allowing something
like "mov r0, <symbol>" especially when we turn it into a movw and the
expression <symbol> does not have a :lower16: or :upper16" as part of the
expression. We don't want the behavior of silently truncating, which can be
unexpected and lead to bugs that are difficult to find since this is an easy
mistake to make.
This does change the previous behavior of llvm but actually matches an
older gnu assembler that would not allow this but print less useful errors
of like “invalid constant (0x927c0) after fixup” and “unsupported relocation on
symbol foo”. The error for llvm is "immediate expression for mov requires
:lower16: or :upper16" with correct location information on the operand
as shown in the added test cases.
rdar://
12342160
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206669
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 23:05:31 +0000 (23:05 +0000)]
test: Add extra run lines to investigate an error on the bots
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206668
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 22:30:03 +0000 (22:30 +0000)]
Reapply "blockfreq: Rewrite BlockFrequencyInfoImpl" (#2)
This reverts commit r206628, reapplying r206622 (and r206626).
Two tests are failing only on buildbots [1][2]: i.e., I can't reproduce
on Darwin, and Chandler can't reproduce on Linux. Asan and valgrind
don't tell us anything, but we're hoping the msan bot will catch it.
So, I'm applying this again to get more feedback from the bots. I'll
leave it in long enough to trigger builds in at least the sanitizer
buildbots (it was failing for reasons unrelated to my commit last time
it was in), and hopefully a few others.... and then I expect to revert a
third time.
[1]: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/1816
[2]: http://llvm-amd64.freebsd.your.org/b/builders/clang-i386-freebsd/builds/18445
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206666
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 18 Apr 2014 22:22:44 +0000 (22:22 +0000)]
[llvm-symbolizer] Print file/line for a PC even if there is no DIE describing it.
This is important for symbolizing executables with debug info in
unavailable .dwo files. Even if all DIE entries are missing, we can
still symbolize an address: function name can be fetched from symbol table,
and file/line info can be fetched from line table.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206665
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 22:00:22 +0000 (22:00 +0000)]
ProfileData: Don't forward declare ComputeHash and make it static inline
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206663
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 18 Apr 2014 21:52:26 +0000 (21:52 +0000)]
Compress debug sections only when beneficial.
Both ZLIB and the debug info compressed section header ("ZLIB" + the
size of the uncompressed data) take some constant overhead so in some
cases the compressed data is actually larger than the uncompressed data.
In these cases, just don't compress or rename the section at all.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206659
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 21:48:40 +0000 (21:48 +0000)]
ProfileData: Add support for the indexed instrprof format
This adds support for an indexed instrumentation based profiling
format, which is just a small header and an on disk hash table. This
format will be used by clang's -fprofile-instr-use= for PGO.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206656
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 18 Apr 2014 21:45:25 +0000 (21:45 +0000)]
Added Sphinx documentation generation to CMake build system.
The option LLVM_ENABLE_SPHINX option enables the "docs-llvm-html",
"docs-llvm-man" targets but does not build them by default. The
following CMake options have been added that control what targets are
made available
SPHINX_OUTPUT_HTML
SPHINX_OUTPUT_MAN
If LLVM_BUILD_DOCS is enabled then the enabled docs-llvm-* targets will
be built by default and if ``make install`` is run then docs-llvm-html
and docs-llvm-man will be installed (tested on Linux only).
The add_sphinx_target function is in its own file so it can be included
by other projects that use Sphinx for their documentation.
Patch by Daniel Liew <daniel.liew@imperial.ac.uk>!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206655
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 18 Apr 2014 21:36:39 +0000 (21:36 +0000)]
[DWARF parser] Turn DILineInfo into a struct.
Immutable DILineInfo doesn't bring any benefits and complicates
code. Also, use std::string instead of SmallString<16> for file
and function names - their length can vary significantly.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206654
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 18 Apr 2014 21:24:12 +0000 (21:24 +0000)]
Update the fragments of symbols in compressed sections.
While unnamed relocations are already cached in side tables in
ELFObjectWriter::RecordRelocation, symbols still need their fragments
updated to refer to the newly compressed fragment (even if that fragment
isn't big enough to fit the offset). Even though we only create
temporary symbols in debug info sections this comes up in 32 bit builds
where even temporary symbols in mergeable sections (such as debug_str)
have to be emitted as named symbols.
I tried a few other ways to do this but they all didn't work for various
reasons:
1) Canonicalize the MCSymbolData in RecordRelocation, nulling out the
Fragment (so it didn't have to be updated by CompressDebugSection). This
doesn't work because some code relies on symbols having fragments to
indicate that they're defined, I think.
2) Canonicalize the MCSymbolData in RecordRelocation to be "first
fragment + absolute offset" so it would be cheaper to just test and
update the fragment in CompressDebugSections. This doesn't work because
the offset computed in RecordRelocation isn't that of the symbol's
fragment, it's the passed in fragment (I haven't figured out what that
fragment is - perhaps it's the location where the relocation is to be
written). And if the fragment offset has to be computed only for this
use we might as well just do it when we need to, in
CompressDebugSection.
I also added an assert to help catch this a bit more clearly, even
though it is UB. The test case improvements would either assert fail
and/or valgrind vail without the fix, even if they wouldn't necessarily
fail the FileCheck output.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206653
91177308-0d34-0410-b5e6-
96231b3b80d8
Chad Rosier [Fri, 18 Apr 2014 21:22:04 +0000 (21:22 +0000)]
[ARM64] Ports the Cortex-A53 Machine Model description from AArch64.
Summary:
This port includes the rudimentary latencies that were provided for
the Cortex-A53 Machine Model in the AArch64 backend. It also changes
the SchedAlias for COPY in the Cyclone model to an explicit
WriteRes mapping to avoid conflicts in other subtargets.
Differential Revision: http://reviews.llvm.org/D3427
Patch by Dave Estes <cestes@codeaurora.org>!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206652
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 18 Apr 2014 21:19:06 +0000 (21:19 +0000)]
Remove -simplify-libcalls pass form Passes documentation
This pass was removed in r184459.
Also added note that the InstCombine pass does library call
simplification.
Patch slightly modified from one by Daniel Liew
<daniel.liew@imperial.ac.uk>!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206650
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Fri, 18 Apr 2014 21:10:11 +0000 (21:10 +0000)]
Expanded test for x86-pc-windows-gnu and x86_64-pc-windows-gnu environments.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206649
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 18 Apr 2014 20:44:16 +0000 (20:44 +0000)]
[LCG] Fix the bugs that Ben pointed out in code review (and the MSan bot
caught). Sad that we don't have warnings for these things, but bleh, no
idea how to fix that.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206646
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 20:39:46 +0000 (20:39 +0000)]
OnDiskHashTable: Expect the Info type to declare the offset type
This changes the on-disk hash to get the type to use for offsets from
the Info type, so that clients can be more flexible with the size of
table they support.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206643
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 20:39:43 +0000 (20:39 +0000)]
OnDiskHashTable: Expect the Info type to declare the hash size
This changes the on-disk hash to get the size of a hash value from the
Info type, so that clients can be more flexible with the types of hash
they use.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206642
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 18 Apr 2014 20:30:27 +0000 (20:30 +0000)]
[DWARF parser] Respect address ranges specified in compile unit DIE.
When address ranges for compile unit are specified in compile unit DIE
itself, there is no need to collect ranges from children subprogram DIEs.
This change speeds up llvm-symbolizer on Clang-produced binaries with
full debug info. For instance, symbolizing a first address in a 1Gb binary
is now 2x faster (1s vs. 2s).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206641
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 19:48:03 +0000 (19:48 +0000)]
Remove a couple of redundant copies of SmallVector::operator==.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206635
91177308-0d34-0410-b5e6-
96231b3b80d8
Adam Nemet [Fri, 18 Apr 2014 19:44:16 +0000 (19:44 +0000)]
[X86] Improve buildFromShuffleMostly for AVX
For a 256-bit BUILD_VECTOR consisting mostly of shuffles of 256-bit vectors,
both the BUILD_VECTOR and its operands may need to be legalized in multiple
steps. Consider:
(v8f32 (BUILD_VECTOR (extract_vector_elt (v8f32 %vreg0,) Constant<1>),
(extract_vector_elt %vreg0, Constant<2>),
(extract_vector_elt %vreg0, Constant<3>),
(extract_vector_elt %vreg0, Constant<4>),
(extract_vector_elt %vreg0, Constant<5>),
(extract_vector_elt %vreg0, Constant<6>),
(extract_vector_elt %vreg0, Constant<7>),
%vreg1))
a. We can't build a 256-bit vector efficiently so, we need to split it into
two 128-bit vecs and combine them with VINSERTX128.
b. Operands like (extract_vector_elt (v8f32 %vreg0), Constant<7>) needs to be
split into a VEXTRACTX128 and a further extract_vector_elt from the
resulting 128-bit vector.
c. The extract_vector_elt from b. is lowered into a shuffle to the first
element and a movss.
Depending on the order in which we legalize the BUILD_VECTOR and its
operands[1], buildFromShuffleMostly may be faced with:
(v4f32 (BUILD_VECTOR (extract_vector_elt
(vector_shuffle<1,u,u,u> (extract_subvector %vreg0, Constant<4>), undef),
Constant<0>),
(extract_vector_elt
(vector_shuffle<2,u,u,u> (extract_subvector %vreg0, Constant<4>), undef),
Constant<0>),
(extract_vector_elt
(vector_shuffle<3,u,u,u> (extract_subvector %vreg0, Constant<4>), undef),
Constant<0>),
%vreg1))
In order to figure out the underlying vector and their identity we need to see
through the shuffles.
[1] Note that the order in which operations and their operands are legalized is
only guaranteed in the first iteration of LegalizeDAG.
Fixes <rdar://problem/
16296956>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206634
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 19:01:53 +0000 (19:01 +0000)]
DebugInfo: Remove some initializer lists to make MSVC happy again.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206632
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 18 Apr 2014 18:24:25 +0000 (18:24 +0000)]
Add range access to MCAssembler's symbol collection.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206631
91177308-0d34-0410-b5e6-
96231b3b80d8
Reid Kleckner [Fri, 18 Apr 2014 18:19:18 +0000 (18:19 +0000)]
Update comment in LLVMBitCodes.h to reflect the actual bitcode record
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206630
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 18 Apr 2014 18:08:31 +0000 (18:08 +0000)]
Fix uint -> size_t conversion warning.
This warning is disabled for the LLVM build,
but external users of the header can still
run into this.
Patch by Ke Bai
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206629
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 17:56:08 +0000 (17:56 +0000)]
Revert "blockfreq: Rewrite BlockFrequencyInfoImpl" (#2)
This reverts commit r206622 and the MSVC fixup in r206626.
Apparently the remotely failing tests are still failing, despite my
attempt to fix the nondeterminism in r206621.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206628
91177308-0d34-0410-b5e6-
96231b3b80d8
Greg Fitzgerald [Fri, 18 Apr 2014 17:39:50 +0000 (17:39 +0000)]
Fixed llvm-build when no targets are enabled
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206627
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 17:38:01 +0000 (17:38 +0000)]
Fixing MSVC after r206622?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206626
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Fri, 18 Apr 2014 17:35:08 +0000 (17:35 +0000)]
Better comments to explain buffered/unbuffered processor resources.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206625
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 18 Apr 2014 17:25:46 +0000 (17:25 +0000)]
[DWARF parser] Refactor fetching DIE address ranges.
Add a helper method to get address ranges specified in a DIE
(either by DW_AT_low_pc/DW_AT_high_pc, or by DW_AT_ranges). Use it
to untangle and simplify the code.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206624
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 17:22:25 +0000 (17:22 +0000)]
Reapply "blockfreq: Rewrite BlockFrequencyInfoImpl"
This reverts commit r206556, effectively reapplying commit r206548 and
its fixups in r206549 and r206550.
In an intervening commit I've added target triples to the tests that
were failing remotely [1] (but passing locally). I'm hoping the mystery
is solved? I'll revert this again if the tests are still failing
remotely.
[1]: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/1816
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206622
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 17:22:19 +0000 (17:22 +0000)]
Add some target triples for better determinism
These tests were failing on some buildbots after r206548 (reverted in
r206556), but passing locally.
They were missing target triples, so maybe that's the problem?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206621
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 16:57:01 +0000 (16:57 +0000)]
LineIterator: Add DataTypes.h for int64_t on MSVC.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206617
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 16:46:29 +0000 (16:46 +0000)]
Add some missing includes for various standard library implementations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206616
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 16:36:15 +0000 (16:36 +0000)]
Make the copy member of StringRef/ArrayRef generic wrt allocators.
Doesn't make sense to restrict this to BumpPtrAllocator. While there
replace an explicit loop with std::equal. Some standard libraries know
how to compile this down to a ::memcmp call if possible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206615
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 14:54:53 +0000 (14:54 +0000)]
AArch64/ARM64: add more NEON tests.
Mostly no testing this time, since they were just wrangling
target-specific intrinsics.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206613
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 14:54:51 +0000 (14:54 +0000)]
Allocator: Remove ReferenceAdder hack.
This was a workaround for compilers that had issues with reference
collapsing.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206612
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 14:54:46 +0000 (14:54 +0000)]
ARM64: disable generation of .loh directives outside MachO.
Part of PR19455.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206611
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 14:54:41 +0000 (14:54 +0000)]
ARM64: don't emit .subsections_via_symbols on ELF.
Part of PR19455.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206610
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 14:54:35 +0000 (14:54 +0000)]
ARM64: add extra NEG pattern.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206609
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 13:16:55 +0000 (13:16 +0000)]
AArch64/ARM64: port more AArch64 tests to ARM64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206592
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 13:16:42 +0000 (13:16 +0000)]
AArch64/ARM64: add non-scalar lowering for more FCVT operations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206591
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 12:50:58 +0000 (12:50 +0000)]
AArch64/ARM64: improve spotting of EXT instructions from VECTOR_SHUFFLE.
We couldn't cope if the first mask element was UNDEF before, which
isn't ideal.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206588
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Fri, 18 Apr 2014 12:17:20 +0000 (12:17 +0000)]
[msan] Add -msan-instrumentation-with-call-threshold.
This flag replaces inline instrumentation for checks and origin stores with
calls into MSan runtime library. This is a workaround for PR17409.
Disabled by default.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206585
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 18 Apr 2014 11:02:33 +0000 (11:02 +0000)]
[LCG] Remove all of the complexity stemming from supporting copying.
Reality is that we're never going to copy one of these. Supporting this
was becoming a nightmare because nothing even causes it to compile most
of the time. Lots of subtle errors built up that wouldn't have been
caught by any "normal" testing.
Also, make the move assignment actually work rather than the bogus swap
implementation that would just infloop if used. As part of that, factor
out the graph pointer updates into a helper to share between move
construction and move assignment.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206583
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 18 Apr 2014 11:02:29 +0000 (11:02 +0000)]
[Allocator] Fix an obvious think-o with the move assignment
implementation of the SpecificBumpPtrAllocator -- we have to actually
move the subobject. =] Noticed when using this code more directly.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206582
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 18 Apr 2014 10:50:32 +0000 (10:50 +0000)]
[LCG] Add support for building persistent and connected SCCs to the
LazyCallGraph. This is the start of the whole point of this different
abstraction, but it is just the initial bits. Here is a run-down of
what's going on here. I'm planning to incorporate some (or all) of this
into comments going forward, hopefully with better editing and wording.
=]
The crux of the problem with the traditional way of building SCCs is
that they are ephemeral. The new pass manager however really needs the
ability to associate analysis passes and results of analysis passes with
SCCs in order to expose these analysis passes to the SCC passes. Making
this work is kind-of the whole point of the new pass manager. =]
So, when we're building SCCs for the call graph, we actually want to
build persistent nodes that stick around and can be reasoned about
later. We'd also like the ability to walk the SCC graph in more complex
ways than just the traditional postorder traversal of the current CGSCC
walk. That means that in addition to being persistent, the SCCs need to
be connected into a useful graph structure.
However, we still want the SCCs to be formed lazily where possible.
These constraints are quite hard to satisfy with the SCC iterator. Also,
using that would bypass our ability to actually add data to the nodes of
the call graph to facilite implementing the Tarjan walk. So I've
re-implemented things in a more direct and embedded way. This
immediately makes it easy to get the persistence and connectivity
correct, and it also allows leveraging the existing nodes to simplify
the algorithm. I've worked somewhat to make this implementation more
closely follow the traditional paper's nomenclature and strategy,
although it is still a bit obtuse because it isn't recursive, using
an explicit stack and a tail call instead, and it is interruptable,
resuming each time we need another SCC.
The other tricky bit here, and what actually took almost all the time
and trials and errors I spent building this, is exactly *what* graph
structure to build for the SCCs. The naive thing to build is the call
graph in its newly acyclic form. I wrote about 4 versions of this which
did precisely this. Inevitably, when I experimented with them across
various use cases, they became incredibly awkward. It was all
implementable, but it felt like a complete wrong fit. Square peg, round
hole. There were two overriding aspects that pushed me in a different
direction:
1) We want to discover the SCC graph in a postorder fashion. That means
the root node will be the *last* node we find. Using the call-SCC DAG
as the graph structure of the SCCs results in an orphaned graph until
we discover a root.
2) We will eventually want to walk the SCC graph in parallel, exploring
distinct sub-graphs independently, and synchronizing at merge points.
This again is not helped by the call-SCC DAG structure.
The structure which, quite surprisingly, ended up being completely
natural to use is the *inverse* of the call-SCC DAG. We add the leaf
SCCs to the graph as "roots", and have edges to the caller SCCs. Once
I switched to building this structure, everything just fell into place
elegantly.
Aside from general cleanups (there are FIXMEs and too few comments
overall) that are still needed, the other missing piece of this is
support for iterating across levels of the SCC graph. These will become
useful for implementing #2, but they aren't an immediate priority.
Once SCCs are in good shape, I'll be working on adding mutation support
for incremental updates and adding the pass manager that this analysis
enables.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206581
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Fri, 18 Apr 2014 10:45:33 +0000 (10:45 +0000)]
X86: Pattern match scalar loads + vcvtph2ps into just vcvtph2ps.
vcvtph2ps only reads the lower 64 bits of the address passed to the
intrinsic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206579
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Fri, 18 Apr 2014 09:35:51 +0000 (09:35 +0000)]
Revert r206565 (and r206566 which updated tests).
This commit was attributed to a different person from the person who
posted the patch to the list, and the person who posted it the list
claimed when they did that they were not the author, but that the author
was yet a third person. I don't know what is going on here, but
reverting until the attribution is clear and the author has explicitly
contributed the patch.
Also, the review hasn't really involved any of the MC maintainers and
that seems questionable too.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206576
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:31 +0000 (09:31 +0000)]
AArch64/ARM64: port atomics test to ARM64.
Covers quite a few extra instructions (like any of the max/min ones
which were broken until recently on ARM64).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206575
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:27 +0000 (09:31 +0000)]
AArch64/ARM64: spot a greater variety of concat_vector operations.
Code mostly copied from AArch64, just tidied up a trifle and plumbed
into the ARM64 way of doing things.
This also enables the AArch64 tests which inspired the previous
untested commits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206574
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:20 +0000 (09:31 +0000)]
ARM64: implement cunning optimisation from AArch64
A vector extract followed by a dup can become a single instruction even if the
types don't match. AArch64 handled this in ISelLowering, but a few reasonably
simple patterns can take care of it in TableGen, so that's where I've put it.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206573
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:15 +0000 (09:31 +0000)]
ARM64: spot a vector_shuffle that maps to INS and expand.
Tests will be coming very shortly when all the optimisations needed to
support AArch64's neon-copy.ll file are committed.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206572
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:11 +0000 (09:31 +0000)]
ARM64: nick some AArch64 patterns for extract/insert -> INS.
Tests will be committed shortly when all optimisations needed to
support AArch64's neon-copy.ll file are supported.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206571
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:07 +0000 (09:31 +0000)]
AArch64/ARM64: emit all vector FP comparisons as such.
ARM64 was scalarizing some vector comparisons which don't quite map to
AArch64's compare and mask instructions. AArch64's approach of sacrificing a
little efficiency to emulate them with the limited set available was better, so
I ported it across.
More "inspired by" than copy/paste since the backend's internal expectations
were a bit different, but the tests were invaluable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206570
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:31:01 +0000 (09:31 +0000)]
AArch64/ARM64: port BSL logic from AArch64 & enable test.
I enhanced it a little in the process. The decision shouldn't really be beased
on whether a BUILD_VECTOR is a splat: any set of constants will do the job
provided they're related in the correct way.
Also, the BUILD_VECTOR could be any operand of the incoming AND nodes, so it's
best to check for all 4 possibilities rather than assuming it'll be the RHS.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206569
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Fri, 18 Apr 2014 09:30:52 +0000 (09:30 +0000)]
AArch64/ARM64: copy byval implementation from AArch64.
It's not actually used to handle C or C++ ABI rules on ARM64, but could well be
emitted by other language front-ends, so it's as well to have a sensible
implementation.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206568
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Fri, 18 Apr 2014 09:05:50 +0000 (09:05 +0000)]
Add missing config file for newly added test case introduced by r206563.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206567
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Fri, 18 Apr 2014 08:50:09 +0000 (08:50 +0000)]
Updated test with register names following r206565.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206566
91177308-0d34-0410-b5e6-
96231b3b80d8
Yaron Keren [Fri, 18 Apr 2014 08:03:38 +0000 (08:03 +0000)]
Patch by Ray Donnelly.
Emit WIN64 SEH registers by name instead of just number.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206565
91177308-0d34-0410-b5e6-
96231b3b80d8
Kostya Serebryany [Fri, 18 Apr 2014 08:02:42 +0000 (08:02 +0000)]
[asan] one more workaround for PR17409: don't do BB-level coverage instrumentation if there are more than N (=1500) basic blocks. This makes ASanCoverage work on libjpeg_turbo/jchuff.c used by Chrome, which has 1824 BBs
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206564
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Fri, 18 Apr 2014 07:57:54 +0000 (07:57 +0000)]
This commit allows vectorized loops to be unrolled by a factor of 2 for AArch64.
A new test case is also added for ARM64.
Patched by Z.Zheng
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206563
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 18 Apr 2014 07:40:20 +0000 (07:40 +0000)]
R600: Minor cleanups.
Fix indentation, better line wrapping, unused includes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206562
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Fri, 18 Apr 2014 06:48:23 +0000 (06:48 +0000)]
[ExecutionEngine] Allow JIT clients to enable/disable module verification.
Previously module verification was always enabled, with no way to turn it off.
As of this commit, module verification is on by default in Debug builds, and off
by default in release builds. The default behaviour can be overridden by calling
setVerifyModules(bool) on the JIT instance (this works for both the old JIT, and
MCJIT).
<rdar://problem/
16150008>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206561
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Fri, 18 Apr 2014 05:58:09 +0000 (05:58 +0000)]
This is one of the optimizations ported from ARM64 to AArch64 to address the performance gap between these two back ends. The test case newly added for AArch64 already exists in ARM64.
Patched by Z.Zheng
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206559
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 18 Apr 2014 05:19:26 +0000 (05:19 +0000)]
R600/SI: Try to use scalar BFE.
Use scalar BFE with constant shift and offset when possible.
This is complicated by the fact that the scalar version packs
the two operands of the vector version into one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206558
91177308-0d34-0410-b5e6-
96231b3b80d8
Jiangning Liu [Fri, 18 Apr 2014 03:58:38 +0000 (03:58 +0000)]
This commit enables unaligned memory accesses of vector types on AArch64 back end. This should boost vectorized code performance.
Patched by Z. Zheng
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206557
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 02:17:43 +0000 (02:17 +0000)]
Revert "blockfreq: Rewrite BlockFrequencyInfoImpl"
This reverts commits r206548, r206549 and r206549.
There are some unit tests failing that aren't failing locally [1], so
reverting until I have time to investigate.
[1]: http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/1816
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206556
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Fri, 18 Apr 2014 02:10:26 +0000 (02:10 +0000)]
OnDiskHashTable: Provide iterator_range for keys and data
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206555
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 02:10:09 +0000 (02:10 +0000)]
blockfreq: Really fix r206548 (and r206549)
Turns out this code is dead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206554
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 18 Apr 2014 02:09:07 +0000 (02:09 +0000)]
c++11: Tidy up tblgen w/ range loops.
IntrInfoEmitter cleanup.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206553
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 18 Apr 2014 02:09:04 +0000 (02:09 +0000)]
iterator access to scheduling classes
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206552
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 18 Apr 2014 02:09:02 +0000 (02:09 +0000)]
iterator_range accessor for CodeGenTarget instruction list.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206551
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 18 Apr 2014 02:08:58 +0000 (02:08 +0000)]
iterator based accessors for CodeGenInstruction operand list.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206550
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 02:06:24 +0000 (02:06 +0000)]
blockfreq: Fixing MSVC after r206548?
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206549
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 18 Apr 2014 01:57:45 +0000 (01:57 +0000)]
blockfreq: Rewrite BlockFrequencyInfoImpl
Rewrite the shared implementation of BlockFrequencyInfo and
MachineBlockFrequencyInfo entirely.
The old implementation had a fundamental flaw: precision losses from
nested loops (or very wide branches) compounded past loop exits (and
convergence points).
The @nested_loops testcase at the end of
test/Analysis/BlockFrequencyAnalysis/basic.ll is motivating. This
function has three nested loops, with branch weights in the loop headers
of 1:4000 (exit:continue). The old analysis gives non-sensical results:
Printing analysis 'Block Frequency Analysis' for function 'nested_loops':
---- Block Freqs ----
entry = 1.0
for.cond1.preheader = 1.00103
for.cond4.preheader = 5.5222
for.body6 = 18095.19995
for.inc8 = 4.52264
for.inc11 = 0.00109
for.end13 = 0.0
The new analysis gives correct results:
Printing analysis 'Block Frequency Analysis' for function 'nested_loops':
block-frequency-info: nested_loops
- entry: float = 1.0, int = 8
- for.cond1.preheader: float = 4001.0, int = 32007
- for.cond4.preheader: float =
16008001.0, int =
128064007
- for.body6: float =
64048012001.0, int =
512384096007
- for.inc8: float =
16008001.0, int =
128064007
- for.inc11: float = 4001.0, int = 32007
- for.end13: float = 1.0, int = 8
Most importantly, the frequency leaving each loop matches the frequency
entering it.
The new algorithm leverages BlockMass and PositiveFloat to maintain
precision, separates "probability mass distribution" from "loop
scaling", and uses dithering to eliminate probability mass loss. I have
unit tests for these types out of tree, but it was decided in the review
to make the classes private to BlockFrequencyInfoImpl, and try to shrink
them (or remove them entirely) in follow-up commits.
The new algorithm should generally have a complexity advantage over the
old. The previous algorithm was quadratic in the worst case. The new
algorithm is still worst-case quadratic in the presence of irreducible
control flow, but it's linear without it.
The key difference between the old algorithm and the new is that control
flow within a loop is evaluated separately from control flow outside,
limiting propagation of precision problems and allowing loop scale to be
calculated independently of mass distribution. Loops are visited
bottom-up, their loop scales are calculated, and they are replaced by
pseudo-nodes. Mass is then distributed through the function, which is
now a DAG. Finally, loops are revisited top-down to multiply through
the loop scales and the masses distributed to pseudo nodes.
There are some remaining flaws.
- Irreducible control flow isn't modelled correctly. LoopInfo and
MachineLoopInfo ignore irreducible edges, so this algorithm will
fail to scale accordingly. There's a note in the class
documentation about how to get closer. See also the comments in
test/Analysis/BlockFrequencyInfo/irreducible.ll.
- Loop scale is limited to 4096 per loop (2^12) to avoid exhausting
the 64-bit integer precision used downstream.
- The "bias" calculation proposed on llvmdev is *not* incorporated
here. This will be added in a follow-up commit, once comments from
this review have been handled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206548
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Fri, 18 Apr 2014 01:53:18 +0000 (01:53 +0000)]
R600/SI: Match sign_extend_inreg to s_sext_i32_i8 and s_sext_i32_i16
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206547
91177308-0d34-0410-b5e6-
96231b3b80d8
Paul Robinson [Fri, 18 Apr 2014 01:20:08 +0000 (01:20 +0000)]
Fix example for VS2012.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206544
91177308-0d34-0410-b5e6-
96231b3b80d8