OSDN Git Service
Peter Eisentraut [Fri, 18 Oct 2002 22:05:36 +0000 (22:05 +0000)]
Improve formatting of --help output.
Tom Lane [Fri, 18 Oct 2002 20:44:02 +0000 (20:44 +0000)]
Fix breakage that had crept into setlocale() usage: once again we've
been bit by the fact that the locale functions return pointers to
modifiable variables. I added some comments that might help us avoid
the mistake in future.
Tom Lane [Fri, 18 Oct 2002 20:33:57 +0000 (20:33 +0000)]
Make 'dummy' declarations in header files be 'extern int no_such_variable'
instead of 'extern int errno'; the latter is unsafe according to the
ANSI C standard, as well as in practice on some platforms.
Tom Lane [Fri, 18 Oct 2002 19:35:28 +0000 (19:35 +0000)]
Un-break createlang build.
Bruce Momjian [Fri, 18 Oct 2002 19:11:27 +0000 (19:11 +0000)]
Clean up for dblink autocommit OFF handling.
Bruce Momjian [Fri, 18 Oct 2002 18:41:22 +0000 (18:41 +0000)]
Update /contrib for "autocommit TO 'on'".
Create objects in public schema.
Make spacing/capitalization consistent.
Remove transaction block use for object creation.
Remove unneeded function GRANTs.
Tom Lane [Fri, 18 Oct 2002 18:26:22 +0000 (18:26 +0000)]
Improve discussion of FOR UPDATE.
Bruce Momjian [Thu, 17 Oct 2002 23:34:10 +0000 (23:34 +0000)]
Update for tables returning function, item 5.3, from Joe Conway.
Barry Lind [Thu, 17 Oct 2002 19:17:08 +0000 (19:17 +0000)]
Fix in updateable result sets to handle binding null values correctly
Patch submitted by Kris Jurka (applied with some modifications)
Modified Files:
jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
Tom Lane [Thu, 17 Oct 2002 14:53:32 +0000 (14:53 +0000)]
Fix free-slot search in PgSetResultId so it actually works.
Tom Lane [Thu, 17 Oct 2002 14:51:50 +0000 (14:51 +0000)]
Improve formatting of error message.
Barry Lind [Thu, 17 Oct 2002 05:33:52 +0000 (05:33 +0000)]
Fixed support in jdbc for 7.3 server autocommit. With these changes the
jdbc regression tests pass for both autocommit on and autocommit off
Modified Files:
jdbc/org/postgresql/jdbc1/AbstractJdbc1Connection.java
jdbc/org/postgresql/test/jdbc2/ConnectionTest.java
Bruce Momjian [Thu, 17 Oct 2002 03:58:22 +0000 (03:58 +0000)]
Add:
> o Allow copy to understand \x as hex
Peter Eisentraut [Wed, 16 Oct 2002 22:06:33 +0000 (22:06 +0000)]
Put the disk information all in one chapter.
Bruce Momjian [Wed, 16 Oct 2002 05:46:54 +0000 (05:46 +0000)]
Make pg_dump save for autocommit = off.
Bruce Momjian [Wed, 16 Oct 2002 04:38:00 +0000 (04:38 +0000)]
Fix from Joe on timeout code.
Bruce Momjian [Wed, 16 Oct 2002 03:44:28 +0000 (03:44 +0000)]
Improve appearance of SET command.
Bruce Momjian [Wed, 16 Oct 2002 03:24:09 +0000 (03:24 +0000)]
Fix script to handle autocommit = 'off' by prepending autocommit 'on' to
the start of the psql commandline. This is better than adding BEGIN/END
because it handles multiple queries well, and allows the return code for
psql to return the proper value.
Bruce Momjian [Wed, 16 Oct 2002 02:55:30 +0000 (02:55 +0000)]
Fix connection_timeout to use time() and handle timeout == 1.
Code cleanup.
Bruce Momjian [Tue, 15 Oct 2002 21:34:10 +0000 (21:34 +0000)]
Remove:
< * Rename oid2name to relfilenode2name and install by default
< * Move /contrib/oid2name to /bin, rename to relfilenode2name
Bruce Momjian [Tue, 15 Oct 2002 18:54:56 +0000 (18:54 +0000)]
Add:
> * Move /contrib/oid2name to /bin, rename to relfilenode2name
Tom Lane [Tue, 15 Oct 2002 16:44:21 +0000 (16:44 +0000)]
Fix unintentional breakage of COPY TO/FROM stdin. Mea culpa.
Tom Lane [Tue, 15 Oct 2002 16:04:17 +0000 (16:04 +0000)]
Fix Linux dynloader code for pre-HAVE_DLOPEN systems, which evidently
are still in use out there. Per report from Brendan LeFebvre.
Tom Lane [Tue, 15 Oct 2002 02:24:16 +0000 (02:24 +0000)]
Fix psql to cope with autocommit off, at least during startup.
Behavior of backslash commands (especially for large objects)
may still require some thought.
Tom Lane [Tue, 15 Oct 2002 01:48:25 +0000 (01:48 +0000)]
Fix libpq startup code to work correctly in autocommit off mode.
In passing, fix breakage for case where PGCLIENTENCODING is set in
environment.
Tom Lane [Mon, 14 Oct 2002 23:49:20 +0000 (23:49 +0000)]
Make SPI's execution of querystrings follow the rules agreed to for
command status at the interactive level. SPI_processed, etc are set
in the same way as the returned command status would have been set if
the same querystring were issued interactively. Per gripe from
Michael Paesold 25-Sep-02.
Bruce Momjian [Mon, 14 Oct 2002 22:43:45 +0000 (22:43 +0000)]
None.
Tom Lane [Mon, 14 Oct 2002 22:14:35 +0000 (22:14 +0000)]
Adjust handling of command status strings in the presence of rules,
as per recent pghackers discussions. initdb forced due to change in
fields of stored Query nodes.
Tom Lane [Mon, 14 Oct 2002 22:12:49 +0000 (22:12 +0000)]
Add missing entries for bit<->int4 and bit<->int8 conversions.
Peter Eisentraut [Mon, 14 Oct 2002 19:04:28 +0000 (19:04 +0000)]
Translation updates
Bruce Momjian [Mon, 14 Oct 2002 18:11:17 +0000 (18:11 +0000)]
Mention that resetting the timeout may be wrong on select retry.
Bruce Momjian [Mon, 14 Oct 2002 17:33:08 +0000 (17:33 +0000)]
Restore ptmp_timeout for cases where no timeout is passed.
Bruce Momjian [Mon, 14 Oct 2002 17:15:11 +0000 (17:15 +0000)]
libpq connection_timeout doesn't do subsecond timing, so make the code
clear on that point.
Tom Lane [Mon, 14 Oct 2002 16:51:30 +0000 (16:51 +0000)]
Arrange to copy relcache's trigdesc structure at the start of any
query that uses it. This ensures that triggers will be applied consistently
throughout a query even if someone commits changes to the relation's
pg_class.reltriggers field meanwhile. Per crash report from Laurette Cisneros.
While at it, simplify memory management in relcache.c, which no longer
needs the old hack to try to keep trigger info in the same place over
a relcache entry rebuild. (Should try to fix rd_att and rewrite-rule
access similarly, someday.) And make RelationBuildTriggers simpler and
more robust by making it build the trigdesc in working memory and then
CopyTriggerDesc() into cache memory.
Bruce Momjian [Mon, 14 Oct 2002 04:29:23 +0000 (04:29 +0000)]
- Link the entries in the table to the catalog heading
- Wrap them in the <database class="table"> tags, since thats what they
are (no markup rules for this, so it inherits from parent -- no style
change)
- Mention that pg_database, pg_shadow, and pg_group are global, and the
rest are local to the specific DB. (I believe this is correct).
> Works for me, though I suppose we could explain what the exceptions are
> like in general terms. Perhaps something like
>
> 'Most system catalogs are copied from the template database during
> database creation, and are thereafter database-specific. A few
> catalogs are physically shared across all databases in an installation;
> these are marked in the descriptions of the individual catalogs.'
Ok, new patch.
Rod Taylor
Bruce Momjian [Mon, 14 Oct 2002 04:27:25 +0000 (04:27 +0000)]
This trivial patch fixes a bunch of spelling mistakes in the
contrib/dbmirror/README.dbmirror doc file.
Neil Conway
Bruce Momjian [Mon, 14 Oct 2002 04:26:54 +0000 (04:26 +0000)]
As Niel so nicely pointed out this morning, the output of EXPLAIN
ANALYZE is not quite clear when branches of the query are never
executed. So this tiny patch fixes that.
The patch is attached and can also be found at:
http://svana.org/kleptog/pgsql/pgsql-explain.patch
Martijn van Oosterhout
Bruce Momjian [Mon, 14 Oct 2002 04:20:52 +0000 (04:20 +0000)]
I have attached two patches as per:
1) pltcl:
Add SPI_freetuptable() calls to avoid memory leaks (Me + Neil Conway)
Change sprintf()s to snprintf()s (Neil Conway)
Remove header files included elsewhere (Neil Conway)
2)plpython:
Add SPI_freetuptable() calls to avoid memory leaks
Cosemtic change to remove a compiler warning
Notes:
I have tested pltcl.c for
a) the original leak problem reported for the repeated call of spi_exec
in a TCL fragment
and
b) the subsequent report resulting from the use of spi_exec -array
in a TCL
fragment.
The plpython.c patch is exactly the same as that applied to make
revision 1.23,
the plpython_schema.sql and feature.expected sections of the patch are
also the
same as last submited, applied and subsequently reversed out. It remains
untested by me (other than via make check). However, this should be safe
provided PyString_FromString() _copies_ the given string to make a
PyObject.
Nigel J. Andrews
Bruce Momjian [Mon, 14 Oct 2002 03:15:33 +0000 (03:15 +0000)]
Improvements to Ian Barwick patch.
Bruce Momjian [Mon, 14 Oct 2002 02:50:28 +0000 (02:50 +0000)]
FAQ updates from Ian Barwick.
Tom Lane [Sun, 13 Oct 2002 16:55:05 +0000 (16:55 +0000)]
Make SET really not start a transaction.
Tom Lane [Sun, 13 Oct 2002 15:39:17 +0000 (15:39 +0000)]
Make macaddr_in reject trailing garbage (except whitespace).
Per gripe from Patrick Welche, 13-Oct-2002.
Tom Lane [Sat, 12 Oct 2002 23:09:34 +0000 (23:09 +0000)]
psql thought that backslash is an escape character inside double quotes.
It isn't.
Tom Lane [Sat, 12 Oct 2002 22:24:49 +0000 (22:24 +0000)]
Fix for bug #795: two clauses that seem redundant are not really, if
one is pushed down into an outer join and the other is not.
Bruce Momjian [Sat, 12 Oct 2002 19:15:09 +0000 (19:15 +0000)]
Update README for oid2name.
Bruce Momjian [Sat, 12 Oct 2002 19:03:41 +0000 (19:03 +0000)]
Add:
> * Rename oid2name to relfilenode2name and install by default
Bruce Momjian [Sat, 12 Oct 2002 17:01:19 +0000 (17:01 +0000)]
Added:
> o Allow psql \copy to specify column names
Peter Eisentraut [Sat, 12 Oct 2002 16:34:28 +0000 (16:34 +0000)]
Compute version number for docs on the fly.
Peter Eisentraut [Sat, 12 Oct 2002 16:33:43 +0000 (16:33 +0000)]
Handle indentation of verbatim environments in HTML output via CSS.
Peter Eisentraut [Sat, 12 Oct 2002 16:31:55 +0000 (16:31 +0000)]
Fix linking problem.
Peter Eisentraut [Sat, 12 Oct 2002 16:29:51 +0000 (16:29 +0000)]
Replace &version; by appropriate version.
Peter Eisentraut [Fri, 11 Oct 2002 23:03:48 +0000 (23:03 +0000)]
Assorted reference page updates
Bruce Momjian [Fri, 11 Oct 2002 17:55:17 +0000 (17:55 +0000)]
Update FAQ.
Bruce Momjian [Fri, 11 Oct 2002 17:45:40 +0000 (17:45 +0000)]
Update Russian FAQ.
Bruce Momjian [Fri, 11 Oct 2002 05:02:24 +0000 (05:02 +0000)]
Add replication, encryption, and cross database FAQ items.
Bruce Momjian [Fri, 11 Oct 2002 04:41:59 +0000 (04:41 +0000)]
Add tv_sec change for connection timeout suggested by author.
Bruce Momjian [Fri, 11 Oct 2002 04:16:44 +0000 (04:16 +0000)]
Oops, back out newNode changes. We are not ready for that yet.
Bruce Momjian [Fri, 11 Oct 2002 04:12:14 +0000 (04:12 +0000)]
Prevent tv_sec from becoming negative in connection timeout code.
Bruce Momjian [Fri, 11 Oct 2002 03:32:45 +0000 (03:32 +0000)]
Update:
> * -Add pg_backend_pid() function to backend
Bruce Momjian [Thu, 10 Oct 2002 03:15:19 +0000 (03:15 +0000)]
Update IN/EXISTS item.
Bruce Momjian [Wed, 9 Oct 2002 16:27:48 +0000 (16:27 +0000)]
set.patch updates an example in ref/set.sgml to have microsecond
precision.
vacuum.patch updates ref/vacuum.sgml to explicitly state that an
exclusive lock is not obtained during normal (non-FULL) vacuum.
Rod Taylor
Bruce Momjian [Wed, 9 Oct 2002 16:26:46 +0000 (16:26 +0000)]
Lock on the rule relation wasn't removed after adding the comment.
Added Tom's patch fix for heap_close.
Rod Taylor
Bruce Momjian [Wed, 9 Oct 2002 16:23:55 +0000 (16:23 +0000)]
Well, this patch makes Makefile for contrib/rserv use the
contrib/contrib-global.mk library and _generally_ behave like
Makefiles for other contrib modules.
Besides it fixes Perl's interpolation of $libdir variable, which
should be passed to backend instead. This patch is done against
PostgreSQL 7.3b2
Besides, I want to thank Peter Eisentraut for his very friendly and
helpful attitude and politely ask him to check whether contrib
modules actually continue to work after he implements another
major change to their build process.
Alexey Borzov
Bruce Momjian [Wed, 9 Oct 2002 16:21:54 +0000 (16:21 +0000)]
> > > > and mb conversions (pg_ascii2mic and pg_mic2ascii not
> > > > found in the postmaster and not included from elsewhere)
> >
> > shared libs on AIX need to be able to resolve all symbols at linkage time.
> > Those two symbols are in backend/utils/SUBSYS.o but not in the postgres
> > executable.
>
> They are defined in backend/utils/mb/conv.c and declared in
> include/mb/pg_wchar.h. They're also linked into the
> postmaster. I don't see anything unusual.
Attached is a patch to fix the mb linking problems on AIX. As a nice side effect
it reduces the duplicate symbol warnings to linking libpq.so and libecpg.so
(all shlibs that are not postmaster loadable modules).
Please apply to current (only affects AIX).
The _LARGE_FILES problem is unfortunately still open, unless Peter
has fixed it per his recent idea.
Zeugswetter Andreas SB SD
Bruce Momjian [Wed, 9 Oct 2002 16:20:25 +0000 (16:20 +0000)]
> Alvaro Herrera <alvherre@atentus.com> writes:
> > I'm looking at pg_dump/common.c:flagInhAttrs() and suspect that it can
> > be more or less rewritten completely, and probably should to get rigth
> > all the cases mentioned in the past attisinherited discussion. Is this
> > desirable for 7.3? It can probably be hacked around and the rewrite
> > kept for 7.4, but I think it will be much simpler after the rewrite.
>
> If it's a bug then it's fair game to fix in 7.3. But keep in mind that
> pg_dump has to behave at least somewhat sanely when called against older
> servers ... will your rewrite behave reasonably if the server does not
> offer attinhcount values?
Nah. I don't think it's worth it: I had forgotten that older versions
should be supported. I just left the code as is and added a
version-specific test.
This patch allows pg_dump to dump correctly local definition of columns.
In particular,
CREATE TABLE p1 (f1 int, f2 int);
CREATE TABLE p2 (f1 int);
CREATE TABLE c () INHERITS (p1, p2);
ALTER TABLE ONLY p1 DROP COLUMN f1;
CREATE TABLE p3 (f1 int);
CREATE TABLE c2 (f1 int) INHERITS (p3);
Will be dumped as
CREATE TABLE p1 (f2 int);
CREATE TABLE p2 (f1 int);
CREATE TABLE c (f1 int) INHERITS (p1, p2);
CREATE TABLE c2 (f1 int) INHERITS (p3);
(Previous version will dump
CREATE TABLE c () INHERITS (p1, p2)
CREATE TABLE c2 () INHERITS (p3) )
Alvaro Herrera
Bruce Momjian [Wed, 9 Oct 2002 04:59:38 +0000 (04:59 +0000)]
Have SET not start transaction when autocommit off, with doc updates.
Bruce Momjian [Wed, 9 Oct 2002 02:04:03 +0000 (02:04 +0000)]
Add:
> o Allow SHOW of non-modifiable variables, like pg_controldata
Bruce Momjian [Tue, 8 Oct 2002 23:12:22 +0000 (23:12 +0000)]
Again improve MemSet comments.
Bruce Momjian [Tue, 8 Oct 2002 19:17:58 +0000 (19:17 +0000)]
Update MemSet comments.
Tom Lane [Tue, 8 Oct 2002 17:17:19 +0000 (17:17 +0000)]
Move responsibility for setting QuerySnapshot for utility statements
into postgres.c; make sure it happens for all cases that seem to need it.
Perhaps it would be better to explicitly exclude just a few utility
statement types from setting a snapshot?
Dave Cramer [Tue, 8 Oct 2002 01:47:55 +0000 (01:47 +0000)]
fixed missing apostrophe
Tom Lane [Mon, 7 Oct 2002 17:04:30 +0000 (17:04 +0000)]
Change order of operations during XLogFlush so that we try to include
in our write/flush operation any WAL entries that got queued while we
were waiting to get the WALWriteLock. This improves throughput when
transactions are small enough that several can be committed per WAL
write (ie, per disk revolution).
Tatsuo Ishii [Mon, 7 Oct 2002 05:10:02 +0000 (05:10 +0000)]
Avoid PQisBusy/PQconsumeInput busy loop in case of PQisBusy returning
false. per Tom Lane's suggestion. See:
Subject: Suggested change to pgbench
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <t-ishii@sra.co.jp>
Cc: pgsql-patches@postgreSQL.org
Date: Sun, 06 Oct 2002 12:37:27 -0400
for more details.
Bruce Momjian [Sun, 6 Oct 2002 03:56:03 +0000 (03:56 +0000)]
Clarify comment.
Bruce Momjian [Sat, 5 Oct 2002 23:43:42 +0000 (23:43 +0000)]
Fix markup error.
Bruce Momjian [Sat, 5 Oct 2002 19:04:00 +0000 (19:04 +0000)]
Add:
> * Add now("transaction|statement|clock") functionality
Bruce Momjian [Sat, 5 Oct 2002 19:03:16 +0000 (19:03 +0000)]
Add more documentation about CURRENT_TIMESTAMP.
Also, code < and > as </> for cleaner SGML.
Bruce Momjian [Sat, 5 Oct 2002 04:00:26 +0000 (04:00 +0000)]
Update:
> * Allow sorting, temp files, temp tables to use multiple work directories
Tom Lane [Fri, 4 Oct 2002 22:19:29 +0000 (22:19 +0000)]
Restrict CREATE OPERATOR CLASS to superusers, per discussion some weeks
ago.
Tom Lane [Fri, 4 Oct 2002 22:08:44 +0000 (22:08 +0000)]
Require superuser privilege to create a binary-compatible cast, per
discussion some weeks ago. Also, add a check that two types to be
binary-equivalenced match as to typlen, typbyval, and typalign; if
they don't then it's surely a mistake to equivalence them.
Bruce Momjian [Fri, 4 Oct 2002 19:06:07 +0000 (19:06 +0000)]
Update wording for temp files:
> * Allow sorting/temp files to use multiple work directories
Tom Lane [Fri, 4 Oct 2002 17:34:01 +0000 (17:34 +0000)]
Fix a couple of grammatical errors in error messages.
Bruce Momjian [Fri, 4 Oct 2002 17:26:56 +0000 (17:26 +0000)]
Add:
> * Allow sorting to use multiple work directories
Tom Lane [Fri, 4 Oct 2002 17:19:55 +0000 (17:19 +0000)]
Tweak a few of the most heavily used function call points to zero out
just the significant fields of FunctionCallInfoData, rather than MemSet'ing
the whole struct to zero. Unused positions in the arg[] array will
thereby contain garbage rather than zeroes. This buys back some of the
performance hit from increasing FUNC_MAX_ARGS. Also tweak tuplesort.c
code for more speed by marking some routines 'inline'. All together
these changes speed up simple sorts, like count(distinct int4column),
by about 25% on a P4 running RH Linux 7.2.
Bruce Momjian [Fri, 4 Oct 2002 02:28:42 +0000 (02:28 +0000)]
Add:
> * Add floor(float8) and other missing functions
Tom Lane [Thu, 3 Oct 2002 21:06:23 +0000 (21:06 +0000)]
Hack to make it possible to load CREATE CONSTRAINT TRIGGER commands that
are missing the FROM clause (due to a long-ago pg_dump bug). Patch by
Stephan Szabo, minor tweaking by Tom Lane.
Bruce Momjian [Thu, 3 Oct 2002 19:33:50 +0000 (19:33 +0000)]
Add auto-vacuum emails.
Bruce Momjian [Thu, 3 Oct 2002 19:32:43 +0000 (19:32 +0000)]
Add:
< * Provide automatic running of vacuum in the background (Tom)
> * Provide automatic running of vacuum in the background (Tom) [vacuum]
Bruce Momjian [Thu, 3 Oct 2002 19:20:25 +0000 (19:20 +0000)]
Add:
> * Check GUC geqo_threshold to see if it is still accurate
Tom Lane [Thu, 3 Oct 2002 19:19:09 +0000 (19:19 +0000)]
In a bootstrap process or standalone backend, set MaxBackends = 1
to avoid unnecessary consumption of semaphores.
Tom Lane [Thu, 3 Oct 2002 19:17:55 +0000 (19:17 +0000)]
Avoid palloc(0) when MaxBackends = 1.
Tom Lane [Thu, 3 Oct 2002 18:40:02 +0000 (18:40 +0000)]
Restore NOTICEs that were mistakenly removed from triggers regression
test expected output. Tweak contrib/spi Makefile so that refint.so is
by default built with appropriate NOTICE support for regression testing.
Bruce Momjian [Thu, 3 Oct 2002 17:26:14 +0000 (17:26 +0000)]
Add SSL documentation info to README.SSL
Bruce Momjian [Thu, 3 Oct 2002 17:20:39 +0000 (17:20 +0000)]
It's just a cosmetic change, fixes the help screen. Should be applied in
/contrib/vacuumlo
Mario Weilguni
Bruce Momjian [Thu, 3 Oct 2002 17:17:42 +0000 (17:17 +0000)]
This patch fixes a few grammatical errors, removes some duplicate
entries, and attributes some JDBC changes to the right people.
Neil Conway
Bruce Momjian [Thu, 3 Oct 2002 17:16:31 +0000 (17:16 +0000)]
This is small README fix for contrib/intarray. Thank you.
Teodor Sigaev
Bruce Momjian [Thu, 3 Oct 2002 17:15:36 +0000 (17:15 +0000)]
The attached adds a bit to the contrib/tablefunc regression test for
behavior of connectby() in the presence of infinite recursion. Please
apply this one in addition to the one sent earlier.
Joe Conway
Bruce Momjian [Thu, 3 Oct 2002 17:11:12 +0000 (17:11 +0000)]
> The previous patch fixed an infinite recursion bug in
> contrib/tablefunc/tablefunc.c:connectby. But, other unmanageable error
> seems to occur even if a table has commonplace tree data(see below).
>
> I would think the patch, ancestor check, should be
>
> if (strstr(branch_delim || branchstr->data || branch_delim,
> branch_delim || current_key || branch_delim))
>
> This is my image, not a real code. However, if branchstr->data includes
> branch_delim, my image will not be perfect.
Good point. Thank you Masaru for the suggested fix.
Attached is a patch to fix the bug found by Masaru. His example now
produces:
regression=# SELECT * FROM connectby('connectby_tree', 'keyid',
'parent_keyid', '11', 0, '-') AS t(keyid int, parent_keyid int, level
int,
branch text);
keyid | parent_keyid | level | branch
-------+--------------+-------+----------
11 | | 0 | 11
10 | 11 | 1 | 11-10
111 | 11 | 1 | 11-111
1 | 111 | 2 | 11-111-1
(4 rows)
While making the patch I also realized that the "no show branch" form of
the function was not going to work very well for recursion detection.
Therefore there is now a default branch delimiter ('~') that is used
internally, for that case, to enable recursion detection to work. If
you need a different delimiter for your specific data, you will have to
use the "show branch" form of the function.
Joe Conway
Bruce Momjian [Thu, 3 Oct 2002 17:09:42 +0000 (17:09 +0000)]
The attached patch fixes a number of issues related to compiling the
client
utilities (libpq.dll and psql.exe) for win32 (missing defines,
adjustments to
includes, pedantic casting, non-existent functions) per:
http://developer.postgresql.org/docs/postgres/install-win32.html.
It compiles cleanly under Windows 2000 using Visual Studio .net. Also
compiles clean and passes all regression tests (regular and contrib)
under Linux.
In addition to a review by the usual suspects, it would be very
desirable for someone well versed in the peculiarities of win32 to take
a look.
Joe Conway
Bruce Momjian [Thu, 3 Oct 2002 17:07:53 +0000 (17:07 +0000)]
This patch removes two unused global variables from globals.c
Neil Conway