OSDN Git Service
Bruce Momjian [Tue, 2 Feb 2010 18:52:02 +0000 (18:52 +0000)]
Remove copyright mention of Andrew Yu, per author's permission.
Backpatch to 8.4.X.
Tom Lane [Tue, 2 Feb 2010 18:16:10 +0000 (18:16 +0000)]
The particular table names used in the new inheritance regression test are
prone to sort differently in different locales, as seen in buildfarm results.
Let's cast to name not text to avoid that.
Michael Meskes [Tue, 2 Feb 2010 16:09:12 +0000 (16:09 +0000)]
Fixed NaN/Infinity problems in ECPG for float/double/numeric/decimal by making it OS independant.
Patch done by Zoltán Böszörményi.
Robert Haas [Mon, 1 Feb 2010 19:28:56 +0000 (19:28 +0000)]
Tighten integrity checks on ALTER TABLE ... ALTER COLUMN ... RENAME.
When a column is renamed, we recursively rename the same column in
all descendent tables. But if one of those tables also inherits that
column from a table outside the inheritance hierarchy rooted at the
named table, we must throw an error. The previous coding correctly
prohibited the rename when the parent had inherited the column from
elsewhere, but overlooked the case where the parent was OK but a child
table also inherited the same column from a second, unrelated parent.
For now, not backpatched due to lack of complaints from the field.
KaiGai Kohei, with further changes by me.
Reviewed by Bernd Helme and Tom Lane.
Bruce Momjian [Mon, 1 Feb 2010 15:48:35 +0000 (15:48 +0000)]
Remove tabs in sgml.
Robert Haas [Mon, 1 Feb 2010 15:43:36 +0000 (15:43 +0000)]
Augment EXPLAIN output with more details on Hash nodes.
We show the number of buckets, the number of batches (and also the original
number if it has changed), and the peak space used by the hash table. Minor
executor changes to track peak space used.
Robert Haas [Mon, 1 Feb 2010 15:38:21 +0000 (15:38 +0000)]
Minor documentation improvements for new string_agg aggregate.
Simon Riggs [Mon, 1 Feb 2010 13:40:28 +0000 (13:40 +0000)]
Revoke augmentation of WAL records for btree delete, per discussion.
Itagaki Takahiro [Mon, 1 Feb 2010 03:14:45 +0000 (03:14 +0000)]
Add string_agg aggregate functions. The one argument version concatenates
the input values into a string. The two argument version also does the same
thing, but inserts delimiters between elements.
Original patch by Pavel Stehule, reviewed by David E. Wheeler and me.
Tom Lane [Mon, 1 Feb 2010 02:45:29 +0000 (02:45 +0000)]
Change regexp engine's ccondissect/crevdissect routines to perform DFA
matching before recursing instead of after. The DFA match eliminates
unworkable midpoint choices a lot faster than the recursive check, in most
cases, so doing it first can speed things up; particularly in pathological
cases such as recently exhibited by Michael Glaesemann.
In addition, apply some cosmetic changes that were applied upstream (in the
Tcl project) at the same time, in order to sync with upstream version 1.15
of regexec.c.
Upstream apparently intends to backpatch this, so I will too. The
pathological behavior could be unpleasant if encountered in the field,
which seems to justify any risk of introducing new bugs.
Tom Lane, reviewed by Donal K. Fellows of Tcl project
Simon Riggs [Sun, 31 Jan 2010 19:01:11 +0000 (19:01 +0000)]
Detect early deadlock in Hot Standby when Startup is already waiting. First
stage of required deadlock detection to allow re-enabling max_standby_delay
setting of -1, which is now essential in the absence of improved relation-
specific conflict resoluton. Requested by Greg Stark et al.
Tom Lane [Sun, 31 Jan 2010 18:15:39 +0000 (18:15 +0000)]
Fix memory leak created by deferrable-index-constraints patches.
We need to free the OID list returned by ExecInsertIndexTuples to avoid
a query-lifespan memory leak. When many rows require rechecking, this
can be a significant leak --- it's even more than the space used for the
queued trigger events.
Dean Rasheed
Magnus Hagander [Sun, 31 Jan 2010 17:39:34 +0000 (17:39 +0000)]
Make checks for invalid pgStatSock use PGINVALID_SOCKET
Tom Lane [Sun, 31 Jan 2010 17:35:46 +0000 (17:35 +0000)]
Parenthesize this macro, just in case.
Tom Lane [Sun, 31 Jan 2010 17:27:22 +0000 (17:27 +0000)]
Get rid of unportable use of socklen_t --- we have a configure test
for that, so use it.
Magnus Hagander [Sun, 31 Jan 2010 17:18:28 +0000 (17:18 +0000)]
Remove now unnecessary loop around CallNamedPipe().
Radu Ilie
Magnus Hagander [Sun, 31 Jan 2010 17:16:23 +0000 (17:16 +0000)]
Fix race condition in win32 signal handling.
There was a race condition where the receiving pipe could be closed by the
child thread if the main thread was pre-empted before it got a chance to
create a new one, and the dispatch thread ran to completion during that time.
One symptom of this is that rows in pg_listener could be dropped under
heavy load.
Analysis and original patch by Radu Ilie, with some small
modifications by Magnus Hagander.
Tom Lane [Sat, 30 Jan 2010 20:09:53 +0000 (20:09 +0000)]
Avoid performing encoding conversion on command tag strings during EndCommand.
Since all current and foreseeable future command tags will be pure ASCII,
there is no need to do conversion on them. This saves a few cycles and also
avoids polluting otherwise-pristine subtransaction memory contexts, which
is the cause of the backend memory leak exhibited in bug #5302. (Someday
we'll probably want to have a better method of determining whether
subtransaction contexts need to be kept around, but today is not that day.)
Backpatch to 8.0. The cycle-shaving aspect of this would work in 7.4
too, but without subtransactions the memory-leak aspect doesn't apply,
so it doesn't seem worth touching 7.4.
Tom Lane [Sat, 30 Jan 2010 18:59:51 +0000 (18:59 +0000)]
Fix memory leakage introduced into print_aligned_text by 8.4 changes
(failure to free col_lineptrs[] array elements) and exacerbated in the
current devel cycle (failure to free "wrap"). This resulted in moderate
bloat of psql over long script runs. Noted while testing bug #5302,
although what the reporter was complaining of was backend-side leakage.
Tom Lane [Sat, 30 Jan 2010 04:18:00 +0000 (04:18 +0000)]
Fix some comments that got mangled by pgindent.
Andrew Dunstan [Sat, 30 Jan 2010 01:46:57 +0000 (01:46 +0000)]
Add plperl.on_perl_init setting to provide for initializing the perl library on load. Also, handle END blocks in plperl.
Database access is disallowed during both these operations, although it might be allowed in END blocks in future.
Patch from Tim Bunce.
Simon Riggs [Fri, 29 Jan 2010 19:45:12 +0000 (19:45 +0000)]
Adjust GetLockConflicts() so that it uses TopMemoryContext when
executed InHotStandby. Cleaner solution than using malloc or palloc
depending upon situation, as proposed by Tom.
Simon Riggs [Fri, 29 Jan 2010 18:39:05 +0000 (18:39 +0000)]
Augment WAL records for btree delete with GetOldestXmin() to reduce
false positives during Hot Standby conflict processing. Simple
patch to enhance conflict processing, following previous discussions.
Controlled by parameter minimize_standby_conflicts = on | off, with
default off allows measurement of performance impact to see whether
it should be set on all the time.
Robert Haas [Fri, 29 Jan 2010 17:44:12 +0000 (17:44 +0000)]
Allow psql variables to be interpolated with literal or identifier escaping.
Loosely based on a patch by Pavel Stehule.
Simon Riggs [Fri, 29 Jan 2010 17:10:05 +0000 (17:10 +0000)]
Filter recovery conflicts based upon dboid from relfilenode of WAL
records for heap and btree. Minor change, mostly API changes to
pass through the required values. This is a simple change though
also provides the refactoring required for further enhancements
to conflict processing using the relOid. Changes only have effect
during Hot Standby.
Michael Meskes [Fri, 29 Jan 2010 16:28:13 +0000 (16:28 +0000)]
Changed ECPG outofscope handling to always print out statements in the same order
so regression testing is possible,
by Zoltan Boszormenyi
Michael Meskes [Fri, 29 Jan 2010 15:57:01 +0000 (15:57 +0000)]
Fixed a few typos in ecpg. Two were in comments, the third made a log output reverse yes and no.
Itagaki Takahiro [Fri, 29 Jan 2010 06:03:15 +0000 (06:03 +0000)]
Fix command tag for ALTER LARGE OBJECT.
Andrew Dunstan [Fri, 29 Jan 2010 01:06:18 +0000 (01:06 +0000)]
Fix thinko in new installcheck-world target
Andrew Dunstan [Thu, 28 Jan 2010 23:59:52 +0000 (23:59 +0000)]
Add new make targets "world", "install-world" and "installcheck-world" to build, install and check just about everything.
In addition to everything built installed and tested by all, install and installcheck targets, these build HTML Docs,
build and test contrib, and test PLs and ECPG.
Peter Eisentraut [Thu, 28 Jan 2010 23:21:13 +0000 (23:21 +0000)]
Type table feature
This adds the CREATE TABLE name OF type command, per SQL standard.
Andrew Dunstan [Thu, 28 Jan 2010 23:06:09 +0000 (23:06 +0000)]
Fix bug found by warning from recent gcc. patch from Tim Bunce.
Heikki Linnakangas [Thu, 28 Jan 2010 19:17:22 +0000 (19:17 +0000)]
Fix crashing bug at the end of recovery in Streaming Replication, when
restore_command is not given. Fujii Masao.
Magnus Hagander [Thu, 28 Jan 2010 14:25:41 +0000 (14:25 +0000)]
Add functions to reset the statistics counter for a single table/index or
a single function.
Magnus Hagander [Thu, 28 Jan 2010 11:36:14 +0000 (11:36 +0000)]
Define INADDR_NONE on Solaris when it's missing. Per a couple of buildfarm
members complaining.
Simon Riggs [Thu, 28 Jan 2010 10:05:37 +0000 (10:05 +0000)]
Use malloc() in GetLockConflicts() when called InHotStandby to avoid repeated
palloc calls. Current code assumed this was already true, so this is a bug fix.
Heikki Linnakangas [Thu, 28 Jan 2010 07:31:42 +0000 (07:31 +0000)]
Change a few remaining calls of XLogArchivingActive() to use
XLogIsNeeded() instead, to determine if an otherwise non-logged operation
needs to be logged in WAL for standby servers.
Fujii Masao
Joe Conway [Thu, 28 Jan 2010 06:28:26 +0000 (06:28 +0000)]
Introduce two new libpq connection functions, PQconnectdbParams and
PQconnectStartParams. These are analogous to PQconnectdb and PQconnectStart
respectively. They differ from the legacy functions in that they accept
two NULL-terminated arrays, keywords and values, rather than conninfo
strings. This avoids the need to build the conninfo string in cases
where it might be inconvenient to do so. Includes documentation.
Also modify psql to utilize PQconnectdbParams rather than PQsetdbLogin.
This allows the new config parameter application_name to be set, which
in turn is displayed in the pg_stat_activity view and included in CSV
log entries. This will also ensure both new functions get regularly
exercised.
Patch by Guillaume Lelarge with review and minor adjustments by
Joe Conway.
Heikki Linnakangas [Wed, 27 Jan 2010 16:41:09 +0000 (16:41 +0000)]
Fix bug in wasender's xlogid boundary handling, reported by Erik Rijkers.
LogwrtRqst.Write can be set to non-existent FF log segment, we mustn't
try to send that in XLogSend().
Also fix similar bug in ReadRecord(), which I just introduced in the
ReadRecord() refactoring patch.
Heikki Linnakangas [Wed, 27 Jan 2010 15:27:51 +0000 (15:27 +0000)]
Make standby server continuously retry restoring the next WAL segment with
restore_command, if the connection to the primary server is lost. This
ensures that the standby can recover automatically, if the connection is
lost for a long time and standby falls behind so much that the required
WAL segments have been archived and deleted in the master.
This also makes standby_mode useful without streaming replication; the
server will keep retrying restore_command every few seconds until the
trigger file is found. That's the same basic functionality pg_standby
offers, but without the bells and whistles.
To implement that, refactor the ReadRecord/FetchRecord functions. The
FetchRecord() function introduced in the original streaming replication
patch is removed, and all the retry logic is now in a new function called
XLogReadPage(). XLogReadPage() is now responsible for executing
restore_command, launching walreceiver, and waiting for new WAL to arrive
from primary, as required.
This also changes the life cycle of walreceiver. When launched, it now only
tries to connect to the master once, and exits if the connection fails, or
is lost during streaming for any reason. The startup process detects the
death, and re-launches walreceiver if necessary.
Magnus Hagander [Wed, 27 Jan 2010 13:03:17 +0000 (13:03 +0000)]
Fix typo.
Noted by Thom Brown.
Magnus Hagander [Wed, 27 Jan 2010 12:12:00 +0000 (12:12 +0000)]
Add support for RADIUS authentication.
Andrew Dunstan [Wed, 27 Jan 2010 02:55:04 +0000 (02:55 +0000)]
Fix plperl.sgml errors from recent commit.
Andrew Dunstan [Tue, 26 Jan 2010 23:11:56 +0000 (23:11 +0000)]
Various small improvements and cleanups for PL/Perl.
- Allow (ineffective) use of 'require' in plperl
If the required module is not already loaded then it dies.
So "use strict;" now works in plperl.
- Pre-load the feature module if perl >= 5.10.
So "use feature :5.10;" now works in plperl.
- Stored procedure subs are now given names.
The names are not visible in ordinary use, but they make
tools like Devel::NYTProf and Devel::Cover much more useful.
- Simplified and generalized the subroutine creation code.
Now one code path for generating sub source code, not four.
Can generate multiple 'use' statements with specific imports
(which handles plperl.use_strict currently and can easily
be extended to handle a plperl.use_feature=':5.12' in future).
- Disallows use of Safe version 2.20 which is broken for PL/Perl.
http://rt.perl.org/rt3/Ticket/Display.html?id=72068
- Assorted minor optimizations by pre-growing data structures.
Patch from Tim Bunce, reviewed by Alex Hunsaker.
Tom Lane [Tue, 26 Jan 2010 16:33:40 +0000 (16:33 +0000)]
Remove the default_do_language parameter, instead making DO use a hardwired
default of "plpgsql". This is more reasonable than it was when the DO patch
was written, because we have since decided that plpgsql should be installed
by default. Per discussion, having a parameter for this doesn't seem useful
enough to justify the risk of application breakage if the value is changed
unexpectedly.
Tom Lane [Tue, 26 Jan 2010 16:18:12 +0000 (16:18 +0000)]
Un-break initdb logic for commenting out IPv6 pg_hba.conf line.
Bruce Momjian [Tue, 26 Jan 2010 14:21:29 +0000 (14:21 +0000)]
Remove tabs in SGML.
Michael Meskes [Tue, 26 Jan 2010 10:31:14 +0000 (10:31 +0000)]
Added test case that was part of Zoltan's patch but apparently wasn't part of my commit.
Michael Meskes [Tue, 26 Jan 2010 09:10:11 +0000 (09:10 +0000)]
Finally applied patch by Boszormenyi Zoltan <zb@cybertec.at> to add the new features his patches added to the docs.
Michael Meskes [Tue, 26 Jan 2010 09:07:32 +0000 (09:07 +0000)]
Applied patch by Boszormenyi Zoltan <zb@cybertec.at> to add out-of-scope cursor support to native mode.
Peter Eisentraut [Tue, 26 Jan 2010 06:58:39 +0000 (06:58 +0000)]
Reformat the comments in pg_hba.conf and pg_ident.conf
These files have apparently been edited over the years by a dozen people
with as many different editor settings, which made the alignment of the
paragraphs quite inconsistent and ugly. I made a pass of M-q with Emacs
to straighten it out.
Peter Eisentraut [Tue, 26 Jan 2010 06:45:31 +0000 (06:45 +0000)]
Make the default pg_hba.conf and pg_ident.conf align at 8-character boundaries
to make it easier to use with tabs.
Simon Riggs [Tue, 26 Jan 2010 00:07:13 +0000 (00:07 +0000)]
Fix longstanding gripe that we check for
0000000001.history at start of
archive recovery, even when we know it is never present.
Tom Lane [Mon, 25 Jan 2010 20:55:32 +0000 (20:55 +0000)]
Add get_bit/set_bit functions for bit strings, paralleling those for bytea,
and implement OVERLAY() for bit strings and bytea.
In passing also convert text OVERLAY() to a true built-in, instead of
relying on a SQL function.
Leonardo F, reviewed by Kevin Grittner
Heikki Linnakangas [Mon, 25 Jan 2010 18:23:10 +0000 (18:23 +0000)]
Add note that PREPARE TRANSACTION is for transaction managers, not
regular applications. Also add a comment pointing out that tab-complition
for PREPARE TRANSACTION is missing on purpose.
Tom Lane [Mon, 25 Jan 2010 01:58:14 +0000 (01:58 +0000)]
Apply Tcl_Init() to the "hold" interpreter created by pltcl.
You might think this is unnecessary since that interpreter is never used
to run code --- but it turns out that's wrong. As of Tcl 8.5, the "clock"
command (alone among builtin Tcl commands) is partially implemented by
loaded-on-demand Tcl code, which means that it fails if there's not
unknown-command support, and also that it's impossible to run it directly
in a safe interpreter. The way they get around the latter is that
Tcl_CreateSlave() automatically sets up an alias command that forwards any
execution of "clock" in a safe slave interpreter to its parent interpreter.
Thus, when attempting to execute "clock" in trusted pltcl, the command
actually executes in the "hold" interpreter, where it will fail if
unknown-command support hasn't been introduced by sourcing the standard
init.tcl script, which is done by Tcl_Init(). (This is a pretty dubious
design decision on the Tcl boys' part, if you ask me ... but they didn't.)
Back-patch all the way. It's not clear that anyone would try to use ancient
versions of pltcl with a recent Tcl, but it's not clear they wouldn't, either.
Also add a regression test using "clock", in branches that have regression
test support for pltcl.
Per recent trouble report from Kyle Bateman.
Joe Conway [Sun, 24 Jan 2010 22:19:38 +0000 (22:19 +0000)]
Rewrite dblink_record_internal() and dblink_fetch() to use a tuplestore
(SFRM_Materialize mode) to return tuples. Since we don't return from the
dblink function in tuplestore mode, release the PGresult with a PG_CATCH
block on error. Also rearrange to share the same code to materialize the
tuplestore. Patch by Takahiro Itagaki.
Tom Lane [Sun, 24 Jan 2010 21:49:17 +0000 (21:49 +0000)]
Fix assorted core dumps and Assert failures that could occur during
AbortTransaction or AbortSubTransaction, when trying to clean up after an
error that prevented (sub)transaction start from completing:
* access to TopTransactionResourceOwner that might not exist
* assert failure in AtEOXact_GUC, if AtStart_GUC not called yet
* assert failure or core dump in AfterTriggerEndSubXact, if
AfterTriggerBeginSubXact not called yet
Per testing by injecting elog(ERROR) at successive steps in StartTransaction
and StartSubTransaction. It's not clear whether all of these cases could
really occur in the field, but at least one of them is easily exposed by
simple stress testing, as per my accidental discovery yesterday.
Magnus Hagander [Sun, 24 Jan 2010 14:46:01 +0000 (14:46 +0000)]
Add missing closing tag.
Tom Lane [Sat, 23 Jan 2010 21:29:00 +0000 (21:29 +0000)]
Insert CHECK_FOR_INTERRUPTS calls into loops in dbsize.c, to ensure that
the various disk-size-reporting functions will respond to query cancel
reasonably promptly even in very large databases. Per report from
Kevin Grittner.
Simon Riggs [Sat, 23 Jan 2010 17:04:05 +0000 (17:04 +0000)]
Add explanatory detail to Hot Standby cancelation error messages
with errdetail(). Add errhint() to suggest retry in certain cases.
Simon Riggs [Sat, 23 Jan 2010 16:37:12 +0000 (16:37 +0000)]
In HS, Startup process sets SIGALRM when waiting for buffer pin. If
woken by alarm we send SIGUSR1 to all backends requesting that they
check to see if they are blocking Startup process. If so, they throw
ERROR/FATAL as for other conflict resolutions. Deadlock stop gap
removed. max_standby_delay = -1 option removed to prevent deadlock.
Bruce Momjian [Fri, 22 Jan 2010 22:50:03 +0000 (22:50 +0000)]
Revert mention that HTML documentation has to be built first.
Now require gmake 3.79.1 or later to build source/sgml.
Robert Haas [Fri, 22 Jan 2010 17:30:24 +0000 (17:30 +0000)]
Fix mismatched tags introduced by attribute options patch.
Thanks to Devrim Gunduz for the report.
Robert Haas [Fri, 22 Jan 2010 16:42:31 +0000 (16:42 +0000)]
Fix several oversights in previous commit - attribute options patch.
I failed to 'cvs add' the new files and also neglected to bump catversion.
Robert Haas [Fri, 22 Jan 2010 16:40:19 +0000 (16:40 +0000)]
Replace ALTER TABLE ... SET STATISTICS DISTINCT with a more general mechanism.
Attributes can now have options, just as relations and tablespaces do, and
the reloptions code is used to parse, validate, and store them. For
simplicity and because these options are not performance critical, we store
them in a separate cache rather than the main relcache.
Thanks to Alex Hunsaker for the review.
Bruce Momjian [Fri, 22 Jan 2010 15:49:29 +0000 (15:49 +0000)]
Document that the HTML documentation must be built before the PDF
documentation.
Peter Eisentraut [Fri, 22 Jan 2010 15:45:15 +0000 (15:45 +0000)]
PL/Python DO handler
Also cleaned up some redundancies between the primary error messages and the
error context in PL/Python.
Hannu Valtonen
Michael Meskes [Fri, 22 Jan 2010 14:19:27 +0000 (14:19 +0000)]
Make argument const char * as per Takahiro Itagaki's suggestion.
Michael Meskes [Fri, 22 Jan 2010 14:13:03 +0000 (14:13 +0000)]
Applied patch by Boszormenyi Zoltan <zb@cybertec.at> to fix problem in auto-prepare mode if the connection is closed and re-opened and the previously prepared query is issued again.
Robert Haas [Thu, 21 Jan 2010 18:43:25 +0000 (18:43 +0000)]
Fix unsafe loop test, and declare as_ident as bool rather than int.
Robert Haas [Thu, 21 Jan 2010 14:58:53 +0000 (14:58 +0000)]
Add new escaping functions PQescapeLiteral and PQescapeIdentifier.
PQescapeLiteral is similar to PQescapeStringConn, but it relieves the
caller of the need to know how large the output buffer should be, and
it provides the appropriate quoting (in addition to escaping special
characers within the string). PQescapeIdentifier provides similar
functionality for escaping identifiers.
Per recent discussion with Tom Lane.
Simon Riggs [Thu, 21 Jan 2010 09:30:36 +0000 (09:30 +0000)]
Add missing flag reset to ensure subsequent manual cancelation gives correct reason.
Heikki Linnakangas [Thu, 21 Jan 2010 08:19:57 +0000 (08:19 +0000)]
Fix bogus comments.
Itagaki Takahiro [Thu, 21 Jan 2010 06:11:46 +0000 (06:11 +0000)]
Adjust psql to use pg_get_triggerdef(pretty=true) to remove extra ()'s
from description of triggers with WHEN clause.
Thanks to Brad T. Sliger for the review.
Simon Riggs [Thu, 21 Jan 2010 00:53:58 +0000 (00:53 +0000)]
Better internal documentation of locking for Hot Standby conflict resolution.
Discuss the reasons for the lock type we hold on ProcArrayLock while deriving
the conflict list. Cover the idea of false positive conflicts and seemingly
strange effects on snapshot derivation.
Tom Lane [Wed, 20 Jan 2010 23:12:03 +0000 (23:12 +0000)]
Well, the systemtap guys moved the goalposts again: with the latest version,
we *must* generate probes.o or the dtrace probes don't work. Revert our
workaround for their previous bug. Details at
https://bugzilla.redhat.com/show_bug.cgi?id=557266
Peter Eisentraut [Wed, 20 Jan 2010 21:15:21 +0000 (21:15 +0000)]
Add user-specific .pg_service.conf file
This extends the existing pg_service.conf facility to first look for a
service definition file in the user's home directory.
Heikki Linnakangas [Wed, 20 Jan 2010 20:34:51 +0000 (20:34 +0000)]
Fix bogus subdir setting. Again. I must've unfixed it by accident while
moving files around.
Heikki Linnakangas [Wed, 20 Jan 2010 19:43:40 +0000 (19:43 +0000)]
Write a WAL record whenever we perform an operation without WAL-logging
that would've been WAL-logged if archiving was enabled. If we encounter
such records in archive recovery anyway, we know that some data is
missing from the log. A WARNING is emitted in that case.
Original patch by Fujii Masao, with changes by me.
Heikki Linnakangas [Wed, 20 Jan 2010 18:54:27 +0000 (18:54 +0000)]
Now that much of walreceiver has been pulled back into the postgres
binary, revert PGDLLIMPORT decoration of global variables. I'm not sure
if there's any real harm from unnecessary PGDLLIMPORTs, but these are all
internal variables that external modules really shouldn't be messing
with. ThisTimeLineID still needs PGDLLIMPORT.
Heikki Linnakangas [Wed, 20 Jan 2010 11:58:44 +0000 (11:58 +0000)]
Add missing "!= NULL", for the sake of consistency.
Fujii Masao
Heikki Linnakangas [Wed, 20 Jan 2010 09:30:07 +0000 (09:30 +0000)]
Adjust windows makefiles too, now that the walreceiver dynamic module
has been renamed.
Heikki Linnakangas [Wed, 20 Jan 2010 09:22:43 +0000 (09:22 +0000)]
Adjust MSVC build script too, now that the walreceiver dynamic module
has been renamed.
Heikki Linnakangas [Wed, 20 Jan 2010 09:16:24 +0000 (09:16 +0000)]
Rethink the way walreceiver is linked into the backend. Instead than shoving
walreceiver as whole into a dynamically loaded module, split the
libpq-specific parts of it into dynamically loaded module and keep the rest
in the main backend binary.
Although Tom fixed the Windows compilation problems with the old walreceiver
module already, this is a cleaner division of labour and makes the code
more readable. There's also the prospect of adding new transport methods
as pluggable modules in the future, which this patch makes easier, though for
now the API between libpqwalreceiver and walreceiver process should be
considered private.
The libpq-specific module is now in src/backend/replication/libpqwalreceiver,
and the part linked with postgres binary is in
src/backend/replication/walreceiver.c.
Peter Eisentraut [Wed, 20 Jan 2010 05:47:09 +0000 (05:47 +0000)]
Before attempting to create a composite type, check whether a type of that
name already exists, so we'd get an error message about a "type" instead
of about a "relation", because the composite type code shares code with
relation creation.
Andrew Dunstan [Wed, 20 Jan 2010 04:29:07 +0000 (04:29 +0000)]
Fix typo in Mkvcbuild.pl
Andrew Dunstan [Wed, 20 Jan 2010 04:14:06 +0000 (04:14 +0000)]
Build plperl's new Util.xs
Robert Haas [Wed, 20 Jan 2010 03:37:10 +0000 (03:37 +0000)]
Fix doc build, which was broken by PL/perl utility functions patch.
Andrew Dunstan [Wed, 20 Jan 2010 01:08:21 +0000 (01:08 +0000)]
Add utility functions to PLPerl:
quote_literal, quote_nullable, quote_ident,
encode_bytea, decode_bytea, looks_like_number,
encode_array_literal, encode_array_constructor.
Split SPI.xs into two - SPI.xs now contains only SPI functions. Remainder
are in new Util.xs.
Some more code and documentation cleanup along the way, as well as
adding some CVS markers to files missing them.
Original patch from Tim Bunce, with a little editing from me.
Robert Haas [Wed, 20 Jan 2010 00:42:28 +0000 (00:42 +0000)]
Reformat documentation of libpq escaping functions.
Modify the "Escaping Strings for Inclusion in SQL Commands" section
to use a <variablelist> as the preceding and following sections do,
and merge the "Escaping Binary Strings for Inclusion in SQL Commands"
section into it.
This changes only the formatting of these sections, not the content.
It is intended to lay the groundwork for a follow-on patch to add
some new escaping functions, but it makes sense to commit this first,
for clarity.
Tom Lane [Tue, 19 Jan 2010 18:39:19 +0000 (18:39 +0000)]
When doing a parallel restore, we must guard against out-of-range dependency
dump IDs, because the array we're using is sized according to the highest
dump ID actually defined in the archive file. In a partial dump there could
be references to higher dump IDs that weren't dumped. Treat these the same
as references to in-range IDs that weren't dumped. (The whole thing is a
bit scary because the missing objects might have been part of dependency
chains, which we won't know about. Not much we can do though --- throwing
an error is probably overreaction.)
Also, reject parallel restore with pre-1.8 archive version (made by pre-8.0
pg_dump). In these old versions the dependency entries are OIDs, not dump
IDs, and we don't have enough information to interpret them.
Per bug #5288 from Jon Erdman.
Tom Lane [Tue, 19 Jan 2010 16:33:33 +0000 (16:33 +0000)]
Fix thinko in my recent change to put an explicit argisrow field in NullTest:
when the planner splits apart a ROW(...) IS NULL test, the argisrow values
of the component tests have to be determined from the component field types,
not copied from the original NullTest (in which argisrow is surely true).
Magnus Hagander [Tue, 19 Jan 2010 14:11:32 +0000 (14:11 +0000)]
Add pg_stat_reset_shared('bgwriter') to reset the cluster-wide shared
statistics of the bgwriter.
Greg Smith
Tom Lane [Tue, 19 Jan 2010 05:50:18 +0000 (05:50 +0000)]
Add pg_table_size() and pg_indexes_size() to provide more user-friendly
wrappers around the pg_relation_size() function.
Bernd Helmle, reviewed by Greg Smith
Tom Lane [Tue, 19 Jan 2010 01:35:31 +0000 (01:35 +0000)]
Add "USING expressions" option to plpgsql's OPEN cursor FOR EXECUTE.
This is the last EXECUTE-like plpgsql statement that was missing
the capability of inserting parameter values via USING.
Pavel Stehule, reviewed by Itagaki Takahiro
Peter Eisentraut [Mon, 18 Jan 2010 22:19:34 +0000 (22:19 +0000)]
Cast slightly abused enum to int, so that GCC 4.5 won't warn about switch
cases that are not part of the enum's definition.
Tom Lane [Mon, 18 Jan 2010 18:17:45 +0000 (18:17 +0000)]
Fix an oversight in convert_EXISTS_sublink_to_join: we can't convert an
EXISTS that contains a WITH clause. This would usually lead to a
"could not find CTE" error later in planning, because the WITH wouldn't
get processed at all. Noted while playing with an example from Ken Marshall.
Teodor Sigaev [Mon, 18 Jan 2010 11:50:43 +0000 (11:50 +0000)]
Fix incorrect comparison of scan key in GIN. Per report from
Vyacheslav Kalinin <vka@mgcp.com>
Tom Lane [Mon, 18 Jan 2010 02:30:25 +0000 (02:30 +0000)]
Fix portalmem.c to avoid keeping a dangling pointer to a cached plan list
after it's released its reference count for the cached plan. There are
code paths that might try to examine the plan list before noticing that
the portal is already in aborted state. Report and diagnosis by Tatsuo
Ishii, though this isn't exactly his proposed patch.