OSDN Git Service
Peter Eisentraut [Mon, 20 Jul 2009 08:01:07 +0000 (08:01 +0000)]
Use errcontext mechanism in PL/Python
Error messages from PL/Python now always mention the function name in the
CONTEXT: field. This also obsoletes the few places that tried to do the
same manually.
Regression test files are updated to work with Python 2.4-2.6. I don't have
access to older versions right now.
Tom Lane [Mon, 20 Jul 2009 03:46:45 +0000 (03:46 +0000)]
Remove unnecessary and version-sensitive dependence on the exact set of
column names to be found in a sequence. Per gripe from Bruce.
Andrew Dunstan [Mon, 20 Jul 2009 02:42:28 +0000 (02:42 +0000)]
DROP IF EXISTS for columns and constraints. Andres Freund.
Tom Lane [Mon, 20 Jul 2009 00:24:30 +0000 (00:24 +0000)]
Teach simplify_boolean_equality to simplify the forms foo <> true and
foo <> false, along with its previous duties of simplifying foo = true
and foo = false. (All of these are equivalent to just foo or NOT foo
as the case may be.) It's not clear how often this is really useful;
but it costs almost nothing to do, and it seems some people think we
should be smart about such cases. Per recent bug report.
Tom Lane [Sun, 19 Jul 2009 21:00:43 +0000 (21:00 +0000)]
Rewrite GEQO's gimme_tree function so that it always finds a legal join
sequence, even when the input "tour" doesn't lead directly to such a sequence.
The stack logic that was added in 2004 only supported cases where relations
that had to be joined to each other (due to join order restrictions) were
adjacent in the tour. However, relying on a random search to figure that out
is tremendously inefficient in large join problems, and could even fail
completely (leading to "failed to make a valid plan" errors) if
random_init_pool ran out of patience. It seems better to make the
tour-to-plan transformation a little bit fuzzier so that every tour can form
a legal plan, even though this means that apparently different tours will
sometimes yield the same plan.
In the same vein, get rid of the logic that knew that tours (a,b,c,d,...)
are the same as tours (b,a,c,d,...), and therefore insisted the latter
are invalid. The chance of generating two tours that differ only in
this way isn't that high, and throwing out 50% of possible tours to
avoid such duplication seems more likely to waste valuable genetic-
refinement generations than to do anything useful.
This leaves us with no cases in which geqo_eval will deem a tour invalid,
so get rid of assorted kluges that tried to deal with such cases, in
particular the undocumented assumption that DBL_MAX is an impossible
plan cost.
This is all per testing of Robert Haas' lets-remove-the-collapse-limits
patch. That idea has crashed and burned, at least for now, but we still
got something useful out of it.
It's possible we should back-patch this change, since the "failed to make a
valid plan" error can happen in existing releases; but I'd rather not until
it has gotten more testing.
Tom Lane [Sun, 19 Jul 2009 20:32:48 +0000 (20:32 +0000)]
Fix a thinko in join_is_legal: when we decide we can implement a semijoin
by unique-ifying the RHS and then inner-joining to some other relation,
that is not grounds for violating the RHS of some other outer join.
Noticed while regression-testing new GEQO code, which will blindly follow
any path that join_is_legal says is legal, and then complain later if that
leads to a dead end.
I'm not certain that this can result in any visible failure in 8.4: the
mistake may always be masked by the fact that subsequent attempts to join
the rest of the RHS of the other join will fail. But I'm not certain it
can't, either, and it's definitely not operating as intended. So back-patch.
The added regression test depends on the new no-failures-allowed logic
that I'm about to commit in GEQO, so no point back-patching that.
Tom Lane [Sat, 18 Jul 2009 19:15:42 +0000 (19:15 +0000)]
Fix error cleanup failure caused by 8.4 changes in plpgsql to try to avoid
memory leakage in error recovery. We were calling FreeExprContext, and
therefore invoking ExprContextCallback callbacks, in both normal and error
exits from subtransactions. However this isn't very safe, as shown in
recent trouble report from Frank van Vugt, in which releasing a tupledesc
refcount failed. It's also unnecessary, since the resources that callbacks
might wish to release should be cleaned up by other error recovery mechanisms
(ie the resource owners). We only really want FreeExprContext to release
memory attached to the exprcontext in the error-exit case. So, add a bool
parameter to FreeExprContext to tell it not to call the callbacks.
A more general solution would be to pass the isCommit bool parameter on to
the callbacks, so they could do only safe things during error exit. But
that would make the patch significantly more invasive and possibly break
third-party code that registers ExprContextCallback callbacks. We might want
to do that later in HEAD, but for now I'll just do what seems reasonable to
back-patch.
Tom Lane [Fri, 17 Jul 2009 23:19:34 +0000 (23:19 +0000)]
Repair bug #4926 "too few pathkeys for mergeclauses". This example shows
that the sanity checking I added to create_mergejoin_plan() in 8.3 was a
few bricks shy of a load: the mergeclauses could reference pathkeys in a
noncanonical order such as x,y,x, not only cases like x,x,y which is all
that the code had allowed for. The odd cases only turn up when using
redundant clauses in an outer join condition, which is why no one had
noticed before.
Tom Lane [Thu, 16 Jul 2009 20:55:44 +0000 (20:55 +0000)]
Make GEQO's planning deterministic by having it start from a predictable
random number seed each time. This is how it used to work years ago, but
we got rid of the seed reset because it was resetting the main random()
sequence and thus having undesirable effects on the rest of the system.
To fix, establish a private random number state for each execution of
geqo(), and initialize the state using the new GUC variable geqo_seed.
People who want to experiment with different random searches can do so
by changing geqo_seed, but you'll always get the same plan for the same
value of geqo_seed (if holding all other planner inputs constant, of course).
The new state is kept in PlannerInfo by adding a "void *" field reserved
for use by join_search hooks. Most of the rather bulky code changes in
this commit are just arranging to pass PlannerInfo around to all the GEQO
functions (many of which formerly didn't receive it).
Andres Freund, with some editorialization by Tom
Tom Lane [Thu, 16 Jul 2009 17:43:52 +0000 (17:43 +0000)]
Add erand48() to the set of functions supported by our src/port/ library,
and extend configure to test for it properly instead of hard-wiring
an assumption that everybody but Windows has the rand48 functions.
(We do cheat to the extent of assuming that probing for erand48 will do
for the entire rand48 family.)
erand48() is unused as of this commit, but a followon patch will cause
GEQO to depend on it.
Andres Freund, additional hacking by Tom
Heikki Linnakangas [Thu, 16 Jul 2009 09:59:46 +0000 (09:59 +0000)]
pg_standby doesn't need to be linked with libpq. Fujii Masao.
Peter Eisentraut [Thu, 16 Jul 2009 06:33:46 +0000 (06:33 +0000)]
Make backend header files C++ safe
This alters various incidental uses of C++ key words to use other similar
identifiers, so that a C++ compiler won't choke outright. You still
(probably) need extern "C" { }; around the inclusion of backend headers.
based on a patch by Kurt Harriman <harriman@acm.org>
Also add a script cpluspluscheck to check for C++ compatibility in the
future. As of right now, this passes without error for me.
Peter Eisentraut [Tue, 14 Jul 2009 22:16:38 +0000 (22:16 +0000)]
Rearrangement of the HTML docs build rules
Set up proper makefile dependencies in the documentation build rules,
especially around the HTML/index build. The problem we've had with all
previous solutions is that we have used the same file name, such as HTML.index
or bookindex.sgml, to mean different things at different stages of the build,
and make can't distinguish that. The solution here is that the first jade run
produces HTML.index, but does not require bookindex.sgml at all, and produces
no other html output (the latter an idea from Alvaro). The second jade run
includes bookindex.sgml, but does not recreate HTML.index. That way, when you
change an sgml file, jade is run twice and at the end all dependencies are
satisfied. Omitting the html output in the first stage also makes the full
build a lot faster.
When you run one of the print format targets, only the first jade run is run,
then the print target-specific commands. If an HTML build has completed
previously, the first jade run is skipped because the dependencies have
already been satisfied.
The draft and check targets for quick builds and syntax verification are still
there.
Tom Lane [Tue, 14 Jul 2009 20:34:48 +0000 (20:34 +0000)]
Remove duplicate definition of TYPECAST token.
(Apparently, some but not all versions of Bison will warn about this.)
Tom Lane [Tue, 14 Jul 2009 20:24:10 +0000 (20:24 +0000)]
Tweak the core scanner so that it can be used by plpgsql too.
Changes:
Pass in the keyword lookup array instead of having it be hardwired.
(This incidentally allows elimination of some duplicate coding in ecpg.)
Re-order the token declarations in gram.y so that non-keyword tokens have
numbers that won't change when keywords are added or removed.
Add ".." and ":=" to the set of tokens recognized by scan.l. (Since these
combinations are nowhere legal in core SQL, this does not change anything
except the precise wording of the error you get when you write this.)
Tom Lane [Tue, 14 Jul 2009 15:37:50 +0000 (15:37 +0000)]
Do a conditional SPI_push/SPI_pop when replanning a query in
RevalidateCachedPlan. This is to avoid a "SPI_ERROR_CONNECT" failure when
the planner calls a SPI-using function and we are already inside one.
The alternative fix is to expect callers of RevalidateCachedPlan to do this,
which seems likely to result in additional hard-to-detect bugs of omission.
Per reports from Frank van Vugt and Marek Lewczuk.
Back-patch to 8.3. It's much harder to trigger the bug in 8.3, due to a
smaller set of cases in which plans can be invalidated, but it could happen.
(I think perhaps only a SI reset event could make 8.3 fail here, but that's
certainly within the realm of possibility.)
Bruce Momjian [Mon, 13 Jul 2009 22:56:30 +0000 (22:56 +0000)]
vacuumlo query cleanups
No need for VACUUM ANAYZE of newly created/populated temp table, just
use analyze.
No need to apologize for using subquery in DELETE anymore.
Peter Eisentraut [Mon, 13 Jul 2009 20:25:57 +0000 (20:25 +0000)]
Update information schema to SQL:2008
- yes_or_no domain for "boolean" data
- new columns for VIEWS view
- slight section renumbering
Tom Lane [Mon, 13 Jul 2009 05:36:53 +0000 (05:36 +0000)]
Make the configure messages rejecting old bison and flex versions include
the full path and version of the program being rejected.
Tom Lane [Mon, 13 Jul 2009 03:11:12 +0000 (03:11 +0000)]
Although the flex documentation avers that yyalloc and yyrealloc take
size_t arguments, the emitted scanner actually prototypes them with
type yy_size_t, which is sometimes not the same thing depending on
flex version and platform. Easiest fix seems to be to use yy_size_t.
Per buildfarm results.
Tom Lane [Mon, 13 Jul 2009 02:02:20 +0000 (02:02 +0000)]
Convert the core lexer and parser into fully reentrant code, by making use
of features added to flex and bison since this code was originally written.
This change doesn't in itself offer any new capability, but it's needed
infrastructure for planned improvements in plpgsql.
Another feature now available in flex is the ability to make it use palloc
instead of malloc, so do that to avoid possible memory leaks. (We should
at some point change the other lexers likewise, but this commit doesn't
touch them.)
Tom Lane [Mon, 13 Jul 2009 01:51:56 +0000 (01:51 +0000)]
Advance the minimum required version of "flex" from 2.5.4 to 2.5.31, and
update documentation accordingly. This is required in order to have support
for a reentrant scanner. I'm committing this bit separately in order to have
an easy reference if we later decide to make the minimum something different
(like 2.5.33).
Bruce Momjian [Mon, 13 Jul 2009 01:37:05 +0000 (01:37 +0000)]
Stamp minor library version numbers for 8.5; sorry for the delay.
Tom Lane [Mon, 13 Jul 2009 00:42:18 +0000 (00:42 +0000)]
Fix up PGDLLIMPORT marking for standard_conforming_strings. Moving it
into a header file that plpgsql's scan.l can see broke the previous
kluge. Per buildfarm results.
Tom Lane [Sun, 12 Jul 2009 17:12:34 +0000 (17:12 +0000)]
Move some declarations in the raw-parser header files to create a clearer
distinction between the external API (parser.h) and declarations that only
need to be visible within the raw parser code (gramparse.h, which now is only
included by parser.c, gram.y, scan.l, and keywords.c). This is in preparation
for the upcoming change to a reentrant lexer, which will require referencing
YYSTYPE in the declarations of base_yylex and filtered_base_yylex, hence
gram.h will have to be included by gramparse.h. We don't want any more files
than absolutely necessary to depend on gram.h, so some cleanup is called for.
Peter Eisentraut [Sat, 11 Jul 2009 21:15:32 +0000 (21:15 +0000)]
Alter some gratuitous uses of "ANSI" when "SQL standard" might have been
meant or the reference to a standard was unnecessary.
Peter Eisentraut [Sat, 11 Jul 2009 21:13:21 +0000 (21:13 +0000)]
Correct what ISO stands for
Tom Lane [Sat, 11 Jul 2009 04:09:33 +0000 (04:09 +0000)]
Fix set_rel_width() to do something reasonable with non-Var items in a
RelOptInfo targetlist. It used to be that the only possibility other than
a Var was a RowExpr representing a whole-row child Var, but as of 8.4's
expanded ability to flatten appendrel members, we can get arbitrary expressions
in there. Use the expression's type info and get_typavgwidth() to produce
an at-least-marginally-sane result. Note that get_typavgwidth()'s fallback
estimate (32 bytes) is the same as what was here before, so there will be
no behavioral change for RowExprs. Noted while looking at recent gripe
about constant quals pushed down to FunctionScan appendrel members ...
not only were we failing to recognize the constant qual, we were getting
the width estimate wrong :-(
Tom Lane [Fri, 10 Jul 2009 00:32:00 +0000 (00:32 +0000)]
Fix xslt_process() to ensure that it inserts a NULL terminator after the
last pair of parameter name/value strings, even when there are MAXPARAMS
of them. Aboriginal bug in contrib/xml2, noted while studying bug #4912
(though I'm not sure whether there's something else involved in that
report).
This might be thought a security issue, since it's a potential backend
crash; but considering that untrustworthy users shouldn't be allowed
to get their hands on xslt_process() anyway, it's probably not worth
getting excited about.
Tom Lane [Wed, 8 Jul 2009 18:55:35 +0000 (18:55 +0000)]
Remove no-longer-necessary transmission of postmaster's LC_COLLATE and
LC_CTYPE settings to children via BackendParameters. Per discussion,
the postmaster is now just using system defaults anyway, so we might as
well save a few cycles during backend startup.
Heikki Linnakangas [Wed, 8 Jul 2009 17:53:29 +0000 (17:53 +0000)]
Need to use pg_perm_setlocale when setting LC_CTYPE and LC_COLLATE at startup.
Otherwise, the LC_CTYPE/COLLATE setting gets reverted when using plperl, which
leads to incorrect query results and index corruption.
This was accidentally broken in the per-database locale patch in 8.4. Pointed
out by Andrew Gierth.
Tom Lane [Wed, 8 Jul 2009 17:21:55 +0000 (17:21 +0000)]
Add missing HOUR TO SECOND option to list of possible INTERVAL field sets,
as noted by Sebastien Flaesch. Also update the claim that we simply throw
away fields outside this set --- that got changed later to only discard
less-significant fields.
Peter Eisentraut [Wed, 8 Jul 2009 13:47:29 +0000 (13:47 +0000)]
When calling unsupported "make check" with a pgxs module, return a nonzero
exit code.
Tom Lane [Tue, 7 Jul 2009 21:45:05 +0000 (21:45 +0000)]
Just a little more schema-qualification ...
Peter Eisentraut [Tue, 7 Jul 2009 20:32:20 +0000 (20:32 +0000)]
psql backward compatibility fix
For servers older than 8.3, sort display of child tables by relname instead
of oid::regclass::text, because the cast from regclass to text did not work
back then. The older display may be slightly worse when different schemas
are involved, but that should be rare enough.
Tom Lane [Tue, 7 Jul 2009 19:28:56 +0000 (19:28 +0000)]
Don't use 'return' where you should use 'PG_RETURN_xxx'.
Tom Lane [Tue, 7 Jul 2009 19:28:00 +0000 (19:28 +0000)]
Query in SQL function still not schema-safe; add a couple
more pg_catalog. qualifications.
Peter Eisentraut [Tue, 7 Jul 2009 19:05:57 +0000 (19:05 +0000)]
Sort child tables by name instead of OID in \d+ display
This was an oversight in the recent patch. Found by Tom Lane.
Tom Lane [Tue, 7 Jul 2009 18:49:16 +0000 (18:49 +0000)]
Fix typo in comment.
Peter Eisentraut [Tue, 7 Jul 2009 18:23:15 +0000 (18:23 +0000)]
More sensible character_octet_length
For character types with typmod, character_octet_length columns in the
information schema now show the maximum character length times the
maximum length of a character in the server encoding, instead of some
huge value as before.
Tom Lane [Tue, 7 Jul 2009 16:28:38 +0000 (16:28 +0000)]
Code review for patch to show definition of index columns in \d on index.
Safely schema-qualify the pg_get_indexdef call, make the query a bit
prettier in -E mode, remove useless join to pg_index, make it more obvious
that the header[] array is not overrun.
Tom Lane [Mon, 6 Jul 2009 20:29:23 +0000 (20:29 +0000)]
Use floor() not rint() when reducing precision of fractional seconds in
timestamp_trunc, timestamptz_trunc, and interval_trunc(). This change
only affects the float-datetime case; the integer-datetime case already
behaved like truncation instead of rounding. Per gripe from Mario Splivalo.
This is a pre-existing issue but I'm choosing not to backpatch, because
it's such a corner case and there have not been prior complaints. The
issue is largely moot anyway given the trend towards integer datetimes.
Heikki Linnakangas [Mon, 6 Jul 2009 19:11:39 +0000 (19:11 +0000)]
Fix ancient bug in handling of to_char modifier 'TH', when used with HH.
In what seems like an oversight, we used to treat 'TH' the same as lowercase
'th', but only with HH/HH12.
Tom Lane [Mon, 6 Jul 2009 18:26:30 +0000 (18:26 +0000)]
Fix set_append_rel_pathlist() to deal intelligently with cases where
substituting a child rel's output expressions into the appendrel's restriction
clauses yields a pseudoconstant restriction. We might be able to skip scanning
that child rel entirely (if we get constant FALSE), or generate a one-time
filter. 8.3 more or less accidentally generated plans that weren't completely
stupid in these cases, but that was only because an extra recursive level of
subquery_planner() always occurred and allowed const-simplification to happen.
8.4's ability to pull up appendrel members with non-Var outputs exposes the
fact that we need to work harder here. Per gripe from Sergey Burladyan.
Peter Eisentraut [Mon, 6 Jul 2009 17:01:42 +0000 (17:01 +0000)]
Show definition of index columns in \d on index
This adds a column called "Definition" to the output of psql \d on an
index, which shows the full expression behind the index column. For indexes
on plain columns, this is redundant, but for expression indexes, this
reveals the real expression.
Author: Khee Chin <kheechin@gmail.com>
Tom Lane [Mon, 6 Jul 2009 02:58:40 +0000 (02:58 +0000)]
Per SQL spec (in particular, the grammar in SQL:2008 7.13) we should allow
parentheses around the <query expression body> that follows a WITH clause, eg
with cte(foo) as ( values(0) ) ((select foo from cte));
This seems to be just an oversight/thinko in gram.y. Noted while
experimenting with bug #4902.
Tom Lane [Mon, 6 Jul 2009 02:16:03 +0000 (02:16 +0000)]
Fix handling of changed-Param signaling for CteScan plan nodes. We were using
the "cteParam" as a proxy for the possibility that the underlying CTE plan
depends on outer-level variables or Params, but that doesn't work very well
because it sometimes causes calling subqueries to be treated as SubPlans when
they could be InitPlans. This is inefficient and also causes the outright
failure exhibited in bug #4902. Instead, leave the cteParam out of it and
copy the underlying CTE plan's extParams directly. Per bug #4902 from
Marko Tiikkaja.
Peter Eisentraut [Fri, 3 Jul 2009 19:14:25 +0000 (19:14 +0000)]
Add log_line_prefix placeholder %e to contain the current SQL state
Author: Guillaume Smet <guillaume.smet@gmail.com>
Peter Eisentraut [Fri, 3 Jul 2009 18:56:50 +0000 (18:56 +0000)]
Have \d show child tables that inherit from the specified parent
As per discussion, \d shows only the number of child tables, because that
could be hundreds, when used for partitioning. \d+ shows the actual list.
Author: Damien Clochard <damien@dalibo.info>
Tom Lane [Thu, 2 Jul 2009 21:34:32 +0000 (21:34 +0000)]
Fix up pg_dump's --binary-upgrade option so that it behaves properly with
inherited columns and check constraints. Per my recent trouble report.
Peter Eisentraut [Thu, 2 Jul 2009 18:55:40 +0000 (18:55 +0000)]
Upgrade to Autoconf 2.63
This upgrades the configure infrastructure to the latest Autoconf version.
Some notable news are:
- The workaround for the broken fseeko() test is gone.
- Checking for unknown options is now provided by Autoconf itself.
- Fixes for Mac OS X
Peter Eisentraut [Thu, 2 Jul 2009 07:03:18 +0000 (07:03 +0000)]
Regression test for XML mapping functionality
I wrote this one while chasing down some bugs in the closing days of 8.4. It
could be useful in the long run. This area of the code had no test coverage
at all before.
Tom Lane [Wed, 1 Jul 2009 23:57:33 +0000 (23:57 +0000)]
Remove useless References column for pg_listener catalog description. Per Shigehiro Honda.
Tom Lane [Wed, 1 Jul 2009 23:15:55 +0000 (23:15 +0000)]
Stamp HEAD as 8.5devel.
Tom Lane [Tue, 30 Jun 2009 17:38:50 +0000 (17:38 +0000)]
Add missed src/include/foreign subdirectory to the set installed into
INSTALLDIR/include/server/. Itagaki Takahiro
Tom Lane [Sat, 27 Jun 2009 21:06:46 +0000 (21:06 +0000)]
Revert addition of "o" to tar options. This was intended to fix bug #4883,
but the cure appears to be worse than the disease. It turns out that GNU
tar versions 1.14.x misinterpret -o as --same-owner, not --no-same-owner,
leading to exactly the wrong behavior for both root and nonroot users.
While that bug has been fixed for nearly five years, these tar versions
are still found in the wild, notably in OS X 10.4. Given that #4883 was
the first complaint we'd heard, it's definitely not worth fixing at the
risk of breaking things for other users. Perhaps revisit at a later date
when we're not up against a release deadline.
Marc G. Fournier [Sat, 27 Jun 2009 00:14:47 +0000 (00:14 +0000)]
Bundle v8.4.0
Tom Lane [Fri, 26 Jun 2009 22:23:17 +0000 (22:23 +0000)]
Update release notes in final preparation for 8.4.0.
Tom Lane [Fri, 26 Jun 2009 22:08:17 +0000 (22:08 +0000)]
Add a note about SystemTap vs DTrace spelling of probe names.
Tom Lane [Fri, 26 Jun 2009 22:06:11 +0000 (22:06 +0000)]
Marginal improvement of description of recovery_end_command.
Tom Lane [Fri, 26 Jun 2009 20:29:04 +0000 (20:29 +0000)]
Cleanup and code review for the patch that made bgwriter active during
archive recovery. Invent a separate state variable and inquiry function
for XLogInsertAllowed() to clarify some tests and make the management of
writing the end-of-recovery checkpoint less klugy. Fix several places
that were incorrectly testing InRecovery when they should be looking at
RecoveryInProgress or XLogInsertAllowed (because they will now be executed
in the bgwriter not startup process). Clarify handling of bad LSNs passed
to XLogFlush during recovery. Use a spinlock for setting/testing
SharedRecoveryInProgress. Improve quite a lot of comments.
Heikki and Tom
Peter Eisentraut [Fri, 26 Jun 2009 19:33:52 +0000 (19:33 +0000)]
Translation updates for 8.4 release.
File that are translated less than 80% have been removed, as per new
translation team policy.
Peter Eisentraut [Fri, 26 Jun 2009 06:40:57 +0000 (06:40 +0000)]
Extract tarballs with "o" option (tar xof), to behave reasonably when run
as root, as would usually be the case during make install.
per bug #4883
Peter Eisentraut [Fri, 26 Jun 2009 06:37:14 +0000 (06:37 +0000)]
Use $(TAR) instead of tar in makefiles.
Tom Lane [Thu, 25 Jun 2009 23:07:15 +0000 (23:07 +0000)]
Add __attribute__((format_arg(1))) to the declaration of err_gettext(),
to restore gcc's ability to crosscheck format arguments within elog.c.
Noted in a test compilation with -Wformat-nonliteral enabled.
Heikki Linnakangas [Thu, 25 Jun 2009 21:36:00 +0000 (21:36 +0000)]
Fix some serious bugs in archive recovery, now that bgwriter is active
during it:
When bgwriter is active, the startup process can't perform mdsync() correctly
because it won't see the fsync requests accumulated in bgwriter's private
pendingOpsTable. Therefore make bgwriter responsible for the end-of-recovery
checkpoint as well, when it's active.
When bgwriter is active (= archive recovery), the startup process must not
accumulate fsync requests to its own pendingOpsTable, since bgwriter won't
see them there when it performs restartpoints. Make startup process drop its
pendingOpsTable when bgwriter is launched to avoid that.
Update minimum recovery point one last time when leaving archive recovery.
It won't be updated by the end-of-recovery checkpoint because XLogFlush()
sees us as out of recovery already.
This fixes bug #4879 reported by Fujii Masao.
Peter Eisentraut [Thu, 25 Jun 2009 21:15:38 +0000 (21:15 +0000)]
Man pages back to lowercase names, with additional fixup to make the .so
links work.
Tom Lane [Thu, 25 Jun 2009 19:33:25 +0000 (19:33 +0000)]
Make prior patch pgindent-safe.
Heikki Linnakangas [Thu, 25 Jun 2009 19:05:52 +0000 (19:05 +0000)]
The code to unlink dropped relations in FinishPreparedTransaction() was
acting like runs inside WAL recovery, but it doesn't. I must've copy-pasted
this from a redo-function in the relation forks patch. Noticed by Tom Lane
while he was looking through callers of smgrdounlink().
Heikki Linnakangas [Thu, 25 Jun 2009 12:03:11 +0000 (12:03 +0000)]
Disable pg_standby -l option because the backend doesn't expect the recovered
file to be a symlink. We tried to fix this issue with an earlier server-side
patch, but it didn't fix the whole issue.
The same bug is present in older releases as well, but the 8.4 train is
about to leave the station, and I'm not sure if have consensus on whether
we can remove the -l option in back-branches or do we need to attempt a
server-side fix to make symlinking safe.
Patch by Simon Riggs, per discussion on bug identified by Fujii Masao.
Magnus Hagander [Thu, 25 Jun 2009 11:30:08 +0000 (11:30 +0000)]
Disallow empty passwords in LDAP authentication, the same way
we already do it for PAM.
Peter Eisentraut [Wed, 24 Jun 2009 15:16:22 +0000 (15:16 +0000)]
Correct grammar in picksplit debug messages
Magnus Hagander [Wed, 24 Jun 2009 13:46:32 +0000 (13:46 +0000)]
Fix incorrect LDAP example, noted by Tom.
Magnus Hagander [Wed, 24 Jun 2009 13:39:42 +0000 (13:39 +0000)]
parse_ident_usermap() shuold use ereport(LOG) and not ERROR, and put the
return value in the *error_p variable.
Noted by Tom.
Tom Lane [Tue, 23 Jun 2009 20:33:25 +0000 (20:33 +0000)]
Provide a link to the UPDATE reference page in the 'Updating Data'
section of the docs. Per suggestion from Brad Bowman.
Magnus Hagander [Tue, 23 Jun 2009 18:13:23 +0000 (18:13 +0000)]
Properly initialize SSL engines when used from libpq. This is required for
most external engines.
Per report and initial code from Lars Kanis
Tom Lane [Tue, 23 Jun 2009 16:25:02 +0000 (16:25 +0000)]
Fix an ancient error in dist_ps (distance from point to line segment), which
a number of other geometric operators also depend on. It miscalculated the
slope of the perpendicular to the given line segment anytime that slope was
other than 0, infinite, or +/-1. In some cases the error would be masked
because the true closest point on the line segment was one of its endpoints
rather than the intersection point, but in other cases it could give an
arbitrarily bad answer. Per bug #4872 from Nick Roosevelt.
Bug goes clear back to Berkeley days, so patch all supported branches.
Make a couple of cosmetic adjustments while at it.
Tom Lane [Tue, 23 Jun 2009 03:46:00 +0000 (03:46 +0000)]
Fix the makefiles to fail cleanly if Perl is needed but not present. This
used to work as intended, but got broken some time ago (a quoted empty string
is not an empty string), and got broken some more by the changes to generate
ecpg's preproc.y automatically. Given all the unprotected uses of $(PERL)
elsewhere, it seems best to make use of the $(missing) script rather than
trying to ensure each such use is protected individually. Also fix various
bits of documentation that omitted to mention Perl as a requirement for
building from a CVS pull. Per a complaint from Robert Haas.
Marc G. Fournier [Mon, 22 Jun 2009 23:15:02 +0000 (23:15 +0000)]
bundle RC2
Tom Lane [Mon, 22 Jun 2009 20:04:28 +0000 (20:04 +0000)]
For bulk write operations (eg COPY IN), use a ring buffer of 16MB instead
of the 256KB limit originally enforced by a patch committed 2008-11-06.
Per recent test results, the smaller size resulted in an undesirable decrease
in bulk data loading speed, due to COPY processing frequently getting blocked
for WAL flushing. This area might need more tweaking later, but this setting
seems to be good enough for 8.4.
Tom Lane [Mon, 22 Jun 2009 17:54:30 +0000 (17:54 +0000)]
Make to_timestamp and friends skip leading spaces before an integer field,
even when not in FM mode. This improves compatibility with Oracle and with
our pre-8.4 behavior, as per bug #4862.
Brendan Jurd
Add a couple of regression test cases for this. In passing, get rid of the
labeling of the individual test cases; doesn't seem to be good for anything
except causing extra work when inserting a test...
Tom Lane
Peter Eisentraut [Mon, 22 Jun 2009 07:12:50 +0000 (07:12 +0000)]
Add more explicit note that the parameters of MOVE are identical to FETCH.
per David Wheeler
Tom Lane [Mon, 22 Jun 2009 04:37:18 +0000 (04:37 +0000)]
Revert dubious message wording change.
Peter Eisentraut [Sun, 21 Jun 2009 20:15:32 +0000 (20:15 +0000)]
Message fixes
Tom Lane [Sat, 20 Jun 2009 18:45:28 +0000 (18:45 +0000)]
Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure. By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever. Adjust documentation and comments
to match that conclusion.
Peter Eisentraut [Fri, 19 Jun 2009 19:15:13 +0000 (19:15 +0000)]
Extend man page installation hackery so that the man page section is also
fixed up in the .so links.
Peter Eisentraut [Fri, 19 Jun 2009 19:14:25 +0000 (19:14 +0000)]
Don't convert the man page names to lower case, so that the .so links work.
This is pretty much a workaround for incomplete tools, but having the man
page names in upper case looks more natural anyway.
Peter Eisentraut [Fri, 19 Jun 2009 15:28:25 +0000 (15:28 +0000)]
Add manvolnum, so that man pages are generated.
Peter Eisentraut [Thu, 18 Jun 2009 15:10:35 +0000 (15:10 +0000)]
Don't attempt to "rm" directories on uninstall.
Peter Eisentraut [Thu, 18 Jun 2009 14:42:08 +0000 (14:42 +0000)]
Recursive Joins -> Recursive Queries
per Erik Rijkers
Peter Eisentraut [Thu, 18 Jun 2009 14:34:36 +0000 (14:34 +0000)]
Add some more documentation and cross-links on using dblink with SQL/MED.
Peter Eisentraut [Thu, 18 Jun 2009 10:22:09 +0000 (10:22 +0000)]
Refine the use of terminology around bound and unbound cursors and cursor
variables. Remove the confusing term "reference cursor".
Heikki Linnakangas [Thu, 18 Jun 2009 10:08:08 +0000 (10:08 +0000)]
Fix a few errors in comments. Patch by Fujii Masao, plus the one in
visibilitymap.c by me.
Tom Lane [Thu, 18 Jun 2009 01:27:02 +0000 (01:27 +0000)]
Fix the just-reported problem that you can't specify all four trigger event
types in CREATE TRIGGER. While at it, clean up the amazingly tedious and
inextensible way that the trigger event type list was handled. Per report
from Greg Sabino Mullane.
Tom Lane [Wed, 17 Jun 2009 21:58:49 +0000 (21:58 +0000)]
Proofreading for Bruce's recent round of documentation proofreading.
Most of those changes were good, but some not so good ...
Tom Lane [Wed, 17 Jun 2009 16:05:34 +0000 (16:05 +0000)]
ExecAgg() failed to finish running out set-returning functions in the last
aggregated tuple of a run. Per report from Laurenz Albe. This is a new
bug in 8.4, but only because prior versions rejected SRFs in an Agg plan
node altogether.
Peter Eisentraut [Wed, 17 Jun 2009 13:59:28 +0000 (13:59 +0000)]
Add another link of a GUC variable to where it is explained.
Peter Eisentraut [Wed, 17 Jun 2009 13:46:12 +0000 (13:46 +0000)]
Fix typo in error message: tgargv -> tg_argv
Tom Lane [Sun, 14 Jun 2009 00:00:24 +0000 (00:00 +0000)]
Change test tables in copy2 regression test to be temporary tables.
This prevents autovacuum from reclaiming free space in them and causing
the test's output row order to change, which is causing intermittent
bogus failure reports in the buildfarm.
Backpatch to 8.3. The issue exists further back, but since autovacuum was
not on by default before 8.3, it's not a problem for buildfarm testing.
Tom Lane [Sat, 13 Jun 2009 15:42:09 +0000 (15:42 +0000)]
Fix get_sort_group_operators() so that it doesn't think arrays can be grouped
via hashing. Eventually we ought to make that possible, but it won't happen
for 8.4. Per yesterday's report from Robert Haas.