OSDN Git Service
Benjamin Kramer [Sat, 15 Mar 2014 18:47:07 +0000 (18:47 +0000)]
Make some assertions on constant expressions static.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204011
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 18:10:49 +0000 (18:10 +0000)]
PointerIntPair: Avoid an (academic) case of undefined behavior in the DenseMapInfo specialization.
If we use a pair with an enum type this could create values outside
of the enum range. Avoid it by creating the bit pattern directly.
While there turn a dynamic assert into a static one. No functionality
change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204010
91177308-0d34-0410-b5e6-
96231b3b80d8
Benjamin Kramer [Sat, 15 Mar 2014 17:17:48 +0000 (17:17 +0000)]
LSR: Compress a pair (and get rid of the DenseMapInfo for it).
Also convert a horrible hash function to use our hashing infrastructure.
No functionality change.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204008
91177308-0d34-0410-b5e6-
96231b3b80d8
Patrik Hagglund [Sat, 15 Mar 2014 09:11:41 +0000 (09:11 +0000)]
Replace ValueTypes.h with MachineValueType.h if possible.
Utilize the previous move of MVT to a separate header for all trivial
cases (that don't need any further restructuring).
Reviewed By: Tim Northover
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204003
91177308-0d34-0410-b5e6-
96231b3b80d8
Justin Bogner [Sat, 15 Mar 2014 04:05:59 +0000 (04:05 +0000)]
Support: Make error_category's constructor public
Since our error_category is based on the std one, we should have the
same visibility for the constructor. This also allows us to avoid
using the _do_message implementation detail in our own categories.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203998
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 02:32:21 +0000 (02:32 +0000)]
llvm/test/Transforms/SampleProfile/syntax.ll: Suppress checking the message catalog in ENOENT. It is locale-dependent on Windows.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203997
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 01:56:17 +0000 (01:56 +0000)]
SampleProfile.cpp: Fix take #2. The issue was abuse of StringRef here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203996
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Sat, 15 Mar 2014 00:10:12 +0000 (00:10 +0000)]
SampleProfile.cpp: Quick fix to r203976 about abuse of Twine. The life of Twine was too short.
FIXME: DiagnosticInfoSampleProfile should not hold Twine&.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203990
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 15 Mar 2014 00:08:26 +0000 (00:08 +0000)]
R600: Remove unnecessary attempt to zext a pointer.
Private pointers are now always 32-bits.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203989
91177308-0d34-0410-b5e6-
96231b3b80d8
Matt Arsenault [Sat, 15 Mar 2014 00:08:22 +0000 (00:08 +0000)]
R600: Code cleanup.
Use sign_extend_inreg and getZeroExtendInReg instead of
using the bit operations they expand into.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203988
91177308-0d34-0410-b5e6-
96231b3b80d8
Rui Ueyama [Sat, 15 Mar 2014 00:04:08 +0000 (00:04 +0000)]
Object/COFF: change data type of SymbolNumber from int16 to uint16.
Microsoft PE/COFF Spec clearly states that the field is of signed interger
type. However, in reality, it's unsigned. If cl.exe needs to create a large
number of sections for COMDAT sections, it will just create more than 32768
sections. Handling large section number as negative number is not correct.
I think this is a spec bug.
Differential Revision: http://llvm-reviews.chandlerc.com/D3088
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203986
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:29 +0000 (23:08 +0000)]
Debug info: Unique types before emitting them to DWARF, where applicable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203983
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:25 +0000 (23:08 +0000)]
Debug Info: Fix LTO type uniquing for C++ member declarations
based on the ODR.
This adds an OdrMemberMap to DwarfDebug which is used to unique C++
member function declarations based on the unique identifier of their
containing class and their mangled name.
We can't use the usual DIRef mechanism here because DIScopes are indexed
using their entire MDNode, including decl_file and decl_line, which need
not be unique (see testcase).
Prior to this change multiple redundant member function declarations would
end up in the same uniqued DW_TAG_class_type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203982
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:21 +0000 (23:08 +0000)]
Re-add checks that were in this testcase before it was converted to dwarfdump.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203981
91177308-0d34-0410-b5e6-
96231b3b80d8
Adrian Prantl [Fri, 14 Mar 2014 23:08:17 +0000 (23:08 +0000)]
typo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203980
91177308-0d34-0410-b5e6-
96231b3b80d8
Jim Grosbach [Fri, 14 Mar 2014 22:41:58 +0000 (22:41 +0000)]
MC: don't create a backtrace for diagnostics.
For better or worse, this is currently the normal error reporting path
when dealing with backend errors from inline assembly. It's not just
internal compiler issues that come through here, so we shouldn't be
creating a backtrace on this path.
rdar://
16329947
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203979
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Fri, 14 Mar 2014 22:07:18 +0000 (22:07 +0000)]
Re-format SampleProfile.cpp with clang-format. No functional changes.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203977
91177308-0d34-0410-b5e6-
96231b3b80d8
Diego Novillo [Fri, 14 Mar 2014 21:58:59 +0000 (21:58 +0000)]
Use DiagnosticInfo facility.
Summary:
The sample profiler pass emits several error messages. Instead of
just aborting the compiler with report_fatal_error, we can emit
better messages using DiagnosticInfo.
This adds a new sub-class of DiagnosticInfo to handle the sample
profiler.
Reviewers: chandlerc, qcolombet
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3086
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203976
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 21:20:07 +0000 (21:20 +0000)]
Remove command line option for CU hashing. This is on by default now.
Fix up testcases and use of flag.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203973
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 21:16:54 +0000 (21:16 +0000)]
Make the arbitrary section name be something mach-o compatible.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203972
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 20:53:49 +0000 (20:53 +0000)]
If we see that we're emitting code for a function that doesn't have
any lexical scopes then go ahead and turn on DW_AT_ranges for the
compile unit since we would be claiming to describe in the CU
a range for which we don't have information in the CU otherwise.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203969
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Fri, 14 Mar 2014 20:53:43 +0000 (20:53 +0000)]
Remove the -generate-dwarf-cu-ranges flag.
Rewrite a couple of testcases to cover areas that would be normally
by turning it on into testcases that will follow the logic.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203968
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 14 Mar 2014 20:36:44 +0000 (20:36 +0000)]
MCDwarf: Initialize MCLineTableHeader::Label
This sometimes remains null into MCLineTableHeader::Emit where we
conditionally construct a label if one isn't provided for us. We need it
to remain null (rather than just always constructing the label) so we
can identify unused line tables... which is a bit weird and maybe we can
do away with that logic one day (& on that day we can always construct
the label up-front and just have compilation units query the line table
for its label, etc)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203967
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 14 Mar 2014 20:09:26 +0000 (20:09 +0000)]
MCContext: Remove redundant assignment
The member variable is not initialized in the ctor so it's already
empty. No need to empty it again.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203963
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 14 Mar 2014 20:09:04 +0000 (20:09 +0000)]
Correctly handle an ELF symbol defined with "a = b + expr".
We were marking the symbol as absolute instead of computing b's offset + the
expression value.
This fixes pr19126.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203962
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 14 Mar 2014 19:53:39 +0000 (19:53 +0000)]
Remove unnecessary StringRef::str() call where an implicit conversion works just fine.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203960
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Fri, 14 Mar 2014 16:33:32 +0000 (16:33 +0000)]
DwarfDebug: Remove some needless recursion.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203946
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 14 Mar 2014 16:29:21 +0000 (16:29 +0000)]
x86: Add missing break to getCallPreservedMask()
This change brings getCallPreservedMask()'s logic in line with
getCalleeSavedRegs().
While this changes the control flow slightly, the change is not
currently observable. is64Bit must be false to get to the accidental
fallthrough, but the case that we fall into (coldcc) does nothing unless
is64Bit is true.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203943
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 14 Mar 2014 16:09:13 +0000 (16:09 +0000)]
x86: NFC: Make getCallPreservedMask() more similar to getCalleeSavedRegs()
Changing order of checks in getCallPreservedMask() to match
getCalleeSavedRegs() so that the logic is easier to compare.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203939
91177308-0d34-0410-b5e6-
96231b3b80d8
Richard Osborne [Fri, 14 Mar 2014 15:53:50 +0000 (15:53 +0000)]
[docs] Add links to XMOS XCore documentation.
Summary: Add links to XCore ISA and ABI documents.
CC: llvm-commits, rafael
Differential Revision: http://llvm-reviews.chandlerc.com/D2981
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203936
91177308-0d34-0410-b5e6-
96231b3b80d8
Duncan P. N. Exon Smith [Fri, 14 Mar 2014 15:38:12 +0000 (15:38 +0000)]
x86: getCalleeSavedRegs() would crash on 0 (so don't default to it)
The current logic assumes that MF is not 0. Assert that it isn't, and
remove the default of 0 from the header.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203934
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Fri, 14 Mar 2014 15:13:35 +0000 (15:13 +0000)]
Fix a bug introduced during the transition to PathV2.
sys::fs::createUniqueFile returns an absolute path, so MakeSharedObject does
too and we don't need to add a './' prefix.
Patch by Jon McLachlan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203931
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 14 Mar 2014 14:52:03 +0000 (14:52 +0000)]
Delete unused ObjectFile::{begin,end}_symbols()
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203928
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 14 Mar 2014 14:22:49 +0000 (14:22 +0000)]
[C++11] Introduce SectionRef::relocations() to use range-based loops
Reviewers: rafael
Reviewed By: rafael
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3077
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203927
91177308-0d34-0410-b5e6-
96231b3b80d8
Patrik Hagglund [Fri, 14 Mar 2014 13:41:09 +0000 (13:41 +0000)]
Separate out MVT in a separate header file: MachineValueType.h
The idea behind this split of ValueTypes.h, is to make it easier to
ensure that stuff after type legalization only use MVT (rather than
EVT), by watching include dependencies.
Reviewed By: Tim Northover
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203926
91177308-0d34-0410-b5e6-
96231b3b80d8
Ulrich Weigand [Fri, 14 Mar 2014 12:45:22 +0000 (12:45 +0000)]
[ppc64] Avoid copy relocs in named rodata sections
Commit r181723 introduced code to avoid placing initialized variables
needing relocations into the .rodata section, which avoid copy relocs
that do not work as expected on ppc64 function references.
The same treatment is also needed for *named* .rodata.XXX sections.
This patch changes PPC64LinuxTargetObjectFile::SelectSectionForGlobal
to modify "Kind" *before* calling the default SelectSectionForGlobal
routine, instead of first calling the default routine and then just
checking for the (main) .rodata section afterwards.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203921
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexander Potapenko [Fri, 14 Mar 2014 10:41:49 +0000 (10:41 +0000)]
[ASan] Fix https://code.google.com/p/address-sanitizer/issues/detail?id=274
by ignoring globals from __TEXT,__cstring,cstring_literals during instrumenation.
Add a regression test.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203916
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 14 Mar 2014 10:37:36 +0000 (10:37 +0000)]
Use ctor instead of initializer list to appease Windows buildbots
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203915
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Fri, 14 Mar 2014 10:20:10 +0000 (10:20 +0000)]
Use temporary instead of a local variable here
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203914
91177308-0d34-0410-b5e6-
96231b3b80d8
Oliver Stannard [Fri, 14 Mar 2014 09:10:26 +0000 (09:10 +0000)]
Generalise assembly tests to not rely on anonymous symbol names
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203909
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Fri, 14 Mar 2014 08:58:04 +0000 (08:58 +0000)]
AddressSanitizer instrumentation for MOV and MOVAPS.
This is an initial version of *Sanitizer instrumentation of assembly code.
Patch by Yuri Gorshenin.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203908
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Fri, 14 Mar 2014 08:48:52 +0000 (08:48 +0000)]
MergeFunctions, cmpType: fixed variable names from XXTy1 and XXTy2 to XXTyL and XXTyR.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203907
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Fri, 14 Mar 2014 08:17:19 +0000 (08:17 +0000)]
MergeFunctions, cmpType: Fixed comments wrapping.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203905
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 14 Mar 2014 06:53:30 +0000 (06:53 +0000)]
[yaml2obj][ELF] Use range-based for loops.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203900
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 14 Mar 2014 06:53:25 +0000 (06:53 +0000)]
[yaml2obj][ELF] Refer to a section in the error message by its name not
index.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203899
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 14 Mar 2014 06:53:21 +0000 (06:53 +0000)]
[yaml2obj][ELF] Remove unused ELFState class field.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203898
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 14 Mar 2014 06:53:16 +0000 (06:53 +0000)]
[yaml2obj][ELF] Assign name (.shstrtab) to the section holds sections names.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203897
91177308-0d34-0410-b5e6-
96231b3b80d8
Simon Atanasyan [Fri, 14 Mar 2014 06:53:10 +0000 (06:53 +0000)]
[Mips] Add one more MIPS relocation type constant.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203896
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Fri, 14 Mar 2014 05:02:18 +0000 (05:02 +0000)]
Revert r203883 (which was more of a bandaid) and fix the real underlying
issue in that the new MachineRegisterInfo bundle iterators didn't
dereference to the START of the bundle, while the old skipBundle()
method did.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203890
91177308-0d34-0410-b5e6-
96231b3b80d8
Sebastian Pop [Fri, 14 Mar 2014 04:04:14 +0000 (04:04 +0000)]
static link polly into tools
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203886
91177308-0d34-0410-b5e6-
96231b3b80d8
Pete Cooper [Fri, 14 Mar 2014 02:28:05 +0000 (02:28 +0000)]
Fix issue with r203865. The old behaviour would get a MachineOperand then find the MI for the bundle the MI was in. The new behaviour was failing to get the parent bundle and instead just used the MI from the MachineOperand
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203883
91177308-0d34-0410-b5e6-
96231b3b80d8
Galina Kistanova [Fri, 14 Mar 2014 01:56:55 +0000 (01:56 +0000)]
Reverted r203879.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203880
91177308-0d34-0410-b5e6-
96231b3b80d8
Galina Kistanova [Fri, 14 Mar 2014 01:43:46 +0000 (01:43 +0000)]
Fixed misuse of isascii. Also fixes mingw32 build, see msdn.microsoft.com/en-us/library/ms235417.aspx
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203879
91177308-0d34-0410-b5e6-
96231b3b80d8
Eric Christopher [Thu, 13 Mar 2014 23:26:25 +0000 (23:26 +0000)]
Use DW_AT_linkage_name when we're emitting DWARF4 or above.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203867
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 13 Mar 2014 23:18:37 +0000 (23:18 +0000)]
Remove the linker_private and linker_private_weak linkages.
These linkages were introduced some time ago, but it was never very
clear what exactly their semantics were or what they should be used
for. Some investigation found these uses:
* utf-16 strings in clang.
* non-unnamed_addr strings produced by the sanitizers.
It turns out they were just working around a more fundamental problem.
For some sections a MachO linker needs a symbol in order to split the
section into atoms, and llvm had no idea that was the case. I fixed
that in r201700 and it is now safe to use the private linkage. When
the object ends up in a section that requires symbols, llvm will use a
'l' prefix instead of a 'L' prefix and things just work.
With that, these linkages were already dead, but there was a potential
future user in the objc metadata information. I am still looking at
CGObjcMac.cpp, but at this point I am convinced that linker_private
and linker_private_weak are not what they need.
The objc uses are currently split in
* Regular symbols (no '\01' prefix). LLVM already directly provides
whatever semantics they need.
* Uses of a private name (start with "\01L" or "\01l") and private
linkage. We can drop the "\01L" and "\01l" prefixes as soon as llvm
agrees with clang on L being ok or not for a given section. I have two
patches in code review for this.
* Uses of private name and weak linkage.
The last case is the one that one could think would fit one of these
linkages. That is not the case. The semantics are
* the linker will merge these symbol by *name*.
* the linker will hide them in the final DSO.
Given that the merging is done by name, any of the private (or
internal) linkages would be a bad match. They allow llvm to rename the
symbols, and that is really not what we want. From the llvm point of
view, these objects should really be (linkonce|weak)(_odr)?.
For now, just keeping the "\01l" prefix is probably the best for these
symbols. If we one day want to have a more direct support in llvm,
IMHO what we should add is not a linkage, it is just a hidden_symbol
attribute. It would be applicable to multiple linkages. For example,
on weak it would produce the current behavior we have for objc
metadata. On internal, it would be equivalent to private (and we
should then remove private).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203866
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 13 Mar 2014 23:12:04 +0000 (23:12 +0000)]
Phase 2 of the great MachineRegisterInfo cleanup. This time, we're changing
operator* on the by-operand iterators to return a MachineOperand& rather than
a MachineInstr&. At this point they almost behave like normal iterators!
Again, this requires making some existing loops more verbose, but should pave
the way for the big range-based for-loop cleanups in the future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203865
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 13 Mar 2014 22:51:43 +0000 (22:51 +0000)]
Fix a bug in InstCombine where we would incorrectly attempt to construct a
bitcast between pointers of two different address spaces if they happened to have
the same pointer size.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203862
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 21:59:51 +0000 (21:59 +0000)]
MCDwarf: Rename MCDwarfFileTable to MCDwarfLineTable
This type now represents all the data for the DWARF line table:
directory names, file names, and the line table proper.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203858
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 21:47:12 +0000 (21:47 +0000)]
MCDwarf: Extract the DWARF line table header handling into its own type
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203856
91177308-0d34-0410-b5e6-
96231b3b80d8
Lang Hames [Thu, 13 Mar 2014 21:25:37 +0000 (21:25 +0000)]
Make GDBJITRegistrar thread safe. Patch by Jim Kearyn, with cleanup by
Ivan Puzyrevskiy.
Fixes PR15750. Thanks Jim and Ivan.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203853
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 13 Mar 2014 21:25:10 +0000 (21:25 +0000)]
Fix a subtle issue introduced my my recent changes to MachineRegisterInfo iterators.
When initializing an iterator, we may have to step forward to find the first
operand that passes the current filter set. When doing that stepping, we should
always step one operand at a time, even if this is by-instr or by-bundle iterator,
as we're stepping between invalid values, so the stride doesn't make sense there.
Fixes a miscompilation of YASM on Win32 reported by Hans Wennborg. I have not
yet figured out how to reduce it to something testcase-able, because it's sensitive
to the details of how the registers get spilled.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203852
91177308-0d34-0410-b5e6-
96231b3b80d8
Kevin Enderby [Thu, 13 Mar 2014 20:31:19 +0000 (20:31 +0000)]
Add -mtriple=x86_64-linux to this test case to fix the build bots.5
The original commit was r203829.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203844
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 19:15:04 +0000 (19:15 +0000)]
MCDwarf: Sink file/directory creation down into MCDwarfFileTable form MCContext
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203836
91177308-0d34-0410-b5e6-
96231b3b80d8
Stephan Tolksdorf [Thu, 13 Mar 2014 19:07:39 +0000 (19:07 +0000)]
Test commit - remove trailing whitespace
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203834
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 19:05:33 +0000 (19:05 +0000)]
MCDwarf: Oh, and move the directory string over to std::string as well
(see r203831 for similar stuff)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203833
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 18:55:04 +0000 (18:55 +0000)]
MCDwarf: Simplify MCDwarfFile to just use std::string instead of cunning use of MCContext's allocator.
There aren't /that/ many files, and we are already using various maps
and other standard containers that don't use MCContext's allocator to
store these values, so this doesn't seem to be critical and simplifies
the design (I'll be moving construction out of MCContext shortly so it'd
be annoying to have to pass the allocator around to allocate these
things... and we'll have non-MCContext users (debug_line.dwo) shortly)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203831
91177308-0d34-0410-b5e6-
96231b3b80d8
Ekaterina Romanova [Thu, 13 Mar 2014 18:47:12 +0000 (18:47 +0000)]
Fix for http://llvm.org/bugs/show_bug.cgi?id=18590
This patch fixes the bug in peephole optimization that folds a load which defines one vreg into the one and only use of that vreg. With debug info, a DBG_VALUE that referenced the vreg considered to be a use, preventing the optimization. The fix is to ignore DBG_VALUE's during the optimization, and undef a DBG_VALUE that references a vreg that gets removed.
Patch by Trevor Smigiel!
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203829
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 18:21:24 +0000 (18:21 +0000)]
MCDwarf: Simply MCDwarfFile since it really is just a StringRef and unsigned.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203827
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 13 Mar 2014 18:09:26 +0000 (18:09 +0000)]
Use printable names to implement directional labels.
This changes the implementation of local directional labels to use a dedicated
map. With that it can then just use CreateTempSymbol, which is what the rest
of MC uses.
CreateTempSymbol doesn't do a great job at making sure the names are unique
(or being efficient when the names are not needed), but that should probably
be fixed in a followup patch.
This fixes pr18928.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203826
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Thu, 13 Mar 2014 18:04:41 +0000 (18:04 +0000)]
Update my e-mail address in CODE_OWNERS.TXT
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203824
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 17:58:09 +0000 (17:58 +0000)]
Remove stale comment
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203823
91177308-0d34-0410-b5e6-
96231b3b80d8
David Blaikie [Thu, 13 Mar 2014 17:55:28 +0000 (17:55 +0000)]
MCDwarf: Refactor line table handling into a single data structure
This replaces several "compile unit ID -> thing" mappings in favor of
one mapping from CUID to the whole line table structure (files,
directories, and lines).
This is another step along the way to refactoring out reusable
components of line table handling for use when generating debug_line.dwo
for fission type units.
Also, might be a good basis to fold some of this handling down into
MCStreamers to avoid the special case of "One line table when doing asm
printing, line table per CU otherwise" by building it into the different
MCStreamer implementations.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203821
91177308-0d34-0410-b5e6-
96231b3b80d8
Tom Stellard [Thu, 13 Mar 2014 17:13:04 +0000 (17:13 +0000)]
R600: LDS instructions shouldn't implicitly define OQAP
LDS instructions are pseudo instructions which model
the OQAP defs and uses within a single instruction.
This fixes a hang in the opencv MedianFilter tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203818
91177308-0d34-0410-b5e6-
96231b3b80d8
Mark Seaborn [Thu, 13 Mar 2014 16:23:00 +0000 (16:23 +0000)]
Cleanup: Remove use of old "-enable-correct-eh-support" option from a test
This option enables LowerInvoke's obsolete SJLJ EH support, but the
target used in this test (ARM Darwin) no longer uses the LowerInvoke
pass, so the option has no effect here. This target currently uses
the newer SjLjEHPrepare pass instead.
This cleanup will help with removing "-enable-correct-eh-support".
Differential Revision: http://llvm-reviews.chandlerc.com/D3064
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203810
91177308-0d34-0410-b5e6-
96231b3b80d8
Hans Wennborg [Thu, 13 Mar 2014 15:56:41 +0000 (15:56 +0000)]
[ARM] Use symbolic register names in .cfi directives only with IAS (PR19110)
This is a follow-up to r203635. Saleem pointed out that since symbolic register
names are much easier to read, it would be good if we could turn them off only
when we really need to because we're using an external assembler.
Differential Revision: http://llvm-reviews.chandlerc.com/D3056
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203806
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Thu, 13 Mar 2014 14:37:36 +0000 (14:37 +0000)]
[C++11] Use ObjectFile::sections() in commandline llvm tools
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203802
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Thu, 13 Mar 2014 13:52:54 +0000 (13:52 +0000)]
[C++11] Introduce ObjectFile::sections().
Summary:
This adds ObjectFile::section_iterator_range, that allows to write
range-based for-loops running over all sections of a given file.
Several files from lib/ are converted to the new interface. Similar fixes
should be applied to a variety of llvm-* tools.
Reviewers: rafael
Reviewed By: rafael
CC: llvm-commits
Differential Revision: http://llvm-reviews.chandlerc.com/D3069
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203799
91177308-0d34-0410-b5e6-
96231b3b80d8
Manuel Jacob [Thu, 13 Mar 2014 13:36:25 +0000 (13:36 +0000)]
CodeGenPrep: sink extends of illegal types into use block.
Summary:
This helps the instruction selector to lower an i64 * i64 -> i128
multiplication into a single instruction on targets which support it.
This is an update of D2973 which was reverted because of a bug reported
as PR19084.
Reviewers: t.p.northover, chapuni
Reviewed By: t.p.northover
CC: llvm-commits, alex, chapuni
Differential Revision: http://llvm-reviews.chandlerc.com/D3021
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203797
91177308-0d34-0410-b5e6-
96231b3b80d8
Evgeniy Stepanov [Thu, 13 Mar 2014 13:17:11 +0000 (13:17 +0000)]
[msan] Fix handling of byval arguments in VarArg calls.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203794
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Thu, 13 Mar 2014 13:08:47 +0000 (13:08 +0000)]
[CMake] Put -Werror to CMAKE_CXX_FLAGS instead of using add_llvm_definitions()
add_definitions shouldn't really be used for compiler flags, and the variable
LLVM_DEFINITIONS is not appropriately used at the moment, e.g. it's not exported
to LLVMConfig.cmake
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203792
91177308-0d34-0410-b5e6-
96231b3b80d8
Rafael Espindola [Thu, 13 Mar 2014 12:14:10 +0000 (12:14 +0000)]
Remove utils/llvm-native-gcc.
llvm-gcc had the ability to produce native .o files long before it died.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203791
91177308-0d34-0410-b5e6-
96231b3b80d8
Elena Demikhovsky [Thu, 13 Mar 2014 12:05:52 +0000 (12:05 +0000)]
AVX-512: masked load/store + intrinsics for them.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203790
91177308-0d34-0410-b5e6-
96231b3b80d8
Stepan Dyatkovskiy [Thu, 13 Mar 2014 11:54:50 +0000 (11:54 +0000)]
First patch of patch series that improves MergeFunctions performance time from O(N*N) to
O(N*log(N)). The idea is to introduce total ordering among functions set.
That allows to build binary tree and perform function look-up procedure in O(log(N)) time.
This patch description:
Introduced total ordering among Type instances. Actually it is improvement for existing
isEquivalentType.
0. Coerce pointer of 0 address space to integer.
1. If left and right types are equal (the same Type* value), return 0 (means equal).
2. If types are of different kind (different type IDs). Return result of type IDs
comparison, treating them as numbers.
3. If types are vectors or integers, return result of its
pointers comparison (casted to numbers).
4. Check whether type ID belongs to the next group:
* Void
* Float
* Double
* X86_FP80
* FP128
* PPC_FP128
* Label
* Metadata
If so, return 0.
5. If left and right are pointers, return result of address space
comparison (numbers comparison).
6. If types are complex.
Then both LEFT and RIGHT will be expanded and their element types will be checked with
the same way. If we get Res != 0 on some stage, return it. Otherwise return 0.
7. For all other cases put llvm_unreachable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203788
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 13 Mar 2014 10:42:18 +0000 (10:42 +0000)]
[PM] As was pointed out in review, I need to define a custom swap in
order to use the single assignment. That's probably worth doing for
a lot of these types anyways as they may have non-trivial moves and so
getting copy elision in more places seems worthwhile.
I've tried to add some tests that actually catch this mistake, and one
of the types is now well tested but the others' tests still fail to
catch this. I'll keep working on tests, but this gets the core pattern
right.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203780
91177308-0d34-0410-b5e6-
96231b3b80d8
Chandler Carruth [Thu, 13 Mar 2014 09:50:31 +0000 (09:50 +0000)]
[PM] Stop playing fast and loose with rebinding of references. However
convenient it is to imagine a world where this works, that is not C++ as
was pointed out in review. The standard even goes to some lengths to
preclude any attempt at this, for better or worse. Maybe better. =]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203775
91177308-0d34-0410-b5e6-
96231b3b80d8
Tim Northover [Thu, 13 Mar 2014 09:00:13 +0000 (09:00 +0000)]
AArch64: error when both positional & named operands are used.
Only one instruction pair needed changing: SMULH & UMULH. The previous
code worked, but MC was doing extra work treating Ra as a valid
operand (which then got completely overwritten in MCCodeEmitter).
No behaviour change, so no tests.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203772
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Thu, 13 Mar 2014 08:19:59 +0000 (08:19 +0000)]
[C++11] DWARF parser: use SmallVector<std::unique_ptr> for parsed units in DWARFContext, and delete custom destructors
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203770
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 13 Mar 2014 07:58:58 +0000 (07:58 +0000)]
[PowerPC] Initial support for the VSX instruction set
VSX is an ISA extension supported on the POWER7 and later cores that enhances
floating-point vector and scalar capabilities. Among other things, this adds
<2 x double> support and generally helps to reduce register pressure.
The interesting part of this ISA feature is the register configuration: there
are 64 new 128-bit vector registers, the 32 of which are super-registers of the
existing 32 scalar floating-point registers, and the second 32 of which overlap
with the 32 Altivec vector registers. This makes things like vector insertion
and extraction tricky: this can be free but only if we force a restriction to
the right register subclass when needed. A new "minipass" PPCVSXCopy takes care
of this (although it could do a more-optimal job of it; see the comment about
unnecessary copies below).
Please note that, currently, VSX is not enabled by default when targeting
anything because it is not yet ready for that. The assembler and disassembler
are fully implemented and tested. However:
- CodeGen support causes miscompiles; test-suite runtime failures:
MultiSource/Benchmarks/FreeBench/distray/distray
MultiSource/Benchmarks/McCat/08-main/main
MultiSource/Benchmarks/Olden/voronoi/voronoi
MultiSource/Benchmarks/mafft/pairlocalalign
MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4
SingleSource/Benchmarks/CoyoteBench/almabench
SingleSource/Benchmarks/Misc/matmul_f64_4x4
- The lowering currently falls back to using Altivec instructions far more
than it should. Worse, there are some things that are scalarized through the
stack that shouldn't be.
- A lot of unnecessary copies make it past the optimizers, and this needs to
be fixed.
- Many more regression tests are needed.
Normally, I'd fix these things prior to committing, but there are some
students and other contributors who would like to work this, and so it makes
sense to move this development process upstream where it can be subject to the
regular code-review procedures.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203768
91177308-0d34-0410-b5e6-
96231b3b80d8
Hal Finkel [Thu, 13 Mar 2014 07:57:54 +0000 (07:57 +0000)]
[TableGen] Optionally forbid overlap between named and positional operands
There are currently two schemes for mapping instruction operands to
instruction-format variables for generating the instruction encoders and
decoders for the assembler and disassembler respectively: a) to map by name and
b) to map by position.
In the long run, we'd like to remove the position-based scheme and use only
name-based mapping. Unfortunately, the name-based scheme currently cannot deal
with complex operands (those with suboperands), and so we currently must use
the position-based scheme for those. On the other hand, the position-based
scheme cannot deal with (register) variables that are split into multiple
ranges. An upcoming commit to the PowerPC backend (adding VSX support) will
require this capability. While we could teach the position-based scheme to
handle that, since we'd like to move away from the position-based mapping
generally, it seems silly to teach it new tricks now. What makes more sense is
to allow for partial transitioning: use the name-based mapping when possible,
and only use the position-based scheme when necessary.
Now the problem is that mixing the two sensibly was not possible: the
position-based mapping would map based on position, but would not skip those
variables that were mapped by name. Instead, the two sets of assignments would
overlap. However, I cannot currently change the current behavior, because there
are some backends that rely on it [I think mistakenly, but I'll send a message
to llvmdev about that]. So I've added a new TableGen bit variable:
noNamedPositionallyEncodedOperands, that can be used to cause the
position-based mapping to skip variables mapped by name.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203767
91177308-0d34-0410-b5e6-
96231b3b80d8
Alexey Samsonov [Thu, 13 Mar 2014 07:52:54 +0000 (07:52 +0000)]
[C++11] Convert DWARF parser to range-based for loops
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203766
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Thu, 13 Mar 2014 07:15:45 +0000 (07:15 +0000)]
ARM: ignore unused variable to fix -Wunused-variable builds
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203765
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Thu, 13 Mar 2014 07:02:46 +0000 (07:02 +0000)]
MC: fix silly typo
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203763
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Thu, 13 Mar 2014 07:02:41 +0000 (07:02 +0000)]
ARM: support emission of complex SO expressions
Support to the IAS was added to actually parse and handle the complex SO
expressions. However, the object file lowering was not updated to compensate
for the fact that the shift operand may be an absolute expression.
When trying to assemble to an object file, the lowering would fail while
succeeding when emitting purely assembly. Add an appropriate test.
The test case is inspired by the test case provided by Jiangning Liu who also
brought the issue to light.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203762
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Thu, 13 Mar 2014 07:02:35 +0000 (07:02 +0000)]
Support: add support to identify WinCOFF/ARM objects
Add the Windows COFF ARM object file magic. This enables the LLVM tools to
interact with COFF object files for Windows on ARM.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203761
91177308-0d34-0410-b5e6-
96231b3b80d8
Ted Kremenek [Thu, 13 Mar 2014 06:37:28 +0000 (06:37 +0000)]
[CMake] Enable a bunch of Xcode build settings that correspond to warnings that are for the most part enabled by default either by Clang or -Wall.
I personally build with these settings enabled all the time, and it
is clearer to see the actual warning flags (e.g., -Wuninitialized)
get passed by Xcode rather than seeing -Wno-uninitialized followed
by -Wall (the latter canceling out the former) and figuring out
what is going on.
Xcode will ignore build settings it doesn't understand, so this will
work on possibly older versions of Xcode that don't support all
of these settings.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203760
91177308-0d34-0410-b5e6-
96231b3b80d8
Owen Anderson [Thu, 13 Mar 2014 06:02:25 +0000 (06:02 +0000)]
Phase 1 of refactoring the MachineRegisterInfo iterators to make them suitable
for use with C++11 range-based for-loops.
The gist of phase 1 is to remove the skipInstruction() and skipBundle()
methods from these iterators, instead splitting each iterator into a version
that walks operands, a version that walks instructions, and a version that
walks bundles. This has the result of making some "clever" loops in lib/CodeGen
more verbose, but also makes their iterator invalidation characteristics much
more obvious to the casual reader. (Making them concise again in the future is a
good motivating case for a pre-incrementing range adapter!)
Phase 2 of this undertaking with consist of removing the getOperand() method,
and changing operator*() of the operand-walker to return a MachineOperand&. At
that point, it should be possible to add range views for them that work as one
might expect.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203757
91177308-0d34-0410-b5e6-
96231b3b80d8
Karthik Bhat [Thu, 13 Mar 2014 04:50:29 +0000 (04:50 +0000)]
Fix PR18800. llvm intrinsic memcpy takes 5 arguments void @llvm.memcpy.p0i8.p0i8.i32(i8* <dest>, i8* <src>, i32 <len>, i32 <align>, i1 <isvolatile>).The test case incorrectly uses the old format resulting in isVolatile function in MemIntrinsic to crash during SROA transformation.Modified the test case to use correct signature of memcpy and memset.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203750
91177308-0d34-0410-b5e6-
96231b3b80d8
Andrew Trick [Thu, 13 Mar 2014 03:49:20 +0000 (03:49 +0000)]
Fix a false error reported by the tblgen backend for machine model
"ProcResource def is not included in the ProcResources".
Some of the machine model definitions were not added to the
processor's list used for diagnostics and error checking.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203749
91177308-0d34-0410-b5e6-
96231b3b80d8
Saleem Abdulrasool [Thu, 13 Mar 2014 02:09:51 +0000 (02:09 +0000)]
MC: fix possible NULL pointer dereference
Avoid NULL pointer scenario found via clang's static analyzer.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203745
91177308-0d34-0410-b5e6-
96231b3b80d8
NAKAMURA Takumi [Thu, 13 Mar 2014 00:10:37 +0000 (00:10 +0000)]
llvm/test/BugPoint/compile-custom.ll.py: Make it py3-compatible. [PR19112]
FIXME: Get rid of invoking this.
I guess it wouldn't run on win32 due to lacking of shell support.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203740
91177308-0d34-0410-b5e6-
96231b3b80d8