OSDN Git Service

pg-rex/syncrep.git
18 years agoSupport include directives in postgresql.conf.
Tom Lane [Sat, 4 Mar 2006 22:19:31 +0000 (22:19 +0000)]
Support include directives in postgresql.conf.
Patch by Joachim Wieland, somewhat reworked for clarity and portability.

18 years agoDeclare the arguments of AllocateFile() as const char *, not char *.
Tom Lane [Sat, 4 Mar 2006 21:32:47 +0000 (21:32 +0000)]
Declare the arguments of AllocateFile() as const char *, not char *.
This is consistent with the standard definition of fopen().

18 years agoIncorporate a couple of recent tuplesort.c improvements into tuplestore.c.
Tom Lane [Sat, 4 Mar 2006 19:30:12 +0000 (19:30 +0000)]
Incorporate a couple of recent tuplesort.c improvements into tuplestore.c.
In particular, ensure that enlargement of the memtuples[] array doesn't
fall foul of MaxAllocSize when work_mem is very large, and don't bother
enlarging it if that would force an immediate switch into 'tape' mode anyway.

18 years agoPrevent lazy_space_alloc from making requests that exceed MaxAllocSize,
Tom Lane [Sat, 4 Mar 2006 19:09:09 +0000 (19:09 +0000)]
Prevent lazy_space_alloc from making requests that exceed MaxAllocSize,
per report from Stefan Kaltenbrunner.

18 years agoPrevent sorting from requesting a SortTuple array that exceeds MaxAllocSize;
Tom Lane [Sat, 4 Mar 2006 19:05:06 +0000 (19:05 +0000)]
Prevent sorting from requesting a SortTuple array that exceeds MaxAllocSize;
we'll go over to disk-based sort if we reach that limit.
This fixes Stefan Kaltenbrunner's observation that sorting can suffer an
'invalid memory alloc request size' failure when sort_mem is set large
enough.  It's unfortunately not so easy to fix in 8.1 ...

18 years agoTighten up SJIS byte sequence check. Now we reject invalid SJIS byte
Tatsuo Ishii [Sat, 4 Mar 2006 10:57:35 +0000 (10:57 +0000)]
Tighten up SJIS byte sequence check. Now we reject invalid SJIS byte
sequence such as "0x95 0x27". Patches from Akio Ishida.
Also update copyright notice.

18 years agoAdd:
Bruce Momjian [Sat, 4 Mar 2006 05:02:03 +0000 (05:02 +0000)]
Add:

> * Allow FSM page return free space based on table clustering, to assist
>   in maintaining clustering?

18 years ago> gettimeofday.c:35: warning: integer constant is too large for "long"
Bruce Momjian [Sat, 4 Mar 2006 04:44:07 +0000 (04:44 +0000)]
> gettimeofday.c:35: warning: integer constant is too large for "long"
> type

Wouldn't it be better to use the UINT64CONST macro?  I realize this
file is Windows-only, but we do worry about more than one compiler
on that platform.

Kris Jurka

18 years ago> It doesn't say that only the listed commands acquire ACCESS EXCLUSIVE,
Bruce Momjian [Sat, 4 Mar 2006 04:41:36 +0000 (04:41 +0000)]
> It doesn't say that only the listed commands acquire ACCESS EXCLUSIVE,
> just that certain commands do.  TRUNCATE isn't shown.

Patch against HEAD to add TRUNCATE to the list of commands that aquire
ACCESS EXCLUSIVE.

Jim C. Nasby, Sr.

18 years agoUse DEVTTY as 'con' on Win32 as a replacement for /dev/tty.
Bruce Momjian [Sat, 4 Mar 2006 04:30:41 +0000 (04:30 +0000)]
Use DEVTTY as 'con' on Win32 as a replacement for /dev/tty.

18 years agoThat was a typo in my comment before the code (the nutshell
Bruce Momjian [Sat, 4 Mar 2006 03:47:29 +0000 (03:47 +0000)]
That was a typo in my comment before the code (the nutshell
descriptions after the code are correct). Only shmmax needs to be
multiples of the page size (at least, that's how I interpret the
Darwin code).

Chris Campbell

18 years agoThis patch fixes this warning.
Bruce Momjian [Fri, 3 Mar 2006 23:59:14 +0000 (23:59 +0000)]
This patch fixes this warning.

gettimeofday.c:35: warning: integer constant is too large for "long"
type

Kris Jurka

18 years agoAvoid trying to open /dev/tty on Win32. Some Win32 systems have
Bruce Momjian [Fri, 3 Mar 2006 23:49:12 +0000 (23:49 +0000)]
Avoid trying to open /dev/tty on Win32.  Some Win32 systems have
/dev/tty, but it isn't a device file and doesn't work as expected.

This fixes a known bug where psql does not prompt for a password on some
Win32 systems.

Backpatch to 8.1.X.

Robert Kinberg

18 years agoImprove pg_dump and psql to use libpq's newer COPY support routines,
Tom Lane [Fri, 3 Mar 2006 23:38:30 +0000 (23:38 +0000)]
Improve pg_dump and psql to use libpq's newer COPY support routines,
instead of the old deprecated ones.
Volkan Yazici, with some editorializing by moi.

18 years agoFixes for Win32-client only compiles.
Bruce Momjian [Fri, 3 Mar 2006 23:11:48 +0000 (23:11 +0000)]
Fixes for Win32-client only compiles.

Hiroshi Saito

18 years agoRename Online Backup to Continuous Archiving.
Bruce Momjian [Fri, 3 Mar 2006 22:02:08 +0000 (22:02 +0000)]
Rename Online Backup to Continuous Archiving.

18 years agoUpdate ipcclean to use try 'id' first for root check.
Bruce Momjian [Fri, 3 Mar 2006 21:52:37 +0000 (21:52 +0000)]
Update ipcclean to use try 'id' first for root check.

18 years agoAdd workaround so MSVC doesn't try to load strings.h, which it doesn't
Bruce Momjian [Fri, 3 Mar 2006 21:35:46 +0000 (21:35 +0000)]
Add workaround so MSVC doesn't try to load strings.h, which it doesn't
have.  This happens when MSVC uses pg_config.h generated by MinGW.

Per report from Charles F. I. Savage

18 years agoTeach PQcmdTuples() that a COPY command tag might contain a row count,
Tom Lane [Fri, 3 Mar 2006 20:57:32 +0000 (20:57 +0000)]
Teach PQcmdTuples() that a COPY command tag might contain a row count,
and tighten up its sanity checking of the tag as a safety measure.
Volkan Yazici.

18 years agoClarify macro layout for win32 IMPORT.
Bruce Momjian [Fri, 3 Mar 2006 20:52:36 +0000 (20:52 +0000)]
Clarify macro layout for win32 IMPORT.

18 years agoDone:
Bruce Momjian [Fri, 3 Mar 2006 20:43:00 +0000 (20:43 +0000)]
Done:

> * -Allow TRUNCATE ... CASCADE/RESTRICT

18 years agoDone:
Bruce Momjian [Fri, 3 Mar 2006 20:37:29 +0000 (20:37 +0000)]
Done:

<  o %Have COPY return the number of rows loaded/unloaded?
>  o -Have COPY return the number of rows loaded/unloaded?

18 years agoMake the COPY command return a command tag that includes the number of
Tom Lane [Fri, 3 Mar 2006 19:54:10 +0000 (19:54 +0000)]
Make the COPY command return a command tag that includes the number of
rows copied.  Backend side of Volkan Yazici's recent patch, with
corrections and documentation.

18 years agoDept. of second thoughts: rejigger the TRUNCATE ... CASCADE patch so that
Tom Lane [Fri, 3 Mar 2006 18:25:14 +0000 (18:25 +0000)]
Dept. of second thoughts: rejigger the TRUNCATE ... CASCADE patch so that
relations are still checked for permissions etc as soon as they are
opened.  The original form of the patch could hold exclusive lock for a
long time on relations that the user doesn't even have permissions to
access, let alone truncate.

18 years agoIn ipcclean, check LOGNAME only if USER is not set.
Bruce Momjian [Fri, 3 Mar 2006 16:49:21 +0000 (16:49 +0000)]
In ipcclean, check LOGNAME only if USER is not set.

Fixes problem with 'su' on some platforms.

18 years agoFix a typo.
Neil Conway [Fri, 3 Mar 2006 04:31:07 +0000 (04:31 +0000)]
Fix a typo.

18 years agoAdd CASCADE option to TRUNCATE. Joachim Wieland
Tom Lane [Fri, 3 Mar 2006 03:30:54 +0000 (03:30 +0000)]
Add CASCADE option to TRUNCATE.  Joachim Wieland

18 years agoAdd:
Bruce Momjian [Fri, 3 Mar 2006 03:13:04 +0000 (03:13 +0000)]
Add:

> * Allow FSM to return free space toward the beginning of the heap file,
>   in hopes that empty pages at the end can be truncated by VACUUM

18 years agoAppended is a small documentation patch that adds a note to the CREATE
Bruce Momjian [Fri, 3 Mar 2006 03:06:05 +0000 (03:06 +0000)]
Appended is a small documentation patch that adds a note to the CREATE
ROLE page, based on what Tom Lane told me here:

http://archives.postgresql.org/pgsql-general/2005-11/msg00998.php

Joachim Wieland

18 years agoAdd:
Bruce Momjian [Fri, 3 Mar 2006 02:38:57 +0000 (02:38 +0000)]
Add:

> * Add missing parameter handling in to_char()
>
>  http://archives.postgresql.org/pgsql-hackers/2005-12/msg00948.php
>

18 years agoAdd:
Bruce Momjian [Fri, 3 Mar 2006 02:18:09 +0000 (02:18 +0000)]
Add:

> * Allow to_date() and to_timestamp() accept localized month names

18 years agoAdd comment about localized month names for to_date and to_timestamp.
Bruce Momjian [Fri, 3 Mar 2006 02:17:30 +0000 (02:17 +0000)]
Add comment about localized month names for to_date and to_timestamp.

18 years agoArrange to call AbsorbFsyncRequests every so often while performing a
Tom Lane [Fri, 3 Mar 2006 00:02:02 +0000 (00:02 +0000)]
Arrange to call AbsorbFsyncRequests every so often while performing a
checkpoint in the bgwriter.  This forestalls overflow of the fsync request
queue, which is not fatal but causes considerable performance degradation
when it occurs (because backends then have to do their own fsyncs).  Per
patch from Itagaki Takahiro, modified a little bit by me.

18 years agoRemove unnecessary lo_lseek call in lo_open. Apparently there was once
Tom Lane [Thu, 2 Mar 2006 21:56:14 +0000 (21:56 +0000)]
Remove unnecessary lo_lseek call in lo_open.  Apparently there was once
a need for it back in the neolithic era, but it's certainly dead code in
any PG release we would recognize as such.  Since it forces an additional
network round trip to the backend, getting rid of it should provide some
small performance improvement for large-object-using clients.

18 years agoFix ancient error in large objects usage example: overwrite() subroutine
Tom Lane [Thu, 2 Mar 2006 21:49:09 +0000 (21:49 +0000)]
Fix ancient error in large objects usage example: overwrite() subroutine
was opening with INV_READ flag and then writing.  Prior to 8.1 the backend
did not reject this, but now it does.

18 years agoRepair oidvectorrecv and int2vectorrecv, which I broke while changing
Tom Lane [Thu, 2 Mar 2006 21:13:04 +0000 (21:13 +0000)]
Repair oidvectorrecv and int2vectorrecv, which I broke while changing
them to use array_recv :-(.  Per report from Tim Kordas.

18 years agoUpdate OS X shared memory documentation for 10.3.9 and later to use
Bruce Momjian [Thu, 2 Mar 2006 20:30:21 +0000 (20:30 +0000)]
Update OS X shared memory documentation for 10.3.9 and later to use
/etc/sysctl.conf.

Chris Campbell

18 years agoMark tsearch2 item as Tom's, not Teodor's.
Bruce Momjian [Thu, 2 Mar 2006 19:34:43 +0000 (19:34 +0000)]
Mark tsearch2 item as Tom's, not Teodor's.

18 years agoUpdate TODO.detail/qsort.
Bruce Momjian [Thu, 2 Mar 2006 19:21:05 +0000 (19:21 +0000)]
Update TODO.detail/qsort.

18 years agoUpdate TODO.detail/qsort.
Bruce Momjian [Thu, 2 Mar 2006 19:20:44 +0000 (19:20 +0000)]
Update TODO.detail/qsort.

18 years agoSignificantly improve ranking:
Teodor Sigaev [Thu, 2 Mar 2006 19:07:19 +0000 (19:07 +0000)]
Significantly improve ranking:
1) rank_cd now use weight of lexemes
2) rank_cd and rank can use any combination of normalization methods:
        no normalization
        normalization by log(length of document)
        -----/------- by length of document
        -----/------- by number of unique word in document
        -----/------- by log(number of unique word in document)
        -----/------- by number of covers (only rank_cd)

Improve cover's search.

TODO: changes in documentation

18 years agoUpdate TODO.detail/qsort.
Bruce Momjian [Thu, 2 Mar 2006 18:20:25 +0000 (18:20 +0000)]
Update TODO.detail/qsort.

18 years agoAdd to TODO.detail for qsort.
Bruce Momjian [Thu, 2 Mar 2006 18:18:13 +0000 (18:18 +0000)]
Add to TODO.detail for qsort.

18 years agoAdd:
Bruce Momjian [Thu, 2 Mar 2006 18:18:00 +0000 (18:18 +0000)]
Add:

> * Improve port/qsort() to handle sorts with 50% unique and 50% duplicate
>   value [qsort]
>
>   This involves choosing better pivot points for the quicksort.

18 years agoFix possible crash at transaction end when a plpgsql function is used and
Tom Lane [Thu, 2 Mar 2006 05:34:12 +0000 (05:34 +0000)]
Fix possible crash at transaction end when a plpgsql function is used and
then modified within the same transaction.  The code was using a linked list
of active PLpgSQL_expr structs, which was OK when it was written because
plpgsql never released any parse data structures for the life of the backend.
But since Neil fixed plpgsql's memory management, elements of the linked list
could be freed, leading to crash when the list is chased.  Per report and test
case from Kris Jurka.

18 years agoFix up pg_dump to emit shell-type definitions at the proper time, to
Tom Lane [Thu, 2 Mar 2006 01:18:26 +0000 (01:18 +0000)]
Fix up pg_dump to emit shell-type definitions at the proper time, to
make use of the recently added ability to create a shell type explicitly.

I also put in place some infrastructure to allow dump/no dump decisions
to be made separately for each database object, rather than the former
hardwired 'dump if in a dumpable schema' policy.  This was needed anyway
for shell types so now seemed a convenient time to do it.  The flexibility
isn't exposed to the user yet, but is ready for future extensions.

18 years agoWoops: also update the alternative "expected" files for contrib/cube's
Neil Conway [Wed, 1 Mar 2006 23:00:56 +0000 (23:00 +0000)]
Woops: also update the alternative "expected" files for contrib/cube's
regression tests to account for the new error message wording. It seems
today is not my day...

18 years agoUpdate text file.
Bruce Momjian [Wed, 1 Mar 2006 22:24:51 +0000 (22:24 +0000)]
Update text file.

18 years agoUpdate patch generation instructions.
Bruce Momjian [Wed, 1 Mar 2006 22:23:14 +0000 (22:23 +0000)]
Update patch generation instructions.

Robert Treat

18 years agoUpdate the expected regression test results to account for the changes to
Neil Conway [Wed, 1 Mar 2006 21:09:32 +0000 (21:09 +0000)]
Update the expected regression test results to account for the changes to
error messages I made yesterday -- thanks to Andrew Dunstan for reporting
this, and my apologies for missing it the first time.

18 years agoUpdate Japanese FAQ, backpatched to 8.1.X.
Bruce Momjian [Wed, 1 Mar 2006 20:31:29 +0000 (20:31 +0000)]
Update Japanese FAQ, backpatched to 8.1.X.

18 years agoAttached is a patch that replaces a bunch of places where StringInfos
Neil Conway [Wed, 1 Mar 2006 06:51:01 +0000 (06:51 +0000)]
Attached is a patch that replaces a bunch of places where StringInfos
are unnecessarily allocated on the heap rather than the stack. If the
StringInfo doesn't outlive the stack frame in which it is created,
there is no need to allocate it on the heap via makeStringInfo() --
stack allocation is faster.  While it's not a big deal unless the
code is in a critical path, I don't see a reason not to save a few
cycles -- using stack allocation is not less readable.

I also cleaned up a bit of code along the way: moved variable
declarations into a more tightly-enclosing scope where possible,
fixed some pointless copying of strings in dblink, etc.

18 years agoThis patch makes the error message strings throughout the backend
Neil Conway [Wed, 1 Mar 2006 06:30:32 +0000 (06:30 +0000)]
This patch makes the error message strings throughout the backend
more compliant with the error message style guide. In particular,
errdetail should begin with a capital letter and end with a period,
whereas errmsg should not. I also fixed a few related issues in
passing, such as fixing the repeated misspelling of "lexeme" in
contrib/tsearch2 (per Tom's suggestion).

18 years agoAdd pg_service.conf documentation for libpq.
Bruce Momjian [Wed, 1 Mar 2006 00:23:21 +0000 (00:23 +0000)]
Add pg_service.conf documentation for libpq.

18 years agoFix typo in comment.
Neil Conway [Tue, 28 Feb 2006 23:38:13 +0000 (23:38 +0000)]
Fix typo in comment.

18 years agoAllow the syntax CREATE TYPE foo, with no parameters, to permit explicit
Tom Lane [Tue, 28 Feb 2006 22:37:27 +0000 (22:37 +0000)]
Allow the syntax CREATE TYPE foo, with no parameters, to permit explicit
creation of a shell type.  This allows a less hacky way of dealing with
the mutual dependency between a datatype and its I/O functions: make a
shell type, then make the functions, then define the datatype fully.
We should fix pg_dump to handle things this way, but this commit just deals
with the backend.

Martijn van Oosterhout, with some corrections by Tom Lane.

18 years agoBack out libpq changes for service --- not ready yet.
Bruce Momjian [Tue, 28 Feb 2006 22:35:35 +0000 (22:35 +0000)]
Back out libpq changes for service --- not ready yet.

18 years agoFix PG_VERSION_NUM for different awk -F handling.
Bruce Momjian [Tue, 28 Feb 2006 22:34:24 +0000 (22:34 +0000)]
Fix PG_VERSION_NUM for different awk -F handling.

18 years agoFix PG_VERSION_NUM awk -F parameter.
Bruce Momjian [Tue, 28 Feb 2006 21:59:19 +0000 (21:59 +0000)]
Fix PG_VERSION_NUM awk -F parameter.

18 years agoTweak the error message emitted when a void-returning PL/Python function
Neil Conway [Tue, 28 Feb 2006 20:56:14 +0000 (20:56 +0000)]
Tweak the error message emitted when a void-returning PL/Python function
does not return None, per suggestion from Tom.

18 years agoAllow PL/Python functions to return void, per gripe from James Robinson
Neil Conway [Tue, 28 Feb 2006 20:03:52 +0000 (20:03 +0000)]
Allow PL/Python functions to return void, per gripe from James Robinson
(I didn't use his patch, however). A void-returning PL/Python function
must return None (from Python), which is translated into a void datum
(and *not* NULL) for Postgres. I also added some regression tests for
this functionality.

18 years agoAdd:
Bruce Momjian [Tue, 28 Feb 2006 19:48:03 +0000 (19:48 +0000)]
Add:

* Split out libpq pgpass and environment documentation sections to make
  it easier for non-developers to find

18 years agoAdd PG_VERSION_NUM for use by 3rd party applications wanting to test the
Bruce Momjian [Tue, 28 Feb 2006 16:41:21 +0000 (16:41 +0000)]
Add PG_VERSION_NUM for use by 3rd party applications wanting to test the
backend version in C using > and < comparisons.

18 years agoTeach nodeSort and nodeMaterial to optimize out unnecessary overhead
Tom Lane [Tue, 28 Feb 2006 05:48:44 +0000 (05:48 +0000)]
Teach nodeSort and nodeMaterial to optimize out unnecessary overhead
when the passed-down eflags indicate they can.
Simon Riggs and Tom Lane

18 years agoExtend the ExecInitNode API so that plan nodes receive a set of flag
Tom Lane [Tue, 28 Feb 2006 04:10:28 +0000 (04:10 +0000)]
Extend the ExecInitNode API so that plan nodes receive a set of flag
bits indicating which optional capabilities can actually be exercised
at runtime.  This will allow Sort and Material nodes, and perhaps later
other nodes, to avoid unnecessary overhead in common cases.
This commit just adds the infrastructure and arranges to pass the correct
flag values down to plan nodes; none of the actual optimizations are here
yet.  I'm committing this separately in case anyone wants to measure the
added overhead.  (It should be negligible.)

Simon Riggs and Tom Lane

18 years agoClean up CREATE FUNCTION syntax usage in contrib and elsewhere, in
Peter Eisentraut [Mon, 27 Feb 2006 16:09:50 +0000 (16:09 +0000)]
Clean up CREATE FUNCTION syntax usage in contrib and elsewhere, in
particular get rid of single quotes around language names and old WITH ()
construct.

18 years agocontrib uninstall scripts
Peter Eisentraut [Mon, 27 Feb 2006 12:54:39 +0000 (12:54 +0000)]
contrib uninstall scripts

by David Fetter

18 years agoAdd mention that tid perhaps someday should be output as a record.
Bruce Momjian [Mon, 27 Feb 2006 01:41:16 +0000 (01:41 +0000)]
Add mention that tid perhaps someday should be output as a record.

18 years agoImprove sorting speed by pre-extracting the first sort-key column of
Tom Lane [Sun, 26 Feb 2006 22:58:12 +0000 (22:58 +0000)]
Improve sorting speed by pre-extracting the first sort-key column of
each tuple, as per my proposal of several days ago.  Also, clean up
sort memory management by keeping all working data in a separate memory
context, and refine the handling of low-memory conditions.

18 years agoFix a few minor typos in comments in PL/Perl.
Neil Conway [Sun, 26 Feb 2006 22:26:39 +0000 (22:26 +0000)]
Fix a few minor typos in comments in PL/Perl.

18 years agoDone:
Bruce Momjian [Sun, 26 Feb 2006 21:22:47 +0000 (21:22 +0000)]
Done:

> * -Add 'tid != tid ' operator for use in corruption recovery

18 years agoImplement the <> operator for the tid type. Original patch from Mark
Neil Conway [Sun, 26 Feb 2006 18:36:23 +0000 (18:36 +0000)]
Implement the <> operator for the tid type. Original patch from Mark
Kirkwood, minor improvements by Neil Conway. The regression tests have
been updated and the catversion has been bumped.

18 years agoMinor SGML work: add some more hyperlinks, where appropriate.
Neil Conway [Sun, 26 Feb 2006 03:20:46 +0000 (03:20 +0000)]
Minor SGML work: add some more hyperlinks, where appropriate.

18 years agoFix typo in comment.
Neil Conway [Sun, 26 Feb 2006 02:23:41 +0000 (02:23 +0000)]
Fix typo in comment.

18 years agoTODO updates:
Neil Conway [Sun, 26 Feb 2006 01:21:57 +0000 (01:21 +0000)]
TODO updates:

- "Add ON COMMIT capability to CREATE TABLE AS ... SELECT" is done

- "Allow PREPARE to automatically determine parameter types" is done

- "Clean up compiler warnings (especially with gcc version 4)" is done:
  AFAIK there are no remaining gcc4 compiler warnings to be fixed.

- Creating rules to do view updates is *not* an easy TODO item

18 years agoRemove ora2pg; now available at <http://www.samse.fr/GPL/ora2pg/>.
Peter Eisentraut [Sat, 25 Feb 2006 19:18:58 +0000 (19:18 +0000)]
Remove ora2pg; now available at <samse.fr/GPL/ora2pg/>.

18 years agoAdd intervals:
Bruce Momjian [Sat, 25 Feb 2006 16:34:52 +0000 (16:34 +0000)]
Add intervals:

>  o Allow infinite dates and intervals just like infinite timestamps

18 years agoFix computation of sample table size.
Bruce Momjian [Sat, 25 Feb 2006 04:28:54 +0000 (04:28 +0000)]
Fix computation of sample table size.

18 years agoRemove duplicate:
Bruce Momjian [Sat, 25 Feb 2006 03:40:14 +0000 (03:40 +0000)]
Remove duplicate:

<  o %Disallow dropping of an inherited constraint

18 years agoRemove mention of MIN/MAX() not using indexes.
Bruce Momjian [Fri, 24 Feb 2006 14:59:54 +0000 (14:59 +0000)]
Remove mention of MIN/MAX() not using indexes.

18 years agoMention that the archive history file has the wal start/stop file names.
Bruce Momjian [Fri, 24 Feb 2006 14:03:01 +0000 (14:03 +0000)]
Mention that the archive history file has the wal start/stop file names.

18 years agoThe Makefile was invoking perl scripts as ./script.pl. This fails when
Peter Eisentraut [Fri, 24 Feb 2006 13:25:44 +0000 (13:25 +0000)]
The Makefile was invoking perl scripts as ./script.pl.  This fails when
the script is not executable as UCS_to_most.pl is in CVS.  It also won't
pick up any custom setting of the perl version/location to use.  This
patch calls perl scripts like $(PERL) $(srcdir)/script.pl.

Kris Jurka

18 years agoMake restricted_exec feature for Windows more robust by using the environment
Andrew Dunstan [Fri, 24 Feb 2006 02:02:41 +0000 (02:02 +0000)]
Make restricted_exec feature for Windows more robust by using the environment
to pass the flag instead of the command line - some implementations of
getopt fail if getopt arguments are present after non-getopt arguments.

18 years agomake initdb -U username work as advertised; back out bogus patch at rev 1.42
Andrew Dunstan [Fri, 24 Feb 2006 00:55:49 +0000 (00:55 +0000)]
make initdb -U username work as advertised; back out bogus patch at rev 1.42
and supply real fix for problem it tried to address.

18 years agoFix vacuumlo to avoid unnecessary use of backslash in search pattern.
Tom Lane [Thu, 23 Feb 2006 22:33:59 +0000 (22:33 +0000)]
Fix vacuumlo to avoid unnecessary use of backslash in search pattern.
Per Michael Fuhr.

18 years agoCleanup the usage of ScanDirection: use the symbolic names for the
Neil Conway [Tue, 21 Feb 2006 23:01:54 +0000 (23:01 +0000)]
Cleanup the usage of ScanDirection: use the symbolic names for the
possible ScanDirection alternatives rather than magic numbers
(-1, 0, 1).  Also, use the ScanDirection macros in a few places
rather than directly checking whether `dir == ForwardScanDirection'
and the like. Per patch from James William Pye. His patch also
changed ScanDirection to be a "char" rather than an enum, which
I haven't applied.

18 years agoFix old pg_dump oversight: default values for domains really need to be dumped
Tom Lane [Tue, 21 Feb 2006 18:01:32 +0000 (18:01 +0000)]
Fix old pg_dump oversight: default values for domains really need to be dumped
by decompiling the typdefaultbin expression, not just printing the typdefault
text which may be out-of-date or assume the wrong schema search path.  (It's
the same hazard as for adbin vs adsrc in column defaults.)  The catalogs.sgml
spec for pg_type implies that the correct procedure is to look to
typdefaultbin first and consider typdefault only if typdefaultbin is NULL.
I made dumping of both domains and base types do that, even though in the
current backend code typdefaultbin is always correct for domains and
typdefault for base types --- might as well try to future-proof it a little.
Per bug report from Alexander Galler.

18 years agoAdjust probe for getaddrinfo to cope with macro-ized definitions, such
Tom Lane [Tue, 21 Feb 2006 06:06:50 +0000 (06:06 +0000)]
Adjust probe for getaddrinfo to cope with macro-ized definitions, such
as Tru64's.  Per previous discussion.

18 years agoFix three Python reference leaks in PLy_traceback(). This would result
Neil Conway [Mon, 20 Feb 2006 20:10:37 +0000 (20:10 +0000)]
Fix three Python reference leaks in PLy_traceback(). This would result
in leaking memory when invoking a PL/Python procedure that raises an
exception. Unfortunately this still leaks memory, but at least the
largest leak has been plugged.

This patch also fixes a reference counting mistake in PLy_modify_tuple()
for 8.0, 8.1 and HEAD: we don't actually own a reference to `platt', so
we shouldn't Py_DECREF() it.

18 years agoFixing and improve compound word support. This changes cannot be applied to
Teodor Sigaev [Mon, 20 Feb 2006 17:51:05 +0000 (17:51 +0000)]
Fixing and improve compound word support. This changes cannot be applied to
previous version iwthout recreating tsvector fields...

Thanks to Alexander Presber <aljoscha@weisshuhn.de> to discover a problem.

18 years agoUpdate obsolete comment.
Tom Lane [Sun, 19 Feb 2006 19:59:53 +0000 (19:59 +0000)]
Update obsolete comment.

18 years agoModify logtape.c so that the initial LogicalTapeSetCreate call only
Tom Lane [Sun, 19 Feb 2006 05:58:36 +0000 (05:58 +0000)]
Modify logtape.c so that the initial LogicalTapeSetCreate call only
allocates the control data.  The per-tape buffers are allocated only
on first use.  This saves memory in situations where tuplesort.c
overestimates the number of tapes needed (ie, there are fewer runs
than tapes).  Also, this makes legitimate the coding in inittapes()
that includes tape buffer space in the maximum-memory calculation:
when inittapes runs, we've already expended the whole allowed memory
on tuple storage, and so we'd better not allocate all the tape buffers
until we've flushed some tuples out of memory.

18 years agoImprove tuplesort.c to support variable merge order. The original coding
Tom Lane [Sun, 19 Feb 2006 05:54:06 +0000 (05:54 +0000)]
Improve tuplesort.c to support variable merge order.  The original coding
with fixed merge order (fixed number of "tapes") was based on obsolete
assumptions, namely that tape drives are expensive.  Since our "tapes"
are really just a couple of buffers, we can have a lot of them given
adequate workspace.  This allows reduction of the number of merge passes
with consequent savings of I/O during large sorts.

Simon Riggs with some rework by Tom Lane

18 years agoAdd TABLESPACE and ON COMMIT clauses to CREATE TABLE AS. ON COMMIT is
Neil Conway [Sun, 19 Feb 2006 00:04:28 +0000 (00:04 +0000)]
Add TABLESPACE and ON COMMIT clauses to CREATE TABLE AS. ON COMMIT is
required by the SQL standard, and TABLESPACE is useful functionality.
Patch from Kris Jurka, minor editorialization by Neil Conway.

18 years agoMinor SGML style police work.
Neil Conway [Sat, 18 Feb 2006 23:14:45 +0000 (23:14 +0000)]
Minor SGML style police work.

18 years ago&apos; is not valid HTML 4.01, so print the plain character instead.
Peter Eisentraut [Sat, 18 Feb 2006 22:54:50 +0000 (22:54 +0000)]
&apos; is not valid HTML 4.01, so print the plain character instead.

18 years agoPatch from Marko Kreen:
Neil Conway [Sat, 18 Feb 2006 20:48:51 +0000 (20:48 +0000)]
Patch from Marko Kreen:

pgcrypto crypt()/md5 and hmac() leak memory when compiled against
OpenSSL as openssl.c digest ->reset will do two DigestInit calls
against a context.  This happened to work with OpenSSL 0.9.6
but not with 0.9.7+.

Reason for the messy code was that I tried to avoid creating
wrapper structure to transport algorithm info and tried to use
OpenSSL context for it.  The fix is to create wrapper structure.

It also uses newer digest API to avoid memory allocations
on reset with newer OpenSSLs.

Thanks to Daniel Blaisdell for reporting it.

18 years agoAdd support for Windows codepages 1253, 1254, 1255, and 1257 and clean
Peter Eisentraut [Sat, 18 Feb 2006 16:15:23 +0000 (16:15 +0000)]
Add support for Windows codepages 1253, 1254, 1255, and 1257 and clean
up a bunch of the support utilities.

In src/backend/utils/mb/Unicode remove nearly duplicate copies of the
UCS_to_XXX perl script and replace with one version to handle all generic
files.  Update the Makefile so that it knows about all the map files.
This produces a slight difference in some of the map files, using a
uniform naming convention and not mapping the null character.

In src/backend/utils/mb/conversion_procs create a master utf8<->win
codepage function like the ISO 8859 versions instead of having a separate
handler for each conversion.

There is an externally visible change in the name of the win1258 to utf8
conversion.  According to the documentation notes, it was named
incorrectly and this changes it to a standard name.

Running the Unicode mapping perl scripts has shown some additional mapping
changes in koi8r and iso8859-7.

18 years agoMark unescape_single_char() "static": as far as I can see this function
Neil Conway [Sat, 18 Feb 2006 01:44:35 +0000 (01:44 +0000)]
Mark unescape_single_char() "static": as far as I can see this function
is only used by scan.l/scan.c

18 years agoFix typo in comment.
Neil Conway [Fri, 17 Feb 2006 03:29:02 +0000 (03:29 +0000)]
Fix typo in comment.