OSDN Git Service
Bruce Momjian [Fri, 11 Mar 2011 01:02:52 +0000 (20:02 -0500)]
Clarify C comment that O_SYNC/O_FSYNC are really the same settting, as
opposed to O_DSYNC.
Bruce Momjian [Fri, 11 Mar 2011 00:40:23 +0000 (19:40 -0500)]
Reference doc "examples" section for pg_dump options that often need
complex quoting, e.g. -t and -n.
Bruce Momjian [Thu, 10 Mar 2011 23:50:44 +0000 (18:50 -0500)]
More wording improvements for disallowed SQL function commands.
Bruce Momjian [Thu, 10 Mar 2011 23:47:44 +0000 (18:47 -0500)]
Improve SQL function disallowed command wording.
Bruce Momjian [Thu, 10 Mar 2011 23:46:21 +0000 (18:46 -0500)]
Clarify what commands are not allowed in SQL functions.
Bruce Momjian [Thu, 10 Mar 2011 23:06:13 +0000 (18:06 -0500)]
Add proper git-external-diff script to src/tools.
Tom Lane [Thu, 10 Mar 2011 22:30:18 +0000 (17:30 -0500)]
Revert addition of third argument to format_type().
Including collation in the behavior of that function promotes a world view
we do not want. Moreover, it was producing the wrong behavior for pg_dump
anyway: what we want is to dump a COLLATE clause on attributes whose
attcollation is different from the underlying type, and likewise for
domains, and the function cannot do that for us. Doing it the hard way
in pg_dump is a bit more tedious but produces more correct output.
In passing, fix initdb so that the initial entry in pg_collation is
properly pinned. It was droppable before :-(
Robert Haas [Thu, 10 Mar 2011 21:24:52 +0000 (16:24 -0500)]
Make error handling of synchronous_standby_names consistent.
It's not a good idea to kill the postmaster just because someone muffs
this, and it's not consistent with what we do for other, similar GUCs.
Fujii Masao, with a bit more hacking by me
Robert Haas [Thu, 10 Mar 2011 20:56:18 +0000 (15:56 -0500)]
More synchronous replication typo fixes.
Fujii Masao
Robert Haas [Thu, 10 Mar 2011 20:38:39 +0000 (15:38 -0500)]
More synchronous replication tweaks.
SyncRepRequested() must check not only the value of the
synchronous_replication GUC but also whether max_wal_senders > 0.
Otherwise, we might end up waiting for sync rep even when there's no
possibility of a standby ever managing to connect. There are some
existing cross-checks to prevent this, but they're not quite sufficient:
the user can start the server with max_wal_senders=0,
synchronous_standby_names='', and synchronous_replication=off and then
subsequent make synchronous_standby_names not empty using pg_ctl reload,
and then SET synchronous_standby=on, leading to an indefinite hang.
Along the way, rename the global variable for the synchronous_replication
GUC to match the name of the GUC itself, for clarity.
Report by Fujii Masao, though I didn't use his patch.
Robert Haas [Thu, 10 Mar 2011 20:00:20 +0000 (15:00 -0500)]
Remove obsolete comment.
In earlier versions of the sync rep patch, waiters removed themselves from
the queue, but now walsender removes them before doing the wakeup.
Report by Fujii Masao.
Robert Haas [Thu, 10 Mar 2011 19:57:02 +0000 (14:57 -0500)]
Minor sync rep corrections.
Fujii Masao, with a bit of additional wordsmithing by me.
Robert Haas [Thu, 10 Mar 2011 19:37:14 +0000 (14:37 -0500)]
Emit a LOG message when pausing at the recovery target.
Fujii Masao
Robert Haas [Thu, 10 Mar 2011 19:29:53 +0000 (14:29 -0500)]
Add missing index terms for recovery control functions.
Fujii Masao
Bruce Momjian [Thu, 10 Mar 2011 14:09:35 +0000 (09:09 -0500)]
Use '=' when documenting long options.
Robert Haas [Thu, 10 Mar 2011 13:59:59 +0000 (08:59 -0500)]
Replication README updates.
Fujii Masao
Heikki Linnakangas [Thu, 10 Mar 2011 07:01:27 +0000 (09:01 +0200)]
Fix bugs in the isolation tester flex rules.
Tom Lane pointed out that it was giving a warning: "-s option given but
default rule can be matched". That was because there was no rule to handle
newline in a quoted string. I made that throw an error.
Also, line number tracking was broken, giving incorrect line number on
error. Fixed that too.
Itagaki Takahiro [Thu, 10 Mar 2011 06:05:33 +0000 (15:05 +0900)]
Cleanup copyright years and file names in the header comments of some files.
Tom Lane [Thu, 10 Mar 2011 05:12:38 +0000 (00:12 -0500)]
replication/repl_gram.h needs to be cleaned too ...
Tom Lane [Thu, 10 Mar 2011 05:03:26 +0000 (00:03 -0500)]
Fix some oversights in distprep and maintainer-clean targets.
At least two recent commits have apparently imagined that a comment in
a Makefile stating that something would be included in the distribution
tarball was sufficient to make it so. They hadn't bothered to hook
into the upper maintainer-clean targets either. Per bug #5923 from
Charles Johnson, in which it emerged that the 9.1alpha4 tarballs are
short a few files that should be there.
Bruce Momjian [Thu, 10 Mar 2011 04:40:39 +0000 (23:40 -0500)]
Mention gcc version in C comment.
Tom Lane [Thu, 10 Mar 2011 03:38:52 +0000 (22:38 -0500)]
Remove collation information from TypeName, where it does not belong.
The initial collations patch treated a COLLATE spec as part of a TypeName,
following what can only be described as brain fade on the part of the SQL
committee. It's a lot more reasonable to treat COLLATE as a syntactically
separate object, so that it can be added in only the productions where it
actually belongs, rather than needing to reject it in a boatload of places
where it doesn't belong (something the original patch mostly failed to do).
In addition this change lets us meet the spec's requirement to allow
COLLATE anywhere in the clauses of a ColumnDef, and it avoids unfriendly
behavior for constructs such as "foo::type COLLATE collation".
To do this, pull collation information out of TypeName and put it in
ColumnDef instead, thus reverting most of the collation-related changes in
parse_type.c's API. I made one additional structural change, which was to
use a ColumnDef as an intermediate node in AT_AlterColumnType AlterTableCmd
nodes. This provides enough room to get rid of the "transform" wart in
AlterTableCmd too, since the ColumnDef can carry the USING expression
easily enough.
Also fix some other minor bugs that have crept in in the same areas,
like failure to copy recently-added fields of ColumnDef in copyfuncs.c.
While at it, document the formerly secret ability to specify a collation
in ALTER TABLE ALTER COLUMN TYPE, ALTER TYPE ADD ATTRIBUTE, and
ALTER TYPE ALTER ATTRIBUTE TYPE; and correct some misstatements about
what the default collation selection will be when COLLATE is omitted.
BTW, the three-parameter form of format_type() should go away too,
since it just contributes to the confusion in this area; but I'll do
that in a separate patch.
Bruce Momjian [Thu, 10 Mar 2011 01:19:59 +0000 (20:19 -0500)]
Document that server single-user mode does not do checkpoints or other
background processing.
Tom Lane [Wed, 9 Mar 2011 16:28:20 +0000 (11:28 -0500)]
Adjust the permissions required for COMMENT ON ROLE.
Formerly, any member of a role could change the role's comment, as of
course could superusers; but holders of CREATEROLE privilege could not,
unless they were also members. This led to the odd situation that a
CREATEROLE holder could create a role but then could not comment on it.
It also seems a bit dubious to let an unprivileged user change his own
comment, let alone those of group roles he belongs to. So, change the
rule to be "you must be superuser to comment on a superuser role, or
hold CREATEROLE to comment on non-superuser roles". This is the same
as the privilege check for creating/dropping roles, and thus fits much
better with the rule for other object types, namely that only the owner
of an object can comment on it.
In passing, clean up the documentation for COMMENT a little bit.
Per complaint from Owen Jacobson and subsequent discussion.
Bruce Momjian [Wed, 9 Mar 2011 14:48:05 +0000 (09:48 -0500)]
Remove '=' from initdb switch syntax.
Bruce Momjian [Wed, 9 Mar 2011 14:18:44 +0000 (09:18 -0500)]
Improve wording of initdb and pg_controldata manual pages.
gabrielle <gorthx@gmail.com>
Itagaki Takahiro [Wed, 9 Mar 2011 11:00:11 +0000 (20:00 +0900)]
Remove 's' from recovery_target_timeline's' from the release note.
Itagaki Takahiro [Wed, 9 Mar 2011 10:49:16 +0000 (19:49 +0900)]
synchronous_standby_names is a string parameter.
Robert Haas [Wed, 9 Mar 2011 05:06:02 +0000 (00:06 -0500)]
Make alpha release notes more consistent as regards periods.
Robert Haas [Wed, 9 Mar 2011 04:59:52 +0000 (23:59 -0500)]
Update alpha release notes for latest commits.
Tom Lane [Wed, 9 Mar 2011 03:50:15 +0000 (22:50 -0500)]
A bit more editing for collation documentation.
Bruce Momjian [Wed, 9 Mar 2011 02:35:42 +0000 (21:35 -0500)]
Fix file descriptor leaks in pg_upgrade in failure code paths.
Robert Haas [Wed, 9 Mar 2011 01:55:29 +0000 (20:55 -0500)]
Create "replication and recovery" section in alpha release notes.
Tom Lane [Tue, 8 Mar 2011 22:10:34 +0000 (17:10 -0500)]
Assorted editing for collation documentation.
I made a pass over this to familiarize myself with the feature, and found
some things that could be improved.
Peter Eisentraut [Tue, 8 Mar 2011 21:49:59 +0000 (23:49 +0200)]
Fix parallel make when running make install before make all
In addition to the
all-foo-recurse: all-bar-recurse
dependencies that constraint the order of the rule execution, we need
install-foo-recurse: install-bar-recurse
dependencies in case one runs make install without a make all first,
as some people apparently do.
Tom Lane [Tue, 8 Mar 2011 21:43:02 +0000 (16:43 -0500)]
Add missing keywords to gram.y's unreserved_keywords list.
We really need an automated check for this ... and did VALIDATE really
need to become a keyword at all, rather than picking some other syntax
using existing keywords?
Peter Eisentraut [Tue, 8 Mar 2011 20:10:00 +0000 (22:10 +0200)]
Ignore files built by coverage builds
Heikki Linnakangas [Tue, 8 Mar 2011 19:01:29 +0000 (21:01 +0200)]
Fix overly strict assertion in SummarizeOldestCommittedSxact(). There's a
race condition where SummarizeOldestCommittedSxact() is called even though
another backend already cleared out all finished sxact entries. That's OK,
RegisterSerializableTransactionInt() can just retry getting a news xact
slot from the available-list when that happens.
Reported by YAMAMOTO Takashi, bug #5918.
Heikki Linnakangas [Tue, 8 Mar 2011 18:13:52 +0000 (20:13 +0200)]
Don't throw a warning if vacuum sees PD_ALL_VISIBLE flag set on a page that
contains newly-inserted tuples that according to our OldestXmin are not
yet visible to everyone. The value returned by GetOldestXmin() is conservative,
and it can move backwards on repeated calls, so if we see that contradiction
between the PD_ALL_VISIBLE flag and status of tuples on the page, we have to
assume it's because an earlier vacuum calculated a higher OldestXmin value,
and all the tuples really are visible to everyone.
We have received several reports of this bug, with the "PD_ALL_VISIBLE flag
was incorrectly set in relation ..." warning appearing in logs. We were
finally able to hunt it down with David Gould's help to run extra diagnostics
in an environment where this happened frequently.
Also reword the warning, per Robert Haas' suggestion, to not imply that the
PD_ALL_VISIBLE flag is necessarily at fault, as it might also be a symptom
of corruption on a tuple header.
Backpatch to 8.4, where the PD_ALL_VISIBLE flag was introduced.
Bruce Momjian [Tue, 8 Mar 2011 17:54:00 +0000 (12:54 -0500)]
Adjust CHAR() doc mention of pattern matching issues for trailing
spaces.
Bruce Momjian [Tue, 8 Mar 2011 16:03:02 +0000 (11:03 -0500)]
Document that char() ignores spaces in non-pattern comparisons, not in
pattern comparisons such as LIKE and regex.
Michael Meskes [Tue, 8 Mar 2011 10:27:32 +0000 (11:27 +0100)]
Added new version of ecpg's parser test script which was written by Andy Colson <andy@squeakycode.net>.
Heikki Linnakangas [Tue, 8 Mar 2011 10:07:29 +0000 (12:07 +0200)]
Truncate predicate lock manager's SLRU lazily at checkpoint. That's safer
than doing it aggressively whenever the tail-XID pointer is advanced, because
this way we don't need to do it while holding SerializableXactHashLock.
This also fixes bug #5915 spotted by YAMAMOTO Takashi, and removes an
obsolete comment spotted by Kevin Grittner.
Peter Eisentraut [Mon, 7 Mar 2011 21:01:54 +0000 (23:01 +0200)]
Fix behavior when raising plpy.Fatal()
It should cause a elog(FATAL) error, and it fact it was simply causing
a elog(ERROR).
Jan Urbański
Peter Eisentraut [Mon, 7 Mar 2011 20:53:32 +0000 (22:53 +0200)]
Report Python errors from iterators with PLy_elog
This improves reporting, as the error string now includes the actual
Python exception. As a side effect, this no longer sets the errcode to
ERRCODE_DATA_EXCEPTION, which might be considered a feature, as it's
not documented and not clear why iterator errors should be treated
differently.
Jan Urbański
Tom Lane [Mon, 7 Mar 2011 21:21:26 +0000 (16:21 -0500)]
Improve description of inquiry functions that accept regclass.
Per a suggestion from Thom Brown, though this is not his proposed patch.
Tom Lane [Mon, 7 Mar 2011 21:00:36 +0000 (16:00 -0500)]
Minor copy-editing in CREATE TRIGGER reference page.
Per suggestions from Thom Brown and Robert Haas.
Heikki Linnakangas [Mon, 7 Mar 2011 19:02:40 +0000 (21:02 +0200)]
If recovery_target_timeline is set to 'latest' and standby mode is enabled,
periodically rescan the archive for new timelines, while waiting for new WAL
segments to arrive. This allows you to set up a standby server that follows
the TLI change if another standby server is promoted to master. Before this,
you had to restart the standby server to make it notice the new timeline.
This patch only scans the archive for TLI changes, it won't follow a TLI
change in streaming replication. That is much needed too, but it would be a
much bigger patch than I dare to sneak in this late in the release cycle.
There was discussion on improving the sanity checking of the WAL segments so
that the system would notice more reliably if the new timeline isn't an
ancestor of the current one, but that is not included in this patch.
Reviewed by Fujii Masao.
Robert Haas [Mon, 7 Mar 2011 18:57:06 +0000 (13:57 -0500)]
Reword alpha release note item on SSI.
Per Josh Berkus; some additional explanatory text by me.
Robert Haas [Mon, 7 Mar 2011 16:59:58 +0000 (11:59 -0500)]
Synchronous replication doc corrections.
Thom Brown
Tom Lane [Mon, 7 Mar 2011 16:17:06 +0000 (11:17 -0500)]
Zero out vacuum_count and related counters in pgstat_recv_tabstat().
This fixes an oversight in commit
946045f04d11d246a834b917a2b8bc6e4f884a37
of 2010-08-21, as reported by Itagaki Takahiro. Also a couple of minor
cosmetic adjustments.
Heikki Linnakangas [Mon, 7 Mar 2011 08:42:49 +0000 (10:42 +0200)]
Document the DEFERRABLE option in SET TRANSACTION command.
Kevin Grittner
Heikki Linnakangas [Mon, 7 Mar 2011 08:41:13 +0000 (10:41 +0200)]
Begin error message with lower-case letter.
Heikki Linnakangas [Mon, 7 Mar 2011 07:56:53 +0000 (09:56 +0200)]
Silence compiler warning about undefined function when compiling without
assertions.
Bruce Momjian [Mon, 7 Mar 2011 02:57:02 +0000 (21:57 -0500)]
Tighten pg_upgrade check for pre-8.4 toast table name matching.
Tom Lane [Mon, 7 Mar 2011 02:15:48 +0000 (21:15 -0500)]
Suppress some "variable might be clobbered by longjmp" warnings.
Seen with an older gcc version. I'm not sure these represent any real
risk factor, but still a bit scary. Anyway we have lots of other
volatile-marked variables in this code, so a couple more won't hurt.
Tom Lane [Mon, 7 Mar 2011 01:14:01 +0000 (20:14 -0500)]
Fix a couple more missing "static" markers.
Tom Lane [Mon, 7 Mar 2011 01:04:29 +0000 (20:04 -0500)]
Add missing "static" marker to internal_ping().
Per testing with a compiler that doesn't like that.
Simon Riggs [Mon, 7 Mar 2011 00:26:30 +0000 (00:26 +0000)]
Dynamic array required within pg_stat_replication.
Simon Riggs [Sun, 6 Mar 2011 23:44:44 +0000 (23:44 +0000)]
Catversion increment for pg_stat_replication changes for syncrep
Simon Riggs [Sun, 6 Mar 2011 23:39:14 +0000 (23:39 +0000)]
Add new files for syncrep missed in previous commit
Tom Lane [Sun, 6 Mar 2011 23:26:18 +0000 (18:26 -0500)]
Fix pg_dump's dump order for collations versus extensions.
Mixing them together alphabetically won't be nice. Per my gripe of
2011-02-12.
Simon Riggs [Sun, 6 Mar 2011 22:49:16 +0000 (22:49 +0000)]
Efficient transaction-controlled synchronous replication.
If a standby is broadcasting reply messages and we have named
one or more standbys in synchronous_standby_names then allow
users who set synchronous_replication to wait for commit, which
then provides strict data integrity guarantees. Design avoids
sending and receiving transaction state information so minimises
bookkeeping overheads. We synchronize with the highest priority
standby that is connected and ready to synchronize. Other standbys
can be defined to takeover in case of standby failure.
This version has very strict behaviour; more relaxed options
may be added at a later date.
Simon Riggs and Fujii Masao, with reviews by Yeb Havinga, Jaime
Casanova, Heikki Linnakangas and Robert Haas, plus the assistance
of many other design reviewers.
Tom Lane [Sun, 6 Mar 2011 17:10:50 +0000 (12:10 -0500)]
Fix incorrect access to pg_index.indcollation.
Since this field is after a variable-length field, it can't simply be
accessed via the C struct for pg_index. Fortunately, the relcache already
did the dirty work of pulling the information out to where it can be
accessed easily, so this is a one-line fix.
Andres Freund
Bruce Momjian [Sun, 6 Mar 2011 11:34:58 +0000 (06:34 -0500)]
Improve pg_upgrade relation name check logic for pre-8.4 servers.
Bruce Momjian [Sun, 6 Mar 2011 03:09:35 +0000 (22:09 -0500)]
Update new pg_upgrade comment about pre-8.4 TOAST tables.
Bruce Momjian [Sun, 6 Mar 2011 02:12:21 +0000 (21:12 -0500)]
Restructure pg_upgrade checks because pre-8.4 Postgres did not rename
toast file names to match the new relfilenode.
Bruce Momjian [Sun, 6 Mar 2011 01:18:31 +0000 (20:18 -0500)]
Fix pg_upgrade to print the proper database name for file transfer
failures.
Bruce Momjian [Sun, 6 Mar 2011 00:32:53 +0000 (19:32 -0500)]
Print clearer failure message when pg_upgrade fails due to a fatal
error.
Bruce Momjian [Sat, 5 Mar 2011 23:32:06 +0000 (18:32 -0500)]
Fix parallel gmake for extension directory addition in PL languages.
Andrew Dunstan [Sat, 5 Mar 2011 21:21:37 +0000 (16:21 -0500)]
Add PL extension files to MSVC Install procedure.
Tom Lane [Sat, 5 Mar 2011 20:34:10 +0000 (15:34 -0500)]
Adjust documentation about pg_pltemplate to reflect latest thinking.
It's more likely that pg_pltemplate will go away in the future than
that we'll add additional specialized infrastructure for it.
Tom Lane [Sat, 5 Mar 2011 20:13:15 +0000 (15:13 -0500)]
Make plpythonu language use plpython2 shared library directly.
The original scheme for this was to symlink plpython.$DLSUFFIX to
plpython2.$DLSUFFIX, but that doesn't work on Windows, and only
accidentally failed to fail because of the way that CREATE LANGUAGE created
or didn't create new C functions. My changes of yesterday exposed the
weakness of that approach. To fix, get rid of the symlink and make
pg_pltemplate show what's really going on.
Tom Lane [Sat, 5 Mar 2011 19:03:06 +0000 (14:03 -0500)]
Convert createlang/droplang to use CREATE/DROP EXTENSION.
In createlang this is a one-line change. In droplang there's a whole
lot of cruft that can be discarded since the extension mechanism now
manages removal of the language's support functions.
Also, add deprecation notices to these two programs' reference pages,
since per discussion we may toss them overboard altogether in a release
or two.
Robert Haas [Sat, 5 Mar 2011 18:00:54 +0000 (13:00 -0500)]
Remove one copy of duplicated alpha4 release note.
Noted by Andy Colson
Peter Eisentraut [Sat, 5 Mar 2011 14:50:03 +0000 (16:50 +0200)]
Update of SQL feature conformance
Robert Haas [Sat, 5 Mar 2011 14:53:05 +0000 (09:53 -0500)]
Add missing word.
Robert Haas [Sat, 5 Mar 2011 14:36:19 +0000 (09:36 -0500)]
First cut at 9.1alpha4 release notes.
Robert Haas [Sat, 5 Mar 2011 12:36:35 +0000 (07:36 -0500)]
Remove emphasis from 9.1alpha3 items.
In preparation for 9.1alpha4 release notes, where only the 9.1alpha4
features will be emphasized.
Tom Lane [Sat, 5 Mar 2011 06:08:38 +0000 (01:08 -0500)]
Update documentation to reflect that standard PLs are now extensions.
Recommend use of CREATE EXTENSION rather than plain CREATE LANGUAGE
where relevant. Encourage PL authors to provide extension wrappers
for their PLs.
Tom Lane [Sat, 5 Mar 2011 02:51:14 +0000 (21:51 -0500)]
Create extension infrastructure for the core procedural languages.
This mostly just involves creating control, install, and
update-from-unpackaged scripts for them. However, I had to adjust plperl
and plpython to not share the same support functions between variants,
because we can't put the same function into multiple extensions.
catversion bump forced due to new contents of pg_pltemplate, and because
initdb now installs plpgsql as an extension not a bare language.
Add support for regression testing these as extensions not bare
languages.
Fix a couple of other issues that popped up while testing this: my initial
hack at pg_dump binary-upgrade support didn't work right, and we don't want
an extra schema permissions test after all.
Documentation changes still to come, but I'm committing now to see
whether the MSVC build scripts need work (likely they do).
Robert Haas [Fri, 4 Mar 2011 22:26:37 +0000 (17:26 -0500)]
Refactor seclabel.c to use the new check_object_ownership function.
This avoids duplicate (and not-quite-matching) code, and makes the logic
for SECURITY LABEL match COMMENT and ALTER EXTENSION ADD/DROP.
Peter Eisentraut [Fri, 4 Mar 2011 21:39:44 +0000 (23:39 +0200)]
Don't allow CREATE TABLE AS to create a column with invalid collation
It is possible that an expression ends up with a collatable type but
without a collation. CREATE TABLE AS could then create a table based
on that. But such a column cannot be dumped with valid SQL syntax, so
we disallow creating such a column.
per test report from Noah Misch
Tom Lane [Fri, 4 Mar 2011 21:08:24 +0000 (16:08 -0500)]
Allow non-superusers to create (some) extensions.
Remove the unconditional superuser permissions check in CREATE EXTENSION,
and instead define a "superuser" extension property, which when false
(not the default) skips the superuser permissions check. In this case
the calling user only needs enough permissions to execute the commands
in the extension's installation script. The superuser property is also
enforced in the same way for ALTER EXTENSION UPDATE cases.
In other ALTER EXTENSION cases and DROP EXTENSION, test ownership of
the extension rather than superuserness. ALTER EXTENSION ADD/DROP needs
to insist on ownership of the target object as well; to do that without
duplicating code, refactor comment.c's big switch for permissions checks
into a separate function in objectaddress.c.
I also removed the superuserness checks in pg_available_extensions and
related functions; there's no strong reason why everybody shouldn't
be able to see that info.
Also invent an IF NOT EXISTS variant of CREATE EXTENSION, and use that
in pg_dump, so that dumps won't fail for installed-by-default extensions.
We don't have any of those yet, but we will soon.
This is all per discussion of wrapping the standard procedural languages
into extensions. I'll make those changes in a separate commit; this is
just putting the core infrastructure in place.
Peter Eisentraut [Fri, 4 Mar 2011 20:14:37 +0000 (22:14 +0200)]
When creating a collation, check that the locales can be loaded
This is the same check that would happen later when the collation is
used, but it's friendlier to check the collation already when it is
created.
Tom Lane [Fri, 4 Mar 2011 16:38:45 +0000 (11:38 -0500)]
In initialize_SSL, don't fail unnecessarily when home dir is unavailable.
Instead, just act as though the certificate file(s) are not present.
There is only one case where this need be a hard failure condition: when
sslmode is verify-ca or verify-full, not having a root cert file is an
error. Change the logic so that we complain only in that case, and
otherwise fall through cleanly. This is how it used to behave pre-9.0,
but my patch
4ed4b6c54e5fab24ab2624d80e26f7546edc88ad of 2010-05-26 broke
the case. Per report from Christian Kastner.
Heikki Linnakangas [Fri, 4 Mar 2011 13:37:09 +0000 (15:37 +0200)]
You must hold a lock on the heap page when you call
CheckForSerializableConflictOut(), because it can set hint bits.
YAMAMOTO Takashi
Andrew Dunstan [Fri, 4 Mar 2011 00:41:54 +0000 (19:41 -0500)]
Add a comment explaining the recent fix for plpython breakage in commit
4c966d9.
Mostly text supplied by Jan Urbański.
Tom Lane [Thu, 3 Mar 2011 20:55:47 +0000 (15:55 -0500)]
Further refine patch for commenting operator implementation functions.
Instead of manually maintaining the "implementation of XXX operator"
comments in pg_proc.h, delete all those entries and let initdb create
them via a join. To let initdb figure out which name to use when there
is a conflict, change the comments for deprecated operators to say they
are deprecated --- which seems like a good thing to do anyway.
Tom Lane [Thu, 3 Mar 2011 18:22:18 +0000 (13:22 -0500)]
Fix citext's upgrade-from-unpackaged script to set its collation correctly.
Although there remains some debate about how CREATE TYPE should represent
the collation property, this doesn't really affect what we need to do in
citext's script, so go ahead and fix that.
Tom Lane [Thu, 3 Mar 2011 18:03:34 +0000 (13:03 -0500)]
Run a portal's cleanup hook immediately when pushing it to DONE state.
This works around the problem noted by Yamamoto Takashi in bug #5906,
that there were code paths whereby we could reach AtCleanup_Portals
with a portal's cleanup hook still unexecuted. The changes I made
a few days ago were intended to prevent that from happening, and
I think that on balance it's still a good thing to avoid, so I don't
want to remove the Assert in AtCleanup_Portals. Hence do this instead.
Michael Meskes [Thu, 3 Mar 2011 12:43:50 +0000 (13:43 +0100)]
Added new version of ecpg's parser generator script. This one was written by
Andy Colson <andy@squeakycode.net>.
Heikki Linnakangas [Thu, 3 Mar 2011 07:42:02 +0000 (09:42 +0200)]
Add tab-completion for table name after JOIN.
Andrey Popp
Tom Lane [Thu, 3 Mar 2011 06:43:38 +0000 (01:43 -0500)]
Add -lm to SHLIB_LINK for contrib/btree_gist.
Now that btree_gist contains a reference to isinf(), this is necessary
at least on some platforms. Per buildfarm.
Tom Lane [Thu, 3 Mar 2011 06:33:19 +0000 (01:33 -0500)]
Mark operator implementation functions as such in their comments.
Historically, we've not had separate comments for built-in pg_operator
entries, but relied on the comments for the underlying functions. The
trouble with this approach is that there isn't much of anything to suggest
to users that they'd be better off using the operators instead. So, move
all the relevant comments into pg_operator, and give each underlying
function a comment that just says "implementation of XXX operator".
There are only about half a dozen cases where it seems reasonable to use
the underlying function interchangeably with the operator; in these cases
I left the same comment in place on the function as on the operator.
While at it, establish a policy that every built-in function and operator
entry should have a comment: there are now queries in the opr_sanity
regression test that will complain if one doesn't. This only required
adding a dozen or two more entries than would have been there anyway.
I also spent some time trying to eliminate gratuitous inconsistencies in
the style of the comments, though it's hopeless to suppose that more won't
creep in soon enough.
Per my proposal of 2010-10-15.
Peter Eisentraut [Wed, 2 Mar 2011 21:10:41 +0000 (23:10 +0200)]
Add collations to information_schema.usage_privileges
This is faked information like for domains.
Tom Lane [Wed, 2 Mar 2011 21:11:05 +0000 (16:11 -0500)]
Add 'collatable' to the Parameters section of CREATE TYPE.
Tom Lane [Wed, 2 Mar 2011 19:43:24 +0000 (14:43 -0500)]
Add KNNGIST support to contrib/btree_gist.
This extends GiST's support for nearest-neighbor searches to many of the
standard data types.
Teodor Sigaev
Peter Eisentraut [Wed, 2 Mar 2011 19:15:28 +0000 (21:15 +0200)]
Support for DragonFly BSD
Mapped to NetBSD, the closest existing match. (Even though DragonFly
BSD is derived from FreeBSD, the shared library version numbering
matches NetBSD, and the rest is mostly the same among all BSD
variants.)
per "Rumko"
Tom Lane [Wed, 2 Mar 2011 16:39:18 +0000 (11:39 -0500)]
Fix erroneous documentation of the syntax of CREATE CONSTRAINT TRIGGER.
The grammar requires a specific ordering of the clauses, but the
documentation showed a different order. This error was introduced in
commit
b47953f9c69d48a9261bd643e3170017b93f6337, which merged the CREATE
CONSTRAINT TRIGGER documentation into the CREATE TRIGGER page. There is
no code bug AFAICS.