OSDN Git Service
Tom Lane [Wed, 12 Aug 2009 21:03:52 +0000 (21:03 +0000)]
The html-stamp and man-stamp files also need to be cvsignore'd.
Tom Lane [Wed, 12 Aug 2009 20:53:31 +0000 (20:53 +0000)]
Allow backends to start up without use of the flat-file copy of pg_database.
To make this work in the base case, pg_database now has a nailed-in-cache
relation descriptor that is initialized using hardwired knowledge in
relcache.c. This means pg_database is added to the set of relations that
need to have a Schema_pg_xxx macro maintained in pg_attribute.h. When this
path is taken, we'll have to do a seqscan of pg_database to find the row
we need.
In the normal case, we are able to do an indexscan to find the database's row
by name. This is made possible by storing a global relcache init file that
describes only the shared catalogs and their indexes (and therefore is usable
by all backends in any database). A new backend loads this cache file,
finds its database OID after an indexscan on pg_database, and then loads
the local relcache init file for that database.
This change should effectively eliminate number of databases as a factor
in backend startup time, even with large numbers of databases. However,
the real reason for doing it is as a first step towards getting rid of
the flat files altogether. There are still several other sub-projects
to be tackled before that can happen.
Tom Lane [Wed, 12 Aug 2009 18:23:49 +0000 (18:23 +0000)]
Fix old bug in log_autovacuum_min_duration code: it was relying on being able
to access a Relation entry it had just closed. I happened to be testing with
CLOBBER_CACHE_ALWAYS, which made this a guaranteed core dump (at least on
machines where sprintf %s isn't forgiving of a NULL pointer). It's probably
quite unlikely that it would fail in the field, but a bug is a bug. Fix by
moving the relation_close call down past the logging action.
Peter Eisentraut [Wed, 12 Aug 2009 16:37:26 +0000 (16:37 +0000)]
Split the plpython regression test into test cases arranged by topic, instead
of the previous monolithic setup-create-run sequence, that was apparently
inherited from a previous test infrastructure, but makes working with the
tests and adding new ones weird.
Peter Eisentraut [Wed, 12 Aug 2009 16:32:35 +0000 (16:32 +0000)]
Document the minimum required Python version.
It turns out that Python 2.2 is the oldest version that PL/Python compiles
with, apparently related to the introduction of iterators. Might as well
document this.
Peter Eisentraut [Tue, 11 Aug 2009 22:22:15 +0000 (22:22 +0000)]
Add .cvsignore entries for documentation files
Peter Eisentraut [Tue, 11 Aug 2009 22:21:51 +0000 (22:21 +0000)]
Remove unnecessary files from distribution
Peter Eisentraut [Tue, 11 Aug 2009 21:53:06 +0000 (21:53 +0000)]
Simplify and speed up man page installation
Alvaro Herrera [Tue, 11 Aug 2009 20:16:03 +0000 (20:16 +0000)]
Refactor some $(JADE.tex.call)s
Bruce Momjian [Tue, 11 Aug 2009 12:02:58 +0000 (12:02 +0000)]
Remove tab in SGML.
Alvaro Herrera [Mon, 10 Aug 2009 22:41:38 +0000 (22:41 +0000)]
Fix URL to "The Hitch-Hiker's Guide to Evolutionary Computation".
Per Andreas Wenk, Andres Freund and Rob Wultsh. Thanks, Robert Haas, for the
patch.
Alvaro Herrera [Mon, 10 Aug 2009 22:13:50 +0000 (22:13 +0000)]
Fix number of columns declared for pg_user_mappings description table.
Alvaro Herrera [Mon, 10 Aug 2009 20:16:05 +0000 (20:16 +0000)]
Refactor NUM_cache_remove calls in error report path to a PG_TRY block.
The code in the new block was not reindented; it will be fixed by pgindent
eventually.
Tom Lane [Mon, 10 Aug 2009 18:29:27 +0000 (18:29 +0000)]
Support EEEE (scientific notation) in to_char().
Pavel Stehule, Brendan Jurd
Bruce Momjian [Mon, 10 Aug 2009 18:19:06 +0000 (18:19 +0000)]
Adjust test_fsync code to be more sane.
Backpatch to 8.4.X.
Tom Lane [Mon, 10 Aug 2009 16:10:19 +0000 (16:10 +0000)]
Adjust extract(epoch) example to clarify that it includes fractional
seconds, per gripe from Richard Neill. Also, add a cross-reference to
the to_timestamp function.
Tom Lane [Mon, 10 Aug 2009 05:46:50 +0000 (05:46 +0000)]
Extend EXPLAIN to support output in XML or JSON format.
There are probably still some adjustments to be made in the details
of the output, but this gets the basic structure in place.
Robert Haas
Andrew Dunstan [Mon, 10 Aug 2009 02:39:04 +0000 (02:39 +0000)]
Re-add documentation for --no-readline option of psql, mistakenly removed a decade ago. Backpatch to release 7.4.
Peter Eisentraut [Sun, 9 Aug 2009 22:47:59 +0000 (22:47 +0000)]
Ship documentation without intermediate tarballs
Documentation files in HTML and man formats are now prepared for
distribution using the distprep make target, like everything else. They
are placed in doc/src/sgml/html and manX and installed from there by
make install, if present. The business with the tarballs in the tarball
is gone.
Tom Lane [Sat, 8 Aug 2009 16:39:17 +0000 (16:39 +0000)]
Document that LocalSetXLogInsertAllowed can be re-executed.
Per comment from Simon.
Tom Lane [Fri, 7 Aug 2009 22:48:34 +0000 (22:48 +0000)]
Modify parallel pg_restore to track pending and ready items by means of
two new lists, rather than repeatedly rescanning the main TOC list.
This avoids a potential O(N^2) slowdown, although you'd need a *lot*
of tables to make that really significant; and it might simplify future
improvements in the scheduling algorithm by making the set of ready
items more easily inspectable. The original thought that it would
in itself result in a more efficient job dispatch order doesn't seem
to have been borne out in testing, but it seems worth doing anyway.
Alvaro Herrera [Fri, 7 Aug 2009 20:54:31 +0000 (20:54 +0000)]
Document that autovacuum may run ANALYZE
Peter Eisentraut [Fri, 7 Aug 2009 20:50:22 +0000 (20:50 +0000)]
Expand test coverage support to entire tree
Test coverage support now covers the entire source tree, including
contrib, instead of just src/backend. In a related but independent
development, the commands make coverage and make coverage-html can be run
in any directory.
This turned out to be much easier than feared. Besides a few ad hoc fixes
to pass the make target down the tree, change all affected makefiles to
list their directories in the SUBDIRS variable, changed from variants like
DIRS and WANTED_DIRS. MSVC build fix was attempted as well.
Tom Lane [Fri, 7 Aug 2009 20:16:11 +0000 (20:16 +0000)]
Try to defend against the possibility that libpq is still in COPY_IN state
when we reach the post-COPY "pump it dry" error recovery code that was added
2006-11-24. Per a report from Neil Best, there is at least one code path
in which this occurs, leading to an infinite loop in code that's supposed
to be making it more robust not less so. A reasonable response seems to be
to call PQputCopyEnd() again, so let's try that.
Back-patch to all versions that contain the cleanup loop.
Tom Lane [Fri, 7 Aug 2009 19:29:49 +0000 (19:29 +0000)]
rm_cleanup functions need to be allowed to write WAL entries. This oversight
appears to explain the recent reports of "PANIC: cannot make new WAL entries
during recovery".
Bruce Momjian [Fri, 7 Aug 2009 16:47:53 +0000 (16:47 +0000)]
Remove unused ecpg variable.
Tom Lane [Fri, 7 Aug 2009 16:19:57 +0000 (16:19 +0000)]
Remove long-since-unused file commands/version.h.
Noticed by Itagaki Takahiro.
Tom Lane [Fri, 7 Aug 2009 15:27:56 +0000 (15:27 +0000)]
Fix some omissions in the dependency-object-class support for SQL/MED objects.
Main problem found by Muhammad Aqeel, some cosmetic additions by me.
Michael Meskes [Fri, 7 Aug 2009 10:51:21 +0000 (10:51 +0000)]
Added STRING datatype for Informix compatibility mode. This work is
based on a patch send in by Böszörményi Zoltán <zb@cybertec.at>.
Heikki Linnakangas [Fri, 7 Aug 2009 05:58:55 +0000 (05:58 +0000)]
Fast shutdown stop should forcibly disconnect any active backends, even
if a smart shutdown is already in progress. Backpatch to 8.3, this was broken
in the patch that introduced "dead-end backends".
Per report by Itagaki Takahiro, patch by Fujii Masao.
Tom Lane [Thu, 6 Aug 2009 20:44:32 +0000 (20:44 +0000)]
Improve plpgsql's ability to cope with rowtypes containing dropped columns,
by supporting conversions in places that used to demand exact rowtype match.
Since this issue is certain to come up elsewhere (in fact, already has,
in ExecEvalConvertRowtype), factor out the support code into new core
functions for tuple conversion. I chose to put these in a new source
file since heaptuple.c is already overly long.
Heavily revised version of a patch by Pavel Stehule.
Magnus Hagander [Thu, 6 Aug 2009 09:50:22 +0000 (09:50 +0000)]
Avoid terminating the postmaster on a number of "can't happen" cases during
backend startup on Win32. Instead, log the error and just forget about
the potentially dangling process, since we can't do anything about it anyway.
Alvaro Herrera [Wed, 5 Aug 2009 19:31:50 +0000 (19:31 +0000)]
Fix manpages related to SPI functions.
This patch adds declaration so that they end up in section 3, and adds
them to the Makefiles to install them.
Also, some synopses needed reflowing so that they look nice in 80-column
terminals.
Tom Lane [Wed, 5 Aug 2009 18:06:49 +0000 (18:06 +0000)]
Add matchorig, matchsynonyms, and keepsynonyms options to contrib/dict_xsyn.
Sergey Karpov
Heikki Linnakangas [Wed, 5 Aug 2009 18:01:54 +0000 (18:01 +0000)]
Improve error messages in md.c. When a filesystem operation like open() or
fsync() fails, say "file" rather than "relation" when printing the filename.
This makes messages that display block numbers a bit confusing. For example,
in message 'could not read block 150000 of file "base/1234/5678.1"', 150000
is the block number from the beginning of the relation, ie. segment 0, not
150000th block within that segment. Per discussion, users aren't usually
interested in the exact location within the file, so we can live with that.
To ease constructing error messages, add FilePathName(File) function to
return the pathname of a virtual fd.
Joe Conway [Wed, 5 Aug 2009 16:11:07 +0000 (16:11 +0000)]
Implement dblink_get_notify().
Adds the ability to retrieve async notifications using dblink,
via the addition of the function dblink_get_notify(). Original patch
by Marcus Kempe, suggestions by Tom Lane and Alvaro Herrera, patch
review and adjustments by Joe Conway.
Michael Meskes [Wed, 5 Aug 2009 11:42:20 +0000 (11:42 +0000)]
Fixed copyright notice.
Peter Eisentraut [Tue, 4 Aug 2009 22:04:37 +0000 (22:04 +0000)]
Use DocBook XSL stylesheets for man page building
This switches the man page building process to use the DocBook XSL stylesheet
toolchain. The previous targets for Docbook2X are removed. configure has been
updated to look for the new tools. The Documentation appendix contains the
new build instructions. There are also a few isolated tweaks in the
documentation to improve places that came out strangely in the man pages.
Tom Lane [Tue, 4 Aug 2009 21:56:09 +0000 (21:56 +0000)]
Fix pg_dump to do the right thing when escaping the contents of large objects.
The previous implementation got it right in most cases but failed in one:
if you pg_dump into an archive with standard_conforming_strings enabled, then
pg_restore to a script file (not directly to a database), the script will set
standard_conforming_strings = on but then emit large object data as
nonstandardly-escaped strings.
At the moment the code is made to emit hex-format bytea strings when dumping
to a script file. We might want to change to old-style escaping for backwards
compatibility, but that would be slower and bulkier. If we do, it's just a
matter of reimplementing appendByteaLiteral().
This has been broken for a long time, but given the lack of field complaints
I'm not going to worry about back-patching.
Alvaro Herrera [Tue, 4 Aug 2009 21:22:46 +0000 (21:22 +0000)]
Avoid including miscadmin.h into plpgsql.h; instead include it into the two
source files that need it.
Tom Lane [Tue, 4 Aug 2009 21:09:39 +0000 (21:09 +0000)]
Fix an ecpg test, too. Are we there yet?
Tom Lane [Tue, 4 Aug 2009 20:10:00 +0000 (20:10 +0000)]
Fix some more regression tests (missed these because they're only
run when built with --with-openssl).
Tom Lane [Tue, 4 Aug 2009 19:46:51 +0000 (19:46 +0000)]
Suppress pointer-signedness warning.
Tom Lane [Tue, 4 Aug 2009 18:49:50 +0000 (18:49 +0000)]
Ooops, missed that a couple of contrib modules have calls to byteacmp.
Add bytea.h inclusions as needed. Some of the contrib regression tests
need to be de-hexified, too. Per buildfarm.
Tom Lane [Tue, 4 Aug 2009 18:05:42 +0000 (18:05 +0000)]
Teach PQescapeByteaConn() to use hex format when the target connection is
to a server >= 8.5. Per my proposal in discussion of hex-format patch.
Tom Lane [Tue, 4 Aug 2009 16:08:37 +0000 (16:08 +0000)]
Support hex-string input and output for type BYTEA.
Both hex format and the traditional "escape" format are automatically
handled on input. The output format is selected by the new GUC variable
bytea_output.
As committed, bytea_output defaults to HEX, which is an *incompatible
change*. We will keep it this way for awhile for testing purposes, but
should consider whether to switch to the more backwards-compatible
default of ESCAPE before 8.5 is released.
Peter Eisentraut
Tom Lane [Tue, 4 Aug 2009 04:04:12 +0000 (04:04 +0000)]
Cause pg_proc.probin to be declared as text, not bytea. Everything was
already treating it as text anyway, to the point that I couldn't find anything
to change except the datatype markings in catalog/*.h. The only effect that
the bytea declaration had was to cause byteaout() to be invoked when pg_dump
(or another client program) inspected the column value. Since pg_dump wasn't
expecting that, but just treating what it got as text, the net result is that
dump and reload would mangle any backslashes or non-ASCII characters in the
filename string for a C-language function. That is a very long-standing bug,
but given the lack of field complaints it doesn't seem worth trying to find
a back-patchable fix. We'll just make this change to fix it going forward.
This change will also forestall problems after the planned change to let bytea
emit hex output instead of escaped characters.
Joe Conway [Mon, 3 Aug 2009 21:11:40 +0000 (21:11 +0000)]
Implement has_sequence_privilege()
Add family of functions that did not exist earlier,
mainly due to historical omission. Original patch by
Abhijit Menon-Sen, with review and modifications by
Joe Conway. catversion.h bumped.
Tom Lane [Mon, 3 Aug 2009 18:30:55 +0000 (18:30 +0000)]
Portability and documentation fixes for threaded pgbench patch.
Tatsuo Ishii [Mon, 3 Aug 2009 15:18:14 +0000 (15:18 +0000)]
Multi-threaded version of pgbench contributed by ITAGAKI Takahiro,
reviewed by Greg Smith and Josh Williams.
Following is the proposal from ITAGAKI Takahiro:
Pgbench is a famous tool to measure postgres performance, but nowadays
it does not work well because it cannot use multiple CPUs. On the other
hand, postgres server can use CPUs very well, so the bottle-neck of
workload is *in pgbench*.
Multi-threading would be a solution. The attached patch adds -j
(number of jobs) option to pgbench. If the value N is greater than 1,
pgbench runs with N threads. Connections are equally-divided into
them (ex. -c64 -j4 => 4 threads with 16 connections each). It can
run on POSIX platforms with pthread and on Windows with win32 threads.
Here are results of multi-threaded pgbench runs on Fedora 11 with intel
core i7 (8 logical cores = 4 physical cores * HT). -j8 (8 threads) was
the best and the tps is 4.5 times of -j1, that is a traditional result.
$ pgbench -i -s10
$ pgbench -n -S -c64 -j1 => tps = 11600.158593
$ pgbench -n -S -c64 -j2 => tps = 17947.100954
$ pgbench -n -S -c64 -j4 => tps = 26571.124001
$ pgbench -n -S -c64 -j8 => tps = 52725.470403
$ pgbench -n -S -c64 -j16 => tps = 38976.675319
$ pgbench -n -S -c64 -j32 => tps = 28998.499601
$ pgbench -n -S -c64 -j64 => tps = 26701.877815
Is it acceptable to use pthread in contrib module?
If ok, I will add the patch to the next commitfest.
Tom Lane [Sun, 2 Aug 2009 22:14:53 +0000 (22:14 +0000)]
Add ALTER TABLE ... ALTER COLUMN ... SET STATISTICS DISTINCT
Robert Haas
Tom Lane [Sat, 1 Aug 2009 20:59:17 +0000 (20:59 +0000)]
Department of second thoughts: let's show the exact key during unique index
build failures, too. Refactor a bit more since that error message isn't
spelled the same.
Tom Lane [Sat, 1 Aug 2009 19:59:41 +0000 (19:59 +0000)]
Improve unique-constraint-violation error messages to include the exact
values being complained of.
In passing, also remove the arbitrary length limitation in the similar
error detail message for foreign key violations.
Itagaki Takahiro
Tom Lane [Fri, 31 Jul 2009 20:26:23 +0000 (20:26 +0000)]
Create a multiplexing structure for signals to Postgres child processes.
This patch gets us out from under the Unix limitation of two user-defined
signal types. We already had done something similar for signals directed to
the postmaster process; this adds multiplexing for signals directed to
backends and auxiliary processes (so long as they're connected to shared
memory).
As proof of concept, replace the former usage of SIGUSR1 and SIGUSR2
for backends with use of the multiplexing mechanism. There are still some
hard-wired definitions of SIGUSR1 and SIGUSR2 for other process types,
but getting rid of those doesn't seem interesting at the moment.
Fujii Masao
Magnus Hagander [Thu, 30 Jul 2009 09:28:00 +0000 (09:28 +0000)]
Make sure FD_SETSIZE is set before we include any Windows
header files.
Josh Williams
Tom Lane [Thu, 30 Jul 2009 02:45:38 +0000 (02:45 +0000)]
Merge the Constraint and FkConstraint node types into a single type.
This was foreseen to be a good idea long ago, but nobody had got round
to doing it. The recent patch for deferred unique constraints made
transformConstraintAttrs() ugly enough that I decided it was time.
This change will also greatly simplify parsing of deferred CHECK constraints,
if anyone ever gets around to implementing that.
While at it, add a location field to Constraint, and use that to provide
an error cursor for some of the constraint-related error messages.
Tom Lane [Wed, 29 Jul 2009 22:19:18 +0000 (22:19 +0000)]
Fix time_part and timetz_part (ie, EXTRACT() for those datatypes) to
include a fractional part in the output for MILLISECOND and SECOND cases,
rather than truncating the source value. This is what the float-timestamp
code has always done, and it was clearly the code author's intent to do
the same for integer timestamps, but he forgot about integer division in C.
The other datatypes supported by EXTRACT() already do this correctly.
Backpatch to 8.4, so that the default (integer) behavior of that branch will
match the default (float) behavior of older branches. Arguably we should
patch further back, but it's possible that applications are expecting the
broken behavior in older branches. 8.4 is new enough that expectations
shouldn't be too settled.
Per report from Greg Stark.
Tom Lane [Wed, 29 Jul 2009 20:56:21 +0000 (20:56 +0000)]
Support deferrable uniqueness constraints.
The current implementation fires an AFTER ROW trigger for each tuple that
looks like it might be non-unique according to the index contents at the
time of insertion. This works well as long as there aren't many conflicts,
but won't scale to massive unique-key reassignments. Improving that case
is a TODO item.
Dean Rasheed
Tom Lane [Wed, 29 Jul 2009 15:57:11 +0000 (15:57 +0000)]
Fix a thinko introduced into CountActiveBackends by a recent patch:
we should ignore NULL array entries, not non-NULL ones. This had the
effect of disabling commit_delay, and could have caused a crash in the
rare race condition the patch was intended to fix.
Bug report and diagnosis by Jeff Janes, in bug #4952.
Teodor Sigaev [Tue, 28 Jul 2009 09:48:00 +0000 (09:48 +0000)]
Correct calculations of overlap and contains operations over polygons.
Teodor Sigaev [Tue, 28 Jul 2009 09:31:55 +0000 (09:31 +0000)]
Fix incorrect cleanup of tsquery in ts_rewrite(). Per bug #4933 by
Aaron Marcuse-Kubitza <aaronmk@blackducksoftware.com>
Tom Lane [Tue, 28 Jul 2009 02:56:31 +0000 (02:56 +0000)]
Add system catalog columns pg_constraint.conindid and pg_trigger.tgconstrindid.
conindid is the index supporting a constraint. We can use this not only for
unique/primary-key constraints, but also foreign-key constraints, which
depend on the unique index that constrains the referenced columns.
tgconstrindid is just copied from the constraint's conindid field, or is
zero for triggers not associated with constraints.
This is mainly intended as infrastructure for upcoming patches, but it has
some virtue in itself, since it exposes a relationship that you formerly
had to grovel in pg_depend to determine. I simplified one information_schema
view accordingly. (There is a pg_dump query that could also use conindid,
but I left it alone because it wasn't clear it'd get any faster.)
Magnus Hagander [Mon, 27 Jul 2009 08:46:10 +0000 (08:46 +0000)]
Fix minor memory leak in Win32 SID handling functions. Not a big issue
since it's only called during process startup, thus no backpatch.
Found by TAKATSUKA Haruka, patch by Magnus Hagander and
Andrew Chernow
Magnus Hagander [Mon, 27 Jul 2009 07:11:15 +0000 (07:11 +0000)]
Enable the use of multiple CPUs/cores when building on MSVC. This only
affects the C compiler step - we still only build one target at a
time.
Tom Lane [Mon, 27 Jul 2009 05:31:05 +0000 (05:31 +0000)]
Add s_lock support for SuperH architecture.
After a patch originally submitted by Nobuhiro Iwamatsu, but corrected
(I think) to match our guidelines for safe use of asm fragments.
This should be considered untested ...
Tom Lane [Mon, 27 Jul 2009 04:09:55 +0000 (04:09 +0000)]
Improve comment, per gripe from Alvaro.
Tom Lane [Mon, 27 Jul 2009 03:34:40 +0000 (03:34 +0000)]
Fix pg_stat_statements for EXEC_BACKEND case.
We should not try to load old statistics when re-attaching to existing
shared memory. Per bug #4941.
Itagaki Takahiro
Tom Lane [Mon, 27 Jul 2009 00:26:03 +0000 (00:26 +0000)]
Experiment with using EXPLAIN COSTS OFF in regression tests.
This is a simple test to see whether COSTS OFF will help much with getting
EXPLAIN output that's sufficiently platform-independent for use in the
regression tests. The planner does have some freedom of choice in these
examples (plain via bitmap indexscan), so I'm not sure what will happen.
Tom Lane [Sun, 26 Jul 2009 23:34:18 +0000 (23:34 +0000)]
Extend EXPLAIN to allow generic options to be specified.
The original syntax made it difficult to add options without making them
into reserved words. This change parenthesizes the options to avoid that
problem, and makes provision for an explicit (and perhaps non-Boolean)
value for each option. The original syntax is still supported, but only
for the two original options ANALYZE and VERBOSE.
As a test case, add a COSTS option that can suppress the planner cost
estimates. This may be useful for including EXPLAIN output in the regression
tests, which are otherwise unable to cope with cross-platform variations in
cost estimates.
Robert Haas
Tom Lane [Sat, 25 Jul 2009 17:04:19 +0000 (17:04 +0000)]
Code review for FORCE QUOTE * patch: fix error checking to consider FORCE
QUOTE * as a variety of FORCE QUOTE, and update psql documentation to include
the option. (The actual psql code doesn't seem to need any changes.)
Andrew Dunstan [Sat, 25 Jul 2009 13:35:32 +0000 (13:35 +0000)]
Small stylistic improvement in recent FORCE QUOTE * code - use a bool instead of a magic value.
Andrew Dunstan [Sat, 25 Jul 2009 00:07:14 +0000 (00:07 +0000)]
Allow * as parameter for FORCE QUOTE for COPY CSV. Itagaki Takahiro.
Tom Lane [Fri, 24 Jul 2009 21:08:42 +0000 (21:08 +0000)]
Assorted minor refactoring in EXPLAIN.
This is believed to not change the output at all, with one known exception:
"Subquery Scan foo" becomes "Subquery Scan on foo". (We can fix that if
anyone complains, but it would be a wart, because the old code was clearly
inconsistent.) The main intention is to remove duplicate coding and
provide a cleaner base for subsequent EXPLAIN patching.
Robert Haas
Magnus Hagander [Fri, 24 Jul 2009 20:12:42 +0000 (20:12 +0000)]
Reserve the shared memory region during backend startup on Windows, so
that memory allocated by starting third party DLLs doesn't end up
conflicting with it.
Hopefully this solves the long-time issue with "could not reattach
to shared memory" errors on Win32.
Patch from Tsutomu Yamada and me, based on idea from Trevor Talbot.
Peter Eisentraut [Fri, 24 Jul 2009 19:35:44 +0000 (19:35 +0000)]
Document \dg+ and \du+
The fact that \dg and \du take the + option was missing in the documentation.
backpatched to 8.4
Author: Andreas Wenk <a.wenk@netzmeister-st-pauli.de>
Tom Lane [Fri, 24 Jul 2009 17:58:31 +0000 (17:58 +0000)]
Avoid extra system calls to block SIGPIPE if the platform provides either
sockopt(SO_NOSIGPIPE) or the MSG_NOSIGNAL flag to send().
We assume these features are available if (1) the symbol is defined at
compile time and (2) the kernel doesn't reject the call at runtime.
It might turn out that there are some platforms where (1) and (2) are
true and yet the signal isn't really blocked, in which case applications
would die on server crash. If that sort of thing gets reported, then
we'll have to add additional defenses of some kind.
Jeremy Kerr
Tom Lane [Fri, 24 Jul 2009 15:03:07 +0000 (15:03 +0000)]
Add commentary about Cygwin's broken erand48, per report from Andrew Dunstan.
Andrew Dunstan [Thu, 23 Jul 2009 23:50:29 +0000 (23:50 +0000)]
Force use of our erand48 on Cygwin
Tom Lane [Thu, 23 Jul 2009 22:59:40 +0000 (22:59 +0000)]
Teach pg_dump to dump comments attached to the columns of a composite type.
Taro Minowa (Higepon)
Tom Lane [Thu, 23 Jul 2009 21:27:10 +0000 (21:27 +0000)]
Save a few cycles in EXPLAIN and related commands by not bothering to form
a physical tuple in do_tup_output(). A virtual tuple is easier to set up
and also easier for most tuple receivers to process. Per my comment on
Robert Haas' recent patch in this code.
Tom Lane [Thu, 23 Jul 2009 20:45:27 +0000 (20:45 +0000)]
In a non-hashed Agg node, reset the "aggcontext" at group boundaries, instead
of individually pfree'ing pass-by-reference transition values. This should
be at least as fast as the prior coding, and it has the major advantage of
clearing out any working data an aggregate function may have stored in or
underneath the aggcontext. This avoids memory leakage when an aggregate
such as array_agg() is used in GROUP BY mode. Per report from Chris Spotts.
Back-patch to 8.4. In principle the problem could arise in prior versions,
but since they didn't have array_agg the issue seems not critical.
Tom Lane [Thu, 23 Jul 2009 17:42:06 +0000 (17:42 +0000)]
Fix another thinko in join_is_legal's handling of semijoins: we have to test
for the case that the semijoin was implemented within either input by
unique-ifying its RHS before we test to see if it appears to match the current
join situation. The previous coding would select semijoin logic in situations
where we'd already unique-ified the RHS and joined it to some unrelated
relation(s), and then came to join it to the semijoin's LHS. That still gave
the right answer as far as the semijoin itself was concerned, but would lead
to incorrectly examining only an arbitrary one of the matchable rows from the
unrelated relation(s). The cause of this thinko was incorrect unification of
the pre-8.4 logic for IN joins and OUTER joins --- the comparable case for
outer joins can be handled after making the match test, but that's because
there is nothing like the unique-ification escape hatch for outer joins.
Per bug #4934 from Benjamin Reed.
Andrew Dunstan [Thu, 23 Jul 2009 17:06:48 +0000 (17:06 +0000)]
Update location to download flex for building on Windows.
Peter Eisentraut [Wed, 22 Jul 2009 18:07:26 +0000 (18:07 +0000)]
Clarify NULLIF example
found by "Vesa-Matti J Kari" <vmkari@cc.helsinki.fi>
Tom Lane [Wed, 22 Jul 2009 17:00:23 +0000 (17:00 +0000)]
Change do_tup_output() to take Datum/isnull arrays instead of a char * array,
so it doesn't go through BuildTupleFromCStrings. This is more or less a
wash for current uses, but will avoid inefficiency for planned changes to
EXPLAIN.
Robert Haas
Magnus Hagander [Wed, 22 Jul 2009 11:07:02 +0000 (11:07 +0000)]
Fix mismatch in const:ness of parameters.
Joe Conway [Wed, 22 Jul 2009 02:31:38 +0000 (02:31 +0000)]
Replace PLpgSQL_dstring by StringInfo.
Replace redundant PLpgSQL_dstring functionality with StringInfo.
Patch by Pavel Stehule. Review by Joe Conway.
Tom Lane [Wed, 22 Jul 2009 01:21:22 +0000 (01:21 +0000)]
Tweak TOAST code so that columns marked with MAIN storage strategy are
not forced out-of-line unless that is necessary to make the row fit on a
page. Previously, they were forced out-of-line if needed to get the row
down to the default target size (1/4th page).
Kevin Grittner
Tom Lane [Tue, 21 Jul 2009 21:46:10 +0000 (21:46 +0000)]
Make pg_dump/pg_restore --clean options drop large objects too.
In passing, make invocations of lo_xxx functions a bit more schema-safe.
Itagaki Takahiro
Peter Eisentraut [Tue, 21 Jul 2009 20:24:51 +0000 (20:24 +0000)]
Change pg_listener attribute number constants to match the usual pattern
It appears that, for no particularly good reason, pg_listener.h deviates from
the usual convention for declaring attribute number constants. Normally, it's
#define Anum_{catalog-name}_{column-name} {attribute-number}
pg_listener.h, however substitutes a different string that is similar, but not
the same as, the column name. This change fixes that.
Author: Robert Haas <robertmhaas@gmail.com>
Tom Lane [Tue, 21 Jul 2009 19:53:12 +0000 (19:53 +0000)]
Speed up AllocSetFreeIndex, which is a significant cost in palloc and pfree,
by using a lookup table instead of a naive shift-and-count loop. Based on
code originally posted by Sean Eron Anderson at
http://graphics.stanford.edu/%7eseander/bithacks.html.
Greg Stark did the research and benchmarking to show that this is what
we should use. Jeremy Kerr first noticed that this is a hotspot that
could be optimized, though we ended up not using his suggestion of
platform-specific bit-searching code.
Peter Eisentraut [Tue, 21 Jul 2009 19:20:33 +0000 (19:20 +0000)]
Remove translated FAQs
The English FAQ has been moved to the wiki, so the translated versions should
have been removed at that point as well.
The FAQ_MINGW.html should have been removed when the platform FAQs were
integrated into the documentation (or earlier).
applied to both 8.4 and 8.5
Peter Eisentraut [Tue, 21 Jul 2009 19:07:24 +0000 (19:07 +0000)]
Add a further customization to the SGML Emacs mode to prevent the use of
tabs in the documentation source.
Tom Lane [Tue, 21 Jul 2009 02:02:44 +0000 (02:02 +0000)]
Fix another semijoin-ordering bug. We already knew that we couldn't
reorder a semijoin into or out of the righthand side of another semijoin,
but actually it doesn't work to reorder it into or out of the righthand
side of a left or antijoin, either. Per bug #4906 from Mathieu Fenniak.
This was sloppy thinking on my part. This identity does work:
( A left join B on (Pab) ) semijoin C on (Pac)
==
( A semijoin C on (Pac) ) left join B on (Pab)
but I failed to see that that doesn't mean this does:
( A left join B on (Pab) ) semijoin C on (Pbc)
!=
A left join ( B semijoin C on (Pbc) ) on (Pab)
Bruce Momjian [Mon, 20 Jul 2009 20:53:40 +0000 (20:53 +0000)]
Properly restore pg_largeobject.relfozenxid in binary upgrade mode.
Backpatch to 8.4.X.
Alvaro Herrera [Mon, 20 Jul 2009 20:38:55 +0000 (20:38 +0000)]
Install src/include/utils/fmgroids.h on VPATH builds too.
The original coding was not dealing specially with this file being a symlink,
with the end result that it was not installed in VPATH builds. Oddly enough,
the clean target does know about it ...
Peter Eisentraut [Mon, 20 Jul 2009 18:34:58 +0000 (18:34 +0000)]
Small additional clean from the rearrangement of the HTML index build rules
Peter Eisentraut [Mon, 20 Jul 2009 08:01:07 +0000 (08:01 +0000)]
Use errcontext mechanism in PL/Python
Error messages from PL/Python now always mention the function name in the
CONTEXT: field. This also obsoletes the few places that tried to do the
same manually.
Regression test files are updated to work with Python 2.4-2.6. I don't have
access to older versions right now.
Tom Lane [Mon, 20 Jul 2009 03:46:45 +0000 (03:46 +0000)]
Remove unnecessary and version-sensitive dependence on the exact set of
column names to be found in a sequence. Per gripe from Bruce.
Andrew Dunstan [Mon, 20 Jul 2009 02:42:28 +0000 (02:42 +0000)]
DROP IF EXISTS for columns and constraints. Andres Freund.