OSDN Git Service
Tom Lane [Sat, 28 May 2011 16:36:04 +0000 (12:36 -0400)]
Fix null-dereference crash in parse_xml_decl().
parse_xml_decl's header comment says you can pass NULL for any unwanted
output parameter, but it failed to honor this contract for the "standalone"
flag. The only currently-affected caller is xml_recv, so the net effect is
that sending a binary XML value containing a standalone parameter in its
xml declaration would crash the backend. Per bug #6044 from Christopher
Dillard.
In passing, remove useless initializations of parse_xml_decl's output
parameters in xml_parse.
Back-patch to 8.3, where this code was introduced.
Alvaro Herrera [Sat, 28 May 2011 01:49:22 +0000 (21:49 -0400)]
Remove unused variable
Cédric Villemain
Peter Eisentraut [Fri, 27 May 2011 22:01:42 +0000 (01:01 +0300)]
Remove literal tabs from message strings
Peter Eisentraut [Fri, 27 May 2011 21:25:33 +0000 (00:25 +0300)]
Drop "meaning" column from error code table
This is currently the same as the condition name, so it doesn't add
any value, only clutter.
Tom Lane [Fri, 27 May 2011 18:13:38 +0000 (14:13 -0400)]
Improve corner cases in pg_ctl's new wait-for-postmaster-startup code.
With "-w -t 0", we should report "still starting up", not "ok". If we
fall out of the loop without ever being able to call PQping (because we
were never able to construct a connection string), report "no response",
not "ok". This gets rid of corner cases in which we'd claim the server
had started even though it had not.
Also, if the postmaster.pid file is not there at any point after we've
waited 5 seconds, assume the postmaster has failed and report that, rather
than almost-certainly-fruitlessly continuing to wait. The pidfile should
appear almost instantly even when there is extensive startup work to do,
so 5 seconds is already a very conservative figure. This part is per a
gripe from MauMau --- there might be better ways to do it, but nothing
simple enough to get done for 9.1.
Tom Lane [Fri, 27 May 2011 16:10:32 +0000 (12:10 -0400)]
Preserve caller's memory context in ProcessCompletedNotifies().
This is necessary to avoid long-term memory leakage, because the main loop
in PostgresMain expects to be executing in MessageContext, and hence is a
bit sloppy about freeing stuff that is only needed for the duration of
processing the current client message. The known case of an actual leak
is when encoding conversion has to be done on the incoming command string,
but there might be others. Per report from Per-Olov Esgard.
Back-patch to 9.0, where the bug was introduced by the LISTEN/NOTIFY
rewrite.
Heikki Linnakangas [Fri, 27 May 2011 08:51:23 +0000 (11:51 +0300)]
Check the return code of pthread_create(). Otherwise we go into an infinite
loop if it fails, which is what what happened on my HP-UX box. (I think
the reason it failed on that box is a misconfiguration on my behalf, but
that's no reason to hang.)
Tom Lane [Thu, 26 May 2011 23:25:19 +0000 (19:25 -0400)]
Make decompilation of optimized CASE constructs more robust.
We had some hacks in ruleutils.c to cope with various odd transformations
that the optimizer could do on a CASE foo WHEN "CaseTestExpr = RHS" clause.
However, the fundamental impossibility of covering all cases was exposed
by Heikki, who pointed out that the "=" operator could get replaced by an
inlined SQL function, which could contain nearly anything at all. So give
up on the hacks and just print the expression as-is if we fail to recognize
it as "CaseTestExpr = RHS". (We must cover that case so that decompiled
rules print correctly; but we are not under any obligation to make EXPLAIN
output be 100% valid SQL in all cases, and already could not do so in some
other cases.) This approach requires that we have some printable
representation of the CaseTestExpr node type; I used "CASE_TEST_EXPR".
Back-patch to all supported branches, since the problem case fails in all.
Tom Lane [Thu, 26 May 2011 21:29:33 +0000 (17:29 -0400)]
Adjust configure to use "+Olibmerrno" with HP-UX C compiler, if possible.
This is reported to be necessary on some versions of that OS. In service
of this, cause PGAC_PROG_CC_CFLAGS_OPT to reject switches that result in
compiler warnings, since on yet other versions of that OS, the switch does
nothing except provoke a warning.
Report and patch by Ibrar Ahmed, further tweaking by me.
Tom Lane [Wed, 25 May 2011 20:26:45 +0000 (16:26 -0400)]
Suppress extensions in partial dumps.
We initially had pg_dump emit CREATE EXTENSION commands unconditionally.
However, pg_dump has long been in the habit of not dumping procedural
language definitions when a --schema or --table switch is given. It seems
appropriate to handle extensions the same way, since like PLs they are SQL
objects that are not in any particular schema. Per complaint from Adrian
Schreyer.
Peter Eisentraut [Wed, 25 May 2011 18:53:26 +0000 (21:53 +0300)]
Put options in some sensible order
For the --help output and reference pages of pg_dump, pg_dumpall,
pg_restore, put the options in some consistent, mostly alphabetical,
and consistent order, rather than newest option last or something like
that.
Andrew Dunstan [Wed, 25 May 2011 04:21:07 +0000 (00:21 -0400)]
Convert builddoc.bat into a perl script that actually works.
The old .bat file wasn't working for reasons that are unclear, and
which it did not seem worth the trouble to ascertain.
The new perl script has been tested and is known to work.
Soon it will be tested regularly on the buildfarm.
The .bat file is kept as a simple wrapper for the perl script.
Bruce Momjian [Wed, 25 May 2011 03:24:44 +0000 (23:24 -0400)]
Add C comment about why we don't spell out "month" in interval values.
Tom Lane [Tue, 24 May 2011 22:52:15 +0000 (18:52 -0400)]
Grammar cleanup for src/test/isolation/README
Josh Kupershmidt
Tom Lane [Tue, 24 May 2011 21:56:52 +0000 (17:56 -0400)]
Cleanup for pull-up-isReset patch.
Clear isReset before, not after, calling the context-specific alloc method,
so as to preserve the option to do a tail call in MemoryContextAlloc
(and also so this code isn't assuming that a failed alloc call won't have
changed the context's state before failing). Fix missed direct invocation
of reset method. Reformat a comment.
Bruce Momjian [Tue, 24 May 2011 19:59:00 +0000 (15:59 -0400)]
In pg_upgrade, do case-insensitive checks of locale, encoding, and ctype
because these are often inconsistently capitalized.
Tom Lane [Tue, 24 May 2011 19:49:56 +0000 (15:49 -0400)]
Adjust configure's probe for libselinux so it rejects too-old versions.
We need at least version 2.0.93, so probe for a function that was added
in that version.
Kaigai Kohei
Peter Eisentraut [Tue, 24 May 2011 18:28:30 +0000 (21:28 +0300)]
Add a "local" replication sample entry
Also adjust alignment a bit to distinguish commented out from comment.
Peter Eisentraut [Tue, 24 May 2011 18:25:28 +0000 (21:25 +0300)]
Message improvements
Tom Lane [Tue, 24 May 2011 18:20:08 +0000 (14:20 -0400)]
Avoid uninitialized bits in the result of QTN2QT().
Found with additional valgrind testing.
Noah Misch
Tom Lane [Mon, 23 May 2011 20:34:27 +0000 (16:34 -0400)]
Make plpgsql complain about conflicting IN and OUT parameter names.
The core CREATE FUNCTION code only enforces that IN parameter names are
non-duplicate, and that OUT parameter names are separately non-duplicate.
This is because some function languages might not have any confusion
between the two. But in plpgsql, such names are all in the same namespace,
so we'd better disallow it.
Per a recent complaint from Dan S. Not back-patching since this is a small
issue and the change could cause unexpected failures if we started to
enforce it in a minor release.
Heikki Linnakangas [Mon, 23 May 2011 19:18:19 +0000 (22:18 +0300)]
Fix integer overflow in text_format function, reported by Dean Rasheed.
In the passing, clarify the comment on why text_format_nv wrapper is needed.
Robert Haas [Mon, 23 May 2011 19:17:18 +0000 (15:17 -0400)]
Improve hash_array() logic for combining hash values.
The new logic is less vulnerable to transpositions.
This invalidates the contents of hash indexes built with the old
functions; hence, bump catversion.
Dean Rasheed
Peter Eisentraut [Mon, 23 May 2011 17:38:20 +0000 (20:38 +0300)]
Message style improvements
Tom Lane [Mon, 23 May 2011 16:52:46 +0000 (12:52 -0400)]
Install defenses against overflow in BuildTupleHashTable().
The planner can sometimes compute very large values for numGroups, and in
cases where we have no alternative to building a hashtable, such a value
will get fed directly to BuildTupleHashTable as its nbuckets parameter.
There were two ways in which that could go bad. First, BuildTupleHashTable
declared the parameter as "int" but most callers were passing "long"s,
so on 64-bit machines undetected overflow could occur leading to a bogus
negative value. The obvious fix for that is to change the parameter to
"long", which is what I've done in HEAD. In the back branches that seems a
bit risky, though, since third-party code might be calling this function.
So for them, just put in a kluge to treat negative inputs as INT_MAX.
Second, hash_create can go nuts with extremely large requested table sizes
(notably, my_log2 becomes an infinite loop for inputs larger than
LONG_MAX/2). What seems most appropriate to avoid that is to bound the
initial table size request to work_mem.
This fixes bug #6035 reported by Daniel Schreiber. Although the reported
case only occurs back to 8.4 since it involves WITH RECURSIVE, I think
it's a good idea to install the defenses in all supported branches.
Andrew Dunstan [Mon, 23 May 2011 01:51:18 +0000 (21:51 -0400)]
Remove spurious underscore in name of isolation tester on MSVC.
Andrew Dunstan [Sun, 22 May 2011 21:58:26 +0000 (17:58 -0400)]
Use the right pgsql for isolation tests.
Peter Eisentraut [Sun, 22 May 2011 19:21:37 +0000 (22:21 +0300)]
Put lists in sensible order
Tom Lane [Sun, 22 May 2011 19:13:35 +0000 (15:13 -0400)]
Make plpgsql provide the typmods for its variables to the main parser.
Historically we didn't do this, even though we had the information, because
plpgsql passed its Params via SPI APIs that only include type OIDs not
typmods. Now that plpgsql uses parser callbacks to create Params, it's
easy to insert the right typmod. This should generally result in lower
surprise factors, because a plpgsql variable that is declared with a typmod
will now work more like a table column with the same typmod. In particular
it's the "right" way to fix bug #6020, in which plpgsql's attempt to return
an anonymous record type is defeated by stricter record-type matching
checks that were added in 9.0. However, it's not impossible that this
could result in subtle behavioral changes that could break somebody's
existing plpgsql code, so I'm afraid to back-patch this change into
released branches. In those branches we'll have to lobotomize the
record-type checks instead.
Peter Eisentraut [Sun, 22 May 2011 17:04:07 +0000 (20:04 +0300)]
Message style improvements
Peter Eisentraut [Sun, 22 May 2011 12:13:17 +0000 (15:13 +0300)]
Put documentation of backslash commands back in alphabetical order
Peter Eisentraut [Sun, 22 May 2011 11:29:36 +0000 (14:29 +0300)]
Clarify the documentation of the --with-ossp-uuid option
Peter Eisentraut [Sat, 21 May 2011 21:36:14 +0000 (00:36 +0300)]
Message improvement
Heikki Linnakangas [Sat, 21 May 2011 18:47:19 +0000 (14:47 -0400)]
Pull up isReset flag from AllocSetContext to MemoryContext struct. This
avoids the overhead of one function call when calling MemoryContextReset(),
and it seems like the isReset optimization would be applicable to any new
memory context we might invent in the future anyway.
This buys back the overhead I just added in previous patch to always call
MemoryContextReset() in ExecScan, even when there's no quals or projections.
Heikki Linnakangas [Sat, 21 May 2011 18:30:11 +0000 (14:30 -0400)]
Reset per-tuple memory context between every row in a scan node, even when
there's no quals or projections. Currently this only matters for foreign
scans, as none of the other scan nodes litter the per-tuple memory context
when there's no quals or projections.
Heikki Linnakangas [Sat, 21 May 2011 12:18:00 +0000 (08:18 -0400)]
In binary-upgrade mode, dump dropped attributes of composite types.
Noah Misch
Peter Eisentraut [Fri, 20 May 2011 21:50:35 +0000 (00:50 +0300)]
Message style improvements
Peter Eisentraut [Thu, 19 May 2011 20:20:11 +0000 (23:20 +0300)]
Rename pg_dump --no-security-label to --no-security-labels
Other similar options also use the plural form.
Peter Eisentraut [Thu, 19 May 2011 19:56:53 +0000 (22:56 +0300)]
Fix untranslatable assembly of libpq connection failure message
Even though this only affects the insertion of a parenthesized word,
it's unwise to assume that parentheses can pass through untranslated.
And in any case, the new version is clearer in the code and for
translators.
Peter Eisentraut [Thu, 19 May 2011 19:14:56 +0000 (22:14 +0300)]
Update config.guess and config.sub
Peter Eisentraut [Thu, 19 May 2011 18:36:57 +0000 (21:36 +0300)]
Consistent spacing for lengthy error messages
Also, we removed the display of the current value of
max_connections/MaxBackends from some messages earlier, because it was
confusing, so do that in the remaining one as well.
Magnus Hagander [Thu, 19 May 2011 18:03:15 +0000 (14:03 -0400)]
Add example for replication in pg_hba.conf
Selena Deckelmann
Robert Haas [Thu, 19 May 2011 16:11:05 +0000 (12:11 -0400)]
Fix race condition in CheckTargetForConflictsIn.
Dan Ports
Alvaro Herrera [Thu, 19 May 2011 03:56:18 +0000 (23:56 -0400)]
Fix declaration of $_TD in "strict" trigger functions
This was broken in commit
ef19dc6d39dd2490ff61489da55d95d6941140bf by
the Bunce/Hunsaker/Dunstan team, which moved the declaration from
plperl_create_sub to plperl_call_perl_trigger_func. This doesn't
actually work because the validator code would not find the variable
declared; and even if you manage to get past the validator, it still
doesn't work because get_sv("_TD", GV_ADD) doesn't have the expected
effect. The only reason this got beyond testing is that it only fails
in strict mode.
We need to declare it as a global just like %_SHARED; it is simpler than
trying to actually do what the patch initially intended, and is said to
have the same performance benefit.
As a more serious issue, fix $_TD not being properly local()ized,
meaning nested trigger functions would clobber $_TD.
Alex Hunsaker, per test report from Greg Mullane
Heikki Linnakangas [Thu, 19 May 2011 02:30:24 +0000 (22:30 -0400)]
Replace strdup() with pstrdup(), to avoid leaking memory.
It's been like this since the seg module was introduced, so backpatch to
8.2 which is the oldest supported version.
Bruce Momjian [Thu, 19 May 2011 02:22:40 +0000 (22:22 -0400)]
In pg_upgrade, clean up handling of invalid directory specification by
checking the stat() errno value more strictly.
Bruce Momjian [Wed, 18 May 2011 22:36:52 +0000 (18:36 -0400)]
Improve pg_upgrade error reporting if the bin or data directories do not
exist or are not directories.
Peter Eisentraut [Wed, 18 May 2011 22:19:57 +0000 (01:19 +0300)]
Remove obsolete comment
Peter Eisentraut [Wed, 18 May 2011 22:14:45 +0000 (01:14 +0300)]
Spell checking and markup refinement
Peter Eisentraut [Wed, 18 May 2011 21:30:31 +0000 (00:30 +0300)]
/contrib/foo -> contrib/foo
Since contrib is a relative directory specification, a leading slash
is inappropriate.
Bruce Momjian [Wed, 18 May 2011 16:25:34 +0000 (12:25 -0400)]
Improve pg_upgrade X_OK comment.
Bruce Momjian [Wed, 18 May 2011 16:13:37 +0000 (12:13 -0400)]
Fix pg_upgrade build problem on Windows when using X_OK access
permission check on the current directory.
Tom Lane [Mon, 16 May 2011 20:41:52 +0000 (16:41 -0400)]
Fix pg_dump's handling of extension-member casts and languages.
pg_dump has some heuristic rules for whether to dump casts and procedural
languages, since it's not all that easy to distinguish built-in ones from
user-defined ones. However, we should not apply those rules to objects
that belong to an extension, but just use the perfectly well-defined rules
for what to do with extension member objects. Otherwise we might
mistakenly lose extension member objects during a binary upgrade (which is
the only time that we'd want to dump extension members).
Bruce Momjian [Mon, 16 May 2011 16:32:36 +0000 (12:32 -0400)]
Update pg_upgrade directory check error message.
Bruce Momjian [Mon, 16 May 2011 15:22:25 +0000 (11:22 -0400)]
Remove redundant privilege doc sentences.
Bruce Momjian [Mon, 16 May 2011 15:01:29 +0000 (11:01 -0400)]
Add pg_upgrade check to make sure the user has full access permission in
the current directory; if not, throw an error.
Bruce Momjian [Mon, 16 May 2011 14:46:52 +0000 (10:46 -0400)]
Allow pg_upgrade to honor libpq environment variables. Add 'local'
checks for PGHOST and PGHOSTADDR.
Andrew Dunstan [Mon, 16 May 2011 03:42:12 +0000 (23:42 -0400)]
Quote isolationtester command name so Windows will not think dot is the command.
Andrew Dunstan [Mon, 16 May 2011 03:12:36 +0000 (23:12 -0400)]
Add required psqldir setting for isolation checks.
Andrew Dunstan [Sun, 15 May 2011 22:45:26 +0000 (18:45 -0400)]
Fix bad macro call noticed by MSVC compiler.
Andrew Dunstan [Sun, 15 May 2011 22:03:19 +0000 (18:03 -0400)]
Add missing check function lookup.
Andrew Dunstan [Sun, 15 May 2011 21:55:05 +0000 (17:55 -0400)]
Build and run isolation test programs under MSVC.
Robert Haas [Fri, 13 May 2011 19:47:31 +0000 (15:47 -0400)]
More cleanup of FOREIGN TABLE permissions handling.
This commit fixes psql, pg_dump, and the information schema to be
consistent with the backend changes which I made as part of commit
be90032e0d1cf473bdd99aee94218218f59f29f1, and also includes a
related documentation tweak.
Shigeru Hanada, with slight adjustment.
Robert Haas [Thu, 12 May 2011 21:10:30 +0000 (17:10 -0400)]
Kill stray "not".
Tom Lane [Thu, 12 May 2011 15:56:38 +0000 (11:56 -0400)]
Fix write-past-buffer-end in ldapServiceLookup().
The code to assemble ldap_get_values_len's output into a single string
wrote the terminating null one byte past where it should. Fix that,
and make some other cosmetic adjustments to make the code a trifle more
readable and more in line with usual Postgres coding style.
Also, free the "result" string when done with it, to avoid a permanent
memory leak.
Bug report and patch by Albe Laurenz, cosmetic adjustments by me.
Alvaro Herrera [Wed, 2 Feb 2011 00:07:42 +0000 (19:07 -0500)]
Fix assorted typos
Tom Lane [Wed, 11 May 2011 23:57:38 +0000 (19:57 -0400)]
Split PGC_S_DEFAULT into two values, for true boot_val vs computed default.
Failure to distinguish these cases is the real cause behind the recent
reports of Windows builds crashing on 'infinity'::timestamp, which was
directly due to failure to establish a value of timezone_abbreviations
in postmaster child processes. The postmaster had the desired value,
but write_one_nondefault_variable() didn't transmit it to backends.
To fix that, invent a new value PGC_S_DYNAMIC_DEFAULT, and be sure to use
that or PGC_S_ENV_VAR (as appropriate) for "default" settings that are
computed during initialization. (We need both because there's at least
one variable that could receive a value from either source.)
This commit also fixes ProcessConfigFile's failure to restore the correct
default value for certain GUC variables if they are set in postgresql.conf
and then removed/commented out of the file. We have to recompute and
reinstall the value for any GUC variable that could have received a value
from PGC_S_DYNAMIC_DEFAULT or PGC_S_ENV_VAR sources, and there were a
number of oversights. (That whole thing is a crock that needs to be
redesigned, but not today.)
However, I intentionally didn't make it work "exactly right" for the cases
of timezone and log_timezone. The exactly right behavior would involve
running select_default_timezone, which we'd have to do independently in
each postgres process, causing the whole database to become entirely
unresponsive for as much as several seconds. That didn't seem like a good
idea, especially since the variable's removal from postgresql.conf might be
just an accidental edit. Instead the behavior is to adopt the previously
active setting as if it were default.
Note that this patch creates an ABI break for extensions that use any of
the PGC_S_XXX constants; they'll need to be recompiled.
Tom Lane [Wed, 11 May 2011 18:43:01 +0000 (14:43 -0400)]
Clean up parsing of CREATE TRIGGER's argument list.
Use ColLabel in place of ColId, so that reserved words are accepted as if
they were not reserved. Also, remove BCONST and XCONST, which were never
documented as allowed. Allowing those exposes to users an implementation
detail, namely the format in which the lexer outputs such constants, that
seems unwise to expose.
No documentation change needed, since this just makes the code act more
like you'd expect from reading the CREATE TRIGGER man page.
Per complaint from Szymon Guz and subsequent discussion.
Heikki Linnakangas [Wed, 11 May 2011 09:46:08 +0000 (12:46 +0300)]
Shut down WAL receiver if it's still running at end of recovery. We used to
just check that it's not running and PANIC if it was, but that can rightfully
happen if recovery stops at recovery target.
Tom Lane [Wed, 11 May 2011 03:44:33 +0000 (23:44 -0400)]
Be more explicit about the meaning of the change in standard_conforming_strings.
Bruce Momjian [Wed, 11 May 2011 00:56:44 +0000 (20:56 -0400)]
Mention "backslash" escape processing change in 9.1 release notes.
Tom Lane [Wed, 11 May 2011 00:36:22 +0000 (20:36 -0400)]
Prevent datebsearch() from crashing on base == NULL && nel == 0.
Normally nel == 0 works okay because the initial value of "last" will be
less than "base"; but if "base" is zero then the calculation wraps around
and we have a very large (unsigned) value for "last", so that the loop can
be entered and we get a SIGSEGV on a bogus pointer.
This is certainly the proximate cause of the recent reports of Windows
builds crashing on 'infinity'::timestamp --- evidently, they're either not
setting an active timezonetktbl, or setting an empty one. It's not yet
clear to me why it's only happening on Windows and not happening on any
buildfarm member. But even if that's due to some bug elsewhere, it seems
wise for this function to not choke on the powerup values of
timezonetktbl/sztimezonetktbl.
I also changed the copy of this code in ecpglib, although I am not sure
whether it's exposed to a similar hazard.
Per report and stack trace from Richard Broersma.
Bruce Momjian [Tue, 10 May 2011 23:44:15 +0000 (19:44 -0400)]
For create/dropdb, only connect once to the server since we now have a
shared description table for pg_database comments.
Also update comments about database name selection.
Peter Eisentraut [Tue, 10 May 2011 19:37:50 +0000 (22:37 +0300)]
Add some punctuation
Peter Eisentraut [Tue, 10 May 2011 19:37:22 +0000 (22:37 +0300)]
Put options in more alphabetical order
Peter Eisentraut [Tue, 10 May 2011 18:48:07 +0000 (21:48 +0300)]
Put options help in alphabetical order
Peter Eisentraut [Tue, 10 May 2011 18:40:29 +0000 (21:40 +0300)]
Format pg_upgrade --version in line with conventions
Peter Eisentraut [Tue, 10 May 2011 18:37:55 +0000 (21:37 +0300)]
Add bug report line to pg_upgrade --help output
Peter Eisentraut [Tue, 10 May 2011 18:34:26 +0000 (21:34 +0300)]
Put pg_test_fsync --help and --version output in line with conventions
Foremost, it should go to stdout.
Tom Lane [Tue, 10 May 2011 17:48:40 +0000 (13:48 -0400)]
Adjust documentation with respect to "unknown" timezone setting.
The recent cleanup of GUC assign hooks got rid of the kludge of using
"unknown" as a magic value for timezone and log_timezone. But I forgot
to update the documentation to match, as noted by Martin Pitt.
Tom Lane [Tue, 10 May 2011 16:08:47 +0000 (12:08 -0400)]
Be more wary in initdb's creation of platform-dependent collations.
Discard any collation aliases that match the built-in pg_collation entries
(ie, "default", "C", "POSIX"). Such aliases would be refused by a CREATE
COLLATION command, but since initdb is injecting them via a simple INSERT,
it has to make the corresponding check for itself. Per Martin Pitt's
report of funny behavior in a machine that had a bogus "C.UTF-8" locale.
Also, use E'' syntax for the output of escape_quotes, as per its header
comment.
Bruce Momjian [Tue, 10 May 2011 14:42:43 +0000 (10:42 -0400)]
In pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', now
that we report the libpq connection failure string. Per suggestion from
Robert Haas.
Bruce Momjian [Tue, 10 May 2011 03:25:16 +0000 (23:25 -0400)]
Documentation cleanup for the possible values of the datatype 'boolean'.
Bruce Momjian [Tue, 10 May 2011 01:04:18 +0000 (21:04 -0400)]
Update documentation to state there is three-value logic, not
three-value boolean logic.
Backpatch to 9.0.X since we just got another bug report about this
today.
Tom Lane [Mon, 9 May 2011 15:00:30 +0000 (11:00 -0400)]
Remove "make check" target in src/test/isolation/Makefile.
This doesn't work as expected because the isolationtester program requires
libpq to already be installed. While it works when you've already installed
libpq, having to already have done "make install" defeats most of the point
of a check with a temp installation. And there are weird corner cases if
the dynamic linker picks up an old libpq.so from system library directories.
Remove the target (or more precisely, make it print a helpful message) so
people don't expect the case to work.
Bruce Momjian [Mon, 9 May 2011 12:55:36 +0000 (08:55 -0400)]
In pg_upgrade, add status message about superuser check.
Bruce Momjian [Mon, 9 May 2011 03:59:31 +0000 (23:59 -0400)]
Add C comment about the fact that the autovacuum limit can go backwards
by 3, but that is it OK.
Tom Lane [Sun, 8 May 2011 23:44:12 +0000 (19:44 -0400)]
Fix some portability issues in isolation regression test driver.
Remove random system #includes in favor of using postgres_fe.h. (The
alternative to that is letting this module grow its own configuration
testing ability...)
Also fix the "make clean" target to actually clean things up.
Per local testing.
Bruce Momjian [Sun, 8 May 2011 02:30:35 +0000 (22:30 -0400)]
Add C comment why client encoding can be set in pg_upgrade.
Bruce Momjian [Sun, 8 May 2011 02:29:20 +0000 (22:29 -0400)]
Add xreflabels to /contrib manuals so links appear correct. Also update
README.links to explain xref properly.
Bruce Momjian [Sat, 7 May 2011 18:31:00 +0000 (14:31 -0400)]
Add missing documention connecting word.
Bruce Momjian [Sat, 7 May 2011 16:17:21 +0000 (12:17 -0400)]
In pg_upgrade, report non-super-user username in error message.
Bruce Momjian [Sat, 7 May 2011 12:55:13 +0000 (08:55 -0400)]
Check that the pg_upgrade user specified is a super-user.
Also report the error message when the post-pg_ctl connection fails.
Per private bug report from EnterpriseDB.
Robert Haas [Sat, 7 May 2011 01:53:55 +0000 (21:53 -0400)]
Add comment about memory reordering to PredicateLockTupleRowVersionLink.
Dan Ports, per head-scratching from Simon Riggs and myself.
Bruce Momjian [Sat, 7 May 2011 01:47:12 +0000 (21:47 -0400)]
Adjust pg_upgrade FATAL error messages to have consistent newlines.
Also adjust some error message capitalization for consistency.
Robert Haas [Sat, 7 May 2011 01:18:18 +0000 (21:18 -0400)]
Fix typos in SECURITY LABEL documentation.
KaiGai Kohei
Peter Eisentraut [Fri, 6 May 2011 19:14:53 +0000 (22:14 +0300)]
Improve compiler string shown in version()
With some compilers such as Clang and ICC emulating GCC, using a
version string of the form "GCC $version" can be quite misleading.
Also, a great while ago, the version output from gcc --version started
including the string "gcc", so it is redundant to repeat that. In
order to support ancient GCC versions, we now prefix the result with
"GCC " only if the version output does not start with a letter.
Tom Lane [Fri, 6 May 2011 16:57:28 +0000 (12:57 -0400)]
Move RegisterPredicateLockingXid() call to a safer place.
The SSI patch inserted a call of RegisterPredicateLockingXid into
GetNewTransactionId, which was a bad idea on a couple of grounds. First,
it's not necessary to hold XidGenLock while manipulating that shared
memory, and doing so is bad because XidGenLock is a high-contention lock
that should be held for as short a time as possible. (Not to mention that
it adds an entirely unnecessary deadlock hazard, since we must take
SerializableXactHashLock as well.) Second, the specific place where it was
put was between extending CLOG and advancing nextXid, which could result in
unpleasant behavior in case of a failure there. Pull the call out to
AssignTransactionId, which is much safer and arguably better from a
modularity standpoint too.
There is more work to do to clean up the failure-before-advancing-nextXid
issue, but that is a separate change that will need to be back-patched.
So for the moment I just want to make GetNewTransactionId look the same as
it did in prior versions.
Tom Lane [Fri, 6 May 2011 00:38:52 +0000 (20:38 -0400)]
Remove precedence labeling of keywords TRUE, FALSE, UNKNOWN, and ZONE.
These were labeled with precedences just to avoid attaching explicit
precedences to the productions in which they were the last terminal symbol.
Since a terminal symbol precedence marking can affect many other things
too, it seems like better practice to attach precedence labels to the
productions, and not mark the terminal symbols.
Ideally we'd also remove the precedence attached to NULL_P, but it turns
out that we are actually depending on that having a precedence higher than
POSTFIXOP, else we get a shift/reduce conflict for postfix operators in
b_expr. (Which more or less proves my point about these markings having a
high risk of unexpected consequences.) For the moment, move NULL_P into
the set of keywords grouped with IDENT, so that at least it will act
similarly to non-keywords; and document the interaction.
Magnus Hagander [Thu, 5 May 2011 21:00:31 +0000 (23:00 +0200)]
Unbreak the regression tests from my previous commit