OSDN Git Service
Sunny Goyal [Wed, 6 Jan 2016 23:30:53 +0000 (15:30 -0800)]
Removing lib proto util
Change-Id: Iebe6341a60a5e62bde97b5cca68f8abb93b04d36
Sunny Goyal [Wed, 6 Jan 2016 23:09:22 +0000 (15:09 -0800)]
Fixing syntax error
Change-Id: I8fbcd34d891b1d020436e9aa430fd26372910a63
Hyunyoung Song [Wed, 6 Jan 2016 23:04:46 +0000 (23:04 +0000)]
[DO NOT MERGE] Revert "Fix broken make target launcher_protoutil_lib Bug:
26406415"
am:
8363faf9a8 -s ours
* commit '
8363faf9a885933aca2ced9bb1c6f9aa4a43c9f7':
[DO NOT MERGE] Revert "Fix broken make target launcher_protoutil_lib Bug:
26406415"
Sunny Goyal [Wed, 6 Jan 2016 22:51:43 +0000 (22:51 +0000)]
Merge "Adding support for negative x and y in layout xml. Fixing default configurations for some screen sizes." into ub-launcher3-burnaby-polish
Hyunyoung Song [Wed, 6 Jan 2016 22:39:56 +0000 (22:39 +0000)]
[DO NOT MERGE] Revert "Fix broken make target launcher_protoutil_lib Bug:
26406415"
In branch ub-launcher3-burnaby,
libprotobuf-java-2.3.0-nano can be linked, because the protobuf project is tracking lmp tree
In branch ub-launcher3-burnaby-polish,
libprotobuf-java-nano can be linked, because the
protobuf project is tracking master tree.
Hence the original CL should be reverted in ub-launcher3-burnaby tree but should not be merged automatically
to downstream trees.
This reverts commit
4ae00b1b8e853f45770c833085179eb382220d78.
Change-Id: I137756b79e2c12d36408073bdd6cddc773a4f168
Sunny Goyal [Wed, 6 Jan 2016 22:47:13 +0000 (14:47 -0800)]
Adding a .nano prefix in the proto package name
Change-Id: Ia513089f813567953ca146538f79d21ca5fd8ddf
Hyunyoung Song [Wed, 6 Jan 2016 21:20:56 +0000 (21:20 +0000)]
Fix broken make target launcher_protoutil_lib Bug:
26406415
am:
4ae00b1b8e
* commit '
4ae00b1b8e853f45770c833085179eb382220d78':
Fix broken make target launcher_protoutil_lib Bug:
26406415
Hyunyoung Song [Wed, 6 Jan 2016 21:12:45 +0000 (13:12 -0800)]
Fix broken make target launcher_protoutil_lib
Bug:
26406415
Change-Id: If3895b384feb9f2a6294fd76c043420851a37f49
Ying Wang [Mon, 4 Jan 2016 20:19:01 +0000 (12:19 -0800)]
Remove unnecessary use of ../.
Change-Id: Ie747c305cbf1a6bf42f6c04c5c4d5ec3c6dad990
Sunny Goyal [Wed, 16 Dec 2015 19:32:54 +0000 (11:32 -0800)]
Adding support for negative x and y in layout xml.
Fixing default configurations for some screen sizes.
> Negative values for x and y are parsed as distance from end
column and row respectively. e.g. (-1, -2) => (3, 2) in a
4x4 grid
Bug:
26110981
Change-Id: I4ca30e225ed6e2a31610ab23235d2cd10e8d317c
Sunny Goyal [Fri, 18 Dec 2015 22:38:52 +0000 (22:38 +0000)]
Merge "Using SharedPrefenrece.apply instead of commit to prevent disk IO on main thread" into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 18 Dec 2015 22:29:47 +0000 (22:29 +0000)]
Merge "Preventing launcher crashes due to low disk space." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 18 Dec 2015 21:13:48 +0000 (13:13 -0800)]
Fix item count check in Folder#replaceFolderWithFinalItem()
Instead of checking the item count (number of views), check the number
of items in the model, since that is where the item is being removed.
This way, mInfo.contents.remove(0) will never be out of bounds.
Bug:
25666490
Change-Id: I0eb880b366157bddb5a8c342d538737722b7f0cd
Sunny Goyal [Fri, 18 Dec 2015 07:22:42 +0000 (23:22 -0800)]
Fixing some invalid checks and cleaning some redundant conditions
Change-Id: I770ce2cc2eccbee105958634e81bbc9bc2e4cc48
Sunny Goyal [Fri, 18 Dec 2015 01:09:36 +0000 (17:09 -0800)]
Preventing launcher crashes due to low disk space.
In case of low disk space, all write operations to the IconCache are
silently ignored. This will not affect the Launcher behavior and
user will still see the latest icons, but in some cases, icon loading
would appear slow
Bug:
24585352
Change-Id: I85ccc519046fc3708403388bba89e019a3f2ce3d
Sunny Goyal [Fri, 18 Dec 2015 06:23:02 +0000 (22:23 -0800)]
Using SharedPrefenrece.apply instead of commit to prevent disk IO on main thread
Bug:
25903149
Change-Id: Ib1ee3fd27cca14f147f704aec768a330c4f03b33
Sunny Goyal [Thu, 17 Dec 2015 19:24:31 +0000 (11:24 -0800)]
Protecting Icon normalization behind a feature flag
Change-Id: I91b7126765049372a3ffec3ad6f661715dc83bab
Sunny Goyal [Wed, 16 Dec 2015 01:12:22 +0000 (17:12 -0800)]
Reverting the cache version change, so that users on release version do not get the cache reset
Change-Id: I61b06ca001e6ae47693e8d6f467565314d66f1b4
Sunny Goyal [Fri, 11 Dec 2015 17:50:49 +0000 (09:50 -0800)]
Restarting launcher when on font scale change
Chaning the font scale affects the static device profile and may
affect various background threads and static constants. Killing
the process ensures that these states get invalidated properly.
Bug:
26131935
Change-Id: Idc262ee5d158019e7a2505f8fb9a6413c06bfdeb
Sunny Goyal [Fri, 11 Dec 2015 01:49:02 +0000 (01:49 +0000)]
Merge "Fixing All apps not respecting scaled icon size" into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 11 Dec 2015 01:37:56 +0000 (01:37 +0000)]
Merge "Clearing DB instead of deleting the DB file." into ub-launcher3-burnaby-polish
Sunny Goyal [Thu, 10 Dec 2015 20:28:21 +0000 (12:28 -0800)]
Fixing All apps not respecting scaled icon size
Change-Id: I3d05c713939fd69d04f5896cdc5db91480b0d4d1
Sunny Goyal [Tue, 8 Dec 2015 21:43:10 +0000 (21:43 +0000)]
Merge "Verifying the install shortcut intent before casting the extras to various object types" into ub-launcher3-burnaby-polish
Sunny Goyal [Tue, 8 Dec 2015 17:28:23 +0000 (09:28 -0800)]
Recreating QSB when the widget host gets reset
Bug:
25073414
Change-Id: Ibdaa2b330ef7989cb7c93d64a05c8f6e5b26594a
Tony Wickham [Tue, 8 Dec 2015 02:36:54 +0000 (02:36 +0000)]
Merge "Added an instrumentation test case for quickly adding a widget." into ub-launcher3-burnaby-polish
Sunny Goyal [Tue, 8 Dec 2015 01:44:40 +0000 (01:44 +0000)]
Merge "Adding FeatureFlags.java file to aggregate various feature definitions" into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 7 Dec 2015 23:00:24 +0000 (15:00 -0800)]
Adding FeatureFlags.java file to aggregate various feature definitions
Change-Id: I52d04ab979329d1afd42fd74ec0a533dd819fd23
Sunny Goyal [Mon, 7 Dec 2015 22:51:23 +0000 (14:51 -0800)]
Verifying the install shortcut intent before casting the extras to various object types
Bug:
26043109
Change-Id: I95f127d62a6a508a850e11d6728afc7509fb07d1
Tony Wickham [Fri, 4 Dec 2015 22:14:36 +0000 (22:14 +0000)]
Merge "Add appropriate (tiny) offset to widget drops so they land correctly." into ub-launcher3-burnaby-polish
Tony [Sun, 18 Oct 2015 22:01:32 +0000 (15:01 -0700)]
Added an instrumentation test case for quickly adding a widget.
This would have caught the race condition bugs that caused the "specified child
already has a parent" IllegalStateException (bug
23896857).
Change-Id: I3b408d21113237b0c89a0a7161f504596212bd58
Tony Wickham [Fri, 4 Dec 2015 18:30:09 +0000 (18:30 +0000)]
Merge "Increase spacing between icons in All Apps on tablets." into ub-launcher3-burnaby-polish
Sunny Goyal [Fri, 4 Dec 2015 17:56:04 +0000 (17:56 +0000)]
Merge "Normalizing app icons based on the standard icon guidelines" into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 4 Dec 2015 17:55:33 +0000 (17:55 +0000)]
Merge "Cleanup keyboard code." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 4 Dec 2015 17:48:17 +0000 (09:48 -0800)]
Cleanup keyboard code.
This should be the last keyboard CL.
- Fix bug: couldn't focus All Apps button in some cases when the All
Apps column was skipped over. Also added test case for this.
- Stop explicitly passing countX and countY to handleKeyEvent, as
these had to match the matrix dimensions anyways.
- Rename createSparseMatrix() - there were 3 methods of the same name,
but all had different purposes. This is confusing both from a
readability standpoint and also when looking at stack traces.
Change-Id: I08ba8411674fcea43a608856c114dee8dbd22398
Tony Wickham [Wed, 18 Nov 2015 18:56:35 +0000 (10:56 -0800)]
Hide the focus indicator view when going to a fullscreen page.
Bug:
25649853
Change-Id: I9f2f221020548b48d816924a1803a1a70d11c412
Tony Wickham [Sat, 14 Nov 2015 01:32:20 +0000 (17:32 -0800)]
Fullscreen pages (e.g. Now) are focusable via keyboard.
Change-Id: I962551651aeb9ac7b57bb51b195adc3140db30d8
Tony Wickham [Wed, 11 Nov 2015 17:25:38 +0000 (09:25 -0800)]
Make sure pages are always accessible via left/right arrow keys.
- Handle NextPageFirstItem as first focusable item in reading order
- Handle PreviousPageLastItem as last focusable item in reading order
- Check the hotseat after the workspace in both cases above
- Dpad horizontal navigation (left/right) uses these as a last
resort (Rule3) to guarantee an item takes focus if a page exists
Note that it is necessary to search for a focusable item because
widgets are not yet focusable.
Bug:
25591057
Change-Id: I953648bd76c657d660a38427fdd4108bf9963c23
Tony Wickham [Thu, 3 Dec 2015 20:41:28 +0000 (20:41 +0000)]
Merge "Add special column for All Apps button in FocusLogic's sparse matrix." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 4 Nov 2015 02:05:01 +0000 (18:05 -0800)]
Add appropriate (tiny) offset to widget drops so they land correctly.
Also removed some unused parameters I found on the way.
Bug:
25191623
Change-Id: Ib9a30db106467c114cc8b54a5b13ed3e88162d56
Sunny Goyal [Thu, 17 Sep 2015 21:59:10 +0000 (14:59 -0700)]
Normalizing app icons based on the standard icon guidelines
Bug:
18245189
Change-Id: Iaadcddbe3f966733a13b2e1fb60ba09a8b3aef9a
Sunny Goyal [Thu, 3 Dec 2015 03:25:21 +0000 (03:25 +0000)]
Merge "Scaling down the icon before applying the user badge > This also saves memory only create one new bitmap while loading instead of two" into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 2 Dec 2015 23:11:09 +0000 (23:11 +0000)]
Merge "Disallow scrolling if workspace is in transition." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 2 Dec 2015 21:37:07 +0000 (13:37 -0800)]
Increase spacing between icons in All Apps on tablets.
Change-Id: If90332098f749295da07f4faca707a7a6965666b
Sunny Goyal [Tue, 1 Dec 2015 23:19:11 +0000 (23:19 +0000)]
Merge "Keeping the focus indicator on the widget view, while a child is focused" into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 23 Nov 2015 19:47:50 +0000 (11:47 -0800)]
Adding margin to Drag layer instead of checking for right insets at every place
Bug:
25692432
Change-Id: I853f41a17c54b30b7772b9fd8556d9465de84752
Sunny Goyal [Tue, 1 Dec 2015 21:21:49 +0000 (13:21 -0800)]
Keeping the focus indicator on the widget view, while a child is focused
Bug:
25199581
Change-Id: Ie08d1438ae0c1b5d4fcaa4d642508c1b9db0f5d4
Sunny Goyal [Mon, 30 Nov 2015 18:59:35 +0000 (10:59 -0800)]
Clearing DB instead of deleting the DB file.
> Deleting a file/reinitializing the openHelper variable is not thread safe
and can cause the sqlite instance ot go in an invalid state
Change-Id: I54d992c7e3daee82e6dad38d6bfbfcbf8ede506c
Sunny Goyal [Tue, 24 Nov 2015 18:16:37 +0000 (10:16 -0800)]
Only fetching firstInstallTime for an activity when required
Change-Id: Ia16c05718938849f4250802d8770ddfe6dbef055
Sunny Goyal [Mon, 19 Oct 2015 21:03:30 +0000 (14:03 -0700)]
Scaling down the icon before applying the user badge
> This also saves memory only create one new bitmap while loading instead of two
Bug:
25027252
Change-Id: Ia594dd65a30f32e99404190f649b334615c9e17f
Sunny Goyal [Wed, 25 Nov 2015 18:10:56 +0000 (18:10 +0000)]
Merge "Allowing widgets to be focusable" into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 25 Nov 2015 00:02:12 +0000 (00:02 +0000)]
Merge "Skip to the end of the folder open animation in battery saver mode." into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 24 Nov 2015 23:34:53 +0000 (15:34 -0800)]
Don't let folder be replaced with final item twice.
Bug:
25732317
Change-Id: I77b3ddc8951583bebfb908fda934c9b80ddebce0
Sunny Goyal [Tue, 24 Nov 2015 19:40:40 +0000 (11:40 -0800)]
Tying LauncherAppState lifecycle with LauncherProvider
The content provider is the first component started with the main process,
which makes it ideal for initiating LauncherAppState
Change-Id: I03db82a8949ad1376af53a0033592f421dbf0b15
Sunny Goyal [Mon, 23 Nov 2015 18:45:41 +0000 (18:45 +0000)]
Merge "Setting statusbar and nav bar colors in theme instead of code" into ub-launcher3-burnaby-polish
Tony Wickham [Mon, 23 Nov 2015 18:43:21 +0000 (18:43 +0000)]
Merge "Focus doesn't leave folders without also closing them." into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 17 Nov 2015 18:46:48 +0000 (10:46 -0800)]
Focus doesn't leave folders without also closing them.
- Pressing Tab wraps around to the first item from the folder name,
and vice versa when pressing Shift+Tab.
- When tapping off the folder while editing the text, the folder
requests focus. We handle the following cases from that state:
- Pressing an arrow key or Tab gives focus to the first item.
- Pressing Shift+Tab gives focus to the last item.
- Fix slight corner case where moving from folder name to an item
didn't update mIsEditingName to false. So when clicking off of
the folder, it gave focus to the folder (as mentioned above)
instead of closing the folder like it usually does when icons are
focused. Not a huge deal, but still worth fixing.
Bug:
25687579
Change-Id: I1bec844c8ccd09529a11b9e3a1d92b3bdf7b2eb3
Tony Wickham [Thu, 19 Nov 2015 20:45:30 +0000 (12:45 -0800)]
Disallow scrolling if workspace is in transition.
Because going to overview mode scales down the workspace, it was
thinking the touch was moving even though your finger was still. If
the "movement" was large enough, it was treated as a scroll, causing
jank. This was especially prevalent on tablets due to their size.
Bug:
25779718
Change-Id: Idb7833e0087bd24ca840f6afc451bf221f6bc047
Tony Wickham [Thu, 19 Nov 2015 00:36:20 +0000 (00:36 +0000)]
Merge "Stop requesting focus on folder if it was closed without animating." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 18 Nov 2015 19:51:55 +0000 (19:51 +0000)]
Merge "Handle errors gracefully in WallpaperCropActivity." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 4 Nov 2015 23:01:54 +0000 (15:01 -0800)]
Handle errors gracefully in WallpaperCropActivity.
(cherry picked from commit
c984cde00840d8594a8b203748cb6e4f9967fd7c)
Now instead of crashing, it says "Couldn't load image."
Bug:
25326319
Bug:
25656670
Change-Id: I71471f4b26f7c23dee40b60772ddd798f67b409e
Tony Wickham [Wed, 18 Nov 2015 01:59:26 +0000 (17:59 -0800)]
Stop requesting focus on folder if it was closed without animating.
Bug:
25092436
Change-Id: Ia6b72ec8c9fa02fc159457b81fef12f6fd394769
Sunny Goyal [Sat, 14 Nov 2015 12:39:20 +0000 (18:09 +0530)]
Fixing crash when uninstalling an app destroys the folder
Bug:
25666490
Bug:
25677822
Change-Id: Id71c04df0a5546ba95239ba2e3f7aabb697375a4
Tony Wickham [Fri, 13 Nov 2015 18:07:18 +0000 (18:07 +0000)]
Revert "Revert "Reverting folder cell width on portrait phones.""
This reverts commit
1974e98f5ec4713e50ba64ec32a7607c92ddce9b.
Change-Id: I7c5d86de187989c085f676933ce3f1cbd57ed8a7
Tony Wickham [Thu, 12 Nov 2015 23:46:33 +0000 (23:46 +0000)]
Revert "Reverting folder cell width on portrait phones."
This reverts commit
b25e684a766362422f5693f7a2189910c1275584.
Change-Id: Ie86adc4b35c73ab7ef78d73225b437adc4751172
Tony Wickham [Thu, 12 Nov 2015 21:12:06 +0000 (13:12 -0800)]
Reverting folder cell width on portrait phones.
The extra folder cell space added in ag/790800 looks bad on phones in
portrait mode, so reverting it here. However, we keep the extra space
on tablets or phones in landscape mode, since it provides more room
for long app names (bug
22462641).
Bug:
25662215
Change-Id: I2a37b884458ee557c9b8cff0c3edef16bfc50efb
Tony Wickham [Thu, 12 Nov 2015 20:31:50 +0000 (12:31 -0800)]
Skip to the end of the folder open animation in battery saver mode.
Bug:
25666809
Change-Id: I867d56a34fc5e0ad6aaabd8b6df47be05ec31966
Tony Wickham [Wed, 11 Nov 2015 17:16:14 +0000 (17:16 +0000)]
Merge "Handle more cases in FocusHelper#handleHotseatButtonKeyEvent()." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 11 Nov 2015 00:52:14 +0000 (16:52 -0800)]
Handle more cases in FocusHelper#handleHotseatButtonKeyEvent().
The first of these cases seems like they should already have been
present, and the last couple allow you to switch pages by hitting
arrow keys on the edges of the hotseat.
Bug:
25589939
Change-Id: I9378b209250f7dc376fa97efde979bcee2979537
Tony Wickham [Tue, 10 Nov 2015 22:44:32 +0000 (14:44 -0800)]
Don't add offset to CellLayout's fullscreen children.
Bug:
25411084
Change-Id: Ifbcd0a53cf04a7fc29386f4f09aaf7f972e7354a
Tony Wickham [Tue, 10 Nov 2015 01:51:08 +0000 (17:51 -0800)]
Add special column for All Apps button in FocusLogic's sparse matrix.
The All Apps button creates a number of edge cases, mainly because it
causes the hotseat to sometimes have an extra column than the workspace.
Previously, we sort of swept these problems under the rug by simply
ignoring the All Apps button if other icons were present in the hotseat,
with the assumption that those other icons should get focus instead of
the All Apps button. (If possible, we want to stay in the same column
when moving from the workspace to the hotseat.) But this doesn't always
work, as in the attached bug where the hotseat doesn't get focus at all
when the All Apps button is an obvious candidate for it.
By adding a specialized column in the focus matrix for the All Apps
button, we ensure that moving down to the hotseat stays within the
original column when possible, while also allowing the focus to switch
to the All Apps button if appropriate. Furthermore, we take care to skip
over the All Apps column when necessary in order to maintain all
previous functionality.
Bug:
25590522
Change-Id: I5d6a8ee69de8834314c4689246fe7d54329b2eef
Tony Wickham [Sat, 7 Nov 2015 01:08:57 +0000 (17:08 -0800)]
Added unit tests for b/
25434120 regression.
Change-Id: I55b10274c4bb63ec6fd3138236e78a04e3eac91a
Tony Wickham [Fri, 6 Nov 2015 18:10:05 +0000 (18:10 +0000)]
Merge "Make sure user can always get to next page with keyboard." into ub-launcher3-burnaby-polish
Tony Wickham [Fri, 6 Nov 2015 18:08:44 +0000 (18:08 +0000)]
Merge "Stop explicitly snapping to page when navigating with keyboard." into ub-launcher3-burnaby-polish
Tony Wickham [Thu, 5 Nov 2015 20:14:26 +0000 (12:14 -0800)]
Make sure user can always get to next page with keyboard.
There's a case where hitting the left/right arrow in the first/last
column wouldn't give focus to an icon on the next page because it is
vertically too far from the first icon to be considered. This makes
for a bad user experience, because there is no way to switch pages
with the keyboard. So now we brute-force search for an appropriate
icon if none was found in this case.
Bug:
25434120
Change-Id: Ifdead0e3b458717ccb33e2f0ec7c15f1fcce4b95
Sunny Goyal [Thu, 5 Nov 2015 10:39:57 +0000 (16:09 +0530)]
Ignoring DeadObjectException in startListening
> As of android M, the platform somtimes throws DeadObjectException
instead of TransactionTooLargeException
Bug:
25305031
Change-Id: I3a98db8a5041aef01640d16f9beb71b72bf598f1
Tony Wickham [Thu, 5 Nov 2015 01:44:32 +0000 (17:44 -0800)]
Stop explicitly snapping to page when navigating with keyboard.
When an icon grabs focus, it already snaps to its own page, so
the explicit snapToPage() is redundant. And in the case where no icon
will grab the focus, the explicit call puts us in a weird state
because the page snaps but the focus doesn't change (see bug).
(This happens, for instance, if you are moving from an icon on the
bottom right of page 1 and the only icon on page 2 is in the top
left. In this case, the second icon won't take focus because the
angle is too wide according to FocusLogic#handleDpadHorizontal().)
Bug:
25434120
Change-Id: I17b0ef7d86426a2599bc948bf2313dca7e112364
Tony Wickham [Sat, 31 Oct 2015 01:04:48 +0000 (18:04 -0700)]
Stop clearing focus when snapping to a new workspace page.
Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.
Bug:
25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
Sunny Goyal [Thu, 29 Oct 2015 06:28:21 +0000 (23:28 -0700)]
Allowing widgets to be focusable
> Pressing 'enter' enters the focus inside the widget.
> If the widget has only one focusable, it directly performs click
> Pressing 'esc' brings the focus back to the parent host.
Bug:
25199581
Change-Id: Ia7fd5d929f5945d61173abd349660a5efbe74afc
Tony Wickham [Fri, 30 Oct 2015 16:52:22 +0000 (09:52 -0700)]
Set parallax offset to be 0.5f for default wallpapers.
This ensures they are centered as they were without any offset.
Bug:
25347076
Change-Id: Id773cd89463d47b350e60878c00e1112e0244414
Tony Wickham [Fri, 23 Oct 2015 18:43:47 +0000 (11:43 -0700)]
Setting correct height for search bar widget options bundle.
- Seperate search bar height from its top and bottom paddings
- Report this height plus 8dps top and bottom for the widget options
- Use a separate bottom padding to adjust spacing between QSB and
the workspace
- Add tests to verify the height of the search bar in both normal and
tall modes (ran on Nexus 6, 7, and 10)
Change-Id: Ia7557785d1b38194eee869d0460456e8f33447d5
Winson Chung [Wed, 28 Oct 2015 22:35:00 +0000 (22:35 +0000)]
Merge "Disabling the desaturation of fast scroll items." into ub-launcher3-burnaby-polish
Winson [Wed, 28 Oct 2015 22:30:38 +0000 (15:30 -0700)]
Disabling the desaturation of fast scroll items.
Change-Id: I7e90e3b35dc6473ba5e2319abcea5c0c76cbd708
Sunny Goyal [Wed, 28 Oct 2015 21:29:14 +0000 (14:29 -0700)]
Setting statusbar and nav bar colors in theme instead of code
Change-Id: I4da50809d14f5fa4e47df47fcfd99df7b713950d
Tony Wickham [Tue, 27 Oct 2015 01:02:26 +0000 (01:02 +0000)]
Merge "Add null check in Launcher onNewIntent() before moveToDefaultScreen()." into ub-launcher3-burnaby-polish
Sunny Goyal [Mon, 26 Oct 2015 17:42:12 +0000 (10:42 -0700)]
Fixing null check when calling mutateOnMainThread
Bug:
25269169
Change-Id: I74f7fb833a374f59a16487099f1bf72b086e88ee
Tony [Mon, 26 Oct 2015 00:39:37 +0000 (17:39 -0700)]
Add null check in Launcher onNewIntent() before moveToDefaultScreen().
There is a race condition that occurs primarily (maybe entirely) with
Android Auto, it seems because they hijack the Home intent or something
similar. I'm not exactly sure how Android Auto works, but if I pair my
phone with the Desktop Head Unit (car dashboard emulator), I can repro
the NPE fairly easily by simply force closing Android Auto and then
disconnecting my phone from the DHU. If I don't force close Android
Auto, then pressing home launches Android Auto or other apps that I
assume handle some custom intent, such as Car Home Ultra, instead of
normal Home intents such as Launcher3/Google Now Launcher. So I think
what's happening is that, when the phone is disconnected from the car,
Android Auto restores and launches the real home intent (Launcher 3)
around the same time that it destroys the previous home intent
(Android Auto, Car Home Ultra, etc.). This could cause the NPE if both
intents are actually Launcher 3, as is the case when Android Auto is
already closed, because mWorkspace is set to null in
Launcher#onDestroy() (something like onNewIntent() --> post() called
--> onDestroy() --> post() runs). This is consistent with the fact
that I can guarantee a repro if I use postDelayed() instead of post().
Long-winded explanation aside, I think this fix is safe, especially
since we already have a null check for mWorkspace in onNewIntent(),
just not inside the post().
Bug:
24610231
Change-Id: I42f75b83946f375d947be1961a1f2a03a3707a84
Tony Wickham [Fri, 23 Oct 2015 18:38:46 +0000 (18:38 +0000)]
Merge "Set search bar height before setting up views in Launcher." into ub-launcher3-burnaby-polish
Tony Wickham [Thu, 22 Oct 2015 00:50:22 +0000 (17:50 -0700)]
Don't add cells to FocusLogic sparse matrix if they aren't focusable.
Previously, any child of ShortcutAndWidgetContainer was added to the
matrix, causing widgets (which aren't focusable) to be considered as
potential targets to gain focus when an arrow key was pressed. But if
the algorithm chose them, they couldn't take the focus so nothing
happened (i.e. the focus stayed on the app/folder it was on before).
Bug:
25126768
Change-Id: Id55fc310f7f58fb8795cce51dcefe4fd1210f788
Tony Wickham [Wed, 21 Oct 2015 21:21:14 +0000 (21:21 +0000)]
Merge "Hide the "Set Wallpaper" action bar when clicked." into ub-launcher3-burnaby-polish
Tony Wickham [Wed, 21 Oct 2015 20:56:59 +0000 (13:56 -0700)]
Hide the "Set Wallpaper" action bar when clicked.
This already happens everywhere except for the case where an external
app such as Photos started the wallpaper picker. So not only is this
more consistent, it also prevents crashes and other potential issues
caused by clicking "Set Wallpaper" too many times.
Bug:
25026717
Change-Id: I63c6a0ce68656e6e68094e88074a836d8c1034f9
Sunny Goyal [Tue, 13 Oct 2015 17:19:01 +0000 (10:19 -0700)]
Do not animate folder when it is closed while changing activity state
Bug:
21733536
Change-Id: I36aa3041b9300c917e320b511e00a1721e44f854
Tony Wickham [Tue, 20 Oct 2015 20:24:36 +0000 (13:24 -0700)]
Set search bar height before setting up views in Launcher.
This ensures that the QSB widget options are set correctly the first
time they are used.
Bug:
24704753
Change-Id: I2bb13ff012b6f13ca076deed61f0b08a7037e2fa
Geoff Mendal [Wed, 21 Oct 2015 15:54:05 +0000 (15:54 +0000)]
Import translations. DO NOT MERGE
am:
6ce85953ac -s ours
* commit '
6ce85953acf0399965c6c8a75f5e6eea5a643678':
Import translations. DO NOT MERGE
Geoff Mendal [Wed, 21 Oct 2015 15:03:43 +0000 (08:03 -0700)]
Import translations. DO NOT MERGE
Change-Id: I4f645e8f071559ad56ee7963934f1039b06d6e96
Auto-generated-cl: translation import
Geoff Mendal [Wed, 21 Oct 2015 15:02:37 +0000 (08:02 -0700)]
Import translations. DO NOT MERGE
Change-Id: I1cea6130293678ef0d5da961d11428f14e62ee25
Auto-generated-cl: translation import
Sunny Goyal [Wed, 21 Oct 2015 00:18:25 +0000 (00:18 +0000)]
Merge "Fixing disabled icon getting changed back to normal state on long press" into ub-launcher3-burnaby-polish
Tony Wickham [Tue, 20 Oct 2015 23:24:53 +0000 (16:24 -0700)]
Fix regression where keyboard couldn't switch between workspace pages.
Bug:
25122302
Change-Id: Id1d7628753ce7ef37af50e8594e541dcb6bea13e
Sunny Goyal [Tue, 20 Oct 2015 22:17:00 +0000 (15:17 -0700)]
Fixing disabled icon getting changed back to normal state on long press
Change-Id: I4f35c1cbecfef7891f8b1187ba3be0af695d4fd5
Sunny Goyal [Tue, 20 Oct 2015 18:05:22 +0000 (18:05 +0000)]
Fixing ConcurrentModificationException in tests
am:
ec7c9178dd
* commit '
ec7c9178dd1f17cf8479acd4e0b4575a91cfb255':
Fixing ConcurrentModificationException in tests
Sunny Goyal [Tue, 20 Oct 2015 17:31:09 +0000 (10:31 -0700)]
Fixing ConcurrentModificationException in tests
Change-Id: I7aabc62aa249dae979366ce2871604f5822f3139