OSDN Git Service

android-x86/kernel.git
14 years agoStaging: comedi: adl_pci9118.c: fix unsigned problem with divisors
Greg Kroah-Hartman [Tue, 4 May 2010 23:08:51 +0000 (16:08 -0700)]
Staging: comedi: adl_pci9118.c: fix unsigned problem with divisors

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: adv_pci1710.c: fix unsigned problem with divisors
Greg Kroah-Hartman [Tue, 4 May 2010 23:08:24 +0000 (16:08 -0700)]
Staging: comedi: adv_pci1710.c: fix unsigned problem with divisors

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: amplc_dio200.c: fix NULL sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:07:43 +0000 (16:07 -0700)]
Staging: comedi: amplc_dio200.c: fix NULL sparse warnings

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: cb_pcidas64.c: fix sparse warnings
Greg Kroah-Hartman [Tue, 4 May 2010 23:07:03 +0000 (16:07 -0700)]
Staging: comedi: cb_pcidas64.c: fix sparse warnings

This fixes a bunch of iomem and other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: das1800.c: fix a locking error on the error path.
Greg Kroah-Hartman [Tue, 4 May 2010 23:06:33 +0000 (16:06 -0700)]
Staging: comedi: das1800.c: fix a locking error on the error path.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: plx9080.h: properly mark iomem variables
Greg Kroah-Hartman [Tue, 4 May 2010 23:05:52 +0000 (16:05 -0700)]
Staging: comedi: plx9080.h: properly mark iomem variables

It's a __iomem *, so mark it as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: quatech_daqp_cs.c: fix up the irq
Greg Kroah-Hartman [Tue, 4 May 2010 23:05:09 +0000 (16:05 -0700)]
Staging: comedi: quatech_daqp_cs.c: fix up the irq

The irq needs to return the correct type.  Also fix up some other
sparse warnings that were found.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_amcc_s5933.h: sparse cleanup
Greg Kroah-Hartman [Tue, 4 May 2010 23:04:19 +0000 (16:04 -0700)]
Staging: comedi: addi_amcc_s5933.h: sparse cleanup

Mark a variable static that does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_common.c: sparse cleanups
Greg Kroah-Hartman [Tue, 4 May 2010 23:03:35 +0000 (16:03 -0700)]
Staging: comedi: addi_common.c: sparse cleanups

Now that we are properly marking the variable as __iomem, don't
cast it.

Also fix up some other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi_common.h: properly mark this variable as __iomem
Greg Kroah-Hartman [Tue, 4 May 2010 23:02:39 +0000 (16:02 -0700)]
Staging: comedi: addi_common.h: properly mark this variable as __iomem

It's not an unsigned long, it's a __iomem pointer, so mark it as
such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: usbduxfast.c: mark a function static
Greg Kroah-Hartman [Tue, 4 May 2010 23:02:00 +0000 (16:02 -0700)]
Staging: comedi: usbduxfast.c: mark a function static

It does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: 8255.c: mark some functions static
Greg Kroah-Hartman [Tue, 4 May 2010 23:01:19 +0000 (16:01 -0700)]
Staging: comedi: 8255.c: mark some functions static

sparse pointed out that these functions should be static, so mark them
as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: mark a variable as __user
Greg Kroah-Hartman [Tue, 4 May 2010 23:00:02 +0000 (16:00 -0700)]
Staging: comedi: mark a variable as __user

This is really a userspace pointer, so mark it as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: fix up sparse warning in hyperv_utils.c
Greg Kroah-Hartman [Tue, 4 May 2010 21:31:18 +0000 (14:31 -0700)]
Staging: hv: fix up sparse warning in hyperv_utils.c

The function isn't called by anyone else, so mark it static.

Also remove version.h, as it is not needed.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar and memrar updates
Alan Cox [Tue, 4 May 2010 19:40:12 +0000 (20:40 +0100)]
Staging: rar and memrar updates

rar: perform a clean up pass

- Move to a registration model where each RAR is claimed/unclaimed
- Use that to fix the client stuff (one client per RAR so no need to queue stuff)
- Support unregister so drivers can rmmod themselves safely
- Fix locking hang on calling rar lock from rar callback
- Clean up
- Kerneldoc

Folded in the memrar update as Greg asked

- Fix various unload related bugs
- Use the per RAR allocator/deallocator
- Add kerneldoc

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:imu ADIS16400 and ADIS16405 driver
Barry Song [Tue, 4 May 2010 13:43:15 +0000 (14:43 +0100)]
staging:iio:imu ADIS16400 and ADIS16405 driver

Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Barry Song <Barry.Song@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:imu ADIS16300 driver
Barry Song [Tue, 4 May 2010 13:43:14 +0000 (14:43 +0100)]
staging:iio:imu ADIS16300 driver

Signed-off-by: Barry Song <Barry.Song@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:Documentation: Rewrite example for new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:13 +0000 (14:43 +0100)]
staging:iio:Documentation: Rewrite example for new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:tsl2563 add a name attribute under the iio
Jonathan Cameron [Tue, 4 May 2010 13:43:12 +0000 (14:43 +0100)]
staging:iio:tsl2563 add a name attribute under the iio

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:ring_sw: Fix incorrect test on successful read of last value, causes...
Jonathan Cameron [Tue, 4 May 2010 13:43:11 +0000 (14:43 +0100)]
staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 add support for 8 bit equivalent devices, max1036-9, max11600-5
Jonathan Cameron [Tue, 4 May 2010 13:43:10 +0000 (14:43 +0100)]
staging:iio:max1363 add support for 8 bit equivalent devices, max1036-9, max11600-5

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 add support for max11606-max11617
Jonathan Cameron [Tue, 4 May 2010 13:43:09 +0000 (14:43 +0100)]
staging:iio:max1363 add support for max11606-max11617

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Remove naming via IDR's where no longer necessary under new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:08 +0000 (14:43 +0100)]
staging:iio: Remove naming via IDR's where no longer necessary under new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:tsl2563: change lux to illuminance0_input to match new abi
Jonathan Cameron [Tue, 4 May 2010 13:43:07 +0000 (14:43 +0100)]
staging:iio:tsl2563: change lux to illuminance0_input to match new abi

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Directory name changes to match new ABI.
Jonathan Cameron [Tue, 4 May 2010 13:43:06 +0000 (14:43 +0100)]
staging:iio: Directory name changes to match new ABI.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: ABI documentation (partial)
Jonathan Cameron [Tue, 4 May 2010 13:43:05 +0000 (14:43 +0100)]
staging:iio: ABI documentation (partial)

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Documentation, update iio_utils.h for the move to a bus
Jonathan Cameron [Tue, 4 May 2010 13:43:04 +0000 (14:43 +0100)]
staging:iio: Documentation, update iio_utils.h for the move to a bus

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio:max1363 move to new abi.
Jonathan Cameron [Tue, 4 May 2010 13:43:03 +0000 (14:43 +0100)]
staging:iio:max1363 move to new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Clean out unused IIO_SCAN_EL and add IIO_SCAN_NAMED_EL_C
Jonathan Cameron [Tue, 4 May 2010 13:43:02 +0000 (14:43 +0100)]
staging:iio: Clean out unused IIO_SCAN_EL and add IIO_SCAN_NAMED_EL_C

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Move event attributes into the event[n] device in sysfs
Jonathan Cameron [Tue, 4 May 2010 13:43:01 +0000 (14:43 +0100)]
staging:iio: Move event attributes into the event[n] device in sysfs

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: iio: Move from class to bus
Jonathan Cameron [Tue, 4 May 2010 13:43:00 +0000 (14:43 +0100)]
staging: iio: Move from class to bus

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Support functions for scan mask matching
Jonathan Cameron [Tue, 4 May 2010 13:42:59 +0000 (14:42 +0100)]
staging:iio: Support functions for scan mask matching

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoiio:staging:accelerometers move towards the new abi
Jonathan Cameron [Tue, 4 May 2010 13:42:58 +0000 (14:42 +0100)]
iio:staging:accelerometers move towards the new abi

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Add new attrs for sampling frequency available and temp_raw
Jonathan Cameron [Tue, 4 May 2010 13:42:57 +0000 (14:42 +0100)]
staging:iio: Add new attrs for sampling frequency available and temp_raw

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging:iio: Add new in_raw definitions for adc channels.
Jonathan Cameron [Tue, 4 May 2010 13:42:56 +0000 (14:42 +0100)]
staging:iio: Add new in_raw definitions for adc channels.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: all rtl8192su chips have the 93c46 eprom
Florian Schilhabel [Tue, 4 May 2010 12:24:35 +0000 (14:24 +0200)]
Staging: rtl8192su: all rtl8192su chips have the 93c46 eprom

all rtl8192su chips have the 93c46 eprom. (no 93c56)
it it theoretically safe to remove the 93c56 definitions and some unneeded code.
if your device stops working after this patch, please send me a mail
and include some information about your device:
* dmesg
* lsusb -v
* _exact_ chipset (version)
* vendor
* everything else, that may help

plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: refactored FirmwareCheckReady
Florian Schilhabel [Tue, 4 May 2010 12:24:12 +0000 (14:24 +0200)]
Staging: rtl8192su: refactored FirmwareCheckReady

replaced if..else if..else by a switch.
this is hopefully easier to read.

plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8192su: check for skb == NULL
Florian Schilhabel [Tue, 4 May 2010 12:23:43 +0000 (14:23 +0200)]
Staging: rtl8192su: check for skb == NULL

added 2 checks for skb == NULL.
plus cosmetics

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: staging/cxt1e1: Convert bare printks to pr_<level>
Joe Perches [Mon, 3 May 2010 19:33:16 +0000 (12:33 -0700)]
Staging: staging/cxt1e1: Convert bare printks to pr_<level>

Added #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
A few line splits for long arguments
A couple of embedded function names converted to "%s", __func__
Removed some uses of THIS_MODULE->name

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: move ASSERT(scmnd) to a more useful location
Bill Pemberton [Mon, 3 May 2010 21:50:45 +0000 (17:50 -0400)]
Staging: hv: move ASSERT(scmnd) to a more useful location

There's not much point to make sure scmnd is not NULL after an assert
that would dereference scmnd.  The ASSERT()'s should be removed, but
until they are at least they at least can be in the right order.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: delete ext_utils.c
Greg Kroah-Hartman [Tue, 4 May 2010 15:26:23 +0000 (08:26 -0700)]
Staging: hv: delete ext_utils.c

A whole file just for a single line function call is beyond silly.
Delete it and move the call into where it is being called.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: fix up formatting issues in utils.h
Greg Kroah-Hartman [Tue, 4 May 2010 15:21:01 +0000 (08:21 -0700)]
Staging: hv: fix up formatting issues in utils.h

--------  cut here and print out and paste on wall --------

Tabs, not spaces

--------  cut here and print out and paste on wall --------

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Added new hv_utils driver with shutdown as first functionality
Hank Janssen [Tue, 4 May 2010 22:55:05 +0000 (15:55 -0700)]
Staging: hv: Added new hv_utils driver with shutdown as first functionality

Addition of new driver for Hyper-V called hv_utils.
This driver is intended to support things like KVP, Timesync, Heartbeat etc.

This first release has support for Gracefull shutdown.
e.g. Select shutdown from the Hyper-V main admin screen and the Linux VM
will do a gracefull shutdown.

Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: __user markup on comedi_fops.c
Greg Kroah-Hartman [Mon, 3 May 2010 23:32:28 +0000 (16:32 -0700)]
Staging: comedi: __user markup on comedi_fops.c

Hm, what a mess.  I tried to properly mark up the __user pointers,
but for some of these structures, we use them both in the kernel,
and across the user/kernel boundry, which isn't ok.  So we end
up generating a few new sparse warnings in places we were not before,
but the large majority of things are now properly tagged in the fops
file.

The whole ioctl interface needs to be carefully looked at in the future.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: drivers.c sparse cleanup
Greg Kroah-Hartman [Mon, 3 May 2010 22:55:45 +0000 (15:55 -0700)]
Staging: comedi: drivers.c sparse cleanup

Fix up some sparse issues in drivers.c

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: range.c: properly mark up __user pointers
Greg Kroah-Hartman [Mon, 3 May 2010 22:50:09 +0000 (15:50 -0700)]
Staging: comedi: range.c: properly mark up __user pointers

This is the start of cleaning up the user pointer markings
in the comedi core.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move some more functions to internal.h
Greg Kroah-Hartman [Mon, 3 May 2010 22:38:37 +0000 (15:38 -0700)]
Staging: comedi: move some more functions to internal.h

Only the internal comedi core calls these, so put them here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: clean up sparse issues in proc.c
Greg Kroah-Hartman [Mon, 3 May 2010 22:32:04 +0000 (15:32 -0700)]
Staging: comedi: clean up sparse issues in proc.c

The whole file should be converted to use seqfile, if it's even
still needed.  Or move to debugfs.

Anyway, I fixed up the minor issues here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_reset_async_buf local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:27:52 +0000 (15:27 -0700)]
Staging: comedi: make comedi_reset_async_buf local to comedi core

No one outside of the comedi core calls this function, so don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_free_board_minor local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:24:14 +0000 (15:24 -0700)]
Staging: comedi: make comedi_free_board_minor local to comedi core

No one outside of the comedi core calls this function, so don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_alloc_board_minor local to comedi core
Greg Kroah-Hartman [Mon, 3 May 2010 22:20:29 +0000 (15:20 -0700)]
Staging: comedi: make comedi_alloc_board_minor local to comedi core

No one outside of the comedi core calls this function, so create
an internal.h file to put the prototype in, and don't export
it to the world.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: make comedi_set_subdevice_runflags() static
Greg Kroah-Hartman [Mon, 3 May 2010 22:15:06 +0000 (15:15 -0700)]
Staging: comedi: make comedi_set_subdevice_runflags() static

No one calls this anymore, except the core comedi code, so
mark it static and don't export it.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: make it typesafe
Greg Kroah-Hartman [Mon, 3 May 2010 22:01:50 +0000 (15:01 -0700)]
Staging: comedi: kcomedilib: make it typesafe

If we really are passing in a struct comedi_device, then say we are,
don't mess around with void pointers for no reason.

This also fixes up the comedi_bond.c driver, which is the only
user of the kcomedilib code.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: simplify comedi_do_insn()
Greg Kroah-Hartman [Mon, 3 May 2010 21:54:34 +0000 (14:54 -0700)]
Staging: comedi: kcomedilib: simplify comedi_do_insn()

Now that we know we are only making 2 different types of instructions,
only handle those two types.

Also make the call a bit more typesafe by passing the correct pointer
type.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: comedi_do_insn is now static
Greg Kroah-Hartman [Mon, 3 May 2010 21:49:54 +0000 (14:49 -0700)]
Staging: comedi: kcomedilib: comedi_do_insn is now static

No one else calls this function, so mark it static.
Now we can strip out the unneeded functionality in here as well.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: delete dio.c and get.c
Greg Kroah-Hartman [Mon, 3 May 2010 21:44:55 +0000 (14:44 -0700)]
Staging: comedi: kcomedilib: delete dio.c and get.c

Merge these two files into kcomedilib_main.c as they are tiny.

This will also let us get rid of another global symbol in the future.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: kcomedilib_main.c: remove unused functions
Greg Kroah-Hartman [Mon, 3 May 2010 21:41:28 +0000 (14:41 -0700)]
Staging: comedi: kcomedilib: kcomedilib_main.c: remove unused functions

Remove the unused functions from the kcomedilib_main.c file as they are
not needed.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: dio.c: remove unused functions
Greg Kroah-Hartman [Mon, 3 May 2010 21:36:56 +0000 (14:36 -0700)]
Staging: comedi: kcomedilib: dio.c: remove unused functions

Remove the unused functions from the dio.c file as they are not
needed.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: cxt1e1: fix cxt1e1 module names
Joe Perches [Mon, 3 May 2010 18:02:44 +0000 (11:02 -0700)]
Staging: cxt1e1: fix cxt1e1 module names

On Mon, 2010-05-03 at 10:09 -0700, Randy Dunlap wrote:
> Lots of cxt1e1 source code uses THIS_MODULE->name, which won't build
> when CONFIG_MODULES is not enabled, so use KBUILD_MODNAME instead.

Perhaps a conversion to pr_<level> is better?

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Fix all checkpatch.pl issues in dt2811.c
Iain Churcher [Mon, 3 May 2010 10:54:53 +0000 (11:54 +0100)]
Staging: comedi: Fix all checkpatch.pl issues in dt2811.c

Patch resolves all checkpatch.pl isues in dt2811.c

Signed-off-by: Iain Churcher <iain.linux.coding@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Adjusted some long line lengths in drivers.c
Mark Rankilor [Mon, 3 May 2010 10:07:36 +0000 (18:07 +0800)]
Staging: comedi: Adjusted some long line lengths in drivers.c

This patch fixes some long line lengths in drivers.c that checkpatch.pl was
complaining about

Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Moved some EXPORT_SYMBOL() macros
Mark Rankilor [Mon, 3 May 2010 09:39:09 +0000 (17:39 +0800)]
Staging: comedi: Moved some EXPORT_SYMBOL() macros

This is a patch to range.c that rearranges some EXPORT_SYMBOL() macros to please
checkpatch.pl

Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Fix Checkpatch.pl issues in mpc624.c
Iain Churcher [Mon, 3 May 2010 09:35:37 +0000 (10:35 +0100)]
Staging: comedi: Fix Checkpatch.pl issues in mpc624.c

This patch resolves all checkpatch.pl issues in the mpc624.c file

Signed-off-by: Iain Churcher <iain.linux.coding@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: crystalhd: remove unused #include <linux/version.h>
Charles Clément [Mon, 3 May 2010 01:50:16 +0000 (18:50 -0700)]
Staging: crystalhd: remove unused #include <linux/version.h>

Signed-off-by: Charles Clément <caratorn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: crystalhd: Cleanup all WIN* references
Charles Clément [Mon, 3 May 2010 01:29:57 +0000 (18:29 -0700)]
Staging: crystalhd: Cleanup all WIN* references

Signed-off-by: Charles Clément <caratorn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: adis16255: Fix compile error
Javier Martinez Canillas [Sun, 2 May 2010 17:05:33 +0000 (13:05 -0400)]
Staging: adis16255: Fix compile error

This patch solves a compilation error in today linux-next tree.

The adis16255 staging driver Makefile seems to be wrong. I think this patch solves the issue.

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: winbond: Renamed README to TODO and corrected Pavel's mail
Lars Lindley [Sun, 2 May 2010 07:33:26 +0000 (09:33 +0200)]
Staging: winbond: Renamed README to TODO and corrected Pavel's mail

Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: code cleanup, fixed comments style at the end of headers
Andres More [Sat, 1 May 2010 22:12:26 +0000 (19:12 -0300)]
Staging: vt6656: code cleanup, fixed comments style at the end of headers

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: removed VOID/PVOID definitions
Andres More [Sat, 1 May 2010 17:25:00 +0000 (14:25 -0300)]
Staging: vt6656: removed VOID/PVOID definitions

Warnings about the usage of externs in .c files were not resolved here.

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: clean up kcomedilib/get.c
Greg Kroah-Hartman [Sat, 1 May 2010 20:59:57 +0000 (13:59 -0700)]
Staging: comedi: clean up kcomedilib/get.c

Remove all of the unused functions, leaving only those that are
actually called by in-kernel code.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: delete kcomedilib/data.c
Greg Kroah-Hartman [Sat, 1 May 2010 20:55:30 +0000 (13:55 -0700)]
Staging: comedi: delete kcomedilib/data.c

No one is using any of these functions, so remove the file entirely.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove unused functions from comedilib.h
Greg Kroah-Hartman [Sat, 1 May 2010 20:51:58 +0000 (13:51 -0700)]
Staging: comedi: remove unused functions from comedilib.h

Remove the functions that are not used from this file.  Now it will
be easier to determine what code can be removed from kcomedilib by
using sparse.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move an include file out of comedlib.h
Greg Kroah-Hartman [Sat, 1 May 2010 20:44:56 +0000 (13:44 -0700)]
Staging: comedi: move an include file out of comedlib.h

The one .c file that needs it can properly include it.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: clean up comedilib.h
Greg Kroah-Hartman [Sat, 1 May 2010 20:42:37 +0000 (13:42 -0700)]
Staging: comedi: clean up comedilib.h

Remove a whole #ifdef section that is not needed anymore.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: kcomedilib: remove ksyms.c file
Greg Kroah-Hartman [Sat, 1 May 2010 20:08:06 +0000 (13:08 -0700)]
Staging: comedi: kcomedilib: remove ksyms.c file

Move only the exports that we actually use into the individual
files, and delete the ksyms.c file entirely.  This will make it
easier to start cleaning up kcomedilib (i.e. delete most of it.)

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove comedi_ksyms.c
Greg Kroah-Hartman [Sat, 1 May 2010 19:38:02 +0000 (12:38 -0700)]
Staging: comedi: remove comedi_ksyms.c

Move the 4 remaining exports to their function location
and then remove the comedi_ksyms.c file, as it's no longer
needed.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: rename check_chanlist to comedi_check_chanlist
Greg Kroah-Hartman [Sat, 1 May 2010 19:33:17 +0000 (12:33 -0700)]
Staging: comedi: rename check_chanlist to comedi_check_chanlist

It's a global function, so properly name it and move the
export to where the function is located at.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: more EXPORT_SYMBOL movement
Greg Kroah-Hartman [Sat, 1 May 2010 19:12:02 +0000 (12:12 -0700)]
Staging: comedi: more EXPORT_SYMBOL movement

Move the exports for the variables that are in range.c into the
file itself.  These variables should be prefixed with comedi_ but
that's for a different patch...

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: more EXPORT_SYMBOL movement
Greg Kroah-Hartman [Sat, 1 May 2010 19:02:23 +0000 (12:02 -0700)]
Staging: comedi: more EXPORT_SYMBOL movement

This moves the markings to the comedi_fops.c file, where
they belong.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move a bunch of EXPORT_SYMBOL lines
Greg Kroah-Hartman [Sat, 1 May 2010 18:54:07 +0000 (11:54 -0700)]
Staging: comedi: move a bunch of EXPORT_SYMBOL lines

Move the ones that are needed to be in drivers.c into the
file.  This is with the goal of deleting the comedi_ksyms.c
file.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: comedi_ksysms: remove commented out symbols
Greg Kroah-Hartman [Sat, 1 May 2010 18:43:32 +0000 (11:43 -0700)]
Staging: comedi: comedi_ksysms: remove commented out symbols

These aren't needed, they are commented out, so remove them.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Fixing wrap-around bug in vis
Linus Lüssing [Mon, 22 Mar 2010 21:46:15 +0000 (22:46 +0100)]
Staging: batman-adv: Fixing wrap-around bug in vis

When the seqno for a vis packet had a wrap around from i.e. 255 to 0,
add_packet() would falsely claim the older packet with the seqno 255 as
newer as the one with the seqno of 0 and would therefore ignore the new
packet. This happens with all following vis packets until the old vis
packet expires after 180 seconds timeout. This patch fixes this issue
and gets rid of these highly undesired 3min. breaks for the vis-server.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Fix VIS output bug for secondary interfaces
Linus Lüssing [Mon, 22 Mar 2010 21:46:14 +0000 (22:46 +0100)]
Staging: batman-adv: Fix VIS output bug for secondary interfaces

TQ and HNA records for originators on secondary interfaces were
wrongly being included on the primary interface. Ensure we output a
line for each source interface on every node, so we correctly separate
primary and secondary interface records.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: don't have interrupts disabled while sending.
Andrew Lunn [Mon, 22 Mar 2010 21:46:13 +0000 (22:46 +0100)]
Staging: batman-adv: don't have interrupts disabled while sending.

send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now need a new lock to protect that
instead of vis_hash_lock.

Also a few checkpatch cleanups.

Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155v4l: add driver to the build
Greg Kroah-Hartman [Sat, 1 May 2010 17:59:23 +0000 (10:59 -0700)]
Staging: dt3155v4l: add driver to the build

The last patch forgot to add the driver to the Makefile, so it
would not end up getting built.  This resolves that issue.

Cc: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: Yet another (third) dt3155 driver PCI/video4linux compliant
Marin Mitov [Fri, 30 Apr 2010 15:36:09 +0000 (18:36 +0300)]
Staging: Yet another (third) dt3155 driver PCI/video4linux compliant

Kernel module (device driver) for dt3155 frame grabber
video4linux2 compliant (finally). Works with "xawtv -f".

======================================================

This driver is written (almost) from scratch, using the
allocator developed for dt3155pci see bellow). The driver
uses videobuf-dma-contig interface modified to use the above
mentioned allocator instead of dma_alloc_coheren().

The first thing to do was to design a new allocator based
on allocating a configurable number of 4MB chunks of memory,
that latter are broken into frame buffers of 768x576 bytes
kept in different FIFOs (queues). As far as the driver autoloads
as a kernel module during kernel boot, the allocation of 4MB
chunks succeeds.

The driver keeps three FIFOs: one for 4MB chunks, one for free
buffers (available for allocations) and one for buffers already
allocated. Allocation/deallocation is done automatically though
the video4linux videobuf subsystem (some pointers to functions
are replaced by driver supplied functions).

Sure, there are problems:

1. The device tested to work with "xawtv -f" either via read()
   method (DT3155_STREAMING not selected), or via mmap() method
   (DT3155_STREAMING is selected) only. This coresponds to either
   cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE;
   or
   cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
   but not when
   cap->capabilities = V4L2_CAP_VIDEO_CAPTURE |
                           V4L2_CAP_STREAMING |
                           V4L2_CAP_READWRITE;
   This is because xawtv calls poll() before starting streaming,
   but videobuf_poll_stream() automatically starts reading if streaming
   is not started.
   This selection is made during kernel configuration (for now).

2. Works for CCIR, but should work for RS-170 (not tested)
   This is made also during kernel configuration.

3. Could work for multiple dt3155 frame grabbers in a PC,
   (private data is allocated during PCI probe() method), but
   is not tested due to lack of a second board.

4. Not tested on a BIG ENDIAN architecture.

5. Many others you could find .... :-)

All critics, comments, suggestions are wellcome.

Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove another vendor id
Greg Kroah-Hartman [Sat, 1 May 2010 00:36:52 +0000 (17:36 -0700)]
Staging: comedi: remove another vendor id

This id was already in the drivers, so just use it there
instead of in a common header file.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move another pci vendor id
Greg Kroah-Hartman [Sat, 1 May 2010 00:32:04 +0000 (17:32 -0700)]
Staging: comedi: move another pci vendor id

Move the vendor id to the drivers needing it.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move another pci device id to the driver
Greg Kroah-Hartman [Sat, 1 May 2010 00:23:51 +0000 (17:23 -0700)]
Staging: comedi: move another pci device id to the driver

Put a pci vendor id into the drivers that need them.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: move a pci vendor id
Greg Kroah-Hartman [Sat, 1 May 2010 00:07:25 +0000 (17:07 -0700)]
Staging: comedi: move a pci vendor id

The vendor id should be in the driver that needs it, not in
a common file.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove some pci vendor ids
Greg Kroah-Hartman [Fri, 30 Apr 2010 23:58:36 +0000 (16:58 -0700)]
Staging: comedi: remove some pci vendor ids

These are never used, so remove them.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: use the standard NI pci device id
Greg Kroah-Hartman [Fri, 30 Apr 2010 23:52:52 +0000 (16:52 -0700)]
Staging: comedi: use the standard NI pci device id

Don't redefine something that we already have in the core
kernel.  Also move to use PCI_DEVICE() macros to make things
a bit simpler when changing the define.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix up remaining coding style issue in proc.c
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:59:18 +0000 (15:59 -0700)]
Staging: comedi: fix up remaining coding style issue in proc.c

Move the external variable into a .h file, where it belongs.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove wrapper.h
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:55:39 +0000 (15:55 -0700)]
Staging: comedi: remove wrapper.h

Just make the bit call when it is needed, no need to wrap
things up like this for no reason.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove local pci_ids.h file
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:48:19 +0000 (15:48 -0700)]
Staging: comedi: remove local pci_ids.h file

It's only being used for one vendor id, so move it into
the driver that uses it and delete the file.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix up coding issues in proc.c
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:43:12 +0000 (15:43 -0700)]
Staging: comedi: fix up coding issues in proc.c

Fixes all but one.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix up coding style issues in range.c
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:35:37 +0000 (15:35 -0700)]
Staging: comedi: fix up coding style issues in range.c

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: remove unneeded ifdef in comedi_bond.c
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:31:13 +0000 (15:31 -0700)]
Staging: comedi: remove unneeded ifdef in comedi_bond.c

No need to check for MODULE_LICENSE, it's always there.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix coding style issues in comedidev.h
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:26:54 +0000 (15:26 -0700)]
Staging: comedi: fix coding style issues in comedidev.h

This resolves some coding style issues in comedidev.h

And yes, volatile here meant nothing, removing it is ok.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix up coding style issues in comedilib.h
Greg Kroah-Hartman [Fri, 30 Apr 2010 22:25:53 +0000 (15:25 -0700)]
Staging: comedi: fix up coding style issues in comedilib.h

This resolves some issues with comedilib.h

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>