OSDN Git Service
Zach Johnson [Mon, 14 Dec 2020 03:54:51 +0000 (19:54 -0800)]
rusty-gd: controller supported commands & le buffer sizes
also, generate TryFrom for OpCodeIndex from OpCode, to remove 700+ lines
of repeated code in C++ gd controller
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ic6d95ccc87a0ccc64636f16b0ef379c1f0d2f069
Zach Johnson [Mon, 14 Dec 2020 01:14:27 +0000 (17:14 -0800)]
rusty-gd: A bit more controller
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I999c43fdbb5bcbcbb005dece73192ec2300138d0
Zach Johnson [Sun, 13 Dec 2020 11:22:22 +0000 (03:22 -0800)]
rusty-gd: add intos for builders, so we can skip the formal build call
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie68b9124b0d6f7b4c52ce882a6966995088d17f6
Zach Johnson [Sun, 13 Dec 2020 11:09:15 +0000 (03:09 -0800)]
rusty-gd: start controller module
only a few calls to start, more to come
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I91e6a21f4d15e67c5ad7b917cd31d419bf86ebe9
Zach Johnson [Sun, 13 Dec 2020 10:31:53 +0000 (02:31 -0800)]
rusty-gd: simplify queued & pending commands
since packets are just wrappers around Arcs, copies are somewhat cheap
so no need to keep a struct with just opcode anymore
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I6294a728e07b2ee949ef96465b07678845f5115c
Zach Johnson [Sun, 13 Dec 2020 10:17:22 +0000 (02:17 -0800)]
rusty-gd: make scalar getters return by copy rather than ref
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I1427e8cc8c252a1eddb68470b1df215cf53c628f
Zach Johnson [Sun, 13 Dec 2020 09:59:43 +0000 (01:59 -0800)]
rusty-gd: drastically simplify command sending
include a trait during generation that knows how to
convert the event responses to the correct matching type
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Icf96ce20c0b2311e94e5198c1cc4038f78683771
Zach Johnson [Sun, 13 Dec 2020 08:22:14 +0000 (00:22 -0800)]
rusty-gd: improve ergonomics of sending commands a bit
use generics to implicity call into
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ied9f2e4f544979f63554bd3276e092788e0f0706
Zach Johnson [Sun, 13 Dec 2020 08:18:03 +0000 (00:18 -0800)]
rusty-gd: send reset command when HCI starts
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Iaca9bcda285ff4682532efeb43e2892adc487e9a
Zach Johnson [Sun, 13 Dec 2020 07:51:13 +0000 (23:51 -0800)]
rusty-gd: no more sleep
since it's backed by a fd, a structure that encourages reuse is a good
thing.
integrate this into HCI, for command timeouts
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I3094c7a666281cebdfdeee05246ac1ad557988c5
Zach Johnson [Sun, 13 Dec 2020 07:16:12 +0000 (23:16 -0800)]
rusty-gd: protect protected events in hci
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I5d79687eb4d464fb5942651f86945db31cfa62d3
Zach Johnson [Sun, 13 Dec 2020 07:03:50 +0000 (23:03 -0800)]
rusty-gd: only allow one registration for an event, allow unregistering
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I6a0f12b696a22f0653037e3530ccfb4e2f38d001
Zach Johnson [Sun, 13 Dec 2020 06:54:17 +0000 (22:54 -0800)]
rusty-gd: drop events dropped by cpp-gd
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I40942038dea359a31f413f604dcc3c6db926f80e
Zach Johnson [Sun, 13 Dec 2020 06:45:46 +0000 (22:45 -0800)]
rusty-gd: implement le meta events
and oh hey, pattern matching is pretty freaking great
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I4ce65e275ffe0e16161260e854d02987d166e4ca
Zach Johnson [Sun, 13 Dec 2020 06:14:56 +0000 (22:14 -0800)]
rusty-gd: update command sending to match cpp-gd
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie08faff009045ee329c7392652d632fed49f9d11
Zach Johnson [Sun, 13 Dec 2020 05:38:53 +0000 (21:38 -0800)]
rusty-gd: simplify hci a little bit
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I0356c2102cf760c091a92ae0ab8ee7917eea03b6
Zach Johnson [Sun, 13 Dec 2020 05:13:52 +0000 (21:13 -0800)]
rusty-gd: simplify some packet usages
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ie591460ed642a46215cfe8b0ddefcb509f21db89
Zach Johnson [Sun, 13 Dec 2020 05:02:59 +0000 (21:02 -0800)]
rusty-gd: improve ergonomics of converting packets to vectors
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I51b88fc9513475ab0e25b41ce5bb40b7934e9692
Zach Johnson [Sun, 13 Dec 2020 04:11:26 +0000 (20:11 -0800)]
rusty-gd: integrate rusty packets into existing code
still gotta wait for parsing to land for this to officially work, but
this allows us to play with the ergonomics independently based on what
compiles..
next CLs will start to improve the ergos.
some ergos improved this CL.
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I5eadd7619c5d392c2dd03331c5d604d9a52a1687
Zach Johnson [Thu, 17 Dec 2020 19:26:20 +0000 (19:26 +0000)]
Merge "use common data + payload for hci & hal facades"
Zach Johnson [Thu, 17 Dec 2020 19:22:18 +0000 (19:22 +0000)]
Merge "rusty-gd: create singular proto facade lib"
Treehugger Robot [Thu, 17 Dec 2020 17:38:26 +0000 (17:38 +0000)]
Merge "gd: Default to rotating addresses"
Chen Chen [Thu, 17 Dec 2020 08:43:38 +0000 (08:43 +0000)]
Merge "Updateability: Remove IBluetoothHeadsetPhone aidl"
Treehugger Robot [Wed, 16 Dec 2020 22:27:31 +0000 (22:27 +0000)]
Merge "set_report API should use HID control channel to send data"
Zach Johnson [Wed, 16 Dec 2020 20:43:23 +0000 (12:43 -0800)]
use common data + payload for hci & hal facades
the special names for each method add no extra details
also, make hci ACL sending purely data packet based and use packet
building instead to create the bytes
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run
Change-Id: Ib4aff269b25851b867676e7b690cafa6b75442a8
Zach Johnson [Wed, 16 Dec 2020 19:08:14 +0000 (11:08 -0800)]
rusty-gd: create singular proto facade lib
need to rename input files so they are unique
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I9f2f0099085db2480950803658a96d005289521f
Zach Johnson [Wed, 16 Dec 2020 21:57:50 +0000 (21:57 +0000)]
Merge changes I10a05872,I1a990478
* changes:
IsoPacket -> Iso, ScoPacket -> Sco
AclPacket -> Acl
Zach Johnson [Wed, 16 Dec 2020 21:29:15 +0000 (21:29 +0000)]
Merge "EventPacket -> Event"
Myles Watson [Wed, 16 Dec 2020 19:30:23 +0000 (11:30 -0800)]
gd: Default to rotating addresses
Tag: #gd-refactor
Bug:
169125803
Test: cert/run
Change-Id: I608c5c57e2e0ece5329e7bb993e6a5288261eb2d
Treehugger Robot [Wed, 16 Dec 2020 19:18:26 +0000 (19:18 +0000)]
Merge changes Ia88c2415,Icc104e2f
* changes:
Group upper layer notifications stack/acl/btm_acl::
Add bta/dm/bta_dm_act::BTA_dm_notify_remote_features_complete
Zach Johnson [Sun, 13 Dec 2020 02:21:00 +0000 (18:21 -0800)]
IsoPacket -> Iso, ScoPacket -> Sco
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I10a058723fe42c731808d6005a9ed32c928e10c0
Zach Johnson [Sun, 13 Dec 2020 02:12:24 +0000 (18:12 -0800)]
AclPacket -> Acl
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I1a990478af55cfce722466b955fe4adc80fa30b1
Zach Johnson [Sun, 13 Dec 2020 01:58:24 +0000 (17:58 -0800)]
EventPacket -> Event
simpler
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ib493861824c05d3a019e25d9fed8ad09cfac55dd
Zach Johnson [Wed, 16 Dec 2020 18:39:30 +0000 (18:39 +0000)]
Merge "CommandPacket -> Command"
Hansong Zhang [Mon, 14 Dec 2020 23:23:35 +0000 (15:23 -0800)]
L2cap shim: Send the correct disconnect callback
Tag: #gd-refactor
Test: CtsVerifier
Bug:
141555841
Change-Id: I939f0fa0ea4d66c11ec282bbc693b22c6804b76a
Treehugger Robot [Wed, 16 Dec 2020 17:48:02 +0000 (17:48 +0000)]
Merge changes I5f1244d7,Ie41c2519,Ie07221ad
* changes:
gd: Enable advertising module by INIT flag
gd: Prevent set privacy policy twice
gd: Handle periodic advertising in start advertising
Chris Manton [Tue, 15 Dec 2020 21:49:27 +0000 (13:49 -0800)]
Group upper layer notifications stack/acl/btm_acl::
Eventual interface replacement
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Ia88c24158d8de4500d1bccbd8685318ac8433bfa
Chris Manton [Thu, 10 Dec 2020 05:18:41 +0000 (21:18 -0800)]
Add bta/dm/bta_dm_act::BTA_dm_notify_remote_features_complete
Although the connection has been made, subsequent queries
of remote host may not have been completed. One important
set of data BTA requires is the remote features.
This callback allows synchronization for valid remote
features.
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Icc104e2f47bd79f904a684a7290ca38a123e3cfb
Chienyuan [Wed, 16 Dec 2020 11:59:19 +0000 (19:59 +0800)]
gd: Enable advertising module by INIT flag
Tag: #gd-refactor
Bug:
169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: I5f1244d71a77b9d8f470dfd621d50bd23788529b
Treehugger Robot [Wed, 16 Dec 2020 11:14:47 +0000 (11:14 +0000)]
Merge changes Ia3a8c7e1,I65bac30e,Ide1a5faa,I64f5be7d,Id19aa6c9, ...
* changes:
enum-ify bta/include/bta_api::BTA_DM_PM_
Remove #def and use IsEprAvailable
Use proper tHCI_STATUS types
Inclusive language BTM_DEV_BLACKLISTED => BTM_DEV_RESTRICT_LISTED
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_remote_features_complete
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_remote_ext_features_complete
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_tx_power_complete
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_automatic_flush_timeout_complete
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_rssi_complete
Re-log and properly type bta/dm/bta_dm_pm::bta_dm_pm_sniff
Properly type bta/.../::BTA_SYS_CONN_OPEN
Properly type args stack/acl/btm_pm::BTM_ReadPowerMode
Add bta/sys/bta_sys::bta_sys_conn_status_text
enum-ify bta/sys/bta_sys::tBTA_SYS_CONN_STATUS
Add stack/include/btm_status::btm_status_text
gd_acl: Remove redundant call stack/l2cap/l2c_link
Chienyuan [Wed, 16 Dec 2020 10:00:59 +0000 (18:00 +0800)]
gd: Prevent set privacy policy twice
Tag: #gd-refactor
Bug:
169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: Ie41c2519818edff3061d77c4df1e126f976fa0c2
Treehugger Robot [Wed, 16 Dec 2020 10:04:25 +0000 (10:04 +0000)]
Merge "Cert: Pin Code Test"
Chienyuan [Wed, 16 Dec 2020 06:41:34 +0000 (14:41 +0800)]
gd: Handle periodic advertising in start advertising
Tag: #gd-refactor
Bug:
169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: Ie07221ad62a5d7674f8cfc6b2253231b5f15f668
Chris Manton [Thu, 10 Dec 2020 00:31:56 +0000 (16:31 -0800)]
enum-ify bta/include/bta_api::BTA_DM_PM_
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Ia3a8c7e18de52d1b4b2b73ea76ce57586c954a4e
Chris Manton [Fri, 11 Dec 2020 00:14:05 +0000 (16:14 -0800)]
Remove #def and use IsEprAvailable
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I65bac30e7060f0cc156676c1f78d2f3482b16835
Chris Manton [Mon, 14 Dec 2020 06:47:04 +0000 (22:47 -0800)]
Use proper tHCI_STATUS types
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Ide1a5faa7afbed347a77d5c484a633479bf641ef
Chris Manton [Tue, 15 Dec 2020 18:02:32 +0000 (10:02 -0800)]
Inclusive language BTM_DEV_BLACKLISTED => BTM_DEV_RESTRICT_LISTED
Bug:
170342881
Tag: #refactor
Test: atest --host bluetooth_test_gd
Change-Id: I64f5be7d2aa38a62091fde43b1926479021c10a6
Chris Manton [Sun, 13 Dec 2020 18:54:19 +0000 (10:54 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_remote_features_complete
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Id19aa6c9dd0c5bb010345e8706a55be05b04fcc0
Chris Manton [Sun, 13 Dec 2020 18:46:23 +0000 (10:46 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_remote_ext_features_complete
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I8daa6e06248eb28463b1ef552bbfe3ff547f6d3a
Chris Manton [Sun, 13 Dec 2020 02:24:23 +0000 (18:24 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_tx_power_complete
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Ib916439e3d5c0580ce299ee2b5b3b2c07161a78b
Chris Manton [Sun, 13 Dec 2020 01:54:04 +0000 (17:54 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_automatic_flush_timeout_complete
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I474142526f861161f5a95c3214a43ea2794afa5c
Chris Manton [Sun, 13 Dec 2020 01:33:24 +0000 (17:33 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::btm_read_rssi_complete
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Icade424100d8ca269166b8f3f9179245abb88963
Chris Manton [Tue, 8 Dec 2020 07:03:00 +0000 (23:03 -0800)]
Re-log and properly type bta/dm/bta_dm_pm::bta_dm_pm_sniff
Towards readable code. Classic power mode is a mess
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: Idd88f6b53eb722a2b7477d9b244ae9ab94d63df2
Chris Manton [Sun, 6 Dec 2020 22:43:19 +0000 (14:43 -0800)]
Properly type bta/.../::BTA_SYS_CONN_OPEN
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I063ab292f54a9ae6e1ab488030fb82f0a4576e49
Chris Manton [Tue, 8 Dec 2020 06:35:06 +0000 (22:35 -0800)]
Properly type args stack/acl/btm_pm::BTM_ReadPowerMode
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I94620f506d0fc5ee32f1fe8a5dc75dc5915dd6af
Chris Manton [Sun, 6 Dec 2020 22:49:06 +0000 (14:49 -0800)]
Add bta/sys/bta_sys::bta_sys_conn_status_text
Towards loggable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I1a43557474ede94add88fe98bece0dda81520315
Chris Manton [Sun, 6 Dec 2020 22:43:35 +0000 (14:43 -0800)]
enum-ify bta/sys/bta_sys::tBTA_SYS_CONN_STATUS
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I1b8e4555ab6754d74f0058b4909a6e06718af035
Chris Manton [Tue, 8 Dec 2020 22:26:10 +0000 (14:26 -0800)]
Add stack/include/btm_status::btm_status_text
Towards loggable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I0c28b56845e4d0c37931842ee882a4c55c5ab98a
Chris Manton [Fri, 4 Dec 2020 23:25:40 +0000 (15:25 -0800)]
gd_acl: Remove redundant call stack/l2cap/l2c_link
Previous arch had l2cap driving the btm layer.
The new legacy acl/btm layer sits between the l2cap
layer and the hci layer. The call path has
already been exercised by this time and is called twice
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I8e83a79020f0c9cdfaab0916af1a8e2028e130ca
Hansong Zhang [Tue, 15 Dec 2020 21:41:32 +0000 (13:41 -0800)]
LE L2cap: Use client callback if locally initiated
Don't use callbacks for registered service (we as server). This could
confuse user (shim).
Tag: #gd-refactor
Test: CtsVerifier
Bug:
141555841
Change-Id: Icde090fa609043a61301c18782874dad9ade99d1
Zach Johnson [Sun, 13 Dec 2020 01:32:32 +0000 (17:32 -0800)]
CommandPacket -> Command
drop the packet, it's simpler.
CommandPacket is already a packet, and the generated Rust packets will
have Packet appended in some cases, which would lead to
CommandPacketPacket, which is not great.
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I5ad00f7c0f0d2dda83b3e1213145f0bd87c799e0
Zach Johnson [Wed, 16 Dec 2020 03:20:00 +0000 (03:20 +0000)]
Merge changes If1e078bd,I8ee5baf6
* changes:
rusty-gd: refine stack ffi a bit
Apply rustfmt to keep checkin hook happy
Treehugger Robot [Wed, 16 Dec 2020 03:14:36 +0000 (03:14 +0000)]
Merge "Revert "Cert: Temporarily disable the SSP OOB test""
Myles Watson [Wed, 16 Dec 2020 01:05:26 +0000 (01:05 +0000)]
Revert "Cert: Temporarily disable the SSP OOB test"
This reverts commit
e17119395069b33a0f6e1080e80d5b1e10c35be4.
Reason for revert: The CL that fixed the test landed
Bug:
175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: I4dd577f53a45abb2e0f6c52fc3d577ed6ab8e3ce
Chienyuan [Tue, 15 Dec 2020 09:30:20 +0000 (17:30 +0800)]
gd: Refactor ExtendedCreateAdvertiser function
Tag: #gd-refactor
Bug:
169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: I2fa3ddf5b50764e5dde5a613de473405824c4948
Martin Brabham [Fri, 4 Dec 2020 05:00:41 +0000 (21:00 -0800)]
Cert: Pin Code Test
Implement cert test for verification of PIN code functionality
Additionally, don't enabled SSP in the controller layer.
Allow for Security module to control setting.
Bug:
162984360
Tag: #gd-refactor
Test: cert/run --host SecurityTest:test_successful_dut_initiated_pin
Change-Id: I770e3fb7e2682269810776aa75b416ebc58b5369
Treehugger Robot [Tue, 15 Dec 2020 22:02:44 +0000 (22:02 +0000)]
Merge "Security: Wait for name request in link key notification"
Zach Johnson [Tue, 15 Dec 2020 21:56:21 +0000 (21:56 +0000)]
Merge changes I992b781d,Ic2cfde11,I8e8d5a05
* changes:
rusty-gd: expose rust enums for enums
rusty-gd: add builder structs
rusty-gd: call children write_to()s
Zach Johnson [Tue, 15 Dec 2020 21:55:03 +0000 (21:55 +0000)]
Merge changes Icc40d3d8,I241bcf4e,I9406eb11,I8dea0a13,Ib4a05164, ...
* changes:
rusty-gd: update visibilities, put parse & to bytes on pub api
rusty-gd: refine specialization
rusty-gd: start specialzation frontend
rusty-gd: add packet accessors
rusty-gd: Add child & into for pub access packet structs
rusty-gd: separate data storage from packet view
Jakub Pawlowski [Tue, 15 Dec 2020 21:54:45 +0000 (21:54 +0000)]
Merge "LE Audio State Machine and Native Interface boilerplate"
Zach Johnson [Thu, 10 Dec 2020 21:08:19 +0000 (13:08 -0800)]
rusty-gd: refine stack ffi a bit
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: If1e078bdb64a41ee0a77e352617f39a0ab3155d5
Zach Johnson [Tue, 15 Dec 2020 21:47:52 +0000 (13:47 -0800)]
Apply rustfmt to keep checkin hook happy
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8ee5baf6fcfabcaefe08a7792e655e41cf502df1
Ivan Lozano [Tue, 15 Dec 2020 21:38:31 +0000 (21:38 +0000)]
Merge "Change rust_grpcio modules to rust_protobuf."
Myles Watson [Tue, 15 Dec 2020 19:32:11 +0000 (19:32 +0000)]
Merge "Cert: Temporarily disable the SSP OOB test"
Martin Brabham [Tue, 15 Dec 2020 18:29:34 +0000 (10:29 -0800)]
Cert: Temporarily disable the SSP OOB test
Waiting on another CL to fix the underlying issue before re-enabling
Bug:
175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: If24dfb92d987d2dc147ed396b9f6b9d4d249347d
Martin Brabham [Mon, 14 Dec 2020 20:31:03 +0000 (12:31 -0800)]
Security: Wait for name request in link key notification
For classic SSP numeric comparison we must wait at the
UserConfirmationRequest in order to get the name before
we display it to the user. However, in the Out of Band
data flow we never get a UserConfirmationRequest.
Thus, we must wait in the link key notification if we
have not yet received a name response.
Remove setting to std::nullopt as the operator= in
std::optional causes the underlying pointer to be reset
and thus freed, but still accessed by the pointer we passed.
Bug:
175033589
Test: cert/run SecurityTest:test_successful_dut_initiated_ssp_oob --repeat=20
Tag: #gd-refactor
Change-Id: Ic3f424e22a0c596b21969d4882d0a9b06f7433ab
Treehugger Robot [Tue, 15 Dec 2020 13:31:25 +0000 (13:31 +0000)]
Merge "AV stream state machine logging"
Treehugger Robot [Tue, 15 Dec 2020 02:33:41 +0000 (02:33 +0000)]
Merge "gd: Fragmentation for periodic advertising"
Zach Johnson [Tue, 15 Dec 2020 00:21:46 +0000 (00:21 +0000)]
Merge "rusty-gd: rename interop to ffi"
Treehugger Robot [Mon, 14 Dec 2020 23:26:53 +0000 (23:26 +0000)]
Merge changes I5bc0330c,I7d68ca08,I3f5bba04
* changes:
enum-ify bta/include/bta_api::SSR_
btm_history: Add acl power mode state
Properly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection
Zach Johnson [Mon, 14 Dec 2020 23:05:00 +0000 (23:05 +0000)]
Merge changes Id10b509c,I3f1a6073,I07885881
* changes:
rusty-gd: mark vector field writing as unimplemented
rusty-gd: add support for struct fields in write_to()
rusty-gd: start writing scalar fields in write_to()
Chris Manton [Tue, 8 Dec 2020 21:35:21 +0000 (13:35 -0800)]
enum-ify bta/include/bta_api::SSR_
Towards readable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I5bc0330c7e9fbf902b0b1f000017f5d733c7dcce
Chris Manton [Tue, 8 Dec 2020 19:01:48 +0000 (11:01 -0800)]
btm_history: Add acl power mode state
Towards loggable code
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I7d68ca082c683f663024309e577041ba5ff5d02e
Chris Manton [Tue, 8 Dec 2020 19:02:06 +0000 (11:02 -0800)]
Properly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection
Towards encapsulation
Bug:
163134718
Tag: #refactor
Test: gd/cert/run --host
Change-Id: I3f5bba04de53378dad998c5471f9ca20cd6be2d6
Treehugger Robot [Mon, 14 Dec 2020 21:32:45 +0000 (21:32 +0000)]
Merge changes If9886370,I80a0fbce
* changes:
GD-Cert: Symbolize ASAN triggered crashes
GD-Facade: Enable ASAN but disable container overflow check
Zach Johnson [Mon, 14 Dec 2020 20:51:16 +0000 (20:51 +0000)]
Merge "rusty-gd: implement btsnoop"
Treehugger Robot [Mon, 14 Dec 2020 20:25:19 +0000 (20:25 +0000)]
Merge "Use canonical version of rustfmt"
Hansong Zhang [Wed, 9 Dec 2020 20:31:16 +0000 (12:31 -0800)]
Print what module is being started/stopped in crash
Tag: #stability
Bug:
174293959
Test: cert/run
Change-Id: Ie1b5d6af3bc57b3672ba10307d6b0fa9c6267706
Zach Johnson [Sat, 12 Dec 2020 23:13:33 +0000 (15:13 -0800)]
rusty-gd: expose rust enums for enums
break parsing primitive type out, just for parsing
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I992b781dd83c3a047970ee25f9bf70e8e1e14f9e
Zach Johnson [Sat, 12 Dec 2020 20:40:44 +0000 (12:40 -0800)]
rusty-gd: update visibilities, put parse & to bytes on pub api
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Icc40d3d81fc5681d3e54536ae56a1e1bf5b90896
Zach Johnson [Sat, 12 Dec 2020 22:40:26 +0000 (14:40 -0800)]
rusty-gd: add builder structs
by making them structs, you must name the parameters explicitly (which
is great for readability - also it doesn't matter which order you
specify them as long as you specify them all)
since builders can be constructed for middle structs in the lineage, add
None option for child enums
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ic2cfde113ccd6f8475c7514c513ac7b62b3689e3
Zach Johnson [Sat, 12 Dec 2020 20:15:28 +0000 (12:15 -0800)]
rusty-gd: refine specialization
no need for accessors, define RCs that get loaded upon construction
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I241bcf4e5f3ad95df37b4d0d3b174728965a4f7f
Zach Johnson [Sat, 12 Dec 2020 20:50:55 +0000 (12:50 -0800)]
rusty-gd: call children write_to()s
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8e8d5a054e9a3f57328d9a0c1cdbaec28a6df9e2
Zach Johnson [Sat, 12 Dec 2020 06:44:28 +0000 (22:44 -0800)]
rusty-gd: start specialzation frontend
comment out and mark internal parse & ctors as unimplemented (child
parsing not ready yet)
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I9406eb111c56a88d31f4973fc4cda6facc9c18bb
Zach Johnson [Sat, 12 Dec 2020 05:47:56 +0000 (21:47 -0800)]
rusty-gd: add packet accessors
accessors for all ancestor fields too
stubbed against accessor functions (until inner child is ready)
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8dea0a1380b70a8b050e277dc3a388751000f7bf
Zach Johnson [Sat, 12 Dec 2020 05:13:17 +0000 (21:13 -0800)]
rusty-gd: Add child & into for pub access packet structs
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: Ib4a0516495246ab73b981f8259500f4ab2a98d17
Zach Johnson [Fri, 11 Dec 2020 18:56:45 +0000 (10:56 -0800)]
rusty-gd: mark vector field writing as unimplemented
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: Id10b509cdca7e05e63c09c04b8c27dc72787e70f
Zach Johnson [Sat, 12 Dec 2020 00:38:08 +0000 (16:38 -0800)]
rusty-gd: separate data storage from packet view
create XYZData structs & enums, which will be internally accessed through
the exposed view
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I734e1ce5198223b51364e0cb5cd8370104c7b8ef
Zach Johnson [Fri, 11 Dec 2020 18:50:24 +0000 (10:50 -0800)]
rusty-gd: add support for struct fields in write_to()
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I3f1a60733d2bf6bd77064523171f08dcb855ba7b
Zach Johnson [Fri, 11 Dec 2020 18:40:26 +0000 (10:40 -0800)]
rusty-gd: start writing scalar fields in write_to()
Bug:
171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost
Change-Id: I07885881aa19538e62bd9cdcdac79127349f60b6
OSDN Git Service
