OSDN Git Service
Treehugger Robot [Tue, 11 Aug 2020 11:45:26 +0000 (11:45 +0000)]
Merge "Add maco@ to vold OWNERS." am:
157a08bb92 am:
3d1b6ac7c0 am:
abd6f5a165 am:
64e605bfee
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1396467
Change-Id: Id5d4954cab6ef86ca406582031660f3b263354de
Treehugger Robot [Tue, 11 Aug 2020 11:28:19 +0000 (11:28 +0000)]
Merge "Add maco@ to vold OWNERS." am:
157a08bb92 am:
3d1b6ac7c0 am:
abd6f5a165
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1396467
Change-Id: I857784ab0f24771c96ad0ecf48ddec659c650f9c
Treehugger Robot [Tue, 11 Aug 2020 11:13:35 +0000 (11:13 +0000)]
Merge "Add maco@ to vold OWNERS." am:
157a08bb92 am:
3d1b6ac7c0
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1396467
Change-Id: I02184aa11a783fb3201812d2a8f64faca981cbc2
Treehugger Robot [Tue, 11 Aug 2020 10:56:15 +0000 (10:56 +0000)]
Merge "Add maco@ to vold OWNERS." am:
157a08bb92
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1396467
Change-Id: I0d0a8048465e190105f03dfe76fbf5c8393a4198
Treehugger Robot [Tue, 11 Aug 2020 10:34:17 +0000 (10:34 +0000)]
Merge "Add maco@ to vold OWNERS."
Martijn Coenen [Tue, 11 Aug 2020 07:13:27 +0000 (09:13 +0200)]
Add maco@ to vold OWNERS.
Bug: N/A
Test: N/A
Change-Id: Ib00991eccbd33e719a64d55da932f7f2bfab7b71
Eric Biggers [Mon, 10 Aug 2020 23:43:48 +0000 (23:43 +0000)]
Merge "vold: use __ANDROID_API_Q__ instead of pre_gki_level" am:
ee1a70c129 am:
c6f47996d6 am:
124f3575be am:
86eefdac89
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1395128
Change-Id: I1b72ac80a0c369039a7b6e405715baef1c3481b5
Eric Biggers [Mon, 10 Aug 2020 23:25:45 +0000 (23:25 +0000)]
Merge "vold: use __ANDROID_API_Q__ instead of pre_gki_level" am:
ee1a70c129 am:
c6f47996d6 am:
124f3575be
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1395128
Change-Id: I09a23c705c2fe0bc01c321f38c3eadb7bd1e44da
Eric Biggers [Mon, 10 Aug 2020 23:10:18 +0000 (23:10 +0000)]
Merge "vold: use __ANDROID_API_Q__ instead of pre_gki_level" am:
ee1a70c129 am:
c6f47996d6
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1395128
Change-Id: I14257e5e427795e8871de5df94696e49766566a6
Eric Biggers [Mon, 10 Aug 2020 22:53:51 +0000 (22:53 +0000)]
Merge "vold: use __ANDROID_API_Q__ instead of pre_gki_level" am:
ee1a70c129
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1395128
Change-Id: Iacb41f3dba6c2a57943f766b749d87efe6f4e4b3
Eric Biggers [Mon, 10 Aug 2020 22:35:21 +0000 (22:35 +0000)]
Merge "vold: use __ANDROID_API_Q__ instead of pre_gki_level"
Eric Biggers [Mon, 10 Aug 2020 19:10:41 +0000 (19:10 +0000)]
Merge "EncryptInPlace: ensure that backup superblocks get encrypted" am:
213dbe30a1 am:
5acfc3e8d5 am:
d1a7e750e2 am:
891b367b0a
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1385029
Change-Id: I5399da429b5177f129f0e907d50a5caed760aa31
Eric Biggers [Mon, 10 Aug 2020 18:46:37 +0000 (18:46 +0000)]
Merge "EncryptInPlace: ensure that backup superblocks get encrypted" am:
213dbe30a1 am:
5acfc3e8d5 am:
d1a7e750e2
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1385029
Change-Id: Ib38c9b7459b1dcd4c8b00334bcf4375d81d590fe
Eric Biggers [Mon, 10 Aug 2020 17:55:56 +0000 (10:55 -0700)]
vold: use __ANDROID_API_Q__ instead of pre_gki_level
The name "pre_gki_level" is causing some confusion because not all
devices launching with Android R are subject to the GKI requirement.
(See b/
161563110#comment11.) E.g., devices that use a 4.14-based kernel
are exempt from GKI. However, the encryption requirements still apply.
Just use __ANDROID_API_Q__ directly instead.
No change in behavior.
Change-Id: Id02ae1140845ac1ae7cf78be4e57fe34da028abf
Eric Biggers [Mon, 10 Aug 2020 18:22:03 +0000 (18:22 +0000)]
Merge "EncryptInPlace: ensure that backup superblocks get encrypted" am:
213dbe30a1 am:
5acfc3e8d5
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1385029
Change-Id: I28615b8a9a656804b8ebacff0876e2acb1a64c1f
Eric Biggers [Mon, 10 Aug 2020 18:04:57 +0000 (18:04 +0000)]
Merge "EncryptInPlace: ensure that backup superblocks get encrypted" am:
213dbe30a1
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1385029
Change-Id: I29e6eab9571d4556883594049f4abc33d9ffa674
Eric Biggers [Mon, 10 Aug 2020 17:52:39 +0000 (17:52 +0000)]
Merge "EncryptInPlace: ensure that backup superblocks get encrypted"
Will Shiu [Wed, 29 Jul 2020 09:03:17 +0000 (17:03 +0800)]
EncryptInPlace: ensure that backup superblocks get encrypted
Block groups with EXT4_BG_BLOCK_UNINIT still have backup superblocks
(and backup block group descriptors). Fix EncryptInPlace to encrypt
these backup superblocks rather than leave them unencrypted.
Previously leaving the backup superblocks unencrypted didn't cause any
problems, but due to system/core commit
72abd7b246f7 ("Try to recover
corrupted ext4 /data with backup superblock") it is causing problems.
Bug:
162479411
Bug:
161871210
Change-Id: Ic090bf4e88193b289b04c5254ddf661ef40b037e
Treehugger Robot [Fri, 17 Jul 2020 19:42:07 +0000 (19:42 +0000)]
Merge "vold: restore -D__ANDROID_DEBUGGABLE__" am:
5de675c93b am:
bb92ff6591 am:
dd8b695c61 am:
e9317d2d74
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365586
Change-Id: I80fb7d3fc455966b64e0626f273ec0c60e279de1
Treehugger Robot [Fri, 17 Jul 2020 19:20:28 +0000 (19:20 +0000)]
Merge "vold: restore -D__ANDROID_DEBUGGABLE__" am:
5de675c93b am:
bb92ff6591 am:
dd8b695c61
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365586
Change-Id: I876aaf6bba933c964a3573d8053cc60829b3a5fa
Treehugger Robot [Fri, 17 Jul 2020 19:02:45 +0000 (19:02 +0000)]
Merge "vold: restore -D__ANDROID_DEBUGGABLE__" am:
5de675c93b am:
bb92ff6591
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365586
Change-Id: Id417587a550b0f4abf5a6a3e4b4535011b21f627
Treehugger Robot [Fri, 17 Jul 2020 18:38:05 +0000 (18:38 +0000)]
Merge "vold: restore -D__ANDROID_DEBUGGABLE__" am:
5de675c93b
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365586
Change-Id: Ibb6947f1fad7a31cf2a42c3604c76fcf45a7082a
Treehugger Robot [Fri, 17 Jul 2020 18:24:51 +0000 (18:24 +0000)]
Merge "vold: restore -D__ANDROID_DEBUGGABLE__"
Mark Salyzyn [Fri, 17 Jul 2020 15:17:50 +0000 (08:17 -0700)]
vold: restore -D__ANDROID_DEBUGGABLE__
Regression introduced by
commit
7ebcc2bcfde2cf6713e2975224034b06ba0943d8
("Revert "[Vold] Conditional dependency to ARC++ ObbVolume"")
errantly removed the product_variables support for
-D__ANDROID_DEBUGGABLE__ when built for userdebug builds.
Restore stanza.
Signed-off-by: Mark Salyzyn <salyzyn@google.com>
Bug:
161454607
Test: adb-remount-test no longer reports a problem
Change-Id: Ia7e55d1174fa7fac2d934d4aac06d15e8be388af
Eric Biggers [Fri, 17 Jul 2020 02:18:01 +0000 (02:18 +0000)]
Merge "KeyUtil: use static local variable in isFsKeyringSupported()" am:
256b23b1c5 am:
350b5ae900 am:
d0b2751e8f am:
bbeec06aeb
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365220
Change-Id: Ie41bfaac1b1d3ea2aea9cb73c655194dc690b212
Eric Biggers [Fri, 17 Jul 2020 02:17:40 +0000 (02:17 +0000)]
Merge "vold: drop local fscrypt UAPI definitions" am:
47425d05a9 am:
83a3eecc03 am:
6b36554b38 am:
cb640677a7
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365221
Change-Id: Ie7df8fc2c5582ad23db0663d33014f86555edc1c
Eric Biggers [Fri, 17 Jul 2020 02:03:01 +0000 (02:03 +0000)]
Merge "KeyUtil: use static local variable in isFsKeyringSupported()" am:
256b23b1c5 am:
350b5ae900 am:
d0b2751e8f
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365220
Change-Id: Id61233aba34e8c67a2ab3860c4259eaeaefdab15
Eric Biggers [Fri, 17 Jul 2020 02:02:39 +0000 (02:02 +0000)]
Merge "vold: drop local fscrypt UAPI definitions" am:
47425d05a9 am:
83a3eecc03 am:
6b36554b38
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365221
Change-Id: I18cbddc92985f88d95dca71b05b9d07919134af9
Eric Biggers [Fri, 17 Jul 2020 01:50:24 +0000 (01:50 +0000)]
Merge "KeyUtil: use static local variable in isFsKeyringSupported()" am:
256b23b1c5 am:
350b5ae900
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365220
Change-Id: Ia7fca6e61c58317002271c8338bb01a12e8223a5
Eric Biggers [Fri, 17 Jul 2020 01:50:07 +0000 (01:50 +0000)]
Merge "vold: drop local fscrypt UAPI definitions" am:
47425d05a9 am:
83a3eecc03
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365221
Change-Id: Iffa50e4c549469de6425134369e609856f1d7813
Eric Biggers [Fri, 17 Jul 2020 01:38:51 +0000 (01:38 +0000)]
Merge "KeyUtil: use static local variable in isFsKeyringSupported()" am:
256b23b1c5
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365220
Change-Id: I94b778955b2ee5cd8c462050e94c39ce05c96179
Eric Biggers [Fri, 17 Jul 2020 01:38:44 +0000 (01:38 +0000)]
Merge "vold: drop local fscrypt UAPI definitions" am:
47425d05a9
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1365221
Change-Id: If47e4ced3b37e44772d802fb8ebe2d9ad51c03e2
Eric Biggers [Fri, 17 Jul 2020 01:20:43 +0000 (01:20 +0000)]
Merge "KeyUtil: use static local variable in isFsKeyringSupported()"
Eric Biggers [Fri, 17 Jul 2020 01:19:39 +0000 (01:19 +0000)]
Merge "vold: drop local fscrypt UAPI definitions"
Eric Biggers [Thu, 16 Jul 2020 23:31:00 +0000 (16:31 -0700)]
vold: drop local fscrypt UAPI definitions
Now that Bionic's copy of <linux/fscrypt.h> has been updated, there's no
need for vold to carry its own fscrypt_uapi.h.
Test: build
Change-Id: I61581ac74f7cf77bc8a835e64d96553a9d0c517a
Eric Biggers [Thu, 16 Jul 2020 21:29:59 +0000 (14:29 -0700)]
KeyUtil: use static local variable in isFsKeyringSupported()
Use C++'s built-in mechanism for one-time initialization rather than
implement it ourselves in a way that isn't thread-safe.
(It doesn't *actually* need to be thread-safe, since all callers of this
run under ACQUIRE_CRYPT_LOCK. But that's not easy to verify.)
Test: booted Cuttlefish and checked log for the one-time message
"Detected support for FS_IOC_ADD_ENCRYPTION_KEY"
Change-Id: I6ca5b143ca305fa95144e388efc9657e3507bf05
Eric Biggers [Thu, 16 Jul 2020 21:31:56 +0000 (21:31 +0000)]
Merge "vold: remove checkEncryption" am:
2d9777bfbf am:
15c0d3e5d0 am:
4cd238b900 am:
c36d0e23bb
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1363339
Change-Id: I20509d10a0534c9c2a6795c73809f02461e03b67
Eric Biggers [Thu, 16 Jul 2020 21:16:12 +0000 (21:16 +0000)]
Merge "vold: remove checkEncryption" am:
2d9777bfbf am:
15c0d3e5d0 am:
4cd238b900
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1363339
Change-Id: I862a51b219b0151c24d009921fa6cd509afa18b0
Eric Biggers [Thu, 16 Jul 2020 21:00:33 +0000 (21:00 +0000)]
Merge "vold: remove checkEncryption" am:
2d9777bfbf am:
15c0d3e5d0
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1363339
Change-Id: I23b9a01632b61a92896ae83e2152fa047dd85c48
Eric Biggers [Thu, 16 Jul 2020 20:45:57 +0000 (20:45 +0000)]
Merge "vold: remove checkEncryption" am:
2d9777bfbf
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1363339
Change-Id: I4ffa4a351292c18dce51247d926ffe7efdbd5bea
Eric Biggers [Thu, 16 Jul 2020 20:30:35 +0000 (20:30 +0000)]
Merge "vold: remove checkEncryption"
Treehugger Robot [Thu, 16 Jul 2020 12:27:09 +0000 (12:27 +0000)]
Merge "Revert "[Vold] Conditional dependency to ARC++ ObbVolume"" am:
6e6fc6b8d3 am:
11757842a3 am:
9afa4c65d8 am:
d4b94d95ab
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1320919
Change-Id: I11db3a962dbe88092f37604d91f844db31275efa
Treehugger Robot [Thu, 16 Jul 2020 12:16:19 +0000 (12:16 +0000)]
Merge "Revert "[Vold] Conditional dependency to ARC++ ObbVolume"" am:
6e6fc6b8d3 am:
11757842a3 am:
9afa4c65d8
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1320919
Change-Id: Idf5736b15c3d1cd2d2dc994e7c5298605d45412a
Treehugger Robot [Thu, 16 Jul 2020 12:03:40 +0000 (12:03 +0000)]
Merge "Revert "[Vold] Conditional dependency to ARC++ ObbVolume"" am:
6e6fc6b8d3 am:
11757842a3
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1320919
Change-Id: Iec0c1190443f1366a0f105bb3eba3967635ff544
Treehugger Robot [Thu, 16 Jul 2020 11:51:01 +0000 (11:51 +0000)]
Merge "Revert "[Vold] Conditional dependency to ARC++ ObbVolume"" am:
6e6fc6b8d3
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1320919
Change-Id: I6fb0ca30c54791549923099c1acf74667e06ae5b
Treehugger Robot [Thu, 16 Jul 2020 11:04:04 +0000 (11:04 +0000)]
Merge "Revert "[Vold] Conditional dependency to ARC++ ObbVolume""
Eric Biggers [Wed, 15 Jul 2020 18:06:02 +0000 (11:06 -0700)]
vold: remove checkEncryption
The testing-only "checkEncryption" command has been replaced with
VtsKernelEncryptionTest [1]. In particular, the metadata encryption
documentation [2] no longer mentions checkEncryption but rather
recommends running VtsKernelEncryptionTest. Also, checkEncryption
hasn't really been maintained, and it has some known bugs; it's unclear
that many people ever really used it.
So, just remove it.
[1] https://android.googlesource.com/platform/test/vts-testcase/kernel/+/refs/heads/master/encryption/
[2] https://source.android.com/security/encryption/metadata#tests
Bug:
155037012
Change-Id: I258829c60768fd11aafdf2faad956cecc1ae9826
Satoshi Niwa [Mon, 1 Jun 2020 12:03:36 +0000 (21:03 +0900)]
Revert "[Vold] Conditional dependency to ARC++ ObbVolume"
This reverts commit
aedae617fec702add64201534a2f514fa31c5965.
Reason for revert: ArcObbVolume is not needed by ARCVM R and above.
Bug:
157885448
Test: trybot
Change-Id: I16395ac8b6902cedea263f51e306b297d719043f
Automerger Merge Worker [Wed, 8 Jul 2020 00:52:08 +0000 (00:52 +0000)]
Merge "[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a -s ours am:
09b9cae24d -s ours" into rvc-d1-dev-plus-aosp am:
ee0e304091 -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
006eed8e3a is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: I5321840d6beb6cd57eaa06a5babb4c8da57a3d4a
Eric Biggers [Wed, 8 Jul 2020 00:51:31 +0000 (00:51 +0000)]
[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a am:
65aa48c810 -s ours am:
784638461d -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
006eed8e3a is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: I871c728b23ecf0f22b01f3f95336e4a7b07a0f5b
Eric Biggers [Wed, 8 Jul 2020 00:51:12 +0000 (00:51 +0000)]
[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a am:
65aa48c810 am:
1f6e9af5b1 -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
eb566d0a7c is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: I0fe158134f8aa7841997b6f91926a66f74a53d92
Automerger Merge Worker [Wed, 8 Jul 2020 00:37:31 +0000 (00:37 +0000)]
Merge "[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a -s ours am:
09b9cae24d -s ours" into rvc-d1-dev-plus-aosp
Eric Biggers [Wed, 8 Jul 2020 00:37:22 +0000 (00:37 +0000)]
[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a -s ours am:
09b9cae24d -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
eb566d0a7c is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: I7d8f6f3fd29595721ee7dfbd7a2fcabf69bc041f
Eric Biggers [Wed, 8 Jul 2020 00:37:21 +0000 (00:37 +0000)]
[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a am:
65aa48c810 -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
eb566d0a7c is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: Ifce40a4998e3fd5a116df5ed8b3ac3433eb6b83e
Eric Biggers [Wed, 8 Jul 2020 00:37:08 +0000 (00:37 +0000)]
vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a am:
65aa48c810
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: I8c417d6e1a66f987717624afbea64608c65e7980
Eric Biggers [Wed, 8 Jul 2020 00:23:19 +0000 (00:23 +0000)]
vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: Ib8656b4dbd8b39a594147aace686a3fcbd3bd0d4
Eric Biggers [Wed, 8 Jul 2020 00:22:58 +0000 (00:22 +0000)]
[automerger skipped] vold: only allow emmc_optimized on eMMC storage am:
006eed8e3a -s ours
am skip reason: Change-Id Ie27b80658db53b1a4207b3cbb4e309d05130812e with SHA-1
eb566d0a7c is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12098822
Change-Id: Id8c90f1833a171c12936a5f4aa2bf80574f5cb64
Eric Biggers [Tue, 7 Jul 2020 18:15:55 +0000 (18:15 +0000)]
Merge "vold: only allow emmc_optimized on eMMC storage" am:
428ae6e90a am:
7a1c4ccb96 am:
09f789e227 am:
4903027a20
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1356175
Change-Id: I6f8316c1eadfa2256bf515a96a45860a021ab088
Eric Biggers [Tue, 7 Jul 2020 17:59:57 +0000 (17:59 +0000)]
Merge "vold: only allow emmc_optimized on eMMC storage" am:
428ae6e90a am:
7a1c4ccb96 am:
09f789e227
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1356175
Change-Id: I277065540c289ff3a7633ebd7b0326da2da4e5a4
Eric Biggers [Tue, 7 Jul 2020 17:37:34 +0000 (17:37 +0000)]
Merge "vold: only allow emmc_optimized on eMMC storage" am:
428ae6e90a am:
7a1c4ccb96
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1356175
Change-Id: Ie124c2cec8e4235ae999463d5c03615880e0c01e
Eric Biggers [Tue, 7 Jul 2020 17:24:35 +0000 (17:24 +0000)]
Merge "vold: only allow emmc_optimized on eMMC storage" am:
428ae6e90a
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1356175
Change-Id: I95f471e6a2a96929b1ff854cac195b68e86309f3
Eric Biggers [Mon, 6 Jul 2020 20:46:38 +0000 (13:46 -0700)]
vold: only allow emmc_optimized on eMMC storage
The emmc_optimized encryption flag is specifically designed for the
limitations of inline encryption hardware that follows the eMMC
standard. It isn't appropriate to use on other types of storage.
So, make vold enforce that it's not used on other types of storage.
Bug:
160639344
Test:
- Enabled emmc_optimized on Cuttlefish and verified it no longer boots
- Using a modified version of this change, verified that
IsEmmcStorage() works as expected on various devices including
Cuttlefish, Cuttlefish booted in GSI image mode, a device with eMMC
storage, and a device with UFS storage.
- Verified that VtsKernelEncryptionTest still passes
Change-Id: Ie27b80658db53b1a4207b3cbb4e309d05130812e
Merged-In: Ie27b80658db53b1a4207b3cbb4e309d05130812e
Eric Biggers [Tue, 7 Jul 2020 17:07:58 +0000 (17:07 +0000)]
Merge "vold: only allow emmc_optimized on eMMC storage"
Eric Biggers [Mon, 6 Jul 2020 20:46:38 +0000 (13:46 -0700)]
vold: only allow emmc_optimized on eMMC storage
The emmc_optimized encryption flag is specifically designed for the
limitations of inline encryption hardware that follows the eMMC
standard. It isn't appropriate to use on other types of storage.
So, make vold enforce that it's not used on other types of storage.
Bug:
160639344
Test:
- Enabled emmc_optimized on Cuttlefish and verified it no longer boots
- Using a modified version of this change, verified that
IsEmmcStorage() works as expected on various devices including
Cuttlefish, Cuttlefish booted in GSI image mode, a device with eMMC
storage, and a device with UFS storage.
- Verified that VtsKernelEncryptionTest still passes
Change-Id: Ie27b80658db53b1a4207b3cbb4e309d05130812e
Martijn Coenen [Tue, 30 Jun 2020 10:29:54 +0000 (10:29 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
bb8a543e43 am:
cf0499038f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I136973c26c66eae2f582885e19749753cdbff7e5
Automerger Merge Worker [Tue, 30 Jun 2020 10:29:46 +0000 (10:29 +0000)]
Merge "Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
5ed648d098 am:
6589ae36c3" into rvc-qpr-dev-plus-aosp
Martijn Coenen [Tue, 30 Jun 2020 10:29:41 +0000 (10:29 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
5ed648d098 am:
c980b5387a
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I49bec11d9aa1328d5cd7b45da098d4421af6f961
Martijn Coenen [Tue, 30 Jun 2020 10:29:37 +0000 (10:29 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
5ed648d098 am:
6589ae36c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I20555c69735747460b0ffe137a116b566ef5b158
Martijn Coenen [Tue, 30 Jun 2020 10:16:24 +0000 (10:16 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
bb8a543e43
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I3ea6c81e33206ef2010af0d91456b0f78437c0ba
Martijn Coenen [Tue, 30 Jun 2020 10:16:07 +0000 (10:16 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
5ed648d098
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I98b748487dc4d517da2008dc0299f14b505273fa
Martijn Coenen [Tue, 30 Jun 2020 10:16:05 +0000 (10:16 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1 am:
5ed648d098
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: Id662a2e471b5e9f11d801a51c3495ee283f9e2bc
Martijn Coenen [Tue, 30 Jun 2020 09:57:21 +0000 (09:57 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I5cd116bfb01b0fe98dfdcd7d4b8005819ccfeb11
Martijn Coenen [Tue, 30 Jun 2020 09:57:17 +0000 (09:57 +0000)]
Configure backing device max_ratio for FUSE filesystems. am:
a485006ab1
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
12024019
Change-Id: I13d40a73f02bec902fe94ca64d825dffb7c8790a
Martijn Coenen [Mon, 29 Jun 2020 09:53:34 +0000 (11:53 +0200)]
Configure backing device max_ratio for FUSE filesystems.
By default FUSE filesystems have a max_ratio of 1%, meaning only 1% of
dirty pages on the system can belong to a FUSE filesystem before we
start writing back pages (and throttling, if writeback can't keep up).
This limit is useful for untrusted filesystems, but in our case, we
trust the FUSE filesystem. Since FUSE writes result in writes to the
lower filesystem, FUSE should take at most 50%. Let's start with
changing max_ratio to 40%, to avoid needless throttling.
Bug:
159254170
Bug:
159770752
Test: inspect /sys/class/bdi manually after boot
Change-Id: I467e3770fc4afba0a08fa480c0b86aa054c8b875
Zim [Mon, 22 Jun 2020 17:23:24 +0000 (17:23 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
0f9690e391 am:
96832d4ef8
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: I6c17bc5c5214c5a2e9573e96999f9edd4357798c
Zim [Mon, 22 Jun 2020 17:21:22 +0000 (17:21 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
0f9690e391 am:
a09ee4ff8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: I30749224177d33b8e5138a227115afd7b0468503
Zim [Mon, 22 Jun 2020 17:21:12 +0000 (17:21 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
c1f45db6e1 am:
3875f982dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: I55d927eb0b7067aea68287dd5d89383ca4a45d9b
Zim [Mon, 22 Jun 2020 17:08:58 +0000 (17:08 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
0f9690e391
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: Ib1ac130a2a4cb24c4154a43c6f989b32defb474f
Zim [Mon, 22 Jun 2020 17:07:12 +0000 (17:07 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
c1f45db6e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: Ia2a497e993ed5302f527840ed0b74fec58e994a1
Zim [Mon, 22 Jun 2020 17:06:45 +0000 (17:06 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f am:
0f9690e391
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: I5217a28692f87a407e776d5c764cf53a4c18d55e
Zim [Mon, 22 Jun 2020 16:54:44 +0000 (16:54 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: Ia3c372428ad1098785f422befac0ba833d56d6a7
Zim [Mon, 22 Jun 2020 16:53:26 +0000 (16:53 +0000)]
Unmount public volume if FUSE mount fails am:
f71707916f
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11900947
Change-Id: Ie390d39ede3dbd63012b0c5acdbcac57e0143145
Zim [Wed, 17 Jun 2020 13:56:10 +0000 (14:56 +0100)]
Unmount public volume if FUSE mount fails
Sometimes, during early boot, a public volume may be created before
the user is unlocked and the mount may fail. This mount failure does
not revert the lower fs mounts (sdcardfs and vfat). Subsequent
mount attempts will then fail because we'd attempt to mount vfat on
already mounted /mnt/media_rw/<volname>
Bug:
158489548
Test: Resilient to an artificial sleep in
StorageManagerService#completeUnlockUser to
delay user unlock longer than public volume mount
Change-Id: I9a1574596434a2eb6b2553c0c9220c2118c7e4fd
David Anderson [Fri, 19 Jun 2020 20:47:10 +0000 (20:47 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 -s ours am:
f1353b9ec4 -s ours am:
5280868006 -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
7e07c53aab is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I7f5a6d29f4320f36b3172c8e45fdd7727a2138a6
David Anderson [Fri, 19 Jun 2020 20:47:01 +0000 (20:47 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 am:
9f054be265 -s ours am:
c01c899abf -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
7e07c53aab is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: Ia9fd42e0dbee3393fdee42d8db27b96fb5b4ee12
David Anderson [Fri, 19 Jun 2020 20:46:36 +0000 (20:46 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 am:
9f054be265 am:
abf4d6a58e -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
23850d30f6 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I7f7aa0fe8fb933a16149aef38124e89bf112c971
David Anderson [Fri, 19 Jun 2020 20:33:54 +0000 (20:33 +0000)]
Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 am:
9f054be265
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I6d255fe56cc04895887417d2eced22cb0f8ea0e5
David Anderson [Fri, 19 Jun 2020 20:33:50 +0000 (20:33 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 -s ours am:
f1353b9ec4 -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
7e07c53aab is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: Ibef61ff852185c8a35fdf071f40b01b60dc371fe
David Anderson [Fri, 19 Jun 2020 20:33:37 +0000 (20:33 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 am:
9f054be265 -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
23850d30f6 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I8107dbfcea17dde5dccedb8b2abb2f8c5223c31d
David Anderson [Fri, 19 Jun 2020 20:21:48 +0000 (20:21 +0000)]
[automerger skipped] Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025 -s ours
am skip reason: Change-Id I33a691da3b99343acfc1e8ddf68a14504c3bfbe1 with SHA-1
23850d30f6 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I324e156e155f361491f963518f69a956ac23dd7f
David Anderson [Fri, 19 Jun 2020 20:21:40 +0000 (20:21 +0000)]
Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev am:
f87198e025
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11917729
Change-Id: I9169d3e70a48b2efb3884869c412519fb1393d02
David Anderson [Fri, 19 Jun 2020 20:04:54 +0000 (20:04 +0000)]
Merge "Add an isCheckpointing() binder call for adb remount." into rvc-dev
TreeHugger Robot [Thu, 18 Jun 2020 23:08:30 +0000 (23:08 +0000)]
[automerger skipped] Merge "Don't call block checkpoint functions above dm-default-key" into rvc-dev am:
14d4e7c7df am:
3c9703d0a0 am:
0b583bcf16 -s ours
am skip reason: Change-Id Ic15fadc67d306463dd0b554f679306d8f9081451 with SHA-1
67f9044ab5 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11886461
Change-Id: I8c7c0544485998e6507c211400fc33dba2ea5a52
David Anderson [Thu, 11 Jun 2020 06:51:17 +0000 (23:51 -0700)]
Add an isCheckpointing() binder call for adb remount.
This is needed so "adb remount" can avoid writing to /data during a
checkpoint.
Bug:
157540389
Test: manual test
Change-Id: I33a691da3b99343acfc1e8ddf68a14504c3bfbe1
Merged-In: I33a691da3b99343acfc1e8ddf68a14504c3bfbe1
TreeHugger Robot [Thu, 18 Jun 2020 22:56:03 +0000 (22:56 +0000)]
[automerger skipped] Merge "Don't call block checkpoint functions above dm-default-key" into rvc-dev am:
14d4e7c7df am:
3c9703d0a0 -s ours am:
ea4f2b73cf -s ours
am skip reason: Change-Id Ic15fadc67d306463dd0b554f679306d8f9081451 with SHA-1
67f9044ab5 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11886461
Change-Id: I148c3b448f6ac57bcce2d3b814e170cb60537f02
TreeHugger Robot [Thu, 18 Jun 2020 22:55:37 +0000 (22:55 +0000)]
[automerger skipped] Merge "Don't call block checkpoint functions above dm-default-key" into rvc-dev am:
14d4e7c7df -s ours am:
c6e83ca68d -s ours am:
c2369905b8 -s ours
am skip reason: Change-Id Ic15fadc67d306463dd0b554f679306d8f9081451 with SHA-1
3fe931109c is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11886461
Change-Id: I342c4e4657fab41864c7aec47712d4dcc3d1ffa9
Paul Lawrence [Thu, 18 Jun 2020 22:53:09 +0000 (22:53 +0000)]
Merge "Don't call block checkpoint functions above dm-default-key" am:
1bb7e8a928 am:
53f1d07339 am:
ebc8801fb3 am:
f2a3877555
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1330879
Change-Id: I7188ee3168814b03b8d4e951fd3e26e48a010744
TreeHugger Robot [Thu, 18 Jun 2020 22:53:01 +0000 (22:53 +0000)]
Merge "Don't call block checkpoint functions above dm-default-key" into rvc-dev am:
14d4e7c7df am:
3c9703d0a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11886461
Change-Id: Ie03214b795767065fbbe3b8ba071c68b244a0078
David Anderson [Thu, 18 Jun 2020 22:52:59 +0000 (22:52 +0000)]
Merge "Add an isCheckpointing() binder call for adb remount." am:
b50480bb96 am:
60e41b7084 am:
026ae1a9ac am:
3fe914dd6a
Original change: https://android-review.googlesource.com/c/platform/system/vold/+/
1330854
Change-Id: I3d88a258147fcc3b454e339d081159d46bd6f982
TreeHugger Robot [Thu, 18 Jun 2020 22:52:49 +0000 (22:52 +0000)]
[automerger skipped] Merge "Don't call block checkpoint functions above dm-default-key" into rvc-dev am:
14d4e7c7df am:
3c9703d0a0 -s ours
am skip reason: Change-Id Ic15fadc67d306463dd0b554f679306d8f9081451 with SHA-1
67f9044ab5 is in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/vold/+/
11886461
Change-Id: Id88e6555c441c9c88a54d5b835ea7f531cf51716