OSDN Git Service

android-x86/external-bluetooth-bluez.git
10 years agoandroid/tester-ng: Add get bdaddr and bdname success cases
Jakub Tyszkowski [Tue, 15 Jul 2014 08:24:54 +0000 (10:24 +0200)]
android/tester-ng: Add get bdaddr and bdname success cases

10 years agoandroid/tester-ng: Verify action results also for success case
Jakub Tyszkowski [Tue, 15 Jul 2014 08:24:53 +0000 (10:24 +0200)]
android/tester-ng: Verify action results also for success case

Case when we were expecting fail as action result but we got success was
not caught.

10 years agoandroid/tester-ng: Set proper callback count
Jakub Tyszkowski [Tue, 15 Jul 2014 08:24:52 +0000 (10:24 +0200)]
android/tester-ng: Set proper callback count

This was a missing piece after fixing the callback count verifying
routine.

10 years agoandroid/tester-ng: Fix for not checking callback count in step
Jakub Tyszkowski [Tue, 15 Jul 2014 08:24:51 +0000 (10:24 +0200)]
android/tester-ng: Fix for not checking callback count in step

If no callback count was set in the step, test passed despite valid properties
still waiting to be verified.

10 years agoandroid/tester-ng: Use loop for adding cases to the queue
Jakub Tyszkowski [Tue, 15 Jul 2014 08:24:50 +0000 (10:24 +0200)]
android/tester-ng: Use loop for adding cases to the queue

It will be simplier to add new cases.

10 years agocore: Add non-temporary BR/EDR devices to the kernel whitelist
Johan Hedberg [Wed, 16 Jul 2014 12:55:57 +0000 (15:55 +0300)]
core: Add non-temporary BR/EDR devices to the kernel whitelist

We want to be able to accept connections from all non-temporary devices.
We should pass these devices kernels that support the BR/EDR whitelist
(through the Add Device mgmt command).

10 years agocore: Bind connectable mode to discoverable for kernel connection control
Johan Hedberg [Wed, 16 Jul 2014 12:52:28 +0000 (15:52 +0300)]
core: Bind connectable mode to discoverable for kernel connection control

When the kernel supports the BR/EDR whitelist we don't need to always be
connectable in order to receive incoming connections. Therefore, bind
the connectable mode to the discoverable mode whenever kernel connection
control is supported.

To avoid unnecessary mgmt and HCI commands disabling discoverable is
simply done by disabling connectable as it has the effect of disabling
both settings.

10 years agocore: Rename kernel_bg_scan to kernel_conn_control
Johan Hedberg [Wed, 16 Jul 2014 12:16:45 +0000 (15:16 +0300)]
core: Rename kernel_bg_scan to kernel_conn_control

This variable will also be used for the BR/EDR whitelist handling so
rename it to something more generic.

10 years agocore: Fix unblocking all transports for dual-mode devices
Johan Hedberg [Wed, 16 Jul 2014 13:02:56 +0000 (16:02 +0300)]
core: Fix unblocking all transports for dual-mode devices

10 years agoandroid/client: Refactor stop and closing streams
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:27 +0000 (10:59 +0300)]
android/client: Refactor stop and closing streams

10 years agoandroid/client: Add mono to stereo conversion for loopback
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:26 +0000 (10:59 +0300)]
android/client: Add mono to stereo conversion for loopback

10 years agoandroid/client: Correct check for similar buffer size
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:25 +0000 (10:59 +0300)]
android/client: Correct check for similar buffer size

The new check takes into account number of channels.

10 years agoandroid/client: Add sample rate parameter when opening audio streams
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:24 +0000 (10:59 +0300)]
android/client: Add sample rate parameter when opening audio streams

Opening input/output audio streams makes use of config with sample rate.

10 years agoandroid/client: Implement read to file
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:23 +0000 (10:59 +0300)]
android/client: Implement read to file

Reads data from stream_in and write to specified file.

10 years agoandroid/client: Add loop command
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:22 +0000 (10:59 +0300)]
android/client: Add loop command

loop command makes stream_in->read() and then stream_out->write(). At
the moment buffers shall be equal.

10 years agoandroid/client: Add read command
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:21 +0000 (10:59 +0300)]
android/client: Add read command

Read command makes stream_in->read() call to Audio HAL.

10 years agoandroid/client: Add open/close input stream commands
Andrei Emeltchenko [Tue, 15 Jul 2014 07:59:20 +0000 (10:59 +0300)]
android/client: Add open/close input stream commands

10 years agomonitor: Write btsnoop before processing packet
Szymon Janc [Tue, 15 Jul 2014 12:18:18 +0000 (14:18 +0200)]
monitor: Write btsnoop before processing packet

In case of parser crash packet should still be present in
btsnoop file. This allows to reproduce crash and provide fix.

10 years agogitignore: Add android/android-tester-ng
Szymon Janc [Tue, 15 Jul 2014 10:30:37 +0000 (12:30 +0200)]
gitignore: Add android/android-tester-ng

10 years agomonitor: Exit with error if failed to open file for writing
Szymon Janc [Tue, 15 Jul 2014 10:30:36 +0000 (12:30 +0200)]
monitor: Exit with error if failed to open file for writing

10 years agoandroid/android-tester: Remove test cases replaced by tester-ng
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:22 +0000 (18:00 +0200)]
android/android-tester: Remove test cases replaced by tester-ng

Enable, Enable done, Disable, set bdname, discovery timeout, scan mode
test cases are no longer needed in android-tester because of
android-tester-ng test rewrite.

10 years agoAndroid/tester-bluetooth: Add disc_timeout set success tc
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:21 +0000 (18:00 +0200)]
Android/tester-bluetooth: Add disc_timeout set success tc

This adds discovery timeout set property success test case.

10 years agoAndroid/tester-bluetooth: Add scan_mode set success tc
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:20 +0000 (18:00 +0200)]
Android/tester-bluetooth: Add scan_mode set success tc

This adds scan_mode set property success test case.

10 years agoandroid/tester-bluetooth: Add bdname set success tc
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:19 +0000 (18:00 +0200)]
android/tester-bluetooth: Add bdname set success tc

This adds handling of property check and bdname set property success
test case. Android tester framework is enhanced by set bd name action.
Test data is enchanced by user step data which can be used inside test
case step.

10 years agoandroid/tester-bluetooth: Add disable success test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:18 +0000 (18:00 +0200)]
android/tester-bluetooth: Add disable success test case

This also adds disable action.

10 years agoandroid/tester-ng: Add property check handling
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:17 +0000 (18:00 +0200)]
android/tester-ng: Add property check handling

This adds property check handling. Existing test cases (enable, enable
done) are updated with property check. If property type/len/val is not
expected in test step its value should be set to 0/NULL. Order of
property is not considered while checking.

10 years agoandroid/tester-gatt: Add initial test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:16 +0000 (18:00 +0200)]
android/tester-gatt: Add initial test case

10 years agoandroid/tester-gatt: Initial gatt tester
Jakub Tyszkowski [Thu, 3 Jul 2014 16:00:15 +0000 (18:00 +0200)]
android/tester-gatt: Initial gatt tester

This is initial patch for android gatt HAL tester. It'll contain test
cases for gatt hal.

10 years agoandroid/tester-hidhost: Add initial test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:14 +0000 (18:00 +0200)]
android/tester-hidhost: Add initial test case

10 years agoandroid/tester-hidhost: Initial hidhost tester
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:13 +0000 (18:00 +0200)]
android/tester-hidhost: Initial hidhost tester

This is initial patch for android hidhost HAL tester. It'll contain test
cases for hidhost hal.

10 years agoandroid/tester-socket: Add initial test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:12 +0000 (18:00 +0200)]
android/tester-socket: Add initial test case

This is patch with initial test case testing setup for socket hal test
cases.

10 years agoandroid/tester-socket: Initial socket tester
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:11 +0000 (18:00 +0200)]
android/tester-socket: Initial socket tester

This is initial patch for android socket HAL tester. It'll contain test
cases for socket hal.

10 years agoandroid/tester-ng: Add double enable success test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:10 +0000 (18:00 +0200)]
android/tester-ng: Add double enable success test case

10 years agoandroid/tester-ng: Add callback mechanism
Jakub Tyszkowski [Thu, 3 Jul 2014 16:00:09 +0000 (18:00 +0200)]
android/tester-ng: Add callback mechanism

This patch adds bt_cb_data to be used for passing callback data from
asynchronous call to tester's main loop. As for now this struct contains
only state but will be extended to handle various callbacks.

10 years agoandroid/tester-bluetooth: Add enable success test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:08 +0000 (18:00 +0200)]
android/tester-bluetooth: Add enable success test case

This adds also enable action which enable bluetooth adapter.

10 years agoandroid/tester-bluetooth: Add initial test case
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:07 +0000 (18:00 +0200)]
android/tester-bluetooth: Add initial test case

This also adds handle of test steps in android tester framework like:
initializing, matching, verifyng and generic test action which
performes first step action.

10 years agoandroid/tester-bluetooth: Initial bluetooth HAL tester
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:06 +0000 (18:00 +0200)]
android/tester-bluetooth: Initial bluetooth HAL tester

This is initial patch for android bluetooth HAL tester. It'll contain
test cases for bluetooth hal using android tester framework
(tester-main). Test step actions for this and every tester should be
declared in main tester. Cohesion of test action make action function
more useful and centralized.

10 years agoandroid/tester-ng: Add android-tester-ng
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:05 +0000 (18:00 +0200)]
android/tester-ng: Add android-tester-ng

Based on past experience with android-tester, new android tester is
written from scrath with fixed all known bugs and framework
inadvertancies. Once new test case will be added, same one from old
android tester will be removed, until whole test case list will be
replaced.

10 years agoshared/tester: Add support for debug logs for tester
Grzegorz Kolodziejczyk [Thu, 3 Jul 2014 16:00:04 +0000 (18:00 +0200)]
shared/tester: Add support for debug logs for tester

It allows to print debug logs if debug mode is enabled. It could help in
case of additional debug prints need (verbose mode).

10 years agoandroid/gatt: Disallow signed write on BR/EDR connection
Szymon Janc [Mon, 14 Jul 2014 12:29:57 +0000 (14:29 +0200)]
android/gatt: Disallow signed write on BR/EDR connection

As per Core Specification 4.1 Part G p. 4.9.2 signed write without
reponse shall not be used on BR/EDR.

10 years agoandroid/gatt: Fix not sending notification for signed write
Szymon Janc [Mon, 14 Jul 2014 12:12:06 +0000 (14:12 +0200)]
android/gatt: Fix not sending notification for signed write

Signed write has no response and notificatino should be send to
Android Framework in case of write succeed.

10 years agoandroid/gatt: Fix signed write on encrypted link
Szymon Janc [Mon, 14 Jul 2014 11:52:41 +0000 (13:52 +0200)]
android/gatt: Fix signed write on encrypted link

This fix invalid setting of res instead of status in error case.

10 years agoandroid/gatt: Make signed_write_cmd similar to rest of write functions
Szymon Janc [Mon, 14 Jul 2014 11:59:07 +0000 (13:59 +0200)]
android/gatt: Make signed_write_cmd similar to rest of write functions

This avoids confusion with assigning bool to uint type.

10 years agotools/smp-tester: Add user confirmation callback
Johan Hedberg [Sun, 13 Jul 2014 13:08:43 +0000 (16:08 +0300)]
tools/smp-tester: Add user confirmation callback

10 years agobuild: Use dist_noinst_MANS for now due to an automake issue
Marcel Holtmann [Sat, 12 Jul 2014 22:06:57 +0000 (00:06 +0200)]
build: Use dist_noinst_MANS for now due to an automake issue

10 years agobuild: Add configure option for generating manual pages
Marcel Holtmann [Sat, 12 Jul 2014 21:44:22 +0000 (23:44 +0200)]
build: Add configure option for generating manual pages

10 years agoemulator: Reopen PTY master when slave closes it
Marcel Holtmann [Sat, 12 Jul 2014 17:49:13 +0000 (19:49 +0200)]
emulator: Reopen PTY master when slave closes it

10 years agotools: Use mainloop handling for btattach utility
Marcel Holtmann [Sat, 12 Jul 2014 14:42:11 +0000 (16:42 +0200)]
tools: Use mainloop handling for btattach utility

10 years agoemulator: Add support for providing a pseudo terminal
Marcel Holtmann [Sat, 12 Jul 2014 13:52:24 +0000 (15:52 +0200)]
emulator: Add support for providing a pseudo terminal

10 years agoandroid/README: Don't mention minor Android release number
Szymon Janc [Sat, 12 Jul 2014 12:40:38 +0000 (14:40 +0200)]
android/README: Don't mention minor Android release number

Minor releases are quite often and don't introduce significant changes.
There is no need pointing this here since aosp-bluez page already
provides info about latest supported minor release.

10 years agobuild: Add support for asciidoc based manual pages
Marcel Holtmann [Sat, 12 Jul 2014 12:26:10 +0000 (14:26 +0200)]
build: Add support for asciidoc based manual pages

10 years agotools: Print controller index after attaching serial port
Marcel Holtmann [Fri, 11 Jul 2014 21:02:29 +0000 (23:02 +0200)]
tools: Print controller index after attaching serial port

10 years agoandroid/gatt: Register SDP records for services
Szymon Janc [Thu, 10 Jul 2014 14:30:36 +0000 (16:30 +0200)]
android/gatt: Register SDP records for services

10 years agoshared/gatt: Add function for getting service UUID
Szymon Janc [Thu, 10 Jul 2014 14:30:35 +0000 (16:30 +0200)]
shared/gatt: Add function for getting service UUID

10 years agoandroid/gatt: Choose LE or BR/EDR based on last seen bearer
Szymon Janc [Thu, 10 Jul 2014 14:30:34 +0000 (16:30 +0200)]
android/gatt: Choose LE or BR/EDR based on last seen bearer

This allows to connect both over LE and BR/EDR bearer.

10 years agoandroid/bluetooth: Add function for checking last seen bearer
Szymon Janc [Thu, 10 Jul 2014 14:30:33 +0000 (16:30 +0200)]
android/bluetooth: Add function for checking last seen bearer

10 years agoandroid/gatt: Add support for GATT over BR/EDR
Szymon Janc [Thu, 10 Jul 2014 14:30:32 +0000 (16:30 +0200)]
android/gatt: Add support for GATT over BR/EDR

This adds listening on both LE and BR/EDR and SDP records for GAP,
GATT and DIS.

10 years agocore: Refactor dirent type getter to a shared function
Johan Hedberg [Fri, 11 Jul 2014 10:47:41 +0000 (13:47 +0300)]
core: Refactor dirent type getter to a shared function

10 years agocore: Fix filename/dirname usage & shadowing
Johan Hedberg [Fri, 11 Jul 2014 10:38:26 +0000 (13:38 +0300)]
core: Fix filename/dirname usage & shadowing

10 years agoprofiles/input: Fix usage of PATH_MAX
Johan Hedberg [Fri, 11 Jul 2014 07:38:24 +0000 (10:38 +0300)]
profiles/input: Fix usage of PATH_MAX

PATH_MAX already contains the terminating null so there's no need to +1
to it. Also, snprintf guarantees a null-terminated string so there's no
need to explicitly set a terminating character after the call.

10 years agoandroid: Fix usage of PATH_MAX
Johan Hedberg [Fri, 11 Jul 2014 07:37:34 +0000 (10:37 +0300)]
android: Fix usage of PATH_MAX

PATH_MAX already contains the terminating null so there's no need to +1
to it.

10 years agocore: Fix filename contruction with PATH_MAX and snprintf
Johan Hedberg [Fri, 11 Jul 2014 07:34:44 +0000 (10:34 +0300)]
core: Fix filename contruction with PATH_MAX and snprintf

PATH_MAX contains the terminating null, so there's no need to +1 to it.
Also, snprintf guarantees a null-terminated string, so there's no need
to explicitly set a terminating character after the call.

10 years agocore: Add support for secondary dirent type lookup
Johan Hedberg [Fri, 11 Jul 2014 07:07:03 +0000 (10:07 +0300)]
core: Add support for secondary dirent type lookup

On some systems readdir() may only return DT_UNKNOWN for the dirent
type. In such a case we need to do a secondary lookup e.g. with lstat to
figure out the real time (for our purposes we're only interested in
whether it's a directory or not).

10 years agoandroid/pts: Update PTS files for DID
Sebastian Chlad [Wed, 9 Jul 2014 12:38:13 +0000 (14:38 +0200)]
android/pts: Update PTS files for DID

Updated PICS, PIXITs and PTS tests results for DID.
PTS version 5.2. Android version 4.4.4

10 years agoandroid/pts: Update PTS files for AVCTP
Sebastian Chlad [Thu, 10 Jul 2014 12:57:45 +0000 (14:57 +0200)]
android/pts: Update PTS files for AVCTP

PICS and PIXITs updated to PTS 5.2. Regression done for Android
4.4.4.

10 years agoandroid/pts: PTS updates for A2DP
Sebastian Chlad [Tue, 8 Jul 2014 10:56:10 +0000 (12:56 +0200)]
android/pts: PTS updates for A2DP

PICS and PIXITs files checked against PTS 5.2.

10 years agoandroid/pts: Initial PTS docs for RFCOMM
Sebastian Chlad [Tue, 8 Jul 2014 14:21:26 +0000 (16:21 +0200)]
android/pts: Initial PTS docs for RFCOMM

10 years agomgmt-tester: Update expected LE-only supported settings
Johan Hedberg [Thu, 10 Jul 2014 07:13:53 +0000 (10:13 +0300)]
mgmt-tester: Update expected LE-only supported settings

10 years agoshared/att: Implement bt_att_register.
Arman Uguray [Tue, 8 Jul 2014 05:05:01 +0000 (22:05 -0700)]
shared/att: Implement bt_att_register.

This patch implements bt_att_register and the internal mechanism for invoking
registered callbacks when a non-response/non-indication PDU is received from the
remote end.

10 years agoshared/att: Remove parameters structures.
Arman Uguray [Tue, 8 Jul 2014 05:05:00 +0000 (22:05 -0700)]
shared/att: Remove parameters structures.

This patch removes the PDU encoding functionality from src/shared/att. This is
now left up to the upper layer and the responsibilities of bt_att are restricted
to handle the low-level transport and the sequential/non-sequential ATT protocol
logic.

10 years agoandroid/gatt: Set need_resp flag in when received PREP_WRITE_REQ
Marcin Kraglak [Wed, 9 Jul 2014 08:53:53 +0000 (10:53 +0200)]
android/gatt: Set need_resp flag in when received PREP_WRITE_REQ

Set need_resp flag if pepare write request have been received.
This is needed because application should send response to stack.

10 years agoandroid/gatt: Fix sending incorrect frames
Marcin Kraglak [Wed, 9 Jul 2014 08:53:52 +0000 (10:53 +0200)]
android/gatt: Fix sending incorrect frames

Don't send pdu if encoding failed. It cause errors when trying
send notification larger than MTU. Length passed to
g_attrib_send was 0 which caused errors on ATT.

10 years agomonitor: Use lowercase for additional words in field names
Marcel Holtmann [Wed, 9 Jul 2014 07:34:13 +0000 (09:34 +0200)]
monitor: Use lowercase for additional words in field names

10 years agoclient: Allow to terminate if bluetoothd was not started
Szymon Janc [Tue, 8 Jul 2014 17:52:26 +0000 (19:52 +0200)]
client: Allow to terminate if bluetoothd was not started

This allows to terminate bluetoothctl with CTRL-C if daemon didn't
start. Otherwise input is not functional and user must kill
bluetoothctl by sending signal from another terminal.

10 years agotools: Add support for firmware loading for Intel bootloader
Marcel Holtmann [Sun, 6 Jul 2014 18:34:45 +0000 (20:34 +0200)]
tools: Add support for firmware loading for Intel bootloader

10 years agotools: Reading Local Version Information is not supported for bootloader
Marcel Holtmann [Sun, 6 Jul 2014 13:00:58 +0000 (15:00 +0200)]
tools: Reading Local Version Information is not supported for bootloader

10 years agoRelease 5.21
Marcel Holtmann [Fri, 4 Jul 2014 19:09:58 +0000 (21:09 +0200)]
Release 5.21

10 years agodoc: Update list of management version 1.7 features
Marcel Holtmann [Fri, 4 Jul 2014 17:25:05 +0000 (19:25 +0200)]
doc: Update list of management version 1.7 features

10 years agomonitor: Print control settings details only if available
Marcel Holtmann [Fri, 4 Jul 2014 17:16:50 +0000 (19:16 +0200)]
monitor: Print control settings details only if available

10 years agomonitor: Decode New Configuration Options control message
Marcel Holtmann [Fri, 4 Jul 2014 17:16:26 +0000 (19:16 +0200)]
monitor: Decode New Configuration Options control message

10 years agotools: Add support for New Configuration Options mgmt event
Marcel Holtmann [Fri, 4 Jul 2014 17:10:10 +0000 (19:10 +0200)]
tools: Add support for New Configuration Options mgmt event

10 years agolib: Add definition for New Configuration Options mgmt event
Marcel Holtmann [Fri, 4 Jul 2014 17:07:43 +0000 (19:07 +0200)]
lib: Add definition for New Configuration Options mgmt event

10 years agodoc: Add description for New Configuration Options mgmt event
Marcel Holtmann [Fri, 4 Jul 2014 17:07:06 +0000 (19:07 +0200)]
doc: Add description for New Configuration Options mgmt event

10 years agotools: Add command for changing external configuration option
Marcel Holtmann [Fri, 4 Jul 2014 16:05:17 +0000 (18:05 +0200)]
tools: Add command for changing external configuration option

10 years agocore: Remove dead code
Andrei Emeltchenko [Fri, 4 Jul 2014 13:44:01 +0000 (16:44 +0300)]
core: Remove dead code

rfcomm can only be NULL in this path

10 years agocups: Remove dead code
Andrei Emeltchenko [Fri, 4 Jul 2014 13:44:00 +0000 (16:44 +0300)]
cups: Remove dead code

10 years agoandroid/gatt: Fix length check
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:59 +0000 (16:43 +0300)]
android/gatt: Fix length check

Function fill_gatt_response() has check shown below:
if (!len)
return;

This eliminates clang warning:
...
android/gatt.c:4443:3: warning: Function call argument is an
uninitialized value
                fill_gatt_response(resp_data, resp_data->handle,
...

10 years agoandroid/tester: Remove unused assignment
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:58 +0000 (16:43 +0300)]
android/tester: Remove unused assignment

Fixes clang warning:
...
android/android-tester.c:1014:2: warning: Value stored to 'status' is
never read
        status =
data->if_bluetooth->get_remote_device_property(&remote_addr, prop.type);
1 warning generated.
...

10 years agoandroid/haltest: Add check for valid channel
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:57 +0000 (16:43 +0300)]
android/haltest: Add check for valid channel

Channel is got from user and needs to be validated before use as index
in the array.

10 years agoandroid/gatt: Add missing error check
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:56 +0000 (16:43 +0300)]
android/gatt: Add missing error check

Fixes clang warning:
...
android/gatt.c:2097:4: warning: Value stored to 'srvc_search_success' is
never read
       srvc_search_success = search_dev_for_srvc(conn, NULL);
...

10 years agoandroid/hal-gatt: Remove unneeded never read initialization
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:55 +0000 (16:43 +0300)]
android/hal-gatt: Remove unneeded never read initialization

Fixes clang warning:
...
android/hal-gatt.c:1021:3: warning: Value stored to 'data' is never read
                data += service_uuid_len;
                ^       ~~~~~~~~~~~~~~~~
1 warning generated.
...

10 years agoandroid/haltest: Auto-accept pairing
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:54 +0000 (16:43 +0300)]
android/haltest: Auto-accept pairing

Simplify PTS testing by asking for pairing consent.

10 years agoandroid/gatt: Fix warning by rearranging allocation
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:53 +0000 (16:43 +0300)]
android/gatt: Fix warning by rearranging allocation

We need to allocate array of uint8_t so fix allocation parameter, this
also removes unneeded type conversion.

This fixes clang warnings:
...
android/gatt.c:5967:29: warning: Result of 'calloc' is converted to a
pointer of type 'uint8_t', which is incompatible with sizeof operand
type 'uint16_t'
        entry->value = (uint8_t *) new0(uint16_t, 1);
                        ~~~~~~~~~  ^~~~~~~~~~~~~~~~~
./src/shared/util.h:81:26: note: expanded from macro 'new0'
                         ^~~~~~      ~~~~~~~~~
...

10 years agoandroid/hal-msg: trivial: Correct coding style
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:52 +0000 (16:43 +0300)]
android/hal-msg: trivial: Correct coding style

Move rsp close to cmd improving readability of the code.

10 years agoandroid/gatt: Change DBG() to error()
Andrei Emeltchenko [Fri, 4 Jul 2014 13:43:50 +0000 (16:43 +0300)]
android/gatt: Change DBG() to error()

10 years agoandroid/gatt: Fix memory leak
Andrei Emeltchenko [Thu, 3 Jul 2014 11:32:56 +0000 (14:32 +0300)]
android/gatt: Fix memory leak

Fixes clang warnings:
...
android/gatt.c:2823:1: warning: Potential leak of memory pointed to by
'cb_data'
...

10 years agomonitor: Fix possible resource leak
Andrei Emeltchenko [Fri, 4 Jul 2014 12:45:38 +0000 (15:45 +0300)]
monitor: Fix possible resource leak

This fixes following memory leak:
...
==14887== 24 bytes in 1 blocks are definitely lost in loss record 2 of 4
==14887==    at 0x4C2CC70: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==14887==    by 0x425B6C: btsnoop_open (btsnoop.c:83)
==14887==    by 0x424837: analyze_trace (analyze.c:262)
==14887==    by 0x40249A: main (main.c:189)
...

10 years agoandroid/README: Add HealthService fix to recommended AOSP patches
Szymon Janc [Fri, 4 Jul 2014 12:33:38 +0000 (14:33 +0200)]
android/README: Add HealthService fix to recommended AOSP patches

10 years agoandroid/README: Add section with bug reporting instructions
Szymon Janc [Fri, 4 Jul 2014 12:08:14 +0000 (14:08 +0200)]
android/README: Add section with bug reporting instructions

10 years agoandroid/README: Mark health implementation as complete
Szymon Janc [Fri, 4 Jul 2014 11:29:23 +0000 (13:29 +0200)]
android/README: Mark health implementation as complete