OSDN Git Service

android-x86/packages-apps-Settings.git
5 years agoAdd correct animation
Alex Salo [Wed, 17 Apr 2019 19:25:36 +0000 (12:25 -0700)]
Add correct animation

Bug: 129352433
Test: manually
Change-Id: I381059203c477407297765936e48271519852f56

5 years agoMerge "Fixed Passpoint network "Not in range" issue and forget button" into qt-dev
Quang Luong [Wed, 17 Apr 2019 17:57:39 +0000 (17:57 +0000)]
Merge "Fixed Passpoint network "Not in range" issue and forget button" into qt-dev

5 years agoMerge "Update strings for the title of lock screen skip dialog" into qt-dev
Maurice Lam [Wed, 17 Apr 2019 17:29:49 +0000 (17:29 +0000)]
Merge "Update strings for the title of lock screen skip dialog" into qt-dev

5 years agoMerge "Turn off debug logging flags" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 17:12:39 +0000 (17:12 +0000)]
Merge "Turn off debug logging flags" into qt-dev

5 years agoMerge "Update summary lines of half condition card" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 17:09:29 +0000 (17:09 +0000)]
Merge "Update summary lines of half condition card" into qt-dev

5 years agoMerge "Default to enable oem-unlocking preference" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 16:54:19 +0000 (16:54 +0000)]
Merge "Default to enable oem-unlocking preference" into qt-dev

5 years agoMerge "Do not special case the storage permission group." into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 14:21:49 +0000 (14:21 +0000)]
Merge "Do not special case the storage permission group." into qt-dev

5 years agoTurn off debug logging flags
Yanting Yang [Wed, 17 Apr 2019 09:34:34 +0000 (17:34 +0800)]
Turn off debug logging flags

Fixes: 130558346
Test: visual
Change-Id: Ie82bfe503f789435a3474697391fdfdeb94864ee

5 years agoUpdate summary lines of half condition card
Yanting Yang [Tue, 16 Apr 2019 09:44:09 +0000 (17:44 +0800)]
Update summary lines of half condition card

To optimize the visual design for regular font size in summary field.

Fixes: 130588679
Test: visual

Change-Id: I89142f403646139b150f38b70b52b0d7b36fed9e

5 years agoMerge "Add subtitle for Do not disturb" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 09:08:17 +0000 (09:08 +0000)]
Merge "Add subtitle for Do not disturb" into qt-dev

5 years agoMerge "Remove On/Off string from Night light slice" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 09:03:07 +0000 (09:03 +0000)]
Merge "Remove On/Off string from Night light slice" into qt-dev

5 years agoMerge "Fix wrong color for rippleColor" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 08:46:46 +0000 (08:46 +0000)]
Merge "Fix wrong color for rippleColor" into qt-dev

5 years agoUpdate strings for the title of lock screen skip dialog
Pasty Chang [Wed, 17 Apr 2019 03:54:55 +0000 (03:54 +0000)]
Update strings for the title of lock screen skip dialog

First letter should be lowercase

Bug: 129870122
Test: Manual
Change-Id: If6ed383cccf56007691ca24d02919b41f1c69281

5 years agoMerge "Fix string comment" into qt-dev
TreeHugger Robot [Wed, 17 Apr 2019 03:36:26 +0000 (03:36 +0000)]
Merge "Fix string comment" into qt-dev

5 years agoMerge "The labels of button in Wi-Fi input and "skip screen lock" dialog doesn't...
Cyril Lee [Wed, 17 Apr 2019 03:20:29 +0000 (03:20 +0000)]
Merge "The labels of button in Wi-Fi input and "skip screen lock" dialog doesn't apply GlifV3 style" into qt-dev

5 years agoMerge "Retrieve WiFi detail test cases" into qt-dev
Clown SHEN [Wed, 17 Apr 2019 02:48:24 +0000 (02:48 +0000)]
Merge "Retrieve WiFi detail test cases" into qt-dev

5 years agoMerge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network...
Arc Wang [Wed, 17 Apr 2019 01:07:12 +0000 (01:07 +0000)]
Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev

5 years agoFix string comment
Kevin Chyn [Wed, 17 Apr 2019 00:02:17 +0000 (17:02 -0700)]
Fix string comment

Bug: 130642861

Test: Builds
Change-Id: Ib889b1a69b5225579ffad6f63b0d98ded9841614

5 years agoDo not special case the storage permission group.
Joel Galenson [Tue, 16 Apr 2019 22:44:52 +0000 (15:44 -0700)]
Do not special case the storage permission group.

We are now not showing storage usages in Permission Controller,
including in the API Settings uses.  We can thus remove this code so
that Settings will reflect what Permissions Hub shows.

Bug: 130567526
Test: See the same graph here and in the dashboard.
Change-Id: Iaa7d95b05f4321543ed42833ac3a7babdb9914f0

5 years agoMerge "Check for attention permissions" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 22:02:43 +0000 (22:02 +0000)]
Merge "Check for attention permissions" into qt-dev

5 years agoMerge "Enforce min value on panel slices slider" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 21:18:05 +0000 (21:18 +0000)]
Merge "Enforce min value on panel slices slider" into qt-dev

5 years agoMerge "Hide Mobile preference for secondary user" into qt-dev
Lei Yu [Tue, 16 Apr 2019 20:47:17 +0000 (20:47 +0000)]
Merge "Hide Mobile preference for secondary user" into qt-dev

5 years agoFixed Passpoint network "Not in range" issue and forget button
Quang Luong [Fri, 12 Apr 2019 19:43:48 +0000 (12:43 -0700)]
Fixed Passpoint network "Not in range" issue and forget button

Passpoint networks now correctly allow the user to connect and forget
from the saved networks network detail page.

Bug: 130373102
Test: atest WifiDetailPreferenceControllerTest

Change-Id: I6ed2817bb3a1ac657695272ceb9d5e3f3e944f16

5 years agoMerge "Add entry animation to Settings Panels." into qt-dev
Linda Tseng [Tue, 16 Apr 2019 18:57:47 +0000 (18:57 +0000)]
Merge "Add entry animation to Settings Panels." into qt-dev

5 years agoMerge "Disable Mobile settings in one condition." into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 18:20:11 +0000 (18:20 +0000)]
Merge "Disable Mobile settings in one condition." into qt-dev

5 years agoMerge "Change dark theme screen to toggle" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 18:16:54 +0000 (18:16 +0000)]
Merge "Change dark theme screen to toggle" into qt-dev

5 years agoMerge "Hide filter spinner when data is loading." into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 18:07:24 +0000 (18:07 +0000)]
Merge "Hide filter spinner when data is loading." into qt-dev

5 years agoMerge "Revert "Fix voice access issue on home page"" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 18:02:26 +0000 (18:02 +0000)]
Merge "Revert "Fix voice access issue on home page"" into qt-dev

5 years agoMerge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev
Sean Stout [Tue, 16 Apr 2019 17:47:29 +0000 (17:47 +0000)]
Merge "Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL" into qt-dev

5 years agoCheck for attention permissions
Alex Salo [Thu, 11 Apr 2019 21:41:57 +0000 (14:41 -0700)]
Check for attention permissions

If attention package does not have sufficient permissions - disable the
setting.

Bug: 130246574130350903
Test: make RunSettingsRoboTests and manually confirmed
Change-Id: Ia7a86c940522e72f7e895d6aec7500f1ef6f9889

5 years agoRetrieve WiFi detail test cases
clownshen [Tue, 16 Apr 2019 17:11:49 +0000 (01:11 +0800)]
Retrieve WiFi detail test cases

1. fix test case failure
2. remove redundant test cases

Bug: 130640128
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Change-Id: Ia59287d7f9adb37a6b56301a2178b6e307fd892d

5 years agoMerge "Use android:attr for display font preview layout background" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 17:05:43 +0000 (17:05 +0000)]
Merge "Use android:attr for display font preview layout background" into qt-dev

5 years agoMerge "Clean up NotificationChannelSlice" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 16:31:22 +0000 (16:31 +0000)]
Merge "Clean up NotificationChannelSlice" into qt-dev

5 years agoEnforce min value on panel slices slider
lindatseng [Mon, 15 Apr 2019 22:51:07 +0000 (15:51 -0700)]
Enforce min value on panel slices slider

We did not set the min value on slider slices when converting them
from preference to slices, which makes the slices all have min 0.
However, there are some slider which should have min value greater
than 0, for example, call and alarm.

We should get the min value and apply it to slider slice to make it
consistent with what we have in settings pref.

Test: Manual verification
Test: make -j40 RunSettingRobotests
Test: atest VolumeSeekBarPreferenceControllerTest
Fixes: 130439216
Fixes: 130358208
Change-Id: Ib4399c36c7da3ac41a6d46a6c150f0ec1b9b0b0f

5 years agoAdd entry animation to Settings Panels.
Matthew Fritze [Fri, 8 Mar 2019 16:15:00 +0000 (08:15 -0800)]
Add entry animation to Settings Panels.

Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.

This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)

When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.

Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.

Hence, we decide to do the following:

If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.

If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.

In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.

When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out.  Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.

The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.

Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159

Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142

5 years agoRevert "Fix voice access issue on home page"
Fan Zhang [Tue, 16 Apr 2019 16:23:02 +0000 (16:23 +0000)]
Revert "Fix voice access issue on home page"

This reverts commit 0f3049d4b74bdfe0a0d0894c4575360371b8cec5.

Reason for revert: b/129456622
Fixes: 129456622
Test: rebuild

Change-Id: Ic883722a9ebe6a2905067dc9cc503c9878acd2fc

5 years agoMerge "Tint battery fix icon" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 16:25:34 +0000 (16:25 +0000)]
Merge "Tint battery fix icon" into qt-dev

5 years agoMerge "Correct the state when prevent ringing page is launched." into qt-dev
Fan Zhang [Tue, 16 Apr 2019 15:22:26 +0000 (15:22 +0000)]
Merge "Correct the state when prevent ringing page is launched." into qt-dev

5 years agoMerge "Update switchbar background color in disabled state." into qt-dev
Fan Zhang [Tue, 16 Apr 2019 15:19:25 +0000 (15:19 +0000)]
Merge "Update switchbar background color in disabled state." into qt-dev

5 years agoMerge "Create TintDrawable in Settings." into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 15:16:26 +0000 (15:16 +0000)]
Merge "Create TintDrawable in Settings." into qt-dev

5 years agoClean up NotificationChannelSlice
Yanting Yang [Tue, 16 Apr 2019 15:08:40 +0000 (23:08 +0800)]
Clean up NotificationChannelSlice

- Remove unused variable.
- Change function interface.

Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632

5 years agoMerge "Add remote volume slider conditionally." into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 12:46:55 +0000 (12:46 +0000)]
Merge "Add remote volume slider conditionally." into qt-dev

5 years agoThe labels of button in Wi-Fi input and "skip screen lock" dialog doesn't apply GlifV...
Cyril Lee [Tue, 16 Apr 2019 09:28:46 +0000 (17:28 +0800)]
The labels of button in Wi-Fi input and "skip screen lock" dialog doesn't apply GlifV3 style

Wi-Fi dialog
https://hsv.googleplex.com/6008335912402944

"Skip screen lock?" dialog
https://hsv.googleplex.com/6299831188324352

Bug: b/112707845
Test: manual test
Change-Id: I27f747268991240faa0970ca4be4ca472f24338f

5 years agoMerge "If backup service is not available, remove Settings->Backup and Backup->"Backu...
Chandan Nath [Tue, 16 Apr 2019 11:21:10 +0000 (11:21 +0000)]
Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev

5 years agoTint battery fix icon
Raff Tsai [Mon, 15 Apr 2019 07:24:38 +0000 (15:24 +0800)]
Tint battery fix icon

Fixes: 129492004
Test: manual
Change-Id: I161284619bc47e342d78f1507ae291f7c23ad3ff

5 years agoHide filter spinner when data is loading.
Yi-Ling Chuang [Mon, 15 Apr 2019 06:52:08 +0000 (14:52 +0800)]
Hide filter spinner when data is loading.

When the filter spinner is initialized, set GONE to its visibility.
Only make it visible after network cycle data finishes loading to
avoid presenting an empty filter spinner.

Fixes: 130397929
Test: robotests
Change-Id: I740fdad35ec82bc0be386c24e53348917bf6bfba

5 years agoHide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network
Arc Wang [Tue, 16 Apr 2019 08:46:57 +0000 (16:46 +0800)]
Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network

Passpoint provisioning is much different from other Wi-Fi networks and ZXing
does not support a QR code format to share a passpoint Wi-Fi network. We
should not show any button to share a passpoint Wi-Fi network.

Bug: 130609037
Test: manual
Change-Id: Ie2538ed9e030e5aa2e88452b50b6592223ca46a8

5 years agoMerge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 08:30:30 +0000 (08:30 +0000)]
Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev

5 years agoMerge "Remove error slice from Settings in rendering time" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 05:20:58 +0000 (05:20 +0000)]
Merge "Remove error slice from Settings in rendering time" into qt-dev

5 years agoMerge "Change Content Capture strings." into qt-dev
Felipe Leme [Tue, 16 Apr 2019 04:51:24 +0000 (04:51 +0000)]
Merge "Change Content Capture strings." into qt-dev

5 years agoMerge "Rename screen aware into screen attention" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 03:17:50 +0000 (03:17 +0000)]
Merge "Rename screen aware into screen attention" into qt-dev

5 years agoMerge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev
TreeHugger Robot [Tue, 16 Apr 2019 03:12:41 +0000 (03:12 +0000)]
Merge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev

5 years agoMerge "Set WifiDialog to light theme in setup flow" into qt-dev
Pasty Chang [Tue, 16 Apr 2019 02:53:29 +0000 (02:53 +0000)]
Merge "Set WifiDialog to light theme in setup flow" into qt-dev

5 years agoChange dark theme screen to toggle
Salvador Martinez [Thu, 11 Apr 2019 21:06:08 +0000 (14:06 -0700)]
Change dark theme screen to toggle

The dark theme screen has been removed in favor of a simple
toggle with a dialog that shows up the first time a user
tries to enable dark theme when in light theme.

Test: robotests pass
Bug: 130251804
Change-Id: I48f8e24a2b2a117e5a8054c5bc0b240ba68fe1ad

5 years agoMerge "Clean up DND slice in search." into qt-dev
Fan Zhang [Tue, 16 Apr 2019 02:50:10 +0000 (02:50 +0000)]
Merge "Clean up DND slice in search." into qt-dev

5 years ago"Disallow adjust volume" restricted dialog didn't show
Edgar Wang [Mon, 15 Apr 2019 04:50:47 +0000 (12:50 +0800)]
"Disallow adjust volume" restricted dialog didn't show

root casue: VolumeSeekBarPreference & SeekBarPreference will return
false when call isSelectable() then this preference won't perform Click

Fixes: 123745455
Test: Manual & robotest
Change-Id: Iba27b503e8a272260c80bd41aecdd5cdbc39f962

5 years agoRename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL
Sean Stout [Mon, 15 Apr 2019 22:34:09 +0000 (15:34 -0700)]
Rename ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL

ACTION_VIEW_ADVANCED_POWER_USAGE_DETAIL is now ACTION_APP_BATTERY_SETTINGS

Test: adb shell am start -a \
"android.settings.VIEW_ADVANCED_POWER_USAGE_DETAIL" -d \
"package:com.google.android.deskclock" --ez \
"request_ignore_background_restriction" 1
Bug: 129901520

Change-Id: Iec103ee46863c05497f9aa53f0ae81b105fdd309

5 years agoRemove error slice from Settings in rendering time
Raff Tsai [Mon, 15 Apr 2019 09:33:55 +0000 (17:33 +0800)]
Remove error slice from Settings in rendering time

We filter error slice in EligibleCardChecker but not filter it in
SliceContextualCardRenderer, these two part should use the same
logic.

Fixes:128687331
Test: manual
Change-Id: I217bc6b578ceb36b0a67b44dc8a08ecd02771d82

5 years agoFix wrong color for rippleColor
Mill Chen [Mon, 15 Apr 2019 22:18:39 +0000 (15:18 -0700)]
Fix wrong color for rippleColor

Fixes: 130328361
Test: visual
Change-Id: Ia72387d3208f3884af229b5de33d0ca675db0213

5 years agoHide Mobile preference for secondary user
Lei Yu [Mon, 15 Apr 2019 22:10:38 +0000 (15:10 -0700)]
Hide Mobile preference for secondary user

Fixes: 128917967
Test: RunSettingsRoboTests
Change-Id: Ibb95e3f0f42a8c484807a286bc77e8764eb31fcf

5 years agoMerge "Make RadioInfo settings menu work for mSIM" into qt-dev
Jordan Liu [Mon, 15 Apr 2019 21:55:43 +0000 (21:55 +0000)]
Merge "Make RadioInfo settings menu work for mSIM" into qt-dev

5 years agoUpdate switchbar background color in disabled state.
Fan Zhang [Mon, 15 Apr 2019 21:13:16 +0000 (14:13 -0700)]
Update switchbar background color in disabled state.

Fixes: 129991749
Test: visual
Change-Id: Ief3a6a09d2ca905e30e74b7cbd6b4c1500311053

5 years agoAdd remote volume slider conditionally.
Lei Yu [Fri, 12 Apr 2019 21:23:33 +0000 (14:23 -0700)]
Add remote volume slider conditionally.

Issue before this CL:
RemoteVolumePreferenceController only return available when
it is casting, otherwise return CONDITIONALLY_UNAVAILABLE.
However slice database only index available controllers and keep
this cache. So remote slider won't be indexed if it is not casting
at that time.

As a tmp fix, this CL make controller always return available
unsearchable to make it indexed by database. However only add
that slice if it is casting.

Bug: 130124950
Test: RunSettingsRoboTests
Change-Id: I191144844d6ba7ccbe3dc1c9d19801adb978abc6

5 years agoChange Content Capture strings.
Felipe Leme [Mon, 15 Apr 2019 15:21:46 +0000 (08:21 -0700)]
Change Content Capture strings.

Test: manual verification
Bug: 129403630

Change-Id: Idfc560c78e29a0557cb009dddf98f4e1ce879f25

5 years agoIf backup service is not available, remove Settings->Backup and Backup->"Backup is...
Chandan Nath [Wed, 10 Apr 2019 16:02:02 +0000 (17:02 +0100)]
If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by
admin" from search results.

"Backup -> Backup" still appears due to the PrivacySettingsActivity. On clicking that,
we get "Backup is disabled by admin" which is OK

Bug: 129743816

Test: 1. atest -v UserBackupSettingsActivityTest
2. atest -v BackupInactivePreferenceControllerTest
3. Create and switch to secondary user. Type "backup" in settings search. Note that only
"Backup->Backup" is shown and on clicking it, we get "Backup is disabled by admin"

Change-Id: Ic13e2d745c9511cbebe27aa4c6f5cd89b277fc37

5 years agoDisable Mobile settings in one condition.
Lei Yu [Mon, 15 Apr 2019 19:28:53 +0000 (12:28 -0700)]
Disable Mobile settings in one condition.

If there is no active subscription and esim is unsupported, disable
this preference.

Bug: 129143739
Test: RunSettingsRoboTests
Change-Id: I5f8b0d95df8764a3a505aae5e26df42e9412c021

5 years agoRemove On/Off string from Night light slice
Mill Chen [Mon, 15 Apr 2019 18:40:19 +0000 (11:40 -0700)]
Remove On/Off string from Night light slice

We only deleted On/Off string from the subtitle of night light slice in
the settings search result, and still keep On/Off string for Night Light
preference.

Fixes: 130364160
Test: visual
Change-Id: Ibe7f2752f099a4ab0d4a01a205e4e8ce0a226f55

5 years agoUse android:attr for display font preview layout background
Fan Zhang [Mon, 15 Apr 2019 18:26:46 +0000 (11:26 -0700)]
Use android:attr for display font preview layout background

Fixes: 117441518
Test: visual
Change-Id: I00ba298c37e9b1dd2bf5bf0890076b204d10de94

5 years agoMerge "Hide app usage time in high usage dialog" into qt-dev
Lei Yu [Mon, 15 Apr 2019 17:54:39 +0000 (17:54 +0000)]
Merge "Hide app usage time in high usage dialog" into qt-dev

5 years agoAdd subtitle for Do not disturb
Mill Chen [Mon, 15 Apr 2019 17:26:20 +0000 (10:26 -0700)]
Add subtitle for Do not disturb

Bug: 130364160
Test: visual
Change-Id: I85507b6b269d427501f144f56ca7dc871269e6d4

5 years agoRename screen aware into screen attention
Alex Salo [Sat, 13 Apr 2019 00:21:11 +0000 (17:21 -0700)]
Rename screen aware into screen attention

Bug: 111939367
Test: make RunSettingsRoboTests, manual
Change-Id: I4f65bd11a71db6601cea418a5d89b14d91858ab4

5 years agoFix problem of multiple stacked copies of "Select SIM" dialog
Antony Sargent [Fri, 12 Apr 2019 22:08:16 +0000 (15:08 -0700)]
Fix problem of multiple stacked copies of "Select SIM" dialog

The SimDialogActivity is used to ask the user questions about which SIM
card to use for various services like calls, SMS, and data. In some
cases of SIM changes (eg when a SIM is added or removed), the telephony
stack sends a broadcast that SimSelectNotification listens for so it can
pop up a general "SIM cards changed" notification, and we additionally
want to bring up an interruptive dialog to ask the user a specific
question. This might happen for instance when we want to ask the user's
permission to turn on data on a SIM.

Recent DSDS changes in the telephony stack have meant that we
accidentally create several stacked copies of this dialog, because they
send several broadcast updates as information about SIMs asynchronously
changes. For instance, we might initially detect a SIM with a generic
name of "CARD 1", and shortly after discover the actual carrier name. So
what we really want is to put up the dialog, and update it as
information changes.

This CL makes SimDialogActivity use launchMode="singleTop" so that
additional copies of the activity won't be launched. Then it internally
enforces only showing one dialog per type of request (calls, SMS, data,
or preferred sim). If we get a request for a dialog that already exists,
we just update it instead of creating a new one for that type. So there
can still be a stack of more than one dialog, but each one will be
asking a different question.

This also refactors the monolithic, somewhat confusing code for showing
the various types of dialogs into a more clearly separated class
hierarchy, and switches to using DialogFragment for the dialog.

Fixes: 126596081
Test: manual (start with device in DSDS mode with 2 subs, remove SIM
card and re-insert it)

Change-Id: I0dbc41dc3b15015389823a24df10bbff08ec6615

5 years agoSet WifiDialog to light theme in setup flow
pastychang [Mon, 15 Apr 2019 03:58:28 +0000 (11:58 +0800)]
Set WifiDialog to light theme in setup flow

Screenshot: https://screenshot.googleplex.com/X6tkxihEWFY

Test: Manual
Bug: 130507879
Change-Id: Icca6b827cdb62387fde4c91435d4df10e2ff4d04

5 years agoMerge "[PasspointV2] Clear feature flag settings_wifi_details_saved_screen" into...
Cosmo Hsieh [Sun, 14 Apr 2019 05:51:02 +0000 (05:51 +0000)]
Merge "[PasspointV2] Clear feature flag settings_wifi_details_saved_screen" into qt-dev

5 years agoMerge "Update intent in SimNotification" into qt-dev
TreeHugger Robot [Sun, 14 Apr 2019 05:11:58 +0000 (05:11 +0000)]
Merge "Update intent in SimNotification" into qt-dev

5 years agoMerge "Launch correct enrollment activity from ChooseLock" into qt-dev
Kevin Chyn [Sun, 14 Apr 2019 04:03:54 +0000 (04:03 +0000)]
Merge "Launch correct enrollment activity from ChooseLock" into qt-dev

5 years agoMerge "Set suw description textview to fixed id" into qt-dev
Pasty Chang [Sun, 14 Apr 2019 03:53:16 +0000 (03:53 +0000)]
Merge "Set suw description textview to fixed id" into qt-dev

5 years agoLaunch correct enrollment activity from ChooseLock
Kevin Chyn [Fri, 12 Apr 2019 22:19:12 +0000 (15:19 -0700)]
Launch correct enrollment activity from ChooseLock

Test: no noticable difference when setting up fingeprint work profile

Fixes: 130397083
Change-Id: I34be5262cc52052ce25a188f19bbcc13f938ac92

5 years agoMerge "Update search bar background drawable for dark mode" into qt-dev
Fan Zhang [Sat, 13 Apr 2019 00:01:12 +0000 (00:01 +0000)]
Merge "Update search bar background drawable for dark mode" into qt-dev

5 years agoMerge changes from topic "Hide notification channel slice" into qt-dev
Fan Zhang [Fri, 12 Apr 2019 23:38:27 +0000 (23:38 +0000)]
Merge changes from topic "Hide notification channel slice" into qt-dev

* changes:
  Log interacted package from ContextualNotificationChannelSlice
  Hide notification channel slice that is interacted

5 years agoMerge "Make RadioInfo settings menu work for mSIM" into qt-dev
Jordan Liu [Fri, 12 Apr 2019 23:27:45 +0000 (23:27 +0000)]
Merge "Make RadioInfo settings menu work for mSIM" into qt-dev

5 years agoClean up DND slice in search.
Fan Zhang [Fri, 12 Apr 2019 22:31:25 +0000 (15:31 -0700)]
Clean up DND slice in search.

- Remove the controller in SoundSettings, just use the common one.
- Update a bunch of IDs so ZenModeSliceBuilder maps to the toggle
  button in zen_mode_settings.xml

This is needed so the slice intent (left target when shown in search)
is the same as what we index from search side. Previously the search
indexer is finding zen_mode from sound page but the slice itself is
reporting a deep link into zenModeSettings page.

Fixes: 130437726
Test: robotest

Change-Id: Ic41d2d93afa1f748e3282e23010199a0fa078645

5 years agoUpdate intent in SimNotification
Antony Sargent [Fri, 12 Apr 2019 23:10:52 +0000 (16:10 -0700)]
Update intent in SimNotification

When you add/remove a SIM, telephony notifies settings and we pop up a
notification. Tapping on that notification was still leading to our old
SIM cards page, but should instead lead to the Network & internet page
where we've added a bunch of new UI for doing the same sorts of
operations.

Bug: 128859223
Test: manual (remove a SIM or add a SIM in DSDS mode; a notification
telling you that sim cards have changed should pop up, clicking that
should lead to Network & internet page in settings)

Change-Id: I9c1e656dcc3e8fc9147bb99861d8fdc15ed09be9

5 years agoHide app usage time in high usage dialog
Lei Yu [Fri, 12 Apr 2019 20:03:57 +0000 (13:03 -0700)]
Hide app usage time in high usage dialog

Also update strings a little bit

Bug: 112285389
Test: Manual
Change-Id: I5c4f3e2de635eb0b880d2d3d5a1550e1af41d931

5 years agoMerge "Misc bug fixes around search bar in app list UI." into qt-dev
TreeHugger Robot [Fri, 12 Apr 2019 22:33:33 +0000 (22:33 +0000)]
Merge "Misc bug fixes around search bar in app list UI." into qt-dev

5 years agoMerge "Update panel logging to include all hide page cases" into qt-dev
TreeHugger Robot [Fri, 12 Apr 2019 22:33:24 +0000 (22:33 +0000)]
Merge "Update panel logging to include all hide page cases" into qt-dev

5 years agoMake RadioInfo settings menu work for mSIM
Jordan Liu [Tue, 2 Apr 2019 19:13:31 +0000 (12:13 -0700)]
Make RadioInfo settings menu work for mSIM

Just add a spinner to the top of the screen which lets you select the
phoneIndex. Upating this value updates the mTelephonyManager
mImsManager, and mPhoneStateListener to use the selected phoneIndex and
the subscription associated with it.

Also adds fields for current subId and default data sim subId.

Due to b/117555407, the same PhoneStateListener object can not be used
to register on different subIds, so we workaround this by recreating
the PhoneStateListener when reregistering.

Test: manual test (on single sim)
Fixes: 128033739
Change-Id: I9d6631da628351511e285afeb5b6d4331aaab7e5
Merged-In: I9d6631da628351511e285afeb5b6d4331aaab7e5

5 years agoMake RadioInfo settings menu work for mSIM
Jordan Liu [Tue, 2 Apr 2019 19:13:31 +0000 (12:13 -0700)]
Make RadioInfo settings menu work for mSIM

Just add a spinner to the top of the screen which lets you select the
phoneIndex. Upating this value updates the mTelephonyManager
mImsManager, and mPhoneStateListener to use the selected phoneIndex and
the subscription associated with it.

Also adds fields for current subId and default data sim subId.

Due to b/117555407, the same PhoneStateListener object can not be used
to register on different subIds, so we workaround this by recreating
the PhoneStateListener when reregistering.

Test: manual test (on single sim)
Fixes: 128033739
Change-Id: Id075e3bffe20523d8ceeb8f2e4320f995abdab55
Merged-In: I9d6631da628351511e285afeb5b6d4331aaab7e5

5 years agoMerge "Fix null App name in Wi-Fi scanning prompt dialog" into qt-dev
TreeHugger Robot [Fri, 12 Apr 2019 21:27:37 +0000 (21:27 +0000)]
Merge "Fix null App name in Wi-Fi scanning prompt dialog" into qt-dev

5 years agoMisc bug fixes around search bar in app list UI.
Fan Zhang [Fri, 12 Apr 2019 20:27:20 +0000 (13:27 -0700)]
Misc bug fixes around search bar in app list UI.

- Turn off DEBUG log flag, it's spammy and is a potential PII risk.
- Save search bar expand state so it stays open during screen rotation.
- Introduce a intent extra so callers can deep link into this UI with
  search bar pre-expanded.

Fixes: 130422388
Test: robotest
Change-Id: Ib81080733707306de516c49340571c543e70874e

5 years agoUpdate panel logging to include all hide page cases
lindatseng [Fri, 12 Apr 2019 17:42:09 +0000 (10:42 -0700)]
Update panel logging to include all hide page cases

The old logging only include see_more, done, and clicked_out when hiding
the panel page.  We were missing many cases that user might use back
button, app switch button to close the page.

Update the hide page keys to change the clicked_out to others to
include all the other cases which hide the page.

Test: Manual verification
Test: atest PanelFragmentTest SettingsPanelActivityTest
Fixes: 130169553
Change-Id: Icede9a8dcb84565cba183963c9fb554507631c98

5 years agoMerge "Set the theme in BiometricEnrollIntroduction" into qt-dev
Maurice Lam [Fri, 12 Apr 2019 17:59:42 +0000 (17:59 +0000)]
Merge "Set the theme in BiometricEnrollIntroduction" into qt-dev

5 years agoMerge "Disable icon for NetworkOperatorPreference" into qt-dev
Lei Yu [Fri, 12 Apr 2019 17:44:59 +0000 (17:44 +0000)]
Merge "Disable icon for NetworkOperatorPreference" into qt-dev

5 years agoFix null App name in Wi-Fi scanning prompt dialog
cosmohsieh [Tue, 9 Apr 2019 06:02:07 +0000 (14:02 +0800)]
Fix null App name in Wi-Fi scanning prompt dialog

App name of the dialog msg is null because getCallingPackage() is null
when calling activity does not use startActvitiyForResult().

Bug: 112248584
Test: manual
Change-Id: If5ba9eb62f895c66ac1839b4be5c372ecba6699c

5 years ago[PasspointV2] Clear feature flag settings_wifi_details_saved_screen
cosmohsieh [Thu, 11 Apr 2019 03:21:10 +0000 (11:21 +0800)]
[PasspointV2] Clear feature flag settings_wifi_details_saved_screen

Clear feature flag settings_wifi_details_saved_screen

Bug: b/128369527
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: Ib8fc9c9eb52bee12d6501a2041c32aa60c80e70e

5 years agoUpdate search bar background drawable for dark mode
Yanting Yang [Thu, 11 Apr 2019 15:30:31 +0000 (23:30 +0800)]
Update search bar background drawable for dark mode

Bug: 129996634
Test: visual

Change-Id: I1657b1b570bf79ad776ae80b2f2878e4f4d72481

5 years agoSet suw description textview to fixed id
pastychang [Fri, 12 Apr 2019 08:22:17 +0000 (16:22 +0800)]
Set suw description textview to fixed id

Heavy theme supports to costomize description text style. Modify it to fixed id
that can be customized by partner resource.

Heavy theme screenshot: https://screenshot.googleplex.com/TL4M7wmTaPg
Set fixed id screenshot: https://screenshot.googleplex.com/CA6QHoNTQBZ

Test: atest
Bug: 121988926
Change-Id: I8882acd49e7d57f24afa9dd6f3e9abfd06556053

5 years agoLog interacted package from ContextualNotificationChannelSlice
Yanting Yang [Thu, 28 Mar 2019 16:38:56 +0000 (00:38 +0800)]
Log interacted package from ContextualNotificationChannelSlice

Fixes:129726858
Test: visual, robotests
Change-Id: Ife4043fe0bcb52445e8e2efec20781ce43c54fef

5 years agoHide notification channel slice that is interacted
Yanting Yang [Mon, 8 Apr 2019 12:30:02 +0000 (20:30 +0800)]
Hide notification channel slice that is interacted

- Ignore interacted package in ContextualNotificationChannelSlice.
- Regularly clear package record with background worker.

Bug:129726858
Test: visual, robotests

Change-Id: I94661a53bcbbe4a15479224c33cfb2eff345aa67

5 years agoMerge "Import translations. DO NOT MERGE" into qt-dev
TreeHugger Robot [Fri, 12 Apr 2019 06:11:17 +0000 (06:11 +0000)]
Merge "Import translations. DO NOT MERGE" into qt-dev