OSDN Git Service
Bruce Momjian [Fri, 11 Dec 2009 02:21:21 +0000 (02:21 +0000)]
Properly define ENABLE_THREAD_SAFETY in conflgure, per suggestion from Peter.
Andrew Dunstan [Fri, 11 Dec 2009 01:33:35 +0000 (01:33 +0000)]
Add YAML to list of EXPLAIN formats. Greg Sabino Mullane, reviewed by Takahiro Itagaki.
Peter Eisentraut [Thu, 10 Dec 2009 20:43:40 +0000 (20:43 +0000)]
PL/Python array support
Support arrays as parameters and return values of PL/Python functions.
Peter Eisentraut [Thu, 10 Dec 2009 06:32:28 +0000 (06:32 +0000)]
Add init[db] option to pg_ctl
pg_ctl gets a new mode that runs initdb. Adjust the documentation a bit to
not assume that initdb is the only way to run database cluster initialization.
But don't replace initdb as the canonical way.
Author: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Robert Haas [Thu, 10 Dec 2009 01:54:17 +0000 (01:54 +0000)]
Fix levenshtein with costs. The previous code multiplied by the cost in only
3 of the 7 relevant locations.
Marcin Mank, slightly adjusted by me.
Tom Lane [Thu, 10 Dec 2009 00:31:14 +0000 (00:31 +0000)]
Update release notes for releases 8.4.2, 8.3.9, 8.2.15, 8.1.19, 8.0.23,
7.4.27.
Tom Lane [Wed, 9 Dec 2009 21:57:51 +0000 (21:57 +0000)]
Prevent indirect security attacks via changing session-local state within
an allegedly immutable index function. It was previously recognized that
we had to prevent such a function from executing SET/RESET ROLE/SESSION
AUTHORIZATION, or it could trivially obtain the privileges of the session
user. However, since there is in general no privilege checking for changes
of session-local state, it is also possible for such a function to change
settings in a way that might subvert later operations in the same session.
Examples include changing search_path to cause an unexpected function to
be called, or replacing an existing prepared statement with another one
that will execute a function of the attacker's choosing.
The present patch secures VACUUM, ANALYZE, and CREATE INDEX/REINDEX against
these threats, which are the same places previously deemed to need protection
against the SET ROLE issue. GUC changes are still allowed, since there are
many useful cases for that, but we prevent security problems by forcing a
rollback of any GUC change after completing the operation. Other cases are
handled by throwing an error if any change is attempted; these include temp
table creation, closing a cursor, and creating or deleting a prepared
statement. (In 7.4, the infrastructure to roll back GUC changes doesn't
exist, so we settle for rejecting changes of "search_path" in these contexts.)
Original report and patch by Gurjeet Singh, additional analysis by
Tom Lane.
Security: CVE-2009-4136
Magnus Hagander [Wed, 9 Dec 2009 17:03:30 +0000 (17:03 +0000)]
Add notes about updating disk and shared memory size information in the
documentation when doing new major release.
Magnus Hagander [Wed, 9 Dec 2009 16:16:34 +0000 (16:16 +0000)]
Update size references in installation instructions to be a bit
more up-to-date with current versions.
Magnus Hagander [Wed, 9 Dec 2009 06:37:06 +0000 (06:37 +0000)]
Reject certificates with embedded NULLs in the commonName field. This stops
attacks where an attacker would put <attack>\0<propername> in the field and
trick the validation code that the certificate was for <attack>.
This is a very low risk attack since it reuqires the attacker to trick the
CA into issuing a certificate with an incorrect field, and the common
PostgreSQL deployments are with private CAs, and not external ones. Also,
default mode in 8.4 does not do any name validation, and is thus also not
vulnerable - but the higher security modes are.
Backpatch all the way. Even though versions 8.3.x and before didn't have
certificate name validation support, they still exposed this field for
the user to perform the validation in the application code, and there
is no way to detect this problem through that API.
Security: CVE-2009-4034
Tom Lane [Wed, 9 Dec 2009 00:35:32 +0000 (00:35 +0000)]
Update time zone data files to tzdata release 2009s: DST law changes in
Antarctica, Argentina, Bangladesh, Fiji, Novokuznetsk, Pakistan, Palestine,
Samoa, Syria. Also historical corrections for Hong Kong.
Magnus Hagander [Tue, 8 Dec 2009 20:08:30 +0000 (20:08 +0000)]
Fix a couple of broken links to third-party sites.
Magnus Hagander [Tue, 8 Dec 2009 19:22:43 +0000 (19:22 +0000)]
Replace broken link to custom local gettext package with one to the main
GNU site for gettext.
Magnus Hagander [Mon, 7 Dec 2009 19:19:56 +0000 (19:19 +0000)]
Update CVS documentation to be more current and add documentation about
git mirror.
Remove information about cvsup and documentation that's more about cvs
than our use of cvs.
Backpatch to 8.4 so we get the git information up on the website as
soon as possible.
Tom Lane [Mon, 7 Dec 2009 05:22:23 +0000 (05:22 +0000)]
Add exclusion constraints, which generalize the concept of uniqueness to
support any indexable commutative operator, not just equality. Two rows
violate the exclusion constraint if "row1.col OP row2.col" is TRUE for
each of the columns in the constraint.
Jeff Davis, reviewed by Robert Haas
Tom Lane [Sun, 6 Dec 2009 02:55:54 +0000 (02:55 +0000)]
Don't use a duplicate OID for aclexplode().
Peter Eisentraut [Sat, 5 Dec 2009 21:43:36 +0000 (21:43 +0000)]
Speed up information schema privilege views
Instead of expensive cross joins to resolve the ACL, add table-returning
function aclexplode() that expands the ACL into a useful form, and join
against that.
Also, implement the role_*_grants views as a thin layer over the respective
*_privileges views instead of essentially repeating the same code twice.
fixes bug #4596
by Joachim Wieland, with cleanup by me
Peter Eisentraut [Sat, 5 Dec 2009 21:31:05 +0000 (21:31 +0000)]
Information schema documentation
Add a sentence of documentation about the differences between the
*_privileges and the role_*_grants views.
Heikki Linnakangas [Thu, 3 Dec 2009 11:03:29 +0000 (11:03 +0000)]
Fix bug in temporary file management with subtransactions. A cursor opened
in a subtransaction stays open even if the subtransaction is aborted, so
any temporary files related to it must stay alive as well. With the patch,
we use ResourceOwners to track open temporary files and don't automatically
close them at subtransaction end (though in the normal case temporary files
are registered with the subtransaction resource owner and will therefore be
closed).
At end of top transaction, we still check that there's no temporary files
marked as close-at-end-of-transaction open, but that's now just a debugging
cross-check as the resource owner cleanup should've closed them already.
Tom Lane [Wed, 2 Dec 2009 21:11:12 +0000 (21:11 +0000)]
Clarify what's supposed to happen when a cursor FETCH is rolled back
by aborting a subtransaction. Per discussion with Heikki.
Bruce Momjian [Wed, 2 Dec 2009 14:07:26 +0000 (14:07 +0000)]
thread-safety
Apply full patch to enable thread-safety by default, e.g. doc changes.
Teodor Sigaev [Wed, 2 Dec 2009 13:13:24 +0000 (13:13 +0000)]
Preventing intersection of ranges during page split. Changes are only
optimization, so don't backpatch.
Tom Lane [Wed, 2 Dec 2009 04:54:10 +0000 (04:54 +0000)]
Mark application_name as GUC_REPORT so that the value will be reported back
to the client by the server. This might seem pretty pointless but apparently
it will help pgbouncer, and perhaps other connection poolers. Anyway it's
practically free to do so for the normal use-case where appname is only set
in the startup packet --- we're just adding a few more bytes to the initial
ParameterStatus response packet. Per comments from Marko Kreen.
Tom Lane [Wed, 2 Dec 2009 04:38:35 +0000 (04:38 +0000)]
Instead of sending application_name as a SET command after the connection
is made, include it in the startup-packet options. This makes it work more
like every other libpq connection option, in particular it now has the same
response to RESET ALL as the rest. This also saves one network round trip
for new applications using application_name. The cost is that if the server
is pre-8.5, it'll reject the startup packet altogether, forcing us to retry
the entire connection cycle. But on balance we shouldn't be optimizing that
case in preference to the behavior with a new server, especially when doing
so creates visible behavioral oddities. Per discussion.
Bruce Momjian [Tue, 1 Dec 2009 23:02:44 +0000 (23:02 +0000)]
Enable thread safety
Enable thread safety on all platforms. This will either be followed up
by a more extensive patch, or reverted, depending on the build farm
results.
Bruce Momjian [Tue, 1 Dec 2009 22:34:33 +0000 (22:34 +0000)]
psql -f -
Adjust psql -f - to behave like a normal file and honor the -1 flag.
Report from Robert Haas
Tom Lane [Tue, 1 Dec 2009 21:00:24 +0000 (21:00 +0000)]
Teach the regular expression functions to do case-insensitive matching and
locale-dependent character classification properly when the database encoding
is UTF8.
The previous coding worked okay in single-byte encodings, or in any case for
ASCII characters, but failed entirely on multibyte characters. The fix
assumes that the <wctype.h> functions use Unicode code points as the wchar
representation for Unicode, ie, wchar matches pg_wchar.
This is only a partial solution, since we're still stupid about non-ASCII
characters in multibyte encodings other than UTF8. The practical effect
of that is limited, however, since those cases are generally Far Eastern
glyphs for which concepts like case-folding don't apply anyway. Certainly
all or nearly all of the field reports of problems have been about UTF8.
A more general solution would require switching to the platform's wchar
representation for all regex operations; which is possible but would have
substantial disadvantages. Let's try this and see if it's sufficient in
practice.
Bruce Momjian [Tue, 1 Dec 2009 02:31:13 +0000 (02:31 +0000)]
Revert due to Tom's concerns:
Add ProcessUtility_hook() to handle all DDL to
contrib/pg_stat_statements.
Bruce Momjian [Tue, 1 Dec 2009 01:08:46 +0000 (01:08 +0000)]
ProcessUtility_hook:
Add ProcessUtility_hook() to handle all DDL to contrib/pg_stat_statements.
Itagaki Takahiro
Bruce Momjian [Mon, 30 Nov 2009 17:56:09 +0000 (17:56 +0000)]
hstore docs
Update hstore docs, mostly word-smithing.
David E. Wheeler
Bruce Momjian [Mon, 30 Nov 2009 16:50:38 +0000 (16:50 +0000)]
THREAD_SUPPORT
There is no reference to THREAD_SUPPORT outside configure, and it is
never set, so remove it.
Tom Lane [Mon, 30 Nov 2009 16:38:31 +0000 (16:38 +0000)]
Avoid core dump on empty thesaurus dictionary.
Per report from Robert Gravsjö.
Peter Eisentraut [Mon, 30 Nov 2009 15:49:35 +0000 (15:49 +0000)]
In SRF example, move oldcontext variable definition into the FIRSTCALL
branch, which is how most actual code is actually structured. Also fix
slight whitespace misalignment.
Bruce Momjian [Mon, 30 Nov 2009 14:47:37 +0000 (14:47 +0000)]
Properly indent SGML.
Tom Lane [Sun, 29 Nov 2009 21:02:16 +0000 (21:02 +0000)]
Fix session-lifespan memory leak when a plperl function is redefined:
we have to tell Perl it can release its compiled copy of the function
text. Noted by Alexey Klyukin.
Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.
Peter Eisentraut [Sun, 29 Nov 2009 20:14:53 +0000 (20:14 +0000)]
Error when a specified connection service is not found, instead of ignoring it
Tom Lane [Sun, 29 Nov 2009 18:53:54 +0000 (18:53 +0000)]
Add some opr_sanity checks that the lengths of the various argument-info
arrays in a pg_proc entry match. Seems like an easy mistake to make when
manually adjusting these values in a pg_proc.h entry.
Peter Eisentraut [Sun, 29 Nov 2009 18:53:44 +0000 (18:53 +0000)]
Remove prefix "ERROR:" from some messages, to make everything consistent
Tom Lane [Sun, 29 Nov 2009 18:14:32 +0000 (18:14 +0000)]
Make pg_stat_activity.application_name visible to all users, rather than
being hidden when current_query is. Relocate it to a column position
more consistent with that behavior. Per discussion.
Tom Lane [Sun, 29 Nov 2009 03:02:27 +0000 (03:02 +0000)]
Add support for anonymous code blocks (DO blocks) to PL/Perl.
Joshua Tolley, reviewed by Brendan Jurd and Tim Bunce
Tom Lane [Sat, 28 Nov 2009 23:38:08 +0000 (23:38 +0000)]
Add support for an application_name parameter, which is displayed in
pg_stat_activity and recorded in log entries.
Dave Page, reviewed by Andres Freund
Bruce Momjian [Sat, 28 Nov 2009 16:21:31 +0000 (16:21 +0000)]
fsync test tools
Add link to exteran fsync testing script and our fsync test tool.
Bruce Momjian [Sat, 28 Nov 2009 15:04:54 +0000 (15:04 +0000)]
test_fsync:
Improve test descriptions displayed during test_fsync; increase default
loops to 5k.
Tom Lane [Sat, 28 Nov 2009 00:46:19 +0000 (00:46 +0000)]
Eliminate a lot of list-management overhead within join_search_one_level
by adding a requirement that build_join_rel add new join RelOptInfos to the
appropriate list immediately at creation. Per report from Robert Haas,
the list_concat_unique_ptr() calls that this change eliminates were taking
the lion's share of the runtime in larger join problems. This doesn't do
anything to fix the fundamental combinatorial explosion in large join
problems, but it should push out the threshold of pain a bit further.
Note: because this changes the order in which joinrel lists are built,
it might result in changes in selected plans in cases where different
alternatives have exactly the same costs. There is one example in the
regression tests.
Bruce Momjian [Fri, 27 Nov 2009 17:41:26 +0000 (17:41 +0000)]
Document ath vacuumdb --analyze does analyze _also_, not in place of
vacuum.
Michael Meskes [Fri, 27 Nov 2009 16:07:22 +0000 (16:07 +0000)]
Remove */ characters from declare cursor statements before putting them into a
comment.
Michael Meskes [Fri, 27 Nov 2009 13:32:17 +0000 (13:32 +0000)]
If no result is given NOTFOUND should be returned. Check for empty result
string too.
Michael Meskes [Fri, 27 Nov 2009 10:00:40 +0000 (10:00 +0000)]
Added script to check if all rule re-definition in ecpg.addons are indeed used
in the build process. If not the build process will stop with an error message.
Tom Lane [Thu, 26 Nov 2009 21:20:12 +0000 (21:20 +0000)]
Fix missing end tag, per Jeff Davis.
Michael Meskes [Thu, 26 Nov 2009 15:55:57 +0000 (15:55 +0000)]
Added missing files.
Michael Meskes [Thu, 26 Nov 2009 15:40:43 +0000 (15:40 +0000)]
Forgot to add dynamic cursors to Changelog.
Michael Meskes [Thu, 26 Nov 2009 15:39:26 +0000 (15:39 +0000)]
Synced addon rules after some renamings.
Michael Meskes [Thu, 26 Nov 2009 15:06:47 +0000 (15:06 +0000)]
Added dynamic cursor names to ecpg. Almost the whole patch was done by
Boszormenyi Zoltan, with only a minor tweak or two from me.
Tom Lane [Wed, 25 Nov 2009 20:26:31 +0000 (20:26 +0000)]
Simplify psql's new linestyle behavior to default to linestyle=ascii all
the time, rather than hoping we can tell whether the terminal supports
UTF8 characters. Per discussion.
Peter Eisentraut [Tue, 24 Nov 2009 19:21:15 +0000 (19:21 +0000)]
Fix syntax in extract() examples
Author: Erik Rijkers <er@xs4all.nl>
Michael Meskes [Tue, 24 Nov 2009 16:30:31 +0000 (16:30 +0000)]
Made function better readable.
Peter Eisentraut [Mon, 23 Nov 2009 21:41:20 +0000 (21:41 +0000)]
Add PG_MODULE_MAGIC and some missing include files to examples
Author: Euler Taveira de Oliveira <euler@timbira.com>
Tom Lane [Mon, 23 Nov 2009 16:02:24 +0000 (16:02 +0000)]
Use diff's -w switch only on Windows, to avoid problems with inconsistent
newline representations. Per buildfarm results and subsequent discussion.
Sync up a couple of other places that had their own policies.
Magnus Hagander [Mon, 23 Nov 2009 12:54:37 +0000 (12:54 +0000)]
Add missing library to standalone libpq build on Win32.
Hiroshi Saito
Heikki Linnakangas [Mon, 23 Nov 2009 09:58:36 +0000 (09:58 +0000)]
Fix an old bug in multixact and two-phase commit. Prepared transactions can
be part of multixacts, so allocate a slot for each prepared transaction in
the "oldest member" array in multixact.c. On PREPARE TRANSACTION, transfer
the oldest member value from the current backends slot to the prepared xact
slot. Also save and recover the value from the 2pc state file.
The symptom of the bug was that after a transaction prepared, a shared lock
still held by the prepared transaction was sometimes ignored by other
transactions.
Fix back to 8.1, where both 2PC and multixact were introduced.
Tom Lane [Sun, 22 Nov 2009 22:06:30 +0000 (22:06 +0000)]
Assorted wordsmithing on the documentation of \pset --- try to make it
a bit more consistent and less obviously written by different people at
different times.
Tom Lane [Sun, 22 Nov 2009 20:58:51 +0000 (20:58 +0000)]
Adjust expected-results spacing per buildfarm results.
Tom Lane [Sun, 22 Nov 2009 17:54:23 +0000 (17:54 +0000)]
Remove -w (--ignore-all-space) option from pg_regress's diff calls.
We have used -w for a long time as a means of reducing the reported diff
volume when one element of a result table isn't of the expected width.
However, most of the time the results just pass anyway, so this isn't as
important as it once was. Meanwhile, the risk of missing potentially
significant deviations has gone up, particularly with psql's ability to
report error cursor positions. So, let's switch over to space-sensitive
comparisons. Per my proposal of yesterday.
(All the expected files that I can test here seem to be ready for this
already, but we'll see what the buildfarm thinks about others.)
Heikki Linnakangas [Sun, 22 Nov 2009 14:54:31 +0000 (14:54 +0000)]
Remove superfluous curly brace, fixing compilation with OPTIMIZER_DEBUG.
Jan Urbanski
Tom Lane [Sun, 22 Nov 2009 06:01:09 +0000 (06:01 +0000)]
Ooops, forgot to check the libxml cases for psql output wrapping change.
Tom Lane [Sun, 22 Nov 2009 05:20:41 +0000 (05:20 +0000)]
Improve psql's tabular display of wrapped-around data by inserting markers
in the formerly-always-blank columns just to left and right of the data.
Different marking is used for a line break caused by a newline in the data
than for a straight wraparound. A newline break is signaled by a "+" in the
right margin column in ASCII mode, or a carriage return arrow in UNICODE mode.
Wraparound is signaled by a dot in the right margin as well as the following
left margin in ASCII mode, or an ellipsis symbol in the same places in UNICODE
mode. "\pset linestyle old-ascii" is added to make the previous behavior
available if anyone really wants it.
In passing, this commit also cleans up a few regression test files that
had unintended spacing differences from the current actual output.
Roger Leigh, reviewed by Gabrielle Roth and other members of PDXPUG.
Peter Eisentraut [Sat, 21 Nov 2009 23:59:12 +0000 (23:59 +0000)]
Ignore UTF-8-encoded Unicode byte-order mark at the beginning of a file if
the client encoding is UTF-8.
a limited version of a patch proposed by Itagaki Takahiro
Tom Lane [Sat, 21 Nov 2009 05:44:05 +0000 (05:44 +0000)]
Refactor ecpg grammar so that it uses the core grammar's unreserved_keyword
list, minus a few specific words that have to be treated specially. This
replaces a hard-wired list of keywords that would have needed manual
maintenance, and was not getting it. The 8.4 coding was already missing
these words, causing ecpg to incorrectly treat them as reserved words:
CALLED, CATALOG, DEFINER, ENUM, FOLLOWING, INVOKER, OPTIONS, PARTITION,
PRECEDING, RANGE, SECURITY, SERVER, UNBOUNDED, WRAPPER. In HEAD we were
additionally missing COMMENTS, FUNCTIONS, SEQUENCES, TABLES.
Per gripe from Bosco Rama.
Tom Lane [Fri, 20 Nov 2009 20:38:12 +0000 (20:38 +0000)]
Add a WHEN clause to CREATE TRIGGER, allowing a boolean expression to be
checked to determine whether the trigger should be fired.
For BEFORE triggers this is mostly a matter of spec compliance; but for AFTER
triggers it can provide a noticeable performance improvement, since queuing of
a deferred trigger event and re-fetching of the row(s) at end of statement can
be short-circuited if the trigger does not need to be fired.
Takahiro Itagaki, reviewed by KaiGai Kohei.
Peter Eisentraut [Thu, 19 Nov 2009 22:05:48 +0000 (22:05 +0000)]
Typo: dump -> restore
fixed in 8.4 and 8.5
Author: Guillaume Lelarge <guillaume@lelarge.info>
Tom Lane [Thu, 19 Nov 2009 02:45:33 +0000 (02:45 +0000)]
Fix memory leak in syslogger: logfile_rotate() would leak a copy of the
output filename if CSV logging was enabled and only one of the two possible
output files got rotated during a particular call (which would, in fact,
typically be the case during a size-based rotation). This would amount to
about MAXPGPATH (1KB) per rotation, and it's been there since the CSV
code was put in, so it's surprising that nobody noticed it before.
Per bug #5196 from Thomas Poindessous.
Tom Lane [Wed, 18 Nov 2009 21:57:56 +0000 (21:57 +0000)]
Add a hook to CREATE/ALTER ROLE to allow an external module to check the
strength of database passwords, and create a sample implementation of
such a hook as a new contrib module "passwordcheck".
Laurenz Albe, reviewed by Takahiro Itagaki
Tom Lane [Mon, 16 Nov 2009 21:32:07 +0000 (21:32 +0000)]
Provide a parenthesized-options syntax for VACUUM, analogous to that recently
adopted for EXPLAIN. This will allow additional options to be implemented
in future without having to make them fully-reserved keywords. The old syntax
remains available for existing options, however.
Itagaki Takahiro
Tom Lane [Mon, 16 Nov 2009 18:04:40 +0000 (18:04 +0000)]
While doing the final setrefs.c pass over a plan tree, try to match up
non-Var sort/group expressions using ressortgroupref labels instead of
depending entirely on equal()-ity of the upper node's tlist expressions
to the lower node's. This avoids emitting the wrong outputs in cases
where there are textually identical volatile sort/group expressions,
as for example
select distinct random(),random() from generate_series(1,10);
Per report from Andrew Gierth.
Backpatch to 8.4. Arguably this is wrong all the way back, but the only known
case where there's an observable problem is when using hash aggregation to
implement DISTINCT, which is new as of 8.4. So for the moment I'll refrain
from backpatching further.
Peter Eisentraut [Sun, 15 Nov 2009 13:57:01 +0000 (13:57 +0000)]
Make text search parser accept underscores in XML attributes (bug #5075)
Tom Lane [Sun, 15 Nov 2009 02:45:35 +0000 (02:45 +0000)]
Improve planning of Materialize nodes inserted atop the inner input of a
mergejoin to shield it from doing mark/restore and refetches. Put an explicit
flag in MergePath so we can centralize the logic that knows about this,
and add costing logic that considers using Materialize even when it's not
forced by the previously-existing considerations. This is in response to
a discussion back in August that suggested that materializing an inner
indexscan can be helpful when the refetch percentage is high enough.
Tom Lane [Sat, 14 Nov 2009 18:24:32 +0000 (18:24 +0000)]
Make unaccent's install/uninstall scripts look more like all the others.
Set search_path explicitly, don't use IF EXISTS, etc.
Magnus Hagander [Sat, 14 Nov 2009 15:39:36 +0000 (15:39 +0000)]
Add inheritable ACE when creating a restricted token for execution on
Win32.
Also refactor the code around it to be more clear.
Jesse Morris
Tom Lane [Fri, 13 Nov 2009 23:49:23 +0000 (23:49 +0000)]
Clean up a couple of bizarre code formatting choices in recent CREATE LIKE patch.
Tom Lane [Fri, 13 Nov 2009 23:44:19 +0000 (23:44 +0000)]
Avoid assuming that enum CreateStmtLikeOption is unsigned. Zdenek Kotala
Tom Lane [Fri, 13 Nov 2009 22:43:42 +0000 (22:43 +0000)]
Add control knobs for plpgsql's variable resolution behavior, and make the
default be "throw error on conflict", as per discussions. The GUC variable
is plpgsql.variable_conflict, with values "error", "use_variable",
"use_column". The behavior can also be specified per-function by inserting
one of
#variable_conflict error
#variable_conflict use_variable
#variable_conflict use_column
at the start of the function body.
The 8.5 release notes will need to mention using "use_variable" to retain
backward-compatible behavior, although we should encourage people to migrate
to the much less mistake-prone "error" setting.
Update the plpgsql documentation to match this and other recent changes.
Heikki Linnakangas [Fri, 13 Nov 2009 19:48:20 +0000 (19:48 +0000)]
A better fix for the "ARRAY[...]::domain" problem. The previous patch worked,
but the transformed ArrayExpr claimed to have a return type of "domain",
even though the domain constraint was only checked by the enclosing
CoerceToDomain node. With this fix, the ArrayExpr is correctly labeled with
the base type of the domain. Per gripe by Tom Lane.
Heikki Linnakangas [Fri, 13 Nov 2009 16:09:10 +0000 (16:09 +0000)]
When you do "ARRAY[...]::domain", where domain is a domain over an array type,
we need to check domain constraints. We used to do it correctly, but 8.4
introduced a separate code path for the "ARRAY[]::arraytype" case to infer
the type of an empty ARRAY construct from the cast target, and forgot to take
domains into account.
Per report from Florian G. Pflug.
Teodor Sigaev [Fri, 13 Nov 2009 11:17:04 +0000 (11:17 +0000)]
Fix multicolumn GIN's wrong results with fastupdate enabled.
User-defined consistent functions believes the check array
contains at least one true element which was not a true for
scanning pending list.
Per report from Yury Don <yura@vpcit.ru>
Tom Lane [Thu, 12 Nov 2009 18:20:23 +0000 (18:20 +0000)]
The recent patch to log changes in postgresql.conf settings dumped core
if the initial value of a string variable was NULL, which is entirely
possible. Noted while experimenting with custom_variable_classes.
Tom Lane [Thu, 12 Nov 2009 03:37:15 +0000 (03:37 +0000)]
Check for C/POSIX before assuming that nl_langinfo or win32_langinfo
will work. Per buildfarm results.
Tom Lane [Thu, 12 Nov 2009 02:46:16 +0000 (02:46 +0000)]
Make initdb behave sanely when the selected locale has codeset "US-ASCII".
Per discussion, this should result in defaulting to SQL_ASCII encoding.
The original coding could not support that because it conflated selection
of SQL_ASCII encoding with not being able to determine the encoding.
Adjust pg_get_encoding_from_locale()'s API to distinguish these cases,
and fix callers appropriately. Only initdb actually changes behavior,
since the other callers were perfectly content to consider these cases
equivalent.
Per bug #5178 from Boh Yap. Not going to bother back-patching, since
no one has complained before and there's an easy workaround (namely,
specify the encoding you want).
Tom Lane [Thu, 12 Nov 2009 01:13:12 +0000 (01:13 +0000)]
Remove pg_parse_string_token() --- not needed anymore.
Tom Lane [Thu, 12 Nov 2009 00:13:00 +0000 (00:13 +0000)]
Remove plpgsql's separate lexer (finally!), in favor of using the core lexer
directly. This was a lot of trouble, but should be worth it in terms of
not having to keep the plpgsql lexer in step with core anymore. In addition
the handling of keywords is significantly better-structured, allowing us to
de-reserve a number of words that plpgsql formerly treated as reserved.
Peter Eisentraut [Wed, 11 Nov 2009 21:07:41 +0000 (21:07 +0000)]
In psql \du, separate the role attributes by comma instead of newline,
for an arguably more pleasant display.
Alvaro Herrera [Wed, 11 Nov 2009 20:31:26 +0000 (20:31 +0000)]
Change "name" nonterminal in cursor-related productions to cursor_name.
This is a preparatory patch for allowing a dynamic cursor name be used in the
ECPG grammar.
Author: Zoltan Boszormenyi
Alvaro Herrera [Wed, 11 Nov 2009 20:07:57 +0000 (20:07 +0000)]
Document the previous FETCH and MOVE changes.
Alvaro Herrera [Wed, 11 Nov 2009 19:25:42 +0000 (19:25 +0000)]
Support optional FROM/IN in FETCH and MOVE
The main motivation for this is that it's required for Informix compatibility
in ECPG.
This patch makes the ECPG and core grammars a bit closer to one another for
these productions.
Author: Zoltan Boszormenyi
Tom Lane [Tue, 10 Nov 2009 23:12:13 +0000 (23:12 +0000)]
Do not build psql's flex module on its own, but instead include it in
mainloop.c. This ensures that postgres_fe.h is read before including
any system headers, which is necessary to avoid problems on some platforms
where we make nondefault selections of feature macros for stdio.h or
other headers. We have had this policy for flex modules in the backend
for many years, but for some reason it was not applied to psql.
Per trouble report from Alexandra Roy and diagnosis by Albe Laurenz.
Tom Lane [Tue, 10 Nov 2009 18:53:38 +0000 (18:53 +0000)]
Revert the temporary patch to work around Snow Leopard readdir() bug.
Apple has fixed that bug in 10.6.2, and we should encourage users to
update to that version rather than trusting this cosmetic patch.
As was recently noted by Stephen Tyler, this patch was only masking
the problem in the context of DROP TABLESPACE, but the failure could
occur in other places such as pg_xlog cleanup.
Bruce Momjian [Tue, 10 Nov 2009 18:41:24 +0000 (18:41 +0000)]
interval_abs():
Add C comment about why there is no interval_abs(): it is unclear what
value to return:
http://archives.postgresql.org/pgsql-general/2009-10/msg01031.php
http://archives.postgresql.org/pgsql-general/2009-11/msg00041.php
Alvaro Herrera [Tue, 10 Nov 2009 18:00:06 +0000 (18:00 +0000)]
Fix longstanding problems in VACUUM caused by untimely interruptions
In VACUUM FULL, an interrupt after the initial transaction has been recorded
as committed can cause postmaster to restart with the following error message:
PANIC: cannot abort transaction NNNN, it was already committed
This problem has been reported many times.
In lazy VACUUM, an interrupt after the table has been truncated by
lazy_truncate_heap causes other backends' relcache to still point to the
removed pages; this can cause future INSERT and UPDATE queries to error out
with the following error message:
could not read block XX of relation 1663/NNN/MMMM: read only 0 of 8192 bytes
The window to this race condition is extremely narrow, but it has been seen in
the wild involving a cancelled autovacuum process.
The solution for both problems is to inhibit interrupts in both operations
until after the respective transactions have been committed. It's not a
complete solution, because the transaction could theoretically be aborted by
some other error, but at least fixes the most common causes of both problems.
Bruce Momjian [Tue, 10 Nov 2009 14:22:45 +0000 (14:22 +0000)]
DIAGNOSTICS/FOUND wording
Update wording of GET DIAGNOSTICS/FOUND, per David Fetter.
Tom Lane [Tue, 10 Nov 2009 02:13:13 +0000 (02:13 +0000)]
More incremental refactoring in plpgsql: get rid of gram.y dependencies on
yytext. This is a necessary change if we're going to have a lexer interface
layer that does lookahead, since yytext won't necessarily be in step with
what the grammar thinks is the current token. yylval and yylloc should
be the only side-variables that we need to manage when doing lookahead.
Bruce Momjian [Tue, 10 Nov 2009 02:09:54 +0000 (02:09 +0000)]
PL/pgSQL FOUND
Document that GET DIAGNOSTICS is affected by EXECUTE, while FOUND is
not.