OSDN Git Service
Simon Riggs [Thu, 25 Mar 2010 20:40:17 +0000 (20:40 +0000)]
Modify some new and pre-existing messages for translatability.
Tom Lane [Thu, 25 Mar 2010 15:50:10 +0000 (15:50 +0000)]
Fix ginint4_queryextract() to actually do what it was intended to do for an
unsatisfiable query, such as indexcol && empty_array. It should return -1
to tell GIN no scan is required; but silly typo disabled the logic for that,
resulting in unnecessary "GIN indexes do not support whole-index scans" error.
Per bug report from Jeff Trout.
Back-patch to 8.3 where the logic was introduced.
Alvaro Herrera [Thu, 25 Mar 2010 14:44:34 +0000 (14:44 +0000)]
Prevent ALTER USER f RESET ALL from removing the settings that were put there
by a superuser -- "ALTER USER f RESET setting" already disallows removing such a
setting.
Apply the same treatment to ALTER DATABASE d RESET ALL when run by a database
owner that's not superuser.
Simon Riggs [Wed, 24 Mar 2010 21:41:57 +0000 (21:41 +0000)]
Additional thoughts on WALSender cpu reduction. Use long type
and alter a comment to reduce confusion.
Simon Riggs [Wed, 24 Mar 2010 21:25:50 +0000 (21:25 +0000)]
Change replication connection log format to allow for a database
called replication. Add host and port details, following format
of messages in BackendInitialize().
Simon Riggs [Wed, 24 Mar 2010 20:11:12 +0000 (20:11 +0000)]
Reduce CPU utilisation of WALSender process. Process was using 10% CPU
doing nothing, caused by naptime specified in milliseconds yet units of
pg_usleep() parameter is microseconds. Correctly specifying units
reduces call frequency by 1000. Reduction in CPU consumption verified.
Tom Lane [Wed, 24 Mar 2010 17:05:45 +0000 (17:05 +0000)]
Fix thinko in log message for "sameuser" ident map mismatch: the provided
and authenticated usernames were swapped. Reported by Bryan Henderson
in bug #5386.
Also clean up poorly-maintained header comment for this function.
Tom Lane [Wed, 24 Mar 2010 16:07:10 +0000 (16:07 +0000)]
Now that we know last_statrequest > last_statwrite can be observed in the
buildfarm, expend a little more effort on the log message for it.
Andrew Dunstan [Wed, 24 Mar 2010 13:14:02 +0000 (13:14 +0000)]
Mark "installcheck-parallel", "world", "install-world" and "installcheck-world" make targets as PHONY. Fujii Masao.
Heikki Linnakangas [Wed, 24 Mar 2010 06:25:39 +0000 (06:25 +0000)]
Update description of walrcv_receive() function to match reality.
Bruce Momjian [Wed, 24 Mar 2010 03:13:45 +0000 (03:13 +0000)]
Document in postgresql.conf that the max_standby_delay default is 30
'seconds'.
Bruce Momjian [Tue, 23 Mar 2010 22:37:14 +0000 (22:37 +0000)]
Typo fix from IRC breinbaas
Peter Eisentraut [Tue, 23 Mar 2010 22:12:06 +0000 (22:12 +0000)]
Remove useless double assignment
GCC 4.5 complained about it.
Itagaki Takahiro [Tue, 23 Mar 2010 04:09:17 +0000 (04:09 +0000)]
Remove CRs for each line in pgbench.sgml.
Bruce Momjian [Tue, 23 Mar 2010 02:28:48 +0000 (02:28 +0000)]
Add back other xlog() function author names.
Itagaki Takahiro [Tue, 23 Mar 2010 01:29:22 +0000 (01:29 +0000)]
Each worker thread will have its own log file in pgbench to avoid interleaved
writes. The first worker still uses "pgbench_log.<pid>" for the name, but
additional workers use "pgbench_log.<pid>.<serial-number>" instead.
Reported by Greg Smith.
Bruce Momjian [Mon, 22 Mar 2010 22:56:52 +0000 (22:56 +0000)]
Properly credit Simon for functions pg_last_xlog_replay_location, etc.
Tom Lane [Mon, 22 Mar 2010 17:43:28 +0000 (17:43 +0000)]
Fix regression test breakage from recent change in default name of exclusion-constraint index.
Simon Riggs [Mon, 22 Mar 2010 15:24:11 +0000 (15:24 +0000)]
Shorten suffix of automatically created indexes to "_excl" when using
exclusion constraints, in line with string length of other pre-9.0 suffixes.
Bruce Momjian [Mon, 22 Mar 2010 14:56:09 +0000 (14:56 +0000)]
Re-order createuser and vacuumedb documentation options, for
consistency.
Gabrielle (Roth)
Tom Lane [Mon, 22 Mar 2010 13:57:16 +0000 (13:57 +0000)]
Fix an oversight in join-removal optimization: we have to check not only for
plain Vars that are generated in the inner rel and used above the join, but
also for PlaceHolderVars. Per report from Oleg K.
Michael Meskes [Mon, 22 Mar 2010 07:41:20 +0000 (07:41 +0000)]
Fixed ECPG regression test to make sure it uses absolute paths for include
files instead of relative ones which break vpath builds.
Bruce Momjian [Sun, 21 Mar 2010 22:12:27 +0000 (22:12 +0000)]
Remove 9.0 release notes xref's to HISTORY.html can be built.
Document this restriction.
Michael Meskes [Sun, 21 Mar 2010 14:26:58 +0000 (14:26 +0000)]
Adding special command line option that is now needed for the one ecpg regression test that was changed.
Michael Meskes [Sun, 21 Mar 2010 11:56:45 +0000 (11:56 +0000)]
ECPG's parser now accepts and handles variables as arguments for the FREE command.
Informix allows variables as argument to the embedded SQL command FREE. Given
that we only allow freeing cursors via FREE for compatibility reasons only we
should do the same.
Michael Meskes [Sun, 21 Mar 2010 11:38:16 +0000 (11:38 +0000)]
Adjusted regression test results to the change I made in debug output for ecpglib.
Michael Meskes [Sun, 21 Mar 2010 11:33:44 +0000 (11:33 +0000)]
Correctly name functions in debug output in ecpglib. When the functions were
refactored the debug output wasn't adjusted.
Michael Meskes [Sun, 21 Mar 2010 10:49:52 +0000 (10:49 +0000)]
ECPG only copied #include statements instead of processing them according to
commandline option "-i". This change fixes this and adds a test case. It also
honors #include_next, although this is probably never used for embedded SQL.
Bruce Momjian [Sun, 21 Mar 2010 02:24:29 +0000 (02:24 +0000)]
Add more 9.0 release note documentation links.
Bruce Momjian [Sun, 21 Mar 2010 00:43:40 +0000 (00:43 +0000)]
Add links to documentation sections in 9.0 release notes.
Also update tagging instructions, and add id tags to a few documentation
sections.
Peter Eisentraut [Sun, 21 Mar 2010 00:17:59 +0000 (00:17 +0000)]
Message tuning
Michael Meskes [Sat, 20 Mar 2010 18:53:00 +0000 (18:53 +0000)]
Fixed ecpg parser to allow more than one C preprocessor command inside a declare section.
Bruce Momjian [Sat, 20 Mar 2010 16:31:09 +0000 (16:31 +0000)]
In 9.0 release notes, move libpq/ecpg up into their own sections, like I
did with server-side languages.
Bruce Momjian [Sat, 20 Mar 2010 14:03:31 +0000 (14:03 +0000)]
Move server-side languages up one section in the 9.0 release notes.
Simon Riggs [Sat, 20 Mar 2010 07:49:48 +0000 (07:49 +0000)]
Further corrections of mismatching struct and btree SizeOf macros.
In this case, correction is to remove now unused fields from struct.
Since these were unused and full of garbage anyway, no version change.
Bruce Momjian [Sat, 20 Mar 2010 03:30:12 +0000 (03:30 +0000)]
Create 9.0 release notes; keep 9.0-alpha release notes in place.
Bruce Momjian [Sat, 20 Mar 2010 03:12:52 +0000 (03:12 +0000)]
Update sgml release note markup suggestions.
Tom Lane [Sat, 20 Mar 2010 00:58:09 +0000 (00:58 +0000)]
Clear error_context_stack and debug_query_string at the beginning of proc_exit,
so that we won't try to attach any context printouts to messages that get
emitted while exiting. Per report from Dennis Koegel, the context functions
won't necessarily work after we've started shutting down the backend, and it
seems possible that debug_query_string could be pointing at freed storage
as well. The context information doesn't seem particularly relevant to
such messages anyway, so there's little lost by suppressing it.
Back-patch to all supported branches. I can only demonstrate a crash with
log_disconnections messages back to 8.1, but the risk seems real in 8.0 and
before anyway.
Robert Haas [Sat, 20 Mar 2010 00:43:42 +0000 (00:43 +0000)]
Forbid renaming columns of objects whose column names are system-generated.
KaiGai Kohei, with adjustments to the comments.
Tom Lane [Fri, 19 Mar 2010 22:54:41 +0000 (22:54 +0000)]
Modify error context callback functions to not assume that they can fetch
catalog entries via SearchSysCache and related operations. Although, at the
time that these callbacks are called by elog.c, we have not officially aborted
the current transaction, it still seems rather risky to initiate any new
catalog fetches. In all these cases the needed information is readily
available in the caller and so it's just a matter of a bit of extra notation
to pass it to the callback.
Per crash report from Dennis Koegel. I've concluded that the real fix for
his problem is to clear the error context stack at entry to proc_exit, but
it still seems like a good idea to make the callbacks a bit less fragile
for other cases.
Backpatch to 8.4. We could go further back, but the patch doesn't apply
cleanly. In the absence of proof that this fixes something and isn't just
paranoia, I'm not going to expend the effort.
Tom Lane [Fri, 19 Mar 2010 20:51:30 +0000 (20:51 +0000)]
Fix oversight in btpo.xact patch; it was in fact installing garbage
in the xact field on replay, due to not writing out all the data in
the wal log struct.
Simon Riggs [Fri, 19 Mar 2010 19:31:06 +0000 (19:31 +0000)]
Clarify docs about database parameter in streaming replication primary_conninfo.
Docs were unclear on whether or not database=replication was required,
nor did they mention the FATAL error this causes if database parameter is
mentioned explicitly, whatever its value.
Simon Riggs [Fri, 19 Mar 2010 19:19:38 +0000 (19:19 +0000)]
Add connection messages for streaming replication. log_connections
was broken for a replication connection and no messages were
displayed on either standby or primary, at any debug level.
Connection messages needed to diagnose session drop/reconnect
events. Use LOG mode for now, discuss lowering in later releases.
Simon Riggs [Fri, 19 Mar 2010 17:51:42 +0000 (17:51 +0000)]
Minor tweaks on libpqrcv_connect(): ensure conninfo_repl[] is
correctly sized and expand comment to explain otherwise
undocumented use of replication connection parameter.
Simon Riggs [Fri, 19 Mar 2010 17:42:10 +0000 (17:42 +0000)]
Update XLOG_PAGE_MAGIC to recognise WAL format changes.
Simon Riggs [Fri, 19 Mar 2010 11:05:15 +0000 (11:05 +0000)]
Adjust comment in .history file to match recovery target specified. Comment
present since 8.0 was never fully meaningful, since two recovery targets
cannot be specified. Refactor recovery target type to make this change
and associated code easier to understand. No change in function.
Bug report arising from internal support question.
Simon Riggs [Fri, 19 Mar 2010 10:41:22 +0000 (10:41 +0000)]
Reset btpo.xact following recovery of btree delete page. Add btpo_xact
field into WAL record and reset it from there, rather than using
FrozenTransactionId which can lead to some corner case bugs.
Problem report and suggested route to a fix from Heikki, details by me.
Peter Eisentraut [Thu, 18 Mar 2010 20:00:51 +0000 (20:00 +0000)]
Also print the libpq error message when lo_create or lo_open fails
Peter Eisentraut [Thu, 18 Mar 2010 19:43:03 +0000 (19:43 +0000)]
Prevent the injection of invalidly encoded strings by PL/Python into PostgreSQL
with a few strategically placed pg_verifymbstr calls.
Peter Eisentraut [Thu, 18 Mar 2010 19:02:46 +0000 (19:02 +0000)]
Message style tuning
Bruce Momjian [Thu, 18 Mar 2010 16:31:12 +0000 (16:31 +0000)]
Mention way to get commit details for release notes.
Tom Lane [Thu, 18 Mar 2010 15:29:44 +0000 (15:29 +0000)]
Fix missing parentheses for current_query(), per bug #5378.
Also make a couple other minor editorial improvements.
Peter Eisentraut [Thu, 18 Mar 2010 13:23:57 +0000 (13:23 +0000)]
Use data-type specific conversion functions also in plpy.execute
In PLy_spi_execute_plan, use the data-type specific Python-to-PostgreSQL
conversion function instead of passing everything through InputFunctionCall
as a string. The equivalent fix was already done months ago for function
parameters and return values, but this other gateway between Python and
PostgreSQL was apparently forgotten. As a result, data types that need
special treatment, such as bytea, would misbehave when used with
plpy.execute.
Heikki Linnakangas [Thu, 18 Mar 2010 09:17:18 +0000 (09:17 +0000)]
Add restartpoint_command option to recovery.conf. Fix bug in %r handling
in recovery_end_command, it always came out as 0 because InRedo was
cleared before recovery_end_command was executed. Also, always take
ControlFileLock when reading checkpoint location for %r.
The recovery_end_command bug and the missing locking was present in 8.4
as well, that part of this patch will be backported separately.
Simon Riggs [Thu, 18 Mar 2010 07:01:01 +0000 (07:01 +0000)]
Add vacuum_defer_cleanup_age to postgresql.conf.sample.
Peter Eisentraut [Wed, 17 Mar 2010 22:02:44 +0000 (22:02 +0000)]
Don't link PL/Python against LOCALMODLIBS
This variable is apparently only for Python internally. In newer releases
of Python this variable pulls in more and more libraries that users are
less likely to have, leading to potential build failures.
Peter Eisentraut [Wed, 17 Mar 2010 21:31:17 +0000 (21:31 +0000)]
Message style tuning
Peter Eisentraut [Wed, 17 Mar 2010 20:58:38 +0000 (20:58 +0000)]
Fix peculiar, untranslatable message concatenation attempt
Peter Eisentraut [Wed, 17 Mar 2010 20:53:19 +0000 (20:53 +0000)]
Make typography consistent
Magnus Hagander [Wed, 17 Mar 2010 18:03:55 +0000 (18:03 +0000)]
Typo fixes.
Fujii Masao
Peter Eisentraut [Wed, 17 Mar 2010 17:12:31 +0000 (17:12 +0000)]
Update broken and permanently moved links
Tom Lane [Wed, 17 Mar 2010 16:52:38 +0000 (16:52 +0000)]
Pass incompletely-transformed aggregate argument lists as separate parameters
to transformAggregateCall, instead of abusing fields in Aggref to carry them
temporarily. No change in functionality but hopefully the code is a bit
clearer now. Per gripe from Gokulakannan Somasundaram.
Tom Lane [Wed, 17 Mar 2010 15:55:50 +0000 (15:55 +0000)]
Fix incorrect example in CREATE INDEX reference page, per Josh Kupershmidt.
Also fix and uncomment an old example of creating a GIST index, and make
a couple of other minor editorial adjustments.
Simon Riggs [Wed, 17 Mar 2010 00:28:15 +0000 (00:28 +0000)]
Fix typo in streaming replication protocol docs.
Simon Riggs [Tue, 16 Mar 2010 16:03:24 +0000 (16:03 +0000)]
Fix typo in math function docs, spotted by Heikki.
Heikki Linnakangas [Tue, 16 Mar 2010 09:09:55 +0000 (09:09 +0000)]
Throw a nicer error message if a standby server attempts to connect while
the master is still in recovery. We don't support cascading slaves yet.
Patch by Fujii Masao, with slightly changed wording.
Simon Riggs [Mon, 15 Mar 2010 19:03:31 +0000 (19:03 +0000)]
Document that trig functions accept/return values in radians.
Simon Riggs [Mon, 15 Mar 2010 18:49:17 +0000 (18:49 +0000)]
Remove incorrect comment from GetWriteRecPtr(): the return value is always
correct, as described in comments at start of xlog.c
Tom Lane [Sun, 14 Mar 2010 04:17:54 +0000 (04:17 +0000)]
Update oidjoins regression test for 9.0.
Peter Eisentraut [Sat, 13 Mar 2010 20:55:05 +0000 (20:55 +0000)]
Add some more structure and bits of information to PL/Python documentation
Bruce Momjian [Sat, 13 Mar 2010 16:56:37 +0000 (16:56 +0000)]
Revert all keepalive moves, reevaluate.
Bruce Momjian [Sat, 13 Mar 2010 16:40:38 +0000 (16:40 +0000)]
Move more tcp keepalive macros to be consistent.
Bruce Momjian [Sat, 13 Mar 2010 15:35:46 +0000 (15:35 +0000)]
Move TCP keepalive macro definition
Jaime Casanova
Bruce Momjian [Sat, 13 Mar 2010 14:55:57 +0000 (14:55 +0000)]
Add libpq warning message if the .pgpass-retrieved password fails.
Add ERRCODE_INVALID_PASSWORD sqlstate error code.
Peter Eisentraut [Sat, 13 Mar 2010 11:00:19 +0000 (11:00 +0000)]
Update shared memory configuration information for Linux
In particular, the assertion that shmall is sufficiently sized by default
is slowly becoming untrue.
Bruce Momjian [Sat, 13 Mar 2010 03:09:04 +0000 (03:09 +0000)]
Document what user name email symbols are supported by tsearch.
Bruce Momjian [Sat, 13 Mar 2010 00:41:58 +0000 (00:41 +0000)]
Allow underscores in tsearch email addressses, per RFC 5322 and report
by Dan O'Hara.
Patch by Teodor Sigaev
Bruce Momjian [Sat, 13 Mar 2010 00:40:43 +0000 (00:40 +0000)]
Small adjustment by pgindent.
Bruce Momjian [Fri, 12 Mar 2010 23:21:48 +0000 (23:21 +0000)]
Re-add comma, oops.
Tom Lane [Fri, 12 Mar 2010 22:19:19 +0000 (22:19 +0000)]
Add some logging code for unexpected cases in pgstat.c, particularly being
unable to read a stats file for reasons other than ENOENT, and having to reset
last_statrequest because it's later than current time in the collector.
Not clear if this will shed any light on the "pgstat wait timeout" business,
but it seems like a good idea in general.
In passing, do some message-style-police work on recently-added
pgstat_reset_shared_counters code.
Tom Lane [Fri, 12 Mar 2010 21:40:36 +0000 (21:40 +0000)]
Fix a commented-out block of code that pgindent didn't understand
properly; it's been making that comment uglier with each run.
Bruce Momjian [Fri, 12 Mar 2010 17:46:07 +0000 (17:46 +0000)]
Remove unnecessary comma in documentation.
Tom Lane [Thu, 11 Mar 2010 21:47:19 +0000 (21:47 +0000)]
Add missing reset of need_initialization in reloptions code.
This resulted in useless extra work during every call of parseRelOptions,
but no bad effects other than that. Noted by Alvaro.
Tom Lane [Thu, 11 Mar 2010 21:29:32 +0000 (21:29 +0000)]
Modify psql's \d printout to fold exclusion constraints in with regular
indexes, rather than printing them twice. Per my gripe when the exclusion
constraint feature was committed.
Tom Lane [Thu, 11 Mar 2010 18:43:24 +0000 (18:43 +0000)]
Sync timezone code with tzcode 2010c from the Olson group. This fixes some
corner cases that come up in certain timezones (apparently, only those with
lots and lots of distinct TZ transition rules, as far as I can gather from
a quick scan of their archives). Per suggestion from Jeevan Chalke.
Back-patch to 8.4. Possibly we need to push this into earlier releases
as well, but I'm hesitant to update them to the 64-bit tzcode without
more thought and testing.
Heikki Linnakangas [Thu, 11 Mar 2010 09:26:59 +0000 (09:26 +0000)]
Fix bug in KnownAssignedXidsMany(). I saw this when looking at the
assertion failure reported by Erik Rijkers, but this alone doesn't explain
the failure.
Heikki Linnakangas [Thu, 11 Mar 2010 09:10:25 +0000 (09:10 +0000)]
Fix comment which was apparently copy-pasted from another function.
Tom Lane [Thu, 11 Mar 2010 04:36:43 +0000 (04:36 +0000)]
Simplify a couple of pg_dump and psql \d queries about index constraints
by joining to pg_constraint.conindid, instead of the former technique of
joining indirectly through pg_depend. This is much more straightforward
and probably faster as well. I had originally desisted from changing these
queries when conindid was added because I was worried about losing
performance, but if we join on conrelid as well as conindid then the index
on conrelid can be used when pg_constraint is large.
Tom Lane [Thu, 11 Mar 2010 03:36:22 +0000 (03:36 +0000)]
Update comment for pg_constraint.conindid to mention that it's used for
exclusion constraints. Not sure how we managed to update the comment for
it in catalogs.sgml but miss this one.
Robert Haas [Wed, 10 Mar 2010 19:48:39 +0000 (19:48 +0000)]
Fix incorrect comment about permissions checking being done in utility.c.
Noted while reviewing a patch from KaiGai Kohei.
Itagaki Takahiro [Wed, 10 Mar 2010 02:04:48 +0000 (02:04 +0000)]
pg_start_backup() can use a share lock to lock ControlFileLock
instead of an exclusive lock.
The change is almost for code cleanup. Since there seems to be no
performance benefits from it, backports should not be needed.
Fujii Masao
Tom Lane [Wed, 10 Mar 2010 01:58:11 +0000 (01:58 +0000)]
Preliminary release notes for releases 8.4.3, 8.3.10, 8.2.16, 8.1.20, 8.0.24,
7.4.28.
Tom Lane [Tue, 9 Mar 2010 22:34:38 +0000 (22:34 +0000)]
Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV in plperl.
The latter is considered unwarranted chumminess with the implementation,
and can lead to crashes with recent Perl versions.
Report and fix by Tim Bunce. Back-patch to all versions containing the
questionable coding pattern.
Alvaro Herrera [Tue, 9 Mar 2010 14:27:28 +0000 (14:27 +0000)]
Update time zone data files to tzdata release 2010d: DST law changes in Fiji,
Samoa, Chile; corrections to recent changes in Paraguay and Bangladesh.
Michael Meskes [Tue, 9 Mar 2010 11:09:46 +0000 (11:09 +0000)]
ecpg now adds a unique counter to its varchar struct definitions to make these definitions unique, too. It used to use the linenumber but in the rare case of two definitions in one line this was not unique.
Andrew Dunstan [Tue, 9 Mar 2010 02:48:33 +0000 (02:48 +0000)]
Add checks for valid encoding of query strings passed to SPI by plperl.
Bruce Momjian [Mon, 8 Mar 2010 23:03:00 +0000 (23:03 +0000)]
Return proper exit code (3) from psql when ON_ERROR_STOP=on and
--single-transaction are both used and the failure happens in commit,
e.g. failed deferred trigger. Also properly free BEGIN/COMMIT result
structures from --single-transaction.
Per report from Dominic Bevacqua
Magnus Hagander [Mon, 8 Mar 2010 12:38:37 +0000 (12:38 +0000)]
Add missing space in example.
Tim Landscheidt
Michael Meskes [Mon, 8 Mar 2010 12:15:24 +0000 (12:15 +0000)]
Better test the content of the SQLSTATE string in ecpglib than the pointer.
Magnus Hagander [Mon, 8 Mar 2010 10:01:12 +0000 (10:01 +0000)]
Require hostname to be set when using GSSAPI authentication. Without it,
the GSSAPI libraries crash.
Noted by Zdenek Kotala