OSDN Git Service
Navin Kochar [Wed, 9 Mar 2016 17:41:53 +0000 (23:11 +0530)]
Add LE L2CAP Connection Oriented Channel
This implementation for LE L2CAP Connection Oriented Channel (a Bluetooth
Core Spec 4.1 feature) has been tested on the following formal and informal
IOP events conducted by BT SIG Sport and Fitness Working Group.
* Informal IOP – Tokyo 2014
* UPF 49 – Berlin 2014
* Formal IOP – Tokyo 2014
* Formal IOP – Santa Clara 2015
Change-Id: Ia6de62f9321a78b98930629f65078884157a9c0d
Signed-off-by: Navin Kochar <navin.kochar@intel.com>
Srinu Jella [Fri, 22 Jan 2016 12:19:15 +0000 (17:49 +0530)]
Start listener thread only after successful open call
Use case: Stress tests ON\OFF with different concurrent
scenarios
Failure: Crash in btsnoop_net_listen thread
Root cause: While starting and shutting down the module
we are calling same function update_logging(). While at
the start it is creating listen thread and throwing error
and exiting without closing the listen thread. While
shutdown of module it "should_log" matches with "is_logging"
and it considers cleanup is not required and returns,
leaving Behind the listen thread open. In the next BT ON,
another listen thread is created and causes the crash.
Fix: Started listener thread after prerequisite operations
are successful.
Change-Id: I92ef293d9b061d0ea65a0c41b506870152114bb0
Srinu Jella [Tue, 15 Mar 2016 11:06:19 +0000 (16:36 +0530)]
Allocate sufficient memory for FCS
Use Case: Hit LeakCanary detection during HDP
Failure: Crash while running LeakCanary detection.
Root cause: Did not have sufficient memory for data frame
which lead to crash.
Fix: Allocating sufficient memory for the data frame
which includes FCS in the header field.
Change-Id: I3bb862f29ecc854423796dc89820ba21c5db6050
Marie Janssen [Thu, 10 Mar 2016 19:27:53 +0000 (11:27 -0800)]
osi: add osi_rand()
Provide a replacement for rand() which has a better random source.
Change-Id: I38a8c74d86b89ec160b43b0f648f53b463be89bb
Pavlin Radoslavov [Mon, 14 Mar 2016 16:45:24 +0000 (09:45 -0700)]
Removed unused function bta_sys_vs_hdl()
Change-Id: Iaf199d418aafc0b518df2f7febfa1c9e29f1fa42
Pavlin Radoslavov [Mon, 14 Mar 2016 17:06:45 +0000 (10:06 -0700)]
Removed duplicate (re)define of BTA_DM_SDP_DB_SIZE
Removed conditional duplicate re-define of BTA_DM_SDP_DB_SIZE.
BTA_DM_SDP_DB_SIZE has been already (conditionally) defined to 8000
in file include/bt_target.h
The conditional re-define of BTA_DM_SDP_DB_SIZE to a smaller
value (250) in file bta/dm/bta_dm_int.h should be removed, because
it is confusing and error-prone.
Change-Id: Id10a45562c7c57fd0a9131ef50b7b7a5c2801ec5
Srinu Jella [Fri, 6 Nov 2015 09:29:10 +0000 (14:59 +0530)]
Free allocation tracker hash map entries to reduce memory pressure
Use case:
A2DP playback becomes choppy after long hours of testing.
Steps:
1. installed 3rd party app that performs recurring LE scans.
2. Leave phone to run overnight.
3. After 24h+, connect a Bluetooth headset and music is very choppy.
Root cause:
The memory allocation tracker has support for double free check
where it stores all allocations in hash map but it never get
removed to track double free issue, A2DP memory allocation is
taking more time and leading to choppyness.
Fix:
Free the hash map entry to avoid memory leak from
allocation tracker.
Bug:
27621407
Change-Id: If57bd0b89c1d9b99c4f066c537a9e0fa49bc093f
Ajay Panicker [Fri, 11 Mar 2016 19:33:21 +0000 (19:33 +0000)]
Merge "Add pair event device class and fix timestamp"
Ajay Panicker [Thu, 10 Mar 2016 23:30:16 +0000 (15:30 -0800)]
Add pair event device class and fix timestamp
Added a function to get the device class to use with pair events.
Also update check_cod_hid as it was only being used with COD_HID_MAJOR.
Also fixed an issue with pair event timestamps where they were
using the wrong clock.
Bug:
27499938
Change-Id: I0805d7a3f82b28e7d7e73d80818948843f51a82b
Jakub Pawlowski [Thu, 10 Mar 2016 17:20:45 +0000 (09:20 -0800)]
Fix startup error when no config file provided
If bluetoothtbd was started without config file
present, it would die on asserts about missing config.
From now it'll proceed with default settings.
Change-Id: I46c35fb2ed71efa49430206da13a19ca7df44a64
Jakub Pawlowski [Thu, 10 Mar 2016 18:58:43 +0000 (18:58 +0000)]
Merge "Linux vendor driver linkage fixes"
Jakub Pawlowski [Thu, 10 Mar 2016 17:25:48 +0000 (09:25 -0800)]
Linux vendor driver linkage fixes
Linux driver depends on osi, so it must be linked with it.
It also must export bt_vendor_interface_t, and named properly,
otherwise it is not being recognized as vendor library.
Bug:
27589244
Change-Id: Ib6817b11e4226f2e289ff0d521daca059ca9aca6
Jakub Pawlowski [Wed, 9 Mar 2016 19:25:45 +0000 (19:25 +0000)]
Merge "Fix build error caused by missing LOG_TAG"
Jakub Pawlowski [Wed, 9 Mar 2016 19:25:06 +0000 (19:25 +0000)]
Merge "Add missing 'cd third_party' step"
Jakub Pawlowski [Wed, 9 Mar 2016 19:22:00 +0000 (11:22 -0800)]
Add missing log tag
Change-Id: Icae6cf63de8d298fb12451887594abe24b026c77
Jakub Pawlowski [Fri, 4 Mar 2016 19:46:08 +0000 (11:46 -0800)]
Remove bta_gattc_id2handle
Now that the instance id is equal to handle, we no longer need this
mapping function.
Bug:
27455533
Change-Id: I6760f8fc81460df8520d4ebf1899ed256ce5ad1e
Jakub Pawlowski [Wed, 2 Mar 2016 22:47:55 +0000 (14:47 -0800)]
Use attribute handle instead of id in GATT cache
Currently we generate an id for each GATT attribute. Those ids
are used to differentiate between attributes that have the same
UUID. We need to get rid of those ids because it won't work with
partial GATT database updates due to "service change"
notifications. Instead, attribute handles, which are unique
across the whole GATT database will be used.
This is first patch in series to achieve that. It gets rid
of id generation, and just assigns handle in place of ids inside
of gatt cache. Upcoming patches will change the GATT cache API
and eventually get rid of "id" completly.
Bug:
27455533
Change-Id: I74c10872ecc223329b8ac7fef4085963bf272624
Jakub Pawlowski [Tue, 8 Mar 2016 20:36:46 +0000 (12:36 -0800)]
HID multi-device refactoring
We don't really support multiple HID services in same device.
We shouldn't use default value 0 for service id.
We shouldn't merge service id and characteristic id into one field,
as it's done not right right now.
Bug:
27455533
Change-Id: I46cc1b62bb2c7393e62f3b1a8e4650706954a066
venkata Jagadeesh [Tue, 15 Dec 2015 07:30:01 +0000 (13:00 +0530)]
SDP: Restrict attribute length to SDP_MAX_ATTR_LEN
Use case:
Bluetooth crash during the SNS testing.
Root Cause:
In sdpu_build_partial_attrib_entry there is no length check, it can
exceed the maximum allowable value and lead to a crash in memcpy.
Fix:
Restrict remaining attribute length to SDP_MAX_ATTR_LEN
in sdpu_build_partial_attrib_entry.
Change-Id: I5bde6868b82e50b3c09cf94277dabb4862f0a2a8
Marie Janssen [Tue, 8 Mar 2016 19:50:27 +0000 (19:50 +0000)]
bluetooth-cli: add support for --exec
am:
5d80cb938d
* commit '
5d80cb938d7fb3312870a047749cc839ba5bafca':
bluetooth-cli: add support for --exec
Marie Janssen [Fri, 22 Jan 2016 02:45:53 +0000 (18:45 -0800)]
bluetooth-cli: add support for --exec
Adds the --exec and -e arguments, which execute commands when the
cli starts.
This also adds support for chaining commands at the command line by
separating them with ';' characters.
Change-Id: Ic2bf8a908fbb7fb4cf775810754571fa96d75e87
Jakub Pawlowski [Tue, 8 Mar 2016 03:04:34 +0000 (03:04 +0000)]
GATT cache storage refactoring
am:
c10b209f62
* commit '
c10b209f62a52d2a782d4d8c97734b6c142f2567':
GATT cache storage refactoring
Jakub Pawlowski [Sun, 6 Mar 2016 01:57:51 +0000 (17:57 -0800)]
GATT cache storage refactoring
Currently when storing GATT cache into file, we save it piece
after piece, max 10 elements at once. This is not necessary,
we have enough space to just save all at once.
Also the logic doesn't need to be so complicated - no need
to state machine for such simple task.
Bug:
27455533
Change-Id: I82923dbedfb317835e45e13e0ea28151eb524d37
Pavlin Radoslavov [Mon, 7 Mar 2016 21:05:23 +0000 (21:05 +0000)]
Ignore LCB entries that migth have been released while queued
am:
fb2105f348
* commit '
fb2105f3488e48f2d908b13a33f47e34f6e3f78d':
Ignore LCB entries that migth have been released while queued
Pavlin Radoslavov [Tue, 1 Mar 2016 21:32:41 +0000 (13:32 -0800)]
Ignore LCB entries that migth have been released while queued
Function btm_send_pending_direct_conn() dequeues tL2C_LCB
entries from the conn_pending_q queue and calls the processing
function.
However, there is the possilility of a race condition
and releasing the entry by l2cu_release_lcb() before it is processed.
Now tL2C_LCB that are not in_use are ignored.
Bug:
27418154
Change-Id: I4b5fda605a60c8aebbf5587bb12dd74ac5d28f68
Patrick Tsai [Sun, 6 Mar 2016 09:42:19 +0000 (01:42 -0800)]
Fix build error caused by missing LOG_TAG
FAILED: gcc -MMD -MF obj/hci/src/libhci.hci_packet_parser.o.d -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DHAS_NO_BDROID_BUILDCFG -DLOG_NDEBUG=1 -DEXPORT_SYMBOL=__attribute__\(\(visibility\(\"default\"\)\)\) -DKERNEL_MISSING_CLOCK_BOOTTIME_ALARM=TRUE -DOS_GENERIC -I../../hci/include -I../.. -I../../include -I../../bta/include -I../../btcore/include -I../../stack/include -I/home/patrick/src/fluoride/libhardware/include -I/home/patrick/src/fluoride/core/include -I/home/patrick/src/fluoride/media/audio/include -g -O0 -fpic -fdata-sections -ffunction-sections -fvisibility=hidden -std=c99 -c ../../hci/src/hci_packet_parser.c -o obj/hci/src/libhci.hci_packet_parser.o
In file included from ../../hci/src/hci_packet_parser.c:28:0:
../../hci/src/hci_packet_parser.c: In function ‘read_command_complete_header’:
../../hci/src/hci_packet_parser.c:239:43: error: expected ‘)’ before ‘__func__’
LOG_ERROR("%s: return status - 0x%x", __func__, status);
Change-Id: I6ca721ba24ba3170d701f606f0676c5c4e707cf8
Patrick Tsai [Sun, 6 Mar 2016 08:35:09 +0000 (00:35 -0800)]
Add missing 'cd third_party' step
Subramanian Srinivasan [Fri, 4 Mar 2016 22:02:25 +0000 (22:02 +0000)]
Update device type in NVRAM correctly during inquiry
am:
ab7418f58c
* commit '
ab7418f58c84216d57b7c0d553f09f5748badd82':
Update device type in NVRAM correctly during inquiry
Subramanian Srinivasan [Thu, 23 Jul 2015 22:05:05 +0000 (15:05 -0700)]
Update device type in NVRAM correctly during inquiry
If the NVRAM device type for a device is not dual mode and the inquiry
result is received for BLE or BR/EDR transport, then this patch updates
the NVRAM device type to dual mode.
Change-Id: I688e7c5e3bd8d844288d095cb97c2e55ddf652c6
Jacky Cheung [Fri, 4 Mar 2016 21:58:32 +0000 (21:58 +0000)]
Default missing DevType and DevClass in NVRAM.
am:
3b6ef54cd2
* commit '
3b6ef54cd262da6a41a16dafe361040740024717':
Default missing DevType and DevClass in NVRAM.
venkata Jagadeesh [Fri, 4 Mar 2016 21:58:28 +0000 (21:58 +0000)]
GATT: Initiate L2CAP disconnect only when the channel is open
am:
bf955cb7e5
* commit '
bf955cb7e50e1047452e741effa504c8aefc8a4f':
GATT: Initiate L2CAP disconnect only when the channel is open
Jacky Cheung [Fri, 4 Mar 2016 21:29:02 +0000 (13:29 -0800)]
Default missing DevType and DevClass in NVRAM.
Missing DevType and DevClass in NVRAM were not properly set to a
default values previously.
venkata Jagadeesh [Thu, 26 Nov 2015 08:44:00 +0000 (14:14 +0530)]
GATT: Initiate L2CAP disconnect only when the channel is open
Use case:
Crash found during L2CAP disconnect from faulty BLE APP.
Steps:
Run SNS testing.
Failure:
Crash during L2CAP disc.
Root cause:
Faulty BLE application triggering GATT disconnection
which internally triggering L2CAP disconnection without checking
proper state of channel.
Fix:
- Initiate L2CAP disconnect only when the channel is open
- Validate LCB during disconnection from upper layers
Change-Id: Ic9d065f095feba659c861828732647e968c20db8
Jakub Pawlowski [Fri, 4 Mar 2016 21:50:24 +0000 (21:50 +0000)]
Remove btla-specific comments
am:
1be7ae1a08
* commit '
1be7ae1a0890380b8a3daebcade0c1f55b04b167':
Remove btla-specific comments
Jakub Pawlowski [Fri, 4 Mar 2016 21:20:05 +0000 (13:20 -0800)]
Remove btla-specific comments
Change-Id: I91a19b2cfbc96d7567e0e0914058619ea364c1d4
Matadeen Mishra [Fri, 4 Mar 2016 19:36:09 +0000 (19:36 +0000)]
Correcting sniff behaviour in multi-connection scenario
am:
31d1a2b525
* commit '
31d1a2b52507df33f13d19ed2349585dfa490542':
Correcting sniff behaviour in multi-connection scenario
Matadeen Mishra [Mon, 1 Feb 2016 13:50:54 +0000 (19:20 +0530)]
Correcting sniff behaviour in multi-connection scenario
Use case: When multiple profiles are connected on same link and if any one of the
profiles deregisters with powermanager, powermanager will initiate a sniff when it
removes the timer for one profile, even if a timeout did not trigger for other profiles.
Steps:
1. Turn on BT
2. Pair with Mi band (Wearable device)
3. Pair with carkit
4. Turn off BT
5. Turn on BT
HF and A2DP connection should successful after BT on to carkit.
Failure: HF connection fails.
Root Cause: powermanager initiates a sniff when it removes the timer for one profile
Even if a timeout did not trigger for other profiles.
Fix: When multiple profiles connect on the same link and if any one profile
deregisters with powermanager, pm should stop the timer for that profile
and restart the other profiles timers.
Change-Id: I8e215a9d868291976c70ff32b61145b4360a7f8f
Srinu Jella [Fri, 4 Mar 2016 19:12:48 +0000 (19:12 +0000)]
Cleanup L2CAP socket properly on close
am:
9123096530
* commit '
91230965304bc323a96ced0527d560aacb606415':
Cleanup L2CAP socket properly on close
Srinu Jella [Mon, 21 Sep 2015 06:30:48 +0000 (12:00 +0530)]
Cleanup L2CAP socket properly on close
Use case:
1. Sometimes pairing pop up occurs during Android beam
transfer though it is not required.
2. No OPP Tx request over OBEX if we cancel during file transfer.
Precondition
1. WIFI ON and conneted with AP.
Steps:
1. Pair and connect from DUT to remote.
2. Go to gallery and send a file.
3. Accept same file and stop it from remote during transfer.
4. Repeat step 2-4 10 times.
Failure:
OPP Tx should not fail.
Root cause:
Close request was not properly handled from BT-IF layer.
Fix:
1. Handled the close request properly from BT-IF layer
to close the socket variables and instruct the BTA layer
close from there as well.
2. Clean up L2CAP socket properly on closure to free
the entry registered with security manager to avoid
leak in security manager records.
Change-Id: I4f5d6ac92317bcaee5f9285ba71d13eea84c737c
Balraj Selvaraj [Fri, 4 Mar 2016 19:02:47 +0000 (19:02 +0000)]
GAP Setting remove device pending status as FALSE
am:
9412bbaea5
* commit '
9412bbaea51f577d903e060b8c8214fbd28b0b4f':
GAP Setting remove device pending status as FALSE
Balraj Selvaraj [Thu, 11 Feb 2016 08:16:02 +0000 (13:46 +0530)]
GAP Setting remove device pending status as FALSE
Use case: DUT deletes Link key and failed to initiate
authentication request after remote headset turned Off and ON
steps:
- Pair the DUT and HS. (Link Keys get established.)
- Now Switch OFF BT on DUT. (DUT still has the Link key of HS)
- Reset the paired devices memory in HS and keep HS in
pairing mode. (HS loses DUT's link key)
- Now switch ON BT on DUT. (DUT starts reconnection with HS,
but as HS lost DUT's key, PIN or KEY missing event will
come to host)
- DUT reconnects to HS (Using newly established link keys)
- Now power OFF and ON the HS.
- HS will try reconnection with DUT.
- While there is an incoming connection from HS to DUT,
host is giving negative link key reply always for the
multiple link key requests from HS.
- HS sends disconnection with "Authentication failure"
Failure: DUT should not delete Link key and DUT should
initiate Authenticatin request.
Root cause: pending status was not FALSE from security device
DB, which will causing Authentication Failure.
Fix: Setting the remove device pending status to FALSE from
security device DB, when the link key notification event
comes. Basically it will avoid deleting the device from
security device DB, Which is solving the reconnection
initated from remote when we remove the link key at
remote side.
Change-Id: Ic164d8d5b5c2e0b9cc5f04f993047fb0a8e5d9a9
Srinu Jella [Fri, 4 Mar 2016 18:48:22 +0000 (18:48 +0000)]
Track TX empty event to manage sniff timer
am:
4e972d8c24
* commit '
4e972d8c24ecfb808757ef5c81eb3877ebc93027':
Track TX empty event to manage sniff timer
Srinu Jella [Tue, 16 Feb 2016 14:52:16 +0000 (20:22 +0530)]
Track TX empty event to manage sniff timer
Use case:
OPP TX while inquiry is in progress.
Steps:
1. Send any file from DUT to remote using BT.
2. Accept file on remote.
3. During file transfer, start inquiry on DUT and
observe behaviour.
Failure:
DUT sends sniff command in the middle of the transfer
though it is not required. eventually OPP Tx over
L2CAP file transfer fail.
Root Cause:
As per the current implementation, for tx it will
immediately starts idle timer without checking
for the completion status of tx.
Fix:
Handled the tx complete event from L2CAP properly
to start the idle timer to manage the sniff properly.
Change-Id: I298075590042e82a2f33837f6df6af0b2fd8179a
Srinu Jella [Fri, 4 Mar 2016 18:36:36 +0000 (18:36 +0000)]
Read local supported codecs as part of boot sequence
am:
f6dcf79f62
* commit '
f6dcf79f62880e716e127b19c70ea328e07c6051':
Read local supported codecs as part of boot sequence
Srinu Jella [Wed, 22 Jul 2015 12:00:32 +0000 (17:30 +0530)]
Read local supported codecs as part of boot sequence
Add support to read local supported codecs as part of
controller module initialization.
Also added an API from controller interface to get the
local supported codecs.
Change-Id: I37a4ab9e6a20ed057ca794dbdd4f99c2a8c65a6e
Srinu Jella [Fri, 4 Mar 2016 18:26:34 +0000 (18:26 +0000)]
Added fd for monitoring when the channel is not congested
am:
7baa1e1792
* commit '
7baa1e17924cdac702ab9d8146a966fbd26c8d50':
Added fd for monitoring when the channel is not congested
Srinu Jella [Tue, 11 Aug 2015 13:46:52 +0000 (19:16 +0530)]
Added fd for monitoring when the channel is not congested
Use case:
Skips and Media Audio Loss are Observed During PAN Connection
Steps:
1. Launched Local Music and Media Audio was in Headset.
2. Paired and Connected to other Phone to DUT Over BT Tethering.
3. While Listening to Media Audio in DUT, Started Watching
Youtube in other phone.
4. Observed Below Observations During Some 30mins of PAN Connection.
Failure:
Skips and Media Audio Loss are Observed During PAN Connection
Root Cause:
socket monitor thread keeps polling for PAN fd, eventually
it will make the BTU thread also busy, inturn NOCP processing
gets delayed.
Fix:
Add PAN fd for monitoring only when L2CAP channel related to
PAN profile is not congested. It will break loop by checking the
congestion status to put the fd for polling.
Change-Id: I2119c6c86d8e4798e516c512ad7aac7630b85a6a
Matadeen Mishra [Fri, 4 Mar 2016 18:14:22 +0000 (18:14 +0000)]
Merge "Shorten local name in EIR data according to UTF encoding rules"
am:
a9644b77b7
* commit '
a9644b77b7959fef0b58410230930317575d0668':
Shorten local name in EIR data according to UTF encoding rules
Andre Eisenbach [Fri, 4 Mar 2016 18:08:00 +0000 (18:08 +0000)]
Merge "Shorten local name in EIR data according to UTF encoding rules"
Hemant Gupta [Fri, 4 Mar 2016 17:44:01 +0000 (17:44 +0000)]
HID: Handle collisions during incoming and outgoing connections
am:
891723a428
* commit '
891723a42851285ec7e6c2f616a405611789da6b':
HID: Handle collisions during incoming and outgoing connections
Hemant Gupta [Fri, 11 Dec 2015 14:39:22 +0000 (20:09 +0530)]
HID: Handle collisions during incoming and outgoing connections
- This patch handles cases when incoming HID connection is in progress, and
there is an outgoing connection attempt from upper layers. This was leading
to a case when ougoing connection would fail as connection was already in
progress, which triggered cleanup of connection states, which was not proper
leading to issues in future connection attempts, as disconnection during
ongoing connection was not handled properly in existing code.
- Reset the incoming flags during open failure to prevent any possible issues
during further outgoing connections.
Change-Id: I6fb0c6156482d2da41ca0d2d280091d73c27f292
Hemant Gupta [Fri, 4 Mar 2016 17:37:40 +0000 (17:37 +0000)]
HID: Reset outgoing connection retry to 1
am:
b7d4613b3c
* commit '
b7d4613b3c1fae825b4c7ba94907c75513feb1c7':
HID: Reset outgoing connection retry to 1
Hemant Gupta [Fri, 4 Mar 2016 17:19:55 +0000 (22:49 +0530)]
HID: Reset outgoing connection retry to 1
Reduce the retry time from host to 1 from 3 to prevent collision scenarios
when remote also tries to connect which could lead to potential authentication
issues in SoC.
Change-Id: I3b5db4a4c4aa985cb9c0537499ce608f9e5d5522
Hemant Gupta [Fri, 4 Mar 2016 17:33:38 +0000 (17:33 +0000)]
HID: Remove bond for device in case Virtual unplug is ongoing
am:
dc5272a39d
* commit '
dc5272a39d7915d0c921de2fb0727853fadda40a':
HID: Remove bond for device in case Virtual unplug is ongoing
Hemant Gupta [Fri, 11 Dec 2015 10:17:45 +0000 (15:47 +0530)]
HID: Remove bond for device in case Virtual unplug is ongoing
Remove bond for remote device in case virtual unplug was initiated from
local device, and ACL got disconnected while processing the VUP request.
this can happen when aaplication is sending disconnect and remove bond
in quick succession. Without this fix it was observed that device was
getting disconnected, but was not getting unpaired even when user
tried to unpair from UI.
Change-Id: Ife1fc99ed59b13daf0bcf0dce3e0a59c7d9e87d7
Matadeen Mishra [Wed, 3 Feb 2016 15:20:31 +0000 (20:50 +0530)]
Shorten local name in EIR data according to UTF encoding rules
Use case:
Test short name after setting the name with maximum length
Steps to reproduce:
1) Phone A: Rename bluetooth into a 60 character Chinese name
2) Phone B: Discover phone A.
3) The short name of phone A will display in phone B and the short
name cantains unrecognizable chars.
Root cause:
As Chinese characters are encoded in different
length in UTF, if shorten BT name in fixed length,
there will be unrecognized characters
Fix:
Shorten BT name according to UTF encoding rule and decrease
the length.
Change-Id: I5f1e49c1b5d87d5e220538c90e297c50ccc790ff
Subramanian Srinivasan [Fri, 4 Mar 2016 07:47:20 +0000 (07:47 +0000)]
Use correct transport type for GATT client and server connections
am:
d27af38849
* commit '
d27af388490dbe194035ad779096f98aef92d1a5':
Use correct transport type for GATT client and server connections
Subramanian Srinivasan [Thu, 29 Oct 2015 00:05:22 +0000 (17:05 -0700)]
Use correct transport type for GATT client and server connections
Use correct transport type for GATT client and server connect
API calls. This change uses the transport used while calling
the connect frameworks API instead of relying on the NVRAM to
find the transport on which the connect call needs to be sent
to the BT stack.
Change-Id: Idf5817b8980e848c6ebebf1e9a79dbce61d8cfc8
Satya Calloji [Fri, 4 Mar 2016 07:18:33 +0000 (07:18 +0000)]
Update OCF values per 0.96 spec
am:
ca58b09a91
* commit '
ca58b09a9129e334f116b7bbdfc0a3834afa299e':
Update OCF values per 0.96 spec
Satya Calloji [Wed, 2 Mar 2016 19:25:49 +0000 (11:25 -0800)]
Update OCF values per 0.96 spec
HCI command values are updated as per Google HCI
BLE requirements v0.96
Bug:
27069512
Change-Id: I30e0046c5d3198f0986e03baf697bad2be99c06e
Eri Kasamatsu [Fri, 4 Mar 2016 07:14:43 +0000 (07:14 +0000)]
OCF for LE Extended Set Scan Parameters Cmd is not correct
am:
b67ada19a7
* commit '
b67ada19a7235552c802d3dccca011245379b6d5':
OCF for LE Extended Set Scan Parameters Cmd is not correct
Eri Kasamatsu [Tue, 9 Feb 2016 14:11:51 +0000 (15:11 +0100)]
OCF for LE Extended Set Scan Parameters Cmd is not correct
OCF for LE Extended Set Scan Paramaters Cmd is defined as 0x15A
in documentation but it is defined as 0x160 in stack.
This results in command failing due to unknown hci command error.
Change-Id: Ia779164b7c03daa8053fb65e4fc8281235904031
Satish Kodishala [Fri, 4 Mar 2016 07:03:03 +0000 (07:03 +0000)]
Handle unknown codecs sent by HF
am:
dccd759e2e
* commit '
dccd759e2ebb0c348d739e32599e50b419bcf7bc':
Handle unknown codecs sent by HF
Satish Kodishala [Thu, 25 Jun 2015 07:48:35 +0000 (13:18 +0530)]
Handle unknown codecs sent by HF
Use case:
1. Connect to headset supporting CVSD, mSBC and other codecs.
2. Verify if headset sending AT+BAC with supported codecs.
3. Check if SCO is established with mSBC codec.
Failure:
SCO is established with CVSD codec.
Root cause:
When parsing AT+BAC command, if unknown codec is received,
we are falling back to CVSD although mSBC is supported in HF.
Fix:
AT+BAC parsing function modified to return correct codecs
supported by HF when it encounters unknown codecs in arguments
of AT+BAC.
Change-Id: I9ac7675c9d863e7362f85e3b7b8d9a42462bd5e9
Srinu Jella [Fri, 4 Mar 2016 06:57:13 +0000 (06:57 +0000)]
Avoid double-free on SDP search failure
am:
07f612cbc0
* commit '
07f612cbc08364a622e6e02cdbb039b82586d82c':
Avoid double-free on SDP search failure
Srinu Jella [Tue, 29 Dec 2015 08:00:19 +0000 (13:30 +0530)]
Avoid double-free on SDP search failure
Use case: BT transfer fails in Doze mode.
Pre-condition:
1. Device is in Doze mode.
2. Device is in Active state.
Steps to reproduce:
1. On test device and support device, turn on Bluetooth and keep test device in Bluetooth on screen.
2. Put device in Doze mode:
adb shell dumpsys battery unplug
adb shell dumpsys deviceidle step
3. From support device send pair request to test device.
4. Pair two devices.
5. Put test device in Doze mode again.
6. Share one picture from support device to test device by Bluetooth.
7. Accept Bluetooth file transferring request.
Failure: From DUT, BT transfer is failed.
Root cause: Free buffer is called twice for the SDP search failure case.
Fix: Added null check for p_sdp_db to avoid freeing same buffer
again on SDP search failure.
Change-Id: Ic7776e842c52418c2b0fb6d6479233d01c709dc2
Andre Eisenbach [Fri, 4 Mar 2016 06:41:45 +0000 (06:41 +0000)]
Remove bluedroidtest
am:
cd0199a20b
* commit '
cd0199a20b48fcb191f3178a28a6a503e28b7685':
Remove bluedroidtest
Andre Eisenbach [Fri, 4 Mar 2016 06:36:51 +0000 (22:36 -0800)]
Remove bluedroidtest
Use bluetooth-cli/bluetoothtbd instead.
Bug:
25369253
Change-Id: I485919dce4bf3229733c85e6a33c754b9cbd62fc
Sharvil Nanavati [Fri, 4 Mar 2016 06:37:49 +0000 (06:37 +0000)]
Delete unused function declarations from sdp_api.h.
am:
5c35aa44a2
* commit '
5c35aa44a2d92185d9eee51781f2522773607986':
Delete unused function declarations from sdp_api.h.
Sharvil Nanavati [Thu, 11 Jun 2015 06:20:24 +0000 (23:20 -0700)]
Delete unused function declarations from sdp_api.h.
Change-Id: I8db02d557fdfc138f2ec8de2b2d45049175fd999
Nitin Arora [Fri, 4 Mar 2016 00:53:25 +0000 (00:53 +0000)]
Avoid SMP process if another pairing is in progress
am:
0bb891dc54
* commit '
0bb891dc54b64e6cc4f774f565c614dfaff05b3a':
Avoid SMP process if another pairing is in progress
Pavlin Radoslavov [Fri, 4 Mar 2016 00:53:20 +0000 (00:53 +0000)]
Remove MCB from mapping table when entry is released
am:
5170c746e5
* commit '
5170c746e5b1ac033de0555760be96d68b139695':
Remove MCB from mapping table when entry is released
Jakub Pawlowski [Fri, 4 Mar 2016 00:53:15 +0000 (00:53 +0000)]
Remove dead methods and callbacks
am:
ee6b6d0965
* commit '
ee6b6d096541cc0f8333ad93cdbbf45e221396c4':
Remove dead methods and callbacks
Nitin Arora [Thu, 28 Jan 2016 01:07:55 +0000 (17:07 -0800)]
Avoid SMP process if another pairing is in progress
This change prevents the incoming pairing/security request
from a remote device when pairing with another remote has
been initiated by the host and has not yet begun.
The pairing request by the second remote will be rejected
Bug:
22525598
Change-Id: I676c85af39d5418c699161ad11eee5951f9203d7
Pavlin Radoslavov [Thu, 3 Mar 2016 21:16:45 +0000 (13:16 -0800)]
Remove MCB from mapping table when entry is released
Explicitly remove MCB entry from the LCB mapping table when
the entry is released.
Bug:
27334916
Change-Id: I14e3f1f5eeffa33e733c4a116d0a70cd7c06753f
Jakub Pawlowski [Mon, 29 Feb 2016 21:23:04 +0000 (13:23 -0800)]
Remove dead methods and callbacks
Bug:
27455533
Change-Id: Ie5661577320810468dd635022027a1e1a2f70a3e
Jakub Pawlowski [Thu, 3 Mar 2016 22:32:34 +0000 (22:32 +0000)]
Simplify UUID handling in GATT cache
am:
be18a60781
* commit '
be18a6078194547400fa9594a62d9d1bea5d7bea':
Simplify UUID handling in GATT cache
Jakub Pawlowski [Thu, 3 Mar 2016 04:01:30 +0000 (20:01 -0800)]
Simplify UUID handling in GATT cache
Bug:
27455533
Change-Id: I653b563d3b3c233ffe31b0a35d396a66db363459
Srinu Jella [Thu, 3 Mar 2016 21:22:14 +0000 (21:22 +0000)]
Increase the number of security slots for other new profiles
am:
9fed745a38
* commit '
9fed745a38b1ff2c5d4d67ca06760da5b07b7f11':
Increase the number of security slots for other new profiles
Srinu Jella [Thu, 3 Mar 2016 21:22:09 +0000 (21:22 +0000)]
Correct the max SDU length used in BTIF layer
am:
f19ca75c17
* commit '
f19ca75c17b8ee0c19261d946c5353c820238bc6':
Correct the max SDU length used in BTIF layer
Srinu Jella [Tue, 25 Aug 2015 13:12:32 +0000 (18:42 +0530)]
Increase the number of security slots for other new profiles
Use case: MAP Sanity Test fail in multi-profile scenario.
Steps:
1. Connect to Instance 1 - Email Sanity Test Case
2. Connect to Instance 0&1 - Email & SMS Sanity Test Case
Failure: MAP sanity fail in multi-profile scenario.
Root Cause: some profile coonnection may fail in multi
profile scenario due to non availability of security id.
Fix: Increased the security slots to 75 to accomadate new
profiles introduced.
Change-Id: Ic7c0268aea654cba2dee0c323ca0342e71ebc577
Srinu Jella [Fri, 22 Jan 2016 10:04:16 +0000 (15:34 +0530)]
Correct the max SDU length used in BTIF layer
Use case: OPP Tx over L2CAP are failing due to invalid PUT packet from DUT.
Steps:
1. Make the Remote device setup with OPP server which supports MTU
of more than 8k.
2. Send file from DUT to Remote device.
3. Transfer always fails.
Failure: OPP Tx over L2CAP file transfer fail. It will always fail
if remote supports more than 8076 as the MTU.
Root Cause: Max SDU of L2CAP layer will be communicated to the upper
layers, and same length of SDU being sent from upper layer
to BTIF layer, but because of change in the max SDU of
BTIF, it will receive less bytes than expected will lead
to form incomplete PUT request.
Fix: Correct the max SDU length used from BTIF layer to be in
sync with max SDU calculation from L2CAP layer.
Change-Id: Ie037c85e798bebf6a71c56488aae37455725028c
Srinu Jella [Thu, 3 Mar 2016 19:49:45 +0000 (19:49 +0000)]
Merge "Reconstruct new packet to accomodate extra header length"
am:
ab6a1335bf
* commit '
ab6a1335bf15d722b6fb420641b0b0ccc0f80d13':
Reconstruct new packet to accomodate extra header length
Ajay Panicker [Thu, 3 Mar 2016 19:46:35 +0000 (19:46 +0000)]
Merge "Reconstruct new packet to accomodate extra header length"
Srinu Jella [Thu, 3 Mar 2016 19:46:08 +0000 (19:46 +0000)]
Enable debug logs for bluetooth process threads, modules
am:
0fa3554630
* commit '
0fa35546304901c62bafcb54420d23ace56a69c1':
Enable debug logs for bluetooth process threads, modules
Srinu Jella [Sun, 13 Sep 2015 12:54:52 +0000 (18:24 +0530)]
Reconstruct new packet to accomodate extra header length
Use case: Bluetooth process crash problem in the middle of RFCOMM
test cases due to buffer corruption detected while freeing it.
Root Cause: RFCOMM layer trying to reuse the same packet to send
to the lower layer but it will fail due to strick buffer
corruption checks.
Failure: Bluetooth process crash.
Fix: created a new packet to accomadate new header
and copied the same payload to the new packet.
Change-Id: I5d12b76229d11480f7f37bbcd3561de97c80a0c1
Srinu Jella [Thu, 3 Mar 2016 19:44:37 +0000 (19:44 +0000)]
Corrected the stream for error checking
am:
a73cf49473
* commit '
a73cf4947355e38d2f44f2f43e87e32a6ad83fd5':
Corrected the stream for error checking
JivakDhadse [Thu, 3 Mar 2016 19:44:33 +0000 (19:44 +0000)]
Revert "DO NOT MERGE Proper construction of AVDTP general reject message"
am:
ebc951060a -s ours
* commit '
ebc951060a76029c3dbc5784a766b09022fa9a19':
Revert "DO NOT MERGE Proper construction of AVDTP general reject message"
Srinu Jella [Tue, 1 Mar 2016 11:29:35 +0000 (16:59 +0530)]
Enable debug logs for bluetooth process threads, modules
Use case: Debug enhancement for bluetooth threads,
modules
- Most of the bluetooth process threads,modules uses
APIs provided from the OSI layer.
- This patch enables the debug logs to know when the
thread, module is created and exited.
- This would be useful while debugging the ON/OFF,
ANR issues.
Change-Id: I17f4f583d2c431725a8c44c586b29980b4bdab3f
Srinu Jella [Tue, 1 Mar 2016 14:15:41 +0000 (19:45 +0530)]
Corrected the stream for error checking
Replace event_stream with acl_stream
Change-Id: I9ceb75ee05bad5d2ef1af819b3930216cc750507
JivakDhadse [Fri, 7 Aug 2015 13:28:38 +0000 (18:58 +0530)]
Revert "DO NOT MERGE Proper construction of AVDTP general reject message"
This reverts commit
2ed10d442266eade44be121cd24fd473c85007d0.
Original change needs to be reverted to align with Errata
ESR04 where "Section 8.17, General Reject Page 71" of adopted
AvDTP Spec is changed to have "Invalid Signal Identifier"
in first 6 bits of Octet 1.
This change helps passing PTS case TP/SIG/SMG/ESR04/BI-28-C
Change-Id: Idfc960ce00662e8aacc26f3b3fdca9deca8a2aff
Ayan Ghosh [Tue, 3 Dec 2013 09:22:22 +0000 (14:52 +0530)]
Peer support of Absolute Volume to be updated only if device supports A2DP
Peer support of absolute Volume feature should be updated to Audio
frameworks only for device which supports A2DP Sink and AVRCP Absolute
Volume TG roles together.
Audio manager need not be updated for AVRCP only peer devices as
that would cause sudden rise in ongoing stream volume when avrcp only
device connects, if it is set to some lower value with other device
connected for A2DP.
Change-Id: I75509d0b0fd1b06fa08390940a327dd2887d7562
Ayan Ghosh [Fri, 26 Dec 2014 12:48:28 +0000 (18:18 +0530)]
Limit Max Bitpool value to SPEC recommended one
Preferred bipool for 44.1 KHz sampling rate for SBC
codec is considered as 53. Hence limit Max Bitpool
value to 53 in setconfig request to have it same as
the one DUT sets in getConfig response and in encoding
pcm packets.
few BMW series of CKs does not connect unless DUT
configures max bitpool in setconfig request to 53.
Change-Id: Ie7ca504c23f6bae8fda997cdeb3e0ff0733defb0
Ayan Ghosh [Wed, 7 Aug 2013 14:35:29 +0000 (20:05 +0530)]
Allow Carkit to trigger play immediately after call
Removing check in stack where AVRCP Play and Pause commands
are being dropped if carkit initiates play or pause within
six seconds.
This addresses the scenario where JCI-Mazda CK pauses the
streaming by initiating Avrcp Pause right before making call
and can not resume the streaming by sending Avrcp Play right
after call ends.
Change-Id: Ibb04223de746f528b356e78bd65130d3fd526a44
Satish Kodishala [Thu, 27 Aug 2015 05:21:45 +0000 (10:51 +0530)]
Initialize sco codecs supported with CVSD
Usecase:
1. Connect headset/carkit supporting codec negotiation
but does not send AT+BAC with available codecs.
2. Make a call and create SCO connection.
3. Transfer audio to AG from headset/carkit.
4. Transfer audio back to carkit.
Failure:
AG will not establish SCO connection with remote.
Rootcause:
We initialize codecs supported by remote as 0 and update
it with codecs received as part of AT+BAC. When AG sends
+BCS to start codec negotiation, it received AT+BCS=1 from
remote. Since 1 is not in the list of remote supported codecs
(0), AG will not create SCO connection in step#4.
Fix:
Initialize sco codecs supported by remote with mandatory
codec, CVSD.
Change-Id: Ibe0e1a7bd3e59e8618568d320acfbde88f3fc11e
Satish Kodishala [Tue, 15 Sep 2015 14:16:41 +0000 (19:46 +0530)]
Ignore empty optional parameters in CLCC response
Usecase:
Pair and connect with AG that sends the optional parameters
in CLCC response.
Failure:
When optional parameters in CLCC response from AG is empty,
HF client is not parsing the empty optional parameters.
User may not be see the phone number on UI properly on
hf client device.
Root cause:
AGs like iPhone sends optional parameters in the CLCC response.
HF client is returning NULL when it encounters empty optional parameters.
Fix:
Ignore empty optional parameters in CLCC Response from AG.
Change-Id: Ia90986ccc4c9c9f1a6fb3a914bc1df8b0a75ba0f
Satish Kodishala [Thu, 25 Jun 2015 08:53:17 +0000 (14:23 +0530)]
Clear remote BD address if SDP search fails
Use case:
1. Enable multi hf.
2. Pair and connect to a headset.
3. Turn off headset and try connecting to headset from AG.
4. After the connection fails, turn on headset.
5. Make sure headset initiates HF connection to AG.
6. Make MO/MT call, switch from headset to AG, vice versa using headset.
Failure:
When call is transferred from AG to headset, headset initiated
SCO connection request is rejected by AG.
Root cause:
For outgoing connection in step 3, SDP search fails. BD address of
remote headset is stored in scb[0]. BD address of headset with which
we tried to connect is not cleared in scb[0].
When incoming HF connection request is accepted in step 5, BD address
of headset is stored in scb[1]. Now, BD address of the same headset is
stored in both scb[0], scb[1].
When SCO connection request is received from headset, we get scb
information using BD address. However, since BD address in scb[0]
is not cleared, we end up selecting scb[0] for which there is no
headset connected. This makes us think that remote is initiating
SCO connection without SLC and we reject the SCO connection.
Fix:
Clear the BD address of remote when SDP search fails.
Change-Id: I21a0b83fcd47fed91e28fe27bdfd6d541b6a527c
Satish Kodishala [Tue, 2 Feb 2016 11:52:15 +0000 (17:22 +0530)]
Do not reset Sniff Subrating parameters on SCO link
Usecase:
1. Pair and connect to BT headset
2. Pair and connect to a watch
3. Pair and connect a LE device
4. Make a call and reset BT on phone
5. Verify devices connect back and SCO is established
Failure:
After BT reset, devices connect and SCO is up. After some time,
SCO and ACL link disconnects due to connection timeout.
Rootcause:
When Headset is connected during active call, HFP is connected
first. Due to active call, SCO is also established. When SCO is
established, we disable sniff subrating(SSR). When A2DP is
connected after SCO connection, it enables SSR. This enabling
of SSR is causing ACL disconnect.
Fix:
When there is new profile connection for the same device which
has SCO, we should not enable SSR. It should be enabled only
when there is no SCO.
Change-Id: I7815dba90851366ecc0523447c2394631c10ede1
Mallikarjuna GB [Tue, 23 Jun 2015 09:49:29 +0000 (15:19 +0530)]
Update the sniff policy when SCO is active
Use case:
1. Connect BT headset.
2. Make an outgoing call or receive a call on BT headset.
3. Check if sniff parameters are taking affect when SCO is active.
Failure:
Sniff parameters when SCO is active are not taking affect.
Root cause:
SCO link was not checked when updating power manager(PM)
about idle or busy states.
Fix:
During AG tx/rx activity, update PM based on SCO state.
Change-Id: I4c09406395998bacf13471a273402a60f3b77f89
Jakub Pawlowski [Thu, 3 Mar 2016 17:06:23 +0000 (17:06 +0000)]
Revert "Remove unused field p_cur_char"
This reverts commit
25e17fb1c7a894dec49fc8eddb2bbfb20a9eeb21.
Change-Id: I21936ae37c1e052ab53233b3465e336369a423df