OSDN Git Service
Bruce Momjian [Mon, 18 Apr 2005 13:11:04 +0000 (13:11 +0000)]
Add description that WAL files used during backup have to be archived
before you are done.
Bruce Momjian [Mon, 18 Apr 2005 12:58:45 +0000 (12:58 +0000)]
Add HTML version of TODO to CVS, for web site use.
Bruce Momjian [Mon, 18 Apr 2005 12:58:11 +0000 (12:58 +0000)]
Add HTML TODO version to CVS.
Bruce Momjian [Mon, 18 Apr 2005 12:51:41 +0000 (12:51 +0000)]
Add description about partial WAL archiving for PITR:
>
> Doing this will allow administrators to know more easily when the
> archive contins all the files needed for point-in-time recovery.
Bruce Momjian [Mon, 18 Apr 2005 03:46:31 +0000 (03:46 +0000)]
Fix html.
Bruce Momjian [Mon, 18 Apr 2005 03:17:23 +0000 (03:17 +0000)]
Test new html tag.
Bruce Momjian [Mon, 18 Apr 2005 03:00:44 +0000 (03:00 +0000)]
Add:
> * Force archiving of partially-full WAL files when pg_stop_backup() is
> called or the server is stopped
Bruce Momjian [Mon, 18 Apr 2005 01:29:00 +0000 (01:29 +0000)]
Update PITR mention of which WAL files are needed.
Tom Lane [Sun, 17 Apr 2005 22:24:02 +0000 (22:24 +0000)]
Initial implementation of lossy-tuple-bitmap data structures.
Not connected to anything useful yet ...
Bruce Momjian [Sun, 17 Apr 2005 03:05:19 +0000 (03:05 +0000)]
Clarify name of file to be checked for PITR expiring.
Bruce Momjian [Sun, 17 Apr 2005 03:04:29 +0000 (03:04 +0000)]
Fix comment typo.
Tom Lane [Sat, 16 Apr 2005 20:07:35 +0000 (20:07 +0000)]
Create a new 'MultiExecProcNode' call API for plan nodes that don't
return just a single tuple at a time. Currently the only such node
type is Hash, but I expect we will soon have indexscans that can return
tuple bitmaps. A side benefit is that EXPLAIN ANALYZE now shows the
correct tuple count for a Hash node.
Tom Lane [Sat, 16 Apr 2005 16:50:01 +0000 (16:50 +0000)]
Minor improvements to locale documentation.
Tom Lane [Fri, 15 Apr 2005 22:19:48 +0000 (22:19 +0000)]
Reduce PANIC to ERROR in several xlog routines that are used in both
critical and noncritical contexts (an example of noncritical being
post-checkpoint removal of dead xlog segments). In the critical cases
the CRIT_SECTION mechanism will cause ERROR to be promoted to PANIC
anyway, and in the noncritical cases we shouldn't let an error take
down the entire database. Arguably there should be *no* explicit
PANIC errors in this module, only more START/END_CRIT_SECTION calls,
but I didn't go that far. (Yet.)
Tom Lane [Fri, 15 Apr 2005 18:48:10 +0000 (18:48 +0000)]
Modify MoveOfflineLogs/InstallXLogFileSegment to avoid O(N^2) behavior
when recycling a large number of xlog segments during checkpoint.
The former behavior searched from the same start point each time,
requiring O(checkpoint_segments^2) stat() calls to relocate all the
segments. Instead keep track of where we stopped last time through.
Tom Lane [Fri, 15 Apr 2005 16:40:36 +0000 (16:40 +0000)]
Revert addition of poorly-thought-out DUMP TIMESTAMP archive entry,
which induced bug #1597 in addition to having several other misbehaviors
(like labeling the dump with a completion time having nothing to do with
reality). Instead just print out the desired strings where RestoreArchive
was already emitting the 'PostgreSQL database dump' and
'PostgreSQL database dump complete' strings.
Neil Conway [Fri, 15 Apr 2005 04:29:32 +0000 (04:29 +0000)]
This patch changes the use of varargs.h to stdarg.h as
required by modern versions of GCC.
Niels Breet
Neil Conway [Fri, 15 Apr 2005 04:18:10 +0000 (04:18 +0000)]
Remove an unused variable "waitingForSignal". From Qingqing Zhou.
Bruce Momjian [Thu, 14 Apr 2005 23:20:55 +0000 (23:20 +0000)]
Done
> * -Use indexes for MIN() and MAX()
Tom Lane [Thu, 14 Apr 2005 22:34:48 +0000 (22:34 +0000)]
Make equalTupleDescs() compare attlen/attbyval/attalign rather than
assuming comparison of atttypid is sufficient. In a dropped column
atttypid will be 0, and we'd better check the physical-storage data
to make sure the tupdescs are physically compatible.
I do not believe there is a real risk before 8.0, since before that
we only used this routine to compare successive states of the tupdesc
for a particular relation. But 8.0's typcache.c might be comparing
arbitrary tupdescs so we'd better play it safer.
Tom Lane [Thu, 14 Apr 2005 22:09:40 +0000 (22:09 +0000)]
Put back blessing of record-function tupledesc, which I removed in a
fit of over-optimization.
Tom Lane [Thu, 14 Apr 2005 21:44:09 +0000 (21:44 +0000)]
Don't try to constant-fold functions returning RECORD, since the optimizer
isn't presently set up to pass them an expected tuple descriptor. Bug has
been there since 7.3 but was just recently reported by Thomas Hallgren.
Tom Lane [Thu, 14 Apr 2005 20:53:09 +0000 (20:53 +0000)]
Must count '*' characters as potential arguments.
Tom Lane [Thu, 14 Apr 2005 20:32:43 +0000 (20:32 +0000)]
Marginal hack to use a specialized hash function for dynahash hashtables
whose keys are OIDs. The only one that looks particularly performance
critical is the relcache hashtable, but as long as we've got the function
we may as well use it wherever it's applicable.
Tom Lane [Thu, 14 Apr 2005 20:03:27 +0000 (20:03 +0000)]
Completion of project to use fixed OIDs for all system catalogs and
indexes. Replace all heap_openr and index_openr calls by heap_open
and index_open. Remove runtime lookups of catalog OID numbers in
various places. Remove relcache's support for looking up system
catalogs by name. Bulky but mostly very boring patch ...
Michael Meskes [Thu, 14 Apr 2005 10:08:57 +0000 (10:08 +0000)]
Added patch by Philip Yarra <philip.yarra@internode.on.net> for a bug in thread support.
Tom Lane [Thu, 14 Apr 2005 01:38:22 +0000 (01:38 +0000)]
First phase of project to use fixed OIDs for all system catalogs and
indexes. Extend the macros in include/catalog/*.h to carry the info
about hand-assigned OIDs, and adjust the genbki script and bootstrap
code to make the relations actually get those OIDs. Remove the small
number of RelOid_pg_foo macros that we had in favor of a complete
set named like the catname.h and indexing.h macros. Next phase will
get rid of internal use of names for looking up catalogs and indexes;
but this completes the changes forcing an initdb, so it looks like a
good place to commit.
Along the way, I made the shared relations (pg_database etc) not be
'bootstrap' relations any more, so as to reduce the number of hardwired
entries and simplify changing those relations in future. I'm not
sure whether they ever really needed to be handled as bootstrap
relations, but it seems to work fine to not do so now.
Tom Lane [Wed, 13 Apr 2005 18:54:57 +0000 (18:54 +0000)]
Simplify initdb-time assignment of OIDs as I proposed yesterday, and
avoid encroaching on the 'user' range of OIDs by allowing automatic
OID assignment to use values below 16k until we reach normal operation.
initdb not forced since this doesn't make any incompatible change;
however a lot of stuff will have different OIDs after your next initdb.
Tom Lane [Wed, 13 Apr 2005 16:50:55 +0000 (16:50 +0000)]
Change addRangeTableEntryForRelation() to take a Relation pointer instead
of just a relation OID, thereby not having to open the relation for itself.
This actually saves code rather than adding it for most of the existing
callers, which had the rel open already. The main point though is to be
able to use this rather than plain addRangeTableEntry in setTargetTable,
thus saving one relation_openrv/relation_close cycle for every INSERT,
UPDATE, or DELETE. Seems to provide a several percent win on simple
INSERTs.
Tom Lane [Wed, 13 Apr 2005 16:15:35 +0000 (16:15 +0000)]
Revert yesterday's change to make pg_cast.h say 'OID = 0' in DATA entries.
On reflection, we ought to get rid of that mechanism entirely.
Neil Conway [Wed, 13 Apr 2005 00:20:10 +0000 (00:20 +0000)]
Minor consistency improvement to the documentation on array functions.
Tom Lane [Tue, 12 Apr 2005 19:45:43 +0000 (19:45 +0000)]
Adjust pg_cast.h so that the OIDs assigned to built-in casts come from
genbki.sh's pool (10000-16383) instead of being run-time assigned by
heap_insert. Might as well use the pool as long as it's there ...
I was a bit bemused to realize that it hadn't been in use at all since 7.2.
initdb not forced since this doesn't really affect anything. The OIDs
of casts and system indexes will change next time you do one, though.
Tom Lane [Tue, 12 Apr 2005 19:29:24 +0000 (19:29 +0000)]
Remove unnecessary UPDATE commands to assign explicit ACLs to functions
and PL languages during initdb. The default permissions for these objects
are the same as what we were assigning anyway, so there is no need to
expend space in the catalogs on them. The space cost is particularly
significant in pg_proc's indexes, which are bloated by about a factor of 2
by the full-table update, and can never really recover the space.
initdb not forced, since the change has no actual impact on behavior.
Peter Eisentraut [Tue, 12 Apr 2005 14:19:43 +0000 (14:19 +0000)]
Revert mistaken renaming of UTF-8.
Tom Lane [Tue, 12 Apr 2005 05:11:28 +0000 (05:11 +0000)]
Fix oversight in MIN/MAX optimization: must not return NULL entries
from index, since the aggregates ignore NULLs.
Tom Lane [Tue, 12 Apr 2005 04:26:34 +0000 (04:26 +0000)]
Add aggsortop column to pg_aggregate, so that MIN/MAX optimization can
be supported for all datatypes. Add CREATE AGGREGATE and pg_dump support
too. Add specialized min/max aggregates for bpchar, instead of depending
on text's min/max, because otherwise the possible use of bpchar indexes
cannot be recognized.
initdb forced because of catalog changes.
Tom Lane [Tue, 12 Apr 2005 03:16:50 +0000 (03:16 +0000)]
Fix broken markup.
Tom Lane [Mon, 11 Apr 2005 23:06:57 +0000 (23:06 +0000)]
Create the planner mechanism for optimizing simple MIN and MAX queries
into indexscans on matching indexes. For the moment, it only handles
int4 and text datatypes; next step is to add a column to pg_aggregate
so that all MIN/MAX aggregates can be handled. Per my recent proposal.
Tom Lane [Mon, 11 Apr 2005 19:51:16 +0000 (19:51 +0000)]
Fix interaction between materializing holdable cursors and firing
deferred triggers: either one can create more work for the other,
so we have to loop till it's all gone. Per example from andrew@supernews.
Add a regression test to help spot trouble in this area in future.
Tom Lane [Mon, 11 Apr 2005 15:59:34 +0000 (15:59 +0000)]
PersistHoldablePortal must establish the correct value for ActiveSnapshot
while completing execution of the cursor's query. Otherwise we get wrong
answers or even crashes from non-volatile functions called by the query.
Per report from andrew@supernews.
Bruce Momjian [Sun, 10 Apr 2005 23:21:33 +0000 (23:21 +0000)]
Update to XHTML.
Tom Lane [Sun, 10 Apr 2005 20:57:32 +0000 (20:57 +0000)]
Make constant-folding produce sane output for COALESCE(NULL,NULL),
that is a plain NULL and not a COALESCE with no inputs. Fixes crash
reported by Michael Williamson.
Tom Lane [Sun, 10 Apr 2005 19:50:08 +0000 (19:50 +0000)]
Split out into a separate function the code in grouping_planner() that
decides whether to use hashed grouping instead of sort-plus-uniq
grouping. The function needs an annoyingly large number of parameters,
but this still seems like a win for legibility, since it removes over
a hundred lines from grouping_planner (which is still too big :-().
Tom Lane [Sun, 10 Apr 2005 18:04:20 +0000 (18:04 +0000)]
SQL functions returning pass-by-reference types were copying the results
into the wrong memory context, resulting in a query-lifespan memory leak.
Bug is new in 8.0, I believe. Per report from Rae Stiening.
Bruce Momjian [Sat, 9 Apr 2005 04:07:03 +0000 (04:07 +0000)]
Done:
< * Allow additional tables to be specified in DELETE for joins
> * -Allow additional tables to be specified in DELETE for joins
Bruce Momjian [Sat, 9 Apr 2005 03:52:43 +0000 (03:52 +0000)]
We don't put URL's in ulink's because the URL is always generated, but
we can put words in ulink and the URL will still be printed.
per Peter
Tom Lane [Fri, 8 Apr 2005 14:18:35 +0000 (14:18 +0000)]
If we're going to have a non-panic check for held_lwlocks[] overrun,
it must occur *before* we get into the critical state of holding a
lock we have no place to record. Per discussion with Qingqing Zhou.
Tom Lane [Fri, 8 Apr 2005 03:43:54 +0000 (03:43 +0000)]
Use an always-there test, not an Assert, to check for overrun of
the held_lwlocks[] array. Per Qingqing Zhou.
Neil Conway [Fri, 8 Apr 2005 00:59:59 +0000 (00:59 +0000)]
Change the default setting of "add_missing_from" to false. This has been
the long-term plan for this behavior for quite some time, but it is only
possible now that DELETE has a USING clause so that the user can join
other tables in a DELETE statement without relying on this behavior.
Neil Conway [Fri, 8 Apr 2005 00:55:07 +0000 (00:55 +0000)]
Use fork_process() to avoid some fork()-related boilerplate code when
forking the stats collector child process.
Tom Lane [Thu, 7 Apr 2005 19:04:13 +0000 (19:04 +0000)]
Update and copy-edit release notes for 8.0.2.
Tom Lane [Thu, 7 Apr 2005 15:23:06 +0000 (15:23 +0000)]
Fix some issues with missing or too many newlines at
end of file.
Tom Lane [Thu, 7 Apr 2005 14:53:04 +0000 (14:53 +0000)]
Allow plpgsql functions to omit RETURN command when the function returns
output parameters or VOID or a set. There seems no particular reason to
insist on a RETURN in these cases, since the function return value is
determined by other elements anyway. Per recent discussion.
Neil Conway [Thu, 7 Apr 2005 03:31:42 +0000 (03:31 +0000)]
Minor documentation tweak.
Neil Conway [Thu, 7 Apr 2005 03:29:01 +0000 (03:29 +0000)]
Fix minor breakage to regression tests induced in previous commit -- I had
updated the expected/ output, not the output/ output. Apologies.
Neil Conway [Thu, 7 Apr 2005 01:51:41 +0000 (01:51 +0000)]
Add a "USING" clause to DELETE, which is equivalent to the FROM clause
in UPDATE. We also now issue a NOTICE if a query has _any_ implicit
range table entries -- in the past, we would only warn about implicit
RTEs in SELECTs with at least one explicit RTE.
As a result of the warning change, 25 of the regression tests had to
be updated. I also took the opportunity to remove some bogus whitespace
differences between some of the float4 and float8 variants. I believe
I have correctly updated all the platform-specific variants, but let
me know if that's not the case.
Original patch for DELETE ... USING from Euler Taveira de Oliveira,
reworked by Neil Conway.
Neil Conway [Wed, 6 Apr 2005 23:56:07 +0000 (23:56 +0000)]
Apply the "nodeAgg" optimization to more of the builtin transition
functions. This patch optimizes int2_sum(), int4_sum(), float4_accum()
and float8_accum() to avoid needing to copy the transition function's
state for each input tuple of the aggregate. In an extreme case
(e.g. SELECT sum(int2_col) FROM table where table has a single column),
it improves performance by about 20%. For more complex queries or tables
with wider rows, the relative performance improvement will not be as
significant.
Tom Lane [Wed, 6 Apr 2005 20:13:49 +0000 (20:13 +0000)]
Remove test for NULL node in ExecProcNode(). No place ever calls
ExecProcNode() with a NULL value, so the test couldn't do anything
for us except maybe mask bugs. Removing it probably doesn't save
anything much either, but then again this is a hot-spot routine.
Tom Lane [Wed, 6 Apr 2005 16:34:07 +0000 (16:34 +0000)]
Merge Resdom nodes into TargetEntry nodes to simplify code and save a
few palloc's. I also chose to eliminate the restype and restypmod fields
entirely, since they are redundant with information stored in the node's
contained expression; re-examining the expression at need seems simpler
and more reliable than trying to keep restype/restypmod up to date.
initdb forced due to change in contents of stored rules.
Bruce Momjian [Wed, 6 Apr 2005 15:19:03 +0000 (15:19 +0000)]
Attached patch cleans up the HTML code in tools/backend. This is
required for us to pull it into the main website. Same kind of fixes as
last time, just make sure things aren't violating the HTML standard. No
context changes at all.
Magnus Hagander
Neil Conway [Wed, 6 Apr 2005 05:23:32 +0000 (05:23 +0000)]
Include information about a domain's CHECK constraint, if any, in the
output of \dD in psql. From Greg Sabino Mullane.
Neil Conway [Wed, 6 Apr 2005 04:34:22 +0000 (04:34 +0000)]
This file was whacked by pgindent before it knew it shouldn't remove
braces around single statements (for PG_TRY macros). This patch fixes
it. Alvaro Herrera.
Tom Lane [Tue, 5 Apr 2005 18:05:46 +0000 (18:05 +0000)]
Adjust grammar for plpgsql's OPEN command so that a cursor can be
OPENed on non-SELECT commands such as EXPLAIN or SHOW (anything that
returns tuples is allowed). This flexibility already existed for
bound cursors, but OPEN was artificially restricting what it would
take. Per a gripe some months back.
Tom Lane [Tue, 5 Apr 2005 06:22:17 +0000 (06:22 +0000)]
plpgsql does OUT parameters, as per my proposal a few weeks ago.
Tom Lane [Tue, 5 Apr 2005 04:47:19 +0000 (04:47 +0000)]
Fix broken markup.
Neil Conway [Mon, 4 Apr 2005 23:50:27 +0000 (23:50 +0000)]
This patch changes int2_avg_accum() and int4_avg_accum() use the nodeAgg
performance hack Tom introduced recently. This means we can avoid
copying the transition array for each input tuple if these functions
are invoked as aggregate transition functions.
To test the performance improvement, I created a 1 million row table
with a single int4 column. Without the patch, SELECT avg(col) FROM
table took about 4.2 seconds (after the data was cached); with the
patch, it took about 3.2 seconds. Naturally, the performance
improvement for a less trivial query (or a table with wider rows)
would be relatively smaller.
Neil Conway [Mon, 4 Apr 2005 07:19:44 +0000 (07:19 +0000)]
Minor fixes for psql tab completion. Spell "absolute" like the English word,
not the brand of vodka. Complete FETCH <sth> <sth> with FROM and IN, not
FROM and TO (which is still pretty incomplete, but at least its the right
syntax).
Neil Conway [Mon, 4 Apr 2005 05:12:32 +0000 (05:12 +0000)]
Add a link to postgresql.org/download to the installation instructions.
From Robert Treat.
Neil Conway [Mon, 4 Apr 2005 04:34:41 +0000 (04:34 +0000)]
Remove an unused variable `ShmemBootstrap', and remove an obsolete
comment. Patch from Alvaro.
Tom Lane [Mon, 4 Apr 2005 01:43:12 +0000 (01:43 +0000)]
In cost_mergejoin, the early-exit effect should not apply to the
outer side of an outer join. Per andrew@supernews.
Tom Lane [Sun, 3 Apr 2005 00:01:51 +0000 (00:01 +0000)]
Put back code mistakenly removed from copy of postmaster's
daemonize routine, namely forcing stdin/stdout/stderr to point
to /dev/null. Per Karl Denninger.
Bruce Momjian [Sat, 2 Apr 2005 03:42:41 +0000 (03:42 +0000)]
Fix release not typo.
Bruce Momjian [Sat, 2 Apr 2005 02:42:01 +0000 (02:42 +0000)]
Update release notes for 8.0.2.
Tom Lane [Fri, 1 Apr 2005 20:31:50 +0000 (20:31 +0000)]
Second try at making examine_variable and friends behave sanely in
cases with binary-compatible relabeling. My first try was implicitly
assuming that all operators scalarineqsel is used for have binary-
compatible datatypes on both sides ... which is very wrong of course.
Per report from Michael Fuhr.
Tom Lane [Fri, 1 Apr 2005 19:34:06 +0000 (19:34 +0000)]
Make plperl work with OUT parameters.
Tom Lane [Fri, 1 Apr 2005 19:32:51 +0000 (19:32 +0000)]
Minor improvements in the really-pretty-ad-hoc test scripts for the
PL languages.
Tom Lane [Fri, 1 Apr 2005 18:35:41 +0000 (18:35 +0000)]
Teach pg_dump about OUT parameters.
Bruce Momjian [Fri, 1 Apr 2005 16:34:31 +0000 (16:34 +0000)]
Update pgcvslog examples.
Bruce Momjian [Fri, 1 Apr 2005 14:25:23 +0000 (14:25 +0000)]
Fix wrong week returnded by date_trunc('week') for early dates in
January --- would return wrong year for 2005-01-01 and 2006-01-01.
per report from Robert Creager.
Backpatch to 8.0.X.
Bruce Momjian [Fri, 1 Apr 2005 13:25:10 +0000 (13:25 +0000)]
Update pgcvslog examples.
Neil Conway [Fri, 1 Apr 2005 08:41:19 +0000 (08:41 +0000)]
Remove pg_buffercache_pages.h -- patch from Mark Kirkwood.
Bruce Momjian [Fri, 1 Apr 2005 05:30:38 +0000 (05:30 +0000)]
Adjust pg_proc.proargtypes[0] tests in psql \df to handle new NULL value
for a function taking no arguments, per report from Michael Fuhr.
Tom Lane [Thu, 31 Mar 2005 23:20:49 +0000 (23:20 +0000)]
Flush any remaining statistics counts out to the collector at process
exit. Without this, operations triggered during backend exit (such as
temp table deletions) won't be counted ... which given heavy usage of
temp tables can lead to pg_autovacuum falling way behind on the need
to vacuum pg_class and pg_attribute. Per reports from Steve Crawford
and others.
Tom Lane [Thu, 31 Mar 2005 22:46:33 +0000 (22:46 +0000)]
First phase of OUT-parameters project. We can now define and use SQL
functions with OUT parameters. The various PLs still need work, as does
pg_dump. Rudimentary docs and regression tests included.
Teodor Sigaev [Thu, 31 Mar 2005 15:08:08 +0000 (15:08 +0000)]
1 fix various comparing functions
2 implement gtsvector_out for use with gevel module (debug GiST indexes, http://www.sai.msu.su/~megera/postgres/gist/gevel/)
Bruce Momjian [Thu, 31 Mar 2005 03:54:38 +0000 (03:54 +0000)]
Adjust SGML ulink tags to the URL is always displayed in our printed docs.
Neil Conway [Thu, 31 Mar 2005 02:02:52 +0000 (02:02 +0000)]
Minor code cleanup: ExecHash() was returning a null TupleTableSlot, and an
old comment in the code claimed that this was necessary. Since it is not
actually necessary any more, it is clearer to remove the comment and
just return NULL instead -- the return value of ExecHash() is not used.
Neil Conway [Thu, 31 Mar 2005 00:45:26 +0000 (00:45 +0000)]
Fix build error in pg_buffercache on Win32 (native and cygwin). From
Mark Kirkwood.
Neil Conway [Wed, 30 Mar 2005 05:05:01 +0000 (05:05 +0000)]
Document that the "-P" option to pg_autovacuum is insecure on many
platforms, and suggest using ~/.pgpass instead.
Neil Conway [Wed, 30 Mar 2005 04:52:49 +0000 (04:52 +0000)]
Minor tweak to documentation.
Neil Conway [Wed, 30 Mar 2005 02:08:39 +0000 (02:08 +0000)]
Fix typo.
Tom Lane [Tue, 29 Mar 2005 19:44:23 +0000 (19:44 +0000)]
Add proallargtypes and proargmodes columns to pg_proc, as per my earlier
proposal for OUT parameter support. The columns don't actually *do*
anything yet, they are just left NULLs. But I thought I'd commit this
part separately as a fairly pure example of the tasks needed when adding
a column to pg_proc or one of the other core system tables.
Tom Lane [Tue, 29 Mar 2005 17:58:51 +0000 (17:58 +0000)]
Fix grammar for IN/OUT/INOUT parameters. This commit doesn't actually
implement any new feature, it just pushes the 'not implemented' error
message deeper into the backend. I also tweaked the grammar to accept
Oracle-ish parameter syntax (parameter name first), as well as the
SQL99 standard syntax (parameter mode first), since it was easy and
people will doubtless try to use both anyway.
Tom Lane [Tue, 29 Mar 2005 03:01:32 +0000 (03:01 +0000)]
Officially decouple FUNC_MAX_ARGS from INDEX_MAX_KEYS, and set the
former to 100 by default. Clean up some of the less necessary
dependencies on FUNC_MAX_ARGS; however, the biggie (FunctionCallInfoData)
remains.
Neil Conway [Tue, 29 Mar 2005 02:53:53 +0000 (02:53 +0000)]
Add SPI_getnspname(), including documentation.
Tom Lane [Tue, 29 Mar 2005 00:17:27 +0000 (00:17 +0000)]
Convert oidvector and int2vector into variable-length arrays. This
change saves a great deal of space in pg_proc and its primary index,
and it eliminates the former requirement that INDEX_MAX_KEYS and
FUNC_MAX_ARGS have the same value. INDEX_MAX_KEYS is still embedded
in the on-disk representation (because it affects index tuple header
size), but FUNC_MAX_ARGS is not. I believe it would now be possible
to increase FUNC_MAX_ARGS at little cost, but haven't experimented yet.
There are still a lot of vestigial references to FUNC_MAX_ARGS, which
I will clean up in a separate pass. However, getting rid of it
altogether would require changing the FunctionCallInfoData struct,
and I'm not sure I want to buy into that.
Tom Lane [Mon, 28 Mar 2005 01:50:34 +0000 (01:50 +0000)]
Remove dead push/pop rollback code. Vadim once planned to implement
transaction rollback via UNDO but I think that's highly unlikely to
happen, so we may as well remove the stubs. (Someday we ought to
rip out the stub xxx_undo routines, too.) Per Alvaro.
Tom Lane [Mon, 28 Mar 2005 00:58:26 +0000 (00:58 +0000)]
Rethink the order of expression preprocessing: eval_const_expressions
really ought to run before canonicalize_qual, because it can now produce
forms that canonicalize_qual knows how to improve (eg, NOT clauses).
Also, because eval_const_expressions already knows about flattening
nested ANDs and ORs into N-argument form, the initial flatten_andors
pass in canonicalize_qual is now completely redundant and can be
removed. This doesn't save a whole lot of code, but the time and
palloc traffic eliminated is a useful gain on large expression trees.
Tom Lane [Sun, 27 Mar 2005 23:53:05 +0000 (23:53 +0000)]
First steps towards index scans with heap access decoupled from index
access: define new index access method functions 'amgetmulti' that can
fetch multiple TIDs per call. (The functions exist but are totally
untested as yet.) Since I was modifying pg_am anyway, remove the
no-longer-needed 'rel' parameter from amcostestimate functions, and
also remove the vestigial amowner column that was creating useless
work for Alvaro's shared-object-dependencies project.
Initdb forced due to changes in pg_am.
Tom Lane [Sun, 27 Mar 2005 19:18:02 +0000 (19:18 +0000)]
Teach const-expression simplification to simplify boolean equality cases,
that is 'x = true' becomes 'x' and 'x = false' becomes 'NOT x'. This isn't
all that amazingly useful in itself, but it ensures that we will recognize
the different forms as being logically equivalent when checking partial
index predicates. Per example from Patrick Clery.