OSDN Git Service
Peter Eisentraut [Mon, 16 Oct 2006 17:24:54 +0000 (17:24 +0000)]
Punt when trying to build with threaded Python on FreeBSD.
Also cut back on excessive use of *** to decorate configure error messages.
If it's an error message, you are sure to see it without any decoration.
Tom Lane [Sun, 15 Oct 2006 22:04:08 +0000 (22:04 +0000)]
Redesign the patch for allocation of shmem space and LWLocks for add-on
modules; the first try was not usable in EXEC_BACKEND builds (e.g.,
Windows). Instead, just provide some entry points to increase the
allocation requests during postmaster start, and provide a dedicated
LWLock that can be used to synchronize allocation operations performed
by backends. Per discussion with Marc Munro.
Tom Lane [Sun, 15 Oct 2006 18:56:39 +0000 (18:56 +0000)]
Adjust plperl to ensure that all strings and hash keys passed to Perl
are marked as UTF8 when the database encoding is UTF8. This should
avoid inconsistencies like that exhibited in bug #2683 from Vitali Stupin.
Bruce Momjian [Sun, 15 Oct 2006 03:10:20 +0000 (03:10 +0000)]
Update Japanese FAQ.
Jun Kuwamura
Bruce Momjian [Sat, 14 Oct 2006 23:08:48 +0000 (23:08 +0000)]
FAQ updates --- This is a small cosmetic patch that adds pt_BR IRC
channel to the lists of IRC channels, fixes a typo in the OID's
question, and corrects the PGCluster's project name.
Euler Taveira de Oliveira
Tom Lane [Sat, 14 Oct 2006 23:07:22 +0000 (23:07 +0000)]
Code review for --no-data-for-failed-tables patch. Instead of trashing
one of the program's core data structures, make use of the existing
ability to selectively exclude TOC items by ID. Slightly more code but
much less likely to create future maintenance problems.
Tom Lane [Fri, 13 Oct 2006 21:43:19 +0000 (21:43 +0000)]
Code and docs review for ALTER TABLE INHERIT/NO INHERIT patch.
Peter Eisentraut [Fri, 13 Oct 2006 20:23:07 +0000 (20:23 +0000)]
Make unknown-option-warning code more portable. echo -n is not portable,
and neither is "|" or "\|" in basic regular expressions.
Bruce Momjian [Fri, 13 Oct 2006 17:29:43 +0000 (17:29 +0000)]
Update Japanese FAQ.
Jun Kuwamura
Tom Lane [Fri, 13 Oct 2006 15:24:56 +0000 (15:24 +0000)]
Fix typo in version number.
Bruce Momjian [Fri, 13 Oct 2006 14:19:29 +0000 (14:19 +0000)]
Fix test_fsync compile on MinGW(win32)
Hiroshi Saito
Teodor Sigaev [Fri, 13 Oct 2006 13:59:47 +0000 (13:59 +0000)]
Fix infinite sleep and failes of send in Win32.
1) pgwin32_waitforsinglesocket(): WaitForMultipleObjectsEx now called with
finite timeout (100ms) in case of FP_WRITE and UDP socket. If timeout occurs
then pgwin32_waitforsinglesocket() tries to write empty packet goes to
WaitForMultipleObjectsEx again.
2) pgwin32_send(): add loop around WSASend and pgwin32_waitforsinglesocket().
The reason is: for overlapped socket, 'ok' result from
pgwin32_waitforsinglesocket() isn't guarantee that socket is still free,
it can become busy again and following WSASend call will fail with
WSAEWOULDBLOCK error.
See http://archives.postgresql.org/pgsql-hackers/2006-10/msg00561.php
Bruce Momjian [Thu, 12 Oct 2006 22:33:04 +0000 (22:33 +0000)]
Remove:
< o Issue a notice if CREATE TABLE ... ON COMMIT { DELETE ROWS |
< DROP } is issued outside a multi-statement transaction
Bruce Momjian [Thu, 12 Oct 2006 21:40:15 +0000 (21:40 +0000)]
Add url's for hints:
> http://archives.postgresql.org/pgsql-hackers/2006-10/msg00517.php
> http://archives.postgresql.org/pgsql-hackers/2006-10/msg00663.php
Bruce Momjian [Thu, 12 Oct 2006 21:29:24 +0000 (21:29 +0000)]
Add:
> o Issue a notice if CREATE TABLE ... ON COMMIT { DELETE ROWS |
> DROP } is issued outside a multi-statement transaction
Neil Conway [Thu, 12 Oct 2006 19:38:08 +0000 (19:38 +0000)]
Make some incremental improvements and fixes to the documentation on
Continuous Archiving. Plenty of editorial work remains...
Tom Lane [Thu, 12 Oct 2006 19:25:12 +0000 (19:25 +0000)]
Update release notes for SQL functions vs triggers fix.
Neil Conway [Thu, 12 Oct 2006 18:49:32 +0000 (18:49 +0000)]
In the installation docs, add some links to the documentation on LDAP
to the discussion of the "--with-ldap" configure option. Patch from
Albe Laurenz.
Tom Lane [Thu, 12 Oct 2006 17:02:24 +0000 (17:02 +0000)]
Fix mishandling of after-trigger state when a SQL function returns multiple
rows --- if the surrounding query queued any trigger events between the rows,
the events would be fired at the wrong time, leading to bizarre behavior.
Per report from Merlin Moncure.
This is a simple patch that should solve the problem fully in the back
branches, but in HEAD we also need to consider the possibility of queries
with RETURNING clauses. Will look into a fix for that separately.
Tom Lane [Thu, 12 Oct 2006 15:04:55 +0000 (15:04 +0000)]
Use Min() instead of min() in qsort, for consistency and to avoid
redefined-macro warnings on some platforms. Per gripe from Hiroshi Saito.
Tom Lane [Thu, 12 Oct 2006 05:14:49 +0000 (05:14 +0000)]
Remove somebody's ill-considered free() call, per report from Chander Ganesan.
No, I do not care whether Coverity considers this a memory leak.
It's entirely not worth the code space to do it correctly.
Bruce Momjian [Wed, 11 Oct 2006 23:01:46 +0000 (23:01 +0000)]
Update pg_hba.conf comment about documentation section.
Tom Lane [Wed, 11 Oct 2006 20:55:52 +0000 (20:55 +0000)]
A bit of copy-editing on back-branch release notes.
Tom Lane [Wed, 11 Oct 2006 20:21:04 +0000 (20:21 +0000)]
Repair incorrect check for coercion of unknown literal to ANYARRAY, a bug
I introduced in 7.4.1 :-(. It's correct to allow unknown to be coerced to
ANY or ANYELEMENT, since it's a real-enough data type, but it most certainly
isn't an array datatype. This can cause a backend crash but AFAICT is not
exploitable as a security hole. Per report from Michael Fuhr.
Note: as fixed in HEAD, this changes a constant in the pg_stats view,
resulting in a change in the expected regression outputs. The back-branch
patches have been hacked to avoid that, so that pre-existing installations
won't start failing their regression tests.
Tom Lane [Wed, 11 Oct 2006 16:42:59 +0000 (16:42 +0000)]
Code review for LIKE INCLUDING CONSTRAINTS patch --- improve comments,
don't cheat on the raw-vs-cooked status of a constraint.
Teodor Sigaev [Wed, 11 Oct 2006 16:42:51 +0000 (16:42 +0000)]
Rename function 'isexists' and 'isdefined' to
'exist' and 'defined' accordingly. Old names
are saved not mentioned in docs - for compatibility
with old applications.
Per discussion
http://archives.postgresql.org/pgsql-hackers/2006-10/msg00571.php
Peter Eisentraut [Tue, 10 Oct 2006 22:19:08 +0000 (22:19 +0000)]
Cleanup pass
Bruce Momjian [Tue, 10 Oct 2006 21:31:44 +0000 (21:31 +0000)]
MSVC/BCC Win32 compiler fixes.
Hiroshi Saito
Bruce Momjian [Tue, 10 Oct 2006 00:30:32 +0000 (00:30 +0000)]
Typo fix.
Bruce Momjian [Tue, 10 Oct 2006 00:30:18 +0000 (00:30 +0000)]
Add release checklist item:
o copy FAQs from HEAD to top-most branches
Bruce Momjian [Tue, 10 Oct 2006 00:28:32 +0000 (00:28 +0000)]
Update FAQ for latest release 8.1.5.
Tom Lane [Mon, 9 Oct 2006 23:36:59 +0000 (23:36 +0000)]
Revise psql pattern-matching switches as per discussion. The rule is now
to process all inclusion switches then all exclusion switches, so that the
behavior is independent of switch ordering.
Use of -T does not cause non-table objects to be suppressed. And
the patterns are now interpreted the same way psql's \d commands do it,
rather than as pure regex commands; this allows for example -t schema.tab
to do what it should have been doing all along. Re-enable the --blobs
switch to do something useful, ie, add back blobs into a dump they were
otherwise suppressed from.
Tom Lane [Mon, 9 Oct 2006 23:31:29 +0000 (23:31 +0000)]
Improve description of the pattern matching rules used by psql's \d
commands (and soon by pg_dump).
Tom Lane [Mon, 9 Oct 2006 23:30:33 +0000 (23:30 +0000)]
Move processNamePattern into dumputils.c in preparation for using it in
pg_dump as well as psql. Since psql already uses dumputils.c, while there's
not any code sharing in the other direction, this seems the easiest way.
Also, fix misinterpretation of patterns using regex | by adding parentheses
(same bug found previously in similar_escape()). This should be backpatched.
Bruce Momjian [Mon, 9 Oct 2006 23:23:47 +0000 (23:23 +0000)]
Update release notes for releases 7.3.16, 7.4.14, 8.0.9, and 8.1.5.
Peter Eisentraut [Sun, 8 Oct 2006 20:51:52 +0000 (20:51 +0000)]
Updated keyword table for 8.2
Tom Lane [Sun, 8 Oct 2006 19:31:03 +0000 (19:31 +0000)]
Update Darwin dlopen() support to avoid deprecation warnings with latest
Apple developer tools. We now use dlopen directly if available, and fall
back to the older code if not. Chris Campbell
Bruce Momjian [Sun, 8 Oct 2006 19:18:32 +0000 (19:18 +0000)]
Update multi-line editing wording in release notes.
Bruce Momjian [Sun, 8 Oct 2006 18:15:52 +0000 (18:15 +0000)]
In release notes, mention that multi-line history saving does not work
on Win32.
Bruce Momjian [Sun, 8 Oct 2006 17:45:50 +0000 (17:45 +0000)]
Add include needed for new getrusage() call.
Tom Lane [Sun, 8 Oct 2006 17:15:34 +0000 (17:15 +0000)]
On Windows, we know the backend stack size limit because we have to
specify it explicitly in backend/Makefile. Arrange for this value to
be known by get_stack_depth_rlimit() too. Per suggestion from Magnus.
Bruce Momjian [Sun, 8 Oct 2006 01:39:59 +0000 (01:39 +0000)]
Update comments for pgcvslog, -r BASE does not work with cvs log.
Bruce Momjian [Sat, 7 Oct 2006 23:48:52 +0000 (23:48 +0000)]
Simplify <link> regex cleanup code.
Bruce Momjian [Sat, 7 Oct 2006 23:28:04 +0000 (23:28 +0000)]
Allow HISTORY/history.html to be generated by removing <link> elements,
per suggestion from Peter. Without this, the main doc links prevent
those files from being built.
Tom Lane [Sat, 7 Oct 2006 22:21:38 +0000 (22:21 +0000)]
Fix ancient oversight in psql's \d pattern processing code: when seeing two
quote chars inside quote marks, should emit one quote *and stay in inquotes
mode*. No doubt the lack of reports of this have something to do with the
poor documentation of the feature ...
Bruce Momjian [Sat, 7 Oct 2006 22:06:25 +0000 (22:06 +0000)]
In release notes, always use </link> rather than </>.
Peter Eisentraut [Sat, 7 Oct 2006 21:51:02 +0000 (21:51 +0000)]
Added missing entry (CASCADED) in keywords table.
Tom Lane [Sat, 7 Oct 2006 21:48:43 +0000 (21:48 +0000)]
Fix thinko in comment.
Peter Eisentraut [Sat, 7 Oct 2006 21:05:59 +0000 (21:05 +0000)]
Updated config.guess and config.sub
Peter Eisentraut [Sat, 7 Oct 2006 20:59:05 +0000 (20:59 +0000)]
The -X option in pg_dump was supposed to be a workaround for the lack of
portable long options. But we have had portable long options for a long
time now, so this is obsolete. Now people have added options which *only*
work with -X but not as regular long option, so I'm putting a stop to this:
-X is deprecated; it still works, but it has been removed from the
documentation, and please don't add more of them.
Tom Lane [Sat, 7 Oct 2006 20:16:57 +0000 (20:16 +0000)]
When planning a query at Bind time, be careful to pass the correct
query_list into the Portal, ie, the one seen and possibly modified by
the planner. My fault :-( Per report from Sergey Koposov.
Tom Lane [Sat, 7 Oct 2006 19:25:29 +0000 (19:25 +0000)]
On platforms that have getrlimit(RLIMIT_STACK), use it to ensure that
max_stack_depth is not set to an unsafe value.
This commit also provides configure-time checking for <sys/resource.h>,
and cleans up some perhaps-unportable code associated with use of that
include file and getrlimit().
Tom Lane [Sat, 7 Oct 2006 16:43:28 +0000 (16:43 +0000)]
Adjust HINT for stack depth limit to mention checking the underlying
platform limit, rather than just blindly raising max_stack_depth.
Also, tweak the code to work properly if someone sets max_stack_depth
to more than 2Gb, which guc.c will allow on a 64-bit machine.
Bruce Momjian [Sat, 7 Oct 2006 03:32:28 +0000 (03:32 +0000)]
Remove tabs added accidentally.
Neil Conway [Sat, 7 Oct 2006 03:17:13 +0000 (03:17 +0000)]
Fix a typo.
Bruce Momjian [Sat, 7 Oct 2006 02:18:34 +0000 (02:18 +0000)]
Add main documentation link tags to the release notes.
Tom Lane [Sat, 7 Oct 2006 00:11:53 +0000 (00:11 +0000)]
Fix string_to_array() to correctly handle the case where there are
overlapping possible matches for the separator string, such as
string_to_array('123xx456xxx789', 'xx').
Also, revise the logic of replace(), split_part(), and string_to_array()
to avoid O(N^2) work from redundant searches and conversions to pg_wchar
format when there are N matches to the separator string.
Backpatched the full patch as far as 8.0. 7.4 also has the bug, but the
code has diverged a lot, so I just went for a quick-and-dirty fix of the
bug itself in that branch.
Tom Lane [Fri, 6 Oct 2006 18:53:53 +0000 (18:53 +0000)]
Fix bcc32.mak to create and remove pg_config_os.h properly. Apparently
win32.mak got patched for this, but not bcc32.mak.
Tom Lane [Fri, 6 Oct 2006 18:23:35 +0000 (18:23 +0000)]
Fix SysCacheGetAttr() to handle the case where the specified syscache has not
been initialized yet. This can happen because there are code paths that call
SysCacheGetAttr() on a tuple originally fetched from a different syscache
(hopefully on the same catalog) than the one specified in the call. It
doesn't seem useful or robust to try to prevent that from happening, so just
improve the function to cope instead. Per bug#2678 from Jeff Trout. The
specific example shown by Jeff is new in 8.1, but to be on the safe side
I'm backpatching 8.0 as well. We could patch 7.x similarly but I think
that's probably overkill, given the lack of evidence of old bugs of this ilk.
Peter Eisentraut [Fri, 6 Oct 2006 17:14:01 +0000 (17:14 +0000)]
Message style improvements
Tom Lane [Thu, 5 Oct 2006 23:33:33 +0000 (23:33 +0000)]
Cleanup for pglz_compress code: remove dead code, const-ify API of
remaining functions, simplify pglz_compress's API to not require a useless
data copy when compression fails. Also add a check in pglz_decompress that
the expected amount of data was decompressed.
Tom Lane [Thu, 5 Oct 2006 17:57:40 +0000 (17:57 +0000)]
Make use of qsort_arg in several places that were formerly using klugy
static variables. This avoids any risk of potential non-reentrancy,
and in particular offers a much cleaner workaround for the Intel compiler
bug that was affecting ginutil.c.
Bruce Momjian [Thu, 5 Oct 2006 03:13:15 +0000 (03:13 +0000)]
Add indenting to Solaris FAQ, for clarity.
Bruce Momjian [Thu, 5 Oct 2006 02:04:32 +0000 (02:04 +0000)]
Update DB2X texinfo example code.
Andreas Seltenreich
Tom Lane [Thu, 5 Oct 2006 01:40:45 +0000 (01:40 +0000)]
Work around buggy strtod on (some versions of?) IRIX. Combination of
proposed patches from John Jorgensen and Steve Singer.
Tom Lane [Thu, 5 Oct 2006 00:07:45 +0000 (00:07 +0000)]
Second try at fixing libedit configuration for Bob Friesenhahn.
Buildfarm results from 'gazelle' show that there are indeed libedit
versions for which history.h is a needed header, even though it's
apparently been dropped entirely in other versions. Grumble.
Bruce Momjian [Wed, 4 Oct 2006 22:49:44 +0000 (22:49 +0000)]
Update Solaris strtod() bug comment.
Bruce Momjian [Wed, 4 Oct 2006 22:48:41 +0000 (22:48 +0000)]
Update Solaris strtol() bug comment.
Tom Lane [Wed, 4 Oct 2006 22:31:14 +0000 (22:31 +0000)]
Adjust configure's handling of libedit to not look for a history.h file.
Per Bob Friesenhahn's report, this file is not supplied by some versions
of libedit, and even when it is supplied it seems to be just a link to
readline.h, so we don't need to include it anyway.
Also, ensure that we won't try to use a too-old version of Bison.
The previous coding would bleat but then use it anyway; better to invoke
the 'missing' script if any grammar files need to be rebuilt.
Bruce Momjian [Wed, 4 Oct 2006 22:03:22 +0000 (22:03 +0000)]
Update Solaris FAQ.
Zdenek Kotala
Bruce Momjian [Wed, 4 Oct 2006 20:42:19 +0000 (20:42 +0000)]
Exclude pgindent from affecting the ecpg regression directory.
Tom Lane [Wed, 4 Oct 2006 18:58:08 +0000 (18:58 +0000)]
Fix initdb's logic for picking shared_buffers/max_fsm_pages, which had
gotten rather thoroughly whacked out by careless recent changes: the
intended ratio between the two was off by a lot, and the minimum number
of shared buffers tried had increased by a lot. Problem exposed by
failures on buildfarm members with smaller SHMMAX values.
Tom Lane [Wed, 4 Oct 2006 18:45:52 +0000 (18:45 +0000)]
Fix comment to agree with presentation.
Tom Lane [Wed, 4 Oct 2006 17:52:52 +0000 (17:52 +0000)]
Improve error messages from to_tsquery per yesterday's discussion:
provide the bad input, and be sure to mention that we are talking about
a tsearch query.
Tom Lane [Wed, 4 Oct 2006 16:51:22 +0000 (16:51 +0000)]
Add qsort and qsort_arg to MSVC list of src/port files.
Michael Meskes [Wed, 4 Oct 2006 10:09:03 +0000 (10:09 +0000)]
Reverted changes made by pgindent
Made show.pgc set all variables before displaying them.
Bruce Momjian [Wed, 4 Oct 2006 00:30:14 +0000 (00:30 +0000)]
pgindent run for 8.2.
Bruce Momjian [Wed, 4 Oct 2006 00:02:10 +0000 (00:02 +0000)]
Udpate typedefs for pgindent.
Tom Lane [Tue, 3 Oct 2006 22:18:23 +0000 (22:18 +0000)]
Switch over to using our own qsort() all the time, as has been proposed
repeatedly. Now that we don't have to worry about memory leaks from
glibc's qsort, we can safely put CHECK_FOR_INTERRUPTS into the tuplesort
comparators, as was requested a couple months ago. Also, get rid of
non-reentrancy and an extra level of function call in tuplesort.c by
providing a variant qsort_arg() API that passes an extra void * argument
through to the comparison routine. (We might want to use that in other
places too, I didn't look yet.)
Bruce Momjian [Tue, 3 Oct 2006 22:12:14 +0000 (22:12 +0000)]
pgevent fixes:
1) Make vcbuild actually build the pgevent dll.
2) Change the pgevent DLL file so it doens't specify ordinal for the
functions. You're not supposed to do that. You're actually supposed to
declare them as PRIVATE as well, but mingw doesn't support that. VC++
will throw a warning and not an error though, so we can live with it.
Magnus Hagander
Bruce Momjian [Tue, 3 Oct 2006 22:09:42 +0000 (22:09 +0000)]
Update typedef list for 8.2 pgindent run.
Bruce Momjian [Tue, 3 Oct 2006 21:45:20 +0000 (21:45 +0000)]
Fix yesno_prompt() memory leak in /script tools, reported by Converity.
Bruce Momjian [Tue, 3 Oct 2006 21:25:56 +0000 (21:25 +0000)]
Improve numeric overflow error message.
David Fetter
Bruce Momjian [Tue, 3 Oct 2006 21:21:36 +0000 (21:21 +0000)]
Make some sentences consistent with similar ones.
Euler Taveira de Oliveira
Bruce Momjian [Tue, 3 Oct 2006 21:14:46 +0000 (21:14 +0000)]
Improve readline psql prompt suggestion.
Andreas Seltenreich
Bruce Momjian [Tue, 3 Oct 2006 21:13:17 +0000 (21:13 +0000)]
Add experimental support for db2x texinfo
Andreas Seltenreich
Bruce Momjian [Tue, 3 Oct 2006 21:11:55 +0000 (21:11 +0000)]
The attached patch changes units of the some default values in
postgresql.conf.
- shared_buffers = 32000kB => 32MB
- temp_buffers = 8000kB => 8MB
- wal_buffers = 8 => 64kB
The code of initdb was a bit modified to write MB-unit values.
Values greater than 8000kB are rounded out to MB.
GUC_UNIT_XBLOCKS is added for wal_buffers. It is like GUC_UNIT_BLOCKS,
but uses XLOG_BLCKSZ instead of BLCKSZ.
Also, I cleaned up the test of GUC_UNIT_* flags in preparation to
add more unit flags in less bits.
ITAGAKI Takahiro
Bruce Momjian [Tue, 3 Oct 2006 20:44:18 +0000 (20:44 +0000)]
Cleanup pgwin32_open() 'if' test, and avoid possible error.
Tom Lane [Tue, 3 Oct 2006 20:33:20 +0000 (20:33 +0000)]
Rearrange MSVC errcode hack, fix incorrect _MSC_VER test. Magnus
Bruce Momjian [Tue, 3 Oct 2006 03:59:22 +0000 (03:59 +0000)]
Move WIN32_ONLY_COMPILER define from c.h to win32.h because it was being
defined too late.
Bruce Momjian [Tue, 3 Oct 2006 01:03:53 +0000 (01:03 +0000)]
This patch fixes a small typo in information_schema.sgml.
Guillaume Lelarge
Bruce Momjian [Tue, 3 Oct 2006 00:39:26 +0000 (00:39 +0000)]
Mention in postgresql.conf that autovacuum also needs
stats_start_collector and stats_row_level to also be on
David Wheeler
Bruce Momjian [Tue, 3 Oct 2006 00:03:54 +0000 (00:03 +0000)]
Add URL for strlcpy():
>
> http://archives.postgresql.org/pgsql-hackers/2006-09/msg02108.php
Bruce Momjian [Tue, 3 Oct 2006 00:00:18 +0000 (00:00 +0000)]
Add:
> * Fix SSL retry to avoid useless repeated connection attempts and
> ensuing misleading error messages
Bruce Momjian [Mon, 2 Oct 2006 23:58:59 +0000 (23:58 +0000)]
Add URL about strlcpy() creation history.
Bruce Momjian [Mon, 2 Oct 2006 23:26:02 +0000 (23:26 +0000)]
Update wording:
< * Use strlcpy() rather than StrNCpy() macro
> * Use strlcpy() rather than our StrNCpy() macro
Bruce Momjian [Mon, 2 Oct 2006 23:23:32 +0000 (23:23 +0000)]
Add:
>
> * Use strlcpy() rather than StrNCpy() macro
Bruce Momjian [Mon, 2 Oct 2006 23:01:17 +0000 (23:01 +0000)]
Remove mention of the -fast option from the Solaris FAQ.
Kenneth Marshall
Bruce Momjian [Mon, 2 Oct 2006 22:33:02 +0000 (22:33 +0000)]
Update recovery documentation.
Simon Riggs
Bruce Momjian [Mon, 2 Oct 2006 22:32:10 +0000 (22:32 +0000)]
Update tsearch2 README.
Robert Treat