OSDN Git Service
Tom Lane [Sat, 12 Feb 2011 21:40:41 +0000 (16:40 -0500)]
Refactor ALTER EXTENSION UPDATE to have cleaner multi-step semantics.
This change causes a multi-step update sequence to behave exactly as if the
updates had been commanded one at a time, including updating the "requires"
dependencies afresh at each step. The initial implementation took the
shortcut of examining only the final target version's "requires" and
changing the catalog entry but once. But on reflection that's a bad idea,
since it could lead to executing old update scripts under conditions
different than they were designed/tested for. Better to expend a few extra
cycles and avoid any surprises.
In the same spirit, if a CREATE EXTENSION FROM operation involves applying
a series of update files, it will act as though the CREATE had first been
done using the initial script's target version and then the additional
scripts were invoked with ALTER EXTENSION UPDATE.
I also removed the restriction about not changing encoding in secondary
control files. The new rule is that a script is assumed to be in whatever
encoding the control file(s) specify for its target version. Since this
reimplementation causes us to read each intermediate version's control
file, there's no longer any uncertainty about which encoding setting would
get applied.
Bruce Momjian [Sat, 12 Feb 2011 14:47:51 +0000 (09:47 -0500)]
Properly handle Win32 paths of 'E:abc', which can be either absolute or
relative, by creating a function path_is_relative_and_below_cwd() to
check for specific requirements. It is unclear if this fixes a security
problem or not but the new code is more robust.
Peter Eisentraut [Sat, 12 Feb 2011 13:54:13 +0000 (15:54 +0200)]
DDL support for collations
- collowner field
- CREATE COLLATION
- ALTER COLLATION
- DROP COLLATION
- COMMENT ON COLLATION
- integration with extensions
- pg_dump support for the above
- dependency management
- psql tab completion
- psql \dO command
Robert Haas [Sat, 12 Feb 2011 13:27:55 +0000 (08:27 -0500)]
Teach ALTER TABLE .. SET DATA TYPE to avoid some table rewrites.
When the old type is binary coercible to the new type and the using
clause does not change the column contents, we can avoid a full table
rewrite, though any indexes on the affected columns will still need
to be rebuilt. This applies, for example, when changing a varchar
column to be of type text.
The prior coding assumed that the set of operations that force a
rewrite is identical to the set of operations that must be propagated
to tables making use of the affected table's rowtype. This is
no longer true: even though the tuples in those tables wouldn't
need to be modified, the data type change invalidate indexes built
using those composite type columns. Indexes on the table we're
actually modifying can be invalidated too, of course, but the
existing machinery is sufficient to handle that case.
Along the way, add some debugging messages that make it possible
to understand what operations ALTER TABLE is actually performing
in these cases.
Noah Misch and Robert Haas
Tom Lane [Sat, 12 Feb 2011 03:53:43 +0000 (22:53 -0500)]
Clean up installation directory choices for extensions.
Arrange for the control files to be in $SHAREDIR/extension not
$SHAREDIR/contrib, since we're generally trying to deprecate the term
"contrib" and this is a once-in-many-moons opportunity to get rid of it in
install paths. Fix PGXS to install the $EXTENSION file into that directory
no matter what MODULEDIR is set to; a nondefault MODULEDIR should only
affect the script and secondary extension files. Fix the control file
directory parameter to be interpreted relative to $SHAREDIR, to avoid a
surprising disconnect between how you specify that and what you set
MODULEDIR to.
Per discussion with David Wheeler.
Tom Lane [Sat, 12 Feb 2011 02:25:20 +0000 (21:25 -0500)]
Add support for multiple versions of an extension and ALTER EXTENSION UPDATE.
This follows recent discussions, so it's quite a bit different from
Dimitri's original. There will probably be more changes once we get a bit
of experience with it, but let's get it in and start playing with it.
This is still just core code. I'll start converting contrib modules
shortly.
Dimitri Fontaine and Tom Lane
Alvaro Herrera [Fri, 11 Feb 2011 22:42:15 +0000 (19:42 -0300)]
Fix comment recently obsoleted
Robert Haas [Fri, 11 Feb 2011 21:57:58 +0000 (16:57 -0500)]
Allow tab-completion of :variable even as first word on a line.
Christoph Berg
Robert Haas [Fri, 11 Feb 2011 16:55:12 +0000 (11:55 -0500)]
Typo fixes. receivedUpto should be capitalized consistently.
Robert Haas [Fri, 11 Feb 2011 13:47:38 +0000 (08:47 -0500)]
Tweak find_composite_type_dependencies API a bit more.
Per discussion with Noah Misch, the previous coding, introduced by
my commit
65377e0b9c0e0397b1598b38b6a7fb8b6f740d39 on 2011-02-06,
was really an abuse of RELKIND_COMPOSITE_TYPE, since the caller in
typecmds.c is actually passing the name of a domain. So go back
having a type name argument, but make the first argument a Relation
rather than just a string so we can tell whether it's a table or
a foreign table and emit the proper error message.
Alvaro Herrera [Thu, 10 Feb 2011 22:47:57 +0000 (19:47 -0300)]
Fix isolation tester Makefile so that it runs in a VPATH build
Tom Lane [Thu, 10 Feb 2011 22:36:44 +0000 (17:36 -0500)]
Extend "ALTER EXTENSION ADD object" to permit "DROP object" as well.
Per discussion, this is something we should have sooner rather than later,
and it doesn't take much additional code to support it.
Alvaro Herrera [Thu, 10 Feb 2011 22:30:57 +0000 (19:30 -0300)]
Fix the isolation tester compilation on VPATH builds
Bruce Momjian [Thu, 10 Feb 2011 21:57:25 +0000 (16:57 -0500)]
Fix "variable not used" warnings when USE_WIDE_UPPER_LOWER is not
defined.
Peter Eisentraut [Thu, 10 Feb 2011 20:49:46 +0000 (22:49 +0200)]
Update comment
It was still claiming that the keyword list is in keywords.c, when it
is now in kwlist.h.
Bruce Momjian [Thu, 10 Feb 2011 20:39:41 +0000 (15:39 -0500)]
Fix pg_get_encoding_from_locale() function call parameters to match
prototype for cases where there is no multi-language support.
Heikki Linnakangas [Thu, 10 Feb 2011 19:00:29 +0000 (21:00 +0200)]
Send status updates back from standby server to master, indicating how far
the standby has written, flushed, and applied the WAL. At the moment, this
is for informational purposes only, the values are only shown in
pg_stat_replication system view, but in the future they will also be needed
for synchronous replication.
Extracted from Simon riggs' synchronous replication patch by Robert Haas, with
some tweaking by me.
Magnus Hagander [Thu, 10 Feb 2011 14:09:35 +0000 (15:09 +0100)]
Track last time for statistics reset on databases and bgwriter
Tracks one counter for each database, which is reset whenever
the statistics for any individual object inside the database is
reset, and one counter for the background writer.
Tomas Vondra, reviewed by Greg Smith
Magnus Hagander [Thu, 10 Feb 2011 11:10:13 +0000 (12:10 +0100)]
Use NOWAIT when including WAL in base backup
Avoids warning and waiting for the last segment to be
archived, which isn't necessary when we're including the
required WAL in the backup itself.
Heikki Linnakangas [Thu, 10 Feb 2011 10:00:53 +0000 (12:00 +0200)]
Allocate all entries in the serializable xid hash up-front, so that you don't
run out of shared memory when you try to assign an xid to a transaction.
Kevin Grittner
Andrew Dunstan [Thu, 10 Feb 2011 09:47:32 +0000 (04:47 -0500)]
Use correct name and URL for MinGW-w64, error noticed by Gurjeet Singh.
Tom Lane [Thu, 10 Feb 2011 04:27:07 +0000 (23:27 -0500)]
Fix improper matching of resjunk column names for FOR UPDATE in subselect.
Flattening of subquery range tables during setrefs.c could lead to the
rangetable indexes in PlanRowMark nodes not matching up with the column
names previously assigned to the corresponding resjunk ctid (resp. tableoid
or wholerow) columns. Typical symptom would be either a "cannot extract
system attribute from virtual tuple" error or an Assert failure. This
wasn't a problem before 9.0 because we didn't support FOR UPDATE below the
top query level, and so the final flattening could never renumber an RTE
that was relevant to FOR UPDATE. Fix by using a plan-tree-wide unique
number for each PlanRowMark to label the associated resjunk columns, so
that the number need not change during flattening.
Per report from David Johnston (though I'm darned if I can see how this got
past initial testing of the relevant code). Back-patch to 9.0.
Itagaki Takahiro [Thu, 10 Feb 2011 01:58:18 +0000 (10:58 +0900)]
Fix typo in the documentation.
by Kevin Grittner
Tom Lane [Thu, 10 Feb 2011 00:17:33 +0000 (19:17 -0500)]
Fix pg_upgrade to handle extensions.
This follows my proposal of yesterday, namely that we try to recreate the
previous state of the extension exactly, instead of allowing CREATE
EXTENSION to run a SQL script that might create some entirely-incompatible
on-disk state. In --binary-upgrade mode, pg_dump won't issue CREATE
EXTENSION at all, but instead uses a kluge function provided by
pg_upgrade_support to recreate the pg_extension row (and extension-level
pg_depend entries) without creating any member objects. The member objects
are then restored in the same way as if they weren't members, in particular
using pg_upgrade's normal hacks to preserve OIDs that need to be preserved.
Then, for each member object, ALTER EXTENSION ADD is issued to recreate the
pg_depend entry that marks it as an extension member.
In passing, fix breakage in pg_upgrade's enum-type support: somebody didn't
fix it when the noise word VALUE got added to ALTER TYPE ADD. Also,
rationalize parsetree representation of COMMENT ON DOMAIN and fix
get_object_address() to allow OBJECT_DOMAIN.
Peter Eisentraut [Wed, 9 Feb 2011 21:26:48 +0000 (23:26 +0200)]
Information schema views for collation support
Add the views character_sets, collations, and
collation_character_set_applicability.
Tom Lane [Wed, 9 Feb 2011 19:05:34 +0000 (14:05 -0500)]
Rethink order of operations for dumping extension member objects.
My original idea of doing extension member identification during
getDependencies() didn't work correctly: we have to mark member tables as
not-to-be-dumped rather earlier than that, else their subsidiary objects
like indexes get dumped anyway. Rearrange code to mark them early enough.
Tom Lane [Wed, 9 Feb 2011 16:55:32 +0000 (11:55 -0500)]
Implement "ALTER EXTENSION ADD object".
This is an essential component of making the extension feature usable;
first because it's needed in the process of converting an existing
installation containing "loose" objects of an old contrib module into
the extension-based world, and second because we'll have to use it
in pg_dump --binary-upgrade, as per recent discussion.
Loosely based on part of Dimitri Fontaine's ALTER EXTENSION UPGRADE
patch.
Bruce Momjian [Wed, 9 Feb 2011 13:16:49 +0000 (08:16 -0500)]
Remove more SGML tabs.
Bruce Momjian [Wed, 9 Feb 2011 13:15:38 +0000 (08:15 -0500)]
Remove tabs in SGML file.
Heikki Linnakangas [Wed, 9 Feb 2011 10:15:08 +0000 (12:15 +0200)]
Fix allocation of RW-conflict pool in the new predicate lock manager, and
also take the RW-conflict pool into account in the PredicateLockShmemSize()
estimate.
Magnus Hagander [Wed, 9 Feb 2011 09:59:53 +0000 (10:59 +0100)]
Implement NOWAIT option for BASE_BACKUP command
Specifying this option makes the server not wait for the
xlog to be archived, or emit a warning that it can't,
instead leaving the responsibility with the client.
This is useful when the log is being streamed using
the streaming protocol in parallel with the backup,
without having log archiving enabled.
Tom Lane [Tue, 8 Feb 2011 23:12:17 +0000 (18:12 -0500)]
Suppress some compiler warnings in recent commits.
Older versions of gcc tend to throw "variable might be clobbered by
`longjmp' or `vfork'" warnings whenever a variable is assigned in more than
one place and then used after the end of a PG_TRY block. That's reasonably
easy to work around in execute_extension_script, and the overhead of
unconditionally saving/restoring the GUC variables seems unlikely to be a
serious concern.
Also clean up logic in ATExecValidateConstraint to make it easier to read
and less likely to provoke "variable might be used uninitialized in this
function" warnings.
Tom Lane [Tue, 8 Feb 2011 21:22:20 +0000 (16:22 -0500)]
Fix merge conflict.
Tom Lane [Tue, 8 Feb 2011 21:08:41 +0000 (16:08 -0500)]
Core support for "extensions", which are packages of SQL objects.
This patch adds the server infrastructure to support extensions.
There is still one significant loose end, namely how to make it play nice
with pg_upgrade, so I am not yet committing the changes that would make
all the contrib modules depend on this feature.
In passing, fix a disturbingly large amount of breakage in
AlterObjectNamespace() and callers.
Dimitri Fontaine, reviewed by Anssi Kääriäinen,
Itagaki Takahiro, Tom Lane, and numerous others
Peter Eisentraut [Tue, 8 Feb 2011 21:04:18 +0000 (23:04 +0200)]
Per-column collation support
This adds collation support for columns and domains, a COLLATE clause
to override it per expression, and B-tree index support.
Peter Eisentraut
reviewed by Pavel Stehule, Itagaki Takahiro, Robert Haas, Noah Misch
Heikki Linnakangas [Tue, 8 Feb 2011 19:47:38 +0000 (21:47 +0200)]
Fix typo, by Kevin Grittner.
Simon Riggs [Tue, 8 Feb 2011 19:44:50 +0000 (19:44 +0000)]
Continue long tradition of bumping the catalog version a little late.
Simon Riggs [Tue, 8 Feb 2011 19:39:08 +0000 (19:39 +0000)]
Named restore points in recovery. Users can record named points, then
new recovery.conf parameter recovery_target_name allows PITR to
specify named points as recovery targets.
Jaime Casanova, reviewed by Euler Taveira de Oliveira, plus minor edits
Simon Riggs [Tue, 8 Feb 2011 18:30:22 +0000 (18:30 +0000)]
Basic Recovery Control functions for use in Hot Standby. Pause, Resume,
Status check functions only. Also, new recovery.conf parameter to
pause_at_recovery_target, default on.
Simon Riggs, reviewed by Fujii Masao
Heikki Linnakangas [Tue, 8 Feb 2011 16:14:26 +0000 (18:14 +0200)]
UINT64_MAX isn't defined on MSVC.
Simon Riggs [Tue, 8 Feb 2011 14:38:02 +0000 (14:38 +0000)]
Remove rare corner case for data loss when triggering standby server.
If the standby was streaming when trigger file arrives, check also in the
archive for additional WAL files. This is a corner case since it is
unlikely that we would trigger a failover while the master is still
available and sending data to standby, while at the same time running in
archive mode and also while the streaming standby has fallen behind archive.
Someone would eventually be unlucky; we must plug all gaps however small.
Fujii Masao
Simon Riggs [Tue, 8 Feb 2011 12:23:20 +0000 (12:23 +0000)]
Extend ALTER TABLE to allow Foreign Keys to be added without initial validation.
FK constraints that are marked NOT VALID may later be VALIDATED, which uses an
ShareUpdateExclusiveLock on constraint table and RowShareLock on referenced
table. Significantly reduces lock strength and duration when adding FKs.
New state visible from psql.
Simon Riggs, with reviews from Marko Tiikkaja and Robert Haas
Heikki Linnakangas [Tue, 8 Feb 2011 07:03:08 +0000 (09:03 +0200)]
Fix copy-pasto in description of pg_serial, and silence compiler warning
about uninitialized field you get on some compilers.
Robert Haas [Tue, 8 Feb 2011 03:04:29 +0000 (22:04 -0500)]
Avoid having autovacuum workers wait for relation locks.
Waiting for relation locks can lead to starvation - it pins down an
autovacuum worker for as long as the lock is held. But if we're doing
an anti-wraparound vacuum, then we still wait; maintenance can no longer
be put off.
To assist with troubleshooting, if log_autovacuum_min_duration >= 0,
we log whenever an autovacuum or autoanalyze is skipped for this reason.
Per a gripe by Josh Berkus, and ensuing discussion.
Heikki Linnakangas [Mon, 7 Feb 2011 22:24:23 +0000 (00:24 +0200)]
Oops, forgot to bump catversion in the Serializable Snapshot Isolation patch.
I thought we didn't need that, but then I remembered that it added a new
SLRU subdirectory, pg_serial. While we're at it, document what pg_serial is.
Heikki Linnakangas [Mon, 7 Feb 2011 21:46:51 +0000 (23:46 +0200)]
Implement genuine serializable isolation level.
Until now, our Serializable mode has in fact been what's called Snapshot
Isolation, which allows some anomalies that could not occur in any
serialized ordering of the transactions. This patch fixes that using a
method called Serializable Snapshot Isolation, based on research papers by
Michael J. Cahill (see README-SSI for full references). In Serializable
Snapshot Isolation, transactions run like they do in Snapshot Isolation,
but a predicate lock manager observes the reads and writes performed and
aborts transactions if it detects that an anomaly might occur. This method
produces some false positives, ie. it sometimes aborts transactions even
though there is no anomaly.
To track reads we implement predicate locking, see storage/lmgr/predicate.c.
Whenever a tuple is read, a predicate lock is acquired on the tuple. Shared
memory is finite, so when a transaction takes many tuple-level locks on a
page, the locks are promoted to a single page-level lock, and further to a
single relation level lock if necessary. To lock key values with no matching
tuple, a sequential scan always takes a relation-level lock, and an index
scan acquires a page-level lock that covers the search key, whether or not
there are any matching keys at the moment.
A predicate lock doesn't conflict with any regular locks or with another
predicate locks in the normal sense. They're only used by the predicate lock
manager to detect the danger of anomalies. Only serializable transactions
participate in predicate locking, so there should be no extra overhead for
for other transactions.
Predicate locks can't be released at commit, but must be remembered until
all the transactions that overlapped with it have completed. That means that
we need to remember an unbounded amount of predicate locks, so we apply a
lossy but conservative method of tracking locks for committed transactions.
If we run short of shared memory, we overflow to a new "pg_serial" SLRU
pool.
We don't currently allow Serializable transactions in Hot Standby mode.
That would be hard, because even read-only transactions can cause anomalies
that wouldn't otherwise occur.
Serializable isolation mode now means the new fully serializable level.
Repeatable Read gives you the old Snapshot Isolation level that we have
always had.
Kevin Grittner and Dan Ports, reviewed by Jeff Davis, Heikki Linnakangas and
Anssi Kääriäinen
Itagaki Takahiro [Mon, 7 Feb 2011 07:51:39 +0000 (16:51 +0900)]
Fix a comment for MergeAttributes.
We forgot to adjust it when we changed relistemp to relpersistence.
Andrew Dunstan [Mon, 7 Feb 2011 02:36:56 +0000 (21:36 -0500)]
Supply now required HeUTF8 macro for plperl where it's missing, per buildfarm results.
Itagaki Takahiro [Mon, 7 Feb 2011 01:46:56 +0000 (10:46 +0900)]
Fix error messages for FreeFile in COPY command.
They are extracted from COPY API patch.
suggested by Noah Misch
Bruce Momjian [Sun, 6 Feb 2011 23:32:27 +0000 (18:32 -0500)]
remove tags.
Andrew Dunstan [Sun, 6 Feb 2011 22:29:26 +0000 (17:29 -0500)]
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way back. This avoids a number of
observed anomalies, and ensures Perl a consistent view of the
world.
Some minor code cleanups are also accomplished.
Alex Hunsaker, reviewed by Andy Colson.
Bruce Momjian [Sun, 6 Feb 2011 17:04:42 +0000 (12:04 -0500)]
Adjust libpq docs to be clearer about 'hostaddr' usage by rewording and
using an itemized list.
Bruce Momjian [Sun, 6 Feb 2011 15:46:15 +0000 (10:46 -0500)]
Rename macro DECIMAL to DECIMAL_T to help pgindent; this is already
done for a few other macros in that file, for other reasons. I also
remove pgindent/README mention of the file.
Magnus Hagander [Sun, 6 Feb 2011 06:46:14 +0000 (07:46 +0100)]
IDENTIFY_SYSTEM now returns 3 fields, not 2
Robert Haas [Sun, 6 Feb 2011 05:26:27 +0000 (00:26 -0500)]
Tighten ALTER FOREIGN TABLE .. SET DATA TYPE checks.
If the foreign table's rowtype is being used as the type of a column in
another table, we can't just up and change its data type. This was
already checked for composite types and ordinary tables, but we
previously failed to enforce it for foreign tables.
Bruce Momjian [Sat, 5 Feb 2011 04:27:45 +0000 (23:27 -0500)]
Add C comment about why older compilers complain about basebackup.c's
longjump.
Andrew Dunstan [Sat, 5 Feb 2011 01:49:39 +0000 (20:49 -0500)]
Attempt to unbreak MSVC builds after pipe.c move.
Bruce Momjian [Fri, 4 Feb 2011 22:30:22 +0000 (17:30 -0500)]
Add doc comment that installation.sgml can't use xrefs.
Robert Haas [Fri, 4 Feb 2011 21:14:54 +0000 (16:14 -0500)]
Clarify comment in ATRewriteTable().
Make sure it's clear that the prohibition on adding a column with a default
when the rowtype is used elsewhere is intentional, and be a bit more
explicit about the other cases where we perform this check.
Robert Haas [Fri, 4 Feb 2011 20:52:21 +0000 (15:52 -0500)]
Move pipe.c into the backend.
It's full of backend-specific error reporting, so it's neither possible
nor necessary for this to be used from frontend code.
Bruce Momjian [Fri, 4 Feb 2011 19:23:01 +0000 (14:23 -0500)]
In docs, move PQrequestCancel() deprecation mention up to match other
libpq doc mentions.
Robert Haas [Fri, 4 Feb 2011 18:11:53 +0000 (13:11 -0500)]
Avoid including postgres.h in frontend compiles of src/port.
This isn't kosher, and doesn't play nicely with my recent changes to the
Makefile in this directory.
Robert Haas [Fri, 4 Feb 2011 18:08:56 +0000 (13:08 -0500)]
Update ALTER TABLE docs to mention using VACUUM FULL for rewrites.
Remove the claim that ALTER TABLE .. SET DATA TYPE is the fastest way of
rewriting a table, since it no longer is.
Noah Misch and Robert Haas, based on a suggestion from Tom Lane.
Robert Haas [Fri, 4 Feb 2011 14:48:32 +0000 (09:48 -0500)]
Use $(MAKE) rather than make.
Per buildfarm.
Robert Haas [Fri, 4 Feb 2011 14:28:06 +0000 (09:28 -0500)]
Make handling of errcodes.h more consistent with other generated headers.
This fixes make distprep, and seems more robust in other ways as well.
Some special handling is required because errcodes.txt is needed by
some stuff in src/port, but just by src/backend as is the case for the
other generated headers.
While I'm at it, fix a few other things that were overlooked in the
original patch.
Magnus Hagander [Fri, 4 Feb 2011 14:23:34 +0000 (15:23 +0100)]
Attempt to un-break the documentation build again
Another case of <xref linkend> in the documentation that
builds INSTALL, which is not allowed.
Robert Haas [Fri, 4 Feb 2011 12:03:19 +0000 (07:03 -0500)]
Unbreak 'configure' followed immediately by 'make install'.
More fallout from
ddfe26f6441c24660595c5efe5fd0bd3974cdc5c.
Report by Fujii Masao.
Magnus Hagander [Fri, 4 Feb 2011 09:52:25 +0000 (10:52 +0100)]
Use single quotes when there are backslashes in the filename
In the hope of unbreaking the buildfarm
Robert Haas [Fri, 4 Feb 2011 05:07:08 +0000 (00:07 -0500)]
Unbreak the VPATH build.
My commit
ddfe26f6441c24660595c5efe5fd0bd3974cdc5c of 2010-02-03 broke it.
Per buildfarm.
Robert Haas [Fri, 4 Feb 2011 03:38:02 +0000 (22:38 -0500)]
Preserve copyright notice from old errcodes.h file.
Robert Haas [Fri, 4 Feb 2011 03:32:49 +0000 (22:32 -0500)]
Avoid maintaining three separate copies of the error codes list.
src/pl/plpgsql/src/plerrcodes.h, src/include/utils/errcodes.h, and a
big chunk of errcodes.sgml are now automatically generated from a single
file, src/backend/utils/errcodes.txt.
Jan Urbański, reviewed by Tom Lane.
Robert Haas [Thu, 3 Feb 2011 20:14:27 +0000 (15:14 -0500)]
ALTER TABLE sometimes takes only ShareUpdateExclusiveLock.
Along the way, be more consistent about the wording we use here.
Bruce Momjian [Thu, 3 Feb 2011 16:54:07 +0000 (11:54 -0500)]
In docs, PL is Procedural Language, not Programming Language.
Satoshi Nagayasu
Bruce Momjian [Thu, 3 Feb 2011 15:46:31 +0000 (10:46 -0500)]
Simplify code used in is_absolute_path() macro; also add comment about
'E:abc' Win32 path handling.
Magnus Hagander [Thu, 3 Feb 2011 12:46:23 +0000 (13:46 +0100)]
Include more status information in walsender results
Add the current xlog insert location to the response of
IDENTIFY_SYSTEM, and adds result sets containing start
and stop location of backups to BASE_BACKUP responses.
Magnus Hagander [Thu, 3 Feb 2011 10:24:47 +0000 (11:24 +0100)]
Fix typo.
Thom Brown
Robert Haas [Thu, 3 Feb 2011 05:23:44 +0000 (00:23 -0500)]
Further sepgsql documentation cleanup.
Robert Haas [Thu, 3 Feb 2011 04:47:45 +0000 (23:47 -0500)]
sepgsql doc fix
KaiGai Kohei
Robert Haas [Thu, 3 Feb 2011 04:46:51 +0000 (23:46 -0500)]
Minor sepgsql regression test fixes.
Robert Haas [Thu, 3 Feb 2011 04:39:43 +0000 (23:39 -0500)]
Various sepgsql corrections.
KaiGai Kohei
Bruce Momjian [Thu, 3 Feb 2011 03:49:54 +0000 (22:49 -0500)]
Rename function to first_path_var_separator() to clarify it works with
path variables, not directory paths.
Bruce Momjian [Thu, 3 Feb 2011 03:28:14 +0000 (22:28 -0500)]
Clearify macro IS_PATH_VAR_SEP in path.c so it is clear this is a path
variable, not a directory path.
Robert Haas [Thu, 3 Feb 2011 02:08:53 +0000 (21:08 -0500)]
Log restartpoints in the same fashion as checkpoints.
Prior to 9.0, restartpoints never created, deleted, or recycled WAL
files, but now they can. This code makes log_checkpoints treat
checkpoints and restartpoints symmetrically. It also adjusts up
the documentation of the parameter to mention restartpoints.
Fujii Masao. Docs by me, as suggested by Itagaki Takahiro.
Tom Lane [Thu, 3 Feb 2011 01:26:43 +0000 (20:26 -0500)]
Repair multiple breakage in Windows-specific code for appending '.exe'.
Tom Lane [Thu, 3 Feb 2011 01:16:27 +0000 (20:16 -0500)]
Clean up missed change to plpython expected files.
Bruce Momjian [Wed, 2 Feb 2011 23:06:38 +0000 (18:06 -0500)]
Mark all GUC variables with <varname> markup, rather than <literal>.
Bruce Momjian [Wed, 2 Feb 2011 21:53:12 +0000 (16:53 -0500)]
Fix wrong verb in pg_upgrade text message, per Haas.
Bruce Momjian [Wed, 2 Feb 2011 20:40:20 +0000 (15:40 -0500)]
Simplify pg_upgrade checking of executable permissions.
Peter Eisentraut [Wed, 2 Feb 2011 20:06:10 +0000 (22:06 +0200)]
Wrap PL/Python SPI calls into subtransactions
This allows the language-specific try/catch construct to catch and
handle exceptions arising from SPI calls, matching the behavior of
other PLs.
As an additional bonus you no longer get all the ugly "unrecognized
error in PLy_spi_execute_query" errors.
Jan Urbański, reviewed by Steve Singer
Andrew Dunstan [Wed, 2 Feb 2011 17:45:42 +0000 (12:45 -0500)]
Add comment on why we're passing a useless 'false' to the plperl function compiler.
It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf.
Bruce Momjian [Tue, 1 Feb 2011 22:17:34 +0000 (17:17 -0500)]
Document that CREATE VIEW that uses "*" for the column list will not
auto-add columns later added to the base table.
Bruce Momjian [Tue, 1 Feb 2011 22:00:26 +0000 (17:00 -0500)]
Properly capitalize hyphenated words in documentation titles.
Bruce Momjian [Tue, 1 Feb 2011 21:43:51 +0000 (16:43 -0500)]
Clarify documentation to state that "zero_damaged_pages" does not force
data to disk, so the table or index should be recreated before the
parameter is turned off again.
Peter Eisentraut [Tue, 1 Feb 2011 20:53:40 +0000 (22:53 +0200)]
Add validator to PL/Python
Jan Urbański, reviewed by Hitoshi Harada
Bruce Momjian [Tue, 1 Feb 2011 20:23:35 +0000 (15:23 -0500)]
Document that effective cache size does not assume data remains in the
cache between queries.
Bruce Momjian [Tue, 1 Feb 2011 20:21:22 +0000 (15:21 -0500)]
Document that Slony can do upgrades easier _because_ it supports
replication between different Postgres major versions.
Bruce Momjian [Tue, 1 Feb 2011 18:57:43 +0000 (13:57 -0500)]
Clarify pg_upgrade install instructions, per suggestion from Robert Haas.
Bruce Momjian [Tue, 1 Feb 2011 18:53:04 +0000 (13:53 -0500)]
Add missing period "." in pg_upgrade documentation.
Bruce Momjian [Tue, 1 Feb 2011 17:22:34 +0000 (12:22 -0500)]
Add pg_upgrade comment for why we can't use template1 inheritance for
the support functions.
Andrew Dunstan [Tue, 1 Feb 2011 14:43:25 +0000 (09:43 -0500)]
Set up PLPerl trigger data using C code instead of Perl code.
This is an efficiency change, and means we now no longer have to run
"out $_TD; local $_TD = shift;", which was especially pointless in the case of
non-trigger functions where the passed value was always undef anyway.
A tiny open issue is whether we should get rid of the $prolog argument of
mkfunc, and the corresponding pushed value, which is now just a constant "false".
Tim Bunce, reviewed by Alex Hunsaker.