OSDN Git Service
Tom Lane [Mon, 9 Aug 2010 18:50:20 +0000 (18:50 +0000)]
Fix incorrect logic in plpgsql for cleanup after evaluation of non-simple
expressions. We need to deal with this when handling subscripts in an array
assignment, and also when catching an exception. In an Assert-enabled build
these omissions led to Assert failures, but I think in a normal build the
only consequence would be short-term memory leakage; which may explain why
this wasn't reported from the field long ago.
Back-patch to all supported versions. 7.4 doesn't have exceptions, but
otherwise these bugs go all the way back.
Heikki Linnakangas and Tom Lane
Robert Haas [Mon, 9 Aug 2010 12:00:39 +0000 (12:00 +0000)]
Provide stable target anchors for libpq functions.
Daniele Varrazzo
Peter Eisentraut [Fri, 6 Aug 2010 20:09:01 +0000 (20:09 +0000)]
Fix indexterm spelling
Tom Lane [Fri, 6 Aug 2010 19:13:18 +0000 (19:13 +0000)]
Let's put that </link> in a sane place ...
Tom Lane [Fri, 6 Aug 2010 18:55:30 +0000 (18:55 +0000)]
Fix inaccurate description of deferrable unique constraints, per Dean Rasheed.
Robert Haas [Fri, 6 Aug 2010 17:57:03 +0000 (17:57 +0000)]
Rearrange "big features" section of the release notes.
Josh Berkus
Tom Lane [Thu, 5 Aug 2010 21:45:45 +0000 (21:45 +0000)]
Add a very specific hint for the case that we're unable to locate a function
matching a call like f(x, ORDER BY y,z). It could be that what the user
really wants is f(x,z ORDER BY y). We now have pretty conclusive evidence
that many people won't understand this problem without concrete guidance,
so give it to them. Per further discussion of the string_agg() problem.
Peter Eisentraut [Thu, 5 Aug 2010 18:36:31 +0000 (18:36 +0000)]
Document which Python environment variables affect PL/Python
Tom Lane [Thu, 5 Aug 2010 18:21:31 +0000 (18:21 +0000)]
Remove the single-argument form of string_agg(). It added nothing much in
functionality, while creating an ambiguity in usage with ORDER BY that at
least two people have already gotten seriously confused by. Also, add an
opr_sanity test to check that we don't in future violate the newly minted
policy of not having built-in aggregates with the same name and different
numbers of parameters. Per discussion of a complaint from Thom Brown.
Tom Lane [Wed, 4 Aug 2010 22:31:55 +0000 (22:31 +0000)]
Forgot to back-patch earlier change to documentation for aggregate
ORDER BY clauses.
Tom Lane [Wed, 4 Aug 2010 16:27:13 +0000 (16:27 +0000)]
Fix sloppy mistakes in documentation of PQescapeLiteral and PQescapeIdentifier.
Noted by Dmitriy Igrishin.
Robert Haas [Tue, 3 Aug 2010 15:47:09 +0000 (15:47 +0000)]
Fix inheritance count tracking in ALTER TABLE .. ADD CONSTRAINT.
Without this patch, constraints inherited by children of a parent
table which itself has multiple inheritance parents can end up with
the wrong coninhcount. After dropping the constraint, the children
end up with a leftover copy of the constraint that is not dumped
and cannot be dropped. There is a similar problem with ALTER TABLE
.. ADD COLUMN, but that looks significantly more difficult to
resolve, so I'm committing this fix separately.
Back-patch to 8.4, which is the first release that has coninhcount.
Report by Hank Enting.
Tom Lane [Tue, 3 Aug 2010 00:10:44 +0000 (00:10 +0000)]
Fix core dump in QTNodeCompare when tsquery_cmp() is applied to two empty
tsqueries. CompareTSQ has to have a guard for the case rather than blindly
applying QTNodeCompare to random data past the end of the datums. Also,
change QTNodeCompare to be a little less trusting: use an actual test rather
than just Assert'ing that the input is sane. Problem encountered while
investigating another issue (I saw a core dump in autoanalyze on a table
containing multiple empty tsquery values).
Back-patch to all branches with tsquery support.
In HEAD, also fix some bizarre (though not outright wrong) coding in
tsq_mcontains().
Tom Lane [Mon, 2 Aug 2010 04:51:25 +0000 (04:51 +0000)]
Don't try to force use of -no-cpp-precomp on OS X. It's been five years
since Apple shipped a compiler that needed this switch, and there's
increasing interest in using other compilers that won't accept the switch
at all. Better to let anybody who still needs the switch inject it via
CPPFLAGS. Per gripe from Neil Conway.
Tom Lane [Mon, 2 Aug 2010 01:25:02 +0000 (01:25 +0000)]
Fix an ancient typo that prevented the detection of conflicting fields when
interval input "invalid" was specified together with other fields. Spotted
by Neil Conway with the help of a clang warning. Although this has been
wrong since the interval code was written more than 10 years ago, it doesn't
affect anything beyond which error message you get for a wrong input, so not
worth back-patching very far.
Tom Lane [Sun, 1 Aug 2010 23:07:05 +0000 (23:07 +0000)]
Back-patch fix for renaming asyncCommitLSN to asyncXactLSN.
AIUI this was supposed to go into 9.0 as well as HEAD.
Tom Lane [Sun, 1 Aug 2010 22:38:20 +0000 (22:38 +0000)]
Fix ANALYZE's ancient deficiency of not trying to collect stats for expression
indexes when the index column type (the opclass opckeytype) is different from
the expression's datatype. When coded, this limitation wasn't worth worrying
about because we had no intelligence to speak of in stats collection for the
datatypes used by such opclasses. However, now that there's non-toy
estimation capability for tsvector queries, it amounts to a bug that ANALYZE
fails to do this.
The fix changes struct VacAttrStats, and therefore constitutes an API break
for custom typanalyze functions. Therefore we can't back-patch it into
released branches, but it was agreed that 9.0 isn't yet frozen hard enough
to make such a change unacceptable. Ergo, back-patch to 9.0 but no further.
The API break had better be mentioned in 9.0 release notes.
Tom Lane [Sun, 1 Aug 2010 19:16:47 +0000 (19:16 +0000)]
Fix an additional set of problems in GIN's handling of lossy page pointers.
Although the key-combining code claimed to work correctly if its input
contained both lossy and exact pointers for a single page in a single TID
stream, in fact this did not work, and could not work without pretty
fundamental redesign. Modify keyGetItem so that it will not return such a
stream, by handling lossy-pointer cases a bit more explicitly than we did
before.
Per followup investigation of a gripe from Artur Dabrowski.
An example of a query that failed given his data set is
select count(*) from search_tab where
(to_tsvector('german', keywords ) @@ to_tsquery('german', 'ee:* | dd:*')) and
(to_tsvector('german', keywords ) @@ to_tsquery('german', 'aa:*'));
Back-patch to 8.4 where the lossy pointer code was introduced.
Tom Lane [Sun, 1 Aug 2010 02:12:51 +0000 (02:12 +0000)]
Rewrite the rbtree routines so that an RBNode is the first field of the
struct representing a tree entry, rather than being a separately allocated
piece of storage. This API is at least as clean as the old one (if not
more so --- there were some bizarre choices in there) and it permits a
very substantial memory savings, on the order of 2X in ginbulk.c's usage.
Also, fix minor memory leaks in code called by ginEntryInsert, in
particular in ginInsertValue and entryFillRoot, as well as ginEntryInsert
itself. These leaks resulted in the GIN index build context continuing
to bloat even after we'd filled it to maintenance_work_mem and started
to dump data out to the index.
In combination these fixes restore the GIN index build code to honoring
the maintenance_work_mem limit about as well as it did in 8.4. Speed
seems on par with 8.4 too, maybe even a bit faster, for a non-pathological
case in which HEAD was formerly slower.
Back-patch to 9.0 so we don't have a performance regression from 8.4.
Tom Lane [Sat, 31 Jul 2010 03:27:48 +0000 (03:27 +0000)]
Tweak tsmatchsel() so that it examines the structure of the tsquery whenever
possible (ie, whenever the tsquery is a constant), even when no statistics
are available for the tsvector. For example, foo @@ 'a & b'::tsquery
can be expected to be more selective than foo @@ 'a'::tsquery, whether
or not we know anything about foo. We use DEFAULT_TS_MATCH_SEL as the assumed
selectivity of individual query terms when no stats are available, then
combine the terms according to the query's AND/OR structure as usual.
Per experimentation with Artur Dabrowski's example. (The fact that there
are no stats available in that example is a problem in itself, but
nonetheless tsmatchsel should be smarter about the case.)
Back-patch to 8.4 to keep all versions of tsmatchsel() in sync.
Tom Lane [Sat, 31 Jul 2010 00:31:04 +0000 (00:31 +0000)]
Rewrite the key-combination logic in GIN's keyGetItem() and scanGetItem()
routines to make them behave better in the presence of "lossy" index pointers.
The previous coding was outright incorrect for some cases, as recently
reported by Artur Dabrowski: scanGetItem would fail to return index entries in
cases where one index key had multiple exact pointers on the same page as
another key had a lossy pointer. Also, keyGetItem was extremely inefficient
for cases where a single index key generates multiple "entry" streams, such as
an @@ operator with a multiple-clause tsquery. The presence of a lossy page
pointer in any one stream defeated its ability to use the opclass
consistentFn, resulting in probing many heap pages that didn't really need to
be visited. In Artur's example case, a query like
WHERE tsvector @@ to_tsquery('a & b')
was about 50X slower than the theoretically equivalent
WHERE tsvector @@ to_tsquery('a') AND tsvector @@ to_tsquery('b')
The way that I chose to fix this was to have GIN call the consistentFn
twice with both TRUE and FALSE values for the in-doubt entry stream,
returning a hit if either call produces TRUE, but not if they both return
FALSE. The code handles this for the case of a single in-doubt entry stream,
but punts (falling back to the stupid behavior) if there's more than one lossy
reference to the same page. The idea could be scaled up to deal with multiple
lossy references, but I think that would probably be wasted complexity. At
least to judge by Artur's example, such cases don't occur often enough to be
worth trying to optimize.
Back-patch to 8.4. 8.3 did not have lossy GIN index pointers, so not
subject to these problems.
Marc G. Fournier [Fri, 30 Jul 2010 03:31:41 +0000 (03:31 +0000)]
tag for beta4
Tom Lane [Thu, 29 Jul 2010 23:16:41 +0000 (23:16 +0000)]
Improved version of patch to protect pg_get_expr() against misuse:
look through join alias Vars to avoid breaking join queries, and
move the test to someplace where it will catch more possible ways
of calling a function. We still ought to throw away the whole thing
in favor of a data-type-based solution, but that's not feasible in
the back branches.
This needs to be back-patched further than 9.0, but I don't have time
to do so today. Committing now so that the fix gets into 9.0beta4.
Tom Lane [Thu, 29 Jul 2010 21:18:16 +0000 (21:18 +0000)]
Update release notes for 9.0 beta 4. Back-patch some changes that were made only in HEAD.
Tom Lane [Thu, 29 Jul 2010 20:09:34 +0000 (20:09 +0000)]
Clean up some inconsistencies in the volatility marking of various I/O
related functions. Per today's discussion, we will henceforth assume
that datatype I/O functions are either stable or immutable, never volatile.
(This implies in particular that domain CHECK constraint expressions shouldn't
be volatile, since domain_in executes them.) In turn, functions that execute
the I/O functions of arbitrary datatypes should always be labeled stable.
This affects the labeling of array_to_string, which was unsafely marked
immutable, and record_in, record_out, record_recv, record_send,
domain_in, domain_recv, which were over-conservatively marked volatile.
The array I/O functions were already marked stable, which is correct
per this policy but would have been wrong if we maintained domain_in
as volatile.
Back-patch to 9.0, along with an earlier fix to correctly mark cash_in
and cash_out as stable not immutable (since they depend on lc_monetary).
No catversion bump --- the implications of this are not currently
severe enough to justify a forced initdb.
Peter Eisentraut [Thu, 29 Jul 2010 19:39:47 +0000 (19:39 +0000)]
Translation updates for 9.0beta4
Peter Eisentraut [Thu, 29 Jul 2010 19:34:37 +0000 (19:34 +0000)]
Fix indentation of verbatim block elements
Block elements with verbatim formatting (literallayout, programlisting,
screen, synopsis) should be aligned at column 0 independent of the surrounding
SGML, because whitespace is significant, and indenting them creates erratic
whitespace in the output. The CSS stylesheets already take care of indenting
the output.
Assorted markup improvements to go along with it.
Tom Lane [Thu, 29 Jul 2010 19:23:28 +0000 (19:23 +0000)]
Fix another longstanding problem in copy_relation_data: it was blithely
assuming that a local char[] array would be aligned on at least a word
boundary. There are architectures on which that is pretty much guaranteed to
NOT be the case ... and those arches also don't like non-aligned memory
accesses, meaning that log_newpage() would crash if it ever got invoked.
Even on Intel-ish machines there's a potential for a large performance penalty
from doing I/O to an inadequately aligned buffer. So palloc it instead.
Backpatch to 8.0 --- 7.4 doesn't have this code.
Tom Lane [Thu, 29 Jul 2010 18:29:57 +0000 (18:29 +0000)]
Work around a documentation toolchain problem by replacing the "AIX-fixlevels"
table with a <variablelist> carrying the same information. Previously the
9.0 documentation was failing to build as a US-size PDF file. It's quite
obscure what the real problem is or why this avoids it, but we need a hack
now so we can build docs for beta4.
In passing do a bit of editing in the AIX installation docs, in particular
remove a long-obsolete claim that the regression tests are likely to fail.
Robert Haas [Thu, 29 Jul 2010 16:14:45 +0000 (16:14 +0000)]
Fix possible page corruption by ALTER TABLE .. SET TABLESPACE.
If a zeroed page is present in the heap, ALTER TABLE .. SET TABLESPACE will
set the LSN and TLI while copying it, which is wrong, and heap_xlog_newpage()
will do the same thing during replay, so the corruption propagates to any
standby. Note, however, that the bug can't be demonstrated unless archiving
is enabled, since in that case we skip WAL logging altogether, and the LSN/TLI
are not set.
Back-patch to 8.0; prior releases do not have tablespaces.
Analysis and patch by Jeff Davis. Adjustments for back-branches and minor
wordsmithing by me.
Peter Eisentraut [Wed, 28 Jul 2010 20:34:12 +0000 (20:34 +0000)]
Remove wildly obsolete type attribute externallength from chkpass
Tom Lane [Wed, 28 Jul 2010 17:22:03 +0000 (17:22 +0000)]
Fix oversight in new EvalPlanQual logic: the second loop over the ExecRowMark
list in ExecLockRows() forgot to allow for the possibility that some of the
rowmarks are for child tables that aren't relevant to the current row.
Per report from Kenichiro Tanaka.
Tom Lane [Wed, 28 Jul 2010 04:50:59 +0000 (04:50 +0000)]
Fix potential failure when hashing the output of a subplan that produces
a pass-by-reference datatype with a nontrivial projection step.
We were using the same memory context for the projection operation as for
the temporary context used by the hashtable routines in execGrouping.c.
However, the hashtable routines feel free to reset their temp context at
any time, which'd lead to destroying input data that was still needed.
Report and diagnosis by Tao Ma.
Back-patch to 8.1, where the problem was introduced by the changes that
allowed us to work with "virtual" tuples instead of materializing intermediate
tuple values everywhere. The earlier code looks quite similar, but it doesn't
suffer the problem because the data gets copied into another context as a
result of having to materialize ExecProject's output tuple.
Peter Eisentraut [Wed, 28 Jul 2010 04:39:15 +0000 (04:39 +0000)]
Show psql timing output even in quiet mode
These two settings ought to be independent of each other.
Robert Haas [Tue, 27 Jul 2010 20:02:17 +0000 (20:02 +0000)]
Fix typo in PL/pgsql code example.
Backpatch to 8.4.
Marc Cousin. Review by Kevin Grittner.
Peter Eisentraut [Tue, 27 Jul 2010 19:01:04 +0000 (19:01 +0000)]
Spelling fixes
Alvaro Herrera [Tue, 27 Jul 2010 04:18:31 +0000 (04:18 +0000)]
Ensure $_SHARED is declared in the main:: namespace, per bugs #5570 and #5571.
Author: Alex Hunsaker
Peter Eisentraut [Mon, 26 Jul 2010 20:28:35 +0000 (20:28 +0000)]
Fix grammar
backpatched to 8.1
Peter Eisentraut [Mon, 26 Jul 2010 20:14:06 +0000 (20:14 +0000)]
Add table creation and population to example
from John Gage
Peter Eisentraut [Sun, 25 Jul 2010 08:30:41 +0000 (08:30 +0000)]
Add INSERT statement to example so that it can be reproduced
from John Gage
Bruce Momjian [Sun, 25 Jul 2010 03:47:33 +0000 (03:47 +0000)]
Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all
migrations.
Backpatch to 9.0.
Bruce Momjian [Sun, 25 Jul 2010 03:28:39 +0000 (03:28 +0000)]
Prevent pg_upgrade from migrating databases that use reg* data types
where the oid is not preserved by pg_upgrade (everything but pg_type).
Update documentation.
Per bug report from depstein@alliedtesting.com.
Peter Eisentraut [Sat, 24 Jul 2010 16:46:43 +0000 (16:46 +0000)]
Fix typo
Peter Eisentraut [Sat, 24 Jul 2010 12:17:34 +0000 (12:17 +0000)]
Tidy up boolean data type page
by Thom Brown
Peter Eisentraut [Fri, 23 Jul 2010 20:04:09 +0000 (20:04 +0000)]
Add more checks against altering typed tables
- Prohibit altering column type
- Prohibit changing inheritance
- Move checks from Exec to Prep phases in ALTER TABLE code
backpatched to 9.0
Robert Haas [Fri, 23 Jul 2010 00:43:09 +0000 (00:43 +0000)]
Avoid deep recursion when assigning XIDs to multiple levels of subxacts.
Backpatch to 8.0.
Andres Freund, with cleanup and adjustment for older branches by me.
Bruce Momjian [Tue, 20 Jul 2010 18:14:25 +0000 (18:14 +0000)]
Properly replay CREATE TABLESPACE during crash recovery by deleting
directory/symlink before creation.
Report from Tom Lane.
Backpatch to 9.0.
Tom Lane [Sun, 18 Jul 2010 23:43:37 +0000 (23:43 +0000)]
Remove unnecessary "Not safe to send CSV data" complaint from elog.c's fallback
path when CSV logging is configured but not yet operational. It's sufficient
to send the message to stderr, as we were already doing, and the "Not safe"
gripe has already confused at least two core members ...
Backpatch to 9.0, but not further --- doesn't seem appropriate to change
this behavior in stable branches.
Tom Lane [Sun, 18 Jul 2010 19:37:57 +0000 (19:37 +0000)]
Allow ORDER BY/GROUP BY/etc items to match targetlist items regardless of
any implicit casting previously applied to the targetlist item. This is
reasonable because the implicit cast, by definition, wasn't written by the
user; so we are preserving the expected behavior that ORDER BY items match
textually equivalent tlist items. The case never arose before because there
couldn't be any implicit casting of a top-level SELECT item before we process
ORDER BY etc. But now it can arise in the context of aggregates containing
ORDER BY clauses, since the "targetlist" is the already-casted list of
arguments for the aggregate. The net effect is that the datatype used for
ORDER BY/DISTINCT purposes is the aggregate's declared input type, not that
of the original input column; which is a bit debatable but not horrendous,
and to do otherwise would require major rework that doesn't seem justified.
Per bug #5564 from Daniel Grace. Back-patch to 9.0 where aggregate ORDER BY
was implemented.
Heikki Linnakangas [Fri, 16 Jul 2010 11:36:10 +0000 (11:36 +0000)]
Fix typo spotted by Thom Brown.
Heikki Linnakangas [Fri, 16 Jul 2010 11:21:46 +0000 (11:21 +0000)]
Add a paragraph explaining what restartpoints are. Mention that
wal_keep_segments does not take effect during recovery.
Fujii Masao
Tom Lane [Wed, 14 Jul 2010 22:04:28 +0000 (22:04 +0000)]
Use an <xref> for restore_command reference. Marko Tiikkaja
Tom Lane [Wed, 14 Jul 2010 21:21:16 +0000 (21:21 +0000)]
Fix several problems in pg_dump's handling of SQL/MED objects, notably failure
to dump a PUBLIC user mapping correctly, as per bug #5560 from Shigeru Hanada.
Use the pg_user_mappings view rather than trying to access pg_user_mapping
directly, so that the code doesn't fail when run by a non-superuser. And
clean up some minor carelessness such as unsafe usage of fmtId().
Back-patch to 8.4 where this code was added.
Tom Lane [Wed, 14 Jul 2010 17:09:54 +0000 (17:09 +0000)]
Allow full SSL certificate verification (wherein libpq checks its host name
parameter against server cert's CN field) to succeed in the case where
both host and hostaddr are specified. As with the existing precedents
for Kerberos, GSSAPI, SSPI, it is the calling application's responsibility
that host and hostaddr match up --- we just use the host name as given.
Per bug #5559 from Christopher Head.
In passing, make the error handling and messages for the no-host-name-given
failure more consistent among these four cases, and correct a lie in the
documentation: we don't attempt to reverse-lookup host from hostaddr
if host is missing.
Back-patch to 8.4 where SSL cert verification was introduced.
Bruce Momjian [Tue, 13 Jul 2010 20:15:51 +0000 (20:15 +0000)]
Backpatch pg_upgrade fixes to 9.0:
In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.
In pg_upgrade, report /bin directory checks independent of /data checks.
Remove incorrect email address for pg_upgrade bug reports.
On Win32, pg_upgrade cannot sent any server log output to the log file
because of file access limitations on that platform.
Heikki Linnakangas [Tue, 13 Jul 2010 09:02:35 +0000 (09:02 +0000)]
Oops, in the previous fix to prevent a cursor that's being used in a FOR
loop from being dropped, I missed subtransaction cleanup. Pinned portals
must be dropped at subtransaction cleanup just as they are at main
transaction cleanup.
Per bug #5556 by Robert Walker. Backpatch to 8.0, 7.4 didn't have
subtransactions.
Robert Haas [Sat, 10 Jul 2010 00:50:37 +0000 (00:50 +0000)]
Clarify that "psql -c" ignores psqlrc files.
Tim Landscheidt
Tom Lane [Fri, 9 Jul 2010 22:57:47 +0000 (22:57 +0000)]
Avoid an Assert failure in deconstruct_array() by making get_attstatsslot()
use the actual element type of the array it's disassembling, rather than
trusting the type OID passed in by its caller. This is needed because
sometimes the planner passes in a type OID that's only binary-compatible
with the target column's type, rather than being an exact match. Per an
example from Bernd Helmle.
Possibly we should refactor get_attstatsslot/free_attstatsslot to not expect
the caller to supply type ID data at all, but for now I'll just do the
minimum-change fix.
Back-patch to 7.4. Bernd's test case only crashes back to 8.0, but since
these subroutines are the same in 7.4, I suspect there may be variant
cases that would crash 7.4 as well.
Tom Lane [Fri, 9 Jul 2010 21:11:57 +0000 (21:11 +0000)]
Fix ruleutils' get_variable() to print something useful for Vars referencing
resjunk outputs of subquery tlists, instead of throwing an error. Per bug
#5548 from Daniel Grace.
We might at some point find we ought to back-patch this further than 9.0,
but I think that such Vars can only occur as resjunk members of upper-level
tlists, in which case the problem can't arise because prior versions didn't
print resjunk tlist items in EXPLAIN VERBOSE.
Bruce Momjian [Fri, 9 Jul 2010 16:51:29 +0000 (16:51 +0000)]
Properly report errno/out-of-disk-space error from pg_upgrade when in
copy mode, per report from depstein@alliedtesting.com.
Patch suggestion from Magnus.
Backpatch to 9.0.X.
Marc G. Fournier [Fri, 9 Jul 2010 02:43:12 +0000 (02:43 +0000)]
tag beta3
Bruce Momjian [Thu, 8 Jul 2010 22:26:14 +0000 (22:26 +0000)]
Update release notes for 9.0 beta 3.
Peter Eisentraut [Thu, 8 Jul 2010 21:35:33 +0000 (21:35 +0000)]
Some small changes for plperl.sgml:
- wrapped long code-lines, for pdf
- typo
Erik Rijkers
Peter Eisentraut [Thu, 8 Jul 2010 21:32:28 +0000 (21:32 +0000)]
Translation updates for 9.0beta3
Tom Lane [Thu, 8 Jul 2010 19:00:11 +0000 (19:00 +0000)]
Minor kibitzing on previous patch: no need to run check more than once.
(_PG_init should be called only once anyway, but as long as it's got an
internal guard against repeat calls, that should be in front of the
version check.)
Peter Eisentraut [Thu, 8 Jul 2010 18:42:12 +0000 (18:42 +0000)]
Install safeguard against running PL/Python 2 and 3 in the same session
Bruce Momjian [Thu, 8 Jul 2010 16:44:12 +0000 (16:44 +0000)]
Doc change: effected -> affected, per correction from Matthew Wakeling
Tom Lane [Thu, 8 Jul 2010 16:30:13 +0000 (16:30 +0000)]
Add a cross-reference to precedence information to CREATE OPERATOR's
documentation. Per suggestion from Marc Cousin.
Magnus Hagander [Thu, 8 Jul 2010 16:19:50 +0000 (16:19 +0000)]
Make the Windows tcp keepalive support depend on the existance of the
SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't
support this API (yet?).
Tom Lane [Thu, 8 Jul 2010 16:08:30 +0000 (16:08 +0000)]
Update obsolete comment. Noted by Josh Tolley.
Tom Lane [Thu, 8 Jul 2010 15:15:05 +0000 (15:15 +0000)]
Fix variant float8 expected files to have exactly the expected spacing.
This wasn't important when we used diff's -w (--ignore-all-space) option
to compare regression result files, but it is now. Per buildfarm member
canary, which evidently has been offline since we did that in November,
but came to life again today.
Magnus Hagander [Thu, 8 Jul 2010 10:20:14 +0000 (10:20 +0000)]
Add support for TCP keepalives on Windows, both for backend and the new
libpq support.
Tom Lane [Thu, 8 Jul 2010 00:14:04 +0000 (00:14 +0000)]
Fix "cannot handle unplanned sub-select" error that can occur when a
sub-select contains a join alias reference that expands into an expression
containing another sub-select. Per yesterday's report from Merlin Moncure
and subsequent off-list investigation.
Back-patch to 7.4. Older versions didn't attempt to flatten sub-selects in
ways that would trigger this problem.
Tom Lane [Wed, 7 Jul 2010 15:13:21 +0000 (15:13 +0000)]
Adjust mbutils.c so it won't get broken by future pgindent runs.
To do that, replace L'\0' by (WCHAR) 0. Perhaps someday we should teach
pgindent about wide-character literals, but so long as this is the only
use-case in the entire Postgres sources, a workaround seems easier.
Bruce Momjian [Wed, 7 Jul 2010 14:42:09 +0000 (14:42 +0000)]
Document the interaction of write-barrier-enabled file systems, and BBU
caches, per June email thread.
Robert Haas [Tue, 6 Jul 2010 22:55:26 +0000 (22:55 +0000)]
Make log_temp_files based on kB, and revert docs & comments to match.
Per extensive discussion on pgsql-hackers. We are deliberately not
back-patching this even though the behavior of 8.3 and 8.4 is
unquestionably broken, for fear of breaking existing users of this
parameter. This incompatibility should be release-noted.
Tom Lane [Tue, 6 Jul 2010 22:03:05 +0000 (22:03 +0000)]
Accept slightly grotty coding in Makefile.global in order to keep the -L
flag for src/port/ in front of any -L flags placed in LDFLAGS by configure.
This undoes an L-flag-ordering change that I had thought would be safe,
but seems to be making at least one buildfarm member fail --- the only
theory for orca's failure that I can think of is that it's got an old
copy of libpgport.a in /usr/lib. Also allow for LDFLAGS_SL to be set by
contrib makefiles before they invoke Makefile.global.
Peter Eisentraut [Tue, 6 Jul 2010 21:37:31 +0000 (21:37 +0000)]
Add note that using PL/Python 2 and 3 in the same session will probably crash
Robert Haas [Tue, 6 Jul 2010 21:14:25 +0000 (21:14 +0000)]
Support setting the keepalive idle time on MacOS X.
MacOS X uses TCP_KEEPALIVE rather than TCP_KEEPIDLE for this purpose.
Thanks to Fujii Masao for the review.
Tom Lane [Tue, 6 Jul 2010 21:09:00 +0000 (21:09 +0000)]
Undo pgindent breakage (again). Per buildfarm.
Bruce Momjian [Tue, 6 Jul 2010 19:26:28 +0000 (19:26 +0000)]
Mention why one C file fails pgindent.
Bruce Momjian [Tue, 6 Jul 2010 19:19:02 +0000 (19:19 +0000)]
pgindent run for 9.0, second run
Bruce Momjian [Tue, 6 Jul 2010 19:18:19 +0000 (19:18 +0000)]
Update pgindent testing instructions.
Tom Lane [Tue, 6 Jul 2010 03:55:33 +0000 (03:55 +0000)]
Still more third thoughts: when linking shared libraries, LDFLAGS probably
needs to appear before anything placed in SHLIB_LINK. This is because
SHLIB_LINK is typically a subset of LIBS, and LIBS has to appear after
LDFLAGS on platforms that are sensitive to the relative order of -L and -l
switches.
Tom Lane [Tue, 6 Jul 2010 03:41:02 +0000 (03:41 +0000)]
Allow for LDFLAGS_SL already having a value in Makefile.aix.
Per buildfarm results.
Tom Lane [Mon, 5 Jul 2010 23:40:13 +0000 (23:40 +0000)]
Dept. of third thoughts: PG_LIBS may contain a -L switch, so it had better
stay in front of LDFLAGS.
Tom Lane [Mon, 5 Jul 2010 23:30:50 +0000 (23:30 +0000)]
Make sure LDFLAGS come before LIBS when linking contrib programs.
Solaris, at least, seems to be sensitive to the relative order of -L
and -l switches, so this is needed. Per buildfarm results.
Tom Lane [Mon, 5 Jul 2010 23:15:56 +0000 (23:15 +0000)]
Fix a few single-file (MODULES, not MODULE_big) contrib makefiles that were
supposing that they should set SHLIB_LINK rather than LDFLAGS_SL. Since these
don't go through Makefile.shlib that was a no-op on most platforms. Also
regularize the few platform-specific Makefiles that did pay attention to
SHLIB_LINK: it seems that the real value of that is to pull in BE_DLLLIBS,
so do that instead. Per buildfarm failures on cygwin.
Tom Lane [Mon, 5 Jul 2010 18:54:38 +0000 (18:54 +0000)]
Split the LDFLAGS make variable into two parts: LDFLAGS is now used for
linking both executables and shared libraries, and we add on LDFLAGS_EX when
linking executables or LDFLAGS_SL when linking shared libraries. This
provides a significantly cleaner way of dealing with link-time switches than
the former behavior. Also, make sure that the various platform-specific
%.so: %.o rules incorporate LDFLAGS and LDFLAGS_SL; most of them missed that
before. (I did not add these variables for the platforms that invoke $(LD)
directly, however. It's not clear if we can do that safely, since for the
most part we assume these variables use CC command-line syntax.)
Per gripe from Aaron Swenson and subsequent investigation.
Heikki Linnakangas [Mon, 5 Jul 2010 09:27:18 +0000 (09:27 +0000)]
The previous fix in CVS HEAD and 8.4 for handling the case where a cursor
being used in a PL/pgSQL FOR loop is closed was inadequate, as Tom Lane
pointed out. The bug affects FOR statement variants too, because you can
close an implicitly created cursor too by guessing the "<unnamed portal X>"
name created for it.
To fix that, "pin" the portal to prevent it from being dropped while it's
being used in a PL/pgSQL FOR loop. Backpatch all the way to 7.4 which is
the oldest supported version.
Bruce Momjian [Sun, 4 Jul 2010 13:42:51 +0000 (13:42 +0000)]
Simplify test_fsync duration computation.
Bruce Momjian [Sun, 4 Jul 2010 01:50:29 +0000 (01:50 +0000)]
Report test_fynsc times in tests per second, instead of total seconds.
Bruce Momjian [Sat, 3 Jul 2010 22:52:25 +0000 (22:52 +0000)]
Remove SGML tab.
Tom Lane [Sat, 3 Jul 2010 22:15:45 +0000 (22:15 +0000)]
Don't set recoveryLastXTime when replaying a checkpoint --- that was a bogus
idea from the start since the variable is only meant to track commit/abort
events. This patch reverts the logic around the variable to what it was in
8.4, except that the value is now kept in shared memory rather than a static
variable, so that it can be reported correctly by CreateRestartPoint (which is
executed in the bgwriter).
Tom Lane [Sat, 3 Jul 2010 21:23:58 +0000 (21:23 +0000)]
Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensible
to have different values in different processes of the primary server.
Also put it into the "Streaming Replication" GUC category; it doesn't belong
in "Standby Servers" because you use it on the master not the standby.
In passing also correct guc.c's idea of wal_keep_segments' category.
Tom Lane [Sat, 3 Jul 2010 20:43:58 +0000 (20:43 +0000)]
Replace max_standby_delay with two parameters, max_standby_archive_delay and
max_standby_streaming_delay, and revise the implementation to avoid assuming
that timestamps found in WAL records can meaningfully be compared to clock
time on the standby server. Instead, the delay limits are compared to the
elapsed time since we last obtained a new WAL segment from archive or since
we were last "caught up" to WAL data arriving via streaming replication.
This avoids problems with clock skew between primary and standby, as well
as other corner cases that the original coding would misbehave in, such
as the primary server having significant idle time between transactions.
Per my complaint some time ago and considerable ensuing discussion.
Do some desultory editing on the hot standby documentation, too.
Bruce Momjian [Sat, 3 Jul 2010 17:21:48 +0000 (17:21 +0000)]
Document more clearly on XML namespaces inside xpath function
Nikolay Samokhvalov
Bruce Momjian [Sat, 3 Jul 2010 16:33:15 +0000 (16:33 +0000)]
Make pg_upgrade copyrights just 2010, not 2010-2010.
Bruce Momjian [Sat, 3 Jul 2010 16:25:01 +0000 (16:25 +0000)]
Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom.
Bruce Momjian [Sat, 3 Jul 2010 14:23:14 +0000 (14:23 +0000)]
Add CVS tags to pg_upgrade and pg_upgrade_support files, per request
from Tom.