OSDN Git Service
Jakub Pawlowski [Mon, 14 Nov 2016 21:20:37 +0000 (21:20 +0000)]
Reenable advertising instance after an LE advertising state change
am:
06325e3d5d
Change-Id: I68e342b054c4547262a20fa12d938875554cc7ed
Jakub Pawlowski [Mon, 14 Nov 2016 19:20:52 +0000 (11:20 -0800)]
Reenable advertising instance after an LE advertising state change
Ensure BleAdvertisingManager::OnAdvertisingStateChanged() is called
after an advertising state change to re-enable advertising after
a connection.
This patch also fixes the registration test, which was broken since
one more advertising instance was freed for general usage.
Test: net_test_stack_multi_adv native test
Change-Id: I76887d98cb3ec386ebc0f7fad95170b8c18b9116
liuchao [Sun, 13 Nov 2016 09:42:42 +0000 (09:42 +0000)]
Remove useless NULL-pointer check code in l2cap_client_new
am:
8c29b62b08
Change-Id: Ib11a39dac9a58df3ddf01526f568cfb22832842f
liuchao [Fri, 11 Nov 2016 07:51:39 +0000 (15:51 +0800)]
Remove useless NULL-pointer check code in l2cap_client_new
Remove the useless "error:" label and NULL-pointer check block
Test: mm -j 8
Change-Id: I218f5f1e2741a49a0fe9bec749dea2484a1df2eb
Marie Janssen [Sat, 12 Nov 2016 04:52:46 +0000 (04:52 +0000)]
AVRCP: unify Get{Element,Item}Attributes response.
am:
033d5a211b
Change-Id: I1b23eb87a9f56bf0834b94c3d5a8016501b13726
Marie Janssen [Fri, 11 Nov 2016 17:07:04 +0000 (09:07 -0800)]
AVRCP: unify Get{Element,Item}Attributes response.
GetElementAttributes response and GetItemAttributes response share the
same format and require the same checks for length.
Test: play media on carkit, see media. especially with long items.
Bug:
32407250
Bug:
30571638
Change-Id: I8623e7d662f7a39112b7527b6f5ab63c5e32379c
Jakub Pawlowski [Sat, 12 Nov 2016 01:03:03 +0000 (01:03 +0000)]
Merge "Fix how LE connection parameters are set after connecting"
am:
d0f7dd5e0a
Change-Id: Ic311d18eaf8c0916dc92458b3a3d72545d0473b7
Treehugger Robot [Sat, 12 Nov 2016 00:52:50 +0000 (00:52 +0000)]
Merge "Fix how LE connection parameters are set after connecting"
Jakub Pawlowski [Fri, 11 Nov 2016 23:48:08 +0000 (23:48 +0000)]
Unify advertising API (1/3)
am:
d964cf944e
Change-Id: I6c0927f0c3cd28c3b6aaac0bd320ce8d2dc5e1ad
Jakub Pawlowski [Fri, 11 Nov 2016 23:33:58 +0000 (23:33 +0000)]
Always use big endian for keeping service UUID
am:
7680a0b1f6
Change-Id: Id3b7edb121a52da452a378145d83334b7f91d558
Jakub Pawlowski [Thu, 3 Nov 2016 22:41:50 +0000 (15:41 -0700)]
Unify advertising API (1/3)
This patch unifies advertising API. On startup, if VSC multi advertising
is avaliable, it will be used, otherwise
BleAdvertiserLegacyHciInterfaceImpl will be used, which provides one
advertising instance.
Test: sl4a tests are passing, all proper tests updated accordingly
Change-Id: I73753962e3a33a980e8a9a1174c8d88611a47e6b
Jakub Pawlowski [Wed, 9 Nov 2016 01:23:11 +0000 (17:23 -0800)]
Always use big endian for keeping service UUID
When adding services to GATT database, applications should always provide
it in big endian format.
Bug:
32750783
Change-Id: I5264357bdbb6bab453b63baae6563cde86d20bac
Jakub Pawlowski [Fri, 11 Nov 2016 21:35:18 +0000 (13:35 -0800)]
Fix how LE connection parameters are set after connecting
This patch fixes bug introduced in commit
95075be6e95e9021c1ddd834bcf9e3771c57c217
which would cause unnecessary connection parameter update requests
to be send. It should be sent immediately after connecting only.
Bug:
32563079
Bug:
28435172
Change-Id: Ibd9301a990f12a94e8043b9c29a480f068251ba8
Matadeen Mishra [Fri, 11 Nov 2016 21:48:51 +0000 (21:48 +0000)]
Handling Authentication Failure From the lower layer
am:
edb5ecf847
Change-Id: Ideef79c26b439c499883cf105adc906083a7fbd7
Matadeen Mishra [Wed, 23 Sep 2015 16:56:46 +0000 (22:26 +0530)]
Handling Authentication Failure From the lower layer
Use case: DUT unable to do connect with all devices in
Multipairing case.
Steps:
1. pair with HS
2. disconnect HS.
3. reconnect HS from DUT.
Failure: Authentication failure occurred due to LMP
transaction collision DUT not deleting link key which
lead to unable to connect to device.
Root Cause: Not posting the Authentication failure
event to application layer, while removing the link-key.
Fix: Post the Authentication failure event to application
and removing the link-key.
Test: code compilation.
Change-Id: I079d8ce89c1fea66f0624127514cec8405bfdd3d
Ajay Panicker [Fri, 11 Nov 2016 17:40:00 +0000 (17:40 +0000)]
Move callback to dispatch thread
am:
681a396515
Change-Id: Ic63dc9bd61b1b000b1d1910e89391b3c2f6484c2
Ajay Panicker [Wed, 9 Nov 2016 03:25:43 +0000 (19:25 -0800)]
Move callback to dispatch thread
Change the thread that the timeout posts a connection request event to
so that the state machine handles calling the callback on the correct
thread to prevent a JNI crash.
Bug:
32754737
Test: Manually paired a device that normally crashes phone
Change-Id: I2c3384feaa404cc583e81b2df994b7cbd079d25d
Jakub Pawlowski [Fri, 11 Nov 2016 02:15:47 +0000 (02:15 +0000)]
Fix incorrect check for empty out-of-band pairing data
am:
a638cc509b
Change-Id: I30ef65815e2a6cfcd897d19b16e3c6f20dc93c78
Jakub Pawlowski [Thu, 10 Nov 2016 23:56:46 +0000 (15:56 -0800)]
Fix incorrect check for empty out-of-band pairing data
Bug:
32780409
Test: try pairing with nRF52DK using OOB LE SC
Change-Id: I3c165843bb76c372b76bdc18a7d9226345d39037
Myles Watson [Thu, 10 Nov 2016 21:26:28 +0000 (21:26 +0000)]
Merge "device: Fix multi-line comments"
am:
8b33abf72d
Change-Id: Ia6b5ec84e1f578dfd742854b21302eff43367a72
Treehugger Robot [Thu, 10 Nov 2016 21:15:32 +0000 (21:15 +0000)]
Merge "device: Fix multi-line comments"
Jakub Pawlowski [Thu, 10 Nov 2016 20:07:52 +0000 (20:07 +0000)]
BLE OOB Pairing - parse address type (1/5)
am:
7921e8f594
Change-Id: I7847e6d211bf24fd4a03490b478e66bfef7fbfcf
Jakub Pawlowski [Thu, 10 Nov 2016 00:39:10 +0000 (16:39 -0800)]
BLE OOB Pairing - parse address type (1/5)
When address type is not parsed, creating bond to devices not using
random address is impossible.
Bug:
32780409
Test: try pairing with nRF52DK using random address
Change-Id: I95c4ebc7bd03cd1b895c9f17deef2e57d8b57d2a
Myles Watson [Thu, 10 Nov 2016 19:51:22 +0000 (19:51 +0000)]
device: Apply clang-format
am:
4451b3bf88
Change-Id: I8a1b7f90ad004bd95d05d9ebc772f7b59211dc7b
Myles Watson [Thu, 10 Nov 2016 18:29:22 +0000 (18:29 +0000)]
bta: Fix comment formatting after clang-format
am:
1baaae3f34
Change-Id: I6c3ebe7d1b88952b712f12932fc5902a97b1c0c7
Myles Watson [Thu, 10 Nov 2016 18:29:20 +0000 (18:29 +0000)]
bta: Apply clang-format
am:
cd1fd07f13
Change-Id: I040bca8a04c0f5434bfe2cfa77a331a09f7f1aa6
Myles Watson [Thu, 10 Nov 2016 18:29:18 +0000 (18:29 +0000)]
bta: Prepare include statements for clang-format
am:
f355ef5a4d
Change-Id: I5c2a63e95cfe6f9dc086a94017d20ef41dc4d28e
Myles Watson [Thu, 10 Nov 2016 18:29:16 +0000 (18:29 +0000)]
bta: Remove double asterisks in comments
am:
8af480e245
Change-Id: I7bbf866b6a6fd58997f5275fd9fac40314510c55
Myles Watson [Wed, 9 Nov 2016 18:27:00 +0000 (10:27 -0800)]
device: Fix multi-line comments
Test: mma -j32
Change-Id: I1df0e71cba73cfde0d973498698c7d6fa017e14a
Myles Watson [Wed, 9 Nov 2016 18:20:44 +0000 (10:20 -0800)]
device: Apply clang-format
clang-format -i --style=file device/include/* \
device/src/* device/test/*
Test: mma -j32
Change-Id: I1a0f9e1cd838c025fca487347358cc0079265004
Myles Watson [Wed, 9 Nov 2016 22:25:23 +0000 (14:25 -0800)]
bta: Fix comment formatting after clang-format
Test: mma -j32
Change-Id: Ic945ac421b1918527105c59674eda89afd3d4126
Myles Watson [Wed, 9 Nov 2016 21:17:43 +0000 (13:17 -0800)]
bta: Apply clang-format
clang-format -i --style=file bta/*/*
(twice)
Test: mma -j32
Change-Id: Ib118b1dfb6a34f9a5bfe153d65841e9041165264
Myles Watson [Wed, 9 Nov 2016 21:04:33 +0000 (13:04 -0800)]
bta: Prepare include statements for clang-format
bta: Separate includes of different types
Include "bta_sys.h" in bta/dm/bta_dm_int.h
Test: mma -j32
Change-Id: I292bc6518230201e1175937b9c6766c19709c9d5
Myles Watson [Wed, 9 Nov 2016 18:40:23 +0000 (10:40 -0800)]
bta: Remove double asterisks in comments
Double asterisks at the beginning of the line
sed -i s,"^[*][*]"," *", bta/*/*
Double asterisks after a space
sed -i s,"^ [*][*]\([^*]\)"," *\1", bta/*/*
sed -i s,"^ [*][*]$"," *", bta/*/*
Test: mma -j32
Change-Id: Ib83b802c7000176683b4e7f24d1255b3c2c6c01c
Myles Watson [Wed, 9 Nov 2016 20:50:22 +0000 (20:50 +0000)]
include: Apply clang-format
am:
c1e4239a77
Change-Id: I0c3df10153b04d3dfac8557a9308112dea47cbbe
Myles Watson [Wed, 9 Nov 2016 20:50:21 +0000 (20:50 +0000)]
include: Fix comment formatting
am:
a88d1e3337
Change-Id: I9c87a5c31eff67793d548b9a7331a9cfa89cea69
Myles Watson [Wed, 9 Nov 2016 17:47:42 +0000 (09:47 -0800)]
include: Apply clang-format
clang-format -i --style=file include/*
Test: mma -j32
Change-Id: Ibfb31af3fa82cfd6021fdc3203381b91e57bb71e
Myles Watson [Wed, 9 Nov 2016 17:41:48 +0000 (09:41 -0800)]
include: Fix comment formatting
In preparation for clang-format, fix a few comments that
would have been mangled.
Test: mma -j32
Change-Id: I7194818e93432f8bad4d7c114a93025e217aa694
Myles Watson [Tue, 8 Nov 2016 23:09:22 +0000 (23:09 +0000)]
bta: Remove executable permissions from code
am:
1ec6fffe00
Change-Id: I752091e8460fa04bac8e9c63814dc1fd327a32fc
Myles Watson [Tue, 8 Nov 2016 22:44:50 +0000 (14:44 -0800)]
bta: Remove executable permissions from code
Test: mma -j32
Change-Id: I2d0df65001c82b37f001ba4697e58c206f2a4b9c
Pavlin Radoslavov [Tue, 8 Nov 2016 05:29:47 +0000 (05:29 +0000)]
Revert "Replace pthread_mutex with std::mutex"
am:
dbf75f1762
Change-Id: I58a9d704edf25a558e17f0075d5402a9c4463af4
Pavlin Radoslavov [Tue, 8 Nov 2016 00:57:53 +0000 (00:57 +0000)]
Revert "Replace pthread_mutex with std::mutex"
This reverts commit
4b801825bd90b826fb53d51f497aba87d6d00d8c.
Change-Id: I862272c682409778dce356c8cba497ea4b78b14d
Marie Janssen [Mon, 7 Nov 2016 22:30:20 +0000 (22:30 +0000)]
Merge "AVRCP: Passthrough code cleanup"
am:
9c72807ee9
Change-Id: I8ee20a6774e67b575724695ba09fd06ffb4e15c1
Treehugger Robot [Mon, 7 Nov 2016 22:17:54 +0000 (22:17 +0000)]
Merge "AVRCP: Passthrough code cleanup"
Andre Eisenbach [Mon, 7 Nov 2016 20:22:47 +0000 (20:22 +0000)]
Mask out HFP 1.7 feature bits if peer version is <1.7
am:
d5eb30d9ca
Change-Id: I8efb1bd40225d020aad0b36130e170aa0202e6fa
Marie Janssen [Fri, 4 Nov 2016 19:36:14 +0000 (12:36 -0700)]
AVRCP: Passthrough code cleanup
Simplify the code surrounding passthrough commands and responses since
we send them all up to the upper layer now.
Test: basic AVRCP control from a carkit
Change-Id: I1d1e22454471a9948df6602b34ae767d7091197c
Andre Eisenbach [Sat, 5 Nov 2016 00:43:17 +0000 (17:43 -0700)]
Mask out HFP 1.7 feature bits if peer version is <1.7
Bug:
32378402
Test: manual
Change-Id: Iac8684bdfd02b18cce260bedefb829e8f7285361
Marco Nelissen [Mon, 7 Nov 2016 17:22:48 +0000 (17:22 +0000)]
Use libaudioclient instead of libmedia
am:
bc40fb1498
Change-Id: Ib98bf149e6ebff814fd054246ce8c24166755f87
Marco Nelissen [Thu, 3 Nov 2016 17:34:08 +0000 (10:34 -0700)]
Use libaudioclient instead of libmedia
Test: build/boot
Change-Id: I8aa5cb6c5351d04daf7117cf8bb983da50d4b089
(cherry picked from commit
af8b51c4061a5d0c18841195dfa1f4deaf9179b5)
Arun Jagadish [Fri, 4 Nov 2016 21:25:43 +0000 (21:25 +0000)]
Merge "Enable AVRCP Volume commands in TG role"
am:
4b9e97d0dd
Change-Id: I2a439bcf0dc72c82dbb9d33073a21b2ee53851e9
Treehugger Robot [Fri, 4 Nov 2016 21:22:39 +0000 (21:22 +0000)]
Merge "Enable AVRCP Volume commands in TG role"
Jack He [Fri, 4 Nov 2016 21:18:42 +0000 (21:18 +0000)]
Merge "Add missing brackets for "if" statement inside BTM_ConfirmReqReply()"
am:
50d1c49f38
Change-Id: I5b0cca8d8a9f80223deb6d7012b120eb32059c6a
Treehugger Robot [Fri, 4 Nov 2016 21:11:34 +0000 (21:11 +0000)]
Merge "Add missing brackets for "if" statement inside BTM_ConfirmReqReply()"
Ayan Ghosh [Fri, 4 Nov 2016 21:00:41 +0000 (21:00 +0000)]
Restart sniff timer on AVDTP signalling channel establishment
am:
583b817eda
Change-Id: I8bb852f9f503d569d1198d92096c26f0b48388f8
Ayan Ghosh [Fri, 6 Dec 2013 11:41:11 +0000 (17:11 +0530)]
Restart sniff timer on AVDTP signalling channel establishment
VolksWagan UHV Preminum takes time to initiate AVDTP media channel
after AVDTP signalling channel is up. If mentioned duration exceeds
7 seconds then ACL link goes into sniff due to which A2dp Connection
fails.
With this change we make sure that when AVDTP signalling channel
is up and media channel is not connected we do not go to sniff,
which is achieved by restarting sniff timer on signalling channel up
so that link does not go to sniff in between ongoing connection.
Change-Id: Ic3f268703067155ffd55a43f320ce199641c6b3f
Marie Janssen [Fri, 4 Nov 2016 20:39:40 +0000 (20:39 +0000)]
Merge "Replace pthread_mutex with std::mutex"
am:
eccb74f122
Change-Id: I2950ab079b8af4d34ee4fec67f518ca0ef00055e
Treehugger Robot [Fri, 4 Nov 2016 20:35:26 +0000 (20:35 +0000)]
Merge "Replace pthread_mutex with std::mutex"
Anubhav Gupta [Fri, 4 Nov 2016 20:31:39 +0000 (20:31 +0000)]
Merge "Enable incoming connection for AVRCP Controller"
am:
7703e94795
Change-Id: I225f36497e43871781041c21d6081c3aaee0473e
Treehugger Robot [Fri, 4 Nov 2016 20:26:04 +0000 (20:26 +0000)]
Merge "Enable incoming connection for AVRCP Controller"
Srinu Jella [Fri, 4 Nov 2016 20:04:48 +0000 (20:04 +0000)]
Merge "Handle L2CAP disconnection on incomplete connection"
am:
143d94bdc5
Change-Id: I28fb07082a134b087ecc1a512771f3ef3f5afa23
Treehugger Robot [Fri, 4 Nov 2016 19:59:37 +0000 (19:59 +0000)]
Merge "Handle L2CAP disconnection on incomplete connection"
Matadeen Mishra [Fri, 4 Nov 2016 19:57:38 +0000 (19:57 +0000)]
Move HDP reg_counter updates to BTIF thread
am:
f098d05775
Change-Id: Idd82fefe600af2065844bd7f9fbe83af8e6433fd
Arun Jagadish [Wed, 18 May 2016 10:34:20 +0000 (16:04 +0530)]
Enable AVRCP Volume commands in TG role
Enables the bits for AVRCP Vol UP, VOL Down and
Mute based on ICS document.
Change-Id: I50cdd97812b260812edf4d005c4dd95177d53426
Signed-off-by: Arun Jagadish <arun.jagadish@intel.com>
Jack He [Fri, 4 Nov 2016 18:18:32 +0000 (11:18 -0700)]
Add missing brackets for "if" statement inside BTM_ConfirmReqReply()
This fixes a potential NULL-pointer reference crash in case
btm_find_dev() returns NULL.
Test: mm -j 8
Change-Id: Ic154b872ca84b4e9e8bc57803a4d9ee7c1665204
Anubhav Gupta [Tue, 5 May 2015 14:54:47 +0000 (20:24 +0530)]
Enable incoming connection for AVRCP Controller
- Start listening for incoming AVRCP connection if we have
only AVRCP Controller
- Update default peer_features based on feature mask. In case
of incoming AVRCP connection, SDP will be done later.
In such a scenario default peer features sent to btif should
be based on features-set selected during initialization.
Test: code compilation
Change-Id: Ied8ac0673288a4423bd41500985366ddc2c567a8
Matadeen Mishra [Wed, 3 Feb 2016 15:11:26 +0000 (20:41 +0530)]
Move HDP reg_counter updates to BTIF thread
Use case: register/unregister HDP from third party APK
Test Steps:
1.Install Any Test APK which internally registers/unregister the HDP.
2.Run Test APK.
3.Do initialization of Test APK which internally registers the HDP.
4.Force stop the Test APK.
5.And rerun the APK by going back test APK menu.
6.Now it never perform the re-register the HDP as part of initialization.
Root Cause: HDP registration related counter write operations are done
in JNI main thread, and it's been referenced in BTIF thread.Sometimes,
if the context switch to BTIF thread doesn't happen immediately after
counter increment/decrement, it may not un-register the app if the
counter becomes 0.
Fix: Fixed it by making all operations related to counter in BTIF
thread, so that de-registration happens for all HDP APPs.
Test: code compilation.
Change-Id: I71ace68a5f3d39d81b646f5f40c02ce56b9e93f0
Srinu Jella [Wed, 16 Mar 2016 13:08:55 +0000 (18:38 +0530)]
Handle L2CAP disconnection on incomplete connection
- Sometimes before receiving the connection complete
event from remote device, upper layer might send a
disconnection on incomplete L2CAP connection, and expects
notification of connection failure.
- This change notifies disconnection to upper layers with
error in case L2CAP disconnection is received on
incomplete L2CAP channel.
Test: code compilation.
Change-Id: I4ab675329b3d791a3f68101495a6e6d90b13bde4
Marie Janssen [Thu, 3 Nov 2016 01:31:55 +0000 (18:31 -0700)]
Replace pthread_mutex with std::mutex
In an effort to simplify and reduce errors, replace pthread_mutexes
with std equivalents.
Test: run unit tests & manual sanity checks
Change-Id: Ia6492b0007dca311ebd1579f52b206993b7535fd
Andre Eisenbach [Fri, 4 Nov 2016 16:34:25 +0000 (16:34 +0000)]
Add OWNERS file
am:
1ee975f50f
Change-Id: Ie2fc1c8116f1713fa2a76860fb7a15740b9b0a8c
Andre Eisenbach [Fri, 4 Nov 2016 16:18:48 +0000 (09:18 -0700)]
Add OWNERS file
Change-Id: Id022d0c98ab3bddc8ceabef148a6c8d1cc4f0bc8
Andre Eisenbach [Fri, 4 Nov 2016 01:43:03 +0000 (01:43 +0000)]
Merge "Remove incorrect assert in btm_read_rssi_cb"
am:
4e70834ccc
Change-Id: I5db49042cc7c5a6f6ce8482e32505c91af7952ab
Treehugger Robot [Fri, 4 Nov 2016 01:39:27 +0000 (01:39 +0000)]
Merge "Remove incorrect assert in btm_read_rssi_cb"
Jakub Pawlowski [Fri, 4 Nov 2016 01:32:34 +0000 (01:32 +0000)]
Use standard types instead of OI_INT* and OI_UINT* types
am:
a239d20e95
Change-Id: I4ddb249f0576ca2ede3c26fe8891e13aafa518a4
Jakub Pawlowski [Thu, 3 Nov 2016 22:01:28 +0000 (15:01 -0700)]
Use standard types instead of OI_INT* and OI_UINT* types
Test: mma -j45
Change-Id: Ieadd33bfe1be9439e1aeb9a7844260a6e33d8dcd
Jakub Pawlowski [Fri, 4 Nov 2016 00:36:28 +0000 (00:36 +0000)]
Merge "Replace DWORD with uint32_t"
am:
5825613c96
Change-Id: I0040797ea4a4c905e6e5218700b8f06795c881b8
Sanket Agarwal [Fri, 4 Nov 2016 00:33:01 +0000 (00:33 +0000)]
Use rc_handle for reconciliation of timer callback
am:
b6ef10149c
Change-Id: I642c4c51190293f47245e3550c6d34b367c35359
Treehugger Robot [Fri, 4 Nov 2016 00:31:49 +0000 (00:31 +0000)]
Merge "Replace DWORD with uint32_t"
Andre Eisenbach [Thu, 3 Nov 2016 22:05:22 +0000 (15:05 -0700)]
Remove incorrect assert in btm_read_rssi_cb
|data| may be NULL if the RSSI request times out.
See btm_read_rssi_timeout implementation for details.
Bug:
32587130
Test: manual
Change-Id: I12ad78ecf5f5859bee7e1536956756bc16d7e54e
Jakub Pawlowski [Thu, 3 Nov 2016 21:18:55 +0000 (14:18 -0700)]
Replace DWORD with uint32_t
Test: mma -j45
Change-Id: Ia96e87460a22c9c14ba682d07dfcb3bf5479add8
Sanket Agarwal [Wed, 2 Nov 2016 22:01:32 +0000 (15:01 -0700)]
Use rc_handle for reconciliation of timer callback
Since the timer callback requires copy of the passed argument, it is not
a good idea to pass non-constant data. Instead passing handle since
lookup based on the handle is safe against possible corruption.
Bug: b/
32610667
Change-Id: I02270b0f52d79310e2db8cf218f624eeb674b9c8
Sanket Agarwal [Wed, 2 Nov 2016 21:13:30 +0000 (21:13 +0000)]
Check A2DP source is not already shut{ting} down
am:
f436d2f131
Change-Id: I88a62d05c77486ac89fbe441dbee7763250b2b01
Sanket Agarwal [Wed, 2 Nov 2016 18:56:44 +0000 (11:56 -0700)]
Check A2DP source is not already shut{ting} down
In case A2DP is not enabled we are still executing the shut down path
which is leading to a race condition and posting to a thread queue which
is never created.
Bug: b/
32610895
Change-Id: Id0cf95f4c7b5be26be28db5e837fbca3a0a87072
Pavlin Radoslavov [Wed, 2 Nov 2016 18:01:00 +0000 (18:01 +0000)]
A2DP codec related fixes and cleanup
am:
feee26c3da
Change-Id: Ia923fad9dee9043df32bcc4be834ce9561958cc0
Pavlin Radoslavov [Tue, 25 Oct 2016 17:17:56 +0000 (10:17 -0700)]
A2DP codec related fixes and cleanup
* Update bta_av_co_audio_getconfig() to select the preferred codec
* Fix a bug in selecting the A2DP codec inside
bta_av_co_audio_set_codec()
* No need for function A2DP_ParsSbcMplHdr() to be exposed in the API
* Generalize the following APIs, so they can be used to redirect
the call for vendor-specific codecs:
- A2DP_CodecSepIndexStr()
- A2DP_InitCodecConfig()
- A2DP_SetSourceCodec()
* Change tA2DP_ENCODER_INIT_PARAMS.SamplingFreq from uint16_t to
uint32_t so it can store larger sampling frequency.
* Rename content protection constants from BTA_AV_CP_*
to AVDT_CP_* and move them from bta_av_co.h to avdt_api.h
* Rename some of the internal functions in a2dp_sbc.cc
* Add extra debug logging and fix some comments
Test: A2DP streaming, unit tests passing
Change-Id: I1b67ff18dc568dd859429fcd89c644799fb1438d
Jakub Pawlowski [Wed, 2 Nov 2016 03:25:12 +0000 (03:25 +0000)]
Merge "Remove unused BLE_PERIPHERAL_MODE_SUPPORT"
am:
9203cb05b5
Change-Id: I71251811ef21cd26561df0b025825fafc5ccb256
Jakub Pawlowski [Wed, 2 Nov 2016 03:21:38 +0000 (03:21 +0000)]
Merge "Remove unused BLE_PERIPHERAL_MODE_SUPPORT"
Satish Kodishala [Wed, 2 Nov 2016 02:33:39 +0000 (02:33 +0000)]
AG: CLCC response can contain non-ATD characters
am:
c75a71d9b6
Change-Id: I600982c46cdbdcbb26332e0498ce206bb46b5c92
Satish Kodishala [Wed, 22 Jun 2016 08:52:41 +0000 (14:22 +0530)]
AG: CLCC response can contain non-ATD characters
Test case:
1. Connect Plantronics backbeat PRO headset.
2. Initiate outgoing call from phone.
3. Accept the call from remote side and terminate call.
4. Try to redial from headset and observe
Failure:
AG is sending error for redial request from BT headset.
Root cause:
Sometimes, the number in CLCC response has "-".
Repeated from the headset, the ATD string has "-"
which is not allowed in the dial string for ATD and
errors.
Fix:
* Sanitize CLCC response to only include valid ATD characters.
* Accept "-" in ATD because it works for us.
Change-Id: I854165c7da295f428852c829543eb4fc18455d91
Jakub Pawlowski [Tue, 1 Nov 2016 22:34:32 +0000 (22:34 +0000)]
Merge "Move start advertise method to advertising interface (3/3)"
am:
3d20eb86d9
Change-Id: I39995983cee5d2351c9c56b8eafa4692e5fb1e83
Jakub Pawlowski [Tue, 1 Nov 2016 20:43:03 +0000 (13:43 -0700)]
Remove unused BLE_PERIPHERAL_MODE_SUPPORT
This patch removes BLE_PERIPHERAL_MODE_SUPPORT and all code related to
it, which is unused.
Bug:
30622771
Bug:
24099160
Change-Id: Ic9cc2a94c8d1b974814d453ee8a0073e7d6deb85
Jakub Pawlowski [Tue, 1 Nov 2016 22:30:42 +0000 (22:30 +0000)]
Merge "Move start advertise method to advertising interface (3/3)"
Jack He [Tue, 1 Nov 2016 21:45:21 +0000 (21:45 +0000)]
Merge "Assign pairing code to bta_dm_cb before device name resolution"
am:
f29df4f5b9
Change-Id: I66afee204c54a076e525425900866df9ed5afdd6
Treehugger Robot [Tue, 1 Nov 2016 21:40:44 +0000 (21:40 +0000)]
Merge "Assign pairing code to bta_dm_cb before device name resolution"
Jakub Pawlowski [Mon, 31 Oct 2016 18:15:20 +0000 (11:15 -0700)]
Move start advertise method to advertising interface (3/3)
Advertising related code should be exposed through
BleAdvertiserInterface. Move client.listen function into this interface.
Remove reduntant clientif parameter.
Bug:
30622771
Bug:
24099160
Test: no tests necessary
Change-Id: Icc865c062e3d7c4b83bbeea6ff5b08bd2c1c4d9a
Jakub Pawlowski [Tue, 1 Nov 2016 20:56:48 +0000 (20:56 +0000)]
Merge "Simplify BTA_GATTC_Listen"
am:
96b55604b2
Change-Id: I9a22d0b834ced49e9a20b3f569a83edcb519aaee
Treehugger Robot [Tue, 1 Nov 2016 20:53:13 +0000 (20:53 +0000)]
Merge "Simplify BTA_GATTC_Listen"
Jack He [Tue, 1 Nov 2016 18:30:51 +0000 (11:30 -0700)]
Assign pairing code to bta_dm_cb before device name resolution
Device name resolution, BTM_ReadRemoteDeviceName(), will cause
bta_dm_sp_cback() to exit early and bta_dm_pinname_cback() callback
will be invoked after the resolution, which continues the pairing
with pairing code from bta_dm_cb.num_val. Hence, bta_dm_cb.num_val
needs to be assigned before BTM_ReadRemoteDeviceName() is called.
Test: manual
Bug:
31381715
Change-Id: I61f06a9d878dd72154d6621eb094dcea5f701cbc
Sanket Agarwal [Tue, 1 Nov 2016 20:03:22 +0000 (20:03 +0000)]
AVRCP CT: Add get_play_status_cmd API
am:
5211827c4c
Change-Id: I03d894ed50178c427178c3d38df19c6b43c54371
Sanket Agarwal [Thu, 22 Sep 2016 21:11:09 +0000 (14:11 -0700)]
AVRCP CT: Add get_play_status_cmd API
- Required for PTS test case TC_CT_MDI_BV_01_C
Bug: b/
31684931
Change-Id: Ice0bd36e3282d1c543c8c7bbec63f406311c0f6b
(cherry picked from commit
9a55fbe77cd9c6acb56e2e24cccfb9f34a89c729)
Jakub Pawlowski [Mon, 31 Oct 2016 16:50:20 +0000 (09:50 -0700)]
Simplify BTA_GATTC_Listen
It is necessary to make BTA_GATTC_Listen not dependent on client_if
before it is moved to advertising interface, where it belongs.
Bug:
30622771
Bug:
24099160
Test: no tests necessary
Change-Id: I75dc7e0fcd64fd3437474933069941b52740f0b5