OSDN Git Service
Sundeep Ghuman [Wed, 15 Mar 2017 23:40:34 +0000 (16:40 -0700)]
Fix list item spacing for preferences.
Bug: b/
33970117
Test: Existing tests pass - purely UI margin change. See screenshots in
bug.
Change-Id: I08ce646c9db2401c1462801ab39713fca8f5cc26
Lei Yu [Fri, 17 Mar 2017 17:11:46 +0000 (17:11 +0000)]
Merge "Change ripple in battery pages"
Paul Duffin [Fri, 17 Mar 2017 13:10:03 +0000 (13:10 +0000)]
Remove ambiguous wildcard import of org.mockito.Matchers.*
The recent upgrade to Mockito 2.7.13 has caused some problems
for grok (and new javac toolchain). The changed files used
wildcard imports to import the same methods from both Matchers
and Mockito.
This was not a problem previously because in the previous
version of Mockito the Mockito class extended the Matchers class
and so even though two methods with the same name were imported
they were not treated as a conflict because they were treated as
being the same method. In 2.7.13 the Mockito class no longer
extends the Matchers class instead they both extend the
ArgumentMatchers class and so for some reason javac no longer
treats them as the same method.
This was not detected by presubmit builds because jack is
still treating the methods as being the same.
Bug:
32912773
Test: m -j32 ANDROID_FORCE_JACK_ENABLED=disabled FrameworksWifiTests
Change-Id: I8c2b1dd39d2d653fe0fba19ed6421b7de25bb82f
TreeHugger Robot [Fri, 17 Mar 2017 01:47:59 +0000 (01:47 +0000)]
Merge "Fix NPE when building suggestion identifier."
TreeHugger Robot [Fri, 17 Mar 2017 01:34:24 +0000 (01:34 +0000)]
Merge "Add "Use open Wi-Fi automatically" setting."
Fan Zhang [Thu, 16 Mar 2017 22:50:31 +0000 (15:50 -0700)]
Fix NPE when building suggestion identifier.
And refactored the getIdent logic into feature provider.
Change-Id: Id6f66a6942cbaf6d26ae4dca62037a6cf01179a5
Fix:
36314240
Test: make RunSettingsRoboTests
TreeHugger Robot [Fri, 17 Mar 2017 00:09:53 +0000 (00:09 +0000)]
Merge "Listen to mobile data enabled flag change."
Amin Shaikh [Thu, 2 Feb 2017 23:47:53 +0000 (15:47 -0800)]
Add "Use open Wi-Fi automatically" setting.
- Add toggle to ConfigureWifiSettings for "Use open Wi-Fi automatically"
- Start ACTION_CUSTOM_ENABLE activity and handle result to set the
USE_OPEN_WIFI_PACKAGE setting.
Bug:
34773276
Test: make
Change-Id: I602e271d5113e415d290468548e35059bd45d8b8
jackqdyulei [Wed, 15 Mar 2017 18:14:29 +0000 (11:14 -0700)]
Change ripple in battery pages
1. Add ripple for battery header
2. Remove ripple for battery usage graph
Bug:
35959227
Bug:
35957849
Test: Manual
Change-Id: I7b9965304d0c79b59bdac92719e303931206b672
TreeHugger Robot [Thu, 16 Mar 2017 23:01:44 +0000 (23:01 +0000)]
Merge "Purify SettingsActivity from old search code."
Fan Zhang [Thu, 16 Mar 2017 19:50:44 +0000 (12:50 -0700)]
Listen to mobile data enabled flag change.
The listener is necessary to show/hide the gear icon on top of billing
cycle settings screen as user turn on/off mobile data from QS.
code cleanup: remove dividedCategory
Fix:
28066849
Test: make RunSettinsgRoboTests
Change-Id: I3b7075512042127fd711a8a70a572adfed069502
TreeHugger Robot [Thu, 16 Mar 2017 21:54:59 +0000 (21:54 +0000)]
Merge "Change name of NetworkScorerPicker."
Matthew Fritze [Thu, 16 Mar 2017 20:19:20 +0000 (13:19 -0700)]
Purify SettingsActivity from old search code.
Bug:
35763944,
32590887
Test: make RunSettingsRoboTests
Change-Id: Id8140b68a676e595bff095546fa119cd3ced2c4a
Stephen Chen [Thu, 16 Mar 2017 20:22:22 +0000 (13:22 -0700)]
Change name of NetworkScorerPicker.
Bug:
36028168
Test: n/a
Change-Id: I8eb8c1ebf703692882b025bebecb0953f934dcd6
TreeHugger Robot [Thu, 16 Mar 2017 20:15:01 +0000 (20:15 +0000)]
Merge "Remove ranking code for Old Search"
Fan Zhang [Thu, 16 Mar 2017 20:13:35 +0000 (20:13 +0000)]
Merge "Fix a crash when resuming sound setting with AfW on Ryu"
Maurice Lam [Thu, 16 Mar 2017 19:47:00 +0000 (19:47 +0000)]
Merge "Remove unused ExploreByTouchHelper class"
TreeHugger Robot [Thu, 16 Mar 2017 18:30:09 +0000 (18:30 +0000)]
Merge "Update some strings to match spec"
Fan Zhang [Thu, 16 Mar 2017 18:08:59 +0000 (11:08 -0700)]
Fix a crash when resuming sound setting with AfW on Ryu
Also renamed a few xmls
Change-Id: I8ff5a778a39ea45471a27048be4ea2f21075872a
Fix:
36357493
Test: make RunSettingsRoboTests
TreeHugger Robot [Thu, 16 Mar 2017 18:06:23 +0000 (18:06 +0000)]
Merge "packages/apps/Settings: Add APCT tests to the device-tests suite."
liurong [Thu, 16 Mar 2017 17:33:53 +0000 (17:33 +0000)]
Merge "Optimized Code: call direct method to get integer extra" am:
b7fa46453a am:
7e51242c05
am:
e821a7af23
Change-Id: I9f042c269caa25c2824e62e06e4fb775124310b7
Maurice Lam [Thu, 16 Mar 2017 03:31:36 +0000 (20:31 -0700)]
Remove unused ExploreByTouchHelper class
Framework bug fixes removed the need for this copy, and
it's not referenced anyway.
Test: Existing tests pass
Change-Id: I1dd5045246ed737b30da2d558d14bc2c86af4f31
liurong [Thu, 16 Mar 2017 17:30:51 +0000 (17:30 +0000)]
Merge "Optimized Code: call direct method to get integer extra" am:
b7fa46453a
am:
7e51242c05
Change-Id: Ide77fb0f05a8eeb2df4ab24dc1831cd734c95362
liurong [Thu, 16 Mar 2017 17:27:51 +0000 (17:27 +0000)]
Merge "Optimized Code: call direct method to get integer extra"
am:
b7fa46453a
Change-Id: Ib7194de15766eb4912e7bbd43b308bd51dd5496a
Treehugger Robot [Thu, 16 Mar 2017 17:23:29 +0000 (17:23 +0000)]
Merge "Optimized Code: call direct method to get integer extra"
Fan Zhang [Wed, 15 Mar 2017 23:13:46 +0000 (16:13 -0700)]
Update some strings to match spec
Change-Id: Iba242871fce9c9bca8fbbc5d3ad3f7948f35d3d0
Fix:
36234108
Test: make RunSettingsRoboTests
Matthew Fritze [Wed, 15 Mar 2017 22:46:21 +0000 (15:46 -0700)]
Remove ranking code for Old Search
Test: make RunSettingsRoboTests
Bug:
35763944
Change-Id: I30b1d22f2de293bd6ff03352ca5793b00beec61a
Christine Franks [Thu, 16 Mar 2017 15:25:50 +0000 (15:25 +0000)]
Merge "Change strings for system alert window setting"
Julia Reynolds [Wed, 15 Mar 2017 15:32:54 +0000 (11:32 -0400)]
Notification channel settings updates
- Show a deleted count instead of individual deleted channels
- Make the link to app settings more prominent
- Reload settings onresume
Change-Id: I4f493181194943310ba536eb2bca270cec7cafce
Fixes:
36119790
Fixes:
36191444
Test: manual
Julia Reynolds [Mon, 13 Mar 2017 19:06:28 +0000 (15:06 -0400)]
Display channel/group names only.
Test: manual
Change-Id: I7da68f71ddb78f3150ebc64af40310de65cd010c
liurong [Thu, 16 Mar 2017 11:52:40 +0000 (19:52 +0800)]
Optimized Code: call direct method to get integer extra
Description: Make the default preferred sim slot as the first one(0) when get PREFERRED_SIM.
Test: NA
Change-Id: Id54bdbefd413c58ecd637cb8ff522861ead79331
Signed-off-by: liurong <liurong@xiaomi.com>
Saige McVea [Thu, 16 Mar 2017 00:49:33 +0000 (00:49 +0000)]
Merge "Fixes string reference in SEARCH_INDEX_DATA_PROVIDER and minor changes to UI based on UX review."
TreeHugger Robot [Thu, 16 Mar 2017 00:46:37 +0000 (00:46 +0000)]
Merge "Create robolectric tests for WifiNetworkDetailsFragment."
Christine Franks [Tue, 14 Mar 2017 17:25:46 +0000 (10:25 -0700)]
Change strings for system alert window setting
Bug:
36070413
Test: Settings reflects new strings, and make RunSettingsRoboTests
Change-Id: I94a92ecee4d37fff2a0c128061d90ed6ef1cc016
TreeHugger Robot [Thu, 16 Mar 2017 00:17:11 +0000 (00:17 +0000)]
Merge "SearchFragment removes stale data from the database"
TreeHugger Robot [Thu, 16 Mar 2017 00:13:18 +0000 (00:13 +0000)]
Merge "Disable collapse when fragment is opened from search"
Marie Janssen [Wed, 15 Mar 2017 23:02:23 +0000 (23:02 +0000)]
Merge "Bluetooth: leave screen off for permission request" am:
172b01035d am:
09f5638b92
am:
895ac35f4d
Change-Id: I9e162f37b76ad8e7adc438d082d8352720916df0
Marie Janssen [Wed, 15 Mar 2017 23:00:06 +0000 (23:00 +0000)]
Merge "Bluetooth: leave screen off for permission request" am:
172b01035d
am:
09f5638b92
Change-Id: I5af6b6f3d6463cd33c9074d31ba0e8c16eb6c9a7
Marie Janssen [Wed, 15 Mar 2017 22:57:38 +0000 (22:57 +0000)]
Merge "Bluetooth: leave screen off for permission request"
am:
172b01035d
Change-Id: Id768f3a4cdbb4286cd1096f94b6fb5b11bae6cc8
Treehugger Robot [Wed, 15 Mar 2017 22:49:56 +0000 (22:49 +0000)]
Merge "Bluetooth: leave screen off for permission request"
Matthew Fritze [Tue, 24 Jan 2017 03:33:34 +0000 (19:33 -0800)]
SearchFragment removes stale data from the database
When search fragment is created, it will get a list of
the non-indexable keys and verify that each of the results
are not a part of that list.
This CL moves the non-indexable keys logic into a
controller for shared use between SearchFragment
and DatabaseIndexingManager.
Bug:
33209418
Test: make RunSettingsRoboTests
Change-Id: I4ed3812ecc5ee9e63b75ba6edbc7ff8712e8e9c9
Sundeep Ghuman [Wed, 15 Mar 2017 02:59:36 +0000 (19:59 -0700)]
Create robolectric tests for WifiNetworkDetailsFragment.
More tests to follow in separate CLs. Submitting test class in order to
unblock parallel development.
Bug:
35963536
Test: make RunSettingsRoboTests
Change-Id: I50752ba0d6c53d016bf5809f7bd5d5f6e0350b90
TreeHugger Robot [Wed, 15 Mar 2017 22:26:36 +0000 (22:26 +0000)]
Merge "Use GLIF theme for screen lock confirmation"
Fan Zhang [Wed, 15 Mar 2017 22:06:41 +0000 (15:06 -0700)]
Disable collapse when fragment is opened from search
Change-Id: I9564dff4ec53256a0fe992055049cf65ce68e37b
Fix:
36076953
Test: make RunSettingsRoboTests
Simran Basi [Wed, 15 Mar 2017 22:12:17 +0000 (15:12 -0700)]
packages/apps/Settings: Add APCT tests to the device-tests suite.
This CL adds the APCT tests within this project to
a similar suite as CTS known as device-tests.
The current method of running APCT tests in the infrastructure
is unaffected.
Bug:
35882476
Test: `make dist device-tests -j` and local builds of
continuous_instrumentation_tests & continuous_native_tests
Change-Id: Ie1b2c6aefbe1497a2e90077a3ed8ab75721dc87b
Saige McVea [Wed, 15 Mar 2017 07:53:41 +0000 (00:53 -0700)]
Fixes string reference in SEARCH_INDEX_DATA_PROVIDER and minor changes to UI based on UX review.
Bug:
34682532
Test: ag/
1813674 and manual testing with TalkBack, Switch Access, S2S, and Accessibility Scanner.
Undo "Revert "Accessibility settings refresh.""
This reverts commit
31d855e73974722e78cd4cf244746a143191b4a7.
Change-Id: I7187250e8070418894aee4ee6c8c5d8282339c82
TreeHugger Robot [Wed, 15 Mar 2017 21:44:35 +0000 (21:44 +0000)]
Merge "Refactor all saved query related logic into a controller"
Stefano Tommasini [Wed, 15 Mar 2017 21:35:12 +0000 (21:35 +0000)]
Merge "Add new theme in Settings."
Daniel Nishi [Wed, 15 Mar 2017 20:30:09 +0000 (20:30 +0000)]
Merge "Category breakdown size should match total size."
Maurice Lam [Fri, 10 Mar 2017 23:31:30 +0000 (15:31 -0800)]
Use GLIF theme for screen lock confirmation
Theme the confirm password screen similar to setup wizard and screen
lock enrollment flow, so that we can start showing it during setup
wizard.
The new layouts are called "internal" because it's supposed to be
used only when another settings screen starts it. For external
intents from CONFIRM_DEVICE_CREDENTIAL, the existing theme and layout
are unchanged.
Bug:
32373672
Test: Run ConfirmLockPasswordTest with `am instrument`
Change-Id: Ib887a763a073e6e4b96264d08846827b2e5cbf52
TreeHugger Robot [Wed, 15 Mar 2017 19:44:41 +0000 (19:44 +0000)]
Merge "Allow page to suppress all of its content from search."
TreeHugger Robot [Wed, 15 Mar 2017 19:42:41 +0000 (19:42 +0000)]
Merge "Add button to remove saved search query"
Fan Zhang [Wed, 15 Mar 2017 18:39:17 +0000 (11:39 -0700)]
Refactor all saved query related logic into a controller
Change-Id: I96f7dd91d7d2715141a9905cb59262d927560da4
Fix:
27391895
Test: make RunSettingsRoboTests
Jay [Wed, 15 Mar 2017 19:28:57 +0000 (19:28 +0000)]
Merge "Improve Wi-Fi Settings UI in guest mode" am:
31f64a1253 am:
241d902200
am:
94854cc57b -s ours
Change-Id: Iffe4bd1fac36c1b51748b802308b3b5dcf5ccb54
Jay [Wed, 15 Mar 2017 19:24:13 +0000 (19:24 +0000)]
Merge "Improve Wi-Fi Settings UI in guest mode" am:
31f64a1253
am:
241d902200
Change-Id: I945b4604a82b8fccc2c24ea3faf1d7b299b3cfb7
Jay [Wed, 15 Mar 2017 19:18:43 +0000 (19:18 +0000)]
Merge "Improve Wi-Fi Settings UI in guest mode"
am:
31f64a1253
Change-Id: I15f05538344aa615a4f69eebf7fdec66efc3cf29
Treehugger Robot [Wed, 15 Mar 2017 19:11:25 +0000 (19:11 +0000)]
Merge "Improve Wi-Fi Settings UI in guest mode"
Stefanot [Wed, 15 Mar 2017 16:41:38 +0000 (16:41 +0000)]
Add new theme in Settings.
We add this style so activities can use SuwThemeGlif.Light theme but
also use Settings default window animations.
Test: RunSettingsRoboTests
BUG:
35959708
Change-Id: Iaedfbf4b9321ff4d32ab44c57b01d9d4a24e0d03
Jay [Thu, 14 Jul 2016 08:31:03 +0000 (16:31 +0800)]
Improve Wi-Fi Settings UI in guest mode
Progress bar is still seen along with a permission forbidden tip in
guest mode and it's confusing. It should be hidden because actually
nothing happens there.
When Wi-Fi is off, Wi-Fi OFF tip should be shown even in guest mode
becuase it should be consistent with Wi-Fi status.
Improves
d8c3ca43163427a75c8b70114096238177f97af0.
Bug:
31235488
Test: manual inspection.
Change-Id: I611719db253a0aec03d61e881af0e5dc3869d50b
Merged-In: If89728e293721cea45dcd717316d87f6df17ea7c
Fan Zhang [Wed, 15 Mar 2017 00:14:05 +0000 (17:14 -0700)]
Add button to remove saved search query
TODO: move all saved query related logic into its own manager instead of
leaving them in SearchFragment.
Change-Id: I9635140eb507331246f9035a23138421cfa4b50a
Fix:
27391895
Test: make RunSettingsRoboTests
Lei Yu [Wed, 15 Mar 2017 17:23:44 +0000 (17:23 +0000)]
Merge "Update todo list comment in PowerUsageAdvanced"
TreeHugger Robot [Wed, 15 Mar 2017 16:37:00 +0000 (16:37 +0000)]
Merge "Remove unused import."
TreeHugger Robot [Wed, 15 Mar 2017 15:52:02 +0000 (15:52 +0000)]
Merge "Fix convert to fbe"
Andrew Scull [Wed, 15 Mar 2017 14:32:27 +0000 (14:32 +0000)]
Remove unused import.
Missed the cleanup step from previous CL.
Test: it builds
Change-Id: I62494994731189f962ca2dd26a7c3283784792ed
TreeHugger Robot [Wed, 15 Mar 2017 14:11:34 +0000 (14:11 +0000)]
Merge "Disallow fingerprint based on user unlock state."
Andrew Scull [Wed, 15 Mar 2017 12:42:18 +0000 (12:42 +0000)]
Disallow fingerprint based on user unlock state.
Previously, the KeyStore lock state was used but this doesn't hold any
real value and may be removed in future. The user unlock state is the
source of truth we are looking for.
Test: Enroll finger, turn off work, lock and unlock device, turn on
work, asked for pin but can no longer user fingerprint.
Fixes:
34858001
Change-Id: I228952f4f7fd24916d294b5b523c6d3609520506
TreeHugger Robot [Wed, 15 Mar 2017 04:03:57 +0000 (04:03 +0000)]
Merge "Fix Wi-Fi Settings Guest mode UI."
TreeHugger Robot [Wed, 15 Mar 2017 02:43:11 +0000 (02:43 +0000)]
Merge "Revert "Make IME handling deterministic in CryptKeeper""
Stephen Chen [Wed, 15 Mar 2017 02:28:04 +0000 (19:28 -0700)]
Fix Wi-Fi Settings Guest mode UI.
Progress bar should not show in guest mode when onViewCreated.
When Wi-Fi is off, Wi-Fi OFF tip should be shown even in guest
mode to be consistent with Wi-Fi status.
Bug:
35627922
Test: tracked in b/
35324506
Change-Id: If89728e293721cea45dcd717316d87f6df17ea7c
TreeHugger Robot [Wed, 15 Mar 2017 01:45:27 +0000 (01:45 +0000)]
Merge "Fix calculation of Access Point Level."
TreeHugger Robot [Wed, 15 Mar 2017 01:40:45 +0000 (01:40 +0000)]
Merge "Clarify meaning of string"
Tom Cherry [Wed, 15 Mar 2017 01:09:42 +0000 (01:09 +0000)]
Revert "Make IME handling deterministic in CryptKeeper"
This reverts commit
4ae46cd1ad0725c8049c3954de19874df8483983.
Bug:
36148078
Change-Id: I776ad2e6ba0eabacb3d6be6de23ba37fe5ce7bc7
TreeHugger Robot [Wed, 15 Mar 2017 01:03:19 +0000 (01:03 +0000)]
Merge "Create the Wifi Network Details Page."
Sundeep Ghuman [Mon, 13 Mar 2017 22:52:40 +0000 (15:52 -0700)]
Fix calculation of Access Point Level.
Bug: b/
35854026
Test: make RunSettingsRoboTests
Change-Id: I5287e8c7b46a463cfa25659c756f6ca9175cb68c
Bartosz Fabianowski [Tue, 14 Mar 2017 23:16:00 +0000 (00:16 +0100)]
Clarify meaning of string
Translators got confused by one of the strings. Add a more
detaled explanation what the string refers to.
Bug:
36170404
Test: None
Change-Id: I7a66fcd5943205501188c5fca2e68630e447f69f
Sundeep Ghuman [Tue, 28 Feb 2017 02:21:53 +0000 (18:21 -0800)]
Create the Wifi Network Details Page.
This page should not be searchable, as it corresponds to a specific
access point, thus click on a search result would not have an access
point in which to open.
Fix WifiPicker bugs b/
35883232 and b/
35951638 that deal with UI jank.
Bug:
34713316
Test: Tracked in b/
35963536 and to be implemented in an immediate follow
up CL.
Change-Id: Iad7f26c7f04c3fc7d07a8e9188843eeb4d44cd36
TreeHugger Robot [Tue, 14 Mar 2017 22:21:22 +0000 (22:21 +0000)]
Merge "Add Advanced button to Apps & notifications page."
TreeHugger Robot [Tue, 14 Mar 2017 21:46:33 +0000 (21:46 +0000)]
Merge "Display recents when search fragment open."
Fan Zhang [Tue, 14 Mar 2017 19:38:43 +0000 (12:38 -0700)]
Allow page to suppress all of its content from search.
To suppress things from search, we usually use preferencecontroller to
control individual items. But a page can sometimes to disabled
entirely. Now it can set isPageSearchEnabled to false to achieve that.
Change-Id: I39424b7fdc6460e27fd7c83cf09b5ace12d1cc37
Fix:
36201167
Test: make RunSettingsRoboTests
Doris Ling [Mon, 13 Mar 2017 21:36:12 +0000 (14:36 -0700)]
Add Advanced button to Apps & notifications page.
- set the progressive mixin to show 3 items initially.
Change-Id: I874982e9b230d5b6afe4f2ced8e8c8c4dd84ba79
Fix:
36177949
Test: visual
Doris Ling [Tue, 14 Mar 2017 20:20:36 +0000 (20:20 +0000)]
Merge "Update the ordering of the homepage tiles."
TreeHugger Robot [Tue, 14 Mar 2017 20:11:16 +0000 (20:11 +0000)]
Merge "Update fingerprint enrolling flow"
Lei Yu [Tue, 14 Mar 2017 20:01:32 +0000 (20:01 +0000)]
Merge "Remove hardcoded color for settings dashboard"
Fan Zhang [Tue, 14 Mar 2017 01:09:29 +0000 (18:09 -0700)]
Display recents when search fragment open.
Bug:
27391895
Test: make RunSettingsRoboTests
Change-Id: I62cfa35af96babf85a795910aa76dc774e2b80f2
jackqdyulei [Thu, 9 Mar 2017 20:48:54 +0000 (12:48 -0800)]
Remove hardcoded color for settings dashboard
1. Change card_background to default background color. In settings
light theme, background color is exactly the #fafafa
2. Change card_background_grey to colorSecondary, which is
material_grey_200 in settings light theme.
Bug:
36139640
Test: Screenshot
Change-Id: I20081e768985ce6c0b9000448ae48599f18b293a
TreeHugger Robot [Tue, 14 Mar 2017 17:17:14 +0000 (17:17 +0000)]
Merge "Add misc logging:"
jackqdyulei [Tue, 14 Mar 2017 17:05:06 +0000 (10:05 -0700)]
Update todo list comment in PowerUsageAdvanced
Bug:
34385770
Test: Manual
Change-Id: Ifca1d1251d9735cf33e3a919d773ec03a9b2f644
TreeHugger Robot [Tue, 14 Mar 2017 01:32:10 +0000 (01:32 +0000)]
Merge "Import translations. DO NOT MERGE"
TreeHugger Robot [Tue, 14 Mar 2017 00:44:02 +0000 (00:44 +0000)]
Merge "Update strings and layout for enterprise privacy"
TreeHugger Robot [Tue, 14 Mar 2017 00:38:09 +0000 (00:38 +0000)]
Merge "Only crop photos owned by Settings."
Daniel Nishi [Tue, 14 Mar 2017 00:11:58 +0000 (00:11 +0000)]
Merge "Count legacy games as games in Storage view."
TreeHugger Robot [Mon, 13 Mar 2017 23:38:55 +0000 (23:38 +0000)]
Merge "Update string s/celluar/mobile/g"
TreeHugger Robot [Mon, 13 Mar 2017 23:38:40 +0000 (23:38 +0000)]
Merge "Swipe to dismiss suggestions"
Fan Zhang [Mon, 13 Mar 2017 21:37:59 +0000 (14:37 -0700)]
Add misc logging:
- Button clicks in app detail page:
uninstall/disable/clear data/clear cache
- More logging in search:
log inline search result click, and its metadata such as
name/value/rank.
Fix:
32652772
Fix:
32798201
Test: make RunSettingsRoboTests
Change-Id: I90cef7c9ea9ea69ea9cf083013a38417097f8594
Yohei Yukawa [Mon, 13 Mar 2017 23:30:18 +0000 (23:30 +0000)]
Merge "Make IME handling deterministic in CryptKeeper"
Bartosz Fabianowski [Fri, 10 Mar 2017 14:47:14 +0000 (15:47 +0100)]
Update strings and layout for enterprise privacy
This CL continues the finalization of UI layout and strings for the
enterprise privacy page:
* Turn footer into a header
* Update strings
* Dynamically generate summaries for entry points in security page
Bug:
32692748
Test: m RunSettingsRoboTests
Change-Id: Ibf248ac269380fb1b919b01f88f721130060b7f9
Daniel Nishi [Mon, 13 Mar 2017 22:10:59 +0000 (22:10 +0000)]
Merge "Don't show owner as a secondary user."
Fan Zhang [Mon, 13 Mar 2017 21:56:08 +0000 (14:56 -0700)]
Update string s/celluar/mobile/g
Change-Id: If2f8d8ceca709c61d435894ab31d12b6bf8f3582
Fix:
34833792
Test: builds
Yohei Yukawa [Mon, 13 Mar 2017 20:27:59 +0000 (13:27 -0700)]
Make IME handling deterministic in CryptKeeper
We have been receiving more and more strange bug reports regarding
the initial IME visibility on CryptKeeper (Bug
31915865, Bug
35198715,
and Bug
36148078). Most likely we have introduced more bugs before
fixing previous bugs.
As the first step to disentangle multiple problems, this CL addresses
a long standing issue that CryptKeeper relies on @hide internal API
InputMethodManager#showSoftInputUnchecked(). As explained in
Bug
36015425, IMM#showSoftInputUnchecked() is considered harmful in
terms of bypassing standard IME focus handling flows, which prevents
us from taking advantage of historical debugging mechanism that we
have added recently in Bug
35079353.
Test: Manually verified that Bug
31915865 is still broken but this CL
does not make it worse.
1. Flash an image into a non direct-boot device.
2. Set up a device boot password.
3. adb reboot
After the step 3, the software keyboard shows up automatically
then suddenly disappears (Bug
35198715).
Bug:
36015425
Change-Id: I3cffeec286d9372ff05e85a49b82287cb1add8a2
Fan Zhang [Thu, 23 Feb 2017 00:41:38 +0000 (16:41 -0800)]
Swipe to dismiss suggestions
- Move dismiss suggestion logic into feature provider
- In DashboardData, use hashcode as suggestion's stable id. This is much
more likely to provide a truely stable id for each suggestion card.
Eventually I want to use hash for all tiles to provide stable id.
- Add a SuggestionDismissionController to handle swipe to dismiss
callbacks
Change-Id: If3770f07a90c5469a0b86fc28f3eb5e4c17227cd
Fix:
35159816
Test: make RunSettingsRoboTests