OSDN Git Service
Bruce Momjian [Tue, 8 Jul 2008 02:07:29 +0000 (02:07 +0000)]
Add comment for deadlock_timeout:
/* This is PGC_SIGHUP so all backends have the same value. */
Tom Lane [Mon, 7 Jul 2008 20:24:55 +0000 (20:24 +0000)]
Fix estimate_num_groups() to assume that GROUP BY expressions yielding boolean
results always contribute two groups, regardless of the expression contents.
This is very substantially more accurate than the regular heuristic for
certain boolean tests like "col IS NULL". Per gripe from Sam Mason.
Back-patch to all supported releases, since the behavior of
estimate_num_groups() hasn't changed all that much since 7.4.
Tom Lane [Mon, 7 Jul 2008 18:09:46 +0000 (18:09 +0000)]
Fix AT TIME ZONE (in all three variants) so that we first try to interpret
the timezone argument as a timezone abbreviation, and only try it as a full
timezone name if that fails. The zic database has four zones (CET, EET, MET,
WET) that are full daylight-savings zones and yet have names that are the
same as their abbreviations for standard time, resulting in ambiguity.
In the timestamp input functions we resolve the ambiguity by preferring the
abbreviation, and AT TIME ZONE should work the same way. (No functionality
is lost because the zic database also has other names for these zones, eg
Europe/Zurich.) Per gripe from Jaromir Talir.
Backpatch to 8.1. Older releases did not have the issue because AT TIME ZONE
only accepted abbreviations not zone names. (Thus, this patch also arguably
fixes a compatibility botch introduced at 8.1: in ambiguous cases we now
behave the same as 8.0 did.)
Peter Eisentraut [Mon, 7 Jul 2008 16:11:35 +0000 (16:11 +0000)]
Added documentation for function xmlagg.
Tom Lane [Sun, 6 Jul 2008 19:48:45 +0000 (19:48 +0000)]
Prevent integer overflows during units conversion when displaying a GUC
variable that has units. Per report from Stefan Kaltenbrunner.
Backport to 8.2. I also backported my patch of 2007-06-21 that prevented
comparable overflows on the input side, since that now seems to have enough
field track record to be back-patched safely. That patch included addition
of hints listing the available unit names, which I did not bother to strip
out of it --- this will make a little more work for the translators, but
they can copy the translation from 8.3, and anyway an untranslated hint
is better than no hint.
Teodor Sigaev [Fri, 4 Jul 2008 13:21:18 +0000 (13:21 +0000)]
Fix initialization of GinScanEntryData.partialMatch
Magnus Hagander [Fri, 4 Jul 2008 10:50:18 +0000 (10:50 +0000)]
Fix a couple of bugs in win32 shmem name generation:
* Don't cut off the prefix. With this fix, it's again readable.
* Properly store it in the Global namespace as intended.
Tom Lane [Thu, 3 Jul 2008 20:58:47 +0000 (20:58 +0000)]
Add a function pg_get_keywords() to let clients find out the set of keywords
known to the SQL parser. Dave Page
Peter Eisentraut [Thu, 3 Jul 2008 16:01:10 +0000 (16:01 +0000)]
Don't refer to the database name "regression" inside the regression test
scripts, to allow running the test successfully with another database name.
Peter Eisentraut [Thu, 3 Jul 2008 15:59:55 +0000 (15:59 +0000)]
Don't print the name of the database in psql \z.
Peter Eisentraut [Thu, 3 Jul 2008 15:36:20 +0000 (15:36 +0000)]
Clean up weird whitespace. Separate patch to simplifiy the next change.
Joe Conway [Thu, 3 Jul 2008 03:56:57 +0000 (03:56 +0000)]
When an ERROR happens on a dblink remote connection, take
pains to pass the ERROR message components locally, including
using the passed SQLSTATE. Also wrap the passed info in an
appropriate CONTEXT message. Addresses complaint by Henry
Combrinck. Joe Conway, with much good advice from Tom Lane.
Tom Lane [Thu, 3 Jul 2008 03:37:17 +0000 (03:37 +0000)]
Fix psql's \d and allied commands to work with all server versions back to 7.4.
Guillaume Lelarge, with some additional fixes by me.
Bruce Momjian [Thu, 3 Jul 2008 02:49:54 +0000 (02:49 +0000)]
Update source code comment about when to use gettext_noop().
Tom Lane [Thu, 3 Jul 2008 00:04:24 +0000 (00:04 +0000)]
Fix transaction-lifespan memory leak in xpath(). Report by Matt Magoffin,
fix by Kris Jurka.
Bruce Momjian [Tue, 1 Jul 2008 21:49:04 +0000 (21:49 +0000)]
Documentation patch by Kevin L. McBride explaining GUC lock variables,
which are available if LOCK_DEBUG is defined.
Tom Lane [Tue, 1 Jul 2008 21:07:33 +0000 (21:07 +0000)]
Remove GUC extra_desc strings that are redundant with the enum value lists.
Bruce Momjian [Tue, 1 Jul 2008 18:26:30 +0000 (18:26 +0000)]
Add URL for:
* Add database and transaction-level triggers
Bruce Momjian [Tue, 1 Jul 2008 18:09:09 +0000 (18:09 +0000)]
Add to TODO:
> * Fix TRUNCATE ... RESTART IDENTITY so its affect on sequences is rolled
> back on transaction abort
Heikki Linnakangas [Tue, 1 Jul 2008 11:46:48 +0000 (11:46 +0000)]
Move volatility, language, etc. modifiers before function body in the pg_dump
output for CREATE FUNCTION. This makes it easier to read especially if the
function body is long.
Original idea and patch by Greg Sabino Mullane, though this is a stripped
down version of that.
Heikki Linnakangas [Tue, 1 Jul 2008 10:33:09 +0000 (10:33 +0000)]
Extend VacAttrStats to allow typanalyze functions to store statistic values
of different types than the underlying column. The capability isn't yet
used for anything, but will be required by upcoming patch to analyze
tsvector columns.
Jan Urbanski
Magnus Hagander [Tue, 1 Jul 2008 06:36:11 +0000 (06:36 +0000)]
"debug" level was supposed to be hidden, since it's just an alias for debug2.
Magnus Hagander [Tue, 1 Jul 2008 06:08:31 +0000 (06:08 +0000)]
Split apart message_level_options into one set for server-side settings and
one for client-side, restoring the previous behaviour with different
sort order for the 'log' level. Also, remove redundant list of available
options, since the enum code will output it automatically.
Tom Lane [Tue, 1 Jul 2008 03:40:55 +0000 (03:40 +0000)]
Fix identify_system_timezone() so that it tests the behavior of the system
timezone setting in the current year and for 100 years back, rather than
always examining years 1904-2004. The original coding would have problems
distinguishing zones whose behavior diverged only after 2004; which is a
situation we will surely face sometime, if it's not out there already.
In passing, also prevent selection of the dummy "Factory" timezone, even
if that's exactly what the system is using. Reporting time as GMT seems
better than that.
Tom Lane [Tue, 1 Jul 2008 02:09:34 +0000 (02:09 +0000)]
Teach autovacuum how to determine whether a temp table belongs to a crashed
backend. If so, send a LOG message to the postmaster log, and if the table
is beyond the vacuum-for-wraparound horizon, forcibly drop it. Per recent
discussions. Perhaps we ought to back-patch this, but it probably needs
to age a bit in HEAD first.
Bruce Momjian [Tue, 1 Jul 2008 00:08:18 +0000 (00:08 +0000)]
Issue psql connection warnings on connection start and via \c, per
observation by David Fetter.
Bruce Momjian [Mon, 30 Jun 2008 22:10:43 +0000 (22:10 +0000)]
Fix recovery.conf boolean variables to take the same range of string
values as postgresql.conf.
Bruce Momjian [Mon, 30 Jun 2008 19:45:15 +0000 (19:45 +0000)]
Add psql TODO:
> o Add "auto" expanded mode that outputs in expanded format if
> "wrapped" mode can't wrap the output to the screen width
>
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00417.php
>
Bruce Momjian [Mon, 30 Jun 2008 19:41:37 +0000 (19:41 +0000)]
Add psql TODO item:
> o Add option to wrap column values at whitespace boundaries,
> rather than chopping them at a fixed width.
> Currently, "wrapped" format chops values into fixed
> widths. Perhaps the word wrapping could use the same
> algorithm documented in the W3C specification.
> http://archives.postgresql.org/pgsql-hackers/2008-05/msg00404.php
> http://www.w3.org/TR/CSS21/tables.html#auto-table-layout
Teodor Sigaev [Mon, 30 Jun 2008 18:30:48 +0000 (18:30 +0000)]
ltree support for multibyte encodings. Patch was made by
laser <laserlist@pgsqldb.com> with some editorization by me.
Heikki Linnakangas [Mon, 30 Jun 2008 10:58:47 +0000 (10:58 +0000)]
Turn PGBE_ACTIVITY_SIZE into a GUC variable, track_activity_query_size.
As the buffer could now be a lot larger than before, and copying it could
thus be a lot more expensive than before, use strcpy instead of memcpy to
copy the query string, as was already suggested in comments. Also, only copy
the PgBackendStatus struct and string if the slot is in use.
Patch by Thomas Lee, with some changes by me.
Tom Lane [Sun, 29 Jun 2008 21:04:01 +0000 (21:04 +0000)]
Remove unnecessary coziness of GIN code with datum copying. Now that
space is tracked via GetMemoryChunkSpace, there's really no advantage
to duplicating datumCopy's innards here. This is one bit of my toast
indirection patch that should go in anyway.
Tom Lane [Sat, 28 Jun 2008 16:45:22 +0000 (16:45 +0000)]
If pnstrdup is going to be promoted to a generally available function,
it ought to conform to the rest of palloc.h in using Size for sizes.
Tom Lane [Fri, 27 Jun 2008 20:54:37 +0000 (20:54 +0000)]
Consider a clause to be outerjoin_delayed if it references the nullable side
of any lower outer join, even if it also references the non-nullable side and
so could not get pushed below the outer join anyway. We need this in case
the clause is an OR clause: if it doesn't get marked outerjoin_delayed,
create_or_index_quals() could pull an indexable restriction for the nullable
side out of it, leading to wrong results as demonstrated by today's bug
report from toruvinn. (See added regression test case for an example.)
In principle this has been wrong for quite a while. In practice I don't
think any branch before 8.3 can really show the failure, because
create_or_index_quals() will only pull out indexable conditions, and before
8.3 those were always strict. So though we might have improperly generated
null-extended rows in the outer join, they'd get discarded from the result
anyway. The gating factor that makes the failure visible is that 8.3
considers "col IS NULL" to be indexable. Hence I'm not going to risk
back-patching further than 8.3.
Magnus Hagander [Fri, 27 Jun 2008 18:58:14 +0000 (18:58 +0000)]
Fix standalone libpq build on win32.
Hiroshi Saito
Tom Lane [Fri, 27 Jun 2008 03:56:55 +0000 (03:56 +0000)]
Improve planner's estimation of the size of an append relation: rather than
taking the maximum of any child rel's width, we should weight the widths
proportionally to the number of rows expected from each child. In hindsight
this is obviously correct because row width is really a proxy for the total
physical size of the relation. Per discussion with Scott Carey (bug #4264).
Bruce Momjian [Fri, 27 Jun 2008 02:44:31 +0000 (02:44 +0000)]
Mention actual function names in documentation of how to pass binary
values to libpq.
Bruce Momjian [Fri, 27 Jun 2008 02:38:29 +0000 (02:38 +0000)]
Add to TODO:
>
> * Fix system views like pg_stat_all_tables to use set-returning
> functions, rather than views of per-column functions
Tom Lane [Fri, 27 Jun 2008 01:52:59 +0000 (01:52 +0000)]
Clarify plpgsql documentation by not treating IF THEN ELSE IF ... as a
truly distinct version of IF. Per suggestion from Marko Kreen.
Tom Lane [Fri, 27 Jun 2008 00:36:16 +0000 (00:36 +0000)]
Modify the recently-added probe for -Wl,--as-needed some more, because RHEL-4
vintage Linux is even more broken than we realized: a link to libreadline
will succeed, and fail only at runtime. It seems that an AC_TRY_RUN test
is the only reliable way to check whether this is really safe. Per report
from Tatsuo.
Bruce Momjian [Thu, 26 Jun 2008 22:24:42 +0000 (22:24 +0000)]
Use SGML table to show backslash string escapes, rather than have them
appear in a paragraph.
Andy Anderson
Bruce Momjian [Thu, 26 Jun 2008 19:18:37 +0000 (19:18 +0000)]
Add MERGE TODO URL:
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01890.php
Bruce Momjian [Thu, 26 Jun 2008 18:25:24 +0000 (18:25 +0000)]
Fix pg_ctl bug where detection of binary location from postopts
wasn't working.
Teodor Sigaev [Thu, 26 Jun 2008 16:06:37 +0000 (16:06 +0000)]
Fix bug "select lower('asd') = 'asd'" returns false with multibyte encoding
and non-C locale. Fix is just to use correct source's length for char2wchar
call.
Michael Meskes [Thu, 26 Jun 2008 08:04:05 +0000 (08:04 +0000)]
Synced parser
Bruce Momjian [Thu, 26 Jun 2008 03:58:00 +0000 (03:58 +0000)]
Add TODO about security:
* Improve server security options
http://archives.postgresql.org/pgsql-hackers/2008-04/msg01875.php
http://archives.postgresql.org/pgsql-hackers/2008-05/msg00000.php
Bruce Momjian [Thu, 26 Jun 2008 03:54:28 +0000 (03:54 +0000)]
More FAQ URL updates from Curtis Gallant.
Bruce Momjian [Thu, 26 Jun 2008 03:51:56 +0000 (03:51 +0000)]
Simplify 'pg_ctl restart' detection of first argument in
postmaster.opts.
Bruce Momjian [Thu, 26 Jun 2008 03:02:27 +0000 (03:02 +0000)]
Update FAQ URLs as suggested by Curtis Gallant.
Bruce Momjian [Thu, 26 Jun 2008 02:53:19 +0000 (02:53 +0000)]
Add to TODO:
>
> * Improve LDAP authentication configuration options
>
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01745.php
Bruce Momjian [Thu, 26 Jun 2008 02:47:19 +0000 (02:47 +0000)]
Fix 'pg_ctl restart' to preserve command-line arguments.
Bruce Momjian [Thu, 26 Jun 2008 01:35:45 +0000 (01:35 +0000)]
Use SYSTEMQUOTE as concatentation to strings, rather than %s printf
patterns, for clarity.
Bruce Momjian [Thu, 26 Jun 2008 01:12:20 +0000 (01:12 +0000)]
Remove use of postmaster.opts.default by pg_ctl.
Tom Lane [Tue, 24 Jun 2008 17:58:27 +0000 (17:58 +0000)]
Reduce the alignment requirement of type "name" from int to char, and arrange
to suppress zero-padding of "name" entries in indexes.
The alignment change is unlikely to save any space, but it is really needed
anyway to make the world safe for our widespread practice of passing plain
old C strings to functions that are declared as taking Name. In the previous
coding, the C compiler was entitled to assume that a Name pointer was
word-aligned; but we were failing to guarantee that. I think the reason
we'd not seen failures is that usually the only thing that gets done with
such a pointer is strcmp(), which is hard to optimize in a way that exploits
word-alignment. Still, some enterprising compiler guy will probably think
of a way eventually, or we might change our code in a way that exposes
more-obvious optimization opportunities.
The padding change is accomplished in one-liner fashion by declaring the
"name" index opclasses to use storage type "cstring" in pg_opclass.h.
Normally btree and hash don't allow a nondefault storage type, because they
don't have any provisions for converting the input datum to another type.
However, because name and cstring are effectively the same thing except for
padding, no conversion is needed --- we only need index_form_tuple() to treat
the datum as being cstring not name, and this is sufficient. This seems to
make for about a one-third reduction in the typical sizes of system catalog
indexes that involve "name" columns, of which we have many.
These two changes are only weakly related, but the alignment change makes
me feel safer that the padding change won't introduce problems, so I'm
committing them together.
Bruce Momjian [Tue, 24 Jun 2008 15:53:24 +0000 (15:53 +0000)]
TODO item done:
< o Prevent pg_dump/pg_restore from being affected by
> o -Prevent pg_dump/pg_restore from being affected by
Tom Lane [Tue, 24 Jun 2008 01:15:36 +0000 (01:15 +0000)]
Oops, make the MSVC build put fmgroids.h where it needs to be.
Per buildfarm results.
Bruce Momjian [Mon, 23 Jun 2008 22:42:32 +0000 (22:42 +0000)]
Add TODO:
>
> o Allow COPY to report errors sooner
>
> http://archives.postgresql.org/pgsql-hackers/2008-04/msg01169.php
Bruce Momjian [Mon, 23 Jun 2008 22:23:54 +0000 (22:23 +0000)]
Add URL for Merge.
Bruce Momjian [Mon, 23 Jun 2008 22:15:17 +0000 (22:15 +0000)]
Backup wording improvement.
Joshua D. Drake
Bruce Momjian [Mon, 23 Jun 2008 22:12:20 +0000 (22:12 +0000)]
Add to TODO:
> * Allow custom variables to appear in pg_settings()
Bruce Momjian [Mon, 23 Jun 2008 21:35:35 +0000 (21:35 +0000)]
Add item:
* Implement a module capability for loading /contrib-style extensions
http://archives.postgresql.org/pgsql-patches/2008-04/msg00164.php
Bruce Momjian [Mon, 23 Jun 2008 21:10:49 +0000 (21:10 +0000)]
Add libpq comment about how to determine the format used for passing
binary values.
Add comments to libpq C function for parameter passing.
Bruce Momjian [Mon, 23 Jun 2008 20:20:54 +0000 (20:20 +0000)]
Add TODO:
* Consider whether duplicate keys should be sorted by block/offset
http://archives.postgresql.org/pgsql-hackers/2008-03/msg00558.php
Create new "Sorting" TODO section.
Bruce Momjian [Mon, 23 Jun 2008 19:27:19 +0000 (19:27 +0000)]
Merge duplicate upper/lower/initcap() routines in oracle_compat.c and
formatting.c to use common code; remove duplicate functions and support
routines that are no longer needed.
Tom Lane [Mon, 23 Jun 2008 17:54:30 +0000 (17:54 +0000)]
Fix Gen_fmgrtab.sh to not rely on hard-wired knowledge of the column numbers
in pg_proc. Also make it not emit duplicate extern declarations, and make it
a bit more bulletproof in some other small ways. Likewise fix the equally
hard-wired, and utterly undocumented, knowledge in the MSVC build scripts.
For testing purposes and perhaps other uses in future, pull out that portion
of the MSVC scripts into a standalone perl script equivalent to
Gen_fmgrtab.sh, and make it generate actually identical output, rather than
just more-or-less-the-same output.
Motivated by looking at Pavel's variadic function patch. Whether or not
that gets accepted, we can be sure that pg_proc's column set will change
again in the future; it's time to not have to deal with this gotcha.
Tom Lane [Fri, 20 Jun 2008 00:24:53 +0000 (00:24 +0000)]
Seems I was too optimistic in supposing that sinval's maxMsgNum could be
read and written without a lock. The value itself is atomic, sure, but on
processors with weak memory ordering it's possible for a reader to see the
value change before it sees the associated message written into the buffer
array. Fix by introducing a spinlock that's used just to read and write
maxMsgNum. (We could do this with less overhead if we recognized a concept
of "memory access barrier"; is it worth introducing such a thing? At the
moment probably not --- I can't measure any clear slowdown from adding the
spinlock, so this solution is probably fine.) Per buildfarm results.
Tom Lane [Thu, 19 Jun 2008 21:32:56 +0000 (21:32 +0000)]
Rewrite the sinval messaging mechanism to reduce contention and avoid
unnecessary cache resets. The major changes are:
* When the queue overflows, we only issue a cache reset to the specific
backend or backends that still haven't read the oldest message, rather
than resetting everyone as in the original coding.
* When we observe backend(s) falling well behind, we signal SIGUSR1
to only one backend, the one that is furthest behind and doesn't already
have a signal outstanding for it. When it finishes catching up, it will
in turn signal SIGUSR1 to the next-furthest-back guy, if there is one that
is far enough behind to justify a signal. The PMSIGNAL_WAKEN_CHILDREN
mechanism is removed.
* We don't attempt to clean out dead messages after every message-receipt
operation; rather, we do it on the insertion side, and only when the queue
fullness passes certain thresholds.
* Split SInvalLock into SInvalReadLock and SInvalWriteLock so that readers
don't block writers nor vice versa (except during the infrequent queue
cleanout operations).
* Transfer multiple sinval messages for each acquisition of a read or
write lock.
Tom Lane [Thu, 19 Jun 2008 16:52:24 +0000 (16:52 +0000)]
Fix a few places that were non-multibyte-safe in tsearch configuration file
parsing. Per bug #4253 from Giorgio Valoti.
Bruce Momjian [Thu, 19 Jun 2008 01:15:48 +0000 (01:15 +0000)]
Add URL for:
o Allow pg_hba.conf to specify host names along with IP addresses
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00569.php
Alvaro Herrera [Thu, 19 Jun 2008 00:46:06 +0000 (00:46 +0000)]
Improve our #include situation by moving pointer types away from the
corresponding struct definitions. This allows other headers to avoid including
certain highly-loaded headers such as rel.h and relscan.h, instead using just
relcache.h, heapam.h or genam.h, which are more lightweight and thus cause less
unnecessary dependencies.
Tom Lane [Wed, 18 Jun 2008 23:08:47 +0000 (23:08 +0000)]
Fix compiler warning introduced by recent patch. Tsk tsk.
Tom Lane [Wed, 18 Jun 2008 20:55:42 +0000 (20:55 +0000)]
Improve error reporting for problems in text search configuration files
by installing an error context subroutine that will provide the file name
and line number for all errors detected while reading a config file.
Some of the reader routines were already doing that in an ad-hoc way for
errors detected directly in the reader, but it didn't help for problems
detected in subroutines, such as encoding violations.
Back-patch to 8.3 because 8.3 is where people will be trying to debug
configuration files.
Bruce Momjian [Wed, 18 Jun 2008 18:42:54 +0000 (18:42 +0000)]
Move wchar2char() and char2wchar() from tsearch into /mb to be easier to
use for other modules; also move pnstrdup().
Clean up code slightly.
Neil Conway [Wed, 18 Jun 2008 17:44:12 +0000 (17:44 +0000)]
Fix a few typos in the DTrace docs. Patch from Euler Taveira de Oliveira,
along with an additional typo I noticed along the way.
Tom Lane [Tue, 17 Jun 2008 20:07:08 +0000 (20:07 +0000)]
Remove freeBackends counter from the sinval shared memory area. We used to
use it to help enforce superuser_reserved_backends, but since 8.1 it's
just been dead weight.
Tom Lane [Tue, 17 Jun 2008 19:10:56 +0000 (19:10 +0000)]
Clean up some problems with redundant cross-type arithmetic operators. Add
int2-and-int8 implementations of the basic arithmetic operators +, -, *, /.
This doesn't really add any new functionality, but it avoids "operator is not
unique" failures that formerly occurred in these cases because the parser
couldn't decide whether to promote the int2 to int4 or int8. We could
alternatively have removed the existing cross-type operators, but
experimentation shows that the cost of an additional type coercion expression
node is noticeable compared to such cheap operators; so let's not give up any
performance here. On the other hand, I removed the int2-and-int4 modulo (%)
operators since they didn't seem as important from a performance standpoint.
Per a complaint last January from ykhuang.
Bruce Momjian [Tue, 17 Jun 2008 18:22:43 +0000 (18:22 +0000)]
Add URL for introduction to multibyte programming in C.
Bruce Momjian [Tue, 17 Jun 2008 16:09:06 +0000 (16:09 +0000)]
Move USE_WIDE_UPPER_LOWER define to c.h, and remove TS_USE_WIDE and use
USE_WIDE_UPPER_LOWER instead.
Tom Lane [Tue, 17 Jun 2008 14:51:32 +0000 (14:51 +0000)]
Fix the code that adds regclass constants to a plan's list of relation OIDs
that it depends on for replan-forcing purposes. We need to consider plain OID
constants too, because eval_const_expressions folds a RelabelType atop a Const
to just a Const. This change could result in OID values that aren't really
for tables getting added to the dependency list, but the worst-case
consequence would be occasional useless replans. Per report from Gabriele
Messineo.
Tom Lane [Tue, 17 Jun 2008 00:52:43 +0000 (00:52 +0000)]
Clean up a number of bogosities around pltcl's handling of the Tcl "result":
1. Directly reading interp->result is deprecated in Tcl 8.0 and later;
you're supposed to use Tcl_GetStringResult. This code finally broke with
Tcl 8.5, because Tcl_GetVar can now have side-effects on interp->result even
though it preserves the logical state of the result. (There's arguably a
Tcl issue here, because Tcl_GetVar could invalidate the pointer result of a
just-preceding Tcl_GetStringResult, but I doubt the Tcl guys will see it as
a bug.)
2. We were being sloppy about the encoding of the result: some places would
push database-encoding data into the Tcl result, which should not happen,
and we were assuming that any error result coming back from Tcl was in the
database encoding, which is not a good assumption.
3. There were a lot of calls of Tcl_SetResult that uselessly specified
TCL_VOLATILE for constant strings. This is only a minor performance issue,
but I fixed it in passing since I had to look at all the calls anyway.
#2 is a live bug regardless of which Tcl version you are interested in,
so back-patch even to branches that are unlikely to be used with Tcl 8.5.
I went back as far as 8.0, which is as far as the patch applied easily;
7.4 was using a different error processing scheme that has got its own
problems :-(
Tom Lane [Mon, 16 Jun 2008 03:13:14 +0000 (03:13 +0000)]
Rewrite docs section about routine vacuuming --- it's gotten rather mangled of
late, with lots of redundancy, bad grammar, and just plain poor exposition.
Make it clear that autovacuum is now considered the normal solution.
Andrew Dunstan [Sun, 15 Jun 2008 21:58:55 +0000 (21:58 +0000)]
Prevent CVS from mangling script
Andrew Dunstan [Sun, 15 Jun 2008 21:46:02 +0000 (21:46 +0000)]
Add script to find .c and .h files that are missing CVS PostgreSQL markers
and add them. Avoids third party files or those that would cause regression
failures.
Tom Lane [Sun, 15 Jun 2008 16:29:05 +0000 (16:29 +0000)]
Make DROP INDEX lock the parent table before locking the index. This behavior
is necessary to avoid deadlock against ordinary queries, but we'd broken it
with recent changes that made the DROP machinery lock the index before
arriving at index_drop. Per intermittent buildfarm failures.
Tom Lane [Sun, 15 Jun 2008 01:41:37 +0000 (01:41 +0000)]
Fix 64-bit problem in recent patch.
Tom Lane [Sun, 15 Jun 2008 01:25:54 +0000 (01:25 +0000)]
Rearrange ALTER TABLE syntax processing as per my recent proposal: the
grammar allows ALTER TABLE/INDEX/SEQUENCE/VIEW interchangeably for all
subforms of those commands, and then we sort out what's really legal
at execution time. This allows the ALTER SEQUENCE/VIEW reference pages
to fully document all the ALTER forms available for sequences and views
respectively, and eliminates a longstanding cause of confusion for users.
The net effect is that the following forms are allowed that weren't before:
ALTER SEQUENCE OWNER TO
ALTER VIEW ALTER COLUMN SET/DROP DEFAULT
ALTER VIEW OWNER TO
ALTER VIEW SET SCHEMA
(There's no actual functionality gain here, but formerly you had to say
ALTER TABLE instead.)
Interestingly, the grammar tables actually get smaller, probably because
there are fewer special cases to keep track of.
I did not disallow using ALTER TABLE for these operations. Perhaps we
should, but there's a backwards-compatibility issue if we do; in fact
it would break existing pg_dump scripts. I did however tighten up
ALTER SEQUENCE and ALTER VIEW to reject non-sequences and non-views
in the new cases as well as a couple of cases where they didn't before.
The patch doesn't change pg_dump to use the new syntaxes, either.
Alvaro Herrera [Sat, 14 Jun 2008 21:59:59 +0000 (21:59 +0000)]
In log_filename documentation, mention that strftime is not used directly to
expand the pattern specifier.
Per gripe from Josh Drake.
Tom Lane [Sat, 14 Jun 2008 18:04:34 +0000 (18:04 +0000)]
Refactor the handling of the various DropStmt variants so that when multiple
objects are specified, we drop them all in a single performMultipleDeletions
call. This makes the RESTRICT/CASCADE checks more relaxed: it's not counted
as a cascade if one of the later objects has a dependency on an earlier one.
NOTICE messages about such cases go away, too.
In passing, fix the permissions check for DROP CONVERSION, which for some
reason was never made role-aware, and omitted the namespace-owner exemption
too.
Alex Hunsaker, with further fiddling by me.
Bruce Momjian [Fri, 13 Jun 2008 16:24:38 +0000 (16:24 +0000)]
Modify TODO entry to be a function:
> o Add functions to syntax check configuration files
>
< * Add pg_ctl option to do a syntax check of postgresql.conf
Tom Lane [Fri, 13 Jun 2008 02:59:47 +0000 (02:59 +0000)]
Improve the various elog messages in tuptoaster.c to report which TOAST table
the problem happened in. These are all supposedly can't-happen cases, but
when they do happen it's useful to know where.
Back-patch to 8.3, but not further because the patch doesn't apply cleanly
further back. Given the lack of response to my proposal of this, there
doesn't seem to be enough interest to justify much back-porting effort.
Bruce Momjian [Thu, 12 Jun 2008 19:15:40 +0000 (19:15 +0000)]
Use macro to document size of ecpg sqlerrmc string.
Bruce Momjian [Thu, 12 Jun 2008 18:09:04 +0000 (18:09 +0000)]
Update item to mention target list problem:
< * Allow INSERT/UPDATE ... RETURNING inside a SELECT 'FROM' clause
> * Allow INSERT/UPDATE ... RETURNING inside a SELECT 'FROM' clause or
> target list
> http://archives.postgresql.org/pgsql-hackers/2008-06/msg00124.php
Heikki Linnakangas [Thu, 12 Jun 2008 09:12:31 +0000 (09:12 +0000)]
Refactor XLogOpenRelation() and XLogReadBuffer() in preparation for relation
forks. XLogOpenRelation() and the associated light-weight relation cache in
xlogutils.c is gone, and XLogReadBuffer() now takes a RelFileNode as argument,
instead of Relation.
For functions that still need a Relation struct during WAL replay, there's a
new function called CreateFakeRelcacheEntry() that returns a fake entry like
XLogOpenRelation() used to.
Tom Lane [Wed, 11 Jun 2008 21:53:49 +0000 (21:53 +0000)]
Improve reporting of dependencies in DROP to work like the scheme that we
devised for pg_shdepend, namely the individual dependencies are reported as
DETAIL lines rather than coming out as separate NOTICEs. The client-side
report is capped at 100 lines, but the server log always gets a full report.
Bruce Momjian [Wed, 11 Jun 2008 20:54:31 +0000 (20:54 +0000)]
Add:
> * Add pg_ctl option to do a syntax check of postgresql.conf
Bruce Momjian [Wed, 11 Jun 2008 15:44:52 +0000 (15:44 +0000)]
Fix spelling mistake in postgresql.conf.
Greg Sabino Mullane
Heikki Linnakangas [Wed, 11 Jun 2008 10:55:43 +0000 (10:55 +0000)]
Update "help" output to reflect that \timing now takes an optional on/off
argument.
Heikki Linnakangas [Wed, 11 Jun 2008 10:48:17 +0000 (10:48 +0000)]
Add optional on/off argument to \timing.
David Fetter.
Heikki Linnakangas [Wed, 11 Jun 2008 08:38:56 +0000 (08:38 +0000)]
Fix bug in the WAL recovery code to finish an incomplete split.
CacheInvalidateRelcache() crashes if called in WAL recovery, because the
invalidation infrastructure hasn't been initialized yet.
Back-patch to 8.2, where the bug was introduced.
Neil Conway [Tue, 10 Jun 2008 20:58:19 +0000 (20:58 +0000)]
Editorialization for the text emitted by the "help" psql command.
Basically just reuse the same text that psql emitted as part of
its startup banner in prior versions, and make some whitespace
more consistent with the conventions in other psql command output.