OSDN Git Service
Antony Sargent [Fri, 22 Mar 2019 16:41:20 +0000 (09:41 -0700)]
Switch some strings to 'Downloaded SIM' instead of 'eSIM'
We also added a '/' divider to distinguish the two bits of state that
these strings convey - active vs inactive, and SIM vs eSIM (aka
downloaded sim).
Fixes:
127821561
Test: m Settings
Change-Id: Ibaa611bb5585dd9797e4db2fb4d684274be26791
Kevin Chyn [Wed, 20 Mar 2019 07:01:52 +0000 (07:01 +0000)]
Merge "Show confirmation dialog for removing enrollment"
TreeHugger Robot [Wed, 20 Mar 2019 06:51:25 +0000 (06:51 +0000)]
Merge "Update About phone icon background color"
TreeHugger Robot [Wed, 20 Mar 2019 06:28:33 +0000 (06:28 +0000)]
Merge "Update enrollment intro"
Yanting Yang [Wed, 20 Mar 2019 04:32:50 +0000 (12:32 +0800)]
Update About phone icon background color
Fixes:
120810263
Test: visual
Change-Id: I8b91a0ef7ba66ff0f4fbd84c765119266119a4a6
Cosmo Hsieh [Wed, 20 Mar 2019 04:34:25 +0000 (04:34 +0000)]
Merge "[Network Connection] Implement new UI changing"
Kevin Chyn [Wed, 20 Mar 2019 03:37:57 +0000 (20:37 -0700)]
Show confirmation dialog for removing enrollment
Fixes:
123605413
Test: builds
Change-Id: I9e918977909bcf461a29eb36f157c3a261c6dcc4
TreeHugger Robot [Wed, 20 Mar 2019 04:20:21 +0000 (04:20 +0000)]
Merge "Fix sticky battery saver toggle"
TreeHugger Robot [Wed, 20 Mar 2019 04:09:31 +0000 (04:09 +0000)]
Merge "Store the application context statically in FeatureFactory"
TreeHugger Robot [Wed, 20 Mar 2019 04:07:02 +0000 (04:07 +0000)]
Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment"
Kevin Chyn [Tue, 19 Mar 2019 00:38:12 +0000 (17:38 -0700)]
Update enrollment intro
1) Toggles resources between normal and accessibility enrollment
2) Add footer for more detail text
Fixes:
127514618
Bug:
111548033
Test: Builds
Change-Id: Ib0c47f04abc5ce9abbd8b27ef5782d1874379f16
Arc Wang [Tue, 19 Mar 2019 02:01:38 +0000 (10:01 +0800)]
Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.
Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.
Bug:
124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
Arc Wang [Wed, 20 Mar 2019 01:53:24 +0000 (01:53 +0000)]
Merge "Fix Wi-Fi Easy Connect buttons UI defects"
Fan Zhang [Tue, 19 Mar 2019 23:52:17 +0000 (23:52 +0000)]
Merge "Make a public activity for zen access details."
Fan Zhang [Tue, 19 Mar 2019 20:08:10 +0000 (13:08 -0700)]
Make a public activity for zen access details.
Bug:
128547723
Test: manual
Change-Id: I0546cbb37c2be50bff44396fa2874d9eb294813c
Fan Zhang [Tue, 19 Mar 2019 22:45:11 +0000 (15:45 -0700)]
Store the application context statically in FeatureFactory
It stores the application context in a static class, and will be
destoryed when application stops.
Bug:
124701288
Test: robo
Change-Id: I4678072f3f38ae682be6ba075c85e63c49f8febe
TreeHugger Robot [Tue, 19 Mar 2019 22:49:04 +0000 (22:49 +0000)]
Merge "Sound + Output Switcher on Volume Slice"
TreeHugger Robot [Tue, 19 Mar 2019 22:36:30 +0000 (22:36 +0000)]
Merge "Enlarge the height of collapsing button"
Salvador Martinez [Tue, 19 Mar 2019 22:20:51 +0000 (15:20 -0700)]
Fix sticky battery saver toggle
It was persisting to settings secure instead of settings global.
Test: robotests pass
Bug:
128929858
Change-Id: I8c5bcc875d71096e70f1a70ec84e85d46c3abe43
Yohei Yukawa [Tue, 19 Mar 2019 21:15:37 +0000 (14:15 -0700)]
Finalize text of per-profile IME settings
This is a follow up CL to a recent CL [1], which updated text in the
Settings app as follows:
* "Keyboard & inputs" to "Keyboards"
* "Input assistance" to "Tools"
For consystency, this CL updates the header text for the work-profile
specific enties in Languages & input from
Work profile input & assistance
to
Work profile keyboards & tools.
Other than that, there is no user-visible behavior change.
[1]: Idbf1e3a8b0c7116271e424548ef37340199eaea2
5b27d18e38f7d684f16aef84b1dfc5d4808cdc07
Bug:
124049901
Fix:
123314089
Test: Manually verified as follows.
1. Build and flash an AOSP build
2. Install Test DPC
3. Open Settings -> System -> Languages & input
4. Make sure that the new category header for work-profile specific
entries is now shown as "Work profile keyboards & tools"
Change-Id: Ib6470debe9be29ec0985cf1e3eb31d232c6b3880
Mill Chen [Tue, 19 Mar 2019 20:47:56 +0000 (20:47 +0000)]
Merge "Add Grayscale conditional"
Mill Chen [Tue, 19 Mar 2019 20:17:09 +0000 (13:17 -0700)]
Enlarge the height of collapsing button
To improve the accessibility of Settings, we make the height of
collapsing button set to 48dp.
Fixes:
128896511
Test: rebuild
Change-Id: I341196802d6d488a8adb88501901e761bc188f7b
TreeHugger Robot [Tue, 19 Mar 2019 18:20:38 +0000 (18:20 +0000)]
Merge "Remove wake from Settings gestures.xml"
Lei Yu [Tue, 19 Mar 2019 17:46:17 +0000 (17:46 +0000)]
Merge "Add circle background outline to unthethered icon"
Clown SHEN [Tue, 19 Mar 2019 17:37:26 +0000 (17:37 +0000)]
Merge "Display more information on network detail page"
Fan Zhang [Tue, 19 Mar 2019 17:18:42 +0000 (17:18 +0000)]
Merge "Stop using framework internal layout for timezone header."
Fan Zhang [Mon, 18 Mar 2019 23:37:28 +0000 (16:37 -0700)]
Stop using framework internal layout for timezone header.
The framework version header has deviated from supportlib version long
ago, and we shouldn't hack our theme to make this layout work. Instead
we now have a custom layout compatible to settings theme.
Fixes:
128833223
Test: visual
Change-Id: I83087352240de183b0639daf844bd7f90e02056a
Fan Zhang [Tue, 19 Mar 2019 17:14:56 +0000 (17:14 +0000)]
Merge "Update strings of notification channel slice"
Fan Zhang [Tue, 19 Mar 2019 17:14:07 +0000 (17:14 +0000)]
Merge "Create a page to manage dnd permission for individual app"
Beverly [Tue, 19 Mar 2019 14:56:07 +0000 (10:56 -0400)]
Remove wake from Settings gestures.xml
Test: manual
Bug:
127955764
Change-Id: Icea129fe5a7b1dbb0bc5ff799c99907a278396df
TreeHugger Robot [Tue, 19 Mar 2019 13:25:25 +0000 (13:25 +0000)]
Merge "Log latency and timeout occurrence for contextual cards."
Yanting Yang [Tue, 19 Mar 2019 11:54:04 +0000 (19:54 +0800)]
Update strings of notification channel slice
Bug:
128641319
Test: manual
Change-Id: Ia5f5ee770a28c0720526e60ffdb48fb2bd3de13f
TreeHugger Robot [Tue, 19 Mar 2019 11:48:40 +0000 (11:48 +0000)]
Merge "Update OWNERS for backup settings"
Yi-Ling Chuang [Wed, 6 Mar 2019 06:38:23 +0000 (14:38 +0800)]
Log latency and timeout occurrence for contextual cards.
Fixes:
124492762
Test: rebuild
Change-Id: I552adf7e6d76e8576a790e83792d067ed5716dc2
Arc Wang [Fri, 15 Mar 2019 08:58:11 +0000 (16:58 +0800)]
Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
ButtonPreference's naming and design look like a general purpose UI
component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
'preference_access_point' to fix UI alignment problems.
Bug:
126964552
Bug:
125434239
Bug:
126762937
Test: manual test
atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
TreeHugger Robot [Tue, 19 Mar 2019 04:06:20 +0000 (04:06 +0000)]
Merge "Import statsdprotolite library to use atoms.proto"
cosmohsieh [Thu, 14 Mar 2019 10:29:55 +0000 (18:29 +0800)]
[Network Connection] Implement new UI changing
1. Change title to multi-lines display
2. Add "SingleSpecifiedSSID" mode, will have connect button
3. Don't pop error dialog, if there is connection failure. Let user
retry.
4. Hide progress icon if list item exists
Bug:
128586511
Test: atest NetworkRequestDialogFragmentTest
Change-Id: Icc560e4882fbcd941574e44690a27d5082a7c4c7
TreeHugger Robot [Tue, 19 Mar 2019 00:17:38 +0000 (00:17 +0000)]
Merge "Enable nav bar overlay when gestural nav is enabled and tune edge swipe width."
Raff Tsai [Mon, 18 Mar 2019 23:19:20 +0000 (07:19 +0800)]
Import statsdprotolite library to use atoms.proto
Bug:
124701288
Test: rebuild
Change-Id: I38ba80707f8b6cbf7d590d72f4f7fb937dc82a89
Hai Shalom [Mon, 18 Mar 2019 22:38:47 +0000 (22:38 +0000)]
Merge "[Wi-Fi] Do not delete certs when forgetting network"
Tracy Zhou [Mon, 18 Mar 2019 22:07:09 +0000 (15:07 -0700)]
Enable nav bar overlay when gestural nav is enabled and tune edge swipe
width.
Fixes:
128680874,
128711028
Test: Manual
Change-Id: I371819c6f6206f2bbc8599c0b14b4da9b67a2e14
Fan Zhang [Mon, 18 Mar 2019 21:55:24 +0000 (21:55 +0000)]
Merge "Disable draw overlay for most of Settings."
Fan Zhang [Thu, 14 Mar 2019 22:45:22 +0000 (15:45 -0700)]
Disable draw overlay for most of Settings.
Fixes:
120484087
Test: robotests
Change-Id: I1f7c8e83bd5054525bde5ca35fac55b7c9586c7c
Fan Zhang [Fri, 15 Mar 2019 23:41:24 +0000 (16:41 -0700)]
Create a page to manage dnd permission for individual app
- Change the original ZenAccessPage to
- Remove the inline switch
- Make the preference click target go into the new detail page
- Some formatting/style change.
- Create a new detail page for zen access.
- Exit if app didn't declare this permission
- Preset the switch toggle to their current permission grant state
- Move the warning dialog logic from ZenAccessSettings to here.
- Move some common functionality into ZenAccessController, a static
helper class
Bug:
128547723
Test: robotest
Change-Id: I1ebb32396869d07ff4283b300bd716506298c9b5
Brad Ebinger [Mon, 18 Mar 2019 21:01:17 +0000 (14:01 -0700)]
[automerger skipped] Merge "Do not show Provisioning items for IMS if it is not enabled." am:
be10b45fe6 am:
76b4661f56
am:
6ed6eeb05f -s ours
am skip reason: change_id I9624535fe766cd79eadb30502c1a0574650a02ef with SHA1
5dfe7f8af9 is in history
Change-Id: Ie9996ba6c93a195053c430aeb4bad88bd314b1f2
Brad Ebinger [Mon, 18 Mar 2019 20:42:49 +0000 (13:42 -0700)]
Merge "Do not show Provisioning items for IMS if it is not enabled." am:
be10b45fe6
am:
76b4661f56
Change-Id: I04d7e91cce1424608581ca36f6282e71c9d3ac7e
Brad Ebinger [Mon, 18 Mar 2019 20:29:25 +0000 (13:29 -0700)]
Merge "Do not show Provisioning items for IMS if it is not enabled."
am:
be10b45fe6
Change-Id: Ie8c404d980d7437550019fccdcac0868fa5d845d
TreeHugger Robot [Mon, 18 Mar 2019 19:59:27 +0000 (19:59 +0000)]
Merge "Fix voice access issue on home page"
TreeHugger Robot [Mon, 18 Mar 2019 19:44:47 +0000 (19:44 +0000)]
Merge "Force LSKF in ConfirmCredential UI when pending escrow token exists"
Fan Zhang [Mon, 18 Mar 2019 18:36:49 +0000 (18:36 +0000)]
Merge "Fix crash on AppInfo screen"
Hunter Knepshield [Mon, 18 Mar 2019 18:17:20 +0000 (18:17 +0000)]
Merge "[Strings + layout] Minor changes for eSIM erase."
TreeHugger Robot [Mon, 18 Mar 2019 18:13:27 +0000 (18:13 +0000)]
Merge "Handle the SQLiteDatabase already-closed problem"
TreeHugger Robot [Mon, 18 Mar 2019 18:01:08 +0000 (18:01 +0000)]
Merge "Add null check for worker"
Brad Ebinger [Mon, 18 Mar 2019 17:35:27 +0000 (17:35 +0000)]
Merge "Do not show Provisioning items for IMS if it is not enabled."
Jack Yu [Mon, 18 Mar 2019 17:28:08 +0000 (17:28 +0000)]
Merge "Renamed NetworkRegistrationState to NetworkRegistrationInfo"
Rubin Xu [Mon, 18 Mar 2019 14:58:53 +0000 (14:58 +0000)]
Force LSKF in ConfirmCredential UI when pending escrow token exists
Escrow tokens can only be activated by user confirming their LSKF,
while ConfirmCredential allows both LSKF and biometrics by default.
By requiring LSKF, it simplifies the DPC's flow of requesting the user
to activate a pending escrow token.
This change tweaks the ConfirmCredential UI to skip biometrics if pending
token exists.
Bug:
127377026
Bug:
76084679
Bug:
79547502
Test: manual
Change-Id: Iee9b2d57d7f4de98e225b3aeff7cc35cc8e3d36a
TreeHugger Robot [Mon, 18 Mar 2019 17:20:01 +0000 (17:20 +0000)]
Merge "Move WakeGestureScreenGestureSettings"
Annie Meng [Mon, 18 Mar 2019 17:18:39 +0000 (17:18 +0000)]
Update OWNERS for backup settings
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: Ib98d9c9ef2b538b7d620e1361d0e48d263635449
Yanting Yang [Mon, 18 Mar 2019 12:58:53 +0000 (20:58 +0800)]
Fix voice access issue on home page
Bug:
128825246
Test: manual
Change-Id: Icd9b31c195f44b11b97a30292de586483ea2e651
TreeHugger Robot [Mon, 18 Mar 2019 12:06:30 +0000 (12:06 +0000)]
Merge "Move a few classes around for easier ownership control"
Sunny Shao [Mon, 18 Mar 2019 11:42:09 +0000 (19:42 +0800)]
Handle the SQLiteDatabase already-closed problem
Remove the database.close in code for handling the re-open an already-closed object:SQLiteDatabase
problem.
Bug:
124451874
Test: robotest
Change-Id: Iff8c0bc5ea092d42cff0a40dfa4324a4de7c90bc
hughchen [Thu, 14 Mar 2019 03:29:32 +0000 (11:29 +0800)]
Add null check for worker
Add null check to avoid crash when worker cannot get through uri.
Bug:
128492874
Test: make -j42 RunSettingsRoboTests
Change-Id: I789ce0bfa98c0b0b145a8605c58c88a77eeb76a9
Jason Chiu [Mon, 18 Mar 2019 10:13:56 +0000 (10:13 +0000)]
Merge "Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice"
Hyundo Moon [Mon, 18 Mar 2019 10:03:07 +0000 (10:03 +0000)]
Merge "Remove ControllerLink"
Jason Chiu [Thu, 7 Mar 2019 09:42:39 +0000 (17:42 +0800)]
Fix the bug of "Connecting" is rarely appearing on Wi-Fi slice
- AccessPoint treats connected and connecting as equal so slice doesn't
refresh in this case
- Add a new method to determine if two lists are the same in SliceBackgroundWorker
- WifiScanWorker overrides this method to check the access point states
Fixes:
123941320
Test: robotest
Change-Id: I78d610da4b6b1d40f5785ba6701fb71b987fe31c
TreeHugger Robot [Mon, 18 Mar 2019 06:24:26 +0000 (06:24 +0000)]
Merge "Update the expand more icon in the condition"
tmfang [Sat, 9 Mar 2019 05:53:02 +0000 (13:53 +0800)]
Fix crash on AppInfo screen
We start a search page with a request code which is same as
"uninstall" request code. The root cause is we handle same
reuqest code for different event.
We redefine an unique request code for "search" feature.
Fixes:
124775813
Test: Click search and back to App info screen.
Change-Id: I8ab21c30b605bcb65b6d4bd9fceb749a65a49f80
Sunny Shao [Mon, 18 Mar 2019 03:52:35 +0000 (11:52 +0800)]
Update the expand more icon in the condition
- Rollback the color from accent to gray.
- Use the "ic_expand_more_inverse.xml" to replace the "expand more" icon.
Fixes:
126926489
Test: manual
Change-Id: I438a03f42987001de7dce5040dd01347c2c6a9b0
TreeHugger Robot [Mon, 18 Mar 2019 05:56:25 +0000 (05:56 +0000)]
Merge "Log contextual card event to CURRENT user"
TreeHugger Robot [Mon, 18 Mar 2019 04:49:14 +0000 (04:49 +0000)]
Merge "Use short format to avoid truncated problem"
Raff Tsai [Mon, 18 Mar 2019 04:29:39 +0000 (12:29 +0800)]
Log contextual card event to CURRENT user
Fixes:
128804262
Test: Robolectric. Manual
Change-Id: I6e7cffe0773572025beb3ab7964cc18da49681c2
tmfang [Mon, 18 Mar 2019 03:43:28 +0000 (11:43 +0800)]
Fix color lint check error
Test: We can upload CL.
Change-Id: Iabe1d918a98167048b86dae1b61d450fb2e8bd97
TreeHugger Robot [Sat, 16 Mar 2019 02:54:25 +0000 (02:54 +0000)]
Merge "Choose a pref key less likely to conflict"
Hall Liu [Sat, 16 Mar 2019 00:41:47 +0000 (17:41 -0700)]
[automerger skipped] Merge "Base implementation of WFC disclaimer UI" am:
7e2c23aa0d am:
257e6f71ee
am:
770e610a77 -s ours
am skip reason: change_id I789f530d3e16baa6e56feaa4269f6696976f747e with SHA1
9fae73915c is in history
Change-Id: I19290040bf66d86354f83aa7854ee549cf54d50a
Hall Liu [Sat, 16 Mar 2019 00:37:37 +0000 (17:37 -0700)]
Merge "Base implementation of WFC disclaimer UI" am:
7e2c23aa0d
am:
257e6f71ee
Change-Id: Iceb8fffc425756e19b1a2bf16469b0cb69a444da
Hall Liu [Sat, 16 Mar 2019 00:33:26 +0000 (17:33 -0700)]
Merge "Base implementation of WFC disclaimer UI"
am:
7e2c23aa0d
Change-Id: Ib89de5bf801b6669795e7c49010136a0e966324a
Hall Liu [Sat, 16 Mar 2019 00:23:23 +0000 (00:23 +0000)]
Merge "Base implementation of WFC disclaimer UI"
hughchen [Tue, 12 Mar 2019 09:17:23 +0000 (17:17 +0800)]
Sound + Output Switcher on Volume Slice
- Show "play media to" item when Previously Connected device is available
- Click "Play media to" to launch output slice
- Update test case
Bug:
127729340
Test: make -j50 RunSettingsRoboTests
Change-Id: Ic00b309f87bc16f540b22b5a43fecb86f76caeb2
manabu, shimoda [Wed, 8 Nov 2017 02:32:31 +0000 (11:32 +0900)]
Base implementation of WFC disclaimer UI
Test: manual - Check that no error occurred when changing the wifi
calling settings to turn on.
Test: auto - Passed WifiCallingSettingsForSubTest,
WifiCallingDisclaimerFragmentTest and DisclaimerItemListAdapterTest.
Bug:
67872298
Change-Id: I789f530d3e16baa6e56feaa4269f6696976f747e
Merged-In: I789f530d3e16baa6e56feaa4269f6696976f747e
Hall Liu [Fri, 15 Mar 2019 22:57:06 +0000 (22:57 +0000)]
Merge "Base implementation of WFC disclaimer UI"
Fan Zhang [Fri, 15 Mar 2019 22:10:16 +0000 (15:10 -0700)]
Move a few classes around for easier ownership control
Bug:
128547723
Test: rebuild
Change-Id: I8f0dcf30fee44eaae60e10510620fb518cded68f
Jack Yu [Fri, 15 Mar 2019 22:03:27 +0000 (15:03 -0700)]
Renamed NetworkRegistrationState to NetworkRegistrationInfo
API review changes. The class covers more information other than
registration state.
Test: Build
Bug:
127657991
Change-Id: I362bcd3e4bec91817081ddea2f822062b12c4207
TreeHugger Robot [Fri, 15 Mar 2019 21:57:23 +0000 (21:57 +0000)]
Merge "Fix channel configurability check"
TreeHugger Robot [Fri, 15 Mar 2019 21:47:51 +0000 (21:47 +0000)]
Merge "Update design of channel pages."
TreeHugger Robot [Fri, 15 Mar 2019 21:47:32 +0000 (21:47 +0000)]
Merge "Fix for affordances to add a mobile subscription"
TreeHugger Robot [Fri, 15 Mar 2019 21:41:29 +0000 (21:41 +0000)]
Merge "Tie ContextualWifiSlice to UI instead of garbage collector"
TreeHugger Robot [Fri, 15 Mar 2019 21:39:42 +0000 (21:39 +0000)]
Merge "Only show zen rule gear if intent is valid"
TreeHugger Robot [Fri, 15 Mar 2019 21:36:41 +0000 (21:36 +0000)]
Merge changes I85ca2b69,Ibd7a47cb,I79522aab
* changes:
Update strings for scanning settings
Display empty message if no recent location access
Add comment to help translator with plural forms
Jack Yu [Fri, 15 Mar 2019 21:16:41 +0000 (21:16 +0000)]
Merge "Moved transport to IntDef"
Fan Zhang [Fri, 15 Mar 2019 19:47:19 +0000 (19:47 +0000)]
Merge "Update switchbar color for accessibilty"
jackqdyulei [Thu, 14 Mar 2019 20:50:36 +0000 (13:50 -0700)]
Add circle background outline to unthethered icon
Fixes:
124247230
Test: manual
Change-Id: I70f8158685134e2115f2a7baded983ebac6c8f1b
Fan Zhang [Fri, 15 Mar 2019 19:40:18 +0000 (12:40 -0700)]
Update switchbar color for accessibilty
Fixes:
127878068
Test: visual
Change-Id: Ice36a11c4fe126a80db6e5a504e8867e81344173
Lifu Tang [Fri, 15 Mar 2019 19:22:13 +0000 (12:22 -0700)]
Update strings for scanning settings
Bug:
128323721
Test: build, flash, and test manually
Change-Id: I85ca2b69e61bdc839b9df1010c74d945990d5549
Lifu Tang [Fri, 15 Mar 2019 18:40:44 +0000 (11:40 -0700)]
Display empty message if no recent location access
Bug:
120873123
Test: build, flash, and test manually
Change-Id: Ibd7a47cb814fe16ecb1c017865ab28862e17ddcc
Julia Reynolds [Fri, 15 Mar 2019 18:15:55 +0000 (14:15 -0400)]
Choose a pref key less likely to conflict
Test: manual
Fixes:
127498706
Change-Id: I254cef727df137abac5810f19e63449a7f582876
Antony Sargent [Thu, 14 Mar 2019 19:58:56 +0000 (12:58 -0700)]
Fix for affordances to add a mobile subscription
This changes the behavior for when we show an affordance to add a mobile
subscription via the eSIM manager (if eSIM is supported). On the
Network & internet page, the behavior we now want for the "Mobile
network" pref has several possibilities as detailed below.
No existing subscriptions:
- Summary is "Add a network"
- Tapping on pref leads to the add subscription flow
One existing subscription:
- Summary is the name of the subscription (usually the carrier name)
- Tapping left-hand side of the pref leads to mobile network details
- A "+" button is shown on right of pref, and tapping "+" leads to the
add subscription flow
2 or more existing subscriptions:
- Summary is "<count> SIMs"
- Tapping left-hand side of the pref leads to a new page with the list
of subscriptions
- A "+" button is shown on right of pref, and tapping "+" leads to the
add subscription flow
The existing code controlling the "Mobile network" pref (in
MobileNetworkSummaryController.java) already had behavior similar to
this, but needed to be updated to no longer rely on whether we're in
DSDS mode.
Also, the page with the list of subscriptions that you can go to in the
"2 or more existing subscriptions" case mentioned above has an "Add
more" link at the bottom which leads to the same eSIM manager flow, but
it was always showing this link even if the device doesn't support
eSIM. This CL also fixes that problem.
Bug:
127870567
Test: make RunSettingsRoboTests
Change-Id: Ie8cca47ac81f8992fa6ecf1940bdfed411fd333b
Julia Reynolds [Fri, 15 Mar 2019 14:31:46 +0000 (10:31 -0400)]
Fix channel configurability check
Test: atest
Fixes:
128669244
Change-Id: Ib4bc666262426ea1fb8fc034a361c93bdd5afb36
Lei Yu [Fri, 15 Mar 2019 17:06:33 +0000 (17:06 +0000)]
Merge "Turn on remote volume slider"
TreeHugger Robot [Fri, 15 Mar 2019 16:19:14 +0000 (16:19 +0000)]
Merge "Remove parameter from uri when get slice"
TreeHugger Robot [Fri, 15 Mar 2019 16:15:40 +0000 (16:15 +0000)]
Merge "Update api usage for rename"