OSDN Git Service
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:30:24 +0000 (15:30 +0200)]
Staging: rt28x0: fix BPP_R66 register handling
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:30:17 +0000 (15:30 +0200)]
Staging: rt28x0: fix GTK length check in ParseKeyData()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:30:11 +0000 (15:30 +0200)]
Staging: rt28x0: add SIOCGIWNAME support to rt_ioctl_giwscan()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:30:04 +0000 (15:30 +0200)]
Staging: rt2870: add fRTUSB_BULK_OUT_DATA_NORMAL_5 quirk
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:58 +0000 (15:29 +0200)]
Staging: rt2870: use internal command for AsicUpdateProtect()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:51 +0000 (15:29 +0200)]
Staging: rt3070: add remaining rt2870 device ids
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:45 +0000 (15:29 +0200)]
Staging: rt3070: remove needless EFUSE_TAG register read
* remove write-only EFuseTag field from RTMP_ADAPTER
* remove needless EFUSE_TAG register read
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:39 +0000 (15:29 +0200)]
Staging: rt3070: AsicSetSlotTime() fix
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:32 +0000 (15:29 +0200)]
Staging: rt3070: WEP fixes
Propagate WEP fixes from rt28[67]0 to rt3070.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:26 +0000 (15:29 +0200)]
Staging: rt3070: fix PID checking in RTUSBEnqueueCmdFromNdis()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:19 +0000 (15:29 +0200)]
Staging: rt3070: update allowed channels list for Japan
rt3070 driver allows use of 5G channel 34 while rt{286,287,309}0
drivers don't and quick googling seems to confirm the limitation.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:11 +0000 (15:29 +0200)]
Staging: rtxxxx: RTMPGetRalinkAuthModeStr() fixes
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:29:05 +0000 (15:29 +0200)]
Staging: rtxx70: unify NICInitRT30xxRFRegisters()
Unify RT30xx and !RT30xx code in NICInitRT30xxRFRegisters().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:28:58 +0000 (15:28 +0200)]
Staging: rtxxxx: unify AsicSwitchChannel()
Unify RT30xx and !RT30xx code in AsicSwitchChannel().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 23 Aug 2009 13:28:52 +0000 (15:28 +0200)]
Staging: rtxxxx: unify AsicRxAntEvalTimeout()
Unify RT30xx and !RT30xx code in AsicRxAntEvalTimeout().
There should be no functional changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:32:09 +0000 (21:32 +0200)]
Staging: rtxxx0: remove unused code
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:32:02 +0000 (21:32 +0200)]
Staging: rtxxx0: remove private ioctls
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:56 +0000 (21:31 +0200)]
Staging: rtxxx0: remove private debugging ioctls
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:49 +0000 (21:31 +0200)]
Staging: rtxxx0: remove superfluous function prototypes
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:43 +0000 (21:31 +0200)]
Staging: rtxxx0: remove unused link_list.h
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:36 +0000 (21:31 +0200)]
Staging: rtxxx0: debug messages fixes
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:30 +0000 (21:31 +0200)]
Staging: rtxxx0: remove dead virtual adapter support
* remove dead virtual adapter support
* remove needless rt28xx_ioctl() wrapper
* remove superfluous NULL checks
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:24 +0000 (21:31 +0200)]
Staging: rtxxx0: remove dead DBG_DIAGNOSE code
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:17 +0000 (21:31 +0200)]
Staging: rtxxx0: unify AsicEvaluateRxAnt()
Unify RT30xx and !RT30xx code in AsicEvaluateRxAnt().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:11 +0000 (21:31 +0200)]
Staging: rtxxx0: unify MlmeCheckPsmChange()
Unify RT30xx and !RT30xx code in MlmeCheckPsmChange().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:31:04 +0000 (21:31 +0200)]
Staging: rtxxx0: unify RT{USB,MP}FilterCalibration()
RTMP_BBP_IO_{READ,WRITE}8_BY_REG_ID equals RTUSB{Read,Write}BBPRegister
in case of USB chipsets so unify RT30xx and !RT30xx code.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:57 +0000 (21:30 +0200)]
Staging: rtxxx0: remove superfluous RT30xx ifdefs
* add !RT30xx version of IS_RT3090() macro
* remove superfluous RT30xx ifdefs
* unify RT30xx and !RT30xx code where possible
* kill RT28XX_UPDATE_PROTECT() macro
* remove needless variable initializations
* kill some needless function prototypes
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:38 +0000 (21:30 +0200)]
Staging: rtxxx0: unify different RT30xx{Read,Write}RFRegister() flavors
RTMP_IO_{READ,WRITE}32 equals RTUSB{Read,Write}MACRegister
in case of USB chipsets so unify RT30xx and !RT30xx code.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:32 +0000 (21:30 +0200)]
Staging: rtxxx0: remove unused defines
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:25 +0000 (21:30 +0200)]
Staging: rtxxx0: kill PID macros
* kill PID macros
* unify now identical RT30xx and !RT30xx code
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:19 +0000 (21:30 +0200)]
Staging: rt3070: kill TimerQThr thread first in RT28xxThreadTerminate()
* kill TimerQThr thread first in RT28xxThreadTerminate()
* remove the debugging printk() while at it
This makes rt3070 driver match rt2870 driver's behavior.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:12 +0000 (21:30 +0200)]
Staging: rtxxx0: PID checking fixes
* rt3070:
- add missing pid_nr() invocations
* rt{28,30}70:
- do not treat PID 0 as valid
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:30:06 +0000 (21:30 +0200)]
Staging: rtxxx0: kill RT8270_USB_DEVICES() macro
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:29:59 +0000 (21:29 +0200)]
Staging: rtxxx0: remove dead platform specific code
Remove dead support for:
* IKANOS_VX_1X0
* INF_TWINPASS
* INF_DANUBE
* BRCM_6358
platforms.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:29:53 +0000 (21:29 +0200)]
Staging: rtxxx0: remove support for older wireless extensions
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:29:47 +0000 (21:29 +0200)]
Staging: rt3070: fix build warnings
In file included from drivers/staging/rt3070/common/../../rt2870/common/cmm_data.c:2,
from drivers/staging/rt3070/common/cmm_data.c:2:
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/cmm_data.c: In function ‘RTMP_FillTxBlkInfo’:
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/cmm_data.c:1018: warning: label ‘FillTxBlkErr’ defined but not used
In file included from drivers/staging/rt3070/common/../../rt2870/common/eeprom.c:2,
from drivers/staging/rt3070/common/eeprom.c:2:
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c: In function ‘set_eFuseLoadFromBin_Proc’:
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c:1041: warning: unused variable â\80\98orgfsgidâ\80\99
drivers/staging/rt3070/common/../../rt2870/common/../../rt2860/common/eeprom.c:1041: warning: unused variable ‘orgfsuid’
In file included from drivers/staging/rt3070/../rt2870/rt_profile.c:2,
from drivers/staging/rt3070/rt_profile.c:2:
drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c: In function ‘RTMPReadParametersHook’:
drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c:863: warning: unused variable â\80\98orgfsgidâ\80\99
drivers/staging/rt3070/../rt2870/../rt2860/rt_profile.c:863: warning: unused variable â\80\98orgfsuidâ\80\99
In file included from drivers/staging/rt3070/common/rtusb_io.c:2:
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c: In function ‘CMDHandler’:
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: ‘CipherAlg’ may be used uninitialized in this function
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1758: note: ‘CipherAlg’ was declared here
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: ‘KeyIdx’ may be used uninitialized in this function
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1757: note: ‘KeyIdx’ was declared here
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1763: warning: ‘ApIdx’ may be used uninitialized in this function
drivers/staging/rt3070/common/../../rt2870/common/rtusb_io.c:1759: note: ‘ApIdx’ was declared here
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bartlomiej Zolnierkiewicz [Sun, 16 Aug 2009 19:29:41 +0000 (21:29 +0200)]
Staging: rt2870: duplicated code is executed twice in AsicEvaluateRxAnt()
Fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:39 +0000 (11:03 +0300)]
Staging: w35und: Remove some write-only struct members
There's no point in keeping around struct members that are only written
to but never read.
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:38 +0000 (11:03 +0300)]
Staging: w35und: Convert typedef MTO_PARAMETERS to struct wb35_mto_param
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:37 +0000 (11:03 +0300)]
Staging: w35und: Remove unused struct _STATISTICS_INFO
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:36 +0000 (11:03 +0300)]
Staging: w35und: Convert typedef DESCRIPTOR to struct wb35_descriptor
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:35 +0000 (11:03 +0300)]
Staging: w35und: Cleanup the mlmetxrx_f.h header file
This patch removes the unused MLMEProcThread and MLMEReturnPacket
declarations and indents the header file.
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:34 +0000 (11:03 +0300)]
Staging: w35und: Remove unused struct _RXBUFFER
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Wed, 12 Aug 2009 08:03:33 +0000 (11:03 +0300)]
Staging: w35und: Convert MDS typedef to struct w35_mds
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jaswinder Singh Rajput [Thu, 13 Aug 2009 07:41:12 +0000 (13:11 +0530)]
Staging: rt2860: includecheck fix: rt_linux.h
fix the following 'make includecheck' warning:
drivers/staging/rt2860/rt_linux.h: linux/wireless.h is included more than once.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Buesch [Sun, 9 Aug 2009 16:02:30 +0000 (18:02 +0200)]
Staging: rtl8187se: Fix comment-out-typo
This fixes a comment-out-typo that resulted in a dangling if-branch.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Daniele Napolitano [Wed, 12 Aug 2009 16:59:21 +0000 (18:59 +0200)]
Staging: rt2870: new USB ID for Belkin N+
F5D8055
New USB ID for Belkin N+
F5D8055 (USB 802.11n adapter).
I've made this patch with drivers/staging branch found here:
http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git
Signed-off-by: Daniele Napolitano <dnax88@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Tue, 4 Aug 2009 14:26:23 +0000 (10:26 -0400)]
Staging: rtl8192su: add linux/vmalloc.h
Some arches don't provide vmalloc.h through the includes already included
in rtl8192su. This patch adds it.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Tue, 4 Aug 2009 14:26:22 +0000 (10:26 -0400)]
Staging: rtl8192su: stop using skb->tail
This patch replaces uses of skb->tail with skb_tail_pointer(skb).
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Tue, 4 Aug 2009 14:26:21 +0000 (10:26 -0400)]
Staging: rtl8192su: fixup size comparison warning
sizeof(val) returns type unsigned long. count is already unsigned long, so
just use that. This fixes a compile warning.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Tue, 4 Aug 2009 14:26:20 +0000 (10:26 -0400)]
Staging: rtl8192su: fix up printk warnings
This patch addresses printk warnings.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jeff Mahoney [Tue, 4 Aug 2009 14:26:19 +0000 (10:26 -0400)]
Staging: rtl8192su: compile fixes
This patch removes -fhard-float and the software float helpers. In-kernel
floating point is not allowed.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 05:07:56 +0000 (22:07 -0700)]
Staging: echo: coding style cleanups
Some remaining coding style cleanups to the header files
and the echo.c file.
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 05:07:13 +0000 (22:07 -0700)]
Staging: echo: remove unneeded USE_SSE2 defines
This define is never set in the kernel, so remove the code
using it.
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 05:06:46 +0000 (22:06 -0700)]
Staging: echo: remove unneeded USE_MMX defines
This define is never set in the kernel, so remove the code
using it. This lets us drop the mmx.h file as well.
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 05:05:45 +0000 (22:05 -0700)]
Staging: echo: remove bit_operations.h
This file is no longer needed, thanks to the work done by David.
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
David Rowe [Sun, 23 Aug 2009 01:27:53 +0000 (10:57 +0930)]
Staging: echo: top bit patch
This patch removes the need for the bit_operations.h include file which
can now be deleted. It also contains some minor corrections to comments
(typos and alignment of ASCII formulas). I have also removed some #if
lines that were not necessary.
I have tested the patch using a unit test module that runs in kernel
mode and have verified that the patched code gives identical results to
the previous version using a 8000 sample input sequence. Let me know if
you want this unit test, it runs automatically when the module is
insmod-ed and outputs a go/no go result:
# insmod oslec.ko
# dmesg
[
17191803.480000] oslec_test installed
[
17191803.480000] Testing OSLEC with 128 taps (16 ms tail)
[
17191803.496000] Oslec Unit Test PASSED! pass: 8000 fail: 0
Signed-off-by: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Mon, 10 Aug 2009 17:46:37 +0000 (10:46 -0700)]
Staging: echo: remove TODO item
The proc interface is no longer in the echo code, so remove the TODO
item.
Cc: Steve Underwood <steveu@coppice.org>
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Mon, 10 Aug 2009 17:45:25 +0000 (10:45 -0700)]
Staging: echo: fix up remaining checkpatch.pl issues
It's all just minor comment spacing issues. This patch fixes
up the remaining ones and now the code is checkpatch.pl clean.
Cc: Steve Underwood <steveu@coppice.org>
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Kamalesh Babulal [Fri, 14 Aug 2009 10:22:50 +0000 (15:52 +0530)]
Staging: sep: SEP driver build breaks with CONFIG_PCI=n
next-
20090813 randconfig build breaks Discretix SEP driver when
configured with CONFIG_PCI=n.
drivers/staging/sep/sep_driver.c: In function 'sep_probe':
drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'
This patch adds the dependency on PCI for the DX SEP driver.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:49:35 +0000 (15:49 +0100)]
Staging: sep: use ioremap helpers
Whee lots of code vanishes. While we are it note various existing stuff
that couldn't work but was ifdeffed in this area.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:49:22 +0000 (15:49 +0100)]
Staging: sep: untangle the register_fs code
While goto can be useful for cleaner cleaning up in C (as Linux sometimes
does and I think Linus borrowed stylistically from Amiga) you can overdo it.
Here is a fine fine example of when it's overkill
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:49:15 +0000 (15:49 +0100)]
Staging: sep: clean up time
The SEP time setting stuff can now get a hoover
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:43:05 +0000 (15:43 +0100)]
Staging: sep: clean up command sending
Split out the debug dumping functionality. Clean up the rest. For the moment
leave the hideous cache flush in there as the code needs fixing to use
the dma_map_sg interfaces not its own crazed table functions
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:42:41 +0000 (15:42 +0100)]
Staging: sep: flow ioctl cleanup
Simple ioctl taking a single numeric argument so ditch the structs and
weirdness. While we are it lock it properly and fix the error returns.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:42:18 +0000 (15:42 +0100)]
Staging: sep: kick out various fields we can prove are not needed
#1: sep->cache_addr is assigned to sep->rar_addr and never changed
sep->rar_addr is never assigned after this point
#2: sep->cache_bus ditto for sep->rar_bus
#3 sep->rar_region_addr is assigned but necer used
#4 sep->io_addr is in fact private to the probe function and
the same as the reg_addr
#5 The remainig sep->io fields are in fact function locals
#6 sep->message_shared_area is assigned once from sep->shared_area
sep->shared_area does not then change
#7 sep->shared_addr and sep->shared_area_addr are the same thing, ditto
for the bus addresses.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:41:16 +0000 (15:41 +0100)]
Staging: sep: Implement some proper open/close methods
Use the mutex as a protection for open close rather than leaving it hanging
invalidly across userspace.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:41:50 +0000 (15:41 +0100)]
Staging: sep: tidy firmware load
Start by removing unused fields and then work this back to eliminate unused
chunks of the firmware loading ioctl (ie almost all of it)
Also fix the wrong handling of shared allocations and allocate the rar
region properly with dma_alloc_coherent not kmalloc, as it is device shared.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:40:45 +0000 (15:40 +0100)]
Staging: sep: various minor tidyups
Do these in one batch rather than generate lots of tiny diffs
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 14 Aug 2009 14:40:32 +0000 (15:40 +0100)]
Staging: sep: fix a conversion thinko
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:25:43 +0000 (19:25 +0100)]
Staging: sep: Use the proper allocators for the shared area
The DMA handling in the driver is a bit of a catastrophe. Start with the
simple things - allocate the shared area properly.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:25:25 +0000 (19:25 +0100)]
Staging: sep: remove extra CFLAGS we don't use
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:25:16 +0000 (19:25 +0100)]
Staging: sep: Try and get kernel address and user address types right
We will need to tackle this in order to begin doing something about the
bus handled and shared memory object mess.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:25:06 +0000 (19:25 +0100)]
Staging: sep: remove module int macro
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:58 +0000 (19:24 +0100)]
Staging: sep: load_rom is remarkably verbose and repetetive
Give it a haircut
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:51 +0000 (19:24 +0100)]
Staging: sep: fix flow API
We can return NULL - much cleaner
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:43 +0000 (19:24 +0100)]
Staging: sep: clean up after switching to passing sep
Various function calls can now be cleaned up
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:36 +0000 (19:24 +0100)]
Staging: sep: Use filp->private_data to create proper device instances
Move from using a sep_dev global. The workqueue still uses it and we use the
pointer in order to know if a device was found.
This requires some restructuring as the pci probe and the init module logic
are all rather messed up and only worked by luck.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:26 +0000 (19:24 +0100)]
Staging: sep: Fix PCI irq usage
Don't read the IRQ from the device, the device has no idea what is going on
in the full bus topology and remapping above PCI. Use the pdev->irq field.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:18 +0000 (19:24 +0100)]
Staging: sep: rename some fields
Make them more Linuxlike - also favour _bus over _phys
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:08 +0000 (19:24 +0100)]
Staging: sep: use O_NDELAY instead of magic APIs
Open is still completely bogus in this driver but we'll tackle that later -
for now fix the bogus API
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:24:00 +0000 (19:24 +0100)]
Staging: sep: fix time handler
Cleaning up the code reveals an obvious thinko
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:50 +0000 (19:23 +0100)]
Staging: sep: forward declaration removal time
Exterminate! Exterminate! Exterminate!
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:41 +0000 (19:23 +0100)]
Staging: sep: squish some of the wrapper functions
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:34 +0000 (19:23 +0100)]
Staging: sep: kill off unused code
Now it is static we can see what code is unused
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:26 +0000 (19:23 +0100)]
Staging: sep: make everything static
Now we have it in one file we can make it all static and see what falls out
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:19 +0000 (19:23 +0100)]
Staging: sep: merge the two files
Now we have it trimmed down a bit merge the two pieces so we can clean it up
properly. Code moves but no changes in functions.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:11 +0000 (19:23 +0100)]
Staging: sep: kill lock wrapper
We don't need wrappers for this so clean them up
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:23:04 +0000 (19:23 +0100)]
Staging: sep: statically initialize the fops like other drivers
This doesn't need to be done at runtime so do it at compile time
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:22:57 +0000 (19:22 +0100)]
Staging: sep: function shuffle
Shuffle the functions into a more normal order. Don't however change any of
them.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Fri, 7 Aug 2009 18:11:48 +0000 (19:11 +0100)]
Staging: sep: Put all the ARM bits together
I suspect these can be killed off entirely
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:46:22 +0000 (20:46 +0100)]
Staging: sep: priceless ...
Remove some rather pointless goto calls
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:46:08 +0000 (20:46 +0100)]
Staging: sep: first pass after indent
Again all formatting
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:45:57 +0000 (20:45 +0100)]
Staging: sep: indent pass
Ok time to indent and get the code in vague shape. No other changes in this
patch.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:45:47 +0000 (20:45 +0100)]
Staging: sep: do something about all the printk macros
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:45:35 +0000 (20:45 +0100)]
Staging: sep: We have two different repeats of the same logic
So how about a little helper
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:45:24 +0000 (20:45 +0100)]
Staging: sep: rework write_register/read_register
Replace the macros with an inline to get type safety and pass sep_dev
instead of the reg pointer
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:45:07 +0000 (20:45 +0100)]
Staging: sep: Create a structure to hold all the current crap spewed about as globals
For now keep the field names matching the variable names
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:44:46 +0000 (20:44 +0100)]
Staging: rar/sep: Remove C++isms from the headers
C++ header wrapping goes on the user space side
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 6 Aug 2009 19:44:09 +0000 (20:44 +0100)]
Staging: sep: Fix rar build
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>