OSDN Git Service
Tom Lane [Wed, 3 Mar 2010 01:53:17 +0000 (01:53 +0000)]
Instead of trying (and failing) to allow <<label>> at the end of a DECLARE
section, throw an error message saying explicitly that the label must go
before DECLARE. Per investigation of a recent pgsql-novice question,
this code did not work as intended in any modern PG version, maybe not ever.
Allowing such a thing would only create ambiguity anyway, so it seems better
to remove it than fix it.
Bruce Momjian [Tue, 2 Mar 2010 23:38:17 +0000 (23:38 +0000)]
Adjust max_standby_delay documentation to be clearer, and mention that
two adjacent long-running queries have much less than max_standby_delay
before query cancel is possible.
Andrew Dunstan [Tue, 2 Mar 2010 22:02:31 +0000 (22:02 +0000)]
Add missing library and include dir for XSLT in MSVC builds
Bruce Momjian [Tue, 2 Mar 2010 21:18:59 +0000 (21:18 +0000)]
Document the effect of max_standby_delay on increasing the delay of data
from master to slave, and discourage its use during slave/master
keep-xid-alive connections.
Peter Eisentraut [Tue, 2 Mar 2010 20:40:48 +0000 (20:40 +0000)]
Update keywords list for 9.0
Andrew Dunstan [Tue, 2 Mar 2010 17:06:51 +0000 (17:06 +0000)]
Do not run regression tests for contrib/xml2 on MSVC unless building with XML
Tom Lane [Tue, 2 Mar 2010 16:14:39 +0000 (16:14 +0000)]
Cause plpgsql to throw an error if "INTO rowtype_var" is followed by a comma.
Per bug #5352, this helps to provide a useful error message if the user
tries to do something presently unsupported, namely use a rowtype variable
as a member of a multiple-item INTO list.
Andrew Dunstan [Tue, 2 Mar 2010 12:29:14 +0000 (12:29 +0000)]
Add XSLT defines for MSVC builds
Heikki Linnakangas [Mon, 1 Mar 2010 21:27:26 +0000 (21:27 +0000)]
Fix translation of strings in psql \d output (translation in headers worked,
but not in cells).
Heikki Linnakangas [Mon, 1 Mar 2010 20:55:45 +0000 (20:55 +0000)]
Fix numericlocale psql option when used with a null string and latex and troff
formats; a null string must not be formatted as a numeric. The more exotic
formats latex and troff also incorrectly formatted all strings as numerics
when numericlocale was on.
Backpatch to 8.1 where numericlocale option was added.
This fixes bug #5355 reported by Andy Lester.
Tom Lane [Mon, 1 Mar 2010 18:07:59 +0000 (18:07 +0000)]
Fix contrib/xml2 so regression test still works when it's built without libxslt.
This involves modifying the module to have a stable ABI, that is, the
xslt_process() function still exists even without libxslt. It throws a
runtime error if called, but doesn't prevent executing the CREATE FUNCTION
call. This is a good thing anyway to simplify cross-version upgrades.
Magnus Hagander [Mon, 1 Mar 2010 16:02:01 +0000 (16:02 +0000)]
It's clearly now pointless to do backwards compatible parsing of this,
since we released a version without it, so remove the comment that
says we might want to do that.
Tom Lane [Mon, 1 Mar 2010 14:54:00 +0000 (14:54 +0000)]
Buildfarm still unhappy, so I'll bet it's EACCES not EPERM.
Tom Lane [Mon, 1 Mar 2010 05:16:35 +0000 (05:16 +0000)]
Remove xmlCleanupParser calls from contrib/xml2.
These are unnecessary and probably dangerous. I don't see any immediate
risk situations in the core XML support or contrib/xml2 itself, but there
could be issues with external uses of libxml2, and in any case it's an
accident waiting to happen.
Greg Stark [Mon, 1 Mar 2010 00:04:06 +0000 (00:04 +0000)]
add EPERM to the list of return codes to expect from opening directories based on Vista results
Tom Lane [Sun, 28 Feb 2010 21:31:57 +0000 (21:31 +0000)]
Fix up memory management problems in contrib/xml2.
Get rid of the code that attempted to funnel libxml2's memory allocations
into palloc. We already knew from experience with the core xml datatype
that trying to do this is simply not reliable. Unlike the core code, I
did not bother adding a lot of PG_TRY/PG_CATCH logic to try to ensure that
everything is cleaned up on error exit. Hence, we might leak some memory
if one of these functions fails partway through. Given the deprecated
status of this contrib module and the fact that errors partway through
the functions shouldn't be too common, it doesn't seem worth worrying about.
Also fix a separate bug in xpath_table, that it did the wrong things
if given a result tuple descriptor with less than 2 columns. While
such a case isn't very useful in practice, we shouldn't fail or stomp
memory when it occurs.
Add some simple regression tests based on all the reported crash cases
that I have on hand.
This should be back-patched, but let's see if the buildfarm likes it first.
Greg Stark [Sun, 28 Feb 2010 21:05:30 +0000 (21:05 +0000)]
Second try at fsyncing directories in CREATE DATABASE. Let's see what the build farm says of opening directories read-only and ignoring EBADF from fsync of directories
Tom Lane [Sun, 28 Feb 2010 19:51:37 +0000 (19:51 +0000)]
Assorted code cleanup for contrib/xml2. No change in functionality,
just make it a bit less ugly in places.
Bruce Momjian [Sun, 28 Feb 2010 02:20:40 +0000 (02:20 +0000)]
Update complex locale example in the documentation.
Bruce Momjian [Sun, 28 Feb 2010 02:19:47 +0000 (02:19 +0000)]
*** empty log message ***
Michael Meskes [Sat, 27 Feb 2010 21:56:16 +0000 (21:56 +0000)]
Make sure ecpg uses the same header files in the same order as the backend.
Tom Lane [Sat, 27 Feb 2010 21:53:21 +0000 (21:53 +0000)]
Insert a hack into get_float8_nan (both core and ecpg copies) to deal with
the fact that NetBSD/mips is currently broken, as per buildfarm member pika.
Also add regression tests to ensure that get_float8_nan and get_float4_nan
are exercised even on platforms where they are not needed by
float8in/float4in.
Zoltán Böszörményi and Tom Lane
Bruce Momjian [Sat, 27 Feb 2010 20:20:44 +0000 (20:20 +0000)]
Back out unintended change to pg_locale.c.
Bruce Momjian [Sat, 27 Feb 2010 20:16:17 +0000 (20:16 +0000)]
Document ATAPI FLUSH CACHE EXT.
Bruce Momjian [Sat, 27 Feb 2010 14:46:05 +0000 (14:46 +0000)]
Document trace_recovery_messages() parameter as an enum, not string.
Fujii Masao
Heikki Linnakangas [Sat, 27 Feb 2010 09:29:20 +0000 (09:29 +0000)]
Document max_standby_delay=-1 option, now that it's allowed again.
Tom Lane [Sat, 27 Feb 2010 04:29:44 +0000 (04:29 +0000)]
Entity-ify a few new uses of literal <, >, and &.
Tom Lane [Sat, 27 Feb 2010 03:55:52 +0000 (03:55 +0000)]
Undo some more pgindent breakage. Per buildfarm.
Bruce Momjian [Sat, 27 Feb 2010 03:41:34 +0000 (03:41 +0000)]
Use <> for libpq #include in example programs, per suggestion from Josh Berkus.
Bruce Momjian [Sat, 27 Feb 2010 01:39:46 +0000 (01:39 +0000)]
Document ATAPI drive flush command, and mention SSD drives.
Bruce Momjian [Fri, 26 Feb 2010 18:00:15 +0000 (18:00 +0000)]
Suggest gmake installcheck-world for pgindent testing.
Bruce Momjian [Fri, 26 Feb 2010 17:07:55 +0000 (17:07 +0000)]
Revert pgindent changes to ecpg include files that are part of ecpg
regession test output, and update pgindent script to avoid them in the
future.
Bruce Momjian [Fri, 26 Feb 2010 15:57:34 +0000 (15:57 +0000)]
Wording improvements to README.
Bruce Momjian [Fri, 26 Feb 2010 15:42:36 +0000 (15:42 +0000)]
Update pgindent docs to use maintainer-clean.
Bruce Momjian [Fri, 26 Feb 2010 13:50:34 +0000 (13:50 +0000)]
Document why pgindent wants a fresh CVS checkout.
Bruce Momjian [Fri, 26 Feb 2010 04:14:36 +0000 (04:14 +0000)]
In vacuumdb --help, call analyze "statistics", not "hints".
Bruce Momjian [Fri, 26 Feb 2010 02:58:49 +0000 (02:58 +0000)]
Call output file typedefs.list; update README.
Bruce Momjian [Fri, 26 Feb 2010 02:31:52 +0000 (02:31 +0000)]
Document pg_restore --jobs as a performance enhancement.
Bruce Momjian [Fri, 26 Feb 2010 02:11:52 +0000 (02:11 +0000)]
Update pgindent instructions.
Bruce Momjian [Fri, 26 Feb 2010 02:01:40 +0000 (02:01 +0000)]
pgindent run for 9.0
Bruce Momjian [Fri, 26 Feb 2010 01:55:35 +0000 (01:55 +0000)]
Add pgindent typedefs file to CVS.
Bruce Momjian [Fri, 26 Feb 2010 01:40:15 +0000 (01:40 +0000)]
Update pgindent instructions to avoid changes to flex output files.
Bruce Momjian [Fri, 26 Feb 2010 01:11:46 +0000 (01:11 +0000)]
Remove 'emphasis' markup inside literal; not allowed.
Bruce Momjian [Thu, 25 Feb 2010 22:24:00 +0000 (22:24 +0000)]
Document that after triggers that need to see changed rows should not be
marked stable.
Tom Lane [Thu, 25 Feb 2010 20:59:53 +0000 (20:59 +0000)]
Allow predicate_refuted_by() to deduce that NOT A refutes A.
We had originally made the stronger assumption that NOT A refutes any B
if B implies A, but this fails in three-valued logic, because we need to
prove B is false not just that it's not true. However the logic does
go through if B is equal to A.
Recognizing this limited case is enough to handle examples that arise when
we have simplified "bool_var = true" or "bool_var = false" to just "bool_var"
or "NOT bool_var". If we had not done that simplification then the
btree-operator proof logic would have been able to prove that the expressions
were contradictory, but only for identical expressions being compared to the
constants; so handling identical A and B covers all the same cases.
The motivation for doing this is to avoid unexpected asymmetrical behavior
when a partitioned table uses a boolean partitioning column, as in today's
gripe from Dominik Sander.
Back-patch to 8.2, which is as far back as predicate_refuted_by attempts to
do anything at all with NOTs.
Bruce Momjian [Thu, 25 Feb 2010 19:20:38 +0000 (19:20 +0000)]
Document clearly the meaning of none/all for log_statements.
Bruce Momjian [Thu, 25 Feb 2010 18:36:14 +0000 (18:36 +0000)]
Add C comment that do_to_timestamp() lacks error checking.
Bruce Momjian [Thu, 25 Feb 2010 18:16:53 +0000 (18:16 +0000)]
Clearly document that timestamp alone means timestamp without timezone,
per SQL standard, and mention 7.3 behavior at the end.
Magnus Hagander [Thu, 25 Feb 2010 13:26:16 +0000 (13:26 +0000)]
Add configuration parameter ssl_renegotiation_limit to control
how often we do SSL session key renegotiation. Can be set to
0 to disable renegotiation completely, which is required if
a broken SSL library is used (broken patches to CVE-2009-3555
a known cause) or when using a client library that can't do
renegotiation.
Magnus Hagander [Thu, 25 Feb 2010 10:02:30 +0000 (10:02 +0000)]
Fix typos, per Richard Huxton
Heikki Linnakangas [Thu, 25 Feb 2010 09:32:19 +0000 (09:32 +0000)]
Clarify that the connection string for primary_conninfo is in the same
format as in PQconnectdb(). As pointed out by Thom Brown.
Heikki Linnakangas [Thu, 25 Feb 2010 09:16:42 +0000 (09:16 +0000)]
Fix typo.
Heikki Linnakangas [Thu, 25 Feb 2010 08:57:47 +0000 (08:57 +0000)]
Small streaming replication document improvements. Be more explicit that
it's asynchronous.
Heikki Linnakangas [Thu, 25 Feb 2010 07:31:40 +0000 (07:31 +0000)]
Fix streaming replication starting at the very first WAL segment.
Per complaint from Greg Stark.
Tom Lane [Thu, 25 Feb 2010 03:08:07 +0000 (03:08 +0000)]
Improve warning about creating nested named subroutines in plperl.
Per discussion.
Tom Lane [Thu, 25 Feb 2010 02:17:50 +0000 (02:17 +0000)]
Make pg_stop_backup's reporting a bit more verbose in hopes of making
error cases less intimidating for novices. Per discussion.
Greg Smith
Tom Lane [Wed, 24 Feb 2010 18:02:24 +0000 (18:02 +0000)]
Allow zero-dimensional (ie, empty) arrays in contrib/ltree operations.
The main motivation for changing this is bug #4921, in which it's pointed out
that it's no longer safe to apply ltree operations to the result of
ARRAY(SELECT ...) if the sub-select might return no rows. Before 8.3,
the ARRAY() construct would return NULL, which might or might not be helpful
but at least it wouldn't result in an error. Now it returns an empty array
which results in a failure for no good reason, since the ltree operations
are all perfectly capable of dealing with zero-element arrays.
As far as I can find, these ltree functions are the only places where zero
array dimensionality is rejected unnecessarily.
Back-patch to 8.3 to prevent behavioral regression of queries that worked
in older releases.
Bruce Momjian [Wed, 24 Feb 2010 16:27:40 +0000 (16:27 +0000)]
Document that pg_restore -t can use -n for its schema qualification.
Bruce Momjian [Wed, 24 Feb 2010 15:54:31 +0000 (15:54 +0000)]
Revert removal of pre-7.4 documenation behavior mentions.
Alvaro Herrera [Wed, 24 Feb 2010 14:10:24 +0000 (14:10 +0000)]
Remove stray semicolon, per report from strk
Itagaki Takahiro [Wed, 24 Feb 2010 05:20:49 +0000 (05:20 +0000)]
Remove useless codes to initialize TupleDesc from dblink_exec.
Bruce Momjian [Wed, 24 Feb 2010 03:33:49 +0000 (03:33 +0000)]
Remove pre-7.4 documentaiton mentions, now that 8.0 is the oldest
supported release.
Tom Lane [Wed, 24 Feb 2010 02:42:55 +0000 (02:42 +0000)]
Fix patch for printing backend and pg_dump versions so that it works in
a desirable fashion in archive-dump cases, ie you should get the pg_dump
version not the pg_restore version.
Tom Lane [Wed, 24 Feb 2010 02:15:58 +0000 (02:15 +0000)]
Un-break pg_dump for the case of zero-column tables.
This was evidently broken by the CREATE TABLE OF TYPE patch. It would have
been noticed if anyone had bothered to try dumping and restoring the
regression database ...
Tom Lane [Wed, 24 Feb 2010 01:57:16 +0000 (01:57 +0000)]
Use CREATE OR REPLACE LANGUAGE in pg_dump to avoid the need for a couple of
significantly uglier kluges that were working around the change in plpgsql's
preinstalled status.
Tom Lane [Wed, 24 Feb 2010 01:35:14 +0000 (01:35 +0000)]
Make pg_regress use CREATE OR REPLACE LANGUAGE, so that --load-language
will work whether or not the specified language is preinstalled. This
responds to some complaints about having to change test scripts because
plpgsql is preinstalled as of 9.0.
Tom Lane [Tue, 23 Feb 2010 22:51:43 +0000 (22:51 +0000)]
Add an OR REPLACE option to CREATE LANGUAGE.
This operates in the same way as other CREATE OR REPLACE commands, ie,
it replaces everything but the ownership and ACL lists of an existing
entry, and requires the caller to have owner privileges for that entry.
While modifying an existing language has some use in development scenarios,
in typical usage all the "replaced" values come from pg_pltemplate so there
will be no actual change in the language definition. The reason for adding
this is mainly to allow programs to ensure that a language exists without
triggering an error if it already does exist.
This commit just adds and documents the new option. A followon patch
will use it to clean up some unpleasant cases in pg_dump and pg_regress.
Bruce Momjian [Tue, 23 Feb 2010 22:17:25 +0000 (22:17 +0000)]
Modify freebsd start script to just exit 0 with message.
Bruce Momjian [Tue, 23 Feb 2010 22:15:35 +0000 (22:15 +0000)]
Update startup scripts for Linux and FreeBSD.
Kevin Grittner
Bruce Momjian [Tue, 23 Feb 2010 21:48:32 +0000 (21:48 +0000)]
Have pg_dump (-v) verbose mode output the pg_dump and server versions in
text output mode, like we do in custom output mode.
Jim Cox
Bruce Momjian [Tue, 23 Feb 2010 21:38:35 +0000 (21:38 +0000)]
Revert recent COPY manual change about encoding; add mention of "server".
Tom Lane [Tue, 23 Feb 2010 18:35:07 +0000 (18:35 +0000)]
Fix configure's regexp for extracting the Perl version number from perl -v
output. Per bug #5339, Perl 5.11 has changed the format of that output
enough to break the previous coding.
Alex Hunsaker
Tom Lane [Tue, 23 Feb 2010 17:28:09 +0000 (17:28 +0000)]
Clarify statements about tar archive format.
Tom Lane [Tue, 23 Feb 2010 16:55:22 +0000 (16:55 +0000)]
Minor style policing for error messages in pg_dump tar code. Notably, change
"dumping data out of order is not supported" to "restoring data out of order
is not supported", because you get that error during pg_restore not pg_dump.
Also fix some comments that didn't look so good after being pgindented as
perhaps they did originally.
Bruce Momjian [Tue, 23 Feb 2010 16:14:26 +0000 (16:14 +0000)]
Revert recent change of to_char('HH12') handling for intervals; instead
improve documentation, and add C comment.
Bruce Momjian [Tue, 23 Feb 2010 06:29:01 +0000 (06:29 +0000)]
Secondary patch to fix interval to_char() for "HH" where hours >= 12.
Tom Lane [Tue, 23 Feb 2010 05:44:55 +0000 (05:44 +0000)]
Some platforms reject fsync() on files opened O_RDONLY.
Bruce Momjian [Tue, 23 Feb 2010 05:17:33 +0000 (05:17 +0000)]
Make documentation more direct about the handling of COPY files based on
the client encoding.
Bruce Momjian [Tue, 23 Feb 2010 02:47:27 +0000 (02:47 +0000)]
Document that expression indexes that call functions allow function-level
statistics.
Bruce Momjian [Tue, 23 Feb 2010 01:42:19 +0000 (01:42 +0000)]
Supress convertion of zero hours to '12' for intervals when using
to_char with HH, e.g.
to_char(interval '0d 0h 12m 44s', 'DD HH24 MI SS');
now returns:
00 00 12 44
not:
00 12 12 44
Bruce Momjian [Tue, 23 Feb 2010 00:21:19 +0000 (00:21 +0000)]
Update pg_restore documentation to show new pg_restore custom listing
format.
Pavel Golub
Bruce Momjian [Mon, 22 Feb 2010 23:51:40 +0000 (23:51 +0000)]
Remove long-commented-out paragraph in documentation about function
inheritance in create table, per Andrew Dunstan.
Bruce Momjian [Mon, 22 Feb 2010 22:30:10 +0000 (22:30 +0000)]
Document that pg_ctl cares about the PGHOST environment variable.
Bruce Momjian [Mon, 22 Feb 2010 21:16:50 +0000 (21:16 +0000)]
Revert configure warning to use "official distribution".
Bruce Momjian [Mon, 22 Feb 2010 18:12:04 +0000 (18:12 +0000)]
Remove protocol documentation paragraph about environment variable
passing being "covered elsewhere", per Dave Page.
Bruce Momjian [Mon, 22 Feb 2010 18:02:06 +0000 (18:02 +0000)]
Use the term "bundled distribution" instead of "official distribution" in
configure warnings.
Bruce Momjian [Mon, 22 Feb 2010 17:15:10 +0000 (17:15 +0000)]
Briefly document in two places that pg_dump and pg_dumpall cannot be
used for continuous archiving.
Tom Lane [Mon, 22 Feb 2010 15:29:46 +0000 (15:29 +0000)]
Let's try forcing errno to zero before issuing fsync. The current buildfarm
results claiming EBADF seem improbable enough that I'm not convinced fsync
is really returning that --- could it be failing to set errno at all?
Tom Lane [Mon, 22 Feb 2010 15:26:14 +0000 (15:26 +0000)]
Adjust pg_fsync_writethrough so that it will set errno when failing
on a platform that doesn't support this operation. The former coding
would allow an unrelated errno to be reported, which would be quite
misleading. Not sure if this has anything to do with the current
buildfarm failures, but it's certainly bogus as-is.
Heikki Linnakangas [Mon, 22 Feb 2010 11:47:30 +0000 (11:47 +0000)]
Move documentation of all recovery.conf option to a new chapter.
They used to be scattered between the "backup and restore" and "streaming
replication" chapters.
Tom Lane [Mon, 22 Feb 2010 02:50:10 +0000 (02:50 +0000)]
Fix multiple copy and paste-o's. No wonder this code didn't work.
Greg Stark [Mon, 22 Feb 2010 00:11:05 +0000 (00:11 +0000)]
Oops, don't forget to rewind the directory before scanning it to fsync files in CREATE DATABASE
Andrew Dunstan [Sat, 20 Feb 2010 22:24:29 +0000 (22:24 +0000)]
Adjust sample auto-explain output to reflect query text inclusion.
Tom Lane [Sat, 20 Feb 2010 21:24:02 +0000 (21:24 +0000)]
Clean up handling of XactReadOnly and RecoveryInProgress checks.
Add some checks that seem logically necessary, in particular let's make
real sure that HS slave sessions cannot create temp tables. (If they did
they would think that temp tables belonging to the master's session with
the same BackendId were theirs. We *must* not allow myTempNamespace to
become set in a slave session.)
Change setval() and nextval() so that they are only allowed on temp sequences
in a read-only transaction. This seems consistent with what we allow for
table modifications in read-only transactions. Since an HS slave can't have a
temp sequence, this also provides a nicer cure for the setval PANIC reported
by Erik Rijkers.
Make the error messages more uniform, and have them mention the specific
command being complained of. This seems worth the trifling amount of extra
code, since people are likely to see such messages a lot more than before.
Bruce Momjian [Sat, 20 Feb 2010 21:04:28 +0000 (21:04 +0000)]
Make 'include_realm' ordering consistent in the docs, to match recent
doc change.
Bruce Momjian [Sat, 20 Feb 2010 19:21:14 +0000 (19:21 +0000)]
Clarify documentation about username mapping when authenticating with
GSSAPI or Kerberos.
Ian Turner
Bruce Momjian [Sat, 20 Feb 2010 18:28:37 +0000 (18:28 +0000)]
Document that many solid-state drives have volatile write-back caches.
Simon Riggs [Sat, 20 Feb 2010 10:07:27 +0000 (10:07 +0000)]
Copy editing of Hot Standby docs. Some clarifications, addition
of missing items and minor edits.
Tom Lane [Fri, 19 Feb 2010 21:49:10 +0000 (21:49 +0000)]
Reduce the rescan cost estimate for Materialize nodes to cpu_operator_cost per
tuple, instead of the former cpu_tuple_cost. It is sane to charge less than
cpu_tuple_cost because Materialize never does any qual-checking or projection,
so it's got less overhead than most plan node types. In particular, we want
to have the same charge here as is charged for readout in cost_sort. That
avoids the problem recently exhibited by Teodor wherein the planner prefers
a useless sort over a materialize step in a context where a lot of rescanning
will happen. The rescan costs should be just about the same for both node
types, so make their estimates the same.
Not back-patching because all of the current logic for rescan cost estimates
is new in 9.0. The old handling of rescans is sufficiently not-sane that
changing this in that structure is a bit pointless, and might indeed cause
regressions.
Peter Eisentraut [Fri, 19 Feb 2010 18:42:30 +0000 (18:42 +0000)]
Revert version stamping in wrong branch