Merge "Introduce BugReportInPowerPreferenceControllerV2"

Merge "Fix "Add Network" button on SavedAccessPoints page."

Merge "Make robotest less flaky"

Merge "Introduce VerifyAppsOverUsbPreferenceControllerV2"

Merge "Introduce AllowAppsOnExternalPreferenceController"

Make robotest less flaky

Change-Id: Ic9ed1ccbb7b7f802b6a5cf915aeb96c799007a7d
Fixes: 67307841
Test: rerun robotest

Import translations. DO NOT MERGE am: 6fe50e7224  -s ours
am: 2032410de4  -s ours

Change-Id: Idba6ac65fea909285d64e6fe2f883d3e80e6b8c2

Introduce BugReportInPowerPreferenceControllerV2

 - Create new BugReportInPowerPreferenceControllerV2
 - Deprecate BugReportInPowerPreferenceController
 - Create controller inside the DashboardFragment
 - Copy logic from BugReportInPowerPreferenceController with
 slight modifications for dashboard fragment compatibility

Bug: 34203528
Test: make RunSettingsRoboTests -j40# Please enter the commit message for your changes. Lines starting
Change-Id: I8ec0c84fa9c4e59aca48586cc081822d78d8c0d5

Import translations. DO NOT MERGE
am: 6fe50e7224  -s ours

Change-Id: I2ac5d233d10ca35a6d8ed24b29f8eb05fe4bba9c

Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858 am: f38ed428dc am: 5d2919907b
am: 143b31959b

Change-Id: I9f2b3769658200c332a38a943f2bc1331bdae3f9

Merge "Introduce AppsNotRespondingPreferenceController"

Merge "Introduce KeepActivitiesPreferenceController"

Merge "Introduce UsbAudioRoutingPreferenceController"

Merge "Introduce HardwareOverlaysPreferenceController"

Merge "Introduce GpuViewUpdatesPreferenceController"

Merge "Introduce ShowLayoutBoundsPreferenceController"

Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858 am: f38ed428dc
am: 5d2919907b

Change-Id: I542ba13fe05f1027e0199c2a57ade93c6dd0bccb

Merge "Avoid NullPointerException when updating preference intents" am: c4b0fa5858
am: f38ed428dc

Change-Id: I3fcc041677b4d739952902076184a8fa1dd73dad

Merge "Avoid NullPointerException when updating preference intents"
am: c4b0fa5858

Change-Id: I403d380ebfbbb0c70fdf5b6c9ff51267a5163e6f

Merge "Avoid NullPointerException when updating preference intents"

Import translations. DO NOT MERGE

Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: Ib580d3bc9d6b979d5da92cc4ef3f207acdfaa48e

Import translations. DO NOT MERGE

Change-Id: I3be6845a3c0c062387defa8349461b08be25df7f
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Avoid NullPointerException when updating preference intents

Comparisons changed on the intent action. Sometimes an account
preference intent does not have an action specified.

Fixes: 67075850
Test: manual - go to Settings > Users & accounts and tap an account.

Change-Id: I54cebbc983b55aa1487a122d37ccd5c79bbf519d

Introduce VerifyAppsOverUsbPreferenceControllerV2

 - Create new VerifyAppsOverUsbPreferenceControllerV2
 - Deprecate VerifyAppsOverUsbPreferenceController
 - Create controller inside the DashboardFragment
 - Copy logic from VerifyAppsOverUsbPreferenceController with
 slight modifications for dashboard fragment compatibility

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I37c01cd262c9e12307ec9cbe6effc5470496550f

Merge "Create suggestion state provider."

Introduce AllowAppsOnExternalPreferenceController

 - Create new AllowAppsOnExternalPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia8f1be0509f87ad42cf3dc640fa711cdec07698d

Introduce AppsNotRespondingPreferenceController

 - Create new AppsNotRespondingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I9cf9a19b59bf21d6aa0205377025f82ed21b7e51

Introduce UsbAudioRoutingPreferenceController

 - Create new UsbAudioRoutingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie806d509e3df4515cccbaf56c259ae55c3e2ab61

Introduce HardwareOverlaysPreferenceController

 - Create new HardwareOverlaysPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Added ShadowParcel to help with testing
 HardwareOverlaysPreferenceController and
 ShowSurfaceUpdatesPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib6b9679f2a2d2ec84f91da5ac0b68cb2b21eea72

Introduce GpuViewUpdatesPreferenceController

 - Create new GpuViewUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Fix a typo in preference naming

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ieff20634238900137acc1524edb6fd0d4bfce894

Introduce ShowLayoutBoundsPreferenceController

 - Create new ShowLayoutBoundsPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ie7bb26675f4dcedbff9607a2c4e4f5bee0343463

Create suggestion state provider.

- The provider now handles isSuggestionComplete check
- Remove SuggestionChecks class.

Bug: 65065268
Test: robotests
Change-Id: Id45d67d4a5146cc023f7fad7bb292b4c1c14a782

Merge "Introduce StrictModePreferenceController"

Merge "Move code from SuggestionChecks to FeatureProvider"

Merge "Introduce ForceMsaaPreferenceController"

Merge "Introduce HardwareLayersUpdatesPreferenceCtrl"

Merge "Introduce ForceGpuRenderingPreferenceController"

Merge "Introduce RtlLayoutPreferenceController"

Merge "Fix a bug in show surface updates"

Introduce StrictModePreferenceController

 - Create new StrictModePreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I28d70fd5c82de2427747625b5f06f79d3808a145

Introduce KeepActivitiesPreferenceController

 - Create new KeepActivitiesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I9e15d285eee51164dd5c3a07c4f2069bf4d73383

Merge "Fix wrong format in AndroidManifest.xml" am: de795d12d1 am: 39ddac51b6 am: 109d0bafd4
am: 806af289e8

Change-Id: I5ff0ee96f36cc1ab72333879fa92a798bf63a2be

Merge "Fix wrong format in AndroidManifest.xml" am: de795d12d1 am: 39ddac51b6
am: 109d0bafd4

Change-Id: I8aa124be1d911d0fd72df1596436514231cc6fd6

Move code from SuggestionChecks to FeatureProvider

This is step one to deprecate SuggestionChecks. Moving logic into
SuggestionFeatureProvider allows potential logic override and improves
testability.

Also moved isSuggestionComplete tests to corresponding activity/pref
controller test.

Bug: 65065268
Test: robotests
Change-Id: I2071d30fc58bb84acad2083ca03cfcf7d41f10cb

Fix a bug in show surface updates

 - fix a bug that caused the master switch to unintentionally turn on
 the show surface updates preference

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I307a801aa1a7c1606b3f5d55a0d1f2dbf1d60416

Introduce ForceMsaaPreferenceController

 - Create new ForceMsaaPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I5d336037a6ae5904d0459fe56b311fac8372be86

Introduce RtlLayoutPreferenceController

 - Create new RtlLayoutPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ieefd8dc97b0e1f781d97aca781bba0243c3875b9

Introduce HardwareLayersUpdatesPreferenceCtrl

 - Create new HardwareLayersUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Fix a typo in preference naming

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I12744051c836b17ca2bfca5a84b9e22eb7b7d677

Introduce ForceGpuRenderingPreferenceController

 - Create new ForceGpuRenderingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib3afb9278257f0c2b181e15f28650d9620538c17

Merge "Optimize poking to happen in dashboard fragment"

Merge "Import translations. DO NOT MERGE"

Merge "Fix wrong format in AndroidManifest.xml" am: de795d12d1
am: 39ddac51b6

Change-Id: Ife3991761d4fcbf5cecdb6745536f9ed99069a2e

Merge "Fix wrong format in AndroidManifest.xml"
am: de795d12d1

Change-Id: I443534ac7e122e337102d41c4138a0e94be72f7f

Merge "Fix wrong format in AndroidManifest.xml"

Fix wrong format in AndroidManifest.xml

N/A

Change-Id: Idf3b9c22e65d15013f5e3e2f5a1e9719d35ede3a
Signed-off-by: songkailun <songkailun@xiaomi.com>

Optimize poking to happen in dashboard fragment

 - Make sure that poking happens only once in
 onDeveloperOptionsDisabled()

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2a47f34ab17bf57ac4dabc7b0e67b42cc0b120b7

isAvailable is true by default in dev options

 - isAvailable() is defaulted to return true for all developer options
 preferences
 - child controllers should override for custom hiding logic

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I89921f801c25e74bf78d02c55b5f34cf1d464cd0

Merge "Introduce ShowSurfaceUpdatesPreferenceController"

Fix "Add Network" button on SavedAccessPoints page.

Fix merge conflict.

The old onSubmit was a no-op. It now correctly pipes onSubmit to
WifiManager#save() with the new WifiConfiguration. On successful save,
it displays the new network in the list, and on failure, it displays a
toast indicating that the save action failed. Adds a test for the
WifiDialog behaviors on this page.

Bug: 66177765
Test: make RunSettingsRoboTests, manual - tested with Wifi enabled and
disabled, and with networks that were visible and not.
Change-Id: I27446aa49bc9efaf1ea1d6c6158928b62ce01ba2

Merge "Introduce BluetoothInbandRingingPreferenceCtrl"

Introduce ShowSurfaceUpdatesPreferenceController

 - Create new ShowSurfaceUpdatesPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I649549af1c5dd9d541bc9e6a62b4553fa7877233

Merge "Fix a failing test in AdbPreferenceControllerTest"

Fix a failing test in AdbPreferenceControllerTest

 - Mock out a problematic method

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ib12f1e852d27df705f5a13e73f29b0b6f4ab5ff6

Merge "Import translations. DO NOT MERGE" into oc-mr1-dev am: d5b9fec389  -s ours
am: 532f150227  -s ours

Change-Id: Id4ea5c6c982f8ab27551513b422fd6570513b6d8

Merge "Import translations. DO NOT MERGE" into oc-mr1-dev
am: d5b9fec389  -s ours

Change-Id: Iec1b837215cf09e1904287f9eee0082fa4f00097

Merge "Import translations. DO NOT MERGE" into oc-mr1-dev

Introduce BluetoothInbandRingingPreferenceCtrl

 - Create new BluetoothInbandRingingPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I2551803b50323c93ce8f1595d5bbab92b7a18ed4

Merge "Introduce PointerLocationPreferenceController"

Merge "Introduce BluetoothAbsoluteVolumePreferenceCtrl"

Merge "Introduce AdbPreferenceController"

Merge "Refactor IndexData conversion flow"

Merge "Fix fingerprint grammar"

Import translations. DO NOT MERGE

Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Bug: 64712476
Change-Id: If92f24f85c26217b251503d846183f80da8b75ba

Import translations. DO NOT MERGE

Change-Id: I0b4682a530cb8c8bf3727041463fd7afcc885048
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import

Merge "Hide summary for type system" into oc-mr1-dev am: aadee0997c
am: da9247d645

Change-Id: I440fcbfea0cf934e68737eb5314739e397d80d88

Merge "Hide summary for type system" into oc-mr1-dev
am: aadee0997c

Change-Id: I99a8cfefe4253ee223b91d2a3e0b9e7721e73ee4

Merge "Hide summary for type system" into oc-mr1-dev

Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev am: d52c4482e4
am: eccb0fcff9

Change-Id: Ic62d580bad8d520e9a1ec942ab30c361df9e24aa

Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev
am: d52c4482e4

Change-Id: I2206805a6b9dada11576a6e6667980585acc8472

Merge "Move listening to brightness changes to onStart/onStop." into oc-mr1-dev

Fix fingerprint grammar

Fixes: 63121846

Test: manual test of fingerprint setup, string is updated
Change-Id: I5ac90da196639a01db1dc4bf765a671e248e492f

Merge "Update Robolectric to 3.4.2"

Settings: Show HAL HDR+ option in user build am: 4d26fa03a8
am: f0c328ed78

Change-Id: Ia14d7a5ada922d29816f8c9d2895f6141d86ff27

Settings: Show HAL HDR+ option in user build
am: 4d26fa03a8

Change-Id: I9b94c91b0a212ca727b9ba2ee7fc75902f2590e4

Merge "Settings: Correctly align cursor in Settings"

Merge "Settings: Show HAL HDR+ option in user build"

Introduce PointerLocationPreferenceController

 - Create new PointerLocationPreferenceController
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Ia2d190ec39d35e10d7ae6663584b993d16958d5e

Merge "delete obsolete SELinux code."

Merge "Introduce ConnectivityMonitorPreferenceCtrlV2"

Settings: Correctly align cursor in Settings

Steps to Reproduce:
- Click on Density Settings (DPI Settings) / Renaming BT Device / Renaming SIM Settings
- EditText Dialog pops up
- The cursor is at the leftmost side of the text
- Logically Cursor should be at rightmost side which can be aligned grabbing text length

Screenshots:
Before:
http://imgur.com/a/o4vkr
http://imgur.com/a/6Qext

After:
http://imgur.com/a/fuxqT
http://imgur.com/a/vm2WX

Bug: 65185652
Test: RunSettingsRoboTests: OK (47 tests)

Change-Id: Id00308e7e019434edad4afab56cf4719be0d0d54
Signed-off-by: PMS22 <prathams99@rediff.com>

Settings: Show HAL HDR+ option in user build

Test: CameraHalHdrPlusPreferenceControllerV2Test
Bug: 66919557
Change-Id: Ibaadf1b24ba82a8440aae9058397c96db6f24188

Settings: Show HAL HDR+ option in user build

Test: CameraHalHdrplusPreferenceControllerTest
Bug: 66919557
Change-Id: I02e89d34db56398e64e12616f34b8584df25c48b

delete obsolete SELinux code.

This settings field only shows up on devices which have the
ro.build.selinux property, which is never something we added. This code
is dead.

Change-Id: I20349b4e8fea5be761047e47d4551c1a4f087a37
Test: code compiles and setting app works.

Merge "Introduce ShowTapsPreferenceController"

Merge "Introduce TetheringHardwareAccelPreferenceCtrl"

Introduce AdbPreferenceController

 - Create new AdbPreferenceController
 - Create AdbOnChangeListener interface for adb change callbacks
 - Create EnableAdbSettingWarningDialog
 - Create controller inside the DashboardFragment
 - Port logic from DevelopmentSettings into the controller
 - Add deprecated annotation to EnableAdbPreferenceController

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: Id57146149943d770bf5ccc9ed5ecc6ea9d8ae66c

Refactor IndexData conversion flow

This is entirely implementation detail, the public
interface and tests get to stay the same.

- The Raw, Resource and Provider methods now return single
or lists of IndexData rather than adding to a member var.
- Some code duplication was removed for Raw IndexData.
- Extra methods were squashed or removed

The only remaining refactoring in IndexDataConverter is
moving work done on IndexProviders to get the raw and
resources into PreIndexDataCollector.

Bug: 33577327
Test: make RunSettingsRoboTests, Database dump before & after
Change-Id: If6011046955f242ba2614400cfeca3bea5b683cb

Merge "Make ApplicationsState.Session lifecycle-aware"

Merge "Fix a bug in CameraHalHdrPlusPrefCtrlV2Test"

Merge "Introduce WifiVerboseLoggingPreferenceCtrl"