OSDN Git Service
Tom Lane [Mon, 25 Apr 2005 02:14:48 +0000 (02:14 +0000)]
Replace slightly klugy create_bitmap_restriction() function with a
more efficient routine in restrictinfo.c (which can make use of
make_restrictinfo_internal).
Bruce Momjian [Mon, 25 Apr 2005 01:42:41 +0000 (01:42 +0000)]
Add description for concurrent sequential scans:
> One possible implementation is to start sequential scans from the lowest
> numbered buffer in the shared cache, and when reaching the end wrap
> around to the beginning, rather than always starting sequential scans
> at the start of the table.
Tom Lane [Mon, 25 Apr 2005 01:30:14 +0000 (01:30 +0000)]
Remove support for OR'd indexscans internal to a single IndexScan plan
node, as this behavior is now better done as a bitmap OR indexscan.
This allows considerable simplification in nodeIndexscan.c itself as
well as several planner modules concerned with indexscan plan generation.
Also we can improve the sharing of code between regular and bitmap
indexscans, since they are now working with nigh-identical Plan nodes.
Tom Lane [Sun, 24 Apr 2005 18:16:38 +0000 (18:16 +0000)]
Adjust nodeBitmapIndexscan.c to not keep the index open across calls,
but just to open and close it during MultiExecBitmapIndexScan. This
avoids acquiring duplicate resources (eg, multiple locks on the same
relation) in a tree with many bitmap scans. Also, don't bother to
lock the parent heap at all here, since we must be underneath a
BitmapHeapScan node that will be holding a suitable lock.
Tom Lane [Sun, 24 Apr 2005 17:32:46 +0000 (17:32 +0000)]
Actually, nodeBitmapIndexscan.c doesn't need to create a standard
ExprContext at all, since it never evaluates any qual or tlist expressions.
Tom Lane [Sun, 24 Apr 2005 15:32:07 +0000 (15:32 +0000)]
Put back example of using Result node to execute an INSERT.
Bruce Momjian [Sun, 24 Apr 2005 12:39:07 +0000 (12:39 +0000)]
Update wording:
< This allows vacuum to reclaim free space without requiring
< a sequential scan
> This allows vacuum to target specific pages for possible free space
> without requiring a sequential scan.
Bruce Momjian [Sun, 24 Apr 2005 12:01:32 +0000 (12:01 +0000)]
Update wording.
Bruce Momjian [Sun, 24 Apr 2005 11:57:19 +0000 (11:57 +0000)]
Clean up HTML.
Bruce Momjian [Sun, 24 Apr 2005 11:48:52 +0000 (11:48 +0000)]
Add replication FAQ item.
Neil Conway [Sun, 24 Apr 2005 11:46:21 +0000 (11:46 +0000)]
Update some comments to use SQL examples rather than QUEL. From Simon
Riggs.
Bruce Momjian [Sun, 24 Apr 2005 11:27:51 +0000 (11:27 +0000)]
Add line break.
Bruce Momjian [Sun, 24 Apr 2005 11:22:44 +0000 (11:22 +0000)]
Update book items.
Bruce Momjian [Sun, 24 Apr 2005 03:51:49 +0000 (03:51 +0000)]
Update VACUUM VERBOSE FSM message, per Tom.
Tom Lane [Sat, 23 Apr 2005 22:53:05 +0000 (22:53 +0000)]
Repair two TIME WITH TIME ZONE bugs found by Dennis Vshivkov. Comparison
of timetz values misbehaved in --enable-integer-datetime cases, and
EXTRACT(EPOCH) subtracted the zone instead of adding it in all cases.
Backpatch to all supported releases (except --enable-integer-datetime code
does not exist in 7.2).
Tom Lane [Sat, 23 Apr 2005 22:09:58 +0000 (22:09 +0000)]
Remove useless argtype_inherit() code, and make consequent simplifications.
As I pointed out a few days ago, this code has failed to do anything useful
for some time ... and if we did want to revive the capability to select
functions by nearness of inheritance ancestry, this is the wrong place
and way to do it anyway. The knowledge would need to go into
func_select_candidate() instead. Perhaps someday someone will be motivated
to do that, but I am not today.
Bruce Momjian [Sat, 23 Apr 2005 21:45:28 +0000 (21:45 +0000)]
Turns out our existing page size is already optimal in most cases:
< * Research the use of larger page sizes
Bruce Momjian [Sat, 23 Apr 2005 21:44:52 +0000 (21:44 +0000)]
Item already added to existing 'thread' item:
< * Consider parallel processing a single query
<
< This would involve using multiple threads or processes to do optimization,
< sorting, or execution of single query. The major advantage of such a
< feature would be to allow multiple CPUs to work together to process a
< single query.
<
Bruce Momjian [Sat, 23 Apr 2005 21:43:24 +0000 (21:43 +0000)]
Remove item, not sure what it refers to:
< * Allow ORDER BY ... LIMIT 1 to select high/low value without sort or
< index using a sequential scan for highest/lowest values
<
< If only one value is needed, there is no need to sort the entire
< table. Instead a sequential scan could get the matching value.
<
Bruce Momjian [Sat, 23 Apr 2005 21:41:01 +0000 (21:41 +0000)]
New item:
> * Change WAL to use 32-bit CRC, for performance reasons
Bruce Momjian [Sat, 23 Apr 2005 21:39:27 +0000 (21:39 +0000)]
Update threading item:
< Solaris) might benefit from threading.
> Solaris) might benefit from threading. Also explore the idea of
> a single session using multiple threads to execute a query faster.
Bruce Momjian [Sat, 23 Apr 2005 21:38:42 +0000 (21:38 +0000)]
Done:
< * Improve SMP performance on i386 machines
> * -Improve SMP performance on i386 machines
Tom Lane [Sat, 23 Apr 2005 21:32:34 +0000 (21:32 +0000)]
Remove explicit FreeExprContext calls during plan node shutdown. The
ExprContexts will be freed anyway when FreeExecutorState() is reached,
and letting that routine do the work is more efficient because it will
automatically free the ExprContexts in reverse creation order. The
existing coding was effectively freeing them in exactly the worst
possible order, resulting in O(N^2) behavior inside list_delete_ptr,
which becomes highly visible in cases with a few thousand plan nodes.
ExecFreeExprContext is now effectively a no-op and could be removed,
but I left it in place in case we ever want to put it back to use.
Bruce Momjian [Sat, 23 Apr 2005 21:25:49 +0000 (21:25 +0000)]
Done:
< * Optimize locale to have minimal performance impact when not used
Bruce Momjian [Sat, 23 Apr 2005 21:22:55 +0000 (21:22 +0000)]
Fix typo:
< * Add ISo INTERVAL handling
> * Add ISO INTERVAL handling
Bruce Momjian [Sat, 23 Apr 2005 21:16:34 +0000 (21:16 +0000)]
Update VACUUM VERBOSE update, per Alvaro.
Bruce Momjian [Sat, 23 Apr 2005 21:10:20 +0000 (21:10 +0000)]
Update working of VACUUM VERBOSE.
Bruce Momjian [Sat, 23 Apr 2005 20:56:01 +0000 (20:56 +0000)]
Make VACUUM VERBOSE FSM output all output in a single INFO output
statement.
Bruce Momjian [Sat, 23 Apr 2005 20:52:32 +0000 (20:52 +0000)]
Move info about lack of depencency checking in Makefiles to developer's faq.q
Bruce Momjian [Sat, 23 Apr 2005 20:51:44 +0000 (20:51 +0000)]
Update FAQ by eliminating non-frequent items like large objects and
extending questions. Update wording of various entries.
Bruce Momjian [Sat, 23 Apr 2005 19:13:40 +0000 (19:13 +0000)]
Done:
> * -Allow non-bitmap indexes to be combined by creating bitmaps in memory
Bruce Momjian [Sat, 23 Apr 2005 18:59:17 +0000 (18:59 +0000)]
Update H4 tag to H3 to be consistent with heading levels.
Bruce Momjian [Sat, 23 Apr 2005 18:57:46 +0000 (18:57 +0000)]
Add item about server-side debugging.
Bruce Momjian [Sat, 23 Apr 2005 18:57:25 +0000 (18:57 +0000)]
Update FAQ items to point to existing web pages rather than duplication
such information. Remove MySQL mention. Move server-side debug item to
developer's FAQ. Update URLs.
Tom Lane [Sat, 23 Apr 2005 18:49:54 +0000 (18:49 +0000)]
Add comment about checkpoint panic behavior during shutdown, per
suggestion from Qingqing Zhou.
Tom Lane [Sat, 23 Apr 2005 18:35:12 +0000 (18:35 +0000)]
Allow -
2147483648 to be treated as an INT4 rather than INT8 constant.
Per discussion with Paul Edwards.
Tom Lane [Sat, 23 Apr 2005 17:55:50 +0000 (17:55 +0000)]
Treat a zero-D array as empty in int_enum(), per Andrew@supernews.
Tom Lane [Sat, 23 Apr 2005 17:45:35 +0000 (17:45 +0000)]
Recent changes got the sense of the notnull bit backwards in the 2.0
protocol output routines. Mea culpa :-(. Per report from Kris Jurka.
Tom Lane [Sat, 23 Apr 2005 17:22:16 +0000 (17:22 +0000)]
Define the right-hand input of AT TIME ZONE as a full a_expr instead of
c_expr. Perhaps the restriction was once needed to avoid bison errors,
but it seems to work just fine now --- and even generates a slightly
smaller state machine. This change allows examples like
SELECT '13:45'::timetz AT TIME ZONE '-07:00'::interval;
to work without parentheses around the right-hand input.
Bruce Momjian [Sat, 23 Apr 2005 15:22:56 +0000 (15:22 +0000)]
Update FAQ release number to 8.0.2.
Bruce Momjian [Sat, 23 Apr 2005 15:20:39 +0000 (15:20 +0000)]
Modify output of VACUUM VERBOSE to be clearer.
Tom Lane [Sat, 23 Apr 2005 05:38:22 +0000 (05:38 +0000)]
int_aggregate's int_enum() doesn't work correctly with arrays that
aren't 1-D, so give an error message instead of failing. Per report
from Ron Mayer.
Tom Lane [Sat, 23 Apr 2005 04:42:53 +0000 (04:42 +0000)]
Turns out that my recent elimination of the 'redundant' flatten_andors()
code in prepqual.c had a small drawback: the flatten_andors code was
able to cope with deeply nested AND/OR structures (like 10000 ORs in
a row), whereas eval_const_expressions tends to recurse until it
overruns the stack. Revise eval_const_expressions so that it doesn't
choke on deeply nested ANDs or ORs.
Bruce Momjian [Sat, 23 Apr 2005 03:27:40 +0000 (03:27 +0000)]
Add documentation stating how to determine if FSM settings are too low
--- look at a database-wide VACUUM VERBOSE.
Tom Lane [Sat, 23 Apr 2005 01:57:34 +0000 (01:57 +0000)]
Teach choose_bitmap_and() to actually be choosy --- that is, try to
make some estimate of which available indexes to AND together, rather
than blindly taking 'em all. This could probably stand further
improvement, but it seems to do OK in simple tests.
Tom Lane [Sat, 23 Apr 2005 01:29:15 +0000 (01:29 +0000)]
Fix bogus EXPLAIN display of rowcount estimates for BitmapAnd and
BitmapOr nodes.
Tom Lane [Fri, 22 Apr 2005 21:58:32 +0000 (21:58 +0000)]
First cut at planner support for bitmap index scans. Lots to do yet,
but the code is basically working. Along the way, rewrite the entire
approach to processing OR index conditions, and make it work in join
cases for the first time ever. orindxpath.c is now basically obsolete,
but I left it in for the time being to allow easy comparison testing
against the old implementation.
Bruce Momjian [Fri, 22 Apr 2005 15:40:16 +0000 (15:40 +0000)]
Fix typo:
< Currently indexes do not have enough tuple tuple visibility
< information to allow data to be pulled from the index without
< also accessing the heap. One way to allow this is to set a bit
< to index tuples to indicate if a tuple is currently visible to
< all transactions when the first valid heap lookup happens. This
< bit would have to be cleared when a heap tuple is expired.
> Currently indexes do not have enough tuple visibility information
> to allow data to be pulled from the index without also accessing
> the heap. One way to allow this is to set a bit to index tuples
> to indicate if a tuple is currently visible to all transactions
> when the first valid heap lookup happens. This bit would have to
> be cleared when a heap tuple is expired.
Bruce Momjian [Fri, 22 Apr 2005 15:32:58 +0000 (15:32 +0000)]
Typo fix. Alvaro.
Bruce Momjian [Fri, 22 Apr 2005 13:38:19 +0000 (13:38 +0000)]
Update URL for TODO list.
Bruce Momjian [Fri, 22 Apr 2005 04:20:44 +0000 (04:20 +0000)]
Remove pre-7.3 mention that FOR UPDATE can be before LIMIT.
Document that FOR UPDATE and LIMIT together can return fewer rows that
LIMIT specifies, and why.
Bruce Momjian [Fri, 22 Apr 2005 04:18:58 +0000 (04:18 +0000)]
Clarify that only crypt can't use md5 pg_shadow passwords.
Bruce Momjian [Thu, 21 Apr 2005 22:19:19 +0000 (22:19 +0000)]
Clarify use of MD5 authentication and pg_shadow encryption.
Tom Lane [Thu, 21 Apr 2005 19:18:13 +0000 (19:18 +0000)]
Rethink original decision to use AND/OR Expr nodes to represent bitmap
logic operations during planning. Seems cleaner to create two new Path
node types, instead --- this avoids duplication of cost-estimation code.
Also, create an enable_bitmapscan GUC parameter to control use of bitmap
plans.
Bruce Momjian [Thu, 21 Apr 2005 15:20:39 +0000 (15:20 +0000)]
Updated text for bitmaps:
< Bitmap indexes index single columns that can be combined with other bitmap
< indexes to dynamically create a composite index to match a specific query.
< Each index is a bitmap, and the bitmaps are bitwise AND'ed or OR'ed to be
< combined. They can index by tid or can be lossy requiring a scan of the
< heap page to find matching rows, or perhaps use a mixed solution where
< tids are recorded for pages with only a few matches and per-page bitmaps
< are used for more dense pages. Another idea is to use a 32-bit bitmap
< for every page and set a bit based on the item number mod(32).
> This feature allows separate indexes to be ANDed or ORed together. This
> is particularly useful for data warehousing applications that need to
> query the database in an many permutations. This feature scans an index
> and creates an in-memory bitmap, and allows that bitmap to be combined
> with other bitmap created in a similar way. The bitmap can either index
> all TIDs, or be lossy, meaning it records just page numbers and each
> page tuple has to be checked for validity in a separate pass.
Bruce Momjian [Thu, 21 Apr 2005 04:09:34 +0000 (04:09 +0000)]
Done:
< * Add tool to query pg_stat_* tables and report indexes that aren't needed
< or tables that might need indexes
Tom Lane [Thu, 21 Apr 2005 02:28:02 +0000 (02:28 +0000)]
Install some slightly realistic cost estimation for bitmap index scans.
Tom Lane [Wed, 20 Apr 2005 23:10:16 +0000 (23:10 +0000)]
Make pg_ctl status do a kill() test to verify that the PID found in
postmaster.pid still represents a live postmaster.
Tom Lane [Wed, 20 Apr 2005 22:19:58 +0000 (22:19 +0000)]
Add note clarifying that indexes that support ordered scans had better
allow clauseless scans.
Tom Lane [Wed, 20 Apr 2005 21:48:04 +0000 (21:48 +0000)]
Don't try to run clauseless index scans on index types that don't support
it. Per report from Marinos Yannikos.
Tom Lane [Wed, 20 Apr 2005 17:14:50 +0000 (17:14 +0000)]
Fix mis-display of negative fractional seconds in interval values for
--enable-integer-datetimes case. Per report from Oliver Siegmar.
Tom Lane [Wed, 20 Apr 2005 15:48:36 +0000 (15:48 +0000)]
Minor performance improvement: avoid unnecessary creation/unioning of
bitmaps for multiple indexscans. Instead just let each indexscan add
TIDs directly into the BitmapOr node's result bitmap.
Bruce Momjian [Wed, 20 Apr 2005 02:48:11 +0000 (02:48 +0000)]
Add:
> * Add tool to query pg_stat_* tables and report indexes that aren't needed
> or tables that might need indexes
Bruce Momjian [Wed, 20 Apr 2005 02:43:49 +0000 (02:43 +0000)]
Add:
> * Log queries where the optimizer row estimates were dramatically
> different from the number of rows actually found (?)
Bruce Momjian [Wed, 20 Apr 2005 01:17:34 +0000 (01:17 +0000)]
Add:
> * All ability to monitor the use of temporary sort files
Tom Lane [Tue, 19 Apr 2005 22:35:18 +0000 (22:35 +0000)]
Create executor and planner-backend support for decoupled heap and index
scans, using in-memory tuple ID bitmaps as the intermediary. The planner
frontend (path creation and cost estimation) is not there yet, so none
of this code can be executed. I have tested it using some hacked planner
code that is far too ugly to see the light of day, however. Committing
now so that the bulk of the infrastructure changes go in before the tree
drifts under me.
Teodor Sigaev [Tue, 19 Apr 2005 13:58:48 +0000 (13:58 +0000)]
Add comment about permissions on pg_ts* tables
Bruce Momjian [Tue, 19 Apr 2005 03:55:43 +0000 (03:55 +0000)]
>>>>Luckily, PG 8 is available for this. Do you have a short example?
>>>
>>>No, and I think it should be in the manual as an example.
>>>
>>>You will need to enter a loop that uses exception handling to detect
>>>unique_violation.
>>
>>Pursuant to an IRC discussion to which Dennis Bjorklund and
>>Christopher Kings-Lynne made most of the contributions, please find
>>enclosed an example patch demonstrating an UPSERT-like capability.
>>
David Fetter
Bruce Momjian [Tue, 19 Apr 2005 03:37:20 +0000 (03:37 +0000)]
> >Luckily, PG 8 is available for this. Do you have a short example?
>
> No, and I think it should be in the manual as an example.
>
> You will need to enter a loop that uses exception handling to detect
> unique_violation.
Pursuant to an IRC discussion to which Dennis Bjorklund and
Christopher Kings-Lynne made most of the contributions, please find
enclosed an example patch demonstrating an UPSERT-like capability.
David Fetter
Bruce Momjian [Tue, 19 Apr 2005 03:35:15 +0000 (03:35 +0000)]
The following patch should allow UPDATE_INTERVAL to be specified on the
command line. We find this useful because we frequently deal with
thousands of tables in an environment where neither the databases nor
the tables are updated frequently. This helps allow us to cut down on
the overhead of updating the list for every other primary loop of
pg_autovacuum.
I chose -i as the command-line argument and documented it briefly in
the README.
The patch was applied to the 7.4.7 version of pg_autovacuum in contrib.
Thomas F.O'Connell
Bruce Momjian [Tue, 19 Apr 2005 03:13:59 +0000 (03:13 +0000)]
Attached patch gets rid of the global timezone in the following steps:
* Changes the APIs to the timezone functions to take a pg_tz pointer as
an argument, representing the timezone to use for the selected
operation.
* Adds a global_timezone variable that represents the current timezone
in the backend as set by SET TIMEZONE (or guc, or env, etc).
* Implements a hash-table cache of loaded tables, so we don't have to
read and parse the TZ file everytime we change a timezone. While not
necesasry now (we don't change timezones very often), I beleive this
will be necessary (or at least good) when "multiple timezones in the
same query" is eventually implemented. And code-wise, this was the time
to do it.
There are no user-visible changes at this time. Implementing the
"multiple zones in one query" is a later step...
This also gets rid of some of the cruft needed to "back out a timezone
change", since we previously couldn't check a timezone unless it was
activated first.
Passes regression tests on win32, linux (slackware 10) and solaris x86.
Magnus Hagander
Bruce Momjian [Tue, 19 Apr 2005 01:39:50 +0000 (01:39 +0000)]
Update PITR wording, per Simon.
Tom Lane [Mon, 18 Apr 2005 23:47:52 +0000 (23:47 +0000)]
pg_dumpall should enforce the server version check for itself, rather
than simply passing it down to pg_dump. Else, version-related failures
in pg_dumpall itself generate unhelpful error messages.
Bruce Momjian [Mon, 18 Apr 2005 18:30:56 +0000 (18:30 +0000)]
Add WAL entry about compression.
Bruce Momjian [Mon, 18 Apr 2005 18:29:57 +0000 (18:29 +0000)]
Added to TODO:
> * Compress WAL entries [wal]
Bruce Momjian [Mon, 18 Apr 2005 17:40:40 +0000 (17:40 +0000)]
Update PITR setence to mention WAL and file system dump.
Tom Lane [Mon, 18 Apr 2005 17:11:05 +0000 (17:11 +0000)]
record_in and record_recv must be careful to return a separately
pfree'able result, since some callers expect to be able to pfree
the result of a pass-by-reference function. Per report from Chris Trawick.
Bruce Momjian [Mon, 18 Apr 2005 15:03:21 +0000 (15:03 +0000)]
Update PITR TODO items:
< failure.
> failure. This could be triggered by a user command or a timer.
< * Force archiving of partially-full WAL files when pg_stop_backup() is
< called or the server is stopped
> * Automatically force archiving of partially-filled WAL files when
> pg_stop_backup() is called or the server is stopped
Bruce Momjian [Mon, 18 Apr 2005 14:44:04 +0000 (14:44 +0000)]
Update TODO script sample.
Bruce Momjian [Mon, 18 Apr 2005 14:42:35 +0000 (14:42 +0000)]
Update for HTML markup.
Bruce Momjian [Mon, 18 Apr 2005 13:11:04 +0000 (13:11 +0000)]
Add description that WAL files used during backup have to be archived
before you are done.
Bruce Momjian [Mon, 18 Apr 2005 12:58:45 +0000 (12:58 +0000)]
Add HTML version of TODO to CVS, for web site use.
Bruce Momjian [Mon, 18 Apr 2005 12:58:11 +0000 (12:58 +0000)]
Add HTML TODO version to CVS.
Bruce Momjian [Mon, 18 Apr 2005 12:51:41 +0000 (12:51 +0000)]
Add description about partial WAL archiving for PITR:
>
> Doing this will allow administrators to know more easily when the
> archive contins all the files needed for point-in-time recovery.
Bruce Momjian [Mon, 18 Apr 2005 03:46:31 +0000 (03:46 +0000)]
Fix html.
Bruce Momjian [Mon, 18 Apr 2005 03:17:23 +0000 (03:17 +0000)]
Test new html tag.
Bruce Momjian [Mon, 18 Apr 2005 03:00:44 +0000 (03:00 +0000)]
Add:
> * Force archiving of partially-full WAL files when pg_stop_backup() is
> called or the server is stopped
Bruce Momjian [Mon, 18 Apr 2005 01:29:00 +0000 (01:29 +0000)]
Update PITR mention of which WAL files are needed.
Tom Lane [Sun, 17 Apr 2005 22:24:02 +0000 (22:24 +0000)]
Initial implementation of lossy-tuple-bitmap data structures.
Not connected to anything useful yet ...
Bruce Momjian [Sun, 17 Apr 2005 03:05:19 +0000 (03:05 +0000)]
Clarify name of file to be checked for PITR expiring.
Bruce Momjian [Sun, 17 Apr 2005 03:04:29 +0000 (03:04 +0000)]
Fix comment typo.
Tom Lane [Sat, 16 Apr 2005 20:07:35 +0000 (20:07 +0000)]
Create a new 'MultiExecProcNode' call API for plan nodes that don't
return just a single tuple at a time. Currently the only such node
type is Hash, but I expect we will soon have indexscans that can return
tuple bitmaps. A side benefit is that EXPLAIN ANALYZE now shows the
correct tuple count for a Hash node.
Tom Lane [Sat, 16 Apr 2005 16:50:01 +0000 (16:50 +0000)]
Minor improvements to locale documentation.
Tom Lane [Fri, 15 Apr 2005 22:19:48 +0000 (22:19 +0000)]
Reduce PANIC to ERROR in several xlog routines that are used in both
critical and noncritical contexts (an example of noncritical being
post-checkpoint removal of dead xlog segments). In the critical cases
the CRIT_SECTION mechanism will cause ERROR to be promoted to PANIC
anyway, and in the noncritical cases we shouldn't let an error take
down the entire database. Arguably there should be *no* explicit
PANIC errors in this module, only more START/END_CRIT_SECTION calls,
but I didn't go that far. (Yet.)
Tom Lane [Fri, 15 Apr 2005 18:48:10 +0000 (18:48 +0000)]
Modify MoveOfflineLogs/InstallXLogFileSegment to avoid O(N^2) behavior
when recycling a large number of xlog segments during checkpoint.
The former behavior searched from the same start point each time,
requiring O(checkpoint_segments^2) stat() calls to relocate all the
segments. Instead keep track of where we stopped last time through.
Tom Lane [Fri, 15 Apr 2005 16:40:36 +0000 (16:40 +0000)]
Revert addition of poorly-thought-out DUMP TIMESTAMP archive entry,
which induced bug #1597 in addition to having several other misbehaviors
(like labeling the dump with a completion time having nothing to do with
reality). Instead just print out the desired strings where RestoreArchive
was already emitting the 'PostgreSQL database dump' and
'PostgreSQL database dump complete' strings.
Neil Conway [Fri, 15 Apr 2005 04:29:32 +0000 (04:29 +0000)]
This patch changes the use of varargs.h to stdarg.h as
required by modern versions of GCC.
Niels Breet
Neil Conway [Fri, 15 Apr 2005 04:18:10 +0000 (04:18 +0000)]
Remove an unused variable "waitingForSignal". From Qingqing Zhou.
Bruce Momjian [Thu, 14 Apr 2005 23:20:55 +0000 (23:20 +0000)]
Done
> * -Use indexes for MIN() and MAX()
Tom Lane [Thu, 14 Apr 2005 22:34:48 +0000 (22:34 +0000)]
Make equalTupleDescs() compare attlen/attbyval/attalign rather than
assuming comparison of atttypid is sufficient. In a dropped column
atttypid will be 0, and we'd better check the physical-storage data
to make sure the tupdescs are physically compatible.
I do not believe there is a real risk before 8.0, since before that
we only used this routine to compare successive states of the tupdesc
for a particular relation. But 8.0's typcache.c might be comparing
arbitrary tupdescs so we'd better play it safer.