OSDN Git Service

android-x86/packages-apps-Camera2.git
9 years agoam baae9e84: am 8bbb5122: Merge "add null check to updateCameraParametersPreferences...
Spike Sprague [Fri, 19 Sep 2014 19:32:08 +0000 (19:32 +0000)]
am baae9e84: am 8bbb5122: Merge "add null check to updateCameraParametersPreferences to apease the monkey" into ub-camera-glacier

* commit 'baae9e8478990258edc7e6d014a68e0796859de9':
  add null check to updateCameraParametersPreferences to apease the monkey

9 years agoam 8bbb5122: Merge "add null check to updateCameraParametersPreferences to apease...
Spike Sprague [Fri, 19 Sep 2014 18:30:27 +0000 (18:30 +0000)]
am 8bbb5122: Merge "add null check to updateCameraParametersPreferences to apease the monkey" into ub-camera-glacier

* commit '8bbb51221106c12b0cf7e933fc2af2a63b84b1c1':
  add null check to updateCameraParametersPreferences to apease the monkey

9 years agoMerge "add null check to updateCameraParametersPreferences to apease the monkey"...
Spike Sprague [Fri, 19 Sep 2014 18:22:56 +0000 (18:22 +0000)]
Merge "add null check to updateCameraParametersPreferences to apease the monkey" into ub-camera-glacier

9 years agoadd null check to updateCameraParametersPreferences to apease the monkey
Spike Sprague [Fri, 19 Sep 2014 18:18:46 +0000 (11:18 -0700)]
add null check to updateCameraParametersPreferences to apease the monkey

bug: 17580046
Change-Id: I4a109c1134684f6d5b2dafdb138137ef36f208f0

9 years agoam 476a9e24: am 963775c3: portability layer doesn\'t work well with startPreviewWithC...
Spike Sprague [Fri, 19 Sep 2014 06:38:51 +0000 (06:38 +0000)]
am 476a9e24: am 963775c3: portability layer doesn\'t work well with startPreviewWithCallback() here\'s a dirty dirty workaround.

* commit '476a9e2490d91a125fc608d4e4b4b31768b65ee7':
  portability layer doesn't work well with startPreviewWithCallback() here's a dirty dirty workaround.

9 years agoam 963775c3: portability layer doesn\'t work well with startPreviewWithCallback(...
Spike Sprague [Fri, 19 Sep 2014 06:19:18 +0000 (06:19 +0000)]
am 963775c3: portability layer doesn\'t work well with startPreviewWithCallback() here\'s a dirty dirty workaround.

* commit '963775c3092e2553ae8157df9e5d307d4f711de1':
  portability layer doesn't work well with startPreviewWithCallback() here's a dirty dirty workaround.

9 years agoportability layer doesn't work well with startPreviewWithCallback()
Spike Sprague [Fri, 19 Sep 2014 02:44:07 +0000 (19:44 -0700)]
portability layer doesn't work well with startPreviewWithCallback()
here's a dirty dirty workaround.

bug: 17576554
Change-Id: Ief40b65ce49712153f6ef604a3513348e493d4d9

9 years agoam af25fb04: am 3c3b31df: mode switch jank fixes
Spike Sprague [Thu, 18 Sep 2014 20:20:46 +0000 (20:20 +0000)]
am af25fb04: am 3c3b31df: mode switch jank fixes

* commit 'af25fb04968d9212ec47367f6ba78ee20ca76d05':
  mode switch jank fixes

9 years agoam 3c3b31df: mode switch jank fixes
Spike Sprague [Thu, 18 Sep 2014 20:11:13 +0000 (20:11 +0000)]
am 3c3b31df: mode switch jank fixes

* commit '3c3b31dfd5ec7a43e89cd4695cc8c498afc3a91d':
  mode switch jank fixes

9 years agomode switch jank fixes
Spike Sprague [Mon, 8 Sep 2014 17:43:04 +0000 (10:43 -0700)]
mode switch jank fixes

puts many ValueAnimators news into initialize methods
changes startPreview() calls to startPreviewWithCallback()
puts MultToggleImageButton's bitmap combine into an AsyncTask

bug: 17070332
Change-Id: Idea6396264588b345ed27b9f96f9434ff3e7e77c

9 years agoam 9a275f5e: (-s ours) Merge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Tue, 16 Sep 2014 15:32:08 +0000 (15:32 +0000)]
am 9a275f5e: (-s ours) Merge "Import translations. DO NOT MERGE" into lmp-dev

* commit '9a275f5eed1e0b6fdcafd9fdd42cd2568db2cfc6':
  Import translations. DO NOT MERGE

9 years agoMerge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Tue, 16 Sep 2014 15:20:49 +0000 (15:20 +0000)]
Merge "Import translations. DO NOT MERGE" into lmp-dev

9 years agoam 0d7a8c08: am 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into...
Puneet Lall [Tue, 16 Sep 2014 08:36:05 +0000 (08:36 +0000)]
am 0d7a8c08: am 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into ub-camera-glacier

* commit '0d7a8c08446f94264870538f76bc0c2846e0dd48':
  Don't set mCameraAppUI to null in onDestroy

9 years agoam ad1462a9: am a16219d5: set proper alpha on shutter button on mode switch, eliminat...
Spike Sprague [Tue, 16 Sep 2014 08:32:02 +0000 (08:32 +0000)]
am ad1462a9: am a16219d5: set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

* commit 'ad1462a9492cdf9e98bb0c94cdd4b6c89e0dd47f':
  set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

9 years agoam 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into ub-camera...
Puneet Lall [Tue, 16 Sep 2014 08:21:16 +0000 (08:21 +0000)]
am 6f1dfe69: Merge "Don\'t set mCameraAppUI to null in onDestroy" into ub-camera-glacier

* commit '6f1dfe69b93bfb42c11d456901e9d3ffee826cce':
  Don't set mCameraAppUI to null in onDestroy

9 years agoMerge "Don't set mCameraAppUI to null in onDestroy" into ub-camera-glacier
Puneet Lall [Mon, 15 Sep 2014 21:41:55 +0000 (21:41 +0000)]
Merge "Don't set mCameraAppUI to null in onDestroy" into ub-camera-glacier

9 years agoDon't set mCameraAppUI to null in onDestroy
Puneet Lall [Mon, 15 Sep 2014 18:29:59 +0000 (11:29 -0700)]
Don't set mCameraAppUI to null in onDestroy

BUG: 17408047

Note that we originally set this to null to address BUG: 12805279
which involved leaking Views.  However, this has regressed and will
require another look regardless.  The number of views leaked
with and without the null assignment is the same, so this change
does not make the regression any worse.

Change-Id: If90aeebb081073eb4f5b928919fc67ef710e1054

9 years agoam a16219d5: set proper alpha on shutter button on mode switch, eliminates a janky...
Spike Sprague [Mon, 15 Sep 2014 19:26:53 +0000 (19:26 +0000)]
am a16219d5: set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

* commit 'a16219d51937bda5f3e69c0e77171ae0fb893823':
  set proper alpha on shutter button on mode switch, eliminates a janky alpha flash

9 years agoImport translations. DO NOT MERGE
Baligh Uddin [Mon, 15 Sep 2014 06:11:10 +0000 (23:11 -0700)]
Import translations. DO NOT MERGE

Change-Id: I7ec96a5d9c1e761e23af43c5b61dd537e1577346
Auto-generated-cl: translation import

9 years agoset proper alpha on shutter button on mode switch,
Spike Sprague [Fri, 12 Sep 2014 22:01:04 +0000 (15:01 -0700)]
set proper alpha on shutter button on mode switch,
eliminates a janky alpha flash

bug: 17487040

Change-Id: I08e66b5be53e58e9e16d32c09ef50081e90e9284

9 years agoam 5c56b2c4: am 70a96525: Don\'t send redundant requests to start the preview
Puneet Lall [Fri, 12 Sep 2014 18:59:58 +0000 (18:59 +0000)]
am 5c56b2c4: am 70a96525: Don\'t send redundant requests to start the preview

* commit '5c56b2c4bf6b31dee65806fcfa67b877657c3975':
  Don't send redundant requests to start the preview

9 years agoam 70a96525: Don\'t send redundant requests to start the preview
Puneet Lall [Fri, 12 Sep 2014 18:02:34 +0000 (18:02 +0000)]
am 70a96525: Don\'t send redundant requests to start the preview

* commit '70a96525f16ca6c6abb9a7a9dab26ba1e61235dd':
  Don't send redundant requests to start the preview

9 years agoam 3c324d34: am 486ba1da: Revert layout change for Camera
Alan Newberger [Fri, 12 Sep 2014 07:26:55 +0000 (07:26 +0000)]
am 3c324d34: am 486ba1da: Revert layout change for Camera

* commit '3c324d34bd0930c615bac32bdb6bbbf7d9cf31c5':
  Revert layout change for Camera

9 years agoam 4a7668d7: am ca5173d8: Move launcher icons to mipmap
Alan Newberger [Fri, 12 Sep 2014 07:26:54 +0000 (07:26 +0000)]
am 4a7668d7: am ca5173d8: Move launcher icons to mipmap

* commit '4a7668d72b2f80e90156bfae4befbe37b10c4d2e':
  Move launcher icons to mipmap

9 years agoDon't send redundant requests to start the preview
Puneet Lall [Fri, 12 Sep 2014 00:33:21 +0000 (17:33 -0700)]
Don't send redundant requests to start the preview

Change-Id: I43d8a2917bbe0140f1e9367cce21f68b19807aa8

9 years agoam 486ba1da: Revert layout change for Camera
Alan Newberger [Fri, 12 Sep 2014 01:46:46 +0000 (01:46 +0000)]
am 486ba1da: Revert layout change for Camera

* commit '486ba1da145f70b07235617e5f1f64186daa0fc0':
  Revert layout change for Camera

9 years agoam ca5173d8: Move launcher icons to mipmap
Alan Newberger [Fri, 12 Sep 2014 01:46:44 +0000 (01:46 +0000)]
am ca5173d8: Move launcher icons to mipmap

* commit 'ca5173d84722383d2d9ef49dd85fba28af035429':
  Move launcher icons to mipmap

9 years agoRevert layout change for Camera
Alan Newberger [Thu, 11 Sep 2014 23:29:20 +0000 (16:29 -0700)]
Revert layout change for Camera

Changing from LAYOUT_FULLSCREEN to FULLSCREEN interferes with layout of
Action Bar.

Bug: 17477202
Change-Id: I029a84adbe4c5017cc8185c5c0c2601a03196bde

9 years agoMove launcher icons to mipmap
Alan Newberger [Thu, 11 Sep 2014 21:39:22 +0000 (14:39 -0700)]
Move launcher icons to mipmap

Bug: 17457682
Change-Id: I6a626c8547f3eea8a06fc47fc70c1a587767b040

9 years agoam 1bbdb135: am 45f316bc: Establish synchronous camera closing when app utilizes...
Alan Newberger [Thu, 11 Sep 2014 18:00:16 +0000 (18:00 +0000)]
am 1bbdb135: am 45f316bc: Establish synchronous camera closing when app utilizes API1/API2

* commit '1bbdb135f84e0c223bac9ee68e5ef6960e03ae62':
  Establish synchronous camera closing when app utilizes API1/API2

9 years agoam 45f316bc: Establish synchronous camera closing when app utilizes API1/API2
Alan Newberger [Thu, 11 Sep 2014 17:51:52 +0000 (17:51 +0000)]
am 45f316bc: Establish synchronous camera closing when app utilizes API1/API2

* commit '45f316bcecb8713cbb217507981fd657fcdaa274':
  Establish synchronous camera closing when app utilizes API1/API2

9 years agoEstablish synchronous camera closing when app utilizes API1/API2
Alan Newberger [Thu, 11 Sep 2014 17:25:54 +0000 (10:25 -0700)]
Establish synchronous camera closing when app utilizes API1/API2

To ensure API1 and API2 portability implementations coordinate together,
if app uses API2 for any mode, lock both modes into synchronouse camera
closing.

Bug: 17464089
Change-Id: If4cf1eb02053ec9e56b7b8df97c21e012467aa3a

9 years agoam f2382657: (-s ours) am 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT...
Baligh Uddin [Thu, 11 Sep 2014 16:11:33 +0000 (16:11 +0000)]
am f2382657: (-s ours) am 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

* commit 'f238265746c8769bdbba8091d6ae0b30f7ee8697':
  Import translations. DO NOT MERGE

9 years agoam 91225f8b: (-s ours) Merge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Thu, 11 Sep 2014 16:11:24 +0000 (16:11 +0000)]
am 91225f8b: (-s ours) Merge "Import translations. DO NOT MERGE" into lmp-dev

* commit '91225f8b7d51be3f2ca8c187de70e775551b3ce4':
  Import translations. DO NOT MERGE

9 years agoam d3db7916: am e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.
Andy Huibers [Thu, 11 Sep 2014 16:00:34 +0000 (16:00 +0000)]
am d3db7916: am e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.

* commit 'd3db7916c770c33feffa34dc2da486af66ab8a13':
  If we are using CaptureModule for Gcam only, turn off flash.

9 years agoam 11d3405c: am 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal...
Alan Newberger [Thu, 11 Sep 2014 15:59:52 +0000 (15:59 +0000)]
am 11d3405c: am 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub-camera-glacier

* commit '11d3405c96e68888e9d8088f35c77a81e941164c':
  Revert "Delay PhotoModule preview cover removal to address jank"

9 years agoam 73d569d4: am 7351415d: Reset aspect ratio on pause
Alan Newberger [Thu, 11 Sep 2014 15:59:09 +0000 (15:59 +0000)]
am 73d569d4: am 7351415d: Reset aspect ratio on pause

* commit '73d569d4939008528be950f055c571048af6e648':
  Reset aspect ratio on pause

9 years agoam 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Thu, 11 Sep 2014 15:58:23 +0000 (15:58 +0000)]
am 0c5fc1d3: (-s ours) Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

* commit '0c5fc1d311eaa82dff09cee6332140fda21d473e':
  Import translations. DO NOT MERGE

9 years agoam ac1dd2f6: am 87a2300f: Merge "workaround fix" into ub-camera-glacier
Spike Sprague [Thu, 11 Sep 2014 15:58:12 +0000 (15:58 +0000)]
am ac1dd2f6: am 87a2300f: Merge "workaround fix" into ub-camera-glacier

* commit 'ac1dd2f67a60aebbac54b779fa419b4c90e49bf9':
  workaround fix

9 years agoam 3d330a60: am 3096e672: Merge "Delay PhotoModule preview cover removal to address...
Alan Newberger [Thu, 11 Sep 2014 15:58:03 +0000 (15:58 +0000)]
am 3d330a60: am 3096e672: Merge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier

* commit '3d330a601da095e86735d7b58f35d22aa8c4e469':
  Delay PhotoModule preview cover removal to address jank

9 years agoam cdf62f78: am d3ee86b7: Merge "Return to filmstrip when video playback finishes...
Senpo Hu [Thu, 11 Sep 2014 15:57:42 +0000 (15:57 +0000)]
am cdf62f78: am d3ee86b7: Merge "Return to filmstrip when video playback finishes." into ub-camera-glacier

* commit 'cdf62f7876cbf24fd8a645a95d1948e65c33c88b':
  Return to filmstrip when video playback finishes.

9 years agoMerge "Import translations. DO NOT MERGE" into lmp-dev
Baligh Uddin [Thu, 11 Sep 2014 15:49:05 +0000 (15:49 +0000)]
Merge "Import translations. DO NOT MERGE" into lmp-dev

9 years agoMerge "Import translations. DO NOT MERGE" into lmp-sprout-dev
Baligh Uddin [Thu, 11 Sep 2014 15:49:04 +0000 (15:49 +0000)]
Merge "Import translations. DO NOT MERGE" into lmp-sprout-dev

9 years agoMerge "Import translations. DO NOT MERGE" into ub-camera-glacier
Baligh Uddin [Thu, 11 Sep 2014 15:48:57 +0000 (15:48 +0000)]
Merge "Import translations. DO NOT MERGE" into ub-camera-glacier

9 years agoam e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.
Andy Huibers [Thu, 11 Sep 2014 04:37:47 +0000 (04:37 +0000)]
am e6ebf3d7: If we are using CaptureModule for Gcam only, turn off flash.

* commit 'e6ebf3d73bb3f337413bdde437fbb8fde6cee436':
  If we are using CaptureModule for Gcam only, turn off flash.

9 years agoIf we are using CaptureModule for Gcam only, turn off flash.
Andy Huibers [Thu, 11 Sep 2014 04:08:56 +0000 (21:08 -0700)]
If we are using CaptureModule for Gcam only, turn off flash.

Bug: 17460394

Change-Id: I4743e9c31f516d12537b2ceedc9e1fe35fbd8381

9 years agoam 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal to address jank...
Alan Newberger [Thu, 11 Sep 2014 01:37:45 +0000 (01:37 +0000)]
am 0c9af933: Merge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub-camera-glacier

* commit '0c9af933b7227577003f462ddab12a1ca49208fe':
  Revert "Delay PhotoModule preview cover removal to address jank"

9 years agoMerge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub...
Alan Newberger [Thu, 11 Sep 2014 01:26:18 +0000 (01:26 +0000)]
Merge "Revert "Delay PhotoModule preview cover removal to address jank"" into ub-camera-glacier

9 years agoRevert "Delay PhotoModule preview cover removal to address jank"
Alan Newberger [Thu, 11 Sep 2014 01:26:01 +0000 (01:26 +0000)]
Revert "Delay PhotoModule preview cover removal to address jank"

This CL introduced PhotoModule state corruption, multiple picture taking was not possible. Need to deal with stopPreview during picture taking vs module initialization.

Bug: 17451185

This reverts commit 49fb93b5517e12606eb747f0a5d218b4d03df821.

Change-Id: I0a1eec8147ce859d2e83ee7bdd17655b4054f904

9 years agoam 7351415d: Reset aspect ratio on pause
Alan Newberger [Thu, 11 Sep 2014 00:33:48 +0000 (00:33 +0000)]
am 7351415d: Reset aspect ratio on pause

* commit '7351415ddfaf7f563a4a12c9204e6feb20fdf49d':
  Reset aspect ratio on pause

9 years agoReset aspect ratio on pause
Alan Newberger [Wed, 10 Sep 2014 22:03:27 +0000 (15:03 -0700)]
Reset aspect ratio on pause

When resuming the app we do resize things but the old aspect
ratio is cached, thus skipping a reset of the transform matrices
because the app thinks it is already at the correct aspect ratio.
In certain cases (changing orientation when paused) this leads to
layout bugs.

Bug: 17304671
Change-Id: Ia171190b3c76dc05519bdf4d1947d9664d5fb604

9 years agoam 87a2300f: Merge "workaround fix" into ub-camera-glacier
Spike Sprague [Wed, 10 Sep 2014 23:14:50 +0000 (23:14 +0000)]
am 87a2300f: Merge "workaround fix" into ub-camera-glacier

* commit '87a2300ff2b49b8bd6a69815d1e4f3db477fcf4d':
  workaround fix

9 years agoMerge "workaround fix" into ub-camera-glacier
Spike Sprague [Wed, 10 Sep 2014 23:07:48 +0000 (23:07 +0000)]
Merge "workaround fix" into ub-camera-glacier

9 years agoam 3096e672: Merge "Delay PhotoModule preview cover removal to address jank" into...
Alan Newberger [Wed, 10 Sep 2014 22:58:30 +0000 (22:58 +0000)]
am 3096e672: Merge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier

* commit '3096e6729b72a47ee3ed0a68a455bc978036de5c':
  Delay PhotoModule preview cover removal to address jank

9 years agoMerge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 22:53:06 +0000 (22:53 +0000)]
Merge "Delay PhotoModule preview cover removal to address jank" into ub-camera-glacier

9 years agoDelay PhotoModule preview cover removal to address jank
Alan Newberger [Wed, 10 Sep 2014 22:44:01 +0000 (15:44 -0700)]
Delay PhotoModule preview cover removal to address jank

Cover should stay in place at least until startPreview completes.
Since it is async, we should call handlers in a callback.

Bug: 17451185
Change-Id: I220c49b9bb75ad977d92780c6eea0ff126a7dcb8

9 years agoam d3ee86b7: Merge "Return to filmstrip when video playback finishes." into ub-camera...
Senpo Hu [Wed, 10 Sep 2014 22:17:02 +0000 (22:17 +0000)]
am d3ee86b7: Merge "Return to filmstrip when video playback finishes." into ub-camera-glacier

* commit 'd3ee86b7c1f1973119619f8e1b356d9707dd0493':
  Return to filmstrip when video playback finishes.

9 years agoworkaround fix
Spike Sprague [Wed, 10 Sep 2014 18:31:09 +0000 (11:31 -0700)]
workaround fix

change View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN to View.SYSTEM_UI_FLAG_FULLSCREEN

on L, with View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN the entire camera app window is shifted down by the height of the status bar.

with View.SYSTEM_UI_FLAG_FULLSCREEN thw window lays out correctly.

note: with either flag on KitKat the window lays out correctly.

bug: 17457492

Change-Id: I6534fcedaafbbb525967289db7fb759ba50fca42

9 years agoMerge "Return to filmstrip when video playback finishes." into ub-camera-glacier
Senpo Hu [Wed, 10 Sep 2014 22:11:15 +0000 (22:11 +0000)]
Merge "Return to filmstrip when video playback finishes." into ub-camera-glacier

9 years agoReturn to filmstrip when video playback finishes.
Senpo Hu [Wed, 10 Sep 2014 21:43:16 +0000 (14:43 -0700)]
Return to filmstrip when video playback finishes.

Bug: 17091348
Change-Id: I9703d014029bf29431b099b129b1ed8bce0ffa03

9 years agoam dcf60eea: am 5675b8af: Fix the upside-down orienation bug in CaptureModule.
Senpo Hu [Wed, 10 Sep 2014 21:51:56 +0000 (21:51 +0000)]
am dcf60eea: am 5675b8af: Fix the upside-down orienation bug in CaptureModule.

* commit 'dcf60eeab39218adc901a3ba3a736a0f7ccdc05e':
  Fix the upside-down orienation bug in CaptureModule.

9 years agoam 5675b8af: Fix the upside-down orienation bug in CaptureModule.
Senpo Hu [Wed, 10 Sep 2014 21:43:30 +0000 (21:43 +0000)]
am 5675b8af: Fix the upside-down orienation bug in CaptureModule.

* commit '5675b8af3fddca8d73d0ce0c8aa2f2a38592f556':
  Fix the upside-down orienation bug in CaptureModule.

9 years agoam 45090bab: am d79b38d6: Merge "Remove jank on camera options switching" into ub...
Alan Newberger [Wed, 10 Sep 2014 21:26:50 +0000 (21:26 +0000)]
am 45090bab: am d79b38d6: Merge "Remove jank on camera options switching" into ub-camera-glacier

* commit '45090babe6f614243a179bc7712e75dbf4666fb5':
  Remove jank on camera options switching

9 years agoam d7a4c3e2: am 9cefdd49: Changed double to float. viewFinder -> viewfinder.
Jiawen Chen [Wed, 10 Sep 2014 21:21:53 +0000 (21:21 +0000)]
am d7a4c3e2: am 9cefdd49: Changed double to float. viewFinder -> viewfinder.

* commit 'd7a4c3e265889c010cdf99170c51701019fb64f0':
  Changed double to float. viewFinder -> viewfinder.

9 years agoam d79b38d6: Merge "Remove jank on camera options switching" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 21:21:08 +0000 (21:21 +0000)]
am d79b38d6: Merge "Remove jank on camera options switching" into ub-camera-glacier

* commit 'd79b38d669e9e61a954b02f3aca63810476f6fc5':
  Remove jank on camera options switching

9 years agoFix the upside-down orienation bug in CaptureModule.
Senpo Hu [Wed, 10 Sep 2014 21:15:00 +0000 (14:15 -0700)]
Fix the upside-down orienation bug in CaptureModule.

Bug: 17369697
Change-Id: I5beb0ec45f2dbf372dda88ffd8a92b1632b3ab90

9 years agoMerge "Remove jank on camera options switching" into ub-camera-glacier
Alan Newberger [Wed, 10 Sep 2014 21:13:54 +0000 (21:13 +0000)]
Merge "Remove jank on camera options switching" into ub-camera-glacier

9 years agoam 9cefdd49: Changed double to float. viewFinder -> viewfinder.
Jiawen Chen [Wed, 10 Sep 2014 21:10:45 +0000 (21:10 +0000)]
am 9cefdd49: Changed double to float. viewFinder -> viewfinder.

* commit '9cefdd495332719d987ffb942742ec602793d8d4':
  Changed double to float. viewFinder -> viewfinder.

9 years agoam 0a156cf6: am ffc395d6: Reinitialize shutter button in Camera mode upon preview...
Alan Newberger [Wed, 10 Sep 2014 20:43:07 +0000 (20:43 +0000)]
am 0a156cf6: am ffc395d6: Reinitialize shutter button in Camera mode upon preview start

* commit '0a156cf6c8543433e1188da2873241bdb1869c11':
  Reinitialize shutter button in Camera mode upon preview start

9 years agoChanged double to float. viewFinder -> viewfinder.
Jiawen Chen [Tue, 9 Sep 2014 21:14:39 +0000 (14:14 -0700)]
Changed double to float. viewFinder -> viewfinder.

Change-Id: I5f10a5e8dae40f56457b863d5e8c703e7bf68e49

9 years agoam ffc395d6: Reinitialize shutter button in Camera mode upon preview start
Alan Newberger [Wed, 10 Sep 2014 20:32:05 +0000 (20:32 +0000)]
am ffc395d6: Reinitialize shutter button in Camera mode upon preview start

* commit 'ffc395d6e7eaafcdcd283e183188de16aa14aa4c':
  Reinitialize shutter button in Camera mode upon preview start

9 years agoReinitialize shutter button in Camera mode upon preview start
Alan Newberger [Wed, 10 Sep 2014 20:07:18 +0000 (13:07 -0700)]
Reinitialize shutter button in Camera mode upon preview start

VideoModule already does this here, and by adding to PhotoModule we
address a bug where pausing when capturing leaves the button
disabled on resume.

Bug: 17426670
Change-Id: I8333b52a72c0da8b58070d689406975332ae632e

9 years agoam 2acdb01d: am 5c4bd6b5: Reduce logging for unknown camera scope
Alan Newberger [Wed, 10 Sep 2014 18:45:07 +0000 (18:45 +0000)]
am 2acdb01d: am 5c4bd6b5: Reduce logging for unknown camera scope

* commit '2acdb01dfb3ce662220f801fb9733cbdca4d6233':
  Reduce logging for unknown camera scope

9 years agoam 5c4bd6b5: Reduce logging for unknown camera scope
Alan Newberger [Wed, 10 Sep 2014 18:32:48 +0000 (18:32 +0000)]
am 5c4bd6b5: Reduce logging for unknown camera scope

* commit '5c4bd6b5348a3464783270ea0bb10d4968d3b0cb':
  Reduce logging for unknown camera scope

9 years agoReduce logging for unknown camera scope
Alan Newberger [Wed, 10 Sep 2014 18:22:19 +0000 (11:22 -0700)]
Reduce logging for unknown camera scope

Still log a warning, but remove stack trace logging.

Change-Id: I28e47feb5d2700fd05e7ff4e6faeb1d5a9e38de5

9 years agoam 91c1c555: am a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L,...
Andy Huibers [Wed, 10 Sep 2014 17:16:05 +0000 (17:16 +0000)]
am 91c1c555: am a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera-glacier

* commit '91c1c555ec75e66d35ed57dfe6134b50c46ee525':
  This fixes Bitmap.createBitmap offset bug in L, not sure why.

9 years agoam a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why...
Andy Huibers [Wed, 10 Sep 2014 17:08:50 +0000 (17:08 +0000)]
am a710f371: Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera-glacier

* commit 'a710f371b8e454d37b8b2be50e001b79e37c67f2':
  This fixes Bitmap.createBitmap offset bug in L, not sure why.

9 years agoMerge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera...
Andy Huibers [Wed, 10 Sep 2014 15:55:10 +0000 (15:55 +0000)]
Merge "This fixes Bitmap.createBitmap offset bug in L, not sure why." into ub-camera-glacier

9 years agoam 031bcdbd: am fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API chang...
Qiwen Zhao [Wed, 10 Sep 2014 15:35:24 +0000 (15:35 +0000)]
am 031bcdbd: am fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier

* commit '031bcdbd1ce646d11542165f626f7590bfa85130':
  DO NOT MERGE: Adjust for camera2 API changes

9 years agoam fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API changes" into...
Qiwen Zhao [Wed, 10 Sep 2014 15:29:28 +0000 (15:29 +0000)]
am fd97c6da: (-s ours) Merge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier

* commit 'fd97c6da954f3e3e6f8547f6f7363cddba6c1b9a':
  DO NOT MERGE: Adjust for camera2 API changes

9 years agoMerge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier
Qiwen Zhao [Wed, 10 Sep 2014 15:20:46 +0000 (15:20 +0000)]
Merge "DO NOT MERGE: Adjust for camera2 API changes" into ub-camera-glacier

9 years agoam aefc884c: am 42a5ad5a: Merge "Granting read permission in the result intent for...
Nicolas Prevot [Wed, 10 Sep 2014 09:56:23 +0000 (09:56 +0000)]
am aefc884c: am 42a5ad5a: Merge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub-camera-glacier

* commit 'aefc884cf5bd12b8caa0a657c33072010cd3234c':
  Granting read permission in the result intent for VIDEO_CAPTURE.

9 years agoam 42a5ad5a: Merge "Granting read permission in the result intent for VIDEO_CAPTURE...
Nicolas Prevot [Wed, 10 Sep 2014 09:50:44 +0000 (09:50 +0000)]
am 42a5ad5a: Merge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub-camera-glacier

* commit '42a5ad5a9c7e660854fd0552b81e025c16db9f05':
  Granting read permission in the result intent for VIDEO_CAPTURE.

9 years agoMerge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub...
Nicolas Prevot [Wed, 10 Sep 2014 09:42:35 +0000 (09:42 +0000)]
Merge "Granting read permission in the result intent for VIDEO_CAPTURE." into ub-camera-glacier

9 years agoam 458590b6: am 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570f...
Andy Huibers [Wed, 10 Sep 2014 07:12:07 +0000 (07:12 +0000)]
am 458590b6: am 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

* commit '458590b60a75ea60a6d30d7713b5d5e6e08302e1':
  Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

9 years agoam 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.
Andy Huibers [Wed, 10 Sep 2014 06:57:12 +0000 (06:57 +0000)]
am 5e3bf4cc: Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

* commit '5e3bf4cc84a186c5e89dfa692f3af95007751877':
  Remove toast. This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

9 years agoRemove jank on camera options switching
Alan Newberger [Wed, 10 Sep 2014 01:47:37 +0000 (18:47 -0700)]
Remove jank on camera options switching

There are two main causes of jank on encountered on options switching:

1. When requesting camera in requestCamera, a portability refactor
introduced a regression where we blocked in the main thread to close
the camera. This main thread blockage is unacceptable as it caused a
preview freeze in addition to the freeze we were trying to create during
the switch, leading to a two-frame preview freeze.

2. The mode options animations which delay the button state transition,
also resulted in preview stutters. Unsure of cause but reverting first
and will assess fixes and reintroduce.

Bug: 17414652
Change-Id: Ib72e331f1bbb5d3b608d8bdc5656c2ff2836ed42

9 years agoRemove toast.
Andy Huibers [Wed, 10 Sep 2014 01:45:28 +0000 (18:45 -0700)]
Remove toast.
This reverts commit 779414e8bfe23d66de310570ff2314654e45ec9f.

Change-Id: Idf04e0bbb69822792327fd17634a4f95f7eb2092

9 years agoam c4f2f4d9: am b954b3e8: Merge "Always match camera orientation with device orientat...
Senpo Hu [Wed, 10 Sep 2014 00:33:17 +0000 (00:33 +0000)]
am c4f2f4d9: am b954b3e8: Merge "Always match camera orientation with device orientation regardless portrait lock." into ub-camera-glacier

* commit 'c4f2f4d922530270ba0b586320bb5228e706e04f':
  Always match camera orientation with device orientation regardless portrait lock.

9 years agoam 7a3bdb23: am 65c00136: Set video quality pref default values at startup.
Senpo Hu [Wed, 10 Sep 2014 00:29:05 +0000 (00:29 +0000)]
am 7a3bdb23: am 65c00136: Set video quality pref default values at startup.

* commit '7a3bdb2341c88dd6d1aac86ea8685ff4fa5ccbc9':
  Set video quality pref default values at startup.

9 years agoam b954b3e8: Merge "Always match camera orientation with device orientation regardles...
Senpo Hu [Wed, 10 Sep 2014 00:27:59 +0000 (00:27 +0000)]
am b954b3e8: Merge "Always match camera orientation with device orientation regardless portrait lock." into ub-camera-glacier

* commit 'b954b3e8b9fff8adf82808bd6cac1f9a7ac9505a':
  Always match camera orientation with device orientation regardless portrait lock.

9 years agoMerge "Always match camera orientation with device orientation regardless portrait...
Senpo Hu [Wed, 10 Sep 2014 00:22:10 +0000 (00:22 +0000)]
Merge "Always match camera orientation with device orientation regardless portrait lock." into ub-camera-glacier

9 years agoam 65c00136: Set video quality pref default values at startup.
Senpo Hu [Wed, 10 Sep 2014 00:21:40 +0000 (00:21 +0000)]
am 65c00136: Set video quality pref default values at startup.

* commit '65c00136cde07e050d05e3da61876199df90dd18':
  Set video quality pref default values at startup.

9 years agoam 420c2c42: Merge "Adjust for camera2 API changes" into lmp-dev
Eino-Ville Talvala [Wed, 10 Sep 2014 00:16:22 +0000 (00:16 +0000)]
am 420c2c42: Merge "Adjust for camera2 API changes" into lmp-dev

* commit '420c2c42f42c1cf9b123a773479d476cede38818':
  Adjust for camera2 API changes

9 years agoSet video quality pref default values at startup.
Senpo Hu [Tue, 9 Sep 2014 20:51:25 +0000 (13:51 -0700)]
Set video quality pref default values at startup.

The problem of the old approach is the default values never got set
until switching on video module.

The caveat of the this CL is that the default value tweak is only applied
for Shamu. Rather than basing on device model string, detecting
CamcorderProfile capability is a better way to get this job done. However,
|CamcorderProfile.hasProfile| needs camera id info so I'd argue this CL
is good enough for the Shamu/L release.

Bug: 17060480
Change-Id: Ia53ff6aecad44fe7a32257fa1415163f167c09bf

9 years agoAlways match camera orientation with device orientation regardless
Senpo Hu [Mon, 8 Sep 2014 08:07:27 +0000 (01:07 -0700)]
Always match camera orientation with device orientation regardless
portrait lock.

Verified that this CL fixes the orientation issue for portrait/landscape
photos taken in PhotoModule with all configuration combinations such as
Camera API1/API2 devices, K/L devices, front/back camera.

Bug: 17360176
Change-Id: If84244726cf7e2ade470c231b8ac16e9b80366fe

9 years agoMerge "Adjust for camera2 API changes" into lmp-dev
Eino-Ville Talvala [Tue, 9 Sep 2014 22:21:07 +0000 (22:21 +0000)]
Merge "Adjust for camera2 API changes" into lmp-dev

9 years agoThis fixes Bitmap.createBitmap offset bug in L, not sure why.
Andy Huibers [Tue, 9 Sep 2014 19:52:29 +0000 (12:52 -0700)]
This fixes Bitmap.createBitmap offset bug in L, not sure why.

Bug: 17145703
Change-Id: I18a673a5cac4400a2d6e80a851b1fb12381dc995

9 years agoGranting read permission in the result intent for VIDEO_CAPTURE.
Nicolas Prevot [Tue, 9 Sep 2014 19:35:56 +0000 (20:35 +0100)]
Granting read permission in the result intent for VIDEO_CAPTURE.

BUG:17437266
Change-Id: I84d1a69a3d314a05a7e3b5c949c896700426644e

9 years agoam b8555b66: am 767a1186: Merge "back to bigger HDR+ icons" into ub-camera-glacier
Spike Sprague [Tue, 9 Sep 2014 18:54:19 +0000 (18:54 +0000)]
am b8555b66: am 767a1186: Merge "back to bigger HDR+ icons" into ub-camera-glacier

* commit 'b8555b66ca0c4571b0a4434321950dc0a6a36505':
  back to bigger HDR+ icons